14376078638

Committed 10 Apr 2025 08:39AM UTC coverage: 56.857%. First build

Build # 14376078638

Build Type

Pull #5515

github

Committed by

web-flow

Commit Message

Merge ea220ae51 into 0f5ecd80e

Pull Request Pull Request #5515: Don't return errors when getting properties

Run Details

27 of 49 new or added lines in 22 files covered. (55.1%)

18305 of 32195 relevant lines covered (56.86%)

37.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/internal/providers/github/webhook/handlers_releases.go

// SPDX-FileCopyrightText: Copyright 2024 The Minder Authors
// SPDX-License-Identifier: Apache-2.0

package webhook

import (
        "context"
        "encoding/json"
        "errors"
        "fmt"

        "github.com/mindersec/minder/internal/db"
        entityMessage "github.com/mindersec/minder/internal/entities/handlers/message"
        ghprop "github.com/mindersec/minder/internal/providers/github/properties"
        pb "github.com/mindersec/minder/pkg/api/protobuf/go/minder/v1"
        "github.com/mindersec/minder/pkg/entities/properties"
        "github.com/mindersec/minder/pkg/eventer/constants"
)

type releaseEvent struct {
        Action  *string  `json:"action,omitempty"`
        Release *release `json:"release,omitempty"`
        Repo    *repo    `json:"repository,omitempty"`
}

func (r *releaseEvent) GetAction() string {
        if r.Action != nil {
                return *r.Action
        }
        return ""
}

func (r *releaseEvent) GetRelease() *release {
        return r.Release
}

func (r *releaseEvent) GetRepo() *repo {
        return r.Repo
}

type release struct {
        ID      *int64  `json:"id,omitempty"`
        TagName *string `json:"tag_name,omitempty"`
        Target  *string `json:"target_commitish,omitempty"`
}

func (r *release) GetID() int64 {
        if r.ID != nil {
                return *r.ID
        }
        return 0
}

func (r *release) GetTagName() string {
        if r.TagName != nil {
                return *r.TagName
        }
        return ""
}

func (r *release) GetTarget() string {
        if r.Target != nil {
                return *r.Target
        }
        return ""
}

func processReleaseEvent(
        ctx context.Context,
        payload []byte,
) (*processingResult, error) {
        var event *releaseEvent
        if err := json.Unmarshal(payload, &event); err != nil {
                return nil, fmt.Errorf("failed to unmarshal release event: %w", err)
        }

        if event.GetAction() == "" {
                return nil, errors.New("release event action not found")
        }

        if event.GetRelease() == nil {
                return nil, errors.New("release event release not found")
        }

        if event.GetRepo() == nil {
                return nil, errors.New("release event repository not found")
        }

        if event.GetRelease().GetTagName() == "" {
                return nil, errors.New("release event tag name not found")
        }

        if event.GetRelease().GetTarget() == "" {
                return nil, errors.New("release event target not found")
        }

        return sendReleaseEvent(ctx, event), nil
}

func sendReleaseEvent(
        _ context.Context,
        event *releaseEvent,
) *processingResult {
        lookByProps := properties.NewProperties(map[string]any{
                properties.PropertyUpstreamID: properties.NumericalValueToUpstreamID(event.GetRelease().GetID()),
                ghprop.ReleasePropertyOwner:   event.GetRepo().GetOwner(),
                ghprop.ReleasePropertyRepo:    event.GetRepo().GetName(),
        })

        originatorProps := properties.NewProperties(map[string]any{
                properties.PropertyUpstreamID: properties.NumericalValueToUpstreamID(event.GetRepo().GetID()),
        })

        switch event.GetAction() {
        case "published":
                return &processingResult{
                        topic: constants.TopicQueueOriginatingEntityAdd,
                        wrapper: entityMessage.NewEntityRefreshAndDoMessage().
                                WithEntity(pb.Entity_ENTITY_RELEASE, lookByProps).
                                WithProviderImplementsHint(string(db.ProviderTypeGithub)).
                                WithOriginator(pb.Entity_ENTITY_REPOSITORIES, originatorProps),
                }
        case "unpublished", "deleted":
                return &processingResult{
                        topic: constants.TopicQueueOriginatingEntityDelete,
                        wrapper: entityMessage.NewEntityRefreshAndDoMessage().
                                WithEntity(pb.Entity_ENTITY_RELEASE, lookByProps).
                                WithProviderImplementsHint(string(db.ProviderTypeGithub)).
                                WithOriginator(pb.Entity_ENTITY_REPOSITORIES, originatorProps),
                }
        case "edited":
                return &processingResult{
                        topic: constants.TopicQueueRefreshEntityAndEvaluate,
                        wrapper: entityMessage.NewEntityRefreshAndDoMessage().
                                WithEntity(pb.Entity_ENTITY_RELEASE, lookByProps).
                                WithProviderImplementsHint(string(db.ProviderTypeGithub)).
                                WithOriginator(pb.Entity_ENTITY_REPOSITORIES, originatorProps),
                }
        }
        return nil
}

1	// SPDX-FileCopyrightText: Copyright 2024 The Minder Authors
2	// SPDX-License-Identifier: Apache-2.0
3
4	package webhook
5
6	import (
7	"context"
8	"encoding/json"
9	"errors"
10	"fmt"
11
12	"github.com/mindersec/minder/internal/db"
13	entityMessage "github.com/mindersec/minder/internal/entities/handlers/message"
14	ghprop "github.com/mindersec/minder/internal/providers/github/properties"
15	pb "github.com/mindersec/minder/pkg/api/protobuf/go/minder/v1"
16	"github.com/mindersec/minder/pkg/entities/properties"
17	"github.com/mindersec/minder/pkg/eventer/constants"
18	)
19
20	type releaseEvent struct {
21	Action *string `json:"action,omitempty"`
22	Release *release `json:"release,omitempty"`
23	Repo *repo `json:"repository,omitempty"`
24	}
25
26	func (r *releaseEvent) GetAction() string {	×
27	if r.Action != nil {	×
28	return *r.Action	×
29	}	×
30	return ""	×
31	}
32
33	func (r releaseEvent) GetRelease() release {	×
34	return r.Release	×
35	}	×
36
37	func (r releaseEvent) GetRepo() repo {	×
38	return r.Repo	×
39	}	×
40
41	type release struct {
42	ID *int64 `json:"id,omitempty"`
43	TagName *string `json:"tag_name,omitempty"`
44	Target *string `json:"target_commitish,omitempty"`
45	}
46
47	func (r *release) GetID() int64 {	×
48	if r.ID != nil {	×
49	return *r.ID	×
50	}	×
51	return 0	×
52	}
53
54	func (r *release) GetTagName() string {	×
55	if r.TagName != nil {	×
56	return *r.TagName	×
57	}	×
58	return ""	×
59	}
60
61	func (r *release) GetTarget() string {	×
62	if r.Target != nil {	×
63	return *r.Target	×
64	}	×
65	return ""	×
66	}
67
68	func processReleaseEvent(
69	ctx context.Context,
70	payload []byte,
71	) (*processingResult, error) {	×
72	var event *releaseEvent	×
73	if err := json.Unmarshal(payload, &event); err != nil {	×
74	return nil, fmt.Errorf("failed to unmarshal release event: %w", err)	×
75	}	×
76
77	if event.GetAction() == "" {	×
78	return nil, errors.New("release event action not found")	×
79	}	×
80
81	if event.GetRelease() == nil {	×
82	return nil, errors.New("release event release not found")	×
83	}	×
84
85	if event.GetRepo() == nil {	×
86	return nil, errors.New("release event repository not found")	×
87	}	×
88
89	if event.GetRelease().GetTagName() == "" {	×
90	return nil, errors.New("release event tag name not found")	×
91	}	×
92
93	if event.GetRelease().GetTarget() == "" {	×
94	return nil, errors.New("release event target not found")	×
95	}	×
96
NEW 97	return sendReleaseEvent(ctx, event), nil	×
98	}
99
100	func sendReleaseEvent(
101	_ context.Context,
102	event *releaseEvent,
NEW 103	) *processingResult {	×
NEW 104	lookByProps := properties.NewProperties(map[string]any{	×
105	properties.PropertyUpstreamID: properties.NumericalValueToUpstreamID(event.GetRelease().GetID()),	×
106	ghprop.ReleasePropertyOwner: event.GetRepo().GetOwner(),	×
107	ghprop.ReleasePropertyRepo: event.GetRepo().GetName(),	×
108	})	×
109		×
NEW 110	originatorProps := properties.NewProperties(map[string]any{	×
111	properties.PropertyUpstreamID: properties.NumericalValueToUpstreamID(event.GetRepo().GetID()),	×
112	})	×
113		×
114	switch event.GetAction() {	×
115	case "published":	×
116	return &processingResult{	×
117	topic: constants.TopicQueueOriginatingEntityAdd,	×
118	wrapper: entityMessage.NewEntityRefreshAndDoMessage().	×
119	WithEntity(pb.Entity_ENTITY_RELEASE, lookByProps).	×
120	WithProviderImplementsHint(string(db.ProviderTypeGithub)).	×
121	WithOriginator(pb.Entity_ENTITY_REPOSITORIES, originatorProps),	×
NEW 122	}	×
123	case "unpublished", "deleted":	×
124	return &processingResult{	×
125	topic: constants.TopicQueueOriginatingEntityDelete,	×
126	wrapper: entityMessage.NewEntityRefreshAndDoMessage().	×
127	WithEntity(pb.Entity_ENTITY_RELEASE, lookByProps).	×
128	WithProviderImplementsHint(string(db.ProviderTypeGithub)).	×
129	WithOriginator(pb.Entity_ENTITY_REPOSITORIES, originatorProps),	×
NEW 130	}	×
131	case "edited":	×
132	return &processingResult{	×
133	topic: constants.TopicQueueRefreshEntityAndEvaluate,	×
134	wrapper: entityMessage.NewEntityRefreshAndDoMessage().	×
135	WithEntity(pb.Entity_ENTITY_RELEASE, lookByProps).	×
136	WithProviderImplementsHint(string(db.ProviderTypeGithub)).	×
137	WithOriginator(pb.Entity_ENTITY_REPOSITORIES, originatorProps),	×
NEW 138	}	×
139	}
NEW 140	return nil	×
141	}

mindersec / minder / 14376078638

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous