14361027675

Committed 09 Apr 2025 03:26PM UTC coverage: 87.167% (+0.07%) from 87.094%

Build # 14361027675

Build Type

Pull #2522

github

Committed by

web-flow

Commit Message

Merge 0f83cdc8b into a6c9136f9

Pull Request Pull Request #2522: fix(subdivision): Remove enough texture check and don't update if subdividing

Run Details

2796 of 3737 branches covered (74.82%)

Branch coverage included in aggregate %.

8 of 12 new or added lines in 3 files covered. (66.67%)

75 existing lines in 2 files now uncovered.

25766 of 29030 relevant lines covered (88.76%)

1115.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

63.52

/packages/Main/src/Process/LayeredMaterialNodeProcessing.js

import { chooseNextLevelToFetch } from 'Layer/LayerUpdateStrategy';
import LayerUpdateState from 'Layer/LayerUpdateState';
import handlingError from 'Process/handlerNodeError';

function materialCommandQueuePriorityFunction(material) {
    // We know that 'node' is visible because commands can only be
    // issued for visible nodes.
    // TODO: need priorization of displayed nodes
    // Then prefer displayed node over non-displayed one
    return material.visible ? 100 : 10;
}

function refinementCommandCancellationFn(cmd) {
    if (!cmd.requester.parent || !cmd.requester.material) {
        return true;
    }
    // Cancel the command if the tile already has a better texture.
    // This is only needed for elevation layers, because we may have several
    // concurrent layers but we can only use one texture.
    if (cmd.layer.isElevationLayer && cmd.requester.material.getElevationLayer() &&
        cmd.targetLevel <= cmd.requester.material.getElevationLayer().level) {
        return true;
    }

    // Cancel the command if the layer was removed between command scheduling and command execution
    if (!cmd.requester.layerUpdateState[cmd.layer.id]
        || !cmd.layer.source._featuresCaches[cmd.layer.crs]) {
        return true;
    }

    return !cmd.requester.material.visible;
}

function buildCommand(view, layer, extentsSource, extentsDestination, requester) {
    return {
        view,
        layer,
        extentsSource,
        extentsDestination,
        requester,
        priority: materialCommandQueuePriorityFunction(requester.material),
        earlyDropFunction: refinementCommandCancellationFn,
        partialLoading: true,
    };
}

function computePitchs(textures, extentsDestination) {
    return extentsDestination
        .map((ext, i) => (ext.offsetToParent(textures[i].extent)));
}

export function updateLayeredMaterialNodeImagery(context, layer, node, parent) {
    if (node.pendingSubdivision) {
        return;
    }
    const material = node.material;
    if (!parent || !material) {
        return;
    }
    const extentsDestination = node.getExtentsByProjection(layer.crs);

    const zoom = extentsDestination[0].zoom;
    if (zoom > layer.zoom.max || zoom < layer.zoom.min) {
        return;
    }

    let nodeLayer = material.getLayer(layer.id);

    // Initialisation
    if (node.layerUpdateState[layer.id] === undefined) {
        node.layerUpdateState[layer.id] = new LayerUpdateState();

        if (!layer.source.extentInsideLimit(node.extent, zoom)) {
            // we also need to check that tile's parent doesn't have a texture for this layer,
            // because even if this tile is outside of the layer, it could inherit it's
            // parent texture
            if (!layer.noTextureParentOutsideLimit &&
                parent.material &&
                parent.material.getLayer &&
                parent.material.getLayer(layer.id)) {
                // ok, we're going to inherit our parent's texture
            } else {
                node.layerUpdateState[layer.id].noMoreUpdatePossible();
                return;
            }
        }

        if (!nodeLayer) {
            // Create new raster node
            nodeLayer = layer.setupRasterNode(node);

            // Init the node by parent
            const parentLayer = parent.material?.getLayer(layer.id);
            nodeLayer.initFromParent(parentLayer, extentsDestination);
        }

        // Proposed new process, two separate processes:
        //      * FIRST PASS: initNodeXXXFromParent and get out of the function
        //      * SECOND PASS: Fetch best texture

        // The two-step allows you to filter out unnecessary requests
        // Indeed in the second pass, their state (not visible or not displayed) can block them to fetch
        if (nodeLayer.level >= layer.source.zoom.min) {
            context.view.notifyChange(node, false);
            return;
        }
    }

    // Node is hidden, no need to update it
    if (!material.visible) {
        return;
    }

    // An update is pending / or impossible -> abort
    if (!layer.visible || !node.layerUpdateState[layer.id].canTryUpdate()) {
        return;
    }

    if (nodeLayer.level >= extentsDestination[0].zoom) {
        // default decision method
        node.layerUpdateState[layer.id].noMoreUpdatePossible();
        return;
    }

    // is fetching data from this layer disabled?
    if (layer.frozen) {
        return;
    }

    const failureParams = node.layerUpdateState[layer.id].failureParams;
    const destinationLevel = extentsDestination[0].zoom || node.level;
    const targetLevel = chooseNextLevelToFetch(layer.updateStrategy.type, node, destinationLevel, nodeLayer.level, layer, failureParams);

    if ((!layer.source.isVectorSource && targetLevel <= nodeLayer.level) || targetLevel > destinationLevel) {
        if (failureParams.lowestLevelError != Infinity) {
            // this is the highest level found in case of error.
            node.layerUpdateState[layer.id].noMoreUpdatePossible();
        }
        return;
    } else if (!layer.source.extentInsideLimit(node.extent, targetLevel)) {
        node.layerUpdateState[layer.id].noData({ targetLevel });
        context.view.notifyChange(node, false);
        return;
    }

    const extentsSource = extentsDestination.map(e => e.tiledExtentParent(targetLevel));
    node.layerUpdateState[layer.id].newTry();
    const command = buildCommand(context.view, layer, extentsSource, extentsDestination, node);

    return context.scheduler.execute(command).then(
        (results) => {
            // Does nothing if the layer has been removed while command was being or waiting to be executed
            if (!node.layerUpdateState[layer.id]) {
                return;
            }
            const textures = results.map((texture, index) => (texture != null ? texture :
                { isTexture: false, extent: extentsDestination[index] }));
            // TODO: Handle error : result is undefined in provider. throw error
            const pitchs = computePitchs(textures, extentsDestination);
            nodeLayer.setTextures(textures, pitchs);
            node.layerUpdateState[layer.id].success();
        },
        err => handlingError(err, node, layer, targetLevel, context.view));
}

export function updateLayeredMaterialNodeElevation(context, layer, node, parent) {
    if (node.pendingSubdivision) {
        return;
    }
    const material = node.material;
    if (!parent || !material) {
        return;
    }

    // TODO: we need either
    //  - compound or exclusive layers
    //  - support for multiple elevation layers

    // Elevation is currently handled differently from color layers.
    // This is caused by a LayeredMaterial limitation: only 1 elevation texture
    // can be used (where a tile can have N textures x M layers)
    const extentsDestination = node.getExtentsByProjection(layer.crs);
    const zoom = extentsDestination[0].zoom;
    if (zoom > layer.zoom.max || zoom < layer.zoom.min) {
        return;
    }
    // Init elevation layer, and inherit from parent if possible
    let nodeLayer = material.getElevationLayer();
    if (!nodeLayer) {
        nodeLayer = layer.setupRasterNode(node);
    }

    if (node.layerUpdateState[layer.id] === undefined) {
        node.layerUpdateState[layer.id] = new LayerUpdateState();

        const parentLayer = parent.material?.getLayer(layer.id);
        nodeLayer.initFromParent(parentLayer, extentsDestination);

        if (nodeLayer.level >= layer.source.zoom.min) {
            context.view.notifyChange(node, false);
            return;
        }
    }

    // Possible conditions to *not* update the elevation texture
    if (layer.frozen ||
            !material.visible ||
            !node.layerUpdateState[layer.id].canTryUpdate()) {
        return;
    }

    const failureParams = node.layerUpdateState[layer.id].failureParams;
    const targetLevel = chooseNextLevelToFetch(layer.updateStrategy.type, node, extentsDestination[0].zoom, nodeLayer.level, layer, failureParams);

    if (targetLevel <= nodeLayer.level || targetLevel > extentsDestination[0].zoom) {
        node.layerUpdateState[layer.id].noMoreUpdatePossible();
        return;
    } else if (!layer.source.extentInsideLimit(node.extent, targetLevel)) {
        node.layerUpdateState[layer.id].noData({ targetLevel });
        context.view.notifyChange(node, false);
        return;
    }

    const extentsSource = extentsDestination.map(e => e.tiledExtentParent(targetLevel));
    node.layerUpdateState[layer.id].newTry();
    const command = buildCommand(context.view, layer, extentsSource, extentsDestination, node);

    return context.scheduler.execute(command).then(
        (results) => {
            // Does nothing if the layer has been removed while command was being or waiting to be executed
            if (!node.layerUpdateState[layer.id]) {
                return;
            }

            // Do not apply the new texture if its level is < than the current
            // one.  This is only needed for elevation layers, because we may
            // have several concurrent layers but we can only use one texture.
            if (targetLevel <= nodeLayer.level) {
                node.layerUpdateState[layer.id].noMoreUpdatePossible();
                return;
            }
            const pitchs = computePitchs(results, extentsDestination);
            nodeLayer.setTextures(results, pitchs);
            node.layerUpdateState[layer.id].success();
        },
        err => handlingError(err, node, layer, targetLevel, context.view));
}

export function removeLayeredMaterialNodeLayer(layerId) {
    /**
     * @param {TileMesh} node - The node to udpate.
     */
    return function removeLayeredMaterialNodeLayer(node) {
        if (node.material?.removeLayer) {
            if (node.material.elevationLayerIds.indexOf(layerId) > -1) {
                node.setBBoxZ({ min: 0, max: 0 });
            }
            node.material.removeLayer(layerId);
        }
        if (node.layerUpdateState && node.layerUpdateState[layerId]) {
            delete node.layerUpdateState[layerId];
        }
    };
}

1	import { chooseNextLevelToFetch } from 'Layer/LayerUpdateStrategy';	1✔
2	import LayerUpdateState from 'Layer/LayerUpdateState';	1✔
3	import handlingError from 'Process/handlerNodeError';	1✔
4		1✔
5	function materialCommandQueuePriorityFunction(material) {	9✔
6	// We know that 'node' is visible because commands can only be	9✔
7	// issued for visible nodes.	9✔
8	// TODO: need priorization of displayed nodes	9✔
9	// Then prefer displayed node over non-displayed one	9✔
10	return material.visible ? 100 : 10;	9!
11	}	9✔
12		1✔
13	function refinementCommandCancellationFn(cmd) {	1✔
14	if (!cmd.requester.parent \|\| !cmd.requester.material) {	1!
15	return true;	×
16	}	×
17	// Cancel the command if the tile already has a better texture.	1✔
18	// This is only needed for elevation layers, because we may have several	1✔
19	// concurrent layers but we can only use one texture.	1✔
20	if (cmd.layer.isElevationLayer && cmd.requester.material.getElevationLayer() &&	1!
21	cmd.targetLevel <= cmd.requester.material.getElevationLayer().level) {	1!
22	return true;	×
23	}	×
24		1✔
25	// Cancel the command if the layer was removed between command scheduling and command execution	1✔
26	if (!cmd.requester.layerUpdateState[cmd.layer.id]	1✔
27	\|\| !cmd.layer.source._featuresCaches[cmd.layer.crs]) {	1!
28	return true;	×
29	}	×
30		1✔
31	return !cmd.requester.material.visible;	1✔
32	}	1✔
33		1✔
34	function buildCommand(view, layer, extentsSource, extentsDestination, requester) {	9✔
35	return {	9✔
36	view,	9✔
37	layer,	9✔
38	extentsSource,	9✔
39	extentsDestination,	9✔
40	requester,	9✔
41	priority: materialCommandQueuePriorityFunction(requester.material),	9✔
42	earlyDropFunction: refinementCommandCancellationFn,	9✔
43	partialLoading: true,	9✔
44	};	9✔
45	}	9✔
46		1✔
47	function computePitchs(textures, extentsDestination) {	1✔
48	return extentsDestination	1✔
49	.map((ext, i) => (ext.offsetToParent(textures[i].extent)));	1✔
50	}	1✔
51		1✔
52	export function updateLayeredMaterialNodeImagery(context, layer, node, parent) {	1✔
53	if (node.pendingSubdivision) {	15!
NEW UNCOV 54	return;	×
NEW 55	}	×
56	const material = node.material;	15✔
57	if (!parent \|\| !material) {	15!
UNCOV 58	return;	×
UNCOV 59	}	×
60	const extentsDestination = node.getExtentsByProjection(layer.crs);	15✔
61		15✔
62	const zoom = extentsDestination[0].zoom;	15✔
63	if (zoom > layer.zoom.max \|\| zoom < layer.zoom.min) {	15!
UNCOV 64	return;	×
UNCOV 65	}	×
66		15✔
67	let nodeLayer = material.getLayer(layer.id);	15✔
68		15✔
69	// Initialisation	15✔
70	if (node.layerUpdateState[layer.id] === undefined) {	15✔
71	node.layerUpdateState[layer.id] = new LayerUpdateState();	9✔
72		9✔
73	if (!layer.source.extentInsideLimit(node.extent, zoom)) {	9!
74	// we also need to check that tile's parent doesn't have a texture for this layer,	×
75	// because even if this tile is outside of the layer, it could inherit it's	×
76	// parent texture	×
77	if (!layer.noTextureParentOutsideLimit &&	×
78	parent.material &&	×
79	parent.material.getLayer &&	×
80	parent.material.getLayer(layer.id)) {	×
81	// ok, we're going to inherit our parent's texture	×
82	} else {	×
83	node.layerUpdateState[layer.id].noMoreUpdatePossible();	×
UNCOV 84	return;	×
UNCOV 85	}	×
UNCOV 86	}	×
87		9✔
88	if (!nodeLayer) {	9✔
89	// Create new raster node	2✔
90	nodeLayer = layer.setupRasterNode(node);	2✔
91		2✔
92	// Init the node by parent	2✔
93	const parentLayer = parent.material?.getLayer(layer.id);	2!
94	nodeLayer.initFromParent(parentLayer, extentsDestination);	2✔
95	}	2✔
96		9✔
97	// Proposed new process, two separate processes:	9✔
98	// * FIRST PASS: initNodeXXXFromParent and get out of the function	9✔
99	// * SECOND PASS: Fetch best texture	9✔
100		9✔
101	// The two-step allows you to filter out unnecessary requests	9✔
102	// Indeed in the second pass, their state (not visible or not displayed) can block them to fetch	9✔
103	if (nodeLayer.level >= layer.source.zoom.min) {	9✔
104	context.view.notifyChange(node, false);	4✔
105	return;	4✔
106	}	4✔
107	}	9✔
108		11✔
109	// Node is hidden, no need to update it	11✔
110	if (!material.visible) {	15!
UNCOV 111	return;	×
UNCOV 112	}	✔
113		11✔
114	// An update is pending / or impossible -> abort	11✔
115	if (!layer.visible \|\| !node.layerUpdateState[layer.id].canTryUpdate()) {	15✔
116	return;	4✔
117	}	4✔
118		7✔
119	if (nodeLayer.level >= extentsDestination[0].zoom) {	15!
120	// default decision method	×
UNCOV 121	node.layerUpdateState[layer.id].noMoreUpdatePossible();	×
UNCOV 122	return;	×
UNCOV 123	}	✔
124		7✔
125	// is fetching data from this layer disabled?	7✔
126	if (layer.frozen) {	15!
UNCOV 127	return;	×
UNCOV 128	}	✔
129		7✔
130	const failureParams = node.layerUpdateState[layer.id].failureParams;	7✔
131	const destinationLevel = extentsDestination[0].zoom \|\| node.level;	15!
132	const targetLevel = chooseNextLevelToFetch(layer.updateStrategy.type, node, destinationLevel, nodeLayer.level, layer, failureParams);	15✔
133		15✔
134	if ((!layer.source.isVectorSource && targetLevel <= nodeLayer.level) \|\| targetLevel > destinationLevel) {	15!
135	if (failureParams.lowestLevelError != Infinity) {	×
136	// this is the highest level found in case of error.	×
UNCOV 137	node.layerUpdateState[layer.id].noMoreUpdatePossible();	×
138	}	×
139	return;	×
140	} else if (!layer.source.extentInsideLimit(node.extent, targetLevel)) {	15!
141	node.layerUpdateState[layer.id].noData({ targetLevel });	×
UNCOV 142	context.view.notifyChange(node, false);	×
UNCOV 143	return;	×
UNCOV 144	}	×
145		7✔
146	const extentsSource = extentsDestination.map(e => e.tiledExtentParent(targetLevel));	7✔
147	node.layerUpdateState[layer.id].newTry();	7✔
148	const command = buildCommand(context.view, layer, extentsSource, extentsDestination, node);	7✔
149		7✔
150	return context.scheduler.execute(command).then(	7✔
151	(results) => {	7✔
152	// Does nothing if the layer has been removed while command was being or waiting to be executed	×
153	if (!node.layerUpdateState[layer.id]) {	×
154	return;	×
155	}	×
156	const textures = results.map((texture, index) => (texture != null ? texture :	×
157	{ isTexture: false, extent: extentsDestination[index] }));	×
158	// TODO: Handle error : result is undefined in provider. throw error	×
UNCOV 159	const pitchs = computePitchs(textures, extentsDestination);	×
UNCOV 160	nodeLayer.setTextures(textures, pitchs);	×
UNCOV 161	node.layerUpdateState[layer.id].success();	×
162	},	7✔
163	err => handlingError(err, node, layer, targetLevel, context.view));	7✔
164	}	7✔
165		1✔
166	export function updateLayeredMaterialNodeElevation(context, layer, node, parent) {	1✔
167	if (node.pendingSubdivision) {	3!
NEW UNCOV 168	return;	×
NEW UNCOV 169	}	×
170	const material = node.material;	3✔
171	if (!parent \|\| !material) {	3!
UNCOV 172	return;	×
UNCOV 173	}	×
174		3✔
175	// TODO: we need either	3✔
176	// - compound or exclusive layers	3✔
177	// - support for multiple elevation layers	3✔
178		3✔
179	// Elevation is currently handled differently from color layers.	3✔
180	// This is caused by a LayeredMaterial limitation: only 1 elevation texture	3✔
181	// can be used (where a tile can have N textures x M layers)	3✔
182	const extentsDestination = node.getExtentsByProjection(layer.crs);	3✔
183	const zoom = extentsDestination[0].zoom;	3✔
184	if (zoom > layer.zoom.max \|\| zoom < layer.zoom.min) {	3!
185	return;	×
UNCOV 186	}	×
187	// Init elevation layer, and inherit from parent if possible	3✔
188	let nodeLayer = material.getElevationLayer();	3✔
189	if (!nodeLayer) {	3!
UNCOV 190	nodeLayer = layer.setupRasterNode(node);	×
UNCOV 191	}	×
192		3✔
193	if (node.layerUpdateState[layer.id] === undefined) {	3✔
194	node.layerUpdateState[layer.id] = new LayerUpdateState();	1✔
195		1✔
196	const parentLayer = parent.material?.getLayer(layer.id);	1!
197	nodeLayer.initFromParent(parentLayer, extentsDestination);	1✔
198		1✔
199	if (nodeLayer.level >= layer.source.zoom.min) {	1!
UNCOV 200	context.view.notifyChange(node, false);	×
UNCOV 201	return;	×
UNCOV 202	}	×
203	}	1✔
204		3✔
205	// Possible conditions to not update the elevation texture	3✔
206	if (layer.frozen \|\|	3✔
207	!material.visible \|\|	3✔
208	!node.layerUpdateState[layer.id].canTryUpdate()) {	3✔
209	return;	1✔
210	}	1✔
211		2✔
212	const failureParams = node.layerUpdateState[layer.id].failureParams;	2✔
213	const targetLevel = chooseNextLevelToFetch(layer.updateStrategy.type, node, extentsDestination[0].zoom, nodeLayer.level, layer, failureParams);	2✔
214		2✔
215	if (targetLevel <= nodeLayer.level \|\| targetLevel > extentsDestination[0].zoom) {	3!
216	node.layerUpdateState[layer.id].noMoreUpdatePossible();	×
UNCOV 217	return;	×
218	} else if (!layer.source.extentInsideLimit(node.extent, targetLevel)) {	3!
UNCOV 219	node.layerUpdateState[layer.id].noData({ targetLevel });	×
UNCOV 220	context.view.notifyChange(node, false);	×
UNCOV 221	return;	×
UNCOV 222	}	×
223		2✔
224	const extentsSource = extentsDestination.map(e => e.tiledExtentParent(targetLevel));	2✔
225	node.layerUpdateState[layer.id].newTry();	2✔
226	const command = buildCommand(context.view, layer, extentsSource, extentsDestination, node);	2✔
227		2✔
228	return context.scheduler.execute(command).then(	2✔
229	(results) => {	2✔
230	// Does nothing if the layer has been removed while command was being or waiting to be executed	1✔
231	if (!node.layerUpdateState[layer.id]) {	1!
UNCOV 232	return;	×
233	}	×
234		1✔
235	// Do not apply the new texture if its level is < than the current	1✔
236	// one. This is only needed for elevation layers, because we may	1✔
237	// have several concurrent layers but we can only use one texture.	1✔
238	if (targetLevel <= nodeLayer.level) {	1!
UNCOV 239	node.layerUpdateState[layer.id].noMoreUpdatePossible();	×
UNCOV 240	return;	×
UNCOV 241	}	×
242	const pitchs = computePitchs(results, extentsDestination);	1✔
243	nodeLayer.setTextures(results, pitchs);	1✔
244	node.layerUpdateState[layer.id].success();	1✔
245	},	2✔
246	err => handlingError(err, node, layer, targetLevel, context.view));	2✔
247	}	2✔
248		1✔
249	export function removeLayeredMaterialNodeLayer(layerId) {	1✔
250	/**	×
251	* @param {TileMesh} node - The node to udpate.	×
252	*/	×
253	return function removeLayeredMaterialNodeLayer(node) {	×
254	if (node.material?.removeLayer) {	×
255	if (node.material.elevationLayerIds.indexOf(layerId) > -1) {	×
256	node.setBBoxZ({ min: 0, max: 0 });	×
257	}	×
258	node.material.removeLayer(layerId);	×
UNCOV 259	}	×
UNCOV 260	if (node.layerUpdateState && node.layerUpdateState[layerId]) {	×
UNCOV 261	delete node.layerUpdateState[layerId];	×
UNCOV 262	}	×
UNCOV 263	};	×
UNCOV 264	}	×

iTowns / itowns / 14361027675

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous