xapi-project / xen-api / 14327912590

Build # 14327912590

Build Type

push

github

Committed by web-flow

Commit Message

xapi_vm_migrate: Avoid duplicate, overly-strict CBT check on VDIs (#6405)

There is already a call to `assert_can_migrate_vdis` present in
`assert_can_migrate`, which checks that none of the VDIs that *are going
to be moved* have CBT enabled. There is no need to additionally check
that none of the VDIs *in general* have CBT enabled.

Some clients, like XenOrchestra, will turn off CBT on VDIs and retry
migration after getting the `VDI_CBT_ENABLED` error on live migration.
Dropping this overly strict check allows not stripping CBT when VDI will
not be moved (when it's on a shared SR).
In addition, during rolling pool upgrades, disabling CBT is not allowed,
hence the live migration operation wouldn't be able to continue.
Avoiding the strict check fixes that as well.

Closes #6400

Run Details

3359 of 4322 relevant lines covered (77.72%)

0.78 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available