14223440618

Committed 02 Apr 2025 02:23PM UTC coverage: 72.385% (-0.3%) from 72.667%

Build # 14223440618

Build Type

Pull #4749

github

Committed by

kersten

Commit Message

🌱 (chore): wrap plugin and util error returns for better context

Pull Request Pull Request #4749: 🌱 (chore): wrap plugin and util error returns for better context

Run Details

27 of 88 new or added lines in 4 files covered. (30.68%)

6 existing lines in 2 files now uncovered.

2304 of 3183 relevant lines covered (72.38%)

16.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/pkg/plugin/util/exec.go

/*
Copyright 2020 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package util

import (
        "fmt"
        "os"
        "os/exec"
        "strings"

        log "github.com/sirupsen/logrus"
)

// RunCmd prints the provided message and command and then executes it binding stdout and stderr
func RunCmd(msg, cmd string, args ...string) error {
        c := exec.Command(cmd, args...) //nolint:gosec
        c.Stdout = os.Stdout
        c.Stderr = os.Stderr
        log.Println(msg + ":\n$ " + strings.Join(c.Args, " "))

        if err := c.Run(); err != nil {
                return fmt.Errorf("error running %q: %w", cmd, err)
        }

        return nil
}

1	/*
2	Copyright 2020 The Kubernetes Authors.
3
4	Licensed under the Apache License, Version 2.0 (the "License");
5	you may not use this file except in compliance with the License.
6	You may obtain a copy of the License at
7
8	http://www.apache.org/licenses/LICENSE-2.0
9
10	Unless required by applicable law or agreed to in writing, software
11	distributed under the License is distributed on an "AS IS" BASIS,
12	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	See the License for the specific language governing permissions and
14	limitations under the License.
15	*/
16
17	package util
18
19	import (
20	"fmt"
21	"os"
22	"os/exec"
23	"strings"
24
25	log "github.com/sirupsen/logrus"
26	)
27
28	// RunCmd prints the provided message and command and then executes it binding stdout and stderr
29	func RunCmd(msg, cmd string, args ...string) error {	1✔
30	c := exec.Command(cmd, args...) //nolint:gosec	1✔
31	c.Stdout = os.Stdout	1✔
32	c.Stderr = os.Stderr	1✔
33	log.Println(msg + ":\n$ " + strings.Join(c.Args, " "))	1✔
34		1✔
35	if err := c.Run(); err != nil {	2✔
36	return fmt.Errorf("error running %q: %w", cmd, err)	1✔
37	}	1✔
38
NEW 39	return nil	×
40	}

kubernetes-sigs / kubebuilder / 14223440618

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous