• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3831

02 Apr 2025 01:14AM UTC coverage: 34.081% (-0.02%) from 34.097%
#3831

push

travis-ci

happyguoxy
test:alter gcda dir

148596 of 599532 branches covered (24.79%)

Branch coverage included in aggregate %.

222550 of 489473 relevant lines covered (45.47%)

1589752.67 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.14
/source/dnode/mgmt/mgmt_vnode/src/vmFile.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http:www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "tjson.h"
18
#include "vmInt.h"
19

20
#define MAX_CONTENT_LEN 2 * 1024 * 1024
21

22
int32_t vmGetAllVnodeListFromHash(SVnodeMgmt *pMgmt, int32_t *numOfVnodes, SVnodeObj ***ppVnodes) {
334✔
23
  (void)taosThreadRwlockRdlock(&pMgmt->hashLock);
334✔
24

25
  int32_t num = 0;
334✔
26
  int32_t size = taosHashGetSize(pMgmt->runngingHash);
334✔
27
  int32_t closedSize = taosHashGetSize(pMgmt->closedHash);
334✔
28
  size += closedSize;
334✔
29
  SVnodeObj **pVnodes = taosMemoryCalloc(size, sizeof(SVnodeObj *));
334!
30
  if (pVnodes == NULL) {
334!
31
    (void)taosThreadRwlockUnlock(&pMgmt->hashLock);
×
32
    return terrno;
×
33
  }
34

35
  void *pIter = taosHashIterate(pMgmt->runngingHash, NULL);
334✔
36
  while (pIter) {
1,285✔
37
    SVnodeObj **ppVnode = pIter;
951✔
38
    SVnodeObj  *pVnode = *ppVnode;
951✔
39
    if (pVnode && num < size) {
1,902!
40
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
951✔
41
      dTrace("vgId:%d,acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
951✔
42
      pVnodes[num++] = (*ppVnode);
951✔
43
      pIter = taosHashIterate(pMgmt->runngingHash, pIter);
951✔
44
    } else {
45
      taosHashCancelIterate(pMgmt->runngingHash, pIter);
×
46
    }
47
  }
48

49
  pIter = taosHashIterate(pMgmt->closedHash, NULL);
334✔
50
  while (pIter) {
334!
51
    SVnodeObj **ppVnode = pIter;
×
52
    SVnodeObj  *pVnode = *ppVnode;
×
53
    if (pVnode && num < size) {
×
54
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
×
55
      dTrace("vgId:%d, acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
×
56
      pVnodes[num++] = (*ppVnode);
×
57
      pIter = taosHashIterate(pMgmt->closedHash, pIter);
×
58
    } else {
59
      taosHashCancelIterate(pMgmt->closedHash, pIter);
×
60
    }
61
  }
62

63
  (void)taosThreadRwlockUnlock(&pMgmt->hashLock);
334✔
64
  *numOfVnodes = num;
334✔
65
  *ppVnodes = pVnodes;
334✔
66

67
  return 0;
334✔
68
}
69

70
int32_t vmGetAllVnodeListFromHashWithCreating(SVnodeMgmt *pMgmt, int32_t *numOfVnodes, SVnodeObj ***ppVnodes) {
212✔
71
  (void)taosThreadRwlockRdlock(&pMgmt->hashLock);
212✔
72

73
  int32_t num = 0;
212✔
74
  int32_t size = taosHashGetSize(pMgmt->runngingHash);
212✔
75
  int32_t creatingSize = taosHashGetSize(pMgmt->creatingHash);
212✔
76
  size += creatingSize;
212✔
77
  SVnodeObj **pVnodes = taosMemoryCalloc(size, sizeof(SVnodeObj *));
212!
78
  if (pVnodes == NULL) {
212!
79
    (void)taosThreadRwlockUnlock(&pMgmt->hashLock);
×
80
    return terrno;
×
81
  }
82

83
  void *pIter = taosHashIterate(pMgmt->runngingHash, NULL);
212✔
84
  while (pIter) {
387✔
85
    SVnodeObj **ppVnode = pIter;
175✔
86
    SVnodeObj  *pVnode = *ppVnode;
175✔
87
    if (pVnode && num < size) {
350!
88
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
175✔
89
      dTrace("vgId:%d,acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
175✔
90
      pVnodes[num++] = (*ppVnode);
175✔
91
      pIter = taosHashIterate(pMgmt->runngingHash, pIter);
175✔
92
    } else {
93
      taosHashCancelIterate(pMgmt->runngingHash, pIter);
×
94
    }
95
  }
96

97
  pIter = taosHashIterate(pMgmt->creatingHash, NULL);
212✔
98
  while (pIter) {
423✔
99
    SVnodeObj **ppVnode = pIter;
211✔
100
    SVnodeObj  *pVnode = *ppVnode;
211✔
101
    if (pVnode && num < size) {
422!
102
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
211✔
103
      dTrace("vgId:%d, acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
211✔
104
      pVnodes[num++] = (*ppVnode);
211✔
105
      pIter = taosHashIterate(pMgmt->creatingHash, pIter);
211✔
106
    } else {
107
      taosHashCancelIterate(pMgmt->creatingHash, pIter);
×
108
    }
109
  }
110
  (void)taosThreadRwlockUnlock(&pMgmt->hashLock);
212✔
111

112
  *numOfVnodes = num;
212✔
113
  *ppVnodes = pVnodes;
212✔
114

115
  return 0;
212✔
116
}
117

118
int32_t vmGetVnodeListFromHash(SVnodeMgmt *pMgmt, int32_t *numOfVnodes, SVnodeObj ***ppVnodes) {
243✔
119
  (void)taosThreadRwlockRdlock(&pMgmt->hashLock);
243✔
120

121
  int32_t     num = 0;
243✔
122
  int32_t     size = taosHashGetSize(pMgmt->runngingHash);
243✔
123
  SVnodeObj **pVnodes = taosMemoryCalloc(size, sizeof(SVnodeObj *));
243!
124
  if (pVnodes == NULL) {
243!
125
    (void)taosThreadRwlockUnlock(&pMgmt->hashLock);
×
126
    return terrno;
×
127
  }
128

129
  void *pIter = taosHashIterate(pMgmt->runngingHash, NULL);
243✔
130
  while (pIter) {
711✔
131
    SVnodeObj **ppVnode = pIter;
468✔
132
    SVnodeObj  *pVnode = *ppVnode;
468✔
133
    if (pVnode && num < size) {
936!
134
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
468✔
135
      dTrace("vgId:%d, acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
468✔
136
      pVnodes[num++] = (*ppVnode);
468✔
137
      pIter = taosHashIterate(pMgmt->runngingHash, pIter);
468✔
138
    } else {
139
      taosHashCancelIterate(pMgmt->runngingHash, pIter);
×
140
    }
141
  }
142

143
  (void)taosThreadRwlockUnlock(&pMgmt->hashLock);
243✔
144
  *numOfVnodes = num;
243✔
145
  *ppVnodes = pVnodes;
243✔
146

147
  return 0;
243✔
148
}
149

150
static int32_t vmDecodeVnodeList(SJson *pJson, SVnodeMgmt *pMgmt, SWrapperCfg **ppCfgs, int32_t *numOfVnodes) {
9✔
151
  int32_t      code = -1;
9✔
152
  SWrapperCfg *pCfgs = NULL;
9✔
153
  *ppCfgs = NULL;
9✔
154

155
  SJson *vnodes = tjsonGetObjectItem(pJson, "vnodes");
9✔
156
  if (vnodes == NULL) return TSDB_CODE_INVALID_JSON_FORMAT;
9!
157

158
  int32_t vnodesNum = cJSON_GetArraySize(vnodes);
9✔
159
  if (vnodesNum > 0) {
9!
160
    pCfgs = taosMemoryCalloc(vnodesNum, sizeof(SWrapperCfg));
9!
161
    if (pCfgs == NULL) return terrno;
9!
162
  }
163

164
  for (int32_t i = 0; i < vnodesNum; ++i) {
42✔
165
    SJson *vnode = tjsonGetArrayItem(vnodes, i);
33✔
166
    if (vnode == NULL) {
33!
167
      code = TSDB_CODE_INVALID_JSON_FORMAT;
×
168
      goto _OVER;
×
169
    }
170

171
    SWrapperCfg *pCfg = &pCfgs[i];
33✔
172
    tjsonGetInt32ValueFromDouble(vnode, "vgId", pCfg->vgId, code);
33✔
173
    if (code != 0) goto _OVER;
33!
174
    tjsonGetInt32ValueFromDouble(vnode, "dropped", pCfg->dropped, code);
33✔
175
    if (code != 0) goto _OVER;
33!
176
    tjsonGetInt32ValueFromDouble(vnode, "vgVersion", pCfg->vgVersion, code);
33✔
177
    if (code != 0) goto _OVER;
33!
178
    tjsonGetInt32ValueFromDouble(vnode, "diskPrimary", pCfg->diskPrimary, code);
33✔
179
    if (code != 0) goto _OVER;
33!
180
    tjsonGetInt32ValueFromDouble(vnode, "toVgId", pCfg->toVgId, code);
33✔
181
    if (code != 0) goto _OVER;
33!
182

183
    snprintf(pCfg->path, sizeof(pCfg->path), "%s%svnode%d", pMgmt->path, TD_DIRSEP, pCfg->vgId);
33✔
184
  }
185

186
  code = 0;
9✔
187
  *ppCfgs = pCfgs;
9✔
188
  *numOfVnodes = vnodesNum;
9✔
189

190
_OVER:
9✔
191
  if (*ppCfgs == NULL) taosMemoryFree(pCfgs);
9!
192
  return code;
9✔
193
}
194

195
int32_t vmGetVnodeListFromFile(SVnodeMgmt *pMgmt, SWrapperCfg **ppCfgs, int32_t *numOfVnodes) {
70✔
196
  int32_t      code = -1;
70✔
197
  TdFilePtr    pFile = NULL;
70✔
198
  char        *pData = NULL;
70✔
199
  SJson       *pJson = NULL;
70✔
200
  char         file[PATH_MAX] = {0};
70✔
201
  SWrapperCfg *pCfgs = NULL;
70✔
202
  snprintf(file, sizeof(file), "%s%svnodes.json", pMgmt->path, TD_DIRSEP);
70✔
203

204
  if (taosStatFile(file, NULL, NULL, NULL) < 0) {
70✔
205
    code = terrno;
61✔
206
    dInfo("vnode file:%s not exist, reason:%s", file, tstrerror(code));
61!
207
    code = 0;
61✔
208
    return code;
61✔
209
  }
210

211
  pFile = taosOpenFile(file, TD_FILE_READ);
9✔
212
  if (pFile == NULL) {
9!
213
    code = terrno;
×
214
    dError("failed to open vnode file:%s since %s", file, tstrerror(code));
×
215
    goto _OVER;
×
216
  }
217

218
  int64_t size = 0;
9✔
219
  code = taosFStatFile(pFile, &size, NULL);
9✔
220
  if (code != 0) {
9!
221
    dError("failed to fstat mnode file:%s since %s", file, tstrerror(code));
×
222
    goto _OVER;
×
223
  }
224

225
  pData = taosMemoryMalloc(size + 1);
9!
226
  if (pData == NULL) {
9!
227
    code = terrno;
×
228
    goto _OVER;
×
229
  }
230

231
  if (taosReadFile(pFile, pData, size) != size) {
9!
232
    code = terrno;
×
233
    dError("failed to read vnode file:%s since %s", file, tstrerror(code));
×
234
    goto _OVER;
×
235
  }
236

237
  pData[size] = '\0';
9✔
238

239
  pJson = tjsonParse(pData);
9✔
240
  if (pJson == NULL) {
9!
241
    code = TSDB_CODE_INVALID_JSON_FORMAT;
×
242
    goto _OVER;
×
243
  }
244

245
  if (vmDecodeVnodeList(pJson, pMgmt, ppCfgs, numOfVnodes) < 0) {
9!
246
    code = TSDB_CODE_INVALID_JSON_FORMAT;
×
247
    goto _OVER;
×
248
  }
249

250
  code = 0;
9✔
251
  dInfo("succceed to read vnode file %s", file);
9!
252

253
_OVER:
×
254
  if (pData != NULL) taosMemoryFree(pData);
9!
255
  if (pJson != NULL) cJSON_Delete(pJson);
9!
256
  if (pFile != NULL) taosCloseFile(&pFile);
9!
257

258
  if (code != 0) {
9!
259
    dError("failed to read vnode file:%s since %s", file, tstrerror(code));
×
260
  }
261
  return code;
9✔
262
}
263

264
static int32_t vmEncodeVnodeList(SJson *pJson, SVnodeObj **ppVnodes, int32_t numOfVnodes) {
334✔
265
  int32_t code = 0;
334✔
266
  SJson  *vnodes = tjsonCreateArray();
334✔
267
  if (vnodes == NULL) {
334!
268
    return terrno;
×
269
  }
270
  if ((code = tjsonAddItemToObject(pJson, "vnodes", vnodes)) < 0) {
334!
271
    tjsonDelete(vnodes);
×
272
    return code;
×
273
  };
274

275
  for (int32_t i = 0; i < numOfVnodes; ++i) {
1,285✔
276
    SVnodeObj *pVnode = ppVnodes[i];
951✔
277
    if (pVnode == NULL) continue;
951!
278

279
    SJson *vnode = tjsonCreateObject();
951✔
280
    if (vnode == NULL) return terrno;
951!
281
    if ((code = tjsonAddDoubleToObject(vnode, "vgId", pVnode->vgId)) < 0) return code;
951!
282
    if ((code = tjsonAddDoubleToObject(vnode, "dropped", pVnode->dropped)) < 0) return code;
951!
283
    if ((code = tjsonAddDoubleToObject(vnode, "vgVersion", pVnode->vgVersion)) < 0) return code;
951!
284
    if ((code = tjsonAddDoubleToObject(vnode, "diskPrimary", pVnode->diskPrimary)) < 0) return code;
951!
285
    if (pVnode->toVgId) {
951!
286
      if ((code = tjsonAddDoubleToObject(vnode, "toVgId", pVnode->toVgId)) < 0) return code;
×
287
    }
288
    if ((code = tjsonAddItemToArray(vnodes, vnode)) < 0) return code;
951!
289
  }
290

291
  return 0;
334✔
292
}
293

294
int32_t vmWriteVnodeListToFile(SVnodeMgmt *pMgmt) {
334✔
295
  int32_t     code = -1;
334✔
296
  char       *buffer = NULL;
334✔
297
  SJson      *pJson = NULL;
334✔
298
  TdFilePtr   pFile = NULL;
334✔
299
  SVnodeObj **ppVnodes = NULL;
334✔
300
  char        file[PATH_MAX] = {0};
334✔
301
  char        realfile[PATH_MAX] = {0};
334✔
302
  int32_t     lino = 0;
334✔
303
  int32_t     ret = -1;
334✔
304

305
  int32_t nBytes = snprintf(file, sizeof(file), "%s%svnodes_tmp.json", pMgmt->path, TD_DIRSEP);
334✔
306
  if (nBytes <= 0 || nBytes >= sizeof(file)) {
334!
307
    return TSDB_CODE_OUT_OF_RANGE;
×
308
  }
309

310
  nBytes = snprintf(realfile, sizeof(realfile), "%s%svnodes.json", pMgmt->path, TD_DIRSEP);
334✔
311
  if (nBytes <= 0 || nBytes >= sizeof(realfile)) {
334!
312
    return TSDB_CODE_OUT_OF_RANGE;
×
313
  }
314

315
  int32_t numOfVnodes = 0;
334✔
316
  TAOS_CHECK_GOTO(vmGetAllVnodeListFromHash(pMgmt, &numOfVnodes, &ppVnodes), &lino, _OVER);
334!
317

318
  // terrno = TSDB_CODE_OUT_OF_MEMORY;
319
  pJson = tjsonCreateObject();
334✔
320
  if (pJson == NULL) {
334!
321
    code = terrno;
×
322
    goto _OVER;
×
323
  }
324
  TAOS_CHECK_GOTO(vmEncodeVnodeList(pJson, ppVnodes, numOfVnodes), &lino, _OVER);
334!
325

326
  buffer = tjsonToString(pJson);
334✔
327
  if (buffer == NULL) {
334!
328
    code = TSDB_CODE_INVALID_JSON_FORMAT;
×
329
    lino = __LINE__;
×
330
    goto _OVER;
×
331
  }
332

333
  code = taosThreadMutexLock(&pMgmt->fileLock);
334✔
334
  if (code != 0) {
334!
335
    lino = __LINE__;
×
336
    goto _OVER;
×
337
  }
338

339
  pFile = taosOpenFile(file, TD_FILE_CREATE | TD_FILE_WRITE | TD_FILE_TRUNC | TD_FILE_WRITE_THROUGH);
334✔
340
  if (pFile == NULL) {
334!
341
    code = terrno;
×
342
    lino = __LINE__;
×
343
    goto _OVER1;
×
344
  }
345

346
  int32_t len = strlen(buffer);
334✔
347
  if (taosWriteFile(pFile, buffer, len) <= 0) {
334!
348
    code = terrno;
×
349
    lino = __LINE__;
×
350
    goto _OVER1;
×
351
  }
352
  if (taosFsyncFile(pFile) < 0) {
334!
353
    code = TAOS_SYSTEM_ERROR(ERRNO);
×
354
    lino = __LINE__;
×
355
    goto _OVER1;
×
356
  }
357

358
  code = taosCloseFile(&pFile);
334✔
359
  if (code != 0) {
334!
360
    code = TAOS_SYSTEM_ERROR(ERRNO);
×
361
    lino = __LINE__;
×
362
    goto _OVER1;
×
363
  }
364
  TAOS_CHECK_GOTO(taosRenameFile(file, realfile), &lino, _OVER1);
334!
365

366
  dInfo("succeed to write vnodes file:%s, vnodes:%d", realfile, numOfVnodes);
334!
367

368
_OVER1:
×
369
  ret = taosThreadMutexUnlock(&pMgmt->fileLock);
334✔
370
  if (ret != 0) {
334!
371
    dError("failed to unlock since %s", tstrerror(ret));
×
372
  }
373

374
_OVER:
334✔
375
  if (pJson != NULL) tjsonDelete(pJson);
334!
376
  if (buffer != NULL) taosMemoryFree(buffer);
334!
377
  if (pFile != NULL) taosCloseFile(&pFile);
334!
378
  if (ppVnodes != NULL) {
334!
379
    for (int32_t i = 0; i < numOfVnodes; ++i) {
1,285✔
380
      SVnodeObj *pVnode = ppVnodes[i];
951✔
381
      if (pVnode != NULL) {
951!
382
        vmReleaseVnode(pMgmt, pVnode);
951✔
383
      }
384
    }
385
    taosMemoryFree(ppVnodes);
334!
386
  }
387

388
  if (code != 0) {
334!
389
    dError("failed to write vnodes file:%s at line:%d since %s, vnodes:%d", realfile, lino, tstrerror(code),
×
390
           numOfVnodes);
391
  }
392
  return code;
334✔
393
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc