#3798

Committed 31 Mar 2025 10:39AM UTC coverage: 9.424% (-20.9%) from 30.372%

Build # #3798

Build Type

push

travis-ci

Committed by

happyguoxy

Commit Message

test:add test cases

Run Details

21549 of 307601 branches covered (7.01%)

Branch coverage included in aggregate %.

36084 of 303967 relevant lines covered (11.87%)

58620.7 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/source/dnode/vnode/src/vnd/vnodeCommit.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "meta.h"
#include "sync.h"
#include "vnd.h"
#include "vnodeInt.h"

extern int32_t tsdbPreCommit(STsdb *pTsdb);
extern int32_t tsdbCommitBegin(STsdb *pTsdb, SCommitInfo *pInfo);
extern int32_t tsdbCommitCommit(STsdb *pTsdb);
extern int32_t tsdbCommitAbort(STsdb *pTsdb);

#define VND_INFO_FNAME_TMP "vnode_tmp.json"

static int vnodeEncodeInfo(const SVnodeInfo *pInfo, char **ppData);
static int vnodeCommitImpl(SCommitInfo *pInfo);

#define WAIT_TIME_MILI_SEC 10  // miliseconds

static int32_t vnodeTryRecycleBufPool(SVnode *pVnode) {
  int32_t code = 0;

  if (pVnode->onRecycle == NULL) {
    if (pVnode->recycleHead == NULL) {
      vDebug("vgId:%d, no recyclable buffer pool", TD_VID(pVnode));
      goto _exit;
    } else {
      vDebug("vgId:%d, buffer pool %p of id %d on recycle queue, try to recycle", TD_VID(pVnode), pVnode->recycleHead,
             pVnode->recycleHead->id);

      pVnode->onRecycle = pVnode->recycleHead;
      if (pVnode->recycleHead == pVnode->recycleTail) {
        pVnode->recycleHead = pVnode->recycleTail = NULL;
      } else {
        pVnode->recycleHead = pVnode->recycleHead->recycleNext;
        pVnode->recycleHead->recyclePrev = NULL;
      }
      pVnode->onRecycle->recycleNext = pVnode->onRecycle->recyclePrev = NULL;
    }
  }

  code = vnodeBufPoolRecycle(pVnode->onRecycle);
  if (code) goto _exit;

_exit:
  if (code) {
    vError("vgId:%d, %s failed since %s", TD_VID(pVnode), __func__, tstrerror(code));
  }
  return code;
}
static int32_t vnodeGetBufPoolToUse(SVnode *pVnode) {
  int32_t code = 0;
  int32_t lino = 0;

  (void)taosThreadMutexLock(&pVnode->mutex);

  int32_t nTry = 0;
  for (;;) {
    ++nTry;

    if (pVnode->freeList) {
      vDebug("vgId:%d, allocate free buffer pool on %d try, pPool:%p id:%d", TD_VID(pVnode), nTry, pVnode->freeList,
             pVnode->freeList->id);

      pVnode->inUse = pVnode->freeList;
      pVnode->inUse->nRef = 1;
      pVnode->freeList = pVnode->inUse->freeNext;
      pVnode->inUse->freeNext = NULL;
      break;
    } else {
      vDebug("vgId:%d, no free buffer pool on %d try, try to recycle...", TD_VID(pVnode), nTry);

      code = vnodeTryRecycleBufPool(pVnode);
      TSDB_CHECK_CODE(code, lino, _exit);

      if (pVnode->freeList == NULL) {
        vDebug("vgId:%d, no free buffer pool on %d try, wait %d ms...", TD_VID(pVnode), nTry, WAIT_TIME_MILI_SEC);

        struct timeval  tv;
        struct timespec ts;
        if (taosGetTimeOfDay(&tv) != 0) {
          continue;
        }
        ts.tv_nsec = tv.tv_usec * 1000 + WAIT_TIME_MILI_SEC * 1000000;
        if (ts.tv_nsec > 999999999l) {
          ts.tv_sec = tv.tv_sec + 1;
          ts.tv_nsec -= 1000000000l;
        } else {
          ts.tv_sec = tv.tv_sec;
        }

        code = taosThreadCondTimedWait(&pVnode->poolNotEmpty, &pVnode->mutex, &ts);
        // ignore timeout error and retry
        if (code == TSDB_CODE_TIMEOUT_ERROR) {
          code = TSDB_CODE_SUCCESS;
        }
        TSDB_CHECK_CODE(code, lino, _exit);
      }
    }
  }

_exit:
  (void)taosThreadMutexUnlock(&pVnode->mutex);
  if (code) {
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
  }
  return code;
}
int vnodeBegin(SVnode *pVnode) {
  int32_t code = 0;
  int32_t lino = 0;

  // alloc buffer pool
  code = vnodeGetBufPoolToUse(pVnode);
  TSDB_CHECK_CODE(code, lino, _exit);

  // begin meta
  code = metaBegin(pVnode->pMeta, META_BEGIN_HEAP_BUFFERPOOL);
  TSDB_CHECK_CODE(code, lino, _exit);

  // begin tsdb
  code = tsdbBegin(pVnode->pTsdb);
  TSDB_CHECK_CODE(code, lino, _exit);

  // begin sma
  if (VND_IS_RSMA(pVnode)) {
    code = smaBegin(pVnode->pSma);
    TSDB_CHECK_CODE(code, lino, _exit);
  }

_exit:
  if (code) {
    terrno = code;
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
  }
  return code;
}

int vnodeShouldCommit(SVnode *pVnode, bool atExit) {
  bool diskAvail = osDataSpaceAvailable();
  bool needCommit = false;

  (void)taosThreadMutexLock(&pVnode->mutex);
  if (pVnode->inUse && diskAvail) {
    needCommit = (pVnode->inUse->size > pVnode->inUse->node.size) ||
                 (atExit && (pVnode->inUse->size > 0 || pVnode->pMeta->changed ||
                             pVnode->state.applied - pVnode->state.committed > 4096));
  }
  vTrace("vgId:%d, should commit:%d, disk available:%d, buffer size:%" PRId64 ", node size:%" PRId64
         ", meta changed:%d"
         ", state:[%" PRId64 ",%" PRId64 "]",
         TD_VID(pVnode), needCommit, diskAvail, pVnode->inUse ? pVnode->inUse->size : 0,
         pVnode->inUse ? pVnode->inUse->node.size : 0, pVnode->pMeta->changed, pVnode->state.applied,
         pVnode->state.committed);
  (void)taosThreadMutexUnlock(&pVnode->mutex);
  return needCommit;
}

int vnodeSaveInfo(const char *dir, const SVnodeInfo *pInfo) {
  int32_t   code = 0;
  int32_t   lino;
  char      fname[TSDB_FILENAME_LEN];
  TdFilePtr pFile = NULL;
  char     *data = NULL;

  snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME_TMP);

  code = vnodeEncodeInfo(pInfo, &data);
  TSDB_CHECK_CODE(code, lino, _exit);

  // save info to a vnode_tmp.json
  pFile = taosOpenFile(fname, TD_FILE_CREATE | TD_FILE_WRITE | TD_FILE_TRUNC | TD_FILE_WRITE_THROUGH);
  if (pFile == NULL) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  if (taosWriteFile(pFile, data, strlen(data)) < 0) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  if (taosFsyncFile(pFile) < 0) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

_exit:
  if (code) {
    vError("vgId:%d %s failed at %s:%d since %s", pInfo->config.vgId, __func__, __FILE__, lino, tstrerror(code));
  } else {
    vInfo("vgId:%d, vnode info is saved, fname:%s replica:%d selfIndex:%d changeVersion:%d", pInfo->config.vgId, fname,
          pInfo->config.syncCfg.replicaNum, pInfo->config.syncCfg.myIndex, pInfo->config.syncCfg.changeVersion);
  }
  if (taosCloseFile(&pFile) != 0) {
    vError("vgId:%d, failed to close file", pInfo->config.vgId);
  }
  taosMemoryFree(data);
  TAOS_RETURN(code);
}

int vnodeCommitInfo(const char *dir) {
  char fname[TSDB_FILENAME_LEN];
  char tfname[TSDB_FILENAME_LEN];

  snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME);
  snprintf(tfname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME_TMP);

  int32_t code = taosRenameFile(tfname, fname);
  if (code < 0) {
    return code;
  }

  vInfo("vnode info is committed, dir:%s", dir);
  return 0;
}

int vnodeLoadInfo(const char *dir, SVnodeInfo *pInfo) {
  int32_t   code = 0;
  int32_t   lino;
  char      fname[TSDB_FILENAME_LEN];
  TdFilePtr pFile = NULL;
  char     *pData = NULL;
  int64_t   size;

  snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME);

  // read info
  pFile = taosOpenFile(fname, TD_FILE_READ);
  if (pFile == NULL) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  code = taosFStatFile(pFile, &size, NULL);
  TSDB_CHECK_CODE(code, lino, _exit);

  pData = taosMemoryMalloc(size + 1);
  if (pData == NULL) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  if (taosReadFile(pFile, pData, size) < 0) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  pData[size] = '\0';

  // decode info
  code = vnodeDecodeInfo(pData, pInfo);
  TSDB_CHECK_CODE(code, lino, _exit);

  pInfo->config.walCfg.committed = pInfo->state.committed;
_exit:
  if (code) {
    if (pFile) {
      vError("vgId:%d %s failed at %s:%d since %s", pInfo->config.vgId, __func__, __FILE__, lino, tstrerror(code));
    }
  }
  taosMemoryFree(pData);
  if (taosCloseFile(&pFile) != 0) {
    vError("vgId:%d, failed to close file", pInfo->config.vgId);
  }
  return code;
}

static int32_t vnodePrepareCommit(SVnode *pVnode, SCommitInfo *pInfo) {
  int32_t code = 0;
  int32_t lino = 0;
  char    dir[TSDB_FILENAME_LEN] = {0};
  int64_t lastCommitted = pInfo->info.state.committed;

  // wait last commit task
  vnodeAWait(&pVnode->commitTask);

  code = syncNodeGetConfig(pVnode->sync, &pVnode->config.syncCfg);
  TSDB_CHECK_CODE(code, lino, _exit);

  pVnode->state.commitTerm = pVnode->state.applyTerm;

  pInfo->info.config = pVnode->config;
  pInfo->info.state.committed = pVnode->state.applied;
  pInfo->info.state.commitTerm = pVnode->state.applyTerm;
  pInfo->info.state.commitID = ++pVnode->state.commitID;
  pInfo->pVnode = pVnode;
  pInfo->txn = metaGetTxn(pVnode->pMeta);

  // save info
  vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, dir, TSDB_FILENAME_LEN);

  vDebug("vgId:%d, save config while prepare commit", TD_VID(pVnode));
  code = vnodeSaveInfo(dir, &pInfo->info);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = tsdbPreCommit(pVnode->pTsdb);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = metaPrepareAsyncCommit(pVnode->pMeta);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = smaPrepareAsyncCommit(pVnode->pSma);
  TSDB_CHECK_CODE(code, lino, _exit);

  (void)taosThreadMutexLock(&pVnode->mutex);
  pVnode->onCommit = pVnode->inUse;
  pVnode->inUse = NULL;
  (void)taosThreadMutexUnlock(&pVnode->mutex);

_exit:
  if (code) {
    vError("vgId:%d, %s failed at line %d since %s, commit id:%" PRId64, TD_VID(pVnode), __func__, lino,
           tstrerror(code), pVnode->state.commitID);
  } else {
    vDebug("vgId:%d, %s done, commit id:%" PRId64, TD_VID(pVnode), __func__, pInfo->info.state.commitID);
  }

  return code;
}
static void vnodeReturnBufPool(SVnode *pVnode) {
  (void)taosThreadMutexLock(&pVnode->mutex);

  SVBufPool *pPool = pVnode->onCommit;
  int32_t    nRef = atomic_sub_fetch_32(&pPool->nRef, 1);

  pVnode->onCommit = NULL;
  if (nRef == 0) {
    vnodeBufPoolAddToFreeList(pPool);
  } else if (nRef > 0) {
    vDebug("vgId:%d, buffer pool %p of id %d is added to recycle queue", TD_VID(pVnode), pPool, pPool->id);

    if (pVnode->recycleTail == NULL) {
      pPool->recyclePrev = pPool->recycleNext = NULL;
      pVnode->recycleHead = pVnode->recycleTail = pPool;
    } else {
      pPool->recyclePrev = pVnode->recycleTail;
      pPool->recycleNext = NULL;
      pVnode->recycleTail->recycleNext = pPool;
      pVnode->recycleTail = pPool;
    }
  } else {
    vError("vgId:%d, buffer pool %p of id %d nRef:%d", TD_VID(pVnode), pPool, pPool->id, nRef);
  }

  (void)taosThreadMutexUnlock(&pVnode->mutex);
}
static int32_t vnodeCommit(void *arg) {
  int32_t code = 0;

  SCommitInfo *pInfo = (SCommitInfo *)arg;
  SVnode      *pVnode = pInfo->pVnode;

  // commit
  if ((code = vnodeCommitImpl(pInfo))) {
    vFatal("vgId:%d, failed to commit vnode since %s", TD_VID(pVnode), terrstr());
    taosMsleep(100);
    exit(EXIT_FAILURE);
    goto _exit;
  }

  vnodeReturnBufPool(pVnode);

_exit:
  taosMemoryFree(arg);
  return code;
}

static void vnodeCommitCancel(void *arg) { taosMemoryFree(arg); }

int vnodeAsyncCommit(SVnode *pVnode) {
  int32_t code = 0;
  int32_t lino = 0;

  SCommitInfo *pInfo = (SCommitInfo *)taosMemoryCalloc(1, sizeof(*pInfo));
  if (NULL == pInfo) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  // prepare to commit
  code = vnodePrepareCommit(pVnode, pInfo);
  TSDB_CHECK_CODE(code, lino, _exit);

  // schedule the task
  code = vnodeAsync(COMMIT_TASK_ASYNC, EVA_PRIORITY_HIGH, vnodeCommit, vnodeCommitCancel, pInfo, &pVnode->commitTask);
  TSDB_CHECK_CODE(code, lino, _exit);

_exit:
  if (code) {
    taosMemoryFree(pInfo);
    vError("vgId:%d %s failed at line %d since %s" PRId64, TD_VID(pVnode), __func__, lino, tstrerror(code));
  } else {
    vInfo("vgId:%d, vnode async commit done, commitId:%" PRId64 " term:%" PRId64 " applied:%" PRId64, TD_VID(pVnode),
          pVnode->state.commitID, pVnode->state.applyTerm, pVnode->state.applied);
  }
  return code;
}

int32_t vnodeSyncCommit(SVnode *pVnode) {
  int32_t lino;
  int32_t code = vnodeAsyncCommit(pVnode);
  TSDB_CHECK_CODE(code, lino, _exit);
  vnodeAWait(&pVnode->commitTask);

_exit:
  if (code) {
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
  } else {
    vInfo("vgId:%d, sync commit end", TD_VID(pVnode));
  }

  return code;
}

static int vnodeCommitImpl(SCommitInfo *pInfo) {
  int32_t code = 0;
  int32_t lino = 0;

  char    dir[TSDB_FILENAME_LEN] = {0};
  SVnode *pVnode = pInfo->pVnode;

  vInfo("vgId:%d, start to commit, commitId:%" PRId64 " version:%" PRId64 " term: %" PRId64, TD_VID(pVnode),
        pInfo->info.state.commitID, pInfo->info.state.committed, pInfo->info.state.commitTerm);

  // persist wal before starting
  if ((code = walPersist(pVnode->pWal)) < 0) {
    vError("vgId:%d, failed to persist wal since %s", TD_VID(pVnode), tstrerror(code));
    return code;
  }

  vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, dir, TSDB_FILENAME_LEN);

  code = syncBeginSnapshot(pVnode->sync, pInfo->info.state.committed);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = tsdbCommitBegin(pVnode->pTsdb, pInfo);
  TSDB_CHECK_CODE(code, lino, _exit);

  if (!TSDB_CACHE_NO(pVnode->config)) {
    code = tsdbCacheCommit(pVnode->pTsdb);
    TSDB_CHECK_CODE(code, lino, _exit);
  }

  if (VND_IS_RSMA(pVnode)) {
    code = smaCommit(pVnode->pSma, pInfo);
    TSDB_CHECK_CODE(code, lino, _exit);
  }

  // commit info
  code = vnodeCommitInfo(dir);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = tsdbCommitCommit(pVnode->pTsdb);
  TSDB_CHECK_CODE(code, lino, _exit);

  if (VND_IS_RSMA(pVnode)) {
    code = smaFinishCommit(pVnode->pSma);
    TSDB_CHECK_CODE(code, lino, _exit);
  }

  code = metaFinishCommit(pVnode->pMeta, pInfo->txn);
  TSDB_CHECK_CODE(code, lino, _exit);

  pVnode->state.committed = pInfo->info.state.committed;

  if (smaPostCommit(pVnode->pSma) < 0) {
    vError("vgId:%d, failed to post-commit sma since %s", TD_VID(pVnode), tstrerror(terrno));
    return -1;
  }

  code = syncEndSnapshot(pVnode->sync);
  TSDB_CHECK_CODE(code, lino, _exit);

_exit:
  if (code) {
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
  } else {
    vInfo("vgId:%d, commit end", TD_VID(pVnode));
  }
  return code;
}

bool vnodeShouldRollback(SVnode *pVnode) {
  char    tFName[TSDB_FILENAME_LEN] = {0};
  int32_t offset = 0;

  vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, tFName, TSDB_FILENAME_LEN);
  offset = strlen(tFName);
  snprintf(tFName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME_TMP);

  return taosCheckExistFile(tFName);
}

void vnodeRollback(SVnode *pVnode) {
  char    tFName[TSDB_FILENAME_LEN] = {0};
  int32_t offset = 0;

  vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, tFName, TSDB_FILENAME_LEN);
  offset = strlen(tFName);
  snprintf(tFName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME_TMP);

  if (taosRemoveFile(tFName) != 0) {
    vError("vgId:%d, failed to remove file %s since %s", TD_VID(pVnode), tFName, tstrerror(terrno));
  }
}

static int vnodeEncodeState(const void *pObj, SJson *pJson) {
  const SVState *pState = (SVState *)pObj;

  TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit version", pState->committed));
  TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit ID", pState->commitID));
  TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit term", pState->commitTerm));

  return 0;
}

static int vnodeDecodeState(const SJson *pJson, void *pObj) {
  SVState *pState = (SVState *)pObj;

  int32_t code;
  tjsonGetNumberValue(pJson, "commit version", pState->committed, code);
  if (code) return code;
  tjsonGetNumberValue(pJson, "commit ID", pState->commitID, code);
  if (code) return code;
  tjsonGetNumberValue(pJson, "commit term", pState->commitTerm, code);
  if (code) return code;

  return 0;
}

static int vnodeEncodeInfo(const SVnodeInfo *pInfo, char **ppData) {
  int32_t code = 0;
  int32_t lino;
  SJson  *pJson = NULL;
  char   *pData = NULL;

  pJson = tjsonCreateObject();
  if (pJson == NULL) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  code = tjsonAddObject(pJson, "config", vnodeEncodeConfig, (void *)&pInfo->config);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = tjsonAddObject(pJson, "state", vnodeEncodeState, (void *)&pInfo->state);
  TSDB_CHECK_CODE(code, lino, _exit);

  pData = tjsonToString(pJson);
  if (pData == NULL) {
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
  }

  tjsonDelete(pJson);

_exit:
  if (code) {
    tjsonDelete(pJson);
    *ppData = NULL;
  } else {
    *ppData = pData;
  }
  return code;
}

int vnodeDecodeInfo(uint8_t *pData, SVnodeInfo *pInfo) {
  int32_t code = 0;
  int32_t lino;
  SJson  *pJson = NULL;

  pJson = tjsonParse(pData);
  if (pJson == NULL) {
    TSDB_CHECK_CODE(code = TSDB_CODE_INVALID_DATA_FMT, lino, _exit);
  }

  code = tjsonToObject(pJson, "config", vnodeDecodeConfig, (void *)&pInfo->config);
  TSDB_CHECK_CODE(code, lino, _exit);

  code = tjsonToObject(pJson, "state", vnodeDecodeState, (void *)&pInfo->state);
  TSDB_CHECK_CODE(code, lino, _exit);

_exit:
  tjsonDelete(pJson);
  return code;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "meta.h"
17	#include "sync.h"
18	#include "vnd.h"
19	#include "vnodeInt.h"
20
21	extern int32_t tsdbPreCommit(STsdb *pTsdb);
22	extern int32_t tsdbCommitBegin(STsdb pTsdb, SCommitInfo pInfo);
23	extern int32_t tsdbCommitCommit(STsdb *pTsdb);
24	extern int32_t tsdbCommitAbort(STsdb *pTsdb);
25
26	#define VND_INFO_FNAME_TMP "vnode_tmp.json"
27
28	static int vnodeEncodeInfo(const SVnodeInfo pInfo, char *ppData);
29	static int vnodeCommitImpl(SCommitInfo *pInfo);
30
31	#define WAIT_TIME_MILI_SEC 10 // miliseconds
32
33	static int32_t vnodeTryRecycleBufPool(SVnode *pVnode) {	×
34	int32_t code = 0;	×
35
36	if (pVnode->onRecycle == NULL) {	×
37	if (pVnode->recycleHead == NULL) {	×
38	vDebug("vgId:%d, no recyclable buffer pool", TD_VID(pVnode));	×
39	goto _exit;	×
40	} else {
41	vDebug("vgId:%d, buffer pool %p of id %d on recycle queue, try to recycle", TD_VID(pVnode), pVnode->recycleHead,	×
42	pVnode->recycleHead->id);
43
44	pVnode->onRecycle = pVnode->recycleHead;	×
45	if (pVnode->recycleHead == pVnode->recycleTail) {	×
46	pVnode->recycleHead = pVnode->recycleTail = NULL;	×
47	} else {
48	pVnode->recycleHead = pVnode->recycleHead->recycleNext;	×
49	pVnode->recycleHead->recyclePrev = NULL;	×
50	}
51	pVnode->onRecycle->recycleNext = pVnode->onRecycle->recyclePrev = NULL;	×
52	}
53	}
54
55	code = vnodeBufPoolRecycle(pVnode->onRecycle);	×
56	if (code) goto _exit;	×
57
58	_exit:	×
59	if (code) {	×
60	vError("vgId:%d, %s failed since %s", TD_VID(pVnode), __func__, tstrerror(code));	×
61	}
62	return code;	×
63	}
64	static int32_t vnodeGetBufPoolToUse(SVnode *pVnode) {	×
65	int32_t code = 0;	×
66	int32_t lino = 0;	×
67
68	(void)taosThreadMutexLock(&pVnode->mutex);	×
69
70	int32_t nTry = 0;	×
71	for (;;) {
72	++nTry;	×
73
74	if (pVnode->freeList) {	×
75	vDebug("vgId:%d, allocate free buffer pool on %d try, pPool:%p id:%d", TD_VID(pVnode), nTry, pVnode->freeList,	×
76	pVnode->freeList->id);
77
78	pVnode->inUse = pVnode->freeList;	×
79	pVnode->inUse->nRef = 1;	×
80	pVnode->freeList = pVnode->inUse->freeNext;	×
81	pVnode->inUse->freeNext = NULL;	×
82	break;	×
83	} else {
84	vDebug("vgId:%d, no free buffer pool on %d try, try to recycle...", TD_VID(pVnode), nTry);	×
85
86	code = vnodeTryRecycleBufPool(pVnode);	×
87	TSDB_CHECK_CODE(code, lino, _exit);	×
88
89	if (pVnode->freeList == NULL) {	×
90	vDebug("vgId:%d, no free buffer pool on %d try, wait %d ms...", TD_VID(pVnode), nTry, WAIT_TIME_MILI_SEC);	×
91
92	struct timeval tv;
93	struct timespec ts;
94	if (taosGetTimeOfDay(&tv) != 0) {	×
95	continue;	×
96	}
97	ts.tv_nsec = tv.tv_usec * 1000 + WAIT_TIME_MILI_SEC * 1000000;	×
98	if (ts.tv_nsec > 999999999l) {	×
99	ts.tv_sec = tv.tv_sec + 1;	×
100	ts.tv_nsec -= 1000000000l;	×
101	} else {
102	ts.tv_sec = tv.tv_sec;	×
103	}
104
105	code = taosThreadCondTimedWait(&pVnode->poolNotEmpty, &pVnode->mutex, &ts);	×
106	// ignore timeout error and retry
107	if (code == TSDB_CODE_TIMEOUT_ERROR) {	×
108	code = TSDB_CODE_SUCCESS;	×
109	}
110	TSDB_CHECK_CODE(code, lino, _exit);	×
111	}
112	}
113	}
114
115	_exit:	×
116	(void)taosThreadMutexUnlock(&pVnode->mutex);	×
117	if (code) {	×
118	vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));	×
119	}
120	return code;	×
121	}
122	int vnodeBegin(SVnode *pVnode) {	×
123	int32_t code = 0;	×
124	int32_t lino = 0;	×
125
126	// alloc buffer pool
127	code = vnodeGetBufPoolToUse(pVnode);	×
128	TSDB_CHECK_CODE(code, lino, _exit);	×
129
130	// begin meta
131	code = metaBegin(pVnode->pMeta, META_BEGIN_HEAP_BUFFERPOOL);	×
132	TSDB_CHECK_CODE(code, lino, _exit);	×
133
134	// begin tsdb
135	code = tsdbBegin(pVnode->pTsdb);	×
136	TSDB_CHECK_CODE(code, lino, _exit);	×
137
138	// begin sma
139	if (VND_IS_RSMA(pVnode)) {	×
140	code = smaBegin(pVnode->pSma);	×
141	TSDB_CHECK_CODE(code, lino, _exit);	×
142	}
143
144	_exit:	×
145	if (code) {	×
146	terrno = code;	×
147	vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));	×
148	}
149	return code;	×
150	}
151
152	int vnodeShouldCommit(SVnode *pVnode, bool atExit) {	×
153	bool diskAvail = osDataSpaceAvailable();	×
154	bool needCommit = false;	×
155
156	(void)taosThreadMutexLock(&pVnode->mutex);	×
157	if (pVnode->inUse && diskAvail) {	×
158	needCommit = (pVnode->inUse->size > pVnode->inUse->node.size) \|\|	×
159	(atExit && (pVnode->inUse->size > 0 \|\| pVnode->pMeta->changed \|\|	×
160	pVnode->state.applied - pVnode->state.committed > 4096));	×
161	}
162	vTrace("vgId:%d, should commit:%d, disk available:%d, buffer size:%" PRId64 ", node size:%" PRId64	×
163	", meta changed:%d"
164	", state:[%" PRId64 ",%" PRId64 "]",
165	TD_VID(pVnode), needCommit, diskAvail, pVnode->inUse ? pVnode->inUse->size : 0,
166	pVnode->inUse ? pVnode->inUse->node.size : 0, pVnode->pMeta->changed, pVnode->state.applied,
167	pVnode->state.committed);
168	(void)taosThreadMutexUnlock(&pVnode->mutex);	×
169	return needCommit;	×
170	}
171
172	int vnodeSaveInfo(const char dir, const SVnodeInfo pInfo) {	×
173	int32_t code = 0;	×
174	int32_t lino;
175	char fname[TSDB_FILENAME_LEN];
176	TdFilePtr pFile = NULL;	×
177	char *data = NULL;	×
178
179	snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME_TMP);	×
180
181	code = vnodeEncodeInfo(pInfo, &data);	×
182	TSDB_CHECK_CODE(code, lino, _exit);	×
183
184	// save info to a vnode_tmp.json
185	pFile = taosOpenFile(fname, TD_FILE_CREATE \| TD_FILE_WRITE \| TD_FILE_TRUNC \| TD_FILE_WRITE_THROUGH);	×
186	if (pFile == NULL) {	×
187	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
188	}
189
190	if (taosWriteFile(pFile, data, strlen(data)) < 0) {	×
191	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
192	}
193
194	if (taosFsyncFile(pFile) < 0) {	×
195	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
196	}
197
198	_exit:	×
199	if (code) {	×
200	vError("vgId:%d %s failed at %s:%d since %s", pInfo->config.vgId, __func__, __FILE__, lino, tstrerror(code));	×
201	} else {
202	vInfo("vgId:%d, vnode info is saved, fname:%s replica:%d selfIndex:%d changeVersion:%d", pInfo->config.vgId, fname,	×
203	pInfo->config.syncCfg.replicaNum, pInfo->config.syncCfg.myIndex, pInfo->config.syncCfg.changeVersion);
204	}
205	if (taosCloseFile(&pFile) != 0) {	×
206	vError("vgId:%d, failed to close file", pInfo->config.vgId);	×
207	}
208	taosMemoryFree(data);	×
209	TAOS_RETURN(code);	×
210	}
211
212	int vnodeCommitInfo(const char *dir) {	×
213	char fname[TSDB_FILENAME_LEN];
214	char tfname[TSDB_FILENAME_LEN];
215
216	snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME);	×
217	snprintf(tfname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME_TMP);	×
218
219	int32_t code = taosRenameFile(tfname, fname);	×
220	if (code < 0) {	×
221	return code;	×
222	}
223
224	vInfo("vnode info is committed, dir:%s", dir);	×
225	return 0;	×
226	}
227
228	int vnodeLoadInfo(const char dir, SVnodeInfo pInfo) {	×
229	int32_t code = 0;	×
230	int32_t lino;
231	char fname[TSDB_FILENAME_LEN];
232	TdFilePtr pFile = NULL;	×
233	char *pData = NULL;	×
234	int64_t size;
235
236	snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME);	×
237
238	// read info
239	pFile = taosOpenFile(fname, TD_FILE_READ);	×
240	if (pFile == NULL) {	×
241	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
242	}
243
244	code = taosFStatFile(pFile, &size, NULL);	×
245	TSDB_CHECK_CODE(code, lino, _exit);	×
246
247	pData = taosMemoryMalloc(size + 1);	×
248	if (pData == NULL) {	×
249	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
250	}
251
252	if (taosReadFile(pFile, pData, size) < 0) {	×
253	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
254	}
255
256	pData[size] = '\0';	×
257
258	// decode info
259	code = vnodeDecodeInfo(pData, pInfo);	×
260	TSDB_CHECK_CODE(code, lino, _exit);	×
261
262	pInfo->config.walCfg.committed = pInfo->state.committed;	×
263	_exit:	×
264	if (code) {	×
265	if (pFile) {	×
266	vError("vgId:%d %s failed at %s:%d since %s", pInfo->config.vgId, __func__, __FILE__, lino, tstrerror(code));	×
267	}
268	}
269	taosMemoryFree(pData);	×
270	if (taosCloseFile(&pFile) != 0) {	×
271	vError("vgId:%d, failed to close file", pInfo->config.vgId);	×
272	}
273	return code;	×
274	}
275
276	static int32_t vnodePrepareCommit(SVnode pVnode, SCommitInfo pInfo) {	×
277	int32_t code = 0;	×
278	int32_t lino = 0;	×
279	char dir[TSDB_FILENAME_LEN] = {0};	×
280	int64_t lastCommitted = pInfo->info.state.committed;	×
281
282	// wait last commit task
283	vnodeAWait(&pVnode->commitTask);	×
284
285	code = syncNodeGetConfig(pVnode->sync, &pVnode->config.syncCfg);	×
286	TSDB_CHECK_CODE(code, lino, _exit);	×
287
288	pVnode->state.commitTerm = pVnode->state.applyTerm;	×
289
290	pInfo->info.config = pVnode->config;	×
291	pInfo->info.state.committed = pVnode->state.applied;	×
292	pInfo->info.state.commitTerm = pVnode->state.applyTerm;	×
293	pInfo->info.state.commitID = ++pVnode->state.commitID;	×
294	pInfo->pVnode = pVnode;	×
295	pInfo->txn = metaGetTxn(pVnode->pMeta);	×
296
297	// save info
298	vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, dir, TSDB_FILENAME_LEN);	×
299
300	vDebug("vgId:%d, save config while prepare commit", TD_VID(pVnode));	×
301	code = vnodeSaveInfo(dir, &pInfo->info);	×
302	TSDB_CHECK_CODE(code, lino, _exit);	×
303
304	code = tsdbPreCommit(pVnode->pTsdb);	×
305	TSDB_CHECK_CODE(code, lino, _exit);	×
306
307	code = metaPrepareAsyncCommit(pVnode->pMeta);	×
308	TSDB_CHECK_CODE(code, lino, _exit);	×
309
310	code = smaPrepareAsyncCommit(pVnode->pSma);	×
311	TSDB_CHECK_CODE(code, lino, _exit);	×
312
313	(void)taosThreadMutexLock(&pVnode->mutex);	×
314	pVnode->onCommit = pVnode->inUse;	×
315	pVnode->inUse = NULL;	×
316	(void)taosThreadMutexUnlock(&pVnode->mutex);	×
317
318	_exit:	×
319	if (code) {	×
320	vError("vgId:%d, %s failed at line %d since %s, commit id:%" PRId64, TD_VID(pVnode), __func__, lino,	×
321	tstrerror(code), pVnode->state.commitID);
322	} else {
323	vDebug("vgId:%d, %s done, commit id:%" PRId64, TD_VID(pVnode), __func__, pInfo->info.state.commitID);	×
324	}
325
326	return code;	×
327	}
328	static void vnodeReturnBufPool(SVnode *pVnode) {	×
329	(void)taosThreadMutexLock(&pVnode->mutex);	×
330
331	SVBufPool *pPool = pVnode->onCommit;	×
332	int32_t nRef = atomic_sub_fetch_32(&pPool->nRef, 1);	×
333
334	pVnode->onCommit = NULL;	×
335	if (nRef == 0) {	×
336	vnodeBufPoolAddToFreeList(pPool);	×
337	} else if (nRef > 0) {	×
338	vDebug("vgId:%d, buffer pool %p of id %d is added to recycle queue", TD_VID(pVnode), pPool, pPool->id);	×
339
340	if (pVnode->recycleTail == NULL) {	×
341	pPool->recyclePrev = pPool->recycleNext = NULL;	×
342	pVnode->recycleHead = pVnode->recycleTail = pPool;	×
343	} else {
344	pPool->recyclePrev = pVnode->recycleTail;	×
345	pPool->recycleNext = NULL;	×
346	pVnode->recycleTail->recycleNext = pPool;	×
347	pVnode->recycleTail = pPool;	×
348	}
349	} else {
350	vError("vgId:%d, buffer pool %p of id %d nRef:%d", TD_VID(pVnode), pPool, pPool->id, nRef);	×
351	}
352
353	(void)taosThreadMutexUnlock(&pVnode->mutex);	×
354	}	×
355	static int32_t vnodeCommit(void *arg) {	×
356	int32_t code = 0;	×
357
358	SCommitInfo pInfo = (SCommitInfo )arg;	×
359	SVnode *pVnode = pInfo->pVnode;	×
360
361	// commit
362	if ((code = vnodeCommitImpl(pInfo))) {	×
363	vFatal("vgId:%d, failed to commit vnode since %s", TD_VID(pVnode), terrstr());	×
364	taosMsleep(100);	×
365	exit(EXIT_FAILURE);	×
366	goto _exit;
367	}
368
369	vnodeReturnBufPool(pVnode);	×
370
371	_exit:	×
372	taosMemoryFree(arg);	×
373	return code;	×
374	}
375
376	static void vnodeCommitCancel(void *arg) { taosMemoryFree(arg); }	×
377
378	int vnodeAsyncCommit(SVnode *pVnode) {	×
379	int32_t code = 0;	×
380	int32_t lino = 0;	×
381
382	SCommitInfo pInfo = (SCommitInfo )taosMemoryCalloc(1, sizeof(*pInfo));	×
383	if (NULL == pInfo) {	×
384	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
385	}
386
387	// prepare to commit
388	code = vnodePrepareCommit(pVnode, pInfo);	×
389	TSDB_CHECK_CODE(code, lino, _exit);	×
390
391	// schedule the task
392	code = vnodeAsync(COMMIT_TASK_ASYNC, EVA_PRIORITY_HIGH, vnodeCommit, vnodeCommitCancel, pInfo, &pVnode->commitTask);	×
393	TSDB_CHECK_CODE(code, lino, _exit);	×
394
395	_exit:	×
396	if (code) {	×
397	taosMemoryFree(pInfo);	×
398	vError("vgId:%d %s failed at line %d since %s" PRId64, TD_VID(pVnode), __func__, lino, tstrerror(code));	×
399	} else {
400	vInfo("vgId:%d, vnode async commit done, commitId:%" PRId64 " term:%" PRId64 " applied:%" PRId64, TD_VID(pVnode),	×
401	pVnode->state.commitID, pVnode->state.applyTerm, pVnode->state.applied);
402	}
403	return code;	×
404	}
405
406	int32_t vnodeSyncCommit(SVnode *pVnode) {	×
407	int32_t lino;
408	int32_t code = vnodeAsyncCommit(pVnode);	×
409	TSDB_CHECK_CODE(code, lino, _exit);	×
410	vnodeAWait(&pVnode->commitTask);	×
411
412	_exit:	×
413	if (code) {	×
414	vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));	×
415	} else {
416	vInfo("vgId:%d, sync commit end", TD_VID(pVnode));	×
417	}
418
419	return code;	×
420	}
421
422	static int vnodeCommitImpl(SCommitInfo *pInfo) {	×
423	int32_t code = 0;	×
424	int32_t lino = 0;	×
425
426	char dir[TSDB_FILENAME_LEN] = {0};	×
427	SVnode *pVnode = pInfo->pVnode;	×
428
429	vInfo("vgId:%d, start to commit, commitId:%" PRId64 " version:%" PRId64 " term: %" PRId64, TD_VID(pVnode),	×
430	pInfo->info.state.commitID, pInfo->info.state.committed, pInfo->info.state.commitTerm);
431
432	// persist wal before starting
433	if ((code = walPersist(pVnode->pWal)) < 0) {	×
434	vError("vgId:%d, failed to persist wal since %s", TD_VID(pVnode), tstrerror(code));	×
435	return code;	×
436	}
437
438	vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, dir, TSDB_FILENAME_LEN);	×
439
440	code = syncBeginSnapshot(pVnode->sync, pInfo->info.state.committed);	×
441	TSDB_CHECK_CODE(code, lino, _exit);	×
442
443	code = tsdbCommitBegin(pVnode->pTsdb, pInfo);	×
444	TSDB_CHECK_CODE(code, lino, _exit);	×
445
446	if (!TSDB_CACHE_NO(pVnode->config)) {	×
447	code = tsdbCacheCommit(pVnode->pTsdb);	×
448	TSDB_CHECK_CODE(code, lino, _exit);	×
449	}
450
451	if (VND_IS_RSMA(pVnode)) {	×
452	code = smaCommit(pVnode->pSma, pInfo);	×
453	TSDB_CHECK_CODE(code, lino, _exit);	×
454	}
455
456	// commit info
457	code = vnodeCommitInfo(dir);	×
458	TSDB_CHECK_CODE(code, lino, _exit);	×
459
460	code = tsdbCommitCommit(pVnode->pTsdb);	×
461	TSDB_CHECK_CODE(code, lino, _exit);	×
462
463	if (VND_IS_RSMA(pVnode)) {	×
464	code = smaFinishCommit(pVnode->pSma);	×
465	TSDB_CHECK_CODE(code, lino, _exit);	×
466	}
467
468	code = metaFinishCommit(pVnode->pMeta, pInfo->txn);	×
469	TSDB_CHECK_CODE(code, lino, _exit);	×
470
471	pVnode->state.committed = pInfo->info.state.committed;	×
472
473	if (smaPostCommit(pVnode->pSma) < 0) {	×
474	vError("vgId:%d, failed to post-commit sma since %s", TD_VID(pVnode), tstrerror(terrno));	×
475	return -1;	×
476	}
477
478	code = syncEndSnapshot(pVnode->sync);	×
479	TSDB_CHECK_CODE(code, lino, _exit);	×
480
481	_exit:	×
482	if (code) {	×
483	vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));	×
484	} else {
485	vInfo("vgId:%d, commit end", TD_VID(pVnode));	×
486	}
487	return code;	×
488	}
489
490	bool vnodeShouldRollback(SVnode *pVnode) {	×
491	char tFName[TSDB_FILENAME_LEN] = {0};	×
492	int32_t offset = 0;	×
493
494	vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, tFName, TSDB_FILENAME_LEN);	×
495	offset = strlen(tFName);	×
496	snprintf(tFName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME_TMP);	×
497
498	return taosCheckExistFile(tFName);	×
499	}
500
501	void vnodeRollback(SVnode *pVnode) {	×
502	char tFName[TSDB_FILENAME_LEN] = {0};	×
503	int32_t offset = 0;	×
504
505	vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, tFName, TSDB_FILENAME_LEN);	×
506	offset = strlen(tFName);	×
507	snprintf(tFName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME_TMP);	×
508
509	if (taosRemoveFile(tFName) != 0) {	×
510	vError("vgId:%d, failed to remove file %s since %s", TD_VID(pVnode), tFName, tstrerror(terrno));	×
511	}
512	}	×
513
514	static int vnodeEncodeState(const void pObj, SJson pJson) {	×
515	const SVState pState = (SVState )pObj;	×
516
517	TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit version", pState->committed));	×
518	TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit ID", pState->commitID));	×
519	TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit term", pState->commitTerm));	×
520
521	return 0;	×
522	}
523
524	static int vnodeDecodeState(const SJson pJson, void pObj) {	×
525	SVState pState = (SVState )pObj;	×
526
527	int32_t code;
528	tjsonGetNumberValue(pJson, "commit version", pState->committed, code);	×
529	if (code) return code;	×
530	tjsonGetNumberValue(pJson, "commit ID", pState->commitID, code);	×
531	if (code) return code;	×
532	tjsonGetNumberValue(pJson, "commit term", pState->commitTerm, code);	×
533	if (code) return code;	×
534
535	return 0;	×
536	}
537
538	static int vnodeEncodeInfo(const SVnodeInfo pInfo, char *ppData) {	×
539	int32_t code = 0;	×
540	int32_t lino;
541	SJson *pJson = NULL;	×
542	char *pData = NULL;	×
543
544	pJson = tjsonCreateObject();	×
545	if (pJson == NULL) {	×
546	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
547	}
548
549	code = tjsonAddObject(pJson, "config", vnodeEncodeConfig, (void *)&pInfo->config);	×
550	TSDB_CHECK_CODE(code, lino, _exit);	×
551
552	code = tjsonAddObject(pJson, "state", vnodeEncodeState, (void *)&pInfo->state);	×
553	TSDB_CHECK_CODE(code, lino, _exit);	×
554
555	pData = tjsonToString(pJson);	×
556	if (pData == NULL) {	×
557	TSDB_CHECK_CODE(code = terrno, lino, _exit);	×
558	}
559
560	tjsonDelete(pJson);	×
561
562	_exit:	×
563	if (code) {	×
564	tjsonDelete(pJson);	×
565	*ppData = NULL;	×
566	} else {
567	*ppData = pData;	×
568	}
569	return code;	×
570	}
571
572	int vnodeDecodeInfo(uint8_t pData, SVnodeInfo pInfo) {	×
573	int32_t code = 0;	×
574	int32_t lino;
575	SJson *pJson = NULL;	×
576
577	pJson = tjsonParse(pData);	×
578	if (pJson == NULL) {	×
579	TSDB_CHECK_CODE(code = TSDB_CODE_INVALID_DATA_FMT, lino, _exit);	×
580	}
581
582	code = tjsonToObject(pJson, "config", vnodeDecodeConfig, (void *)&pInfo->config);	×
583	TSDB_CHECK_CODE(code, lino, _exit);	×
584
585	code = tjsonToObject(pJson, "state", vnodeDecodeState, (void *)&pInfo->state);	×
586	TSDB_CHECK_CODE(code, lino, _exit);	×
587
588	_exit:	×
589	tjsonDelete(pJson);	×
590	return code;	×
591	}

taosdata / TDengine / #3798

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous