14134108101

Committed 28 Mar 2025 05:03PM CUT coverage: 97.985% (-0.01%) from 97.999%

Build # 14134108101

Build Type

Pull #5171

github

Committed by

web-flow

Commit Message

Merge 54ef5b23f into 5a3bc6d24

Pull Request Pull Request #5171: fix(card): card component checkbox accessibility name and keyboard access #5168

Run Details

5340 of 5638 branches covered (94.71%)

Branch coverage included in aggregate %.

102 of 108 new or added lines in 2 files covered. (94.44%)

4 existing lines in 1 file now uncovered.

33761 of 34267 relevant lines covered (98.52%)

646.1 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/packages/picker/src/MobileController.ts

/*
Copyright 2024 Adobe. All rights reserved.
This file is licensed to you under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. You may obtain a copy
of the License at http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
OF ANY KIND, either express or implied. See the License for the specific language
governing permissions and limitations under the License.
*/

import {
    InteractionController,
    InteractionTypes,
    SAFARI_FOCUS_RING_CLASS,
} from './InteractionController.js';
import { isWebKit } from '@spectrum-web-components/shared';

export class MobileController extends InteractionController {
    override type = InteractionTypes.mobile;

    handleClick(): void {
        if (this.host.disabled) {
            return;
        }
        if (this.preventNextToggle == 'no') {

            this.host.toggle();
        }
        this.preventNextToggle = 'no';
    }

    public override handlePointerdown(): void {
        this.preventNextToggle = this.open ? 'yes' : 'no';
        if (isWebKit()) {
            this.target.classList.add(SAFARI_FOCUS_RING_CLASS);
        }
    }

    private handleFocusOut(): void {
        if (this.host.open) {
            return;
        }
        if (
            isWebKit() &&
            this.target.classList.contains(SAFARI_FOCUS_RING_CLASS)
        ) {
            this.target.classList.remove(SAFARI_FOCUS_RING_CLASS);
        }
    }

    override init(): void {
        // Clean up listeners if they've already been bound
        this.abortController?.abort();
        this.abortController = new AbortController();
        const { signal } = this.abortController;
        this.target.addEventListener('click', () => this.handleClick(), {
            signal,
        });
        this.target.addEventListener(
            'pointerdown',
            () => this.handlePointerdown(),
            { signal }
        );
        this.target.addEventListener('focusout', () => this.handleFocusOut(), {
            signal,
        });
    }
}

1	/*	30✔
2	Copyright 2024 Adobe. All rights reserved.	30✔
3	This file is licensed to you under the Apache License, Version 2.0 (the "License");	30✔
4	you may not use this file except in compliance with the License. You may obtain a copy	30✔
5	of the License at http://www.apache.org/licenses/LICENSE-2.0	30✔
6	Unless required by applicable law or agreed to in writing, software distributed under	30✔
7	the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS	30✔
8	OF ANY KIND, either express or implied. See the License for the specific language	30✔
9	governing permissions and limitations under the License.	30✔
10	*/	30✔
11		30✔
12	import {	30✔
13	InteractionController,	30✔
14	InteractionTypes,	30✔
15	SAFARI_FOCUS_RING_CLASS,	30✔
16	} from './InteractionController.js';	30✔
17	import { isWebKit } from '@spectrum-web-components/shared';	30✔
18		30✔
19	export class MobileController extends InteractionController {	30✔
20	override type = InteractionTypes.mobile;	4✔
21		30✔
22	handleClick(): void {	30✔
23	if (this.host.disabled) {	4!
24	return;	×
25	}	×
26	if (this.preventNextToggle == 'no') {	4✔
27		4✔
28	this.host.toggle();	4✔
29	}	4✔
30	this.preventNextToggle = 'no';	4✔
31	}	4✔
32		30✔
33	public override handlePointerdown(): void {	30✔
34	this.preventNextToggle = this.open ? 'yes' : 'no';	4!
35	if (isWebKit()) {	4!
36	this.target.classList.add(SAFARI_FOCUS_RING_CLASS);	×
37	}	×
38	}	4✔
39		30✔
40	private handleFocusOut(): void {	30✔
41	if (this.host.open) {	4✔
42	return;	4✔
43	}	4!
44	if (	×
45	isWebKit() &&	×
46	this.target.classList.contains(SAFARI_FOCUS_RING_CLASS)	×
47	) {	4!
48	this.target.classList.remove(SAFARI_FOCUS_RING_CLASS);	×
49	}	×
50	}	4✔
51		30✔
52	override init(): void {	30✔
53	// Clean up listeners if they've already been bound	8✔
54	this.abortController?.abort();	8✔
55	this.abortController = new AbortController();	8✔
56	const { signal } = this.abortController;	8✔
57	this.target.addEventListener('click', () => this.handleClick(), {	8✔
58	signal,	8✔
59	});	8✔
60	this.target.addEventListener(	8✔
61	'pointerdown',	8✔
62	() => this.handlePointerdown(),	8✔
63	{ signal }	8✔
64	);	8✔
65	this.target.addEventListener('focusout', () => this.handleFocusOut(), {	8✔
66	signal,	8✔
67	});	8✔
68	}	8✔
69	}	30✔

adobe / spectrum-web-components / 14134108101

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous