14063512994

Committed 25 Mar 2025 03:23PM UTC coverage: 1.275% (-0.001%) from 1.276%

Build # 14063512994

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #605 from Yoast/bugfix/604-crawler-javascript

[BUGFIX] Added missing translations and supportedLanguages javascript configuration for the Crawler module

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

35 of 2746 relevant lines covered (1.27%)

0.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Classes/Service/Crawler/CrawlerJavascriptConfigService.php

<?php

declare(strict_types=1);

namespace YoastSeoForTypo3\YoastSeo\Service\Crawler;

use TYPO3\CMS\Backend\Routing\UriBuilder;
use YoastSeoForTypo3\YoastSeo\Service\Javascript\JavascriptService;
use YoastSeoForTypo3\YoastSeo\Service\Javascript\JsonConfigService;
use YoastSeoForTypo3\YoastSeo\Service\LocaleService;
use YoastSeoForTypo3\YoastSeo\Utility\PathUtility;

class CrawlerJavascriptConfigService
{
    public function __construct(
        protected JavascriptService $javascriptService,
        protected JsonConfigService $jsonConfigService,
        protected UriBuilder $uriBuilder,
        protected LocaleService $localeService
    ) {}

    public function addJavascriptConfig(): void
    {
        $this->javascriptService->loadPluginJavascript();
        $this->jsonConfigService->addConfig([
            'urls' => [
                'workerUrl' => PathUtility::getPublicPathToResources() . '/JavaScript/dist/worker.js',
                'preview' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_preview'),
                'determinePages' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_crawler_determine_pages'),
                'indexPages' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_crawler_index_pages'),
                'prominentWords' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_prominent_words'),
            ],
            'translations' => [$this->localeService->getTranslations()],
            'supportedLanguages' => $this->localeService->getSupportedLanguages(),
        ]);
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace YoastSeoForTypo3\YoastSeo\Service\Crawler;
6
7	use TYPO3\CMS\Backend\Routing\UriBuilder;
8	use YoastSeoForTypo3\YoastSeo\Service\Javascript\JavascriptService;
9	use YoastSeoForTypo3\YoastSeo\Service\Javascript\JsonConfigService;
10	use YoastSeoForTypo3\YoastSeo\Service\LocaleService;
11	use YoastSeoForTypo3\YoastSeo\Utility\PathUtility;
12
13	class CrawlerJavascriptConfigService
14	{
15	public function __construct(
16	protected JavascriptService $javascriptService,
17	protected JsonConfigService $jsonConfigService,
18	protected UriBuilder $uriBuilder,
19	protected LocaleService $localeService
UNCOV 20	) {}	×
21
22	public function addJavascriptConfig(): void
23	{
24	$this->javascriptService->loadPluginJavascript();	×
25	$this->jsonConfigService->addConfig([	×
26	'urls' => [	×
27	'workerUrl' => PathUtility::getPublicPathToResources() . '/JavaScript/dist/worker.js',	×
28	'preview' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_preview'),	×
29	'determinePages' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_crawler_determine_pages'),	×
30	'indexPages' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_crawler_index_pages'),	×
31	'prominentWords' => (string)$this->uriBuilder->buildUriFromRoute('ajax_yoast_prominent_words'),	×
32	],	×
NEW 33	'translations' => [$this->localeService->getTranslations()],	×
NEW 34	'supportedLanguages' => $this->localeService->getSupportedLanguages(),	×
UNCOV 35	]);	×
36	}
37	}

Yoast / Yoast-SEO-for-TYPO3 / 14063512994

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous