14016638949

Committed 23 Mar 2025 07:11AM UTC coverage: 27.127%. Remained the same

Build # 14016638949

Build Type

Pull #427

github

Committed by

web-flow

Commit Message

Merge 53d7b369d into 4409a1bb4

Pull Request Pull Request #427: Process addresses in the Mach-O export trie as ULEB128 instead of LEB128

Run Details

1270 of 6490 branches covered (19.57%)

Branch coverage included in aggregate %.

0 of 15 new or added lines in 3 files covered. (0.0%)

2 existing lines in 2 files now uncovered.

3379 of 10648 relevant lines covered (31.73%)

122354.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/LibCpp2IL/MachO/MachOExportTrie.cs

﻿using System;
using System.Collections.Generic;

namespace LibCpp2IL.MachO;

public class MachOExportTrie
{
    public List<MachOExportEntry> Entries = [];

    private ClassReadingBinaryReader _reader;
    private long _basePtr;

    public MachOExportTrie(ClassReadingBinaryReader reader)
    {
        _reader = reader;
        _basePtr = reader.BaseStream.Position;

        var children = ParseNode("", 0);
        while (children.Count > 0)
        {
            var current = children[0];
            children.RemoveAt(0);
            children.AddRange(ParseNode(current.Name, current.Offset));
        }
    }

    private List<Node> ParseNode(string name, int offset)
    {
        var children = new List<Node>();
        _reader.BaseStream.Position = _basePtr + offset;

        var terminalSize = _reader.BaseStream.ReadLEB128Unsigned();
        var childrenIndex = _reader.BaseStream.Position + (long)terminalSize;
        if (terminalSize != 0)
        {
            var flags = (ExportFlags)_reader.BaseStream.ReadLEB128Unsigned();
            var address = 0UL;
            var other = 0UL;
            string? importName = null;

            if ((flags & ExportFlags.ReExport) != 0)
            {
                other = _reader.BaseStream.ReadLEB128Unsigned();
                importName = _reader.ReadStringToNullAtCurrentPos();
            }
            else
            {
                address = _reader.BaseStream.ReadLEB128Unsigned();
                if ((flags & ExportFlags.StubAndResolver) != 0)
                    other = _reader.BaseStream.ReadLEB128Unsigned();
            }

            Entries.Add(new(name, address, (ulong)flags, other, importName));
        }

        _reader.BaseStream.Position = childrenIndex;
        var numChildren = _reader.BaseStream.ReadLEB128Unsigned();
        for (var i = 0ul; i < numChildren; i++)
        {
            var childName = _reader.ReadStringToNullAtCurrentPos();
            var childOffset = _reader.BaseStream.ReadLEB128Unsigned();
            children.Add(new Node { Name = name + childName, Offset = (int)childOffset });
        }

        return children;
    }

    [Flags]
    private enum ExportFlags
    {
        KindRegular = 0,
        KindThreadLocal = 1,
        KindAbsolute = 2,
        WeakDefinition = 4,
        ReExport = 8,
        StubAndResolver = 0x10
    }

    private struct Node
    {
        public string Name;
        public int Offset;
    }
}

1	using System;
2	using System.Collections.Generic;
3
4	namespace LibCpp2IL.MachO;
5
6	public class MachOExportTrie
7	{
8	public List<MachOExportEntry> Entries = [];	×
9
10	private ClassReadingBinaryReader _reader;
11	private long _basePtr;
12
13	public MachOExportTrie(ClassReadingBinaryReader reader)	×
14	{
15	_reader = reader;	×
16	_basePtr = reader.BaseStream.Position;	×
17
18	var children = ParseNode("", 0);	×
19	while (children.Count > 0)	×
20	{
21	var current = children[0];	×
22	children.RemoveAt(0);	×
23	children.AddRange(ParseNode(current.Name, current.Offset));	×
24	}
25	}	×
26
27	private List<Node> ParseNode(string name, int offset)
28	{
29	var children = new List<Node>();	×
30	_reader.BaseStream.Position = _basePtr + offset;	×
31
32	var terminalSize = _reader.BaseStream.ReadLEB128Unsigned();	×
33	var childrenIndex = _reader.BaseStream.Position + (long)terminalSize;	×
34	if (terminalSize != 0)	×
35	{
36	var flags = (ExportFlags)_reader.BaseStream.ReadLEB128Unsigned();	×
NEW 37	var address = 0UL;	×
NEW 38	var other = 0UL;	×
UNCOV 39	string? importName = null;	×
40
41	if ((flags & ExportFlags.ReExport) != 0)	×
42	{
NEW 43	other = _reader.BaseStream.ReadLEB128Unsigned();	×
44	importName = _reader.ReadStringToNullAtCurrentPos();	×
45	}
46	else
47	{
NEW 48	address = _reader.BaseStream.ReadLEB128Unsigned();	×
49	if ((flags & ExportFlags.StubAndResolver) != 0)	×
NEW 50	other = _reader.BaseStream.ReadLEB128Unsigned();	×
51	}
52
NEW 53	Entries.Add(new(name, address, (ulong)flags, other, importName));	×
54	}
55
56	_reader.BaseStream.Position = childrenIndex;	×
57	var numChildren = _reader.BaseStream.ReadLEB128Unsigned();	×
58	for (var i = 0ul; i < numChildren; i++)	×
59	{
60	var childName = _reader.ReadStringToNullAtCurrentPos();	×
61	var childOffset = _reader.BaseStream.ReadLEB128Unsigned();	×
62	children.Add(new Node { Name = name + childName, Offset = (int)childOffset });	×
63	}
64
65	return children;	×
66	}
67
68	[Flags]
69	private enum ExportFlags
70	{
71	KindRegular = 0,
72	KindThreadLocal = 1,
73	KindAbsolute = 2,
74	WeakDefinition = 4,
75	ReExport = 8,
76	StubAndResolver = 0x10
77	}
78
79	private struct Node
80	{
81	public string Name;
82	public int Offset;
83	}
84	}

SamboyCoding / Cpp2IL / 14016638949

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous