13977866104

Committed 20 Mar 2025 07:34PM UTC coverage: 75.543% (+3.2%) from 72.327%

Build # 13977866104

Build Type

push

github

Committed by

tylernathanreed

Commit Message

~ Fixed and validated nested DTOs

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

71 existing lines in 35 files now uncovered.

5186 of 6865 relevant lines covered (75.54%)

9.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.06

/src/Deserializer.php

<?php

namespace Jira\Client;

use DateTimeImmutable;
use Jira\Client\Exceptions\DeserializationException;
use ReflectionClass;
use ReflectionNamedType;
use ReflectionProperty;

class Deserializer
{
    /**
     * @phpstan-template TDto of Dto
     * @param ($array is true ? list<array<string,mixed>> : array<string,mixed>) $data
     * @param class-string<TDto> $class
     * @return ($array is true ? (TDto is PolymorphicDto ? list<Dto> : list<TDto>) : (TDto is PolymorphicDto ? Dto : TDto))
     */
    public function deserialize(array $data, string $class, bool $array = false)
    {
        if ($array) {
            $values = [];

            foreach ($data as $value) {
                $values[] = self::deserialize($value, $class);
            }

            return $values;
        }

        if (is_subclass_of($class, PolymorphicDto::class)) {
            $class = $class::discriminateFromData($data);
        }

        return $this->from($class, $data);
    }

    /**
     * @phpstan-template T of Dto
     * @param class-string<T> $class
     * @param array<string,mixed> $data
     * @return T
     */
    public function from(string $class, array $data): Dto
    {
        $reflector = new ReflectionClass($class);

        $parameters = $reflector->getConstructor()?->getParameters() ?? [];

        $args = [];

        foreach ($parameters as $parameter) {
            $name = $parameter->getName();
            $key = str_starts_with($name, '_')
                ? substr($name, 1)
                : $name;

            $property = $reflector->getProperty($name);

            $value = array_key_exists($key, $data)
                ? $data[$key]
                : (
                    $parameter->isDefaultValueAvailable()
                    ? $parameter->getDefaultValue()
                    : null
                );

            $type = $parameter->getType();

            if (is_null($value)) {
                $args[] = $value;
            } elseif (is_null($type)) {
                $args[] = $value;
            } elseif (! $type instanceof ReflectionNamedType) {
                $args[] = $value;
            } elseif ($type->getName() === 'array' && is_array($value)) {
                $args[] = $this->fromArray($class, $property, $value);
            } elseif ($type->getName() === DateTimeImmutable::class && is_string($value)) {
                $args[] = new DateTimeImmutable($value);
            } elseif ($type->getName() === DateTimeImmutable::class && is_int($value)) {
                $args[] = (new DateTimeImmutable)->setTimestamp($value);
            } elseif (! $type->isBuiltin() && is_subclass_of($type->getName(), Dto::class) && is_array($value)) {
                // @phpstan-ignore argument.type
                $args[] = $this->from($type->getName(), $value);
            } else {
                $args[] = $value;
            }
        }

        return $reflector->newInstanceArgs($args);
    }

    /**
     * @param class-string<Dto> $class
     * @param array<mixed,mixed> $array
     * @return array<mixed,mixed>
     */
    protected function fromArray(string $class, ReflectionProperty $property, array $array): array
    {
        $doc = $property->getDocComment();

        if (! $doc) {
            return $array;
        }

        $var = preg_match('/@var ?\?([^ ]+)(?:\n| \*)/', $doc, $matches)
            ? $matches[1]
            : null;

        if (! $var) {
            return $array;
        }

        if (str_starts_with($var, 'list')) {
            $type = substr($var, strlen('list<'), -strlen('>'));
        } else {
            if (! preg_match('/^array<(?<key>[^>]+), ?(?<type>.+)>$/', $var, $matches)) {
                return $array;
            }

            $type = $matches['type'];
        }

        if ($type === 'mixed' || str_starts_with($type, 'list')) {
            return $array;
        }

        if (in_array($type, ['int', 'float', 'string', 'boolean'])) {
            return array_map(function ($v) use ($type) {
                settype($v, $type);
                return $v;
            }, $array);
        }

        if (class_exists($subclass = 'Jira\\Client\\Schema\\' . $type) && is_subclass_of($subclass, Dto::class)) {
            // @phpstan-ignore argument.type
            return $this->deserialize($array, $subclass, array: true);
        }

        throw new DeserializationException("Unknown class [{$subclass}] when deserializing [{$class}].");
    }
}

1	<?php
2
3	namespace Jira\Client;
4
5	use DateTimeImmutable;
6	use Jira\Client\Exceptions\DeserializationException;
7	use ReflectionClass;
8	use ReflectionNamedType;
9	use ReflectionProperty;
10
11	class Deserializer
12	{
13	/**
14	* @phpstan-template TDto of Dto
15	* @param ($array is true ? list<array<string,mixed>> : array<string,mixed>) $data
16	* @param class-string<TDto> $class
17	* @return ($array is true ? (TDto is PolymorphicDto ? list<Dto> : list<TDto>) : (TDto is PolymorphicDto ? Dto : TDto))
18	*/
19	public function deserialize(array $data, string $class, bool $array = false)	397✔
20	{
21	if ($array) {	397✔
22	$values = [];	214✔
23
24	foreach ($data as $value) {	214✔
25	$values[] = self::deserialize($value, $class);	200✔
26	}
27
28	return $values;	214✔
29	}
30
31	if (is_subclass_of($class, PolymorphicDto::class)) {	397✔
32	$class = $class::discriminateFromData($data);	1✔
33	}
34
35	return $this->from($class, $data);	397✔
36	}
37
38	/**
39	* @phpstan-template T of Dto
40	* @param class-string<T> $class
41	* @param array<string,mixed> $data
42	* @return T
43	*/
44	public function from(string $class, array $data): Dto	397✔
45	{
46	$reflector = new ReflectionClass($class);	397✔
47
48	$parameters = $reflector->getConstructor()?->getParameters() ?? [];	397✔
49
50	$args = [];	397✔
51
52	foreach ($parameters as $parameter) {	397✔
53	$name = $parameter->getName();	397✔
54	$key = str_starts_with($name, '_')	397✔
55	? substr($name, 1)	49✔
56	: $name;	397✔
57
58	$property = $reflector->getProperty($name);	397✔
59
60	$value = array_key_exists($key, $data)	397✔
61	? $data[$key]	395✔
62	: (	397✔
63	$parameter->isDefaultValueAvailable()	251✔
64	? $parameter->getDefaultValue()	251✔
65	: null	251✔
66	);	397✔
67
68	$type = $parameter->getType();	397✔
69
70	if (is_null($value)) {	397✔
71	$args[] = $value;	251✔
72	} elseif (is_null($type)) {	395✔
73	$args[] = $value;	×
74	} elseif (! $type instanceof ReflectionNamedType) {	395✔
75	$args[] = $value;	×
76	} elseif ($type->getName() === 'array' && is_array($value)) {	395✔
77	$args[] = $this->fromArray($class, $property, $value);	248✔
78	} elseif ($type->getName() === DateTimeImmutable::class && is_string($value)) {	371✔
79	$args[] = new DateTimeImmutable($value);	31✔
80	} elseif ($type->getName() === DateTimeImmutable::class && is_int($value)) {	371✔
81	$args[] = (new DateTimeImmutable)->setTimestamp($value);	4✔
82	} elseif (! $type->isBuiltin() && is_subclass_of($type->getName(), Dto::class) && is_array($value)) {	371✔
83	// @phpstan-ignore argument.type
84	$args[] = $this->from($type->getName(), $value);	140✔
85	} else {
86	$args[] = $value;	369✔
87	}
88	}
89
90	return $reflector->newInstanceArgs($args);	397✔
91	}
92
93	/**
94	* @param class-string<Dto> $class
95	* @param array<mixed,mixed> $array
96	* @return array<mixed,mixed>
97	*/
98	protected function fromArray(string $class, ReflectionProperty $property, array $array): array	248✔
99	{
100	$doc = $property->getDocComment();	248✔
101
102	if (! $doc) {	248✔
103	return $array;	×
104	}
105
106	$var = preg_match('/@var ?\?([^ ]+)(?:\n\| \*)/', $doc, $matches)	248✔
107	? $matches[1]	198✔
108	: null;	103✔
109
110	if (! $var) {	248✔
111	return $array;	103✔
112	}
113
114	if (str_starts_with($var, 'list')) {	198✔
115	$type = substr($var, strlen('list<'), -strlen('>'));	198✔
116	} else {
UNCOV 117	if (! preg_match('/^array<(?<key>[^>]+), ?(?<type>.+)>$/', $var, $matches)) {	×
UNCOV 118	return $array;	×
119	}
120
UNCOV 121	$type = $matches['type'];	×
122	}
123
124	if ($type === 'mixed' \|\| str_starts_with($type, 'list')) {	198✔
UNCOV 125	return $array;	×
126	}
127
128	if (in_array($type, ['int', 'float', 'string', 'boolean'])) {	198✔
129	return array_map(function ($v) use ($type) {	54✔
130	settype($v, $type);	48✔
131	return $v;	48✔
132	}, $array);	54✔
133	}
134
135	if (class_exists($subclass = 'Jira\\Client\\Schema\\' . $type) && is_subclass_of($subclass, Dto::class)) {	179✔
136	// @phpstan-ignore argument.type
137	return $this->deserialize($array, $subclass, array: true);	179✔
138	}
139
140	throw new DeserializationException("Unknown class [{$subclass}] when deserializing [{$class}].");	×
141	}
142	}

tylernathanreed / jira-client-php / 13977866104

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous