13906025440

Committed 17 Mar 2025 05:32PM UTC coverage: 31.197% (+0.5%) from 30.662%

Build # 13906025440

Build Type

push

github

Committed by

web-flow

Commit Message

chore: supprime useMutation et clarifie les fonctions (#1304)

* chore: supprime useMutation et clarifie les fonctions

- Renomme useGraphQL en useFetchData
- Introduit une fonction useMutateData pour mettre à jour les données pour un scope (query + variables)

* fix: articleId destructuring

* chore: ajout de tests sur le hook article

* fix: mise à jour des tags associés à l'article sur la liste des articles

* chore: adapt TagEditForm tests

Coverage Stats

462 of 677 branches covered (68.24%)

Branch coverage included in aggregate %.

165 of 341 new or added lines in 29 files covered. (48.39%)

9 existing lines in 8 files now uncovered.

4367 of 14802 relevant lines covered (29.5%)

2.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/front/src/components/collaborative/CollaborativeSessionAction.jsx

import React, { useCallback, useEffect, useMemo } from 'react'
import PropTypes from 'prop-types'
import { Badge, Modal as GeistModal, useModal } from '@geist-ui/core'
import { Users } from 'react-feather'
import { useTranslation } from 'react-i18next'
import { useHistory } from 'react-router-dom'

import { startCollaborativeSession } from '../Article.graphql'
import Button from '../Button.jsx'
import { useGraphQLClient } from '../../helpers/graphQL.js'

export default function CollaborativeSessionAction({
  collaborativeSession,
  articleId,
}) {
  const { t } = useTranslation()
  const history = useHistory()
  const { query } = useGraphQLClient()
  const {
    visible: collaborativeEditingVisible,
    setVisible: setCollaborativeEditingVisible,
    bindings: collaborativeEditingBinding,
  } = useModal()

  const handleStartCollaborativeEditing = useCallback(async () => {
    // try to start a collaborative editing
    if (collaborativeSession && collaborativeSession.id) {
      // join existing collaborative session
      history.push(`/article/${articleId}/session/${collaborativeSession.id}`)
    } else {
      // start a new collaborative session
      const data = await query({
        query: startCollaborativeSession,
        variables: { articleId },
      })
      history.push(
        `/article/${articleId}/session/${data.article.startCollaborativeSession.id}`
      )
    }
  }, [collaborativeSession])

  const collaborativeSessionDialogTitle = useMemo(
    () =>
      collaborativeSession
        ? t('article.collaborativeEditingJoin.title')
        : t('article.collaborativeEditingStart.title'),
    [collaborativeSession]
  )

  const collaborativeSessionDialogMessage = useMemo(
    () =>
      collaborativeSession
        ? t('article.collaborativeEditingJoin.confirmMessage')
        : t('article.collaborativeEditingStart.confirmMessage'),
    [collaborativeSession]
  )

  useEffect(() => {
    return () => {
      setCollaborativeEditingVisible(false)
    }
  }, [])

  return (
    <>
      <Button
        title={t(
          'collaborativeSessionAction.launchCollaborativeSessionButton.title'
        )}
        icon={true}
        onClick={() => setCollaborativeEditingVisible(true)}
      >
        <Users />
        {collaborativeSession && collaborativeSession.id && (
          <Badge type="error">Live</Badge>
        )}
      </Button>
      <GeistModal
        width="35rem"
        visible={collaborativeEditingVisible}
        {...collaborativeEditingBinding}
      >
        <h2>{collaborativeSessionDialogTitle}</h2>
        <GeistModal.Content>
          {collaborativeSessionDialogMessage}
        </GeistModal.Content>
        <GeistModal.Action
          passive
          onClick={() => setCollaborativeEditingVisible(false)}
        >
          {t('modal.cancelButton.text')}
        </GeistModal.Action>
        <GeistModal.Action onClick={handleStartCollaborativeEditing}>
          {t('modal.confirmButton.text')}
        </GeistModal.Action>
      </GeistModal>
    </>
  )
}

CollaborativeSessionAction.propTypes = {
  articleId: PropTypes.string.isRequired,
  collaborativeSession: PropTypes.shape({
    id: PropTypes.string,
  }),
}

1	import React, { useCallback, useEffect, useMemo } from 'react'	×
2	import PropTypes from 'prop-types'	×
3	import { Badge, Modal as GeistModal, useModal } from '@geist-ui/core'	×
4	import { Users } from 'react-feather'	×
5	import { useTranslation } from 'react-i18next'	×
6	import { useHistory } from 'react-router-dom'	×
7
8	import { startCollaborativeSession } from '../Article.graphql'	×
UNCOV 9	import Button from '../Button.jsx'	×
NEW 10	import { useGraphQLClient } from '../../helpers/graphQL.js'	×
11
12	export default function CollaborativeSessionAction({	×
13	collaborativeSession,	×
14	articleId,	×
15	}) {	×
16	const { t } = useTranslation()	×
17	const history = useHistory()	×
NEW 18	const { query } = useGraphQLClient()	×
19	const {	×
20	visible: collaborativeEditingVisible,	×
21	setVisible: setCollaborativeEditingVisible,	×
22	bindings: collaborativeEditingBinding,	×
23	} = useModal()	×
24
25	const handleStartCollaborativeEditing = useCallback(async () => {	×
26	// try to start a collaborative editing
27	if (collaborativeSession && collaborativeSession.id) {	×
28	// join existing collaborative session
29	history.push(`/article/${articleId}/session/${collaborativeSession.id}`)	×
30	} else {	×
31	// start a new collaborative session
NEW 32	const data = await query({	×
33	query: startCollaborativeSession,	×
34	variables: { articleId },	×
35	})	×
36	history.push(	×
37	`/article/${articleId}/session/${data.article.startCollaborativeSession.id}`	×
38	)	×
39	}	×
40	}, [collaborativeSession])	×
41
42	const collaborativeSessionDialogTitle = useMemo(	×
43	() =>	×
44	collaborativeSession	×
45	? t('article.collaborativeEditingJoin.title')	×
46	: t('article.collaborativeEditingStart.title'),	×
47	[collaborativeSession]	×
48	)	×
49
50	const collaborativeSessionDialogMessage = useMemo(	×
51	() =>	×
52	collaborativeSession	×
53	? t('article.collaborativeEditingJoin.confirmMessage')	×
54	: t('article.collaborativeEditingStart.confirmMessage'),	×
55	[collaborativeSession]	×
56	)	×
57
58	useEffect(() => {	×
59	return () => {	×
60	setCollaborativeEditingVisible(false)	×
61	}	×
62	}, [])	×
63
64	return (	×
65	<>	×
66	<Button	×
67	title={t(	×
68	'collaborativeSessionAction.launchCollaborativeSessionButton.title'	×
69	)}	×
70	icon={true}	×
71	onClick={() => setCollaborativeEditingVisible(true)}	×
72	>
73	<Users />	×
74	{collaborativeSession && collaborativeSession.id && (	×
75	<Badge type="error">Live</Badge>	×
76	)}
77	</Button>	×
78	<GeistModal	×
79	width="35rem"	×
80	visible={collaborativeEditingVisible}	×
81	{...collaborativeEditingBinding}	×
82	>
83	<h2>{collaborativeSessionDialogTitle}</h2>	×
84	<GeistModal.Content>	×
85	{collaborativeSessionDialogMessage}	×
86	</GeistModal.Content>	×
87	<GeistModal.Action	×
88	passive	×
89	onClick={() => setCollaborativeEditingVisible(false)}	×
90	>
91	{t('modal.cancelButton.text')}	×
92	</GeistModal.Action>	×
93	<GeistModal.Action onClick={handleStartCollaborativeEditing}>	×
94	{t('modal.confirmButton.text')}	×
95	</GeistModal.Action>	×
96	</GeistModal>	×
97	</>	×
98	)
99	}	×
100
101	CollaborativeSessionAction.propTypes = {	×
102	articleId: PropTypes.string.isRequired,	×
103	collaborativeSession: PropTypes.shape({	×
104	id: PropTypes.string,	×
105	}),	×
106	}	×

EcrituresNumeriques / stylo / 13906025440

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous