#3660

Committed 15 Mar 2025 09:06AM UTC coverage: 62.039% (-1.3%) from 63.314%

Build # #3660

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(stream): support stream processing for virtual tables (#30144)

* enh: add client processing

* enh: add mnode vtables processing

* enh: add mnode vtable processing

* enh: add normal child vtable support

* fix: compile issues

* fix: compile issues

* fix: create stream issues

* fix: multi stream scan issue

* fix: remove debug info

* fix: agg task and task level issues

* fix: correct task output type

* fix: split vtablescan from agg

* fix: memory leak issues

* fix: add limitations

* Update 09-error-code.md

* Update 09-error-code.md

* fix: remove usless case

* feat(stream): extract original table data in source scan task

Implemented functionality in the source task to extract data
corresponding to the virtual table from the original table using WAL.
The extracted data is then sent to the downstream merge task for further
processing.

* feat(stream): multi-way merge using loser tree in virtual merge task

Implemented multi-way merge in the merge task using a loser tree to
combine data from multiple original table into a single virtual table.
The merged virtual table data is then pushed downstream for further
processing.  Introduced memory limit handling during the merge process
with configurable behavior when the memory limit is reached.

* fix(test): remove useless cases

---------

Co-authored-by: dapan1121 <wpan@taosdata.com>
Co-authored-by: Pan Wei <72057773+dapan1121@users.noreply.github.com>

Run Details

154078 of 317582 branches covered (48.52%)

Branch coverage included in aggregate %.

313 of 2391 new or added lines in 34 files covered. (13.09%)

26134 existing lines in 205 files now uncovered.

240261 of 318051 relevant lines covered (75.54%)

16655189.27 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.92

/source/libs/sync/src/syncRequestVoteReply.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "syncRequestVoteReply.h"
#include "syncMessage.h"
#include "syncRaftStore.h"
#include "syncUtil.h"
#include "syncVoteMgr.h"

// TLA+ Spec
// HandleRequestVoteResponse(i, j, m) ==
//    \* This tallies votes even when the current state is not Candidate, but
//    \* they won't be looked at, so it doesn't matter.
//    /\ m.mterm = currentTerm[i]
//    /\ votesResponded' = [votesResponded EXCEPT ![i] =
//                              votesResponded[i] \cup {j}]
//    /\ \/ /\ m.mvoteGranted
//          /\ votesGranted' = [votesGranted EXCEPT ![i] =
//                                  votesGranted[i] \cup {j}]
//          /\ voterLog' = [voterLog EXCEPT ![i] =
//                              voterLog[i] @@ (j :> m.mlog)]
//       \/ /\ ~m.mvoteGranted
//          /\ UNCHANGED <<votesGranted, voterLog>>
//    /\ Discard(m)
//    /\ UNCHANGED <<serverVars, votedFor, leaderVars, logVars>>
//

int32_t syncNodeOnRequestVoteReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {
  int32_t               ret = 0;
  SyncRequestVoteReply* pMsg = pRpcMsg->pCont;

  // if already drop replica, do not process
  if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {
    syncLogRecvRequestVoteReply(ths, pMsg, "not in my config");

    TAOS_RETURN(TSDB_CODE_SYN_MISMATCHED_SIGNATURE);
  }
  SyncTerm currentTerm = raftStoreGetTerm(ths);
  // drop stale response
  if (pMsg->term < currentTerm) {
    syncLogRecvRequestVoteReply(ths, pMsg, "drop stale response");

    TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);
  }

  if (pMsg->term > currentTerm) {
    syncLogRecvRequestVoteReply(ths, pMsg, "error term");
    syncNodeStepDown(ths, pMsg->term, pMsg->destId);

    TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);
  }

  syncLogRecvRequestVoteReply(ths, pMsg, "");
  if (pMsg->term != currentTerm) return TSDB_CODE_SYN_INTERNAL_ERROR;

  // This tallies votes even when the current state is not Candidate,
  // but they won't be looked at, so it doesn't matter.
  if (ths->state == TAOS_SYNC_STATE_CANDIDATE) {
    if (ths->pVotesRespond->term != pMsg->term) {
      sNError(ths, "vote respond error vote-respond-mgr term:%" PRIu64 ", msg term:%" PRIu64 "",
              ths->pVotesRespond->term, pMsg->term);

      TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);
    }

    votesRespondAdd(ths->pVotesRespond, pMsg);
    if (pMsg->voteGranted) {
      // add vote
      voteGrantedVote(ths->pVotesGranted, pMsg);

      // maybe to leader
      if (voteGrantedMajority(ths->pVotesGranted)) {
        if (!ths->pVotesGranted->toLeader) {
          syncNodeCandidate2Leader(ths);

          // prevent to leader again!
          ths->pVotesGranted->toLeader = true;
        }
      }
    } else {
      ;
      // do nothing
      // UNCHANGED <<votesGranted, voterLog>>
    }
  }

  TAOS_RETURN(TSDB_CODE_SUCCESS);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "syncRequestVoteReply.h"
18	#include "syncMessage.h"
19	#include "syncRaftStore.h"
20	#include "syncUtil.h"
21	#include "syncVoteMgr.h"
22
23	// TLA+ Spec
24	// HandleRequestVoteResponse(i, j, m) ==
25	// \* This tallies votes even when the current state is not Candidate, but
26	// \* they won't be looked at, so it doesn't matter.
27	// /\ m.mterm = currentTerm[i]
28	// /\ votesResponded' = [votesResponded EXCEPT ![i] =
29	// votesResponded[i] \cup {j}]
30	// /\ \/ /\ m.mvoteGranted
31	// /\ votesGranted' = [votesGranted EXCEPT ![i] =
32	// votesGranted[i] \cup {j}]
33	// /\ voterLog' = [voterLog EXCEPT ![i] =
34	// voterLog[i] @@ (j :> m.mlog)]
35	// \/ /\ ~m.mvoteGranted
36	// /\ UNCHANGED <<votesGranted, voterLog>>
37	// /\ Discard(m)
38	// /\ UNCHANGED <<serverVars, votedFor, leaderVars, logVars>>
39	//
40
41	int32_t syncNodeOnRequestVoteReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {	1,940✔
42	int32_t ret = 0;	1,940✔
43	SyncRequestVoteReply* pMsg = pRpcMsg->pCont;	1,940✔
44
45	// if already drop replica, do not process
46	if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {	1,940!
47	syncLogRecvRequestVoteReply(ths, pMsg, "not in my config");	×
48
49	TAOS_RETURN(TSDB_CODE_SYN_MISMATCHED_SIGNATURE);	×
50	}
51	SyncTerm currentTerm = raftStoreGetTerm(ths);	1,940✔
52	// drop stale response
53	if (pMsg->term < currentTerm) {	1,940!
UNCOV 54	syncLogRecvRequestVoteReply(ths, pMsg, "drop stale response");	×
55
UNCOV 56	TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);	×
57	}
58
59	if (pMsg->term > currentTerm) {	1,940✔
60	syncLogRecvRequestVoteReply(ths, pMsg, "error term");	10✔
61	syncNodeStepDown(ths, pMsg->term, pMsg->destId);	10✔
62
63	TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);	10✔
64	}
65
66	syncLogRecvRequestVoteReply(ths, pMsg, "");	1,930✔
67	if (pMsg->term != currentTerm) return TSDB_CODE_SYN_INTERNAL_ERROR;	1,930!
68
69	// This tallies votes even when the current state is not Candidate,
70	// but they won't be looked at, so it doesn't matter.
71	if (ths->state == TAOS_SYNC_STATE_CANDIDATE) {	1,930✔
72	if (ths->pVotesRespond->term != pMsg->term) {	1,207!
73	sNError(ths, "vote respond error vote-respond-mgr term:%" PRIu64 ", msg term:%" PRIu64 "",	×
74	ths->pVotesRespond->term, pMsg->term);
75
76	TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);	×
77	}
78
79	votesRespondAdd(ths->pVotesRespond, pMsg);	1,207✔
80	if (pMsg->voteGranted) {	1,207✔
81	// add vote
82	voteGrantedVote(ths->pVotesGranted, pMsg);	1,049✔
83
84	// maybe to leader
85	if (voteGrantedMajority(ths->pVotesGranted)) {	1,049✔
86	if (!ths->pVotesGranted->toLeader) {	961!
87	syncNodeCandidate2Leader(ths);	961✔
88
89	// prevent to leader again!
90	ths->pVotesGranted->toLeader = true;	961✔
91	}
92	}
93	} else {
94	;
95	// do nothing
96	// UNCHANGED <<votesGranted, voterLog>>
97	}
98	}
99
100	TAOS_RETURN(TSDB_CODE_SUCCESS);	1,930✔
101	}

taosdata / TDengine / #3660

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous