• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3656

14 Mar 2025 08:10AM UTC coverage: 62.841% (+3.3%) from 59.532%
#3656

push

travis-ci

web-flow
feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

147682 of 302527 branches covered (48.82%)

Branch coverage included in aggregate %.

88 of 99 new or added lines in 12 files covered. (88.89%)

3177 existing lines in 34 files now uncovered.

232747 of 302857 relevant lines covered (76.85%)

5880306.3 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.92
/source/dnode/mnode/impl/src/mndStb.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "audit.h"
18
#include "mndDb.h"
19
#include "mndDnode.h"
20
#include "mndIndex.h"
21
#include "mndIndexComm.h"
22
#include "mndInfoSchema.h"
23
#include "mndMnode.h"
24
#include "mndPerfSchema.h"
25
#include "mndPrivilege.h"
26
#include "mndScheduler.h"
27
#include "mndShow.h"
28
#include "mndSma.h"
29
#include "mndStb.h"
30
#include "mndTopic.h"
31
#include "mndTrans.h"
32
#include "mndUser.h"
33
#include "mndVgroup.h"
34
#include "tname.h"
35

36
#define STB_VER_NUMBER   2
37
#define STB_RESERVE_SIZE 56
38

39
static SSdbRow *mndStbActionDecode(SSdbRaw *pRaw);
40
static int32_t  mndStbActionInsert(SSdb *pSdb, SStbObj *pStb);
41
static int32_t  mndStbActionDelete(SSdb *pSdb, SStbObj *pStb);
42
static int32_t  mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew);
43
static int32_t  mndProcessTtlTimer(SRpcMsg *pReq);
44
static int32_t  mndProcessTrimDbTimer(SRpcMsg *pReq);
45
static int32_t  mndProcessS3MigrateDbTimer(SRpcMsg *pReq);
46
static int32_t  mndProcessS3MigrateDbRsp(SRpcMsg *pReq);
47
static int32_t  mndProcessCreateStbReq(SRpcMsg *pReq);
48
static int32_t  mndProcessAlterStbReq(SRpcMsg *pReq);
49
static int32_t  mndProcessDropStbReq(SRpcMsg *pReq);
50
static int32_t  mndProcessDropTtltbRsp(SRpcMsg *pReq);
51
static int32_t  mndProcessTrimDbRsp(SRpcMsg *pReq);
52
static int32_t  mndProcessTableMetaReq(SRpcMsg *pReq);
53
static int32_t  mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
54
static int32_t  mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
55
static void     mndCancelGetNextStb(SMnode *pMnode, void *pIter);
56
static int32_t  mndProcessTableCfgReq(SRpcMsg *pReq);
57
static int32_t  mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
58
                               void *alterOriData, int32_t alterOriDataLen);
59
static int32_t  mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
60
                                              void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter);
61

62
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq);
63
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq);
64

65
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq);
66
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq);
67
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pReq);
68

69
int32_t mndInitStb(SMnode *pMnode) {
1,794✔
70
  SSdbTable table = {
1,794✔
71
      .sdbType = SDB_STB,
72
      .keyType = SDB_KEY_BINARY,
73
      .encodeFp = (SdbEncodeFp)mndStbActionEncode,
74
      .decodeFp = (SdbDecodeFp)mndStbActionDecode,
75
      .insertFp = (SdbInsertFp)mndStbActionInsert,
76
      .updateFp = (SdbUpdateFp)mndStbActionUpdate,
77
      .deleteFp = (SdbDeleteFp)mndStbActionDelete,
78
  };
79

80
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_STB, mndProcessCreateStbReq);
1,794✔
81
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_STB, mndProcessAlterStbReq);
1,794✔
82
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_STB, mndProcessDropStbReq);
1,794✔
83
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_STB_RSP, mndTransProcessRsp);
1,794✔
84
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TTL_TABLE_RSP, mndProcessDropTtltbRsp);
1,794✔
85
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_RSP, mndProcessTrimDbRsp);
1,794✔
86
  mndSetMsgHandle(pMnode, TDMT_VND_ALTER_STB_RSP, mndTransProcessRsp);
1,794✔
87
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_STB_RSP, mndTransProcessRsp);
1,794✔
88
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_META, mndProcessTableMetaReq);
1,794✔
89
  mndSetMsgHandle(pMnode, TDMT_MND_TTL_TIMER, mndProcessTtlTimer);
1,794✔
90
  mndSetMsgHandle(pMnode, TDMT_MND_TRIM_DB_TIMER, mndProcessTrimDbTimer);
1,794✔
91
  mndSetMsgHandle(pMnode, TDMT_VND_S3MIGRATE_RSP, mndProcessS3MigrateDbRsp);
1,794✔
92
  mndSetMsgHandle(pMnode, TDMT_MND_S3MIGRATE_DB_TIMER, mndProcessS3MigrateDbTimer);
1,794✔
93
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_CFG, mndProcessTableCfgReq);
1,794✔
94
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP, mndProcessDropStbReqFromMNode);
1,794✔
95
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP_RSP, mndTransProcessRsp);
1,794✔
96
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_TB_WITH_TSMA, mndProcessDropTbWithTsma);
1,794✔
97
  mndSetMsgHandle(pMnode, TDMT_VND_FETCH_TTL_EXPIRED_TBS_RSP, mndProcessFetchTtlExpiredTbs);
1,794✔
98
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TABLE_RSP, mndTransProcessRsp);
1,794✔
99
  //  mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveStbReq);
100

101
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIndexReq);
102
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIndexReq);
103
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
104
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
105

106
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_STB, mndRetrieveStb);
1,794✔
107
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_STB, mndCancelGetNextStb);
1,794✔
108

109
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COL, mndRetrieveStbCol);
1,794✔
110
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_COL, mndCancelGetNextStb);
1,794✔
111

112
  return sdbSetTable(pMnode->pSdb, table);
1,794✔
113
}
114

115
void mndCleanupStb(SMnode *pMnode) {}
1,793✔
116

117
SSdbRaw *mndStbActionEncode(SStbObj *pStb) {
24,416✔
118
  int32_t code = 0;
24,416✔
119
  int32_t lino = 0;
24,416✔
120
  terrno = TSDB_CODE_OUT_OF_MEMORY;
24,416✔
121

122
  int32_t size = sizeof(SStbObj) + (pStb->numOfColumns + pStb->numOfTags) * sizeof(SSchema) + pStb->commentLen +
48,832✔
123
                 pStb->ast1Len + pStb->ast2Len + pStb->numOfColumns * sizeof(SColCmpr) + STB_RESERVE_SIZE +
48,832✔
124
                 taosArrayGetSize(pStb->pFuncs) * TSDB_FUNC_NAME_LEN;
24,416✔
125
  SSdbRaw *pRaw = sdbAllocRaw(SDB_STB, STB_VER_NUMBER, size);
24,416✔
126
  if (pRaw == NULL) goto _OVER;
24,416!
127

128
  int32_t dataPos = 0;
24,416✔
129
  SDB_SET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
24,416!
130
  SDB_SET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
24,416!
131
  SDB_SET_INT64(pRaw, dataPos, pStb->createdTime, _OVER)
24,416!
132
  SDB_SET_INT64(pRaw, dataPos, pStb->updateTime, _OVER)
24,416!
133
  SDB_SET_INT64(pRaw, dataPos, pStb->uid, _OVER)
24,416!
134
  SDB_SET_INT64(pRaw, dataPos, pStb->dbUid, _OVER)
24,416!
135
  SDB_SET_INT32(pRaw, dataPos, pStb->tagVer, _OVER)
24,416!
136
  SDB_SET_INT32(pRaw, dataPos, pStb->colVer, _OVER)
24,416!
137
  SDB_SET_INT32(pRaw, dataPos, pStb->smaVer, _OVER)
24,416!
138
  SDB_SET_INT32(pRaw, dataPos, pStb->nextColId, _OVER)
24,416!
139
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[0], _OVER)
24,416!
140
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[1], _OVER)
24,416!
141
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[0], _OVER)
24,416!
142
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[1], _OVER)
24,416!
143
  SDB_SET_INT32(pRaw, dataPos, pStb->ttl, _OVER)
24,416!
144
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfColumns, _OVER)
24,416!
145
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfTags, _OVER)
24,416!
146
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfFuncs, _OVER)
24,416!
147
  SDB_SET_INT32(pRaw, dataPos, pStb->commentLen, _OVER)
24,416!
148
  SDB_SET_INT32(pRaw, dataPos, pStb->ast1Len, _OVER)
24,416!
149
  SDB_SET_INT32(pRaw, dataPos, pStb->ast2Len, _OVER)
24,416!
150

151
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
2,679,744✔
152
    SSchema *pSchema = &pStb->pColumns[i];
2,655,328✔
153
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
2,655,328!
154
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
2,655,328!
155
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
2,655,328!
156
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
2,655,328!
157
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
2,655,328!
158
  }
159

160
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
273,319✔
161
    SSchema *pSchema = &pStb->pTags[i];
248,903✔
162
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
248,903!
163
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
248,903!
164
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
248,903!
165
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
248,903!
166
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
248,903!
167
  }
168

169
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
24,428✔
170
    char *func = taosArrayGet(pStb->pFuncs, i);
12✔
171
    SDB_SET_BINARY(pRaw, dataPos, func, TSDB_FUNC_NAME_LEN, _OVER)
12!
172
  }
173

174
  if (pStb->commentLen > 0) {
24,416✔
175
    SDB_SET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
173!
176
  }
177

178
  if (pStb->ast1Len > 0) {
24,416✔
179
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
12!
180
  }
181

182
  if (pStb->ast2Len > 0) {
24,416✔
183
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
12!
184
  }
185

186
  if (pStb->pCmpr != NULL) {
24,416!
187
    for (int i = 0; i < pStb->numOfColumns; i++) {
2,679,744✔
188
      SColCmpr *p = &pStb->pCmpr[i];
2,655,328✔
189
      SDB_SET_INT16(pRaw, dataPos, p->id, _OVER)
2,655,328!
190
      SDB_SET_INT32(pRaw, dataPos, p->alg, _OVER)
2,655,328!
191
    }
192
  }
193
  SDB_SET_INT64(pRaw, dataPos, pStb->keep, _OVER)
24,416!
194

195
  SDB_SET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
24,416!
196
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
24,416!
197

198
  terrno = 0;
24,416✔
199

200
_OVER:
24,416✔
201
  if (terrno != 0) {
24,416!
UNCOV
202
    mError("stb:%s, failed to encode to raw:%p since %s", pStb->name, pRaw, terrstr());
×
UNCOV
203
    sdbFreeRaw(pRaw);
×
204
    return NULL;
×
205
  }
206

207
  mTrace("stb:%s, encode to raw:%p, row:%p", pStb->name, pRaw, pStb);
24,416✔
208
  return pRaw;
24,416✔
209
}
210

211
static SSdbRow *mndStbActionDecode(SSdbRaw *pRaw) {
28,052✔
212
  int32_t code = 0;
28,052✔
213
  int32_t lino = 0;
28,052✔
214
  terrno = TSDB_CODE_OUT_OF_MEMORY;
28,052✔
215
  SSdbRow *pRow = NULL;
28,052✔
216
  SStbObj *pStb = NULL;
28,052✔
217

218
  int8_t sver = 0;
28,052✔
219
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
28,052!
220

221
  if (sver > STB_VER_NUMBER) {
28,052!
UNCOV
222
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
UNCOV
223
    goto _OVER;
×
224
  }
225

226
  pRow = sdbAllocRow(sizeof(SStbObj));
28,052✔
227
  if (pRow == NULL) goto _OVER;
28,052!
228

229
  pStb = sdbGetRowObj(pRow);
28,052✔
230
  if (pStb == NULL) goto _OVER;
28,052!
231

232
  int32_t dataPos = 0;
28,052✔
233
  SDB_GET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
28,052!
234
  SDB_GET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
28,052!
235
  SDB_GET_INT64(pRaw, dataPos, &pStb->createdTime, _OVER)
28,052!
236
  SDB_GET_INT64(pRaw, dataPos, &pStb->updateTime, _OVER)
28,052!
237
  SDB_GET_INT64(pRaw, dataPos, &pStb->uid, _OVER)
28,052!
238
  SDB_GET_INT64(pRaw, dataPos, &pStb->dbUid, _OVER)
28,052!
239
  SDB_GET_INT32(pRaw, dataPos, &pStb->tagVer, _OVER)
28,052!
240
  SDB_GET_INT32(pRaw, dataPos, &pStb->colVer, _OVER)
28,052!
241
  SDB_GET_INT32(pRaw, dataPos, &pStb->smaVer, _OVER)
28,052!
242
  SDB_GET_INT32(pRaw, dataPos, &pStb->nextColId, _OVER)
28,052!
243
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[0], _OVER)
28,052!
244
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[1], _OVER)
28,052!
245
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[0], _OVER)
28,052!
246
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[1], _OVER)
28,052!
247
  SDB_GET_INT32(pRaw, dataPos, &pStb->ttl, _OVER)
28,052!
248
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfColumns, _OVER)
28,052!
249
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfTags, _OVER)
28,052!
250
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfFuncs, _OVER)
28,052!
251
  SDB_GET_INT32(pRaw, dataPos, &pStb->commentLen, _OVER)
28,052!
252
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast1Len, _OVER)
28,052!
253
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast2Len, _OVER)
28,052!
254

255
  pStb->pColumns = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchema));
28,052!
256
  pStb->pTags = taosMemoryCalloc(pStb->numOfTags, sizeof(SSchema));
28,052!
257
  pStb->pFuncs = taosArrayInit(pStb->numOfFuncs, TSDB_FUNC_NAME_LEN);
28,052✔
258
  if (pStb->pColumns == NULL || pStb->pTags == NULL || pStb->pFuncs == NULL) {
28,052!
UNCOV
259
    goto _OVER;
×
260
  }
261

262
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
6,866,067✔
263
    SSchema *pSchema = &pStb->pColumns[i];
6,838,015✔
264
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
6,838,015!
265
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
6,838,015!
266
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
6,838,015!
267
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
6,838,015!
268
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
6,838,015!
269
  }
270

271
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
580,870✔
272
    SSchema *pSchema = &pStb->pTags[i];
552,818✔
273
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
552,818!
274
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
552,818!
275
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
552,818!
276
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
552,818!
277
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
552,818!
278
  }
279

280
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
28,062✔
281
    char funcName[TSDB_FUNC_NAME_LEN] = {0};
10✔
282
    SDB_GET_BINARY(pRaw, dataPos, funcName, TSDB_FUNC_NAME_LEN, _OVER)
10!
283
    if (taosArrayPush(pStb->pFuncs, funcName) == NULL) goto _OVER;
20!
284
  }
285

286
  if (pStb->commentLen > 0) {
28,052✔
287
    pStb->comment = taosMemoryCalloc(pStb->commentLen + 1, 1);
154!
288
    if (pStb->comment == NULL) goto _OVER;
154!
289
    SDB_GET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
154!
290
  }
291

292
  if (pStb->ast1Len > 0) {
28,052✔
293
    pStb->pAst1 = taosMemoryCalloc(pStb->ast1Len, 1);
10!
294
    if (pStb->pAst1 == NULL) goto _OVER;
10!
295
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
10!
296
  }
297

298
  if (pStb->ast2Len > 0) {
28,052✔
299
    pStb->pAst2 = taosMemoryCalloc(pStb->ast2Len, 1);
10!
300
    if (pStb->pAst2 == NULL) goto _OVER;
10!
301
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
10!
302
  }
303

304
  pStb->pCmpr = taosMemoryCalloc(pStb->numOfColumns, sizeof(SColCmpr));
28,052!
305
  if (sver < STB_VER_NUMBER) {
28,052!
306
    // compatible with old data, setup default compress value
307
    // impl later
UNCOV
308
    for (int i = 0; i < pStb->numOfColumns; i++) {
×
UNCOV
309
      SSchema  *pSchema = &pStb->pColumns[i];
×
310
      SColCmpr *pCmpr = &pStb->pCmpr[i];
×
311
      pCmpr->id = pSchema->colId;
×
312
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
×
313
    }
314
  } else {
315
    for (int i = 0; i < pStb->numOfColumns; i++) {
6,866,067✔
316
      SColCmpr *pCmpr = &pStb->pCmpr[i];
6,838,015✔
317
      SDB_GET_INT16(pRaw, dataPos, &pCmpr->id, _OVER)
6,838,015!
318
      SDB_GET_INT32(pRaw, dataPos, (int32_t *)&pCmpr->alg, _OVER)  // compatiable
6,838,015!
319
    }
320
  }
321
  SDB_GET_INT64(pRaw, dataPos, &pStb->keep, _OVER)
28,052!
322

323
  SDB_GET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
28,052!
324

325
  terrno = 0;
28,052✔
326

327
_OVER:
28,052✔
328
  if (terrno != 0) {
28,052!
UNCOV
329
    mError("stb:%s, failed to decode from raw:%p since %s", pStb == NULL ? "null" : pStb->name, pRaw, terrstr());
×
UNCOV
330
    if (pStb != NULL) {
×
UNCOV
331
      taosMemoryFreeClear(pStb->pColumns);
×
332
      taosMemoryFreeClear(pStb->pTags);
×
333
      taosMemoryFreeClear(pStb->comment);
×
334
      taosMemoryFree(pStb->pCmpr);
×
335
    }
336
    taosMemoryFreeClear(pRow);
×
337
    return NULL;
×
338
  }
339

340
  mTrace("stb:%s, decode from raw:%p, row:%p", pStb->name, pRaw, pStb);
28,052✔
341
  return pRow;
28,052✔
342
}
343

344
void mndFreeStb(SStbObj *pStb) {
35,274✔
345
  taosArrayDestroy(pStb->pFuncs);
35,274✔
346
  taosMemoryFreeClear(pStb->pColumns);
35,274!
347
  taosMemoryFreeClear(pStb->pTags);
35,274!
348
  taosMemoryFreeClear(pStb->comment);
35,274!
349
  taosMemoryFreeClear(pStb->pAst1);
35,274!
350
  taosMemoryFreeClear(pStb->pAst2);
35,274!
351
  taosMemoryFreeClear(pStb->pCmpr);
35,274!
352
}
35,274✔
353

354
static int32_t mndStbActionInsert(SSdb *pSdb, SStbObj *pStb) {
9,499✔
355
  mTrace("stb:%s, perform insert action, row:%p", pStb->name, pStb);
9,499✔
356
  return 0;
9,499✔
357
}
358

359
static int32_t mndStbActionDelete(SSdb *pSdb, SStbObj *pStb) {
33,698✔
360
  mTrace("stb:%s, perform delete action, row:%p", pStb->name, pStb);
33,698✔
361
  mndFreeStb(pStb);
33,698✔
362
  return 0;
33,698✔
363
}
364

365
static int32_t mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew) {
14,854✔
366
  mTrace("stb:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
14,854✔
367

368
  taosWLockLatch(&pOld->lock);
14,854✔
369
  int32_t numOfColumns = pOld->numOfColumns;
14,854✔
370
  if (pOld->numOfColumns < pNew->numOfColumns) {
14,854✔
371
    void *pColumns = taosMemoryMalloc(pNew->numOfColumns * sizeof(SSchema));
3,210!
372
    if (pColumns != NULL) {
3,210!
373
      taosMemoryFree(pOld->pColumns);
3,210!
374
      pOld->pColumns = pColumns;
3,210✔
375
    } else {
UNCOV
376
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
377
      mTrace("stb:%s, failed to perform update action since %s", pOld->name, terrstr());
×
UNCOV
378
      taosWUnLockLatch(&pOld->lock);
×
379
    }
380
  }
381

382
  if (pOld->numOfTags < pNew->numOfTags) {
14,854✔
383
    void *pTags = taosMemoryMalloc(pNew->numOfTags * sizeof(SSchema));
1,002!
384
    if (pTags != NULL) {
1,002!
385
      taosMemoryFree(pOld->pTags);
1,002!
386
      pOld->pTags = pTags;
1,002✔
387
    } else {
UNCOV
388
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
389
      mTrace("stb:%s, failed to perform update action since %s", pOld->name, terrstr());
×
UNCOV
390
      taosWUnLockLatch(&pOld->lock);
×
391
    }
392
  }
393

394
  if (pOld->commentLen < pNew->commentLen && pNew->commentLen > 0) {
14,854!
395
    void *comment = taosMemoryMalloc(pNew->commentLen + 1);
17!
396
    if (comment != NULL) {
17!
397
      taosMemoryFree(pOld->comment);
17!
398
      pOld->comment = comment;
17✔
399
    } else {
UNCOV
400
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
401
      mTrace("stb:%s, failed to perform update action since %s", pOld->name, terrstr());
×
UNCOV
402
      taosWUnLockLatch(&pOld->lock);
×
403
    }
404
  }
405
  pOld->commentLen = pNew->commentLen;
14,854✔
406

407
  if (pOld->ast1Len < pNew->ast1Len) {
14,854!
UNCOV
408
    void *pAst1 = taosMemoryMalloc(pNew->ast1Len + 1);
×
UNCOV
409
    if (pAst1 != NULL) {
×
UNCOV
410
      taosMemoryFree(pOld->pAst1);
×
411
      pOld->pAst1 = pAst1;
×
412
    } else {
413
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
414
      mTrace("stb:%s, failed to perform update action since %s", pOld->name, terrstr());
×
UNCOV
415
      taosWUnLockLatch(&pOld->lock);
×
416
    }
417
  }
418

419
  if (pOld->ast2Len < pNew->ast2Len) {
14,854!
UNCOV
420
    void *pAst2 = taosMemoryMalloc(pNew->ast2Len + 1);
×
UNCOV
421
    if (pAst2 != NULL) {
×
UNCOV
422
      taosMemoryFree(pOld->pAst2);
×
423
      pOld->pAst2 = pAst2;
×
424
    } else {
425
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
426
      mTrace("stb:%s, failed to perform update action since %s", pOld->name, terrstr());
×
UNCOV
427
      taosWUnLockLatch(&pOld->lock);
×
428
    }
429
  }
430

431
  pOld->updateTime = pNew->updateTime;
14,854✔
432
  pOld->tagVer = pNew->tagVer;
14,854✔
433
  pOld->colVer = pNew->colVer;
14,854✔
434
  pOld->smaVer = pNew->smaVer;
14,854✔
435
  pOld->nextColId = pNew->nextColId;
14,854✔
436
  pOld->ttl = pNew->ttl;
14,854✔
437
  pOld->keep = pNew->keep;
14,854✔
438
  
439
  if (pNew->numOfColumns > 0) {
14,854✔
440
    pOld->numOfColumns = pNew->numOfColumns;
14,811✔
441
    memcpy(pOld->pColumns, pNew->pColumns, pOld->numOfColumns * sizeof(SSchema));
14,811✔
442
  }
443
  if (pNew->numOfTags > 0) {
14,854✔
444
    pOld->numOfTags = pNew->numOfTags;
14,811✔
445
    memcpy(pOld->pTags, pNew->pTags, pOld->numOfTags * sizeof(SSchema));
14,811✔
446
  }
447
  if (pNew->commentLen > 0) {
14,854✔
448
    memcpy(pOld->comment, pNew->comment, pNew->commentLen + 1);
131✔
449
    pOld->commentLen = pNew->commentLen;
131✔
450
  }
451
  if (pNew->ast1Len != 0) {
14,854!
UNCOV
452
    memcpy(pOld->pAst1, pNew->pAst1, pNew->ast1Len);
×
UNCOV
453
    pOld->ast1Len = pNew->ast1Len;
×
454
  }
455
  if (pNew->ast2Len != 0) {
14,854!
UNCOV
456
    memcpy(pOld->pAst2, pNew->pAst2, pNew->ast2Len);
×
457
    pOld->ast2Len = pNew->ast2Len;
×
458
  }
459
  if (numOfColumns < pNew->numOfColumns) {
14,854✔
460
    taosMemoryFree(pOld->pCmpr);
3,210!
461
    pOld->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
3,210!
462
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
3,210✔
463
  } else {
464
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
11,644✔
465
  }
466

467
  taosWUnLockLatch(&pOld->lock);
14,854✔
468
  return 0;
14,854✔
469
}
470

471
SStbObj *mndAcquireStb(SMnode *pMnode, char *stbName) {
45,468✔
472
  SSdb    *pSdb = pMnode->pSdb;
45,468✔
473
  SStbObj *pStb = sdbAcquire(pSdb, SDB_STB, stbName);
45,468✔
474
  if (pStb == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
45,468!
475
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
14,308✔
476
  }
477
  return pStb;
45,468✔
478
}
479

480
void mndReleaseStb(SMnode *pMnode, SStbObj *pStb) {
38,695✔
481
  SSdb *pSdb = pMnode->pSdb;
38,695✔
482
  sdbRelease(pSdb, pStb);
38,695✔
483
}
38,695✔
484

485
SDbObj *mndAcquireDbByStb(SMnode *pMnode, const char *stbName) {
12,547✔
486
  SName name = {0};
12,547✔
487
  if ((terrno = tNameFromString(&name, stbName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) return NULL;
12,547!
488

489
  char db[TSDB_TABLE_FNAME_LEN] = {0};
12,547✔
490
  if ((terrno = tNameGetFullDbName(&name, db)) != 0) return NULL;
12,547!
491

492
  return mndAcquireDb(pMnode, db);
12,547✔
493
}
494

495
static FORCE_INLINE int32_t schemaExColIdCompare(const void *colId, const void *pSchema) {
496
  if (*(col_id_t *)colId < ((SSchema *)pSchema)->colId) {
497
    return -1;
498
  } else if (*(col_id_t *)colId > ((SSchema *)pSchema)->colId) {
499
    return 1;
500
  }
501
  return 0;
502
}
503

504
void *mndBuildVCreateStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen, void *alterOriData,
24,780✔
505
                            int32_t alterOriDataLen) {
506
  SEncoder       encoder = {0};
24,780✔
507
  int32_t        contLen;
508
  SName          name = {0};
24,780✔
509
  SVCreateStbReq req = {0};
24,780✔
510

511
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
24,780!
UNCOV
512
    goto _err;
×
513
  }
514
  char dbFName[TSDB_DB_FNAME_LEN] = {0};
24,780✔
515
  if ((terrno = tNameGetFullDbName(&name, dbFName)) != 0) {
24,780!
UNCOV
516
    goto _err;
×
517
  };
518

519
  req.name = (char *)tNameGetTableName(&name);
24,780✔
520
  req.suid = pStb->uid;
24,780✔
521
  req.rollup = pStb->ast1Len > 0 ? 1 : 0;
24,780✔
522
  req.alterOriData = alterOriData;
24,780✔
523
  req.alterOriDataLen = alterOriDataLen;
24,780✔
524
  req.source = pStb->source;
24,780✔
525
  // todo
526
  req.schemaRow.nCols = pStb->numOfColumns;
24,780✔
527
  req.schemaRow.version = pStb->colVer;
24,780✔
528
  req.schemaRow.pSchema = pStb->pColumns;
24,780✔
529
  req.schemaTag.nCols = pStb->numOfTags;
24,780✔
530
  req.schemaTag.version = pStb->tagVer;
24,780✔
531
  req.schemaTag.pSchema = pStb->pTags;
24,780✔
532

533
  req.colCmpred = 1;
24,780✔
534
  SColCmprWrapper *pCmpr = &req.colCmpr;
24,780✔
535
  req.keep = pStb->keep;
24,780✔
536
  pCmpr->version = pStb->colVer;
24,780✔
537
  pCmpr->nCols = pStb->numOfColumns;
24,780✔
538

539
  req.colCmpr.pColCmpr = taosMemoryCalloc(pCmpr->nCols, sizeof(SColCmpr));
24,780!
540
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
2,557,419✔
541
    SColCmpr *p = &pCmpr->pColCmpr[i];
2,532,639✔
542
    p->alg = pStb->pCmpr[i].alg;
2,532,639✔
543
    p->id = pStb->pCmpr[i].id;
2,532,639✔
544
  }
545

546
  if (req.rollup) {
24,780✔
547
    req.rsmaParam.maxdelay[0] = pStb->maxdelay[0];
4✔
548
    req.rsmaParam.maxdelay[1] = pStb->maxdelay[1];
4✔
549
    req.rsmaParam.watermark[0] = pStb->watermark[0];
4✔
550
    req.rsmaParam.watermark[1] = pStb->watermark[1];
4✔
551
    if (pStb->ast1Len > 0) {
4!
552
      if (mndConvertRsmaTask(&req.rsmaParam.qmsg[0], &req.rsmaParam.qmsgLen[0], pStb->pAst1, pStb->uid,
4!
553
                             STREAM_TRIGGER_WINDOW_CLOSE, req.rsmaParam.watermark[0],
554
                             req.rsmaParam.deleteMark[0]) < 0) {
UNCOV
555
        goto _err;
×
556
      }
557
    }
558
    if (pStb->ast2Len > 0) {
4!
559
      if (mndConvertRsmaTask(&req.rsmaParam.qmsg[1], &req.rsmaParam.qmsgLen[1], pStb->pAst2, pStb->uid,
4!
560
                             STREAM_TRIGGER_WINDOW_CLOSE, req.rsmaParam.watermark[1],
561
                             req.rsmaParam.deleteMark[1]) < 0) {
UNCOV
562
        goto _err;
×
563
      }
564
    }
565
  }
566
  // get length
567
  int32_t ret = 0;
24,780✔
568
  tEncodeSize(tEncodeSVCreateStbReq, &req, contLen, ret);
24,780!
569
  if (ret < 0) {
24,780!
UNCOV
570
    goto _err;
×
571
  }
572

573
  contLen += sizeof(SMsgHead);
24,780✔
574

575
  SMsgHead *pHead = taosMemoryCalloc(1, contLen);
24,780!
576
  if (pHead == NULL) {
24,780!
UNCOV
577
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
578
    goto _err;
×
579
  }
580

581
  pHead->contLen = htonl(contLen);
24,780✔
582
  pHead->vgId = htonl(pVgroup->vgId);
24,780✔
583

584
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
24,780✔
585
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
24,780✔
586
  if (tEncodeSVCreateStbReq(&encoder, &req) < 0) {
24,780!
UNCOV
587
    taosMemoryFreeClear(pHead);
×
UNCOV
588
    tEncoderClear(&encoder);
×
UNCOV
589
    goto _err;
×
590
  }
591
  tEncoderClear(&encoder);
24,780✔
592

593
  *pContLen = contLen;
24,780✔
594
  taosMemoryFreeClear(req.rsmaParam.qmsg[0]);
24,780!
595
  taosMemoryFreeClear(req.rsmaParam.qmsg[1]);
24,780!
596
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
24,780!
597
  return pHead;
24,780✔
UNCOV
598
_err:
×
UNCOV
599
  taosMemoryFreeClear(req.rsmaParam.qmsg[0]);
×
UNCOV
600
  taosMemoryFreeClear(req.rsmaParam.qmsg[1]);
×
UNCOV
601
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
×
UNCOV
602
  return NULL;
×
603
}
604

605
static void *mndBuildVDropStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen) {
19,746✔
606
  SName        name = {0};
19,746✔
607
  SVDropStbReq req = {0};
19,746✔
608
  int32_t      contLen = 0;
19,746✔
609
  int32_t      ret = 0;
19,746✔
610
  SMsgHead    *pHead = NULL;
19,746✔
611
  SEncoder     encoder = {0};
19,746✔
612

613
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
19,746!
UNCOV
614
    return NULL;
×
615
  }
616

617
  req.name = (char *)tNameGetTableName(&name);
19,746✔
618
  req.suid = pStb->uid;
19,746✔
619

620
  tEncodeSize(tEncodeSVDropStbReq, &req, contLen, ret);
19,746!
621
  if (ret < 0) return NULL;
19,746!
622

623
  contLen += sizeof(SMsgHead);
19,746✔
624
  pHead = taosMemoryMalloc(contLen);
19,746!
625
  if (pHead == NULL) {
19,746!
UNCOV
626
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
627
    return NULL;
×
628
  }
629

630
  pHead->contLen = htonl(contLen);
19,746✔
631
  pHead->vgId = htonl(pVgroup->vgId);
19,746✔
632

633
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
19,746✔
634

635
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
19,746✔
636
  int32_t code = tEncodeSVDropStbReq(&encoder, &req);
19,746✔
637
  tEncoderClear(&encoder);
19,746✔
638
  if (code != 0) {
19,746!
UNCOV
639
    terrno = code;
×
UNCOV
640
    return NULL;
×
641
  }
642

643
  *pContLen = contLen;
19,746✔
644
  return pHead;
19,746✔
645
}
646

647
int32_t mndCheckCreateStbReq(SMCreateStbReq *pCreate) {
7,378✔
648
  int32_t code = 0;
7,378✔
649
  if (pCreate->igExists < 0 || pCreate->igExists > 1) {
7,378!
UNCOV
650
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
651
    TAOS_RETURN(code);
×
652
  }
653

654
  if (pCreate->numOfColumns < TSDB_MIN_COLUMNS || pCreate->numOfTags + pCreate->numOfColumns > TSDB_MAX_COLUMNS) {
7,378!
UNCOV
655
    code = TSDB_CODE_PAR_INVALID_COLUMNS_NUM;
×
656
    TAOS_RETURN(code);
×
657
  }
658

659
  if (pCreate->numOfTags <= 0 || pCreate->numOfTags > TSDB_MAX_TAGS) {
7,378!
UNCOV
660
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
661
    TAOS_RETURN(code);
×
662
  }
663

664
  SField *pField = taosArrayGet(pCreate->pColumns, 0);
7,378✔
665
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
7,378!
666
    code = TSDB_CODE_PAR_INVALID_FIRST_COLUMN;
×
667
    TAOS_RETURN(code);
×
668
  }
669

670
  for (int32_t i = 0; i < pCreate->numOfColumns; ++i) {
163,053✔
671
    SFieldWithOptions *pField1 = taosArrayGet(pCreate->pColumns, i);
155,675✔
672
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
155,675!
673
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
674
      TAOS_RETURN(code);
×
675
    }
676
    if (pField1->bytes <= 0) {
155,675!
UNCOV
677
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
678
      TAOS_RETURN(code);
×
679
    }
680
    if (pField1->name[0] == 0) {
155,675!
UNCOV
681
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
682
      TAOS_RETURN(code);
×
683
    }
684
  }
685

686
  for (int32_t i = 0; i < pCreate->numOfTags; ++i) {
41,104✔
687
    SField *pField1 = taosArrayGet(pCreate->pTags, i);
33,726✔
688
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
33,726!
UNCOV
689
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
690
      TAOS_RETURN(code);
×
691
    }
692
    if (pField1->bytes <= 0) {
33,726!
UNCOV
693
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
694
      TAOS_RETURN(code);
×
695
    }
696
    if (pField1->name[0] == 0) {
33,726!
UNCOV
697
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
698
      TAOS_RETURN(code);
×
699
    }
700
  }
701

702
  TAOS_RETURN(code);
7,378✔
703
}
704

UNCOV
705
static int32_t mndSetCreateStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
×
UNCOV
706
  int32_t  code = 0;
×
UNCOV
707
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
×
UNCOV
708
  if (pRedoRaw == NULL) {
×
UNCOV
709
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
710
    if (terrno != 0) code = terrno;
×
711
    TAOS_RETURN(code);
×
712
  }
713
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
×
714
    sdbFreeRaw(pRedoRaw);
×
715
    TAOS_RETURN(code);
×
716
  }
717
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
×
718

719
  TAOS_RETURN(code);
×
720
}
721

722
static int32_t mndSetCreateStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
7,195✔
723
  int32_t  code = 0;
7,195✔
724
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
7,195✔
725
  if (pCommitRaw == NULL) {
7,195!
UNCOV
726
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
727
    if (terrno != 0) code = terrno;
×
UNCOV
728
    TAOS_RETURN(code);
×
729
  }
730
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
7,195!
UNCOV
731
    sdbFreeRaw(pCommitRaw);
×
732
    TAOS_RETURN(code);
×
733
  }
734
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
7,195!
735

736
  TAOS_RETURN(code);
7,195✔
737
}
738

739
static int32_t mndSetCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
7,195✔
740
  int32_t code = 0;
7,195✔
741
  SSdb   *pSdb = pMnode->pSdb;
7,195✔
742
  SVgObj *pVgroup = NULL;
7,195✔
743
  void   *pIter = NULL;
7,195✔
744
  int32_t contLen;
745

746
  while (1) {
31,772✔
747
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
38,967✔
748
    if (pIter == NULL) break;
38,967✔
749
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
31,772✔
750
      sdbRelease(pSdb, pVgroup);
13,319✔
751
      continue;
13,319✔
752
    }
753

754
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
18,453✔
755
    if (pReq == NULL) {
18,453!
UNCOV
756
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
757
      sdbRelease(pSdb, pVgroup);
×
UNCOV
758
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
759
      if (terrno != 0) code = terrno;
×
UNCOV
760
      TAOS_RETURN(code);
×
761
    }
762

763
    STransAction action = {0};
18,453✔
764
    action.mTraceId = pTrans->mTraceId;
18,453✔
765
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
18,453✔
766
    action.pCont = pReq;
18,453✔
767
    action.contLen = contLen;
18,453✔
768
    action.msgType = TDMT_VND_CREATE_STB;
18,453✔
769
    action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
18,453✔
770
    action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
18,453✔
771
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
18,453!
UNCOV
772
      taosMemoryFree(pReq);
×
UNCOV
773
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
774
      sdbRelease(pSdb, pVgroup);
×
UNCOV
775
      TAOS_RETURN(code);
×
776
    }
777
    sdbRelease(pSdb, pVgroup);
18,453✔
778
  }
779

780
  TAOS_RETURN(code);
7,195✔
781
}
782

783
int32_t mndSetForceDropCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup, SStbObj *pStb) {
2✔
784
  int32_t code = 0;
2✔
785
  SSdb   *pSdb = pMnode->pSdb;
2✔
786
  int32_t contLen;
787

788
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
2✔
789
  if (pReq == NULL) {
2!
UNCOV
790
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
791
    if (terrno != 0) code = terrno;
×
UNCOV
792
    TAOS_RETURN(code);
×
793
  }
794

795
  STransAction action = {0};
2✔
796
  action.mTraceId = pTrans->mTraceId;
2✔
797
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
2✔
798
  action.pCont = pReq;
2✔
799
  action.contLen = contLen;
2✔
800
  action.msgType = TDMT_VND_CREATE_STB;
2✔
801
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
2✔
802
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
2✔
803
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
2!
UNCOV
804
    taosMemoryFree(pReq);
×
UNCOV
805
    TAOS_RETURN(code);
×
806
  }
807

808
  TAOS_RETURN(code);
2✔
809
}
810

811
static int32_t mndSetCreateStbUndoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
7,195✔
812
  int32_t code = 0;
7,195✔
813
  SSdb   *pSdb = pMnode->pSdb;
7,195✔
814
  SVgObj *pVgroup = NULL;
7,195✔
815
  void   *pIter = NULL;
7,195✔
816

817
  while (1) {
31,772✔
818
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
38,967✔
819
    if (pIter == NULL) break;
38,967✔
820
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
31,772✔
821
      sdbRelease(pSdb, pVgroup);
13,319✔
822
      continue;
13,319✔
823
    }
824

825
    int32_t contLen = 0;
18,453✔
826
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
18,453✔
827
    if (pReq == NULL) {
18,453!
UNCOV
828
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
829
      sdbRelease(pSdb, pVgroup);
×
UNCOV
830
      code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
831
      TAOS_RETURN(code);
×
832
    }
833

834
    STransAction action = {0};
18,453✔
835
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
18,453✔
836
    action.pCont = pReq;
18,453✔
837
    action.contLen = contLen;
18,453✔
838
    action.msgType = TDMT_VND_DROP_STB;
18,453✔
839
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
18,453✔
840
    if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
18,453!
UNCOV
841
      taosMemoryFree(pReq);
×
UNCOV
842
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
843
      sdbRelease(pSdb, pVgroup);
×
UNCOV
844
      TAOS_RETURN(code);
×
845
    }
846
    sdbRelease(pSdb, pVgroup);
18,453✔
847
  }
848

849
  TAOS_RETURN(code);
7,195✔
850
}
851

UNCOV
852
static SSchema *mndFindStbColumns(const SStbObj *pStb, const char *colName) {
×
UNCOV
853
  for (int32_t col = 0; col < pStb->numOfColumns; ++col) {
×
UNCOV
854
    SSchema *pSchema = &pStb->pColumns[col];
×
UNCOV
855
    if (taosStrncasecmp(pSchema->name, colName, TSDB_COL_NAME_LEN) == 0) {
×
UNCOV
856
      return pSchema;
×
857
    }
858
  }
859
  return NULL;
×
860
}
861

862
int32_t mndBuildStbFromReq(SMnode *pMnode, SStbObj *pDst, SMCreateStbReq *pCreate, SDbObj *pDb) {
7,222✔
863
  int32_t code = 0;
7,222✔
864
  memcpy(pDst->name, pCreate->name, TSDB_TABLE_FNAME_LEN);
7,222✔
865
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
7,222✔
866
  pDst->createdTime = taosGetTimestampMs();
7,222✔
867
  pDst->updateTime = pDst->createdTime;
7,222✔
868
  pDst->uid = (pCreate->source == TD_REQ_FROM_TAOX_OLD || pCreate->source == TD_REQ_FROM_TAOX)
7,222✔
869
                  ? pCreate->suid
870
                  : mndGenerateUid(pCreate->name, TSDB_TABLE_FNAME_LEN);
14,444!
871
  pDst->dbUid = pDb->uid;
7,222✔
872
  pDst->tagVer = 1;
7,222✔
873
  pDst->colVer = 1;
7,222✔
874
  pDst->smaVer = 1;
7,222✔
875
  pDst->nextColId = 1;
7,222✔
876
  pDst->maxdelay[0] = pCreate->delay1;
7,222✔
877
  pDst->maxdelay[1] = pCreate->delay2;
7,222✔
878
  pDst->watermark[0] = pCreate->watermark1;
7,222✔
879
  pDst->watermark[1] = pCreate->watermark2;
7,222✔
880
  pDst->ttl = pCreate->ttl;
7,222✔
881
  pDst->numOfColumns = pCreate->numOfColumns;
7,222✔
882
  pDst->numOfTags = pCreate->numOfTags;
7,222✔
883
  pDst->numOfFuncs = pCreate->numOfFuncs;
7,222✔
884
  pDst->commentLen = pCreate->commentLen;
7,222✔
885
  pDst->pFuncs = pCreate->pFuncs;
7,222✔
886
  pDst->source = pCreate->source;
7,222✔
887
  pDst->keep = pCreate->keep;
7,222✔
888
  pCreate->pFuncs = NULL;
7,222✔
889

890
  if (pDst->commentLen > 0) {
7,222✔
891
    pDst->comment = taosMemoryCalloc(pDst->commentLen + 1, 1);
18!
892
    if (pDst->comment == NULL) {
18!
UNCOV
893
      code = terrno;
×
UNCOV
894
      TAOS_RETURN(code);
×
895
    }
896
    memcpy(pDst->comment, pCreate->pComment, pDst->commentLen + 1);
18✔
897
  }
898

899
  pDst->ast1Len = pCreate->ast1Len;
7,222✔
900
  if (pDst->ast1Len > 0) {
7,222✔
901
    pDst->pAst1 = taosMemoryCalloc(pDst->ast1Len, 1);
3!
902
    if (pDst->pAst1 == NULL) {
3!
UNCOV
903
      code = terrno;
×
UNCOV
904
      TAOS_RETURN(code);
×
905
    }
906
    memcpy(pDst->pAst1, pCreate->pAst1, pDst->ast1Len);
3✔
907
  }
908

909
  pDst->ast2Len = pCreate->ast2Len;
7,222✔
910
  if (pDst->ast2Len > 0) {
7,222✔
911
    pDst->pAst2 = taosMemoryCalloc(pDst->ast2Len, 1);
3!
912
    if (pDst->pAst2 == NULL) {
3!
UNCOV
913
      code = terrno;
×
UNCOV
914
      TAOS_RETURN(code);
×
915
    }
916
    memcpy(pDst->pAst2, pCreate->pAst2, pDst->ast2Len);
3✔
917
  }
918

919
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
7,222!
920
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
7,222!
921
  if (pDst->pColumns == NULL || pDst->pTags == NULL) {
7,222!
UNCOV
922
    code = terrno;
×
UNCOV
923
    TAOS_RETURN(code);
×
924
  }
925

926
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
7,222!
UNCOV
927
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
928
    TAOS_RETURN(code);
×
929
  }
930

931
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
162,020✔
932
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
154,798✔
933
    SSchema           *pSchema = &pDst->pColumns[i];
154,798✔
934
    pSchema->type = pField->type;
154,798✔
935
    pSchema->bytes = pField->bytes;
154,798✔
936
    pSchema->flags = pField->flags;
154,798✔
937
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
154,798✔
938
    pSchema->colId = pDst->nextColId;
154,798✔
939
    pDst->nextColId++;
154,798✔
940
  }
941

942
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
40,374✔
943
    SField  *pField = taosArrayGet(pCreate->pTags, i);
33,152✔
944
    SSchema *pSchema = &pDst->pTags[i];
33,152✔
945
    pSchema->type = pField->type;
33,152✔
946
    pSchema->bytes = pField->bytes;
33,152✔
947
    if (i == 0) {
33,152✔
948
      SSCHMEA_SET_IDX_ON(pSchema);
7,222✔
949
    }
950
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
33,152✔
951
    pSchema->colId = pDst->nextColId;
33,152✔
952
    pDst->nextColId++;
33,152✔
953
  }
954
  // set col compress
955
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
7,222!
956
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
162,020✔
957
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
154,798✔
958
    SSchema           *pSchema = &pDst->pColumns[i];
154,798✔
959

960
    SColCmpr *pColCmpr = &pDst->pCmpr[i];
154,798✔
961
    pColCmpr->id = pSchema->colId;
154,798✔
962
    pColCmpr->alg = pField->compress;
154,798✔
963
  }
964
  TAOS_RETURN(code);
7,222✔
965
}
966
static int32_t mndGenIdxNameForFirstTag(char *fullname, char *dbname, char *stbname, char *tagname) {
5,646✔
967
  SName name = {0};
5,646✔
968
  if ((terrno = tNameFromString(&name, stbname, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
5,646!
UNCOV
969
    return -1;
×
970
  }
971
  return snprintf(fullname, TSDB_INDEX_FNAME_LEN, "%s.%s_%s", dbname, tagname, tNameGetTableName(&name));
5,646✔
972
}
973

974
static int32_t mndCreateStb(SMnode *pMnode, SRpcMsg *pReq, SMCreateStbReq *pCreate, SDbObj *pDb) {
5,646✔
975
  SStbObj stbObj = {0};
5,646✔
976
  int32_t code = -1;
5,646✔
977

978
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
5,646✔
979

980
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb");
5,646✔
981
  if (pTrans == NULL) {
5,646!
UNCOV
982
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
983
    if (terrno != 0) code = terrno;
×
UNCOV
984
    goto _OVER;
×
985
  }
986

987
  mInfo("trans:%d, used to create stb:%s", pTrans->id, pCreate->name);
5,646!
988
  TAOS_CHECK_GOTO(mndBuildStbFromReq(pMnode, &stbObj, pCreate, pDb), NULL, _OVER);
5,646!
989

990
  SSchema *pSchema = &(stbObj.pTags[0]);
5,646✔
991
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
5,646!
UNCOV
992
    goto _OVER;
×
993
  }
994
  SSIdx idx = {0};
5,646✔
995
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
5,646!
UNCOV
996
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
UNCOV
997
    mndReleaseIdx(pMnode, idx.pIdx);
×
UNCOV
998
    goto _OVER;
×
999
  }
1000

1001
  SIdxObj idxObj = {0};
5,646✔
1002
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
5,646✔
1003
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
5,646✔
1004
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
5,646✔
1005
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
5,646✔
1006
  idxObj.createdTime = taosGetTimestampMs();
5,646✔
1007
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
5,646✔
1008
  idxObj.stbUid = stbObj.uid;
5,646✔
1009
  idxObj.dbUid = stbObj.dbUid;
5,646✔
1010

1011
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
5,646!
1012

1013
  TAOS_CHECK_GOTO(mndAddStbToTrans(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
5,646✔
1014
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
5,619!
1015
  code = 0;
5,619✔
1016

1017
_OVER:
5,646✔
1018
  mndTransDrop(pTrans);
5,646✔
1019
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
5,646!
1020
  TAOS_RETURN(code);
5,646✔
1021
}
1022

1023
int32_t mndAddStbToTrans(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
7,222✔
1024
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
7,222✔
1025
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
7,222✔
1026
  TAOS_CHECK_RETURN(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, pStb));
7,195!
1027
  TAOS_CHECK_RETURN(mndSetCreateStbRedoActions(pMnode, pTrans, pDb, pStb));
7,195!
1028
  TAOS_CHECK_RETURN(mndSetCreateStbUndoActions(pMnode, pTrans, pDb, pStb));
7,195!
1029
  return 0;
7,195✔
1030
}
1031

1032
static int32_t mndProcessTtlTimer(SRpcMsg *pReq) {
4,129✔
1033
  SMnode           *pMnode = pReq->info.node;
4,129✔
1034
  SSdb             *pSdb = pMnode->pSdb;
4,129✔
1035
  SVgObj           *pVgroup = NULL;
4,129✔
1036
  void             *pIter = NULL;
4,129✔
1037
  SVDropTtlTableReq ttlReq = {
4,129✔
1038
      .timestampSec = taosGetTimestampSec(), .ttlDropMaxCount = tsTtlBatchDropNum, .nUids = 0, .pTbUids = NULL};
4,129✔
1039
  int32_t reqLen = tSerializeSVDropTtlTableReq(NULL, 0, &ttlReq);
4,129✔
1040
  int32_t contLen = reqLen + sizeof(SMsgHead);
4,129✔
1041

1042
  mDebug("start to process ttl timer");
4,129✔
1043

1044
  while (1) {
16,635✔
1045
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
20,764✔
1046
    if (pIter == NULL) break;
20,764✔
1047

1048
    int32_t   code = 0;
16,635✔
1049
    SMsgHead *pHead = rpcMallocCont(contLen);
16,635✔
1050
    if (pHead == NULL) {
16,635!
UNCOV
1051
      sdbRelease(pSdb, pVgroup);
×
UNCOV
1052
      continue;
×
1053
    }
1054
    pHead->contLen = htonl(contLen);
16,635✔
1055
    pHead->vgId = htonl(pVgroup->vgId);
16,635✔
1056
    if ((code = tSerializeSVDropTtlTableReq((char *)pHead + sizeof(SMsgHead), reqLen, &ttlReq)) < 0) {
16,635!
UNCOV
1057
      mError("vgId:%d, failed to serialize drop ttl table request since %s", pVgroup->vgId, tstrerror(code));
×
1058
      sdbRelease(pSdb, pVgroup);
×
1059
      continue;
×
1060
    }
1061

1062
    SRpcMsg rpcMsg = {
16,635✔
1063
        .msgType = TDMT_VND_FETCH_TTL_EXPIRED_TBS, .pCont = pHead, .contLen = contLen, .info = pReq->info};
1064
    SEpSet epSet = mndGetVgroupEpset(pMnode, pVgroup);
16,635✔
1065
    code = tmsgSendReq(&epSet, &rpcMsg);
16,635✔
1066
    if (code != 0) {
16,635✔
1067
      mError("vgId:%d, failed to send drop ttl table request to vnode since 0x%x", pVgroup->vgId, code);
21!
1068
    } else {
1069
      mDebug("vgId:%d, send drop ttl table request to vnode, time:%" PRId32, pVgroup->vgId, ttlReq.timestampSec);
16,614✔
1070
    }
1071
    sdbRelease(pSdb, pVgroup);
16,635✔
1072
  }
1073

1074
  return 0;
4,129✔
1075
}
1076

UNCOV
1077
static int32_t mndProcessTrimDbTimer(SRpcMsg *pReq) {
×
UNCOV
1078
  SMnode     *pMnode = pReq->info.node;
×
UNCOV
1079
  SSdb       *pSdb = pMnode->pSdb;
×
UNCOV
1080
  SVgObj     *pVgroup = NULL;
×
UNCOV
1081
  void       *pIter = NULL;
×
UNCOV
1082
  SVTrimDbReq trimReq = {.timestamp = taosGetTimestampSec()};
×
UNCOV
1083
  int32_t     reqLen = tSerializeSVTrimDbReq(NULL, 0, &trimReq);
×
1084
  int32_t     contLen = reqLen + sizeof(SMsgHead);
×
1085

1086
  while (1) {
×
1087
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
1088
    if (pIter == NULL) break;
×
1089

1090
    int32_t code = 0;
×
1091

UNCOV
1092
    SMsgHead *pHead = rpcMallocCont(contLen);
×
1093
    if (pHead == NULL) {
×
1094
      sdbCancelFetch(pSdb, pVgroup);
×
1095
      sdbRelease(pSdb, pVgroup);
×
UNCOV
1096
      continue;
×
1097
    }
UNCOV
1098
    pHead->contLen = htonl(contLen);
×
1099
    pHead->vgId = htonl(pVgroup->vgId);
×
1100
    if ((code = tSerializeSVTrimDbReq((char *)pHead + sizeof(SMsgHead), reqLen, &trimReq)) < 0) {
×
1101
      mError("vgId:%d, failed to serialize trim db request since %s", pVgroup->vgId, tstrerror(code));
×
1102
    }
1103

UNCOV
1104
    SRpcMsg rpcMsg = {.msgType = TDMT_VND_TRIM, .pCont = pHead, .contLen = contLen};
×
1105
    SEpSet  epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
1106
    code = tmsgSendReq(&epSet, &rpcMsg);
×
1107
    if (code != 0) {
×
1108
      mError("vgId:%d, timer failed to send vnode-trim request to vnode since 0x%x", pVgroup->vgId, code);
×
1109
    } else {
UNCOV
1110
      mInfo("vgId:%d, timer send vnode-trim request to vnode, time:%d", pVgroup->vgId, trimReq.timestamp);
×
1111
    }
1112
    sdbRelease(pSdb, pVgroup);
×
1113
  }
1114

1115
  return 0;
×
1116
}
1117

UNCOV
1118
static int32_t mndProcessS3MigrateDbTimer(SRpcMsg *pReq) {
×
1119
  SMnode          *pMnode = pReq->info.node;
×
UNCOV
1120
  SSdb            *pSdb = pMnode->pSdb;
×
UNCOV
1121
  SVgObj          *pVgroup = NULL;
×
1122
  void            *pIter = NULL;
×
UNCOV
1123
  SVS3MigrateDbReq s3migrateReq = {.timestamp = taosGetTimestampSec()};
×
UNCOV
1124
  int32_t          reqLen = tSerializeSVS3MigrateDbReq(NULL, 0, &s3migrateReq);
×
1125
  int32_t          contLen = reqLen + sizeof(SMsgHead);
×
1126

1127
  while (1) {
×
1128
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
1129
    if (pIter == NULL) break;
×
1130

1131
    int32_t code = 0;
×
1132

UNCOV
1133
    SMsgHead *pHead = rpcMallocCont(contLen);
×
1134
    if (pHead == NULL) {
×
1135
      sdbRelease(pSdb, pVgroup);
×
1136
      continue;
×
1137
    }
1138
    pHead->contLen = htonl(contLen);
×
UNCOV
1139
    pHead->vgId = htonl(pVgroup->vgId);
×
1140
    if ((code = tSerializeSVS3MigrateDbReq((char *)pHead + sizeof(SMsgHead), reqLen, &s3migrateReq)) < 0) {
×
1141
      mError("vgId:%d, failed to serialize s3migrate db request since %s", pVgroup->vgId, tstrerror(code));
×
1142
      sdbRelease(pSdb, pVgroup);
×
1143
      continue;
×
1144
    }
1145

1146
    SRpcMsg rpcMsg = {.msgType = TDMT_VND_S3MIGRATE, .pCont = pHead, .contLen = contLen};
×
1147
    SEpSet  epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
1148
    code = tmsgSendReq(&epSet, &rpcMsg);
×
1149
    if (code != 0) {
×
1150
      mError("vgId:%d, timer failed to send vnode-s3migrate request to vnode since 0x%x", pVgroup->vgId, code);
×
1151
    } else {
UNCOV
1152
      mInfo("vgId:%d, timer send vnode-s3migrate request to vnode, time:%d", pVgroup->vgId, s3migrateReq.timestamp);
×
1153
    }
1154
    sdbRelease(pSdb, pVgroup);
×
1155
  }
1156

1157
  return 0;
×
1158
}
1159

1160
static int32_t mndFindSuperTableTagIndex(const SStbObj *pStb, const char *tagName) {
3,790✔
1161
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
93,092✔
1162
    if (strcmp(pStb->pTags[tag].name, tagName) == 0) {
90,759✔
1163
      return tag;
1,457✔
1164
    }
1165
  }
1166

1167
  return -1;
2,333✔
1168
}
1169

1170
static int32_t mndFindSuperTableColumnIndex(const SStbObj *pStb, const char *colName) {
3,074✔
1171
  for (int32_t col = 0; col < pStb->numOfColumns; col++) {
967,265✔
1172
    if (strcmp(pStb->pColumns[col].name, colName) == 0) {
964,899✔
1173
      return col;
708✔
1174
    }
1175
  }
1176

1177
  return -1;
2,366✔
1178
}
1179

1180
static bool mndValidateSchema(SSchema *pSchemas, int32_t nSchema, SArray *pFields, int32_t maxLen) {
1,660✔
1181
  int32_t rowLen = 0;
1,660✔
1182
  for (int32_t i = 0; i < nSchema; ++i) {
531,503✔
1183
    rowLen += (pSchemas + i)->bytes;
529,843✔
1184
  }
1185

1186
  int32_t nField = taosArrayGetSize(pFields);
1,660✔
1187
  for (int32_t i = 0; i < nField; ++i) {
3,320✔
1188
    rowLen += ((SField *)TARRAY_GET_ELEM(pFields, i))->bytes;
1,660✔
1189
  }
1190

1191
  return rowLen <= maxLen;
1,660✔
1192
}
1193

1194
static int32_t mndBuildStbFromAlter(SStbObj *pStb, SStbObj *pDst, SMCreateStbReq *createReq) {
73✔
1195
  int32_t code = 0;
73✔
1196
  taosRLockLatch(&pStb->lock);
73✔
1197
  memcpy(pDst, pStb, sizeof(SStbObj));
73✔
1198
  taosRUnLockLatch(&pStb->lock);
73✔
1199

1200
  pDst->source = createReq->source;
73✔
1201
  pDst->updateTime = taosGetTimestampMs();
73✔
1202
  pDst->numOfColumns = createReq->numOfColumns;
73✔
1203
  pDst->numOfTags = createReq->numOfTags;
73✔
1204
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
73!
1205
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
73!
1206
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SColCmpr));
73!
1207

1208
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL) {
73!
UNCOV
1209
    code = terrno;
×
UNCOV
1210
    TAOS_RETURN(code);
×
1211
  }
1212

1213
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
73!
UNCOV
1214
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
1215
    TAOS_RETURN(code);
×
1216
  }
1217

1218
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
547✔
1219
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
474✔
1220
    SSchema           *pSchema = &pDst->pColumns[i];
474✔
1221
    pSchema->type = pField->type;
474✔
1222
    pSchema->bytes = pField->bytes;
474✔
1223
    pSchema->flags = pField->flags;
474✔
1224
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
474✔
1225
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pField->name);
474✔
1226
    if (cIndex >= 0) {
474✔
1227
      pSchema->colId = pStb->pColumns[cIndex].colId;
416✔
1228
    } else {
1229
      pSchema->colId = pDst->nextColId++;
58✔
1230
    }
1231
  }
1232

1233
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
429✔
1234
    SField  *pField = taosArrayGet(createReq->pTags, i);
356✔
1235
    SSchema *pSchema = &pDst->pTags[i];
356✔
1236
    pSchema->type = pField->type;
356✔
1237
    pSchema->bytes = pField->bytes;
356✔
1238
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
356✔
1239
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pField->name);
356✔
1240
    if (cIndex >= 0) {
356✔
1241
      pSchema->colId = pStb->pTags[cIndex].colId;
321✔
1242
    } else {
1243
      pSchema->colId = pDst->nextColId++;
35✔
1244
    }
1245
  }
1246
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
547✔
1247
    SColCmpr          *p = pDst->pCmpr + i;
474✔
1248
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
474✔
1249
    SSchema           *pSchema = &pDst->pColumns[i];
474✔
1250
    p->id = pSchema->colId;
474✔
1251
    if (pField->compress == 0) {
474!
UNCOV
1252
      p->alg = createDefaultColCmprByType(pSchema->type);
×
1253
    } else {
1254
      p->alg = pField->compress;
474✔
1255
    }
1256
  }
1257
  pDst->tagVer = createReq->tagVer;
73✔
1258
  pDst->colVer = createReq->colVer;
73✔
1259
  return TSDB_CODE_SUCCESS;
73✔
1260
}
1261

1262
static int32_t mndProcessCreateStbReq(SRpcMsg *pReq) {
5,802✔
1263
  SMnode        *pMnode = pReq->info.node;
5,802✔
1264
  int32_t        code = -1;
5,802✔
1265
  SStbObj       *pStb = NULL;
5,802✔
1266
  SDbObj        *pDb = NULL;
5,802✔
1267
  SMCreateStbReq createReq = {0};
5,802✔
1268
  bool           isAlter = false;
5,802✔
1269
  SHashObj      *pHash = NULL;
5,802✔
1270

1271
  if (tDeserializeSMCreateStbReq(pReq->pCont, pReq->contLen, &createReq) != 0) {
5,802!
UNCOV
1272
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
1273
    goto _OVER;
×
1274
  }
1275

1276
  mInfo("stb:%s, start to create", createReq.name);
5,802!
1277
  if (mndCheckCreateStbReq(&createReq) != 0) {
5,802!
UNCOV
1278
    code = TSDB_CODE_INVALID_MSG;
×
1279
    goto _OVER;
×
1280
  }
1281

1282
  pStb = mndAcquireStb(pMnode, createReq.name);
5,802✔
1283
  if (pStb != NULL) {
5,802✔
1284
    if (createReq.igExists) {
154✔
1285
      if (createReq.source == TD_REQ_FROM_APP) {
151✔
1286
        mInfo("stb:%s, already exist, ignore exist is set", createReq.name);
10!
1287
        code = 0;
10✔
1288
        goto _OVER;
10✔
1289
      } else if (pStb->uid != createReq.suid) {
141!
UNCOV
1290
        mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
×
UNCOV
1291
        code = 0;
×
UNCOV
1292
        goto _OVER;
×
1293
      } else if (createReq.tagVer > 0 || createReq.colVer > 0) {
214!
1294
        int32_t tagDelta = createReq.tagVer - pStb->tagVer;
141✔
1295
        int32_t colDelta = createReq.colVer - pStb->colVer;
141✔
1296
        mInfo("stb:%s, already exist while create, input tagVer:%d colVer:%d, exist tagVer:%d colVer:%d",
141!
1297
              createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1298
        if (tagDelta <= 0 && colDelta <= 0) {
141✔
1299
          mInfo("stb:%s, schema version is not incremented and nothing needs to be done", createReq.name);
68!
1300
          code = 0;
68✔
1301
          goto _OVER;
68✔
1302
        } else if ((tagDelta == 1 && colDelta == 0) || (tagDelta == 0 && colDelta == 1) ||
73!
UNCOV
1303
                   (pStb->colVer == 1 && createReq.colVer > 1) || (pStb->tagVer == 1 && createReq.tagVer > 1)) {
×
1304
          isAlter = true;
73✔
1305
          mInfo("stb:%s, schema version is only increased by 1 number, do alter operation", createReq.name);
73!
1306
        } else {
UNCOV
1307
          mError("stb:%s, schema version increase more than 1 number, error is returned", createReq.name);
×
UNCOV
1308
          code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
UNCOV
1309
          goto _OVER;
×
1310
        }
1311
      } else {
UNCOV
1312
        mError("stb:%s, already exist while create, input tagVer:%d colVer:%d is invalid, origin tagVer:%d colVer:%d",
×
1313
               createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1314
        code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
1315
        goto _OVER;
×
1316
      }
1317
    } else {
1318
      code = TSDB_CODE_MND_STB_ALREADY_EXIST;
3✔
1319
      goto _OVER;
3✔
1320
    }
1321
  } else if (terrno != TSDB_CODE_MND_STB_NOT_EXIST) {
5,648!
1322
    goto _OVER;
×
1323
  } else if ((createReq.source == TD_REQ_FROM_TAOX_OLD || createReq.source == TD_REQ_FROM_TAOX) &&
5,648!
1324
             (createReq.tagVer != 1 || createReq.colVer != 1)) {
51!
1325
    mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
1!
1326
    code = 0;
1✔
1327
    goto _OVER;
1✔
1328
  }
1329

1330
  pHash = taosHashInit(createReq.numOfColumns + createReq.numOfTags, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY),
5,720✔
1331
                       false, HASH_NO_LOCK);
1332
  if (pHash == NULL) {
5,720!
UNCOV
1333
    code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
1334
    goto _OVER;
×
1335
  }
1336

1337
  for (int32_t i = 0; i < createReq.numOfColumns; ++i) {
102,405✔
1338
    SFieldWithOptions *pField = taosArrayGet(createReq.pColumns, i);
96,685✔
1339
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
96,685!
1340
      if (code == TSDB_CODE_DUP_KEY) {
×
1341
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
×
1342
      }
UNCOV
1343
      goto _OVER;
×
1344
    }
1345
  }
1346

1347
  for (int32_t i = 0; i < createReq.numOfTags; ++i) {
36,349✔
1348
    SField *pField = taosArrayGet(createReq.pTags, i);
30,630✔
1349
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
30,630✔
1350
      if (code == TSDB_CODE_DUP_KEY) {
1!
1351
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
1✔
1352
      }
1353
      goto _OVER;
1✔
1354
    }
1355
  }
1356

1357
  pDb = mndAcquireDbByStb(pMnode, createReq.name);
5,719✔
1358
  if (pDb == NULL) {
5,719!
UNCOV
1359
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
1360
    goto _OVER;
×
1361
  }
1362

1363
  if ((code = mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb)) != 0) {
5,719!
UNCOV
1364
    goto _OVER;
×
1365
  }
1366

1367
  int32_t numOfStbs = -1;
5,719✔
1368
  if ((code = mndGetNumOfStbs(pMnode, pDb->name, &numOfStbs)) != 0) {
5,719!
UNCOV
1369
    goto _OVER;
×
1370
  }
1371

1372
  if (pDb->cfg.numOfStables == 1 && numOfStbs != 0) {
5,719!
UNCOV
1373
    code = TSDB_CODE_MND_SINGLE_STB_MODE_DB;
×
UNCOV
1374
    goto _OVER;
×
1375
  }
1376

1377
  if ((code = grantCheck(TSDB_GRANT_STABLE)) < 0) {
5,719!
UNCOV
1378
    goto _OVER;
×
1379
  }
1380

1381
  if (isAlter) {
5,719✔
1382
    bool    needRsp = false;
73✔
1383
    SStbObj pDst = {0};
73✔
1384
    if ((code = mndBuildStbFromAlter(pStb, &pDst, &createReq)) != 0) {
73!
1385
      taosMemoryFreeClear(pDst.pTags);
×
UNCOV
1386
      taosMemoryFreeClear(pDst.pColumns);
×
UNCOV
1387
      taosMemoryFreeClear(pDst.pCmpr);
×
UNCOV
1388
      goto _OVER;
×
1389
    }
1390

1391
    code = mndAlterStbImp(pMnode, pReq, pDb, &pDst, needRsp, NULL, 0);
73✔
1392
    taosMemoryFreeClear(pDst.pTags);
73!
1393
    taosMemoryFreeClear(pDst.pColumns);
73!
1394
    taosMemoryFreeClear(pDst.pCmpr);
73!
1395
  } else {
1396
    code = mndCreateStb(pMnode, pReq, &createReq, pDb);
5,646✔
1397
  }
1398
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
5,719✔
1399

1400
  SName name = {0};
5,719✔
1401
  TAOS_CHECK_RETURN(tNameFromString(&name, createReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
5,719!
1402

1403
  if (createReq.sql == NULL && createReq.sqlLen == 0) {
6,097!
1404
    char detail[1000] = {0};
378✔
1405

1406
    (void)tsnprintf(detail, sizeof(detail), "dbname:%s, stable name:%s", name.dbname, name.tname);
378✔
1407

1408
    auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, detail, strlen(detail));
378✔
1409
  } else {
1410
    auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, createReq.sql, createReq.sqlLen);
5,341✔
1411
  }
1412
_OVER:
5,802✔
1413
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
5,802✔
1414
    mError("stb:%s, failed to create since %s", createReq.name, tstrerror(code));
31!
1415
  }
1416

1417
  mndReleaseStb(pMnode, pStb);
5,802✔
1418
  mndReleaseDb(pMnode, pDb);
5,802✔
1419
  tFreeSMCreateStbReq(&createReq);
5,802✔
1420

1421
  if (pHash != NULL) {
5,802✔
1422
    taosHashCleanup(pHash);
5,720✔
1423
  }
1424

1425
  TAOS_RETURN(code);
5,802✔
1426
}
1427

1428
static int32_t mndCheckAlterStbReq(SMAlterStbReq *pAlter) {
3,095✔
1429
  int32_t code = 0;
3,095✔
1430
  if (pAlter->commentLen >= 0) return 0;
3,095!
UNCOV
1431
  if (pAlter->ttl != 0) return 0;
×
NEW
1432
  if (pAlter->keep != -1) return 0;
×
1433

UNCOV
1434
  if (pAlter->numOfFields < 1 || pAlter->numOfFields != (int32_t)taosArrayGetSize(pAlter->pFields)) {
×
UNCOV
1435
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
1436
    TAOS_RETURN(code);
×
1437
  }
1438

1439
  for (int32_t i = 0; i < pAlter->numOfFields; ++i) {
×
1440
    SField *pField = taosArrayGet(pAlter->pFields, i);
×
UNCOV
1441
    if (pField->name[0] == 0) {
×
1442
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1443
      TAOS_RETURN(code);
×
1444
    }
1445
  }
1446

1447
  TAOS_RETURN(code);
×
1448
}
1449

1450
int32_t mndAllocStbSchemas(const SStbObj *pOld, SStbObj *pNew) {
2,969✔
1451
  pNew->pTags = taosMemoryCalloc(pNew->numOfTags, sizeof(SSchema));
2,969!
1452
  pNew->pColumns = taosMemoryCalloc(pNew->numOfColumns, sizeof(SSchema));
2,969!
1453
  pNew->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
2,969!
1454
  if (pNew->pTags == NULL || pNew->pColumns == NULL || pNew->pCmpr == NULL) {
2,969!
1455
    TAOS_RETURN(terrno);
×
1456
  }
1457

1458
  memcpy(pNew->pColumns, pOld->pColumns, sizeof(SSchema) * pOld->numOfColumns);
2,969✔
1459
  memcpy(pNew->pTags, pOld->pTags, sizeof(SSchema) * pOld->numOfTags);
2,969✔
1460
  memcpy(pNew->pCmpr, pOld->pCmpr, sizeof(SColCmpr) * pOld->numOfColumns);
2,969✔
1461

1462
  TAOS_RETURN(0);
2,969✔
1463
}
1464

1465
static int32_t mndUpdateTableOptions(const SStbObj *pOld, SStbObj *pNew, char *pComment, int32_t commentLen,
22✔
1466
                                     int32_t ttl, int64_t keep) {
1467
  int32_t code = 0;
22✔
1468
  if (commentLen > 0) {
22✔
1469
    pNew->commentLen = commentLen;
17✔
1470
    pNew->comment = taosMemoryCalloc(1, commentLen + 1);
17!
1471
    if (pNew->comment == NULL) {
17!
UNCOV
1472
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
1473
      return -1;
×
1474
    }
1475
    memcpy(pNew->comment, pComment, commentLen + 1);
17✔
1476
  } else if (commentLen == 0) {
5!
1477
    pNew->commentLen = 0;
5✔
1478
  } else {
1479
  }
1480

1481
  if (ttl >= 0) {
22!
1482
    pNew->ttl = ttl;
22✔
1483
  }
1484

1485
  if (keep > 0) {
22!
NEW
1486
    pNew->keep = keep;
×
1487
  }
1488

1489
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
22!
UNCOV
1490
    TAOS_RETURN(code);
×
1491
  }
1492
  TAOS_RETURN(code);
22✔
1493
}
1494

1495
static int32_t mndAddSuperTableTag(const SStbObj *pOld, SStbObj *pNew, SArray *pFields, int32_t ntags) {
471✔
1496
  int32_t code = 0;
471✔
1497
  if (pOld->numOfTags + ntags > TSDB_MAX_TAGS) {
471!
1498
    code = TSDB_CODE_MND_TOO_MANY_TAGS;
×
UNCOV
1499
    TAOS_RETURN(code);
×
1500
  }
1501

1502
  if (pOld->numOfColumns + ntags + pOld->numOfTags > TSDB_MAX_COLUMNS) {
471!
UNCOV
1503
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
UNCOV
1504
    TAOS_RETURN(code);
×
1505
  }
1506

1507
  if (!mndValidateSchema(pOld->pTags, pOld->numOfTags, pFields, TSDB_MAX_TAGS_LEN)) {
471!
UNCOV
1508
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
×
UNCOV
1509
    TAOS_RETURN(code);
×
1510
  }
1511

1512
  pNew->numOfTags = pNew->numOfTags + ntags;
471✔
1513
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
471!
UNCOV
1514
    TAOS_RETURN(code);
×
1515
  }
1516

1517
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ntags) {
471!
UNCOV
1518
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
1519
    TAOS_RETURN(code);
×
1520
  }
1521

1522
  for (int32_t i = 0; i < ntags; i++) {
928✔
1523
    SField *pField = taosArrayGet(pFields, i);
471✔
1524
    if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
471✔
1525
      code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
6✔
1526
      TAOS_RETURN(code);
6✔
1527
    }
1528

1529
    if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
465✔
1530
      code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
8✔
1531
      TAOS_RETURN(code);
8✔
1532
    }
1533

1534
    SSchema *pSchema = &pNew->pTags[pOld->numOfTags + i];
457✔
1535
    pSchema->bytes = pField->bytes;
457✔
1536
    pSchema->type = pField->type;
457✔
1537
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
457✔
1538
    pSchema->colId = pNew->nextColId;
457✔
1539
    pNew->nextColId++;
457✔
1540

1541
    mInfo("stb:%s, start to add tag %s", pNew->name, pSchema->name);
457!
1542
  }
1543

1544
  pNew->tagVer++;
457✔
1545
  TAOS_RETURN(code);
457✔
1546
}
1547

1548
static int32_t mndCheckAlterColForTopic(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
1,352✔
1549
  int32_t code = 0;
1,352✔
1550
  SSdb   *pSdb = pMnode->pSdb;
1,352✔
1551
  void   *pIter = NULL;
1,352✔
1552
  while (1) {
1,027✔
1553
    SMqTopicObj *pTopic = NULL;
2,379✔
1554
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
2,379✔
1555
    if (pIter == NULL) break;
2,379✔
1556

1557
    mInfo("topic:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, subType:%d sql:%s",
1,105!
1558
          pTopic->name, stbFullName, suid, colId, pTopic->subType, pTopic->sql);
1559
    if (pTopic->ast == NULL) {
1,105✔
1560
      sdbRelease(pSdb, pTopic);
107✔
1561
      continue;
107✔
1562
    }
1563

1564
    SNode *pAst = NULL;
998✔
1565
    if (nodesStringToNode(pTopic->ast, &pAst) != 0) {
998!
UNCOV
1566
      code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TOPIC;
×
UNCOV
1567
      mError("topic:%s, create ast error", pTopic->name);
×
UNCOV
1568
      sdbRelease(pSdb, pTopic);
×
UNCOV
1569
      sdbCancelFetch(pSdb, pIter);
×
1570
      TAOS_RETURN(code);
78✔
1571
    }
1572

1573
    SNodeList *pNodeList = NULL;
998✔
1574
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
998!
1575
        0) {
UNCOV
1576
      sdbRelease(pSdb, pTopic);
×
UNCOV
1577
      sdbCancelFetch(pSdb, pIter);
×
1578
      TAOS_RETURN(code);
×
1579
    }
1580
    SNode *pNode = NULL;
998✔
1581
    FOREACH(pNode, pNodeList) {
1,639✔
1582
      SColumnNode *pCol = (SColumnNode *)pNode;
1,560✔
1583
      mInfo("topic:%s, check colId:%d tableId:%" PRId64 " ctbStbUid:%" PRId64, pTopic->name, pCol->colId, pCol->tableId,
1,560!
1584
            pTopic->ctbStbUid);
1585

1586
      if (pCol->tableId != suid && pTopic->ctbStbUid != suid) {
1,560✔
1587
        mInfo("topic:%s, check colId:%d passed", pTopic->name, pCol->colId);
841!
1588
        goto NEXT;
841✔
1589
      }
1590
      if (pCol->colId > 0 && pCol->colId == colId) {
719!
1591
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TOPIC;
78✔
1592
        mError("topic:%s, check colId:%d conflicted", pTopic->name, pCol->colId);
78!
1593
        nodesDestroyNode(pAst);
78✔
1594
        nodesDestroyList(pNodeList);
78✔
1595
        sdbCancelFetch(pSdb, pIter);
78✔
1596
        sdbRelease(pSdb, pTopic);
78✔
1597
        TAOS_RETURN(code);
78✔
1598
      }
1599
      mInfo("topic:%s, check colId:%d passed", pTopic->name, pCol->colId);
641!
1600
    }
1601

1602
  NEXT:
79✔
1603
    sdbRelease(pSdb, pTopic);
920✔
1604
    nodesDestroyNode(pAst);
920✔
1605
    nodesDestroyList(pNodeList);
920✔
1606
  }
1607
  TAOS_RETURN(code);
1,274✔
1608
}
1609

1610
static int32_t mndCheckAlterColForStream(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
1,274✔
1611
  int32_t code = 0;
1,274✔
1612
  SSdb   *pSdb = pMnode->pSdb;
1,274✔
1613
  void   *pIter = NULL;
1,274✔
1614
  while (1) {
10✔
1615
    SStreamObj *pStream = NULL;
1,284✔
1616
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
1,284✔
1617
    if (pIter == NULL) break;
1,284✔
1618

1619
    SNode *pAst = NULL;
30✔
1620
    if (nodesStringToNode(pStream->ast, &pAst) != 0) {
30!
UNCOV
1621
      code = TSDB_CODE_MND_INVALID_STREAM_OPTION;
×
UNCOV
1622
      mError("stream:%s, create ast error", pStream->name);
×
UNCOV
1623
      sdbRelease(pSdb, pStream);
×
UNCOV
1624
      sdbCancelFetch(pSdb, pIter);
×
1625
      TAOS_RETURN(code);
20✔
1626
    }
1627

1628
    SNodeList *pNodeList = NULL;
30✔
1629
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
30!
1630
        0) {
UNCOV
1631
      sdbRelease(pSdb, pStream);
×
UNCOV
1632
      sdbCancelFetch(pSdb, pIter);
×
1633
      TAOS_RETURN(code);
×
1634
    }
1635

1636
    SNode *pNode = NULL;
30✔
1637
    FOREACH(pNode, pNodeList) {
95!
1638
      SColumnNode *pCol = (SColumnNode *)pNode;
90✔
1639

1640
      if (pCol->tableId != suid) {
90✔
1641
        mInfo("stream:%s, check colId:%d passed", pStream->name, pCol->colId);
5!
1642
        goto NEXT;
5✔
1643
      }
1644
      if (pCol->colId > 0 && pCol->colId == colId) {
85!
1645
        code = TSDB_CODE_MND_STREAM_MUST_BE_DELETED;
20✔
1646
        mError("stream:%s, check colId:%d conflicted", pStream->name, pCol->colId);
20!
1647
        nodesDestroyNode(pAst);
20✔
1648
        nodesDestroyList(pNodeList);
20✔
1649
        sdbRelease(pSdb, pStream);
20✔
1650
        sdbCancelFetch(pSdb, pIter);
20✔
1651
        TAOS_RETURN(code);
20✔
1652
      }
1653
      mInfo("stream:%s, check colId:%d passed", pStream->name, pCol->colId);
65!
1654
    }
1655

1656
  NEXT:
5✔
1657
    sdbRelease(pSdb, pStream);
10✔
1658
    nodesDestroyNode(pAst);
10✔
1659
    nodesDestroyList(pNodeList);
10✔
1660
  }
1661
  TAOS_RETURN(code);
1,254✔
1662
}
1663

1664
static int32_t mndCheckAlterColForTSma(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
1,254✔
1665
  int32_t code = 0;
1,254✔
1666
  SSdb   *pSdb = pMnode->pSdb;
1,254✔
1667
  void   *pIter = NULL;
1,254✔
1668
  while (1) {
10✔
1669
    SSmaObj *pSma = NULL;
1,264✔
1670
    pIter = sdbFetch(pSdb, SDB_SMA, pIter, (void **)&pSma);
1,264✔
1671
    if (pIter == NULL) break;
1,264✔
1672

1673
    mInfo("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, sql:%s", pSma->name, stbFullName,
10!
1674
          suid, colId, pSma->sql);
1675

1676
    SNode *pAst = NULL;
10✔
1677
    if (nodesStringToNode(pSma->ast, &pAst) != 0) {
10!
UNCOV
1678
      code = TSDB_CODE_SDB_INVALID_DATA_CONTENT;
×
UNCOV
1679
      mError("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d failed since parse AST err",
×
1680
             pSma->name, stbFullName, suid, colId);
UNCOV
1681
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
1682
      TAOS_RETURN(code);
×
1683
    }
1684

1685
    SNodeList *pNodeList = NULL;
10✔
1686
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
10!
1687
        0) {
UNCOV
1688
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
1689
      TAOS_RETURN(code);
×
1690
    }
1691
    SNode *pNode = NULL;
10✔
1692
    FOREACH(pNode, pNodeList) {
55!
1693
      SColumnNode *pCol = (SColumnNode *)pNode;
50✔
1694
      mInfo("tsma:%s, check colId:%d tableId:%" PRId64, pSma->name, pCol->colId, pCol->tableId);
50!
1695

1696
      if ((pCol->tableId != suid) && (pSma->stbUid != suid)) {
50!
1697
        mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
5!
1698
        goto NEXT;
5✔
1699
      }
1700
      if ((pCol->colId) > 0 && (pCol->colId == colId)) {
45!
1701
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
×
UNCOV
1702
        mError("tsma:%s, check colId:%d conflicted", pSma->name, pCol->colId);
×
UNCOV
1703
        nodesDestroyNode(pAst);
×
UNCOV
1704
        nodesDestroyList(pNodeList);
×
UNCOV
1705
        sdbRelease(pSdb, pSma);
×
UNCOV
1706
        sdbCancelFetch(pSdb, pIter);
×
UNCOV
1707
        TAOS_RETURN(code);
×
1708
      }
1709
      mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
45!
1710
    }
1711

1712
  NEXT:
5✔
1713
    sdbRelease(pSdb, pSma);
10✔
1714
    nodesDestroyNode(pAst);
10✔
1715
    nodesDestroyList(pNodeList);
10✔
1716
  }
1717
  TAOS_RETURN(code);
1,254✔
1718
}
1719

1720
int32_t mndCheckColAndTagModifiable(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
1,352✔
1721
  TAOS_CHECK_RETURN(mndCheckAlterColForTopic(pMnode, stbFullName, suid, colId));
1,352✔
1722
  TAOS_CHECK_RETURN(mndCheckAlterColForStream(pMnode, stbFullName, suid, colId));
1,274✔
1723
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, stbFullName, suid, colId));
1,254!
1724
  TAOS_RETURN(0);
1,254✔
1725
}
1726

1727
static int32_t mndDropSuperTableTag(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *tagName) {
385✔
1728
  int32_t code = 0;
385✔
1729
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagName);
385✔
1730
  if (tag < 0) {
385✔
1731
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
4✔
1732
    TAOS_RETURN(code);
4✔
1733
  }
1734

1735
  col_id_t colId = pOld->pTags[tag].colId;
381✔
1736
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
381✔
1737

1738
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
353!
1739

1740
  memmove(pNew->pTags + tag, pNew->pTags + tag + 1, sizeof(SSchema) * (pNew->numOfTags - tag - 1));
353✔
1741
  pNew->numOfTags--;
353✔
1742

1743
  pNew->tagVer++;
353✔
1744

1745
  // if (mndDropIndexByTag(pMnode, pOld, tagName) != 0) {
1746
  //   return -1;
1747
  // }
1748
  mInfo("stb:%s, start to drop tag %s", pNew->name, tagName);
353!
1749
  TAOS_RETURN(code);
353✔
1750
}
1751

1752
static int32_t mndAlterStbTagName(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pFields) {
697✔
1753
  int32_t code = 0;
697✔
1754
  if ((int32_t)taosArrayGetSize(pFields) != 2) {
697!
UNCOV
1755
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
1756
    TAOS_RETURN(code);
×
1757
  }
1758

1759
  SField *pField0 = taosArrayGet(pFields, 0);
697✔
1760
  SField *pField1 = taosArrayGet(pFields, 1);
697✔
1761

1762
  const char *oldTagName = pField0->name;
697✔
1763
  const char *newTagName = pField1->name;
697✔
1764

1765
  int32_t tag = mndFindSuperTableTagIndex(pOld, oldTagName);
697✔
1766
  if (tag < 0) {
697✔
1767
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
9✔
1768
    TAOS_RETURN(code);
9✔
1769
  }
1770

1771
  col_id_t colId = pOld->pTags[tag].colId;
688✔
1772
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
688✔
1773

1774
  if (mndFindSuperTableTagIndex(pOld, newTagName) >= 0) {
666✔
1775
    code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
11✔
1776
    TAOS_RETURN(code);
11✔
1777
  }
1778

1779
  if (mndFindSuperTableColumnIndex(pOld, newTagName) >= 0) {
655✔
1780
    code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
1✔
1781
    TAOS_RETURN(code);
1✔
1782
  }
1783

1784
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
654!
1785

1786
  SSchema *pSchema = (SSchema *)(pNew->pTags + tag);
654✔
1787
  memcpy(pSchema->name, newTagName, TSDB_COL_NAME_LEN);
654✔
1788

1789
  pNew->tagVer++;
654✔
1790
  mInfo("stb:%s, start to modify tag %s to %s", pNew->name, oldTagName, newTagName);
654!
1791
  TAOS_RETURN(code);
654✔
1792
}
1793

1794
static int32_t mndAlterStbTagBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
42✔
1795
  int32_t code = 0;
42✔
1796
  int32_t tag = mndFindSuperTableTagIndex(pOld, pField->name);
42✔
1797
  if (tag < 0) {
42✔
1798
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
1✔
1799
    TAOS_RETURN(code);
1✔
1800
  }
1801

1802
  col_id_t colId = pOld->pTags[tag].colId;
41✔
1803
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
41✔
1804

1805
  uint32_t nLen = 0;
32✔
1806
  for (int32_t i = 0; i < pOld->numOfTags; ++i) {
145✔
1807
    nLen += (pOld->pTags[i].colId == colId) ? pField->bytes : pOld->pTags[i].bytes;
113✔
1808
  }
1809

1810
  if (nLen > TSDB_MAX_TAGS_LEN) {
32!
UNCOV
1811
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
×
UNCOV
1812
    TAOS_RETURN(code);
×
1813
  }
1814

1815
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
32!
1816

1817
  SSchema *pTag = pNew->pTags + tag;
32✔
1818

1819
  if (!(pTag->type == TSDB_DATA_TYPE_BINARY || pTag->type == TSDB_DATA_TYPE_VARBINARY ||
32!
1820
        pTag->type == TSDB_DATA_TYPE_NCHAR || pTag->type == TSDB_DATA_TYPE_GEOMETRY)) {
9!
1821
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
1✔
1822
    TAOS_RETURN(code);
1✔
1823
  }
1824

1825
  if (pField->bytes <= pTag->bytes) {
31✔
1826
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
1✔
1827
    TAOS_RETURN(code);
1✔
1828
  }
1829

1830
  pTag->bytes = pField->bytes;
30✔
1831
  pNew->tagVer++;
30✔
1832

1833
  mInfo("stb:%s, start to modify tag len %s to %d", pNew->name, pField->name, pField->bytes);
30!
1834
  TAOS_RETURN(code);
30✔
1835
}
1836

1837
static int32_t mndUpdateSuperTableColumnCompress(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pField,
26✔
1838
                                                 int32_t nCols) {
1839
  // if (pColCmpr == NULL || colName == NULL) return -1;
1840

1841
  if (taosArrayGetSize(pField) != nCols) return TSDB_CODE_FAILED;
26!
1842
  TAOS_FIELD *p = taosArrayGet(pField, 0);
26✔
1843

1844
  int32_t code = 0;
26✔
1845
  int32_t idx = mndFindSuperTableColumnIndex(pOld, p->name);
26✔
1846
  if (idx == -1) {
26!
UNCOV
1847
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
×
UNCOV
1848
    TAOS_RETURN(code);
×
1849
  }
1850
  SSchema *pTarget = &pOld->pColumns[idx];
26✔
1851
  col_id_t colId = pTarget->colId;
26✔
1852

1853
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
26!
1854
  code = validColCmprByType(pTarget->type, p->bytes);
26✔
1855
  if (code != TSDB_CODE_SUCCESS) {
26✔
1856
    TAOS_RETURN(code);
1✔
1857
  }
1858

1859
  int8_t updated = 0;
25✔
1860
  for (int i = 0; i < pNew->numOfColumns; i++) {
161!
1861
    SColCmpr *pCmpr = &pNew->pCmpr[i];
161✔
1862
    if (pCmpr->id == colId) {
161✔
1863
      uint32_t dst = 0;
25✔
1864
      updated = tUpdateCompress(pCmpr->alg, p->bytes, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
25✔
1865
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
1866
      if (updated > 0) pCmpr->alg = dst;
25✔
1867
      break;
25✔
1868
    }
1869
  }
1870

1871
  if (updated == 0) {
25✔
1872
    code = TSDB_CODE_MND_COLUMN_COMPRESS_ALREADY_EXIST;
7✔
1873
    TAOS_RETURN(code);
7✔
1874
  } else if (updated == -1) {
18!
UNCOV
1875
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
UNCOV
1876
    TAOS_RETURN(code);
×
1877
  }
1878

1879
  pNew->colVer++;
18✔
1880

1881
  TAOS_RETURN(code);
18✔
1882
}
1883
static int32_t mndAddSuperTableColumn(const SStbObj *pOld, SStbObj *pNew, SArray *pFields, int32_t ncols,
1,189✔
1884
                                      int8_t withCompress) {
1885
  int32_t code = 0;
1,189✔
1886
  if (pOld->numOfColumns + ncols + pOld->numOfTags > TSDB_MAX_COLUMNS) {
1,189!
1887
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
1888
    TAOS_RETURN(code);
×
1889
  }
1890

1891
  if ((code = grantCheck(TSDB_GRANT_TIMESERIES)) != 0) {
1,189!
UNCOV
1892
    TAOS_RETURN(code);
×
1893
  }
1894

1895
  if (!mndValidateSchema(pOld->pColumns, pOld->numOfColumns, pFields, TSDB_MAX_BYTES_PER_ROW)) {
1,189!
UNCOV
1896
    code = TSDB_CODE_PAR_INVALID_ROW_LENGTH;
×
UNCOV
1897
    TAOS_RETURN(code);
×
1898
  }
1899

1900
  pNew->numOfColumns = pNew->numOfColumns + ncols;
1,189✔
1901

1902
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
1,189!
1903

1904
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ncols) {
1,189!
UNCOV
1905
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
1906
    TAOS_RETURN(code);
×
1907
  }
1908

1909
  for (int32_t i = 0; i < ncols; i++) {
2,361✔
1910
    if (withCompress) {
1,189✔
1911
      SFieldWithOptions *pField = taosArrayGet(pFields, i);
2✔
1912
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
2!
UNCOV
1913
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
×
UNCOV
1914
        TAOS_RETURN(code);
×
1915
      }
1916

1917
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
2!
1918
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
×
UNCOV
1919
        TAOS_RETURN(code);
×
1920
      }
1921

1922
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
2✔
1923
      pSchema->bytes = pField->bytes;
2✔
1924
      pSchema->type = pField->type;
2✔
1925
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
2✔
1926
      pSchema->colId = pNew->nextColId;
2✔
1927
      pNew->nextColId++;
2✔
1928

1929
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
2✔
1930
      pCmpr->id = pSchema->colId;
2✔
1931
      pCmpr->alg = pField->compress;
2✔
1932
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
2!
1933
    } else {
1934
      SField *pField = taosArrayGet(pFields, i);
1,187✔
1935
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
1,187✔
1936
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
10✔
1937
        TAOS_RETURN(code);
10✔
1938
      }
1939

1940
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
1,177✔
1941
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
7✔
1942
        TAOS_RETURN(code);
7✔
1943
      }
1944

1945
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
1,170✔
1946
      pSchema->bytes = pField->bytes;
1,170✔
1947
      pSchema->type = pField->type;
1,170✔
1948
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
1,170✔
1949
      pSchema->colId = pNew->nextColId;
1,170✔
1950
      pNew->nextColId++;
1,170✔
1951

1952
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
1,170✔
1953
      pCmpr->id = pSchema->colId;
1,170✔
1954
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
1,170✔
1955
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
1,170!
1956
    }
1957
  }
1958

1959
  pNew->colVer++;
1,172✔
1960
  TAOS_RETURN(code);
1,172✔
1961
}
1962

1963
static int32_t mndDropSuperTableColumn(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *colName) {
200✔
1964
  int32_t code = 0;
200✔
1965
  int32_t col = mndFindSuperTableColumnIndex(pOld, colName);
200✔
1966
  if (col < 0) {
200✔
1967
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
7✔
1968
    TAOS_RETURN(code);
7✔
1969
  }
1970

1971
  if (col == 0) {
193✔
1972
    code = TSDB_CODE_MND_INVALID_STB_ALTER_OPTION;
5✔
1973
    TAOS_RETURN(code);
5✔
1974
  }
1975

1976
  if (pOld->numOfColumns == 2) {
188✔
1977
    code = TSDB_CODE_PAR_INVALID_DROP_COL;
1✔
1978
    TAOS_RETURN(code);
1✔
1979
  }
1980

1981
  col_id_t colId = pOld->pColumns[col].colId;
187✔
1982
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
187✔
1983

1984
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
160!
1985

1986
  int32_t sz = pNew->numOfColumns - col - 1;
160✔
1987
  memmove(pNew->pColumns + col, pNew->pColumns + col + 1, sizeof(SSchema) * sz);
160✔
1988
  memmove(pNew->pCmpr + col, pNew->pCmpr + col + 1, sizeof(SColCmpr) * sz);
160✔
1989
  pNew->numOfColumns--;
160✔
1990

1991
  pNew->colVer++;
160✔
1992
  mInfo("stb:%s, start to drop col %s", pNew->name, colName);
160!
1993
  TAOS_RETURN(code);
160✔
1994
}
1995

1996
static int32_t mndAlterStbColumnBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
59✔
1997
  int32_t code = 0;
59✔
1998
  int32_t col = mndFindSuperTableColumnIndex(pOld, pField->name);
59✔
1999
  if (col < 0) {
59✔
2000
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
3✔
2001
    TAOS_RETURN(code);
3✔
2002
  }
2003

2004
  col_id_t colId = pOld->pColumns[col].colId;
56✔
2005

2006
  uint32_t nLen = 0;
56✔
2007
  for (int32_t i = 0; i < pOld->numOfColumns; ++i) {
322✔
2008
    nLen += (pOld->pColumns[i].colId == colId) ? pField->bytes : pOld->pColumns[i].bytes;
266✔
2009
  }
2010

2011
  if (nLen > TSDB_MAX_BYTES_PER_ROW) {
56✔
2012
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
1✔
2013
    TAOS_RETURN(code);
1✔
2014
  }
2015

2016
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
55✔
2017

2018
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
43!
2019

2020
  SSchema *pCol = pNew->pColumns + col;
43✔
2021
  if (!(pCol->type == TSDB_DATA_TYPE_BINARY || pCol->type == TSDB_DATA_TYPE_VARBINARY ||
43✔
2022
        pCol->type == TSDB_DATA_TYPE_NCHAR || pCol->type == TSDB_DATA_TYPE_GEOMETRY)) {
9!
2023
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
1✔
2024
    TAOS_RETURN(code);
1✔
2025
  }
2026

2027
  if (pField->bytes <= pCol->bytes) {
42✔
2028
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
1✔
2029
    TAOS_RETURN(code);
1✔
2030
  }
2031

2032
  pCol->bytes = pField->bytes;
41✔
2033
  pNew->colVer++;
41✔
2034

2035
  mInfo("stb:%s, start to modify col len %s to %d", pNew->name, pField->name, pField->bytes);
41!
2036
  TAOS_RETURN(code);
41✔
2037
}
2038

2039
static int32_t mndSetAlterStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
2,980✔
2040
  int32_t  code = 0;
2,980✔
2041
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
2,980✔
2042
  if (pRedoRaw == NULL) {
2,980!
UNCOV
2043
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2044
    if (terrno != 0) code = terrno;
×
UNCOV
2045
    TAOS_RETURN(code);
×
2046
  }
2047
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
2,980!
UNCOV
2048
    sdbFreeRaw(pRedoRaw);
×
UNCOV
2049
    TAOS_RETURN(code);
×
2050
  }
2051
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
2,980!
2052

2053
  TAOS_RETURN(code);
2,980✔
2054
}
2055

2056
static int32_t mndSetAlterStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
2,980✔
2057
  int32_t  code = 0;
2,980✔
2058
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
2,980✔
2059
  if (pCommitRaw == NULL) {
2,980!
2060
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2061
    if (terrno != 0) code = terrno;
×
UNCOV
2062
    TAOS_RETURN(code);
×
2063
  }
2064
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
2,980!
UNCOV
2065
    sdbFreeRaw(pCommitRaw);
×
UNCOV
2066
    TAOS_RETURN(code);
×
2067
  }
2068
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
2,980!
2069

2070
  TAOS_RETURN(code);
2,980✔
2071
}
2072

2073
static int32_t mndSetAlterStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, void *alterOriData,
2,980✔
2074
                                         int32_t alterOriDataLen) {
2075
  int32_t code = 0;
2,980✔
2076
  SSdb   *pSdb = pMnode->pSdb;
2,980✔
2077
  SVgObj *pVgroup = NULL;
2,980✔
2078
  void   *pIter = NULL;
2,980✔
2079
  int32_t contLen;
2080

2081
  while (1) {
9,779✔
2082
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
12,759✔
2083
    if (pIter == NULL) break;
12,759✔
2084
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
9,779✔
2085
      sdbRelease(pSdb, pVgroup);
3,481✔
2086
      continue;
3,481✔
2087
    }
2088

2089
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
6,298✔
2090
    if (pReq == NULL) {
6,298!
UNCOV
2091
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2092
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2093
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2094
      if (terrno != 0) code = terrno;
×
UNCOV
2095
      TAOS_RETURN(code);
×
2096
    }
2097
    STransAction action = {0};
6,298✔
2098
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
6,298✔
2099
    action.pCont = pReq;
6,298✔
2100
    action.contLen = contLen;
6,298✔
2101
    action.msgType = TDMT_VND_ALTER_STB;
6,298✔
2102
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
6,298!
2103
      taosMemoryFree(pReq);
×
2104
      sdbCancelFetch(pSdb, pIter);
×
2105
      sdbRelease(pSdb, pVgroup);
×
2106
      TAOS_RETURN(code);
×
2107
    }
2108
    sdbRelease(pSdb, pVgroup);
6,298✔
2109
  }
2110

2111
  TAOS_RETURN(code);
2,980✔
2112
}
2113

UNCOV
2114
static int32_t mndSetAlterStbRedoActions2(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
×
2115
                                          void *alterOriData, int32_t alterOriDataLen) {
2116
  int32_t code = 0;
×
2117
  SSdb   *pSdb = pMnode->pSdb;
×
2118
  SVgObj *pVgroup = NULL;
×
UNCOV
2119
  void   *pIter = NULL;
×
2120
  int32_t contLen;
2121

UNCOV
2122
  while (1) {
×
UNCOV
2123
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
UNCOV
2124
    if (pIter == NULL) break;
×
UNCOV
2125
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
×
2126
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2127
      continue;
×
2128
    }
2129

2130
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
×
2131
    if (pReq == NULL) {
×
UNCOV
2132
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2133
      sdbRelease(pSdb, pVgroup);
×
2134
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2135
      if (terrno != 0) code = terrno;
×
2136
      TAOS_RETURN(code);
×
2137
    }
2138
    STransAction action = {0};
×
2139
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
UNCOV
2140
    action.pCont = pReq;
×
UNCOV
2141
    action.contLen = contLen;
×
2142
    action.msgType = TDMT_VND_CREATE_INDEX;
×
2143
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
2144
      taosMemoryFree(pReq);
×
2145
      sdbCancelFetch(pSdb, pIter);
×
2146
      sdbRelease(pSdb, pVgroup);
×
2147
      TAOS_RETURN(code);
×
2148
    }
UNCOV
2149
    sdbRelease(pSdb, pVgroup);
×
2150
  }
2151

2152
  TAOS_RETURN(code);
×
2153
}
2154
static int32_t mndBuildStbSchemaImp(SDbObj *pDb, SStbObj *pStb, const char *tbName, STableMetaRsp *pRsp) {
16,328✔
2155
  int32_t code = 0;
16,328✔
2156
  taosRLockLatch(&pStb->lock);
16,328✔
2157

2158
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
16,328✔
2159
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
16,328!
2160
  if (pRsp->pSchemas == NULL) {
16,328!
2161
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2162
    code = terrno;
×
UNCOV
2163
    TAOS_RETURN(code);
×
2164
  }
2165
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
16,328!
2166
  if (pRsp->pSchemaExt == NULL) {
16,328!
UNCOV
2167
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2168
    code = terrno;
×
UNCOV
2169
    TAOS_RETURN(code);
×
2170
  }
2171

2172
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
16,328✔
2173
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
16,328✔
2174
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
16,328✔
2175
  pRsp->dbId = pDb->uid;
16,328✔
2176
  pRsp->numOfTags = pStb->numOfTags;
16,328✔
2177
  pRsp->numOfColumns = pStb->numOfColumns;
16,328✔
2178
  pRsp->precision = pDb->cfg.precision;
16,328✔
2179
  pRsp->tableType = TSDB_SUPER_TABLE;
16,328✔
2180
  pRsp->sversion = pStb->colVer;
16,328✔
2181
  pRsp->tversion = pStb->tagVer;
16,328✔
2182
  pRsp->suid = pStb->uid;
16,328✔
2183
  pRsp->tuid = pStb->uid;
16,328✔
2184

2185
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,433,641✔
2186
    SSchema *pSchema = &pRsp->pSchemas[i];
1,417,313✔
2187
    SSchema *pSrcSchema = &pStb->pColumns[i];
1,417,313✔
2188
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
1,417,313✔
2189
    pSchema->type = pSrcSchema->type;
1,417,313✔
2190
    pSchema->flags = pSrcSchema->flags;
1,417,313✔
2191
    pSchema->colId = pSrcSchema->colId;
1,417,313✔
2192
    pSchema->bytes = pSrcSchema->bytes;
1,417,313✔
2193
  }
2194

2195
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
163,943✔
2196
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
147,615✔
2197
    SSchema *pSrcSchema = &pStb->pTags[i];
147,615✔
2198
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
147,615✔
2199
    pSchema->type = pSrcSchema->type;
147,615✔
2200
    pSchema->flags = pSrcSchema->flags;
147,615✔
2201
    pSchema->colId = pSrcSchema->colId;
147,615✔
2202
    pSchema->bytes = pSrcSchema->bytes;
147,615✔
2203
  }
2204
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
1,433,641✔
2205
    SColCmpr   *pCmpr = &pStb->pCmpr[i];
1,417,313✔
2206
    SSchemaExt *pSchEx = &pRsp->pSchemaExt[i];
1,417,313✔
2207
    pSchEx->colId = pCmpr->id;
1,417,313✔
2208
    pSchEx->compress = pCmpr->alg;
1,417,313✔
2209
  }
2210

2211
  taosRUnLockLatch(&pStb->lock);
16,328✔
2212
  TAOS_RETURN(code);
16,328✔
2213
}
2214

2215
static int32_t mndBuildStbCfgImp(SDbObj *pDb, SStbObj *pStb, const char *tbName, STableCfgRsp *pRsp) {
33✔
2216
  int32_t code = 0;
33✔
2217
  taosRLockLatch(&pStb->lock);
33✔
2218

2219
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
33✔
2220
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
33!
2221
  if (pRsp->pSchemas == NULL) {
33!
UNCOV
2222
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2223
    code = terrno;
×
UNCOV
2224
    TAOS_RETURN(code);
×
2225
  }
2226

2227
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
33✔
2228
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
33✔
2229
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
33✔
2230
  pRsp->numOfTags = pStb->numOfTags;
33✔
2231
  pRsp->numOfColumns = pStb->numOfColumns;
33✔
2232
  pRsp->tableType = TSDB_SUPER_TABLE;
33✔
2233
  pRsp->delay1 = pStb->maxdelay[0];
33✔
2234
  pRsp->delay2 = pStb->maxdelay[1];
33✔
2235
  pRsp->watermark1 = pStb->watermark[0];
33✔
2236
  pRsp->watermark2 = pStb->watermark[1];
33✔
2237
  pRsp->ttl = pStb->ttl;
33✔
2238
  pRsp->commentLen = pStb->commentLen;
33✔
2239
  if (pStb->commentLen > 0) {
33!
UNCOV
2240
    pRsp->pComment = taosStrdup(pStb->comment);
×
2241
  }
2242

2243
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
157✔
2244
    SSchema *pSchema = &pRsp->pSchemas[i];
124✔
2245
    SSchema *pSrcSchema = &pStb->pColumns[i];
124✔
2246
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
124✔
2247
    pSchema->type = pSrcSchema->type;
124✔
2248
    pSchema->flags = pSrcSchema->flags;
124✔
2249
    pSchema->colId = pSrcSchema->colId;
124✔
2250
    pSchema->bytes = pSrcSchema->bytes;
124✔
2251
  }
2252

2253
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
94✔
2254
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
61✔
2255
    SSchema *pSrcSchema = &pStb->pTags[i];
61✔
2256
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
61✔
2257
    pSchema->type = pSrcSchema->type;
61✔
2258
    pSchema->flags = pSrcSchema->flags;
61✔
2259
    pSchema->colId = pSrcSchema->colId;
61✔
2260
    pSchema->bytes = pSrcSchema->bytes;
61✔
2261
  }
2262

2263
  if (pStb->numOfFuncs > 0) {
33!
UNCOV
2264
    pRsp->pFuncs = taosArrayDup(pStb->pFuncs, NULL);
×
2265
  }
2266

2267
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
33!
2268
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
157✔
2269
    SColCmpr *pCmpr = &pStb->pCmpr[i];
124✔
2270

2271
    SSchemaExt *pSchExt = &pRsp->pSchemaExt[i];
124✔
2272
    pSchExt->colId = pCmpr->id;
124✔
2273
    pSchExt->compress = pCmpr->alg;
124✔
2274
  }
2275

2276
  taosRUnLockLatch(&pStb->lock);
33✔
2277
  TAOS_RETURN(code);
33✔
2278
}
2279

2280
static int32_t mndValidateStbVersion(SMnode *pMnode, SSTableVersion *pStbVer, bool *schema, bool *sma) {
8,860✔
2281
  int32_t code = 0;
8,860✔
2282
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
8,860✔
2283
  snprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVer->dbFName, pStbVer->stbName);
8,860✔
2284

2285
  SDbObj *pDb = mndAcquireDb(pMnode, pStbVer->dbFName);
8,860✔
2286
  if (pDb == NULL) {
8,860✔
2287
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
441✔
2288
    TAOS_RETURN(code);
441✔
2289
  }
2290

2291
  if (pDb->uid != pStbVer->dbId) {
8,419✔
2292
    mndReleaseDb(pMnode, pDb);
183✔
2293
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
183✔
2294
    TAOS_RETURN(code);
183✔
2295
  }
2296

2297
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
8,236✔
2298
  if (pStb == NULL) {
8,236✔
2299
    mndReleaseDb(pMnode, pDb);
112✔
2300
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
112✔
2301
    TAOS_RETURN(code);
112✔
2302
  }
2303

2304
  taosRLockLatch(&pStb->lock);
8,124✔
2305

2306
  if (pStbVer->sversion != pStb->colVer || pStbVer->tversion != pStb->tagVer) {
8,124✔
2307
    *schema = true;
16✔
2308
  } else {
2309
    *schema = false;
8,108✔
2310
  }
2311

2312
  if (pStbVer->smaVer && pStbVer->smaVer != pStb->smaVer) {
8,124!
UNCOV
2313
    *sma = true;
×
2314
  } else {
2315
    *sma = false;
8,124✔
2316
  }
2317

2318
  taosRUnLockLatch(&pStb->lock);
8,124✔
2319

2320
  mndReleaseDb(pMnode, pDb);
8,124✔
2321
  mndReleaseStb(pMnode, pStb);
8,124✔
2322
  return TSDB_CODE_SUCCESS;
8,124✔
2323
}
2324

2325
static int32_t mndBuildStbSchema(SMnode *pMnode, const char *dbFName, const char *tbName, STableMetaRsp *pRsp) {
8,277✔
2326
  int32_t code = 0;
8,277✔
2327
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
8,277✔
2328
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
8,277✔
2329

2330
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
8,277✔
2331
  if (pDb == NULL) {
8,277!
UNCOV
2332
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
2333
    TAOS_RETURN(code);
×
2334
  }
2335

2336
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
8,277✔
2337
  if (pStb == NULL) {
8,277✔
2338
    mndReleaseDb(pMnode, pDb);
529✔
2339
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
529✔
2340
    TAOS_RETURN(code);
529✔
2341
  }
2342

2343
  code = mndBuildStbSchemaImp(pDb, pStb, tbName, pRsp);
7,748✔
2344
  mndReleaseDb(pMnode, pDb);
7,748✔
2345
  mndReleaseStb(pMnode, pStb);
7,748✔
2346
  TAOS_RETURN(code);
7,748✔
2347
}
2348

2349
static int32_t mndBuildStbCfg(SMnode *pMnode, const char *dbFName, const char *tbName, STableCfgRsp *pRsp) {
33✔
2350
  int32_t code = 0;
33✔
2351
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
33✔
2352
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
33✔
2353

2354
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
33✔
2355
  if (pDb == NULL) {
33!
UNCOV
2356
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
2357
    TAOS_RETURN(code);
×
2358
  }
2359

2360
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
33✔
2361
  if (pStb == NULL) {
33!
UNCOV
2362
    mndReleaseDb(pMnode, pDb);
×
UNCOV
2363
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
UNCOV
2364
    TAOS_RETURN(code);
×
2365
  }
2366

2367
  code = mndBuildStbCfgImp(pDb, pStb, tbName, pRsp);
33✔
2368

2369
  mndReleaseDb(pMnode, pDb);
33✔
2370
  mndReleaseStb(pMnode, pStb);
33✔
2371
  TAOS_RETURN(code);
33✔
2372
}
2373

2374
static int32_t mndBuildSMAlterStbRsp(SDbObj *pDb, SStbObj *pObj, void **pCont, int32_t *pLen) {
2,885✔
2375
  int32_t       code = 0;
2,885✔
2376
  SEncoder      ec = {0};
2,885✔
2377
  uint32_t      contLen = 0;
2,885✔
2378
  SMAlterStbRsp alterRsp = {0};
2,885✔
2379
  SName         name = {0};
2,885✔
2380
  TAOS_CHECK_RETURN(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
2,885!
2381

2382
  alterRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
2,885!
2383
  if (NULL == alterRsp.pMeta) {
2,885!
UNCOV
2384
    code = terrno;
×
UNCOV
2385
    TAOS_RETURN(code);
×
2386
  }
2387

2388
  code = mndBuildStbSchemaImp(pDb, pObj, name.tname, alterRsp.pMeta);
2,885✔
2389
  if (code) {
2,885!
UNCOV
2390
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2391
    return code;
×
2392
  }
2393

2394
  tEncodeSize(tEncodeSMAlterStbRsp, &alterRsp, contLen, code);
2,885!
2395
  if (code) {
2,885!
2396
    tFreeSMAlterStbRsp(&alterRsp);
×
2397
    return code;
×
2398
  }
2399

2400
  void *cont = taosMemoryMalloc(contLen);
2,885!
2401
  if (NULL == cont) {
2,885!
2402
    code = terrno;
×
2403
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2404
    TAOS_RETURN(code);
×
2405
  }
2406
  tEncoderInit(&ec, cont, contLen);
2,885✔
2407
  code = tEncodeSMAlterStbRsp(&ec, &alterRsp);
2,885✔
2408
  tEncoderClear(&ec);
2,885✔
2409

2410
  tFreeSMAlterStbRsp(&alterRsp);
2,885✔
2411

2412
  if (code < 0) TAOS_RETURN(code);
2,885!
2413

2414
  *pCont = cont;
2,885✔
2415
  *pLen = contLen;
2,885✔
2416

2417
  TAOS_RETURN(code);
2,885✔
2418
}
2419

2420
int32_t mndBuildSMCreateStbRsp(SMnode *pMnode, char *dbFName, char *stbFName, void **pCont, int32_t *pLen) {
5,698✔
2421
  int32_t code = -1;
5,698✔
2422
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
5,698✔
2423
  if (NULL == pDb) {
5,698!
UNCOV
2424
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2425
    if (terrno != 0) code = terrno;
×
UNCOV
2426
    TAOS_RETURN(code);
×
2427
  }
2428

2429
  SStbObj *pObj = mndAcquireStb(pMnode, stbFName);
5,698✔
2430
  if (NULL == pObj) {
5,698✔
2431
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
3✔
2432
    if (terrno != 0) code = terrno;
3!
2433
    goto _OVER;
3✔
2434
  }
2435

2436
  SEncoder       ec = {0};
5,695✔
2437
  uint32_t       contLen = 0;
5,695✔
2438
  SMCreateStbRsp stbRsp = {0};
5,695✔
2439
  SName          name = {0};
5,695✔
2440
  TAOS_CHECK_GOTO(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE), NULL, _OVER);
5,695!
2441

2442
  stbRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
5,695!
2443
  if (NULL == stbRsp.pMeta) {
5,695!
UNCOV
2444
    code = terrno;
×
UNCOV
2445
    goto _OVER;
×
2446
  }
2447

2448
  code = mndBuildStbSchemaImp(pDb, pObj, name.tname, stbRsp.pMeta);
5,695✔
2449
  if (code) {
5,695!
UNCOV
2450
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2451
    goto _OVER;
×
2452
  }
2453

2454
  tEncodeSize(tEncodeSMCreateStbRsp, &stbRsp, contLen, code);
5,695!
2455
  if (code) {
5,695!
2456
    tFreeSMCreateStbRsp(&stbRsp);
×
2457
    goto _OVER;
×
2458
  }
2459

2460
  void *cont = taosMemoryMalloc(contLen);
5,695!
2461
  if (NULL == cont) {
5,695!
2462
    code = terrno;
×
2463
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2464
    goto _OVER;
×
2465
  }
2466
  tEncoderInit(&ec, cont, contLen);
5,695✔
2467
  TAOS_CHECK_GOTO(tEncodeSMCreateStbRsp(&ec, &stbRsp), NULL, _OVER);
5,695!
2468
  tEncoderClear(&ec);
5,695✔
2469

2470
  tFreeSMCreateStbRsp(&stbRsp);
5,695✔
2471

2472
  *pCont = cont;
5,695✔
2473
  *pLen = contLen;
5,695✔
2474

2475
  code = 0;
5,695✔
2476

2477
_OVER:
5,698✔
2478
  if (pObj) {
5,698✔
2479
    mndReleaseStb(pMnode, pObj);
5,695✔
2480
  }
2481

2482
  if (pDb) {
5,698!
2483
    mndReleaseDb(pMnode, pDb);
5,698✔
2484
  }
2485

2486
  TAOS_RETURN(code);
5,698✔
2487
}
2488

2489
static int32_t mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
1,973✔
2490
                              void *alterOriData, int32_t alterOriDataLen) {
2491
  int32_t code = -1;
1,973✔
2492
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
1,973✔
2493
  if (pTrans == NULL) {
1,973!
UNCOV
2494
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2495
    if (terrno != 0) code = terrno;
×
UNCOV
2496
    goto _OVER;
×
2497
  }
2498

2499
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
1,973!
2500
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
1,973✔
2501
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
1,973!
2502

2503
  if (needRsp) {
1,973✔
2504
    void   *pCont = NULL;
1,878✔
2505
    int32_t contLen = 0;
1,878✔
2506
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
1,878!
2507
    mndTransSetRpcRsp(pTrans, pCont, contLen);
1,878✔
2508
  }
2509

2510
  TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
1,973!
2511
  TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
1,973!
2512
  TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
1,973!
2513
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
1,973!
2514

2515
  code = 0;
1,973✔
2516

2517
_OVER:
1,973✔
2518
  mndTransDrop(pTrans);
1,973✔
2519
  TAOS_RETURN(code);
1,973✔
2520
}
2521

2522
static int32_t mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
1,007✔
2523
                                             void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter) {
2524
  int32_t code = -1;
1,007✔
2525
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
1,007✔
2526
  if (pTrans == NULL) {
1,007!
UNCOV
2527
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2528
    if (terrno != 0) code = terrno;
×
UNCOV
2529
    goto _OVER;
×
2530
  }
2531

2532
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
1,007!
2533
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
1,007✔
2534

2535
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
1,007!
2536

2537
  if (needRsp) {
1,007!
2538
    void   *pCont = NULL;
1,007✔
2539
    int32_t contLen = 0;
1,007✔
2540
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
1,007!
2541
    mndTransSetRpcRsp(pTrans, pCont, contLen);
1,007✔
2542
  }
2543

2544
  if (pAlter->alterType == TSDB_ALTER_TABLE_DROP_TAG) {
1,007✔
2545
    SIdxObj idxObj = {0};
353✔
2546
    SField *pField0 = taosArrayGet(pAlter->pFields, 0);
353✔
2547
    bool    exist = false;
353✔
2548
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
353✔
2549
      exist = true;
6✔
2550
    }
2551
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
353!
2552
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
353!
2553

2554
    if (exist == true) {
353✔
2555
      TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
6!
2556
      TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
6!
2557
    }
2558

2559
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
353!
2560
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
353!
2561

2562
  } else if (pAlter->alterType == TSDB_ALTER_TABLE_UPDATE_TAG_NAME) {
654!
2563
    SIdxObj     idxObj = {0};
654✔
2564
    SField     *pField0 = taosArrayGet(pAlter->pFields, 0);
654✔
2565
    SField     *pField1 = taosArrayGet(pAlter->pFields, 1);
654✔
2566
    const char *oTagName = pField0->name;
654✔
2567
    const char *nTagName = pField1->name;
654✔
2568
    bool        exist = false;
654✔
2569

2570
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
654✔
2571
      exist = true;
33✔
2572
    }
2573

2574
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
654!
2575
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
654!
2576

2577
    if (exist == true) {
654✔
2578
      memcpy(idxObj.colName, nTagName, strlen(nTagName));
33✔
2579
      idxObj.colName[strlen(nTagName)] = 0;
33✔
2580
      TAOS_CHECK_GOTO(mndSetAlterIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
33!
2581
      TAOS_CHECK_GOTO(mndSetAlterIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
33!
2582
    }
2583

2584
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
654!
2585
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
654!
2586
  }
2587
  code = 0;
1,007✔
2588

2589
_OVER:
1,007✔
2590
  mndTransDrop(pTrans);
1,007✔
2591
  TAOS_RETURN(code);
1,007✔
2592
}
2593

2594
static int32_t mndAlterStb(SMnode *pMnode, SRpcMsg *pReq, const SMAlterStbReq *pAlter, SDbObj *pDb, SStbObj *pOld) {
3,091✔
2595
  bool    needRsp = true;
3,091✔
2596
  int32_t code = -1;
3,091✔
2597
  SField *pField0 = NULL;
3,091✔
2598

2599
  SStbObj stbObj = {0};
3,091✔
2600
  taosRLockLatch(&pOld->lock);
3,091✔
2601
  memcpy(&stbObj, pOld, sizeof(SStbObj));
3,091✔
2602
  taosRUnLockLatch(&pOld->lock);
3,091✔
2603
  stbObj.pColumns = NULL;
3,091✔
2604
  stbObj.pTags = NULL;
3,091✔
2605
  stbObj.pFuncs = NULL;
3,091✔
2606
  stbObj.pCmpr = NULL;
3,091✔
2607
  stbObj.updateTime = taosGetTimestampMs();
3,091✔
2608
  stbObj.lock = 0;
3,091✔
2609
  bool updateTagIndex = false;
3,091✔
2610
  switch (pAlter->alterType) {
3,091!
2611
    case TSDB_ALTER_TABLE_ADD_TAG:
471✔
2612
      code = mndAddSuperTableTag(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
471✔
2613
      break;
471✔
2614
    case TSDB_ALTER_TABLE_DROP_TAG:
385✔
2615
      pField0 = taosArrayGet(pAlter->pFields, 0);
385✔
2616
      code = mndDropSuperTableTag(pMnode, pOld, &stbObj, pField0->name);
385✔
2617
      updateTagIndex = true;
385✔
2618
      break;
385✔
2619
    case TSDB_ALTER_TABLE_UPDATE_TAG_NAME:
697✔
2620
      code = mndAlterStbTagName(pMnode, pOld, &stbObj, pAlter->pFields);
697✔
2621
      updateTagIndex = true;
697✔
2622
      break;
697✔
2623
    case TSDB_ALTER_TABLE_UPDATE_TAG_BYTES:
42✔
2624
      pField0 = taosArrayGet(pAlter->pFields, 0);
42✔
2625
      code = mndAlterStbTagBytes(pMnode, pOld, &stbObj, pField0);
42✔
2626
      break;
42✔
2627
    case TSDB_ALTER_TABLE_ADD_COLUMN:
1,187✔
2628
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields, 0);
1,187✔
2629
      break;
1,187✔
2630
    case TSDB_ALTER_TABLE_DROP_COLUMN:
200✔
2631
      pField0 = taosArrayGet(pAlter->pFields, 0);
200✔
2632
      code = mndDropSuperTableColumn(pMnode, pOld, &stbObj, pField0->name);
200✔
2633
      break;
200✔
2634
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
59✔
2635
      pField0 = taosArrayGet(pAlter->pFields, 0);
59✔
2636
      code = mndAlterStbColumnBytes(pMnode, pOld, &stbObj, pField0);
59✔
2637
      break;
59✔
2638
    case TSDB_ALTER_TABLE_UPDATE_OPTIONS:
22✔
2639
      needRsp = false;
22✔
2640
      code = mndUpdateTableOptions(pOld, &stbObj, pAlter->comment, pAlter->commentLen, pAlter->ttl, pAlter->keep);
22✔
2641
      break;
22✔
2642
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_COMPRESS:
26✔
2643
      code = mndUpdateSuperTableColumnCompress(pMnode, pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
26✔
2644
      break;
26✔
2645
    case TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COMPRESS_OPTION:
2✔
2646
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields, 1);
2✔
2647
      break;
2✔
UNCOV
2648
    default:
×
UNCOV
2649
      needRsp = false;
×
UNCOV
2650
      terrno = TSDB_CODE_OPS_NOT_SUPPORT;
×
UNCOV
2651
      break;
×
2652
  }
2653

2654
  if (code != 0) goto _OVER;
3,091✔
2655
  if (updateTagIndex == false) {
2,907✔
2656
    code = mndAlterStbImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen);
1,900✔
2657
  } else {
2658
    code = mndAlterStbAndUpdateTagIdxImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen, pAlter);
1,007✔
2659
  }
2660

2661
_OVER:
3,091✔
2662
  taosMemoryFreeClear(stbObj.pTags);
3,091!
2663
  taosMemoryFreeClear(stbObj.pColumns);
3,091!
2664
  taosMemoryFreeClear(stbObj.pCmpr);
3,091!
2665
  if (pAlter->commentLen > 0) {
3,091✔
2666
    taosMemoryFreeClear(stbObj.comment);
17!
2667
  }
2668
  TAOS_RETURN(code);
3,091✔
2669
}
2670

2671
static int32_t mndProcessAlterStbReq(SRpcMsg *pReq) {
3,095✔
2672
  SMnode       *pMnode = pReq->info.node;
3,095✔
2673
  int32_t       code = -1;
3,095✔
2674
  SDbObj       *pDb = NULL;
3,095✔
2675
  SStbObj      *pStb = NULL;
3,095✔
2676
  SMAlterStbReq alterReq = {0};
3,095✔
2677

2678
  if (tDeserializeSMAlterStbReq(pReq->pCont, pReq->contLen, &alterReq) != 0) {
3,095!
UNCOV
2679
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
2680
    goto _OVER;
×
2681
  }
2682

2683
  mInfo("stb:%s, start to alter", alterReq.name);
3,095!
2684
  if (mndCheckAlterStbReq(&alterReq) != 0) goto _OVER;
3,095!
2685

2686
  pDb = mndAcquireDbByStb(pMnode, alterReq.name);
3,095✔
2687
  if (pDb == NULL) {
3,095✔
2688
    code = TSDB_CODE_MND_DB_NOT_EXIST;
2✔
2689
    goto _OVER;
2✔
2690
  }
2691

2692
  pStb = mndAcquireStb(pMnode, alterReq.name);
3,093✔
2693
  if (pStb == NULL) {
3,093✔
2694
    code = TSDB_CODE_MND_STB_NOT_EXIST;
2✔
2695
    goto _OVER;
2✔
2696
  }
2697

2698
  if ((code = mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb)) != 0) {
3,091!
UNCOV
2699
    goto _OVER;
×
2700
  }
2701

2702
  code = mndAlterStb(pMnode, pReq, &alterReq, pDb, pStb);
3,091✔
2703
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
3,091✔
2704

2705
  SName   name = {0};
3,091✔
2706
  int32_t ret = 0;
3,091✔
2707
  if ((ret = tNameFromString(&name, alterReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
3,091!
UNCOV
2708
    mError("stb:%s, failed to tNameFromString since %s", alterReq.name, tstrerror(ret));
×
2709

2710
  auditRecord(pReq, pMnode->clusterId, "alterStb", name.dbname, name.tname, alterReq.sql, alterReq.sqlLen);
3,091✔
2711

2712
_OVER:
3,095✔
2713
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
3,095!
2714
    mError("stb:%s, failed to alter since %s", alterReq.name, tstrerror(code));
188!
2715
  }
2716

2717
  mndReleaseStb(pMnode, pStb);
3,095✔
2718
  mndReleaseDb(pMnode, pDb);
3,095✔
2719
  tFreeSMAltertbReq(&alterReq);
3,095✔
2720

2721
  TAOS_RETURN(code);
3,095✔
2722
}
2723

2724
static int32_t mndSetDropStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
456✔
2725
  int32_t  code = 0;
456✔
2726
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
456✔
2727
  if (pRedoRaw == NULL) {
456!
UNCOV
2728
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2729
    if (terrno != 0) code = terrno;
×
UNCOV
2730
    TAOS_RETURN(code);
×
2731
  }
2732
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
456!
UNCOV
2733
    sdbFreeRaw(pRedoRaw);
×
UNCOV
2734
    TAOS_RETURN(code);
×
2735
  }
2736
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
456!
2737

2738
  TAOS_RETURN(code);
456✔
2739
}
2740

2741
static int32_t mndSetDropStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
456✔
2742
  int32_t  code = 0;
456✔
2743
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
456✔
2744
  if (pCommitRaw == NULL) {
456!
2745
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2746
    if (terrno != 0) code = terrno;
×
UNCOV
2747
    TAOS_RETURN(code);
×
2748
  }
2749
  if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
456!
UNCOV
2750
    sdbFreeRaw(pCommitRaw);
×
UNCOV
2751
    TAOS_RETURN(code);
×
2752
  }
2753
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
456!
2754

2755
  TAOS_RETURN(code);
456✔
2756
}
2757

2758
static int32_t mndSetDropStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
456✔
2759
  int32_t code = 0;
456✔
2760
  SSdb   *pSdb = pMnode->pSdb;
456✔
2761
  SVgObj *pVgroup = NULL;
456✔
2762
  void   *pIter = NULL;
456✔
2763

2764
  while (1) {
1,969✔
2765
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
2,425✔
2766
    if (pIter == NULL) break;
2,425✔
2767
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
1,969✔
2768
      sdbRelease(pSdb, pVgroup);
676✔
2769
      continue;
676✔
2770
    }
2771

2772
    int32_t contLen = 0;
1,293✔
2773
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
1,293✔
2774
    if (pReq == NULL) {
1,293!
UNCOV
2775
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2776
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2777
      code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
2778
      TAOS_RETURN(code);
×
2779
    }
2780

2781
    STransAction action = {0};
1,293✔
2782
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
1,293✔
2783
    action.pCont = pReq;
1,293✔
2784
    action.contLen = contLen;
1,293✔
2785
    action.msgType = TDMT_VND_DROP_STB;
1,293✔
2786
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
1,293✔
2787
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
1,293!
2788
      taosMemoryFree(pReq);
×
2789
      sdbCancelFetch(pSdb, pIter);
×
2790
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2791
      TAOS_RETURN(code);
×
2792
    }
2793
    sdbRelease(pSdb, pVgroup);
1,293✔
2794
  }
2795

2796
  TAOS_RETURN(code);
456✔
2797
}
2798

2799
static int32_t mndDropStb(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb) {
456✔
2800
  int32_t code = -1;
456✔
2801
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "drop-stb");
456✔
2802
  if (pTrans == NULL) {
456!
2803
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2804
    if (terrno != 0) code = terrno;
×
UNCOV
2805
    goto _OVER;
×
2806
  }
2807

2808
  mInfo("trans:%d, used to drop stb:%s", pTrans->id, pStb->name);
456!
2809
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
456✔
2810
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
456!
2811

2812
  TAOS_CHECK_GOTO(mndSetDropStbPrepareLogs(pMnode, pTrans, pStb), NULL, _OVER);
456!
2813
  TAOS_CHECK_GOTO(mndSetDropStbCommitLogs(pMnode, pTrans, pStb), NULL, _OVER);
456!
2814
  TAOS_CHECK_GOTO(mndSetDropStbRedoActions(pMnode, pTrans, pDb, pStb), NULL, _OVER);
456!
2815
  TAOS_CHECK_GOTO(mndDropIdxsByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
456!
2816
  TAOS_CHECK_GOTO(mndDropSmasByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
456!
2817
  TAOS_CHECK_GOTO(mndUserRemoveStb(pMnode, pTrans, pStb->name), NULL, _OVER);
456!
2818
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
456!
2819
  code = 0;
456✔
2820

2821
_OVER:
456✔
2822
  mndTransDrop(pTrans);
456✔
2823
  TAOS_RETURN(code);
456✔
2824
}
2825

2826
static int32_t mndCheckDropStbForTopic(SMnode *pMnode, const char *stbFullName, int64_t suid) {
460✔
2827
  int32_t code = 0;
460✔
2828
  SSdb   *pSdb = pMnode->pSdb;
460✔
2829
  void   *pIter = NULL;
460✔
2830
  while (1) {
80✔
2831
    SMqTopicObj *pTopic = NULL;
540✔
2832
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
540✔
2833
    if (pIter == NULL) break;
540✔
2834

2835
    if (pTopic->subType == TOPIC_SUB_TYPE__TABLE) {
80✔
2836
      if (pTopic->stbUid == suid) {
14!
UNCOV
2837
        sdbRelease(pSdb, pTopic);
×
UNCOV
2838
        sdbCancelFetch(pSdb, pIter);
×
UNCOV
2839
        TAOS_RETURN(-1);
×
2840
      }
2841
    }
2842

2843
    if (pTopic->ast == NULL) {
80✔
2844
      sdbRelease(pSdb, pTopic);
38✔
2845
      continue;
38✔
2846
    }
2847

2848
    SNode *pAst = NULL;
42✔
2849
    if (nodesStringToNode(pTopic->ast, &pAst) != 0) {
42!
2850
      code = TSDB_CODE_MND_INVALID_TOPIC_OPTION;
×
2851
      mError("topic:%s, create ast error", pTopic->name);
×
UNCOV
2852
      sdbRelease(pSdb, pTopic);
×
UNCOV
2853
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2854
      TAOS_RETURN(code);
×
2855
    }
2856

2857
    SNodeList *pNodeList = NULL;
42✔
2858
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
42!
2859
        0) {
UNCOV
2860
      sdbRelease(pSdb, pTopic);
×
UNCOV
2861
      sdbCancelFetch(pSdb, pIter);
×
2862
      TAOS_RETURN(code);
×
2863
    }
2864
    SNode *pNode = NULL;
42✔
2865
    FOREACH(pNode, pNodeList) {
42✔
2866
      SColumnNode *pCol = (SColumnNode *)pNode;
28✔
2867

2868
      if (pCol->tableId == suid) {
28!
UNCOV
2869
        sdbRelease(pSdb, pTopic);
×
UNCOV
2870
        nodesDestroyNode(pAst);
×
UNCOV
2871
        nodesDestroyList(pNodeList);
×
2872
        sdbCancelFetch(pSdb, pIter);
×
2873
        TAOS_RETURN(-1);
×
2874
      } else {
2875
        goto NEXT;
28✔
2876
      }
2877
    }
2878
  NEXT:
14✔
2879
    sdbRelease(pSdb, pTopic);
42✔
2880
    nodesDestroyNode(pAst);
42✔
2881
    nodesDestroyList(pNodeList);
42✔
2882
  }
2883
  TAOS_RETURN(code);
460✔
2884
}
2885

2886
static int32_t mndCheckDropStbForStream(SMnode *pMnode, const char *stbFullName, int64_t suid) {
460✔
2887
  int32_t code = 0;
460✔
2888
  SSdb   *pSdb = pMnode->pSdb;
460✔
2889
  void   *pIter = NULL;
460✔
2890
  while (1) {
146✔
2891
    SStreamObj *pStream = NULL;
606✔
2892
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
606✔
2893
    if (pIter == NULL) break;
606✔
2894

2895
    if (pStream->targetStbUid == suid) {
150!
UNCOV
2896
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2897
      sdbRelease(pSdb, pStream);
×
2898
      TAOS_RETURN(-1);
4✔
2899
    }
2900

2901
    SNode *pAst = NULL;
150✔
2902
    if (nodesStringToNode(pStream->ast, &pAst) != 0) {
150!
UNCOV
2903
      code = TSDB_CODE_MND_INVALID_STREAM_OPTION;
×
UNCOV
2904
      mError("stream:%s, create ast error", pStream->name);
×
UNCOV
2905
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2906
      sdbRelease(pSdb, pStream);
×
UNCOV
2907
      TAOS_RETURN(code);
×
2908
    }
2909

2910
    SNodeList *pNodeList = NULL;
150✔
2911
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
150!
2912
        0) {
UNCOV
2913
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2914
      sdbRelease(pSdb, pStream);
×
2915
      TAOS_RETURN(code);
×
2916
    }
2917
    SNode *pNode = NULL;
150✔
2918
    FOREACH(pNode, pNodeList) {
150!
2919
      SColumnNode *pCol = (SColumnNode *)pNode;
150✔
2920

2921
      if (pCol->tableId == suid) {
150✔
2922
        sdbCancelFetch(pSdb, pIter);
4✔
2923
        sdbRelease(pSdb, pStream);
4✔
2924
        nodesDestroyNode(pAst);
4✔
2925
        nodesDestroyList(pNodeList);
4✔
2926
        TAOS_RETURN(-1);
4✔
2927
      } else {
2928
        goto NEXT;
146✔
2929
      }
2930
    }
UNCOV
2931
  NEXT:
×
2932
    sdbRelease(pSdb, pStream);
146✔
2933
    nodesDestroyNode(pAst);
146✔
2934
    nodesDestroyList(pNodeList);
146✔
2935
  }
2936
  TAOS_RETURN(code);
456✔
2937
}
2938

UNCOV
2939
static int32_t mndProcessDropTtltbRsp(SRpcMsg *pRsp) { return 0; }
×
2940
static int32_t mndProcessTrimDbRsp(SRpcMsg *pRsp) { return 0; }
2✔
UNCOV
2941
static int32_t mndProcessS3MigrateDbRsp(SRpcMsg *pRsp) { return 0; }
×
2942

2943
static int32_t mndProcessDropStbReq(SRpcMsg *pReq) {
771✔
2944
  SMnode      *pMnode = pReq->info.node;
771✔
2945
  int32_t      code = -1;
771✔
2946
  SDbObj      *pDb = NULL;
771✔
2947
  SStbObj     *pStb = NULL;
771✔
2948
  SMDropStbReq dropReq = {0};
771✔
2949

2950
  TAOS_CHECK_GOTO(tDeserializeSMDropStbReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
771!
2951

2952
  mInfo("stb:%s, start to drop", dropReq.name);
771!
2953

2954
  pStb = mndAcquireStb(pMnode, dropReq.name);
771✔
2955
  if (pStb == NULL) {
771✔
2956
    if (dropReq.igNotExists) {
311✔
2957
      mInfo("stb:%s, not exist, ignore not exist is set", dropReq.name);
309!
2958
      code = 0;
309✔
2959
      goto _OVER;
309✔
2960
    } else {
2961
      code = TSDB_CODE_MND_STB_NOT_EXIST;
2✔
2962
      goto _OVER;
2✔
2963
    }
2964
  }
2965

2966
  if ((dropReq.source == TD_REQ_FROM_TAOX_OLD || dropReq.source == TD_REQ_FROM_TAOX) && pStb->uid != dropReq.suid) {
460!
UNCOV
2967
    code = 0;
×
UNCOV
2968
    goto _OVER;
×
2969
  }
2970

2971
  pDb = mndAcquireDbByStb(pMnode, dropReq.name);
460✔
2972
  if (pDb == NULL) {
460!
UNCOV
2973
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
2974
    goto _OVER;
×
2975
  }
2976

2977
  if ((code = mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb)) != 0) {
460!
UNCOV
2978
    goto _OVER;
×
2979
  }
2980

2981
  if (mndCheckDropStbForTopic(pMnode, dropReq.name, pStb->uid) < 0) {
460!
UNCOV
2982
    code = TSDB_CODE_MND_TOPIC_MUST_BE_DELETED;
×
UNCOV
2983
    goto _OVER;
×
2984
  }
2985

2986
  if (mndCheckDropStbForStream(pMnode, dropReq.name, pStb->uid) < 0) {
460✔
2987
    code = TSDB_CODE_MND_STREAM_MUST_BE_DELETED;
4✔
2988
    goto _OVER;
4✔
2989
  }
2990

2991
  code = mndDropStb(pMnode, pReq, pDb, pStb);
456✔
2992
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
456!
2993

2994
  SName   name = {0};
456✔
2995
  int32_t ret = 0;
456✔
2996
  if ((ret = tNameFromString(&name, dropReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
456!
UNCOV
2997
    mError("stb:%s, failed to tNameFromString since %s", dropReq.name, tstrerror(ret));
×
2998

2999
  auditRecord(pReq, pMnode->clusterId, "dropStb", name.dbname, name.tname, dropReq.sql, dropReq.sqlLen);
456✔
3000

3001
_OVER:
771✔
3002
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
771✔
3003
    mError("stb:%s, failed to drop since %s", dropReq.name, tstrerror(code));
6!
3004
  }
3005

3006
  mndReleaseDb(pMnode, pDb);
771✔
3007
  mndReleaseStb(pMnode, pStb);
771✔
3008
  tFreeSMDropStbReq(&dropReq);
771✔
3009
  TAOS_RETURN(code);
771✔
3010
}
3011

3012
static int32_t mndProcessTableMetaReq(SRpcMsg *pReq) {
9,817✔
3013
  SMnode       *pMnode = pReq->info.node;
9,817✔
3014
  int32_t       code = -1;
9,817✔
3015
  STableInfoReq infoReq = {0};
9,817✔
3016
  STableMetaRsp metaRsp = {0};
9,817✔
3017
  SUserObj     *pUser = NULL;
9,817✔
3018

3019
  code = mndAcquireUser(pMnode, pReq->info.conn.user, &pUser);
9,817✔
3020
  if (pUser == NULL) return 0;
9,818!
3021
  bool sysinfo = pUser->sysInfo;
9,818✔
3022

3023
  TAOS_CHECK_GOTO(tDeserializeSTableInfoReq(pReq->pCont, pReq->contLen, &infoReq), NULL, _OVER);
9,818!
3024

3025
  if (0 == strcmp(infoReq.dbFName, TSDB_INFORMATION_SCHEMA_DB)) {
9,818✔
3026
    mInfo("information_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
1,391!
3027
    TAOS_CHECK_GOTO(mndBuildInsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, sysinfo, &metaRsp), NULL, _OVER);
1,391✔
3028
  } else if (0 == strcmp(infoReq.dbFName, TSDB_PERFORMANCE_SCHEMA_DB)) {
8,427✔
3029
    mInfo("performance_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
166!
3030
    TAOS_CHECK_GOTO(mndBuildPerfsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp), NULL, _OVER);
166✔
3031
  } else {
3032
    mInfo("stb:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
8,261✔
3033
    TAOS_CHECK_GOTO(mndBuildStbSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp), NULL, _OVER);
8,262✔
3034
  }
3035

3036
  int32_t rspLen = tSerializeSTableMetaRsp(NULL, 0, &metaRsp);
9,069✔
3037
  if (rspLen < 0) {
9,069!
UNCOV
3038
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3039
    goto _OVER;
×
3040
  }
3041

3042
  void *pRsp = rpcMallocCont(rspLen);
9,069✔
3043
  if (pRsp == NULL) {
9,069!
UNCOV
3044
    code = terrno;
×
UNCOV
3045
    goto _OVER;
×
3046
  }
3047

3048
  if ((rspLen = tSerializeSTableMetaRsp(pRsp, rspLen, &metaRsp)) < 0) {
9,069!
UNCOV
3049
    code = rspLen;
×
3050
    goto _OVER;
×
3051
  }
3052
  pReq->info.rsp = pRsp;
9,069✔
3053
  pReq->info.rspLen = rspLen;
9,069✔
3054
  code = 0;
9,069✔
3055

3056
  mTrace("%s.%s, meta is retrieved", infoReq.dbFName, infoReq.tbName);
9,069✔
3057

3058
_OVER:
7,434✔
3059
  if (code != 0) {
9,818✔
3060
    mError("stb:%s.%s, failed to retrieve meta since %s", infoReq.dbFName, infoReq.tbName, tstrerror(code));
749!
3061
  }
3062

3063
  mndReleaseUser(pMnode, pUser);
9,818✔
3064
  tFreeSTableMetaRsp(&metaRsp);
9,818✔
3065
  // TODO change to TAOS_RETURN
3066
  return code;
9,818✔
3067
}
3068

3069
static int32_t mndProcessTableCfgReq(SRpcMsg *pReq) {
33✔
3070
  SMnode      *pMnode = pReq->info.node;
33✔
3071
  int32_t      code = -1;
33✔
3072
  STableCfgReq cfgReq = {0};
33✔
3073
  STableCfgRsp cfgRsp = {0};
33✔
3074

3075
  TAOS_CHECK_GOTO(tDeserializeSTableCfgReq(pReq->pCont, pReq->contLen, &cfgReq), NULL, _OVER);
33!
3076

3077
  char dbName[TSDB_DB_NAME_LEN] = {0};
33✔
3078
  TAOS_CHECK_GOTO(mndExtractShortDbNameFromDbFullName(cfgReq.dbFName, dbName), NULL, _OVER);
33!
3079
  if (0 == strcmp(dbName, TSDB_INFORMATION_SCHEMA_DB)) {
33!
UNCOV
3080
    mInfo("information_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
×
UNCOV
3081
    TAOS_CHECK_GOTO(mndBuildInsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
×
3082
  } else if (0 == strcmp(dbName, TSDB_PERFORMANCE_SCHEMA_DB)) {
33!
UNCOV
3083
    mInfo("performance_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
×
UNCOV
3084
    TAOS_CHECK_GOTO(mndBuildPerfsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
×
3085
  } else {
3086
    mInfo("stb:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
33!
3087
    TAOS_CHECK_GOTO(mndBuildStbCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
33!
3088
  }
3089

3090
  int32_t rspLen = tSerializeSTableCfgRsp(NULL, 0, &cfgRsp);
33✔
3091
  if (rspLen < 0) {
33!
3092
    code = TSDB_CODE_INVALID_MSG;
×
3093
    goto _OVER;
×
3094
  }
3095

3096
  void *pRsp = rpcMallocCont(rspLen);
33✔
3097
  if (pRsp == NULL) {
33!
UNCOV
3098
    code = terrno;
×
UNCOV
3099
    goto _OVER;
×
3100
  }
3101

3102
  if ((rspLen = tSerializeSTableCfgRsp(pRsp, rspLen, &cfgRsp)) < 0) {
33!
UNCOV
3103
    code = rspLen;
×
3104
    goto _OVER;
×
3105
  }
3106
  pReq->info.rsp = pRsp;
33✔
3107
  pReq->info.rspLen = rspLen;
33✔
3108
  code = 0;
33✔
3109

3110
  mTrace("%s.%s, cfg is retrieved", cfgReq.dbFName, cfgReq.tbName);
33✔
3111

3112
_OVER:
28✔
3113
  if (code != 0) {
33!
UNCOV
3114
    mError("stb:%s.%s, failed to retrieve cfg since %s", cfgReq.dbFName, cfgReq.tbName, tstrerror(code));
×
3115
  }
3116

3117
  tFreeSTableCfgRsp(&cfgRsp);
33✔
3118
  TAOS_RETURN(code);
33✔
3119
}
3120

3121
int32_t mndValidateStbInfo(SMnode *pMnode, SSTableVersion *pStbVersions, int32_t numOfStbs, void **ppRsp,
6,801✔
3122
                           int32_t *pRspLen) {
3123
  int32_t   code = 0;
6,801✔
3124
  SSTbHbRsp hbRsp = {0};
6,801✔
3125
  hbRsp.pMetaRsp = taosArrayInit(numOfStbs, sizeof(STableMetaRsp));
6,801✔
3126
  if (hbRsp.pMetaRsp == NULL) {
6,801!
UNCOV
3127
    code = terrno;
×
UNCOV
3128
    TAOS_RETURN(code);
×
3129
  }
3130

3131
  hbRsp.pIndexRsp = taosArrayInit(numOfStbs, sizeof(STableIndexRsp));
6,801✔
3132
  if (NULL == hbRsp.pIndexRsp) {
6,801!
UNCOV
3133
    taosArrayDestroy(hbRsp.pMetaRsp);
×
UNCOV
3134
    code = terrno;
×
UNCOV
3135
    TAOS_RETURN(code);
×
3136
  }
3137

3138
  for (int32_t i = 0; i < numOfStbs; ++i) {
15,661✔
3139
    SSTableVersion *pStbVersion = &pStbVersions[i];
8,860✔
3140
    pStbVersion->suid = be64toh(pStbVersion->suid);
8,860✔
3141
    pStbVersion->sversion = ntohl(pStbVersion->sversion);
8,860✔
3142
    pStbVersion->tversion = ntohl(pStbVersion->tversion);
8,860✔
3143
    pStbVersion->smaVer = ntohl(pStbVersion->smaVer);
8,860✔
3144

3145
    bool    schema = false;
8,860✔
3146
    bool    sma = false;
8,860✔
3147
    int32_t code = mndValidateStbVersion(pMnode, pStbVersion, &schema, &sma);
8,860✔
3148
    if (TSDB_CODE_SUCCESS != code) {
8,860✔
3149
      STableMetaRsp metaRsp = {0};
736✔
3150
      metaRsp.numOfColumns = -1;
736✔
3151
      metaRsp.suid = pStbVersion->suid;
736✔
3152
      tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
736✔
3153
      tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
736✔
3154
      tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
736✔
3155
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
1,472!
UNCOV
3156
        code = terrno;
×
UNCOV
3157
        return code;
×
3158
      }
3159
      continue;
736✔
3160
    }
3161

3162
    if (schema) {
8,124✔
3163
      STableMetaRsp metaRsp = {0};
16✔
3164
      mInfo("stb:%s.%s, start to retrieve meta", pStbVersion->dbFName, pStbVersion->stbName);
16!
3165
      if (mndBuildStbSchema(pMnode, pStbVersion->dbFName, pStbVersion->stbName, &metaRsp) != 0) {
16!
UNCOV
3166
        metaRsp.numOfColumns = -1;
×
UNCOV
3167
        metaRsp.suid = pStbVersion->suid;
×
3168
        tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
×
3169
        tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
×
UNCOV
3170
        tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
×
UNCOV
3171
        if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
×
UNCOV
3172
          code = terrno;
×
UNCOV
3173
          return code;
×
3174
        }
UNCOV
3175
        continue;
×
3176
      }
3177

3178
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
32!
3179
        code = terrno;
×
3180
        return code;
×
3181
      }
3182
    }
3183

3184
    if (sma) {
8,124!
3185
      bool           exist = false;
×
3186
      char           tbFName[TSDB_TABLE_FNAME_LEN];
3187
      STableIndexRsp indexRsp = {0};
×
UNCOV
3188
      indexRsp.pIndex = taosArrayInit(10, sizeof(STableIndexInfo));
×
UNCOV
3189
      if (NULL == indexRsp.pIndex) {
×
UNCOV
3190
        code = terrno;
×
3191
        TAOS_RETURN(code);
×
3192
      }
3193

UNCOV
3194
      (void)tsnprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVersion->dbFName, pStbVersion->stbName);
×
UNCOV
3195
      int32_t code = mndGetTableSma(pMnode, tbFName, &indexRsp, &exist);
×
UNCOV
3196
      if (code || !exist) {
×
3197
        indexRsp.suid = pStbVersion->suid;
×
UNCOV
3198
        indexRsp.version = -1;
×
3199
        indexRsp.pIndex = NULL;
×
3200
      }
3201

3202
      tstrncpy(indexRsp.dbFName, pStbVersion->dbFName, sizeof(indexRsp.dbFName));
×
3203
      tstrncpy(indexRsp.tbName, pStbVersion->stbName, sizeof(indexRsp.tbName));
×
3204

UNCOV
3205
      if (taosArrayPush(hbRsp.pIndexRsp, &indexRsp) == NULL) {
×
3206
        code = terrno;
×
3207
        return code;
×
3208
      }
3209
    }
3210
  }
3211

3212
  int32_t rspLen = tSerializeSSTbHbRsp(NULL, 0, &hbRsp);
6,801✔
3213
  if (rspLen < 0) {
6,801!
3214
    tFreeSSTbHbRsp(&hbRsp);
×
3215
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3216
    TAOS_RETURN(code);
×
3217
  }
3218

3219
  void *pRsp = taosMemoryMalloc(rspLen);
6,801!
3220
  if (pRsp == NULL) {
6,801!
UNCOV
3221
    tFreeSSTbHbRsp(&hbRsp);
×
UNCOV
3222
    code = terrno;
×
UNCOV
3223
    TAOS_RETURN(code);
×
3224
  }
3225

3226
  rspLen = tSerializeSSTbHbRsp(pRsp, rspLen, &hbRsp);
6,801✔
3227
  tFreeSSTbHbRsp(&hbRsp);
6,801✔
3228
  if (rspLen < 0) return rspLen;
6,801!
3229
  *ppRsp = pRsp;
6,801✔
3230
  *pRspLen = rspLen;
6,801✔
3231
  TAOS_RETURN(code);
6,801✔
3232
}
3233

3234
int32_t mndGetNumOfStbs(SMnode *pMnode, char *dbName, int32_t *pNumOfStbs) {
7,295✔
3235
  int32_t code = 0;
7,295✔
3236
  SSdb   *pSdb = pMnode->pSdb;
7,295✔
3237
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
7,295✔
3238
  if (pDb == NULL) {
7,295!
UNCOV
3239
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
3240
    TAOS_RETURN(code);
×
3241
  }
3242

3243
  int32_t numOfStbs = 0;
7,295✔
3244
  void   *pIter = NULL;
7,295✔
3245
  while (1) {
91,657✔
3246
    SStbObj *pStb = NULL;
98,952✔
3247
    pIter = sdbFetch(pSdb, SDB_STB, pIter, (void **)&pStb);
98,952✔
3248
    if (pIter == NULL) break;
98,952✔
3249

3250
    if (pStb->dbUid == pDb->uid) {
91,657✔
3251
      numOfStbs++;
78,862✔
3252
    }
3253

3254
    sdbRelease(pSdb, pStb);
91,657✔
3255
  }
3256

3257
  *pNumOfStbs = numOfStbs;
7,295✔
3258
  mndReleaseDb(pMnode, pDb);
7,295✔
3259
  TAOS_RETURN(code);
7,295✔
3260
}
3261

UNCOV
3262
int32_t mndExtractDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
UNCOV
3263
  SName name = {0};
×
UNCOV
3264
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3265

UNCOV
3266
  TAOS_CHECK_RETURN(tNameGetFullDbName(&name, dst));
×
3267

UNCOV
3268
  return 0;
×
3269
}
3270

3271
int32_t mndExtractShortDbNameFromStbFullName(const char *stbFullName, char *dst) {
3✔
3272
  SName name = {0};
3✔
3273
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
3!
3274

3275
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
3!
3276

3277
  return 0;
3✔
3278
}
3279

3280
int32_t mndExtractShortDbNameFromDbFullName(const char *stbFullName, char *dst) {
33✔
3281
  SName name = {0};
33✔
3282
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB));
33!
3283

3284
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
33!
3285

3286
  return 0;
33✔
3287
}
3288

3289
void mndExtractTbNameFromStbFullName(const char *stbFullName, char *dst, int32_t dstSize) {
2,004✔
3290
  int32_t pos = -1;
2,004✔
3291
  int32_t num = 0;
2,004✔
3292
  for (pos = 0; stbFullName[pos] != 0; ++pos) {
13,471!
3293
    if (stbFullName[pos] == TS_PATH_DELIMITER[0]) num++;
13,471✔
3294
    if (num == 2) break;
13,471✔
3295
  }
3296

3297
  if (num == 2) {
2,004!
3298
    tstrncpy(dst, stbFullName + pos + 1, dstSize);
2,004✔
3299
  }
3300
}
2,004✔
3301

3302
static int32_t mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
335✔
3303
  SMnode  *pMnode = pReq->info.node;
335✔
3304
  SSdb    *pSdb = pMnode->pSdb;
335✔
3305
  int32_t  numOfRows = 0;
335✔
3306
  SStbObj *pStb = NULL;
335✔
3307
  int32_t  cols = 0;
335✔
3308
  int32_t  lino = 0;
335✔
3309
  int32_t  code = 0;
335✔
3310

3311
  SDbObj *pDb = NULL;
335✔
3312
  if (strlen(pShow->db) > 0) {
335✔
3313
    pDb = mndAcquireDb(pMnode, pShow->db);
234✔
3314
    if (pDb == NULL) return terrno;
234✔
3315
  }
3316

3317
  while (numOfRows < rows) {
1,929✔
3318
    pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
1,923✔
3319
    if (pShow->pIter == NULL) break;
1,923✔
3320

3321
    if (pDb != NULL && pStb->dbUid != pDb->uid) {
1,597✔
3322
      sdbRelease(pSdb, pStb);
88✔
3323
      continue;
100✔
3324
    }
3325

3326
    if (isTsmaResSTb(pStb->name)) {
1,509✔
3327
      sdbRelease(pSdb, pStb);
12✔
3328
      continue;
12✔
3329
    }
3330

3331
    cols = 0;
1,497✔
3332

3333
    SName name = {0};
1,497✔
3334

3335
    char stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,497✔
3336
    mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
1,497✔
3337
    varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
1,497✔
3338
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3339
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _ERROR);
1,497!
3340

3341
    char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,497✔
3342
    RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _ERROR);
1,497!
3343
    RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _ERROR);
1,497!
3344
    varDataSetLen(db, strlen(varDataVal(db)));
1,497✔
3345
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3346
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _ERROR);
1,497!
3347

3348
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3349
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->createdTime, false), pStb, &lino,
1,497!
3350
                        _ERROR);
3351

3352
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3353
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfColumns, false), pStb, &lino,
1,497!
3354
                        _ERROR);
3355

3356
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3357
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfTags, false), pStb, &lino, _ERROR);
1,497!
3358

3359
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3360
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->updateTime, false), pStb, &lino,
1,497!
3361
                        _ERROR);  // number of tables
3362

3363
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3364
    if (pStb->commentLen > 0) {
1,497✔
3365
      char comment[TSDB_TB_COMMENT_LEN + VARSTR_HEADER_SIZE] = {0};
69✔
3366
      STR_TO_VARSTR(comment, pStb->comment);
69✔
3367
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
69!
3368
    } else if (pStb->commentLen == 0) {
1,428✔
3369
      char comment[VARSTR_HEADER_SIZE + VARSTR_HEADER_SIZE] = {0};
53✔
3370
      STR_TO_VARSTR(comment, "");
53✔
3371
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
53!
3372
    } else {
3373
      colDataSetNULL(pColInfo, numOfRows);
1,375!
3374
    }
3375

3376
    char watermark[64 + VARSTR_HEADER_SIZE] = {0};
1,497✔
3377
    (void)tsnprintf(varDataVal(watermark), sizeof(watermark) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
1,497✔
3378
              pStb->watermark[0], pStb->watermark[1]);
1,497✔
3379
    varDataSetLen(watermark, strlen(varDataVal(watermark)));
1,497✔
3380

3381
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3382
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)watermark, false), pStb, &lino, _ERROR);
1,497!
3383

3384
    char maxDelay[64 + VARSTR_HEADER_SIZE] = {0};
1,497✔
3385
    (void)tsnprintf(varDataVal(maxDelay), sizeof(maxDelay) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
1,497✔
3386
              pStb->maxdelay[0], pStb->maxdelay[1]);
1,497✔
3387
    varDataSetLen(maxDelay, strlen(varDataVal(maxDelay)));
1,497✔
3388

3389
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3390
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)maxDelay, false), pStb, &lino, _ERROR);
1,497!
3391

3392
    char    rollup[160 + VARSTR_HEADER_SIZE] = {0};
1,497✔
3393
    int32_t rollupNum = (int32_t)taosArrayGetSize(pStb->pFuncs);
1,497✔
3394
    char   *sep = ", ";
1,497✔
3395
    int32_t sepLen = strlen(sep);
1,497✔
3396
    int32_t rollupLen = sizeof(rollup) - VARSTR_HEADER_SIZE - 2;
1,497✔
3397
    for (int32_t i = 0; i < rollupNum; ++i) {
1,500✔
3398
      char *funcName = taosArrayGet(pStb->pFuncs, i);
3✔
3399
      if (i) {
3!
UNCOV
3400
        (void)strncat(varDataVal(rollup), sep, rollupLen);
×
UNCOV
3401
        rollupLen -= sepLen;
×
3402
      }
3403
      (void)strncat(varDataVal(rollup), funcName, rollupLen);
3✔
3404
      rollupLen -= strlen(funcName);
3✔
3405
    }
3406
    varDataSetLen(rollup, strlen(varDataVal(rollup)));
1,497✔
3407

3408
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3409
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)rollup, false), pStb, &lino, _ERROR);
1,497!
3410

3411
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,497✔
3412
    if (pColInfo) {
1,497!
3413
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->uid), false), pStb, &lino, _ERROR);
1,497!
3414
    }
3415

3416
    numOfRows++;
1,497✔
3417
    sdbRelease(pSdb, pStb);
1,497✔
3418
  }
3419

3420
  if (pDb != NULL) {
332✔
3421
    mndReleaseDb(pMnode, pDb);
231✔
3422
  }
3423

3424
  goto _OVER;
332✔
3425

UNCOV
3426
_ERROR:
×
UNCOV
3427
  mError("show:0x%" PRIx64 ", failed to retrieve data at %s:%d since %s", pShow->id, __FUNCTION__, lino,
×
3428
         tstrerror(code));
3429

UNCOV
3430
_OVER:
×
3431
  pShow->numOfRows += numOfRows;
332✔
3432
  return numOfRows;
332✔
3433
}
3434

3435
static int32_t buildDbColsInfoBlock(const SSDataBlock *p, const SSysTableMeta *pSysDbTableMeta, size_t size,
13,647✔
3436
                                    const char *dbName, const char *tbName) {
3437
  char    tName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
13,647✔
3438
  char    dName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
13,647✔
3439
  char    typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
13,647✔
3440
  int32_t numOfRows = p->info.rows;
13,647✔
3441
  int32_t lino = 0;
13,647✔
3442
  int32_t code = 0;
13,647✔
3443

3444
  STR_TO_VARSTR(dName, dbName);
13,647✔
3445
  STR_TO_VARSTR(typeName, "SYSTEM_TABLE");
13,647✔
3446

3447
  for (int32_t i = 0; i < size; ++i) {
308,372✔
3448
    const SSysTableMeta *pm = &pSysDbTableMeta[i];
293,358✔
3449
    //    if (pm->sysInfo) {
3450
    //      continue;
3451
    //    }
3452
    if (tbName[0] && strncmp(tbName, pm->name, TSDB_TABLE_NAME_LEN) != 0) {
293,358!
UNCOV
3453
      continue;
×
3454
    }
3455

3456
    STR_TO_VARSTR(tName, pm->name);
293,358✔
3457

3458
    for (int32_t j = 0; j < pm->colNum; j++) {
2,892,452✔
3459
      // table name
3460
      SColumnInfoData *pColInfoData = taosArrayGet(p->pDataBlock, 0);
2,597,727✔
3461
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, tName, false), &lino, _OVER);
2,596,805!
3462

3463
      // database name
3464
      pColInfoData = taosArrayGet(p->pDataBlock, 1);
2,596,608✔
3465
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, dName, false), &lino, _OVER);
2,596,024!
3466

3467
      pColInfoData = taosArrayGet(p->pDataBlock, 2);
2,594,962✔
3468
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, typeName, false), &lino, _OVER);
2,594,618!
3469

3470
      // col name
3471
      char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
2,594,472✔
3472
      STR_TO_VARSTR(colName, pm->schema[j].name);
2,594,472✔
3473
      pColInfoData = taosArrayGet(p->pDataBlock, 3);
2,594,472✔
3474
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, colName, false), &lino, _OVER);
2,597,487!
3475

3476
      // col type
3477
      int8_t colType = pm->schema[j].type;
2,597,182✔
3478
      pColInfoData = taosArrayGet(p->pDataBlock, 4);
2,597,182✔
3479
      char colTypeStr[VARSTR_HEADER_SIZE + 32];
3480
      int  colTypeLen =
2,606,039✔
3481
          tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
2,596,881✔
3482
      if (colType == TSDB_DATA_TYPE_VARCHAR) {
2,606,039✔
3483
        colTypeLen +=
1,432,711✔
3484
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
1,432,605✔
3485
                      (int32_t)(pm->schema[j].bytes - VARSTR_HEADER_SIZE));
1,432,605✔
3486
      } else if (colType == TSDB_DATA_TYPE_NCHAR) {
1,173,434!
UNCOV
3487
        colTypeLen +=
×
UNCOV
3488
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
×
UNCOV
3489
                      (int32_t)((pm->schema[j].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
×
3490
      }
3491
      varDataSetLen(colTypeStr, colTypeLen);
2,606,145✔
3492
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (char *)colTypeStr, false), &lino, _OVER);
2,606,145!
3493

3494
      pColInfoData = taosArrayGet(p->pDataBlock, 5);
2,602,486✔
3495
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (const char *)&pm->schema[j].bytes, false), &lino, _OVER);
2,602,203!
3496
      for (int32_t k = 6; k <= 8; ++k) {
10,371,108✔
3497
        pColInfoData = taosArrayGet(p->pDataBlock, k);
7,772,014✔
3498
        colDataSetNULL(pColInfoData, numOfRows);
7,771,421✔
3499
      }
3500

3501
      numOfRows += 1;
2,599,094✔
3502
    }
3503
  }
3504
_OVER:
15,014✔
3505
  mError("failed at %s:%d since %s", __FUNCTION__, lino, tstrerror(code));
15,014✔
3506
  return numOfRows;
13,648✔
3507
}
3508
#define BUILD_COL_FOR_INFO_DB 1
3509
#define BUILD_COL_FOR_PERF_DB 1 << 1
3510
#define BUILD_COL_FOR_USER_DB 1 << 2
3511
#define BUILD_COL_FOR_ALL_DB  (BUILD_COL_FOR_INFO_DB | BUILD_COL_FOR_PERF_DB | BUILD_COL_FOR_USER_DB)
3512

3513
static int32_t buildSysDbColsInfo(SSDataBlock *p, int8_t buildWhichDBs, char *tb) {
6,824✔
3514
  size_t               size = 0;
6,824✔
3515
  const SSysTableMeta *pSysDbTableMeta = NULL;
6,824✔
3516

3517
  if (buildWhichDBs & BUILD_COL_FOR_INFO_DB) {
6,824!
3518
    getInfosDbMeta(&pSysDbTableMeta, &size);
6,824✔
3519
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_INFORMATION_SCHEMA_DB, tb);
6,824✔
3520
  }
3521

3522
  if (buildWhichDBs & BUILD_COL_FOR_PERF_DB) {
6,824!
3523
    getPerfDbMeta(&pSysDbTableMeta, &size);
6,824✔
3524
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_PERFORMANCE_SCHEMA_DB, tb);
6,824✔
3525
  }
3526

3527
  return p->info.rows;
6,824✔
3528
}
3529

3530
static int8_t determineBuildColForWhichDBs(const char *db) {
6,824✔
3531
  int8_t buildWhichDBs;
3532
  if (!db[0])
6,824!
3533
    buildWhichDBs = BUILD_COL_FOR_ALL_DB;
6,824✔
3534
  else {
UNCOV
3535
    char *p = strchr(db, '.');
×
UNCOV
3536
    if (p && strcmp(p + 1, TSDB_INFORMATION_SCHEMA_DB) == 0) {
×
UNCOV
3537
      buildWhichDBs = BUILD_COL_FOR_INFO_DB;
×
UNCOV
3538
    } else if (p && strcmp(p + 1, TSDB_PERFORMANCE_SCHEMA_DB) == 0) {
×
UNCOV
3539
      buildWhichDBs = BUILD_COL_FOR_PERF_DB;
×
3540
    } else {
UNCOV
3541
      buildWhichDBs = BUILD_COL_FOR_USER_DB;
×
3542
    }
3543
  }
3544
  return buildWhichDBs;
6,824✔
3545
}
3546

3547
static int32_t mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
6,824✔
3548
  uint8_t  buildWhichDBs;
3549
  SMnode  *pMnode = pReq->info.node;
6,824✔
3550
  SSdb    *pSdb = pMnode->pSdb;
6,824✔
3551
  SStbObj *pStb = NULL;
6,824✔
3552
  int32_t  numOfRows = 0;
6,824✔
3553
  int32_t  lino = 0;
6,824✔
3554
  int32_t  code = 0;
6,824✔
3555

3556
  buildWhichDBs = determineBuildColForWhichDBs(pShow->db);
6,824✔
3557

3558
  if (!pShow->sysDbRsp) {
6,824!
3559
    numOfRows = buildSysDbColsInfo(pBlock, buildWhichDBs, pShow->filterTb);
6,824✔
3560
    mDebug("mndRetrieveStbCol get system table cols, rows:%d, db:%s", numOfRows, pShow->db);
6,824!
3561
    pShow->sysDbRsp = true;
6,824✔
3562
  }
3563

3564
  if (buildWhichDBs & BUILD_COL_FOR_USER_DB) {
6,824!
3565
    SDbObj *pDb = NULL;
6,824✔
3566
    if (strlen(pShow->db) > 0) {
6,824!
UNCOV
3567
      pDb = mndAcquireDb(pMnode, pShow->db);
×
UNCOV
3568
      if (pDb == NULL && TSDB_CODE_MND_DB_NOT_EXIST != terrno && pBlock->info.rows == 0) return terrno;
×
3569
    }
3570

3571
    char typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
6,824✔
3572
    STR_TO_VARSTR(typeName, "SUPER_TABLE");
6,824✔
3573
    bool fetch = pShow->restore ? false : true;
6,824✔
3574
    pShow->restore = false;
6,824✔
3575
    while (numOfRows < rows) {
7,328!
3576
      if (fetch) {
7,328!
3577
        pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
7,328✔
3578
        if (pShow->pIter == NULL) break;
7,328✔
3579
      } else {
3580
        fetch = true;
×
UNCOV
3581
        void *pKey = taosHashGetKey(pShow->pIter, NULL);
×
UNCOV
3582
        pStb = sdbAcquire(pSdb, SDB_STB, pKey);
×
UNCOV
3583
        if (!pStb) continue;
×
3584
      }
3585

3586
      if (pDb != NULL && pStb->dbUid != pDb->uid) {
504!
UNCOV
3587
        sdbRelease(pSdb, pStb);
×
UNCOV
3588
        continue;
×
3589
      }
3590

3591
      SName name = {0};
504✔
3592
      char  stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
504✔
3593
      mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
504✔
3594
      if (pShow->filterTb[0] && strncmp(pShow->filterTb, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN) != 0) {
504!
3595
        sdbRelease(pSdb, pStb);
×
UNCOV
3596
        continue;
×
3597
      }
3598

3599
      if ((numOfRows + pStb->numOfColumns) > rows) {
504!
3600
        pShow->restore = true;
×
UNCOV
3601
        if (numOfRows == 0) {
×
UNCOV
3602
          mError("mndRetrieveStbCol failed to get stable cols since buf:%d less than result:%d, stable name:%s, db:%s",
×
3603
                 rows, pStb->numOfColumns, pStb->name, pStb->db);
3604
        }
UNCOV
3605
        sdbRelease(pSdb, pStb);
×
UNCOV
3606
        break;
×
3607
      }
3608

3609
      varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
504✔
3610

3611
      mDebug("mndRetrieveStbCol get stable cols, stable name:%s, db:%s", pStb->name, pStb->db);
504!
3612

3613
      char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
504✔
3614
      RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _OVER);
504!
3615
      RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _OVER);
504!
3616
      varDataSetLen(db, strlen(varDataVal(db)));
504✔
3617

3618
      for (int i = 0; i < pStb->numOfColumns; i++) {
10,560✔
3619
        int32_t          cols = 0;
10,056✔
3620
        SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
10,056✔
3621
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _OVER);
10,056!
3622

3623
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
10,056✔
3624
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _OVER);
10,056!
3625

3626
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
10,056✔
3627
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, typeName, false), pStb, &lino, _OVER);
10,056!
3628

3629
        // col name
3630
        char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
10,056✔
3631
        STR_TO_VARSTR(colName, pStb->pColumns[i].name);
10,056✔
3632
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
10,056✔
3633
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, colName, false), pStb, &lino, _OVER);
10,056!
3634

3635
        // col type
3636
        int8_t colType = pStb->pColumns[i].type;
10,056✔
3637
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
10,056✔
3638
        char colTypeStr[VARSTR_HEADER_SIZE + 32];
3639
        int  colTypeLen =
10,056✔
3640
            tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
10,056✔
3641
        if (colType == TSDB_DATA_TYPE_VARCHAR) {
10,056✔
3642
          colTypeLen +=
4✔
3643
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
4✔
3644
                        "(%d)", (int32_t)(pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE));
4✔
3645
        } else if (colType == TSDB_DATA_TYPE_NCHAR) {
10,052✔
3646
          colTypeLen +=
4✔
3647
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
4✔
3648
                        "(%d)", (int32_t)((pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
4✔
3649
        }
3650
        varDataSetLen(colTypeStr, colTypeLen);
10,056✔
3651
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (char *)colTypeStr, false), pStb, &lino, _OVER);
10,056!
3652

3653
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
10,056✔
3654
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].bytes, false), pStb,
10,056!
3655
                            &lino, _OVER);
3656
        while (cols < pShow->numOfColumns) {
40,224✔
3657
          pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
30,168✔
3658
          colDataSetNULL(pColInfo, numOfRows);
30,168!
3659
        }
3660
        numOfRows++;
10,056✔
3661
      }
3662

3663
      sdbRelease(pSdb, pStb);
504✔
3664
    }
3665

3666
    if (pDb != NULL) {
6,824!
UNCOV
3667
      mndReleaseDb(pMnode, pDb);
×
3668
    }
3669
  }
3670

3671
  mDebug("mndRetrieveStbCol success, rows:%d, pShow->numOfRows:%d", numOfRows, pShow->numOfRows);
6,824!
3672
  goto _OVER;
6,824✔
3673

3674
_ERROR:
3675
  mError("failed to mndRetrieveStbCol, rows:%d, pShow->numOfRows:%d, at %s:%d since %s", numOfRows, pShow->numOfRows,
3676
         __FUNCTION__, lino, tstrerror(code));
3677

3678
_OVER:
6,824✔
3679
  pShow->numOfRows += numOfRows;
6,824✔
3680
  return numOfRows;
6,824✔
3681
}
3682

UNCOV
3683
static void mndCancelGetNextStb(SMnode *pMnode, void *pIter) {
×
UNCOV
3684
  SSdb *pSdb = pMnode->pSdb;
×
UNCOV
3685
  sdbCancelFetchByType(pSdb, pIter, SDB_STB);
×
UNCOV
3686
}
×
3687

3688
const char *mndGetStbStr(const char *src) {
738✔
3689
  char *posDb = strstr(src, TS_PATH_DELIMITER);
738✔
3690
  if (posDb != NULL) ++posDb;
738!
3691
  if (posDb == NULL) return src;
738!
3692

3693
  char *posStb = strstr(posDb, TS_PATH_DELIMITER);
738✔
3694
  if (posStb != NULL) ++posStb;
738!
3695
  if (posStb == NULL) return posDb;
738!
3696
  return posStb;
738✔
3697
}
3698

UNCOV
3699
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
3700
  // impl
UNCOV
3701
  return TSDB_CODE_SUCCESS;
×
3702
}
3703

3704
/*int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp, void *sql,
3705
                        int32_t len) {
3706
  // impl later
3707
  int32_t code = 0;
3708
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
3709
  if (pTrans == NULL) goto _OVER;
3710

3711
  mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
3712
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
3713
  if (mndTransCheckConflict(pMnode, pTrans) != 0) goto _OVER;
3714

3715
  if (mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
3716
  if (mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
3717
  if (mndSetAlterStbRedoActions2(pMnode, pTrans, pDb, pStb, sql, len) != 0) goto _OVER;
3718
  if (mndTransPrepare(pMnode, pTrans) != 0) goto _OVER;
3719

3720
  return code;
3721

3722
_OVER:
3723
  mndTransDrop(pTrans);
3724
  return code;
3725
}
3726
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *tagIdxReq, SDbObj *pDb, SStbObj *pOld) {
3727
  bool    needRsp = true;
3728
  int32_t code = -1;
3729
  SField *pField0 = NULL;
3730

3731
  SStbObj  stbObj = {0};
3732
  SStbObj *pNew = &stbObj;
3733

3734
  taosRLockLatch(&pOld->lock);
3735
  memcpy(&stbObj, pOld, sizeof(SStbObj));
3736
  taosRUnLockLatch(&pOld->lock);
3737

3738
  stbObj.pColumns = NULL;
3739
  stbObj.pTags = NULL;
3740
  stbObj.updateTime = taosGetTimestampMs();
3741
  stbObj.lock = 0;
3742

3743
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagIdxReq->colName);
3744
  if (tag < 0) {
3745
    terrno = TSDB_CODE_MND_TAG_NOT_EXIST;
3746
    return -1;
3747
  }
3748
  if (mndAllocStbSchemas(pOld, pNew) != 0) {
3749
    return -1;
3750
  }
3751

3752
  SSchema *pTag = pNew->pTags + tag;
3753
  if (IS_IDX_ON(pTag)) {
3754
    terrno = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
3755
    return -1;
3756
  } else {
3757
    pTag->flags |= COL_IDX_ON;
3758
  }
3759
  pNew->tagVer++;
3760

3761
  code = mndAddIndexImpl(pMnode, pReq, pDb, pNew, needRsp, pReq->pCont, pReq->contLen);
3762

3763
  return code;
3764
}
3765
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq) {
3766
  SMnode            *pMnode = pReq->info.node;
3767
  int32_t            code = -1;
3768
  SDbObj            *pDb = NULL;
3769
  SStbObj           *pStb = NULL;
3770
  SCreateTagIndexReq tagIdxReq = {0};
3771

3772
  if (tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &tagIdxReq) != 0) {
3773
    terrno = TSDB_CODE_INVALID_MSG;
3774
    goto _OVER;
3775
  }
3776

3777
  mInfo("stb:%s, start to alter", tagIdxReq.stbName);
3778

3779
  if (mndCheckIndexReq(&tagIdxReq) != TSDB_CODE_SUCCESS) {
3780
    goto _OVER;
3781
  }
3782

3783
  pDb = mndAcquireDbByStb(pMnode, tagIdxReq.dbFName);
3784
  if (pDb == NULL) {
3785
    terrno = TSDB_CODE_MND_DB_NOT_EXIST;
3786
    goto _OVER;
3787
  }
3788

3789
  pStb = mndAcquireStb(pMnode, tagIdxReq.stbName);
3790
  if (pStb == NULL) {
3791
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
3792
    goto _OVER;
3793
  }
3794
  if (mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb) != 0) {
3795
    goto _OVER;
3796
  }
3797

3798
  code = mndAddIndex(pMnode, pReq, &tagIdxReq, pDb, pStb);
3799
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
3800
    return terrno;
3801
  } else {
3802
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
3803
  }
3804
_OVER:
3805
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
3806
    mError("stb:%s, failed to create index since %s", tagIdxReq.stbName, terrstr());
3807
  }
3808
  mndReleaseStb(pMnode, pStb);
3809
  mndReleaseDb(pMnode, pDb);
3810
  return code;
3811
}
3812
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq) {
3813
  SMnode          *pMnode = pReq->info.node;
3814
  int32_t          code = -1;
3815
  SDbObj          *pDb = NULL;
3816
  SStbObj         *pStb = NULL;
3817
  SDropTagIndexReq dropReq = {0};
3818
  if (tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
3819
    terrno = TSDB_CODE_INVALID_MSG;
3820
    goto _OVER;
3821
  }
3822
  //
3823
  return TSDB_CODE_SUCCESS;
3824
_OVER:
3825
  return code;
3826
}*/
3827

3828
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq) {
214✔
3829
  int32_t code = mndProcessDropStbReq(pReq);
214✔
3830
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
214!
UNCOV
3831
    pReq->info.rsp = rpcMallocCont(1);
×
UNCOV
3832
    pReq->info.rspLen = 1;
×
UNCOV
3833
    pReq->info.noResp = false;
×
UNCOV
3834
    pReq->code = code;
×
3835
  }
3836
  return code;
214✔
3837
}
3838

3839
typedef struct SVDropTbVgReqs {
3840
  SArray     *pBatchReqs;
3841
  SVgroupInfo info;
3842
} SVDropTbVgReqs;
3843

3844
typedef struct SMDropTbDbInfo {
3845
  SArray *dbVgInfos;
3846
  int32_t hashPrefix;
3847
  int32_t hashSuffix;
3848
  int32_t hashMethod;
3849
} SMDropTbDbInfo;
3850

3851
typedef struct SMDropTbTsmaInfo {
3852
  char           tsmaResTbDbFName[TSDB_DB_FNAME_LEN];
3853
  char           tsmaResTbNamePrefix[TSDB_TABLE_FNAME_LEN];
3854
  int32_t        suid;
3855
  SMDropTbDbInfo dbInfo;  // reference to DbInfo in pDbMap
3856
} SMDropTbTsmaInfo;
3857

3858
typedef struct SMDropTbTsmaInfos {
3859
  SArray *pTsmaInfos;  // SMDropTbTsmaInfo
3860
} SMDropTbTsmaInfos;
3861

3862
typedef struct SMndDropTbsWithTsmaCtx {
3863
  SHashObj *pVgMap;  // <vgId, SVDropTbVgReqs>
3864
} SMndDropTbsWithTsmaCtx;
3865

3866
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId);
3867

3868
static void destroySVDropTbBatchReqs(void *p);
3869
static void mndDestroyDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx *p) {
30✔
3870
  if (!p) return;
30!
3871

3872
  if (p->pVgMap) {
30!
3873
    void *pIter = taosHashIterate(p->pVgMap, NULL);
30✔
3874
    while (pIter) {
65✔
3875
      SVDropTbVgReqs *pReqs = pIter;
35✔
3876
      taosArrayDestroyEx(pReqs->pBatchReqs, destroySVDropTbBatchReqs);
35✔
3877
      pIter = taosHashIterate(p->pVgMap, pIter);
35✔
3878
    }
3879
    taosHashCleanup(p->pVgMap);
30✔
3880
  }
3881
  taosMemoryFree(p);
30!
3882
}
3883

3884
static int32_t mndInitDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx **ppCtx) {
30✔
3885
  int32_t                 code = 0;
30✔
3886
  SMndDropTbsWithTsmaCtx *pCtx = taosMemoryCalloc(1, sizeof(SMndDropTbsWithTsmaCtx));
30!
3887
  if (!pCtx) return terrno;
30!
3888

3889
  pCtx->pVgMap = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_INT), false, HASH_NO_LOCK);
30✔
3890
  if (!pCtx->pVgMap) {
30!
UNCOV
3891
    code = terrno;
×
UNCOV
3892
    goto _end;
×
3893
  }
3894

3895
  *ppCtx = pCtx;
30✔
3896
_end:
30✔
3897
  if (code) mndDestroyDropTbsWithTsmaCtx(pCtx);
30!
3898
  return code;
30✔
3899
}
3900

3901
static void *mndBuildVDropTbsReq(SMnode *pMnode, const SVgroupInfo *pVgInfo, const SVDropTbBatchReq *pReq,
35✔
3902
                                 int32_t *len) {
3903
  int32_t   contLen = 0;
35✔
3904
  int32_t   ret = 0;
35✔
3905
  SMsgHead *pHead = NULL;
35✔
3906
  SEncoder  encoder = {0};
35✔
3907

3908
  tEncodeSize(tEncodeSVDropTbBatchReq, pReq, contLen, ret);
35!
3909
  if (ret < 0) return NULL;
35!
3910

3911
  contLen += sizeof(SMsgHead);
35✔
3912
  pHead = taosMemoryMalloc(contLen);
35!
3913
  if (pHead == NULL) {
35!
UNCOV
3914
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
3915
    return NULL;
×
3916
  }
3917

3918
  pHead->contLen = htonl(contLen);
35✔
3919
  pHead->vgId = htonl(pVgInfo->vgId);
35✔
3920

3921
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
35✔
3922

3923
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
35✔
3924
  int32_t code = tEncodeSVDropTbBatchReq(&encoder, pReq);
35✔
3925
  tEncoderClear(&encoder);
35✔
3926
  if (code != 0) return NULL;
35!
3927

3928
  *len = contLen;
35✔
3929
  return pHead;
35✔
3930
}
3931

3932
static int32_t mndSetDropTbsRedoActions(SMnode *pMnode, STrans *pTrans, const SVDropTbVgReqs *pVgReqs, void *pCont,
35✔
3933
                                        int32_t contLen, tmsg_t msgType) {
3934
  STransAction action = {0};
35✔
3935
  action.epSet = pVgReqs->info.epSet;
35✔
3936
  action.pCont = pCont;
35✔
3937
  action.contLen = contLen;
35✔
3938
  action.msgType = msgType;
35✔
3939
  action.acceptableCode = TSDB_CODE_TDB_TABLE_NOT_EXIST;
35✔
3940
  return mndTransAppendRedoAction(pTrans, &action);
35✔
3941
}
3942

3943
static int32_t mndBuildDropTbRedoActions(SMnode *pMnode, STrans *pTrans, SHashObj *pVgMap, tmsg_t msgType) {
30✔
3944
  int32_t code = 0;
30✔
3945
  void   *pIter = taosHashIterate(pVgMap, NULL);
30✔
3946
  while (pIter) {
65✔
3947
    const SVDropTbVgReqs *pVgReqs = pIter;
35✔
3948
    int32_t               len = 0;
35✔
3949
    for (int32_t i = 0; i < taosArrayGetSize(pVgReqs->pBatchReqs) && code == TSDB_CODE_SUCCESS; ++i) {
70!
3950
      SVDropTbBatchReq *pBatchReq = taosArrayGet(pVgReqs->pBatchReqs, i);
35✔
3951
      void             *p = mndBuildVDropTbsReq(pMnode, &pVgReqs->info, pBatchReq, &len);
35✔
3952
      if (!p) {
35!
UNCOV
3953
        code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3954
        if (terrno != 0) code = terrno;
×
UNCOV
3955
        break;
×
3956
      }
3957
      if ((code = mndSetDropTbsRedoActions(pMnode, pTrans, pVgReqs, p, len, msgType)) != 0) {
35!
UNCOV
3958
        break;
×
3959
      }
3960
    }
3961
    if (TSDB_CODE_SUCCESS != code) {
35!
UNCOV
3962
      taosHashCancelIterate(pVgMap, pIter);
×
UNCOV
3963
      break;
×
3964
    }
3965
    pIter = taosHashIterate(pVgMap, pIter);
35✔
3966
  }
3967
  return code;
30✔
3968
}
3969

3970
static int32_t mndCreateDropTbsTxnPrepare(SRpcMsg *pRsp, SMndDropTbsWithTsmaCtx *pCtx) {
30✔
3971
  int32_t code = 0;
30✔
3972
  SMnode *pMnode = pRsp->info.node;
30✔
3973
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pRsp, "drop-tbs");
30✔
3974
  mndTransSetChangeless(pTrans);
30✔
3975
  mndTransSetSerial(pTrans);
30✔
3976
  if (pTrans == NULL) {
30!
UNCOV
3977
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3978
    if (terrno != 0) code = terrno;
×
UNCOV
3979
    goto _OVER;
×
3980
  }
3981

3982
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
30!
3983

3984
  if ((code = mndBuildDropTbRedoActions(pMnode, pTrans, pCtx->pVgMap, TDMT_VND_DROP_TABLE)) != 0) goto _OVER;
30!
3985
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) goto _OVER;
30!
3986

3987
_OVER:
30✔
3988
  mndTransDrop(pTrans);
30✔
3989
  TAOS_RETURN(code);
30✔
3990
}
3991

3992
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq) {
25✔
3993
  int32_t      code = -1;
25✔
3994
  SMnode      *pMnode = pReq->info.node;
25✔
3995
  SDbObj      *pDb = NULL;
25✔
3996
  SStbObj     *pStb = NULL;
25✔
3997
  SMDropTbsReq dropReq = {0};
25✔
3998
  bool         locked = false;
25✔
3999
  if (tDeserializeSMDropTbsReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
25!
UNCOV
4000
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
4001
    goto _OVER;
×
4002
  }
4003

4004
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
25✔
4005
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
25✔
4006
  if (code) goto _OVER;
25!
4007
  for (int32_t i = 0; i < dropReq.pVgReqs->size; ++i) {
55✔
4008
    SMDropTbReqsOnSingleVg *pReq = taosArrayGet(dropReq.pVgReqs, i);
30✔
4009
    code = mndDropTbForSingleVg(pMnode, pCtx, pReq->pTbs, pReq->vgInfo.vgId);
30✔
4010
    if (code) goto _OVER;
30!
4011
  }
4012
  code = mndCreateDropTbsTxnPrepare(pReq, pCtx);
25✔
4013
  if (code == 0) {
25!
4014
    code = TSDB_CODE_ACTION_IN_PROGRESS;
25✔
4015
  }
UNCOV
4016
_OVER:
×
4017
  tFreeSMDropTbsReq(&dropReq);
25✔
4018
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
25!
4019
  TAOS_RETURN(code);
25✔
4020
}
4021

4022
static int32_t createDropTbBatchReq(const SVDropTbReq *pReq, SVDropTbBatchReq *pBatchReq) {
35✔
4023
  pBatchReq->nReqs = 1;
35✔
4024
  pBatchReq->pArray = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbReq));
35✔
4025
  if (!pBatchReq->pArray) return terrno;
35!
4026
  if (taosArrayPush(pBatchReq->pArray, pReq) == NULL) {
70!
UNCOV
4027
    taosArrayDestroy(pBatchReq->pArray);
×
4028
    pBatchReq->pArray = NULL;
×
UNCOV
4029
    return terrno;
×
4030
  }
4031
  return TSDB_CODE_SUCCESS;
35✔
4032
}
4033

4034
static void destroySVDropTbBatchReqs(void *p) {
35✔
4035
  SVDropTbBatchReq *pReq = p;
35✔
4036
  taosArrayDestroy(pReq->pArray);
35✔
4037
  pReq->pArray = NULL;
35✔
4038
}
35✔
4039

4040
static int32_t mndDropTbAdd(SMnode *pMnode, SHashObj *pVgHashMap, const SVgroupInfo *pVgInfo, char *name, tb_uid_t suid,
35✔
4041
                            bool ignoreNotExists) {
4042
  SVDropTbReq req = {.name = name, .suid = suid, .igNotExists = ignoreNotExists, .uid = 0};
35✔
4043

4044
  SVDropTbVgReqs *pVgReqs = taosHashGet(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId));
35✔
4045
  SVDropTbVgReqs  vgReqs = {0};
35✔
4046
  if (pVgReqs == NULL) {
35!
4047
    vgReqs.info = *pVgInfo;
35✔
4048
    vgReqs.pBatchReqs = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbBatchReq));
35✔
4049
    if (!vgReqs.pBatchReqs) return terrno;
35!
4050
    SVDropTbBatchReq batchReq = {0};
35✔
4051
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
35✔
4052
    if (TSDB_CODE_SUCCESS != code) return code;
35!
4053
    if (taosArrayPush(vgReqs.pBatchReqs, &batchReq) == NULL) {
70!
UNCOV
4054
      taosArrayDestroy(batchReq.pArray);
×
UNCOV
4055
      return terrno;
×
4056
    }
4057
    if (taosHashPut(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId), &vgReqs, sizeof(vgReqs)) != 0) {
35!
UNCOV
4058
      taosArrayDestroyEx(vgReqs.pBatchReqs, destroySVDropTbBatchReqs);
×
UNCOV
4059
      return terrno;
×
4060
    }
4061
  } else {
UNCOV
4062
    SVDropTbBatchReq batchReq = {0};
×
UNCOV
4063
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
×
UNCOV
4064
    if (TSDB_CODE_SUCCESS != code) return code;
×
UNCOV
4065
    if (taosArrayPush(pVgReqs->pBatchReqs, &batchReq) == NULL) {
×
4066
      taosArrayDestroy(batchReq.pArray);
×
4067
      return terrno;
×
4068
    }
4069
  }
4070
  return 0;
35✔
4071
}
4072

4073
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId) {
35✔
4074
  int32_t code = 0;
35✔
4075

4076
  SVgObj *pVgObj = mndAcquireVgroup(pMnode, vgId);
35✔
4077
  if (!pVgObj) {
35!
4078
    code = 0;
×
4079
    goto _end;
×
4080
  }
4081
  SVgroupInfo vgInfo = {.hashBegin = pVgObj->hashBegin,
35✔
4082
                        .hashEnd = pVgObj->hashEnd,
35✔
4083
                        .numOfTable = pVgObj->numOfTables,
35✔
4084
                        .vgId = pVgObj->vgId};
35✔
4085
  vgInfo.epSet = mndGetVgroupEpset(pMnode, pVgObj);
35✔
4086
  mndReleaseVgroup(pMnode, pVgObj);
35✔
4087

4088
  for (int32_t i = 0; i < pTbs->size; ++i) {
70✔
4089
    SVDropTbReq *pTb = taosArrayGet(pTbs, i);
35✔
4090
    TAOS_CHECK_GOTO(mndDropTbAdd(pMnode, pCtx->pVgMap, &vgInfo, pTb->name, pTb->suid, pTb->igNotExists), NULL, _end);
35!
4091
  }
4092
_end:
35✔
4093
  return code;
35✔
4094
}
4095

4096
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pRsp) {
16,596✔
4097
  int32_t                 code = -1;
16,596✔
4098
  SDecoder                decoder = {0};
16,596✔
4099
  SMnode                 *pMnode = pRsp->info.node;
16,596✔
4100
  SVFetchTtlExpiredTbsRsp rsp = {0};
16,596✔
4101
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
16,596✔
4102
  if (pRsp->code != TSDB_CODE_SUCCESS) {
16,596✔
4103
    code = pRsp->code;
365✔
4104
    goto _end;
365✔
4105
  }
4106
  if (pRsp->contLen == 0) {
16,231✔
4107
    code = 0;
16,226✔
4108
    goto _end;
16,226✔
4109
  }
4110

4111
  tDecoderInit(&decoder, pRsp->pCont, pRsp->contLen);
5✔
4112
  code = tDecodeVFetchTtlExpiredTbsRsp(&decoder, &rsp);
5✔
4113
  if (code) goto _end;
5!
4114

4115
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
5✔
4116
  if (code) goto _end;
5!
4117

4118
  code = mndDropTbForSingleVg(pMnode, pCtx, rsp.pExpiredTbs, rsp.vgId);
5✔
4119
  if (code) goto _end;
5!
4120
  code = mndCreateDropTbsTxnPrepare(pRsp, pCtx);
5✔
4121
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
5!
UNCOV
4122
_end:
×
4123
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
16,596✔
4124
  tDecoderClear(&decoder);
16,596✔
4125
  tFreeFetchTtlExpiredTbsRsp(&rsp);
16,596✔
4126
  TAOS_RETURN(code);
16,596✔
4127
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc