#3655

Committed 14 Mar 2025 08:10AM UTC coverage: 59.532% (+22.6%) from 36.951%

Build # #3655

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

139898 of 302527 branches covered (46.24%)

Branch coverage included in aggregate %.

71 of 99 new or added lines in 12 files covered. (71.72%)

2746 existing lines in 57 files now uncovered.

220499 of 302857 relevant lines covered (72.81%)

5509252.7 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.52

/source/dnode/mnode/sdb/src/sdbHash.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "sdb.h"

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow);

const char *sdbTableName(ESdbType type) {
  switch (type) {
    case SDB_TRANS:
      return "trans";
    case SDB_CLUSTER:
      return "cluster";
    case SDB_MNODE:
      return "mnode";
    case SDB_QNODE:
      return "qnode";
    case SDB_SNODE:
      return "snode";
    case SDB_DNODE:
      return "dnode";
    case SDB_USER:
      return "user";
    case SDB_AUTH:
      return "auth";
    case SDB_ACCT:
      return "acct";
    case SDB_STREAM_CK:
      return "stream_ck";
    case SDB_STREAM:
      return "stream";
    case SDB_OFFSET:
      return "offset";
    case SDB_SUBSCRIBE:
      return "subscribe";
    case SDB_CONSUMER:
      return "consumer";
    case SDB_TOPIC:
      return "topic";
    case SDB_VGROUP:
      return "vgroup";
    case SDB_SMA:
      return "sma";
    case SDB_STB:
      return "stb";
    case SDB_DB:
      return "db";
    case SDB_FUNC:
      return "func";
    case SDB_IDX:
      return "idx";
    case SDB_VIEW:
      return "view";
    case SDB_STREAM_SEQ:
      return "stream_seq";
    case SDB_COMPACT:
      return "compact";
    case SDB_COMPACT_DETAIL:
      return "compact_detail";
    case SDB_GRANT:
      return "grant";
    case SDB_ARBGROUP:
      return "arb_group";
    case SDB_ANODE:
      return "anode";
    case SDB_CFG:
      return "config";
    default:
      return "undefine";
  }
}

const char *sdbStatusName(ESdbStatus status) {
  switch (status) {
    case SDB_STATUS_CREATING:
      return "creating";
    case SDB_STATUS_DROPPING:
      return "dropping";
    case SDB_STATUS_READY:
      return "ready";
    case SDB_STATUS_DROPPED:
      return "dropped";
    case SDB_STATUS_INIT:
      return "init";
    case SDB_STATUS_UPDATE:
      return "update";
    default:
      return "undefine";
  }
}

void sdbPrintOper(SSdb *pSdb, SSdbRow *pRow, const char *oper) {
#if 1
  EKeyType keyType = pSdb->keyTypes[pRow->type];

  if (keyType == SDB_KEY_BINARY) {
    mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT32) {
    mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), *(int32_t *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT64) {
    mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),
           *(int64_t *)pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else {
  }
#endif
}

static SHashObj *sdbGetHash(SSdb *pSdb, int32_t type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return NULL;
  }

  SHashObj *hash = pSdb->hashObjs[type];
  if (hash == NULL) {
    terrno = TSDB_CODE_APP_ERROR;
    return NULL;
  }

  return hash;
}

static int32_t sdbGetkeySize(SSdb *pSdb, ESdbType type, const void *pKey) {
  int32_t  keySize = 0;
  EKeyType keyType = pSdb->keyTypes[type];

  if (keyType == SDB_KEY_INT32) {
    keySize = sizeof(int32_t);
  } else if (keyType == SDB_KEY_BINARY) {
    keySize = strlen(pKey) + 1;
  } else {
    keySize = sizeof(int64_t);
  }

  return keySize;
}

static int32_t sdbInsertRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (pOldRow != NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;
    return terrno;
  }

  pRow->refCount = 0;
  pRow->status = pRaw->status;
  sdbPrintOper(pSdb, pRow, "insert");

  int32_t code = 0;
  if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    return code;
  }

  SdbInsertFp insertFp = pSdb->insertFps[pRow->type];
  if (insertFp != NULL) {
    code = (*insertFp)(pSdb, pRow->pObj);
    if (code != 0) {
      if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {
        mError("failed to remove row from hash");
      }
      sdbFreeRow(pSdb, pRow, false);
      sdbUnLock(pSdb, type);
      terrno = code;
      return terrno;
    }
  }

  sdbUnLock(pSdb, type);

  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int32_t *)pRow->pObj));
  }
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int64_t *)pRow->pObj));
  }
  pSdb->tableVer[pRow->type]++;

  return 0;
}

static int32_t sdbUpdateRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pNewRow, int32_t keySize) {
  int32_t type = pNewRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);
  }

  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;
  sdbPrintOper(pSdb, pOldRow, "update");

  int32_t     code = 0;
  SdbUpdateFp updateFp = pSdb->updateFps[type];
  if (updateFp != NULL) {
    code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);
  }
  sdbUnLock(pSdb, type);

  // sdbUnLock(pSdb, type);
  sdbFreeRow(pSdb, pNewRow, false);

  pSdb->tableVer[pOldRow->type]++;
  return code;
}

static int32_t sdbDeleteRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;

  (void)atomic_add_fetch_32(&pOldRow->refCount, 1);
  sdbPrintOper(pSdb, pOldRow, "delete");

  if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  pSdb->tableVer[pOldRow->type]++;
  sdbUnLock(pSdb, type);

  sdbFreeRow(pSdb, pRow, false);

  sdbCheckRow(pSdb, pOldRow);
  return 0;
}

int32_t sdbWriteWithoutFree(SSdb *pSdb, SSdbRaw *pRaw) {
  if (pRaw->type == SDB_CFG) {
    mTrace("sdb write cfg");
  }
  SHashObj *hash = sdbGetHash(pSdb, pRaw->type);
  if (hash == NULL) return terrno;

  SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];
  SSdbRow    *pRow = (*decodeFp)(pRaw);
  if (pRow == NULL) return terrno;

  pRow->type = pRaw->type;

  int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);
  int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;

  switch (pRaw->status) {
    case SDB_STATUS_CREATING:
      code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_READY:
    case SDB_STATUS_UPDATE:
    case SDB_STATUS_DROPPING:
      code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_DROPPED:
      code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);
      break;
  }

  return code;
}

int32_t sdbWrite(SSdb *pSdb, SSdbRaw *pRaw) {
  int32_t code = sdbWriteWithoutFree(pSdb, pRaw);
  sdbFreeRaw(pRaw);
  return code;
}

void *sdbAcquireAll(SSdb *pSdb, ESdbType type, const void *pKey, bool onlyReady) {
  terrno = 0;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  void   *pRet = NULL;
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);
  if (ppRow == NULL || *ppRow == NULL) {
    sdbUnLock(pSdb, type);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return NULL;
  }

  SSdbRow *pRow = *ppRow;
  switch (pRow->status) {
    case SDB_STATUS_READY:
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
      break;
    case SDB_STATUS_CREATING:
      terrno = TSDB_CODE_SDB_OBJ_CREATING;
      break;
    case SDB_STATUS_DROPPING:
      terrno = TSDB_CODE_SDB_OBJ_DROPPING;
      break;
    default:
      terrno = TSDB_CODE_APP_ERROR;
      break;
  }

  if (pRet == NULL) {
    if (!onlyReady) {
      terrno = 0;
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
    }
  }

  sdbUnLock(pSdb, type);
  return pRet;
}

void *sdbAcquire(SSdb *pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }
void *sdbAcquireNotReadyObj(SSdb *pSdb, ESdbType type, const void *pKey) {
  return sdbAcquireAll(pSdb, type, pKey, false);
}

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "check");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  sdbUnLock(pSdb, type);
}

void sdbReleaseLock(SSdb *pSdb, void *pObj, bool lock) {
  if (pObj == NULL) return;

  SSdbRow *pRow = (SSdbRow *)((char *)pObj - sizeof(SSdbRow));
  if (pRow->type >= SDB_MAX) return;

  int32_t type = pRow->type;
  if (lock) {
    sdbWriteLock(pSdb, type);
  }

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "release");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  if (lock) {
    sdbUnLock(pSdb, type);
  }
}

void sdbRelease(SSdb *pSdb, void *pObj) { sdbReleaseLock(pSdb, pObj, true); }

void *sdbFetch(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL || pRow->status != SDB_STATUS_READY) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    break;
  }
  sdbUnLock(pSdb, type);

  return ppRow;
}

void *sdbFetchAll(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj, ESdbStatus *status, bool lock) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  if (lock) {
    sdbReadLock(pSdb, type);
  }

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    *status = pRow->status;
    break;
  }
  if (lock) {
    sdbUnLock(pSdb, type);
  }

  return ppRow;
}

void sdbCancelFetch(SSdb *pSdb, void *pIter) {
  if (pIter == NULL) return;
  SSdbRow *pRow = *(SSdbRow **)pIter;
  mTrace("cancel fetch row:%p", pRow);
  SHashObj *hash = sdbGetHash(pSdb, pRow->type);
  if (hash == NULL) return;

  int32_t type = pRow->type;
  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbCancelFetchByType(SSdb *pSdb, void *pIter, ESdbType type) {
  if (pIter == NULL) return;
  if (type >= SDB_MAX || type < 0) return;
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbTraverse(SSdb *pSdb, ESdbType type, sdbTraverseFp fp, void *p1, void *p2, void *p3) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow->status == SDB_STATUS_READY) {
      bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);
      if (!isContinue) {
        taosHashCancelIterate(hash, ppRow);
        break;
      }
    }

    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
}

int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return 0;

  sdbReadLock(pSdb, type);
  int32_t size = taosHashGetSize(hash);
  sdbUnLock(pSdb, type);

  return size;
}

int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return -1;

  if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;

  int32_t maxId = 0;
  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    int32_t  id = *(int32_t *)pRow->pObj;
    maxId = TMAX(id, maxId);
    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
  maxId = TMAX(maxId, pSdb->maxId[type]);
  return maxId + 1;
}

int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return -1;
  }

  return pSdb->tableVer[type];
}

bool countValid(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
  int32_t *pInt = p1;
  (*pInt) += 1;
  return true;
}

int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {
  int32_t num = 0;
  sdbTraverse(pSdb, type, countValid, &num, 0, 0);
  return num;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "sdb.h"
18
19	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow);
20
21	const char *sdbTableName(ESdbType type) {	1,602,422✔
22	switch (type) {	1,602,422!
23	case SDB_TRANS:	230,632✔
24	return "trans";	230,632✔
25	case SDB_CLUSTER:	20,427✔
26	return "cluster";	20,427✔
27	case SDB_MNODE:	34,876✔
28	return "mnode";	34,876✔
29	case SDB_QNODE:	17,895✔
30	return "qnode";	17,895✔
31	case SDB_SNODE:	7,229✔
32	return "snode";	7,229✔
33	case SDB_DNODE:	122,844✔
34	return "dnode";	122,844✔
35	case SDB_USER:	40,214✔
36	return "user";	40,214✔
37	case SDB_AUTH:	×
38	return "auth";	×
39	case SDB_ACCT:	13,334✔
40	return "acct";	13,334✔
41	case SDB_STREAM_CK:	×
42	return "stream_ck";	×
43	case SDB_STREAM:	39,587✔
44	return "stream";	39,587✔
45	case SDB_OFFSET:	×
46	return "offset";	×
47	case SDB_SUBSCRIBE:	10,965✔
48	return "subscribe";	10,965✔
49	case SDB_CONSUMER:	14,655✔
50	return "consumer";	14,655✔
51	case SDB_TOPIC:	9,715✔
52	return "topic";	9,715✔
53	case SDB_VGROUP:	286,162✔
54	return "vgroup";	286,162✔
55	case SDB_SMA:	33,014✔
56	return "sma";	33,014✔
57	case SDB_STB:	97,112✔
58	return "stb";	97,112✔
59	case SDB_DB:	79,091✔
60	return "db";	79,091✔
61	case SDB_FUNC:	7,305✔
62	return "func";	7,305✔
63	case SDB_IDX:	35,907✔
64	return "idx";	35,907✔
65	case SDB_VIEW:	8,255✔
66	return "view";	8,255✔
67	case SDB_STREAM_SEQ:	7,122✔
68	return "stream_seq";	7,122✔
69	case SDB_COMPACT:	7,149✔
70	return "compact";	7,149✔
71	case SDB_COMPACT_DETAIL:	7,272✔
72	return "compact_detail";	7,272✔
73	case SDB_GRANT:	15,745✔
74	return "grant";	15,745✔
75	case SDB_ARBGROUP:	7,220✔
76	return "arb_group";	7,220✔
77	case SDB_ANODE:	7,133✔
78	return "anode";	7,133✔
79	case SDB_CFG:	441,563✔
80	return "config";	441,563✔
UNCOV 81	default:	×
UNCOV 82	return "undefine";	×
83	}
84	}
85
86	const char *sdbStatusName(ESdbStatus status) {	969,543✔
87	switch (status) {	969,543✔
88	case SDB_STATUS_CREATING:	25,240✔
89	return "creating";	25,240✔
90	case SDB_STATUS_DROPPING:	5,187✔
91	return "dropping";	5,187✔
92	case SDB_STATUS_READY:	877,793✔
93	return "ready";	877,793✔
94	case SDB_STATUS_DROPPED:	51,423✔
95	return "dropped";	51,423✔
96	case SDB_STATUS_INIT:	9,871✔
97	return "init";	9,871✔
98	case SDB_STATUS_UPDATE:	28✔
99	return "update";	28✔
100	default:	1✔
101	return "undefine";	1✔
102	}
103	}
104
105	void sdbPrintOper(SSdb pSdb, SSdbRow pRow, const char *oper) {	10,955,761✔
106	#if 1
107	EKeyType keyType = pSdb->keyTypes[pRow->type];	10,955,761✔
108
109	if (keyType == SDB_KEY_BINARY) {	10,955,761✔
110	mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,	4,401,417✔
111	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
112	} else if (keyType == SDB_KEY_INT32) {	6,554,344✔
113	mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (int32_t )pRow->pObj,	5,240,451✔
114	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
115	} else if (keyType == SDB_KEY_INT64) {	1,313,893!
116	mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),	1,314,456✔
117	(int64_t )pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
118	} else {
119	}
120	#endif
121	}	10,955,761✔
122
123	static SHashObj sdbGetHash(SSdb pSdb, int32_t type) {	7,433,809✔
124	if (type >= SDB_MAX \|\| type < 0) {	7,433,809!
125	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	×
126	return NULL;	1✔
127	}
128
129	SHashObj *hash = pSdb->hashObjs[type];	7,433,855✔
130	if (hash == NULL) {	7,433,855✔
131	terrno = TSDB_CODE_APP_ERROR;	4✔
132	return NULL;	4✔
133	}
134
135	return hash;	7,433,851✔
136	}
137
138	static int32_t sdbGetkeySize(SSdb pSdb, ESdbType type, const void pKey) {	4,342,977✔
139	int32_t keySize = 0;	4,342,977✔
140	EKeyType keyType = pSdb->keyTypes[type];	4,342,977✔
141
142	if (keyType == SDB_KEY_INT32) {	4,342,977✔
143	keySize = sizeof(int32_t);	1,983,913✔
144	} else if (keyType == SDB_KEY_BINARY) {	2,359,064✔
145	keySize = strlen(pKey) + 1;	1,789,921✔
146	} else {
147	keySize = sizeof(int64_t);	569,143✔
148	}
149
150	return keySize;	4,342,977✔
151	}
152
153	static int32_t sdbInsertRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	250,242✔
154	int32_t type = pRow->type;	250,242✔
155	sdbWriteLock(pSdb, type);	250,242✔
156
157	SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);	250,242✔
158	if (pOldRow != NULL) {	250,242!
159	sdbUnLock(pSdb, type);	×
160	sdbFreeRow(pSdb, pRow, false);	×
161	terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;	×
162	return terrno;	×
163	}
164
165	pRow->refCount = 0;	250,242✔
166	pRow->status = pRaw->status;	250,242✔
167	sdbPrintOper(pSdb, pRow, "insert");	250,242✔
168
169	int32_t code = 0;	250,242✔
170	if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {	250,242!
171	sdbUnLock(pSdb, type);	×
172	sdbFreeRow(pSdb, pRow, false);	×
173	return code;	×
174	}
175
176	SdbInsertFp insertFp = pSdb->insertFps[pRow->type];	250,242✔
177	if (insertFp != NULL) {	250,242!
178	code = (*insertFp)(pSdb, pRow->pObj);	250,242✔
179	if (code != 0) {	250,242!
180	if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {	×
181	mError("failed to remove row from hash");	×
182	}
183	sdbFreeRow(pSdb, pRow, false);	×
184	sdbUnLock(pSdb, type);	×
185	terrno = code;	×
186	return terrno;	×
187	}
188	}
189
190	sdbUnLock(pSdb, type);	250,242✔
191
192	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {	250,242✔
193	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int32_t )pRow->pObj));	61,183✔
194	}
195	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {	250,242✔
196	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int64_t )pRow->pObj));	2,332✔
197	}
198	pSdb->tableVer[pRow->type]++;	250,242✔
199
200	return 0;	250,242✔
201	}
202
203	static int32_t sdbUpdateRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pNewRow, int32_t keySize) {	330,144✔
204	int32_t type = pNewRow->type;	330,144✔
205	sdbWriteLock(pSdb, type);	330,144✔
206
207	SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);	330,144✔
208	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	330,144!
209	sdbUnLock(pSdb, type);	237,095✔
210	return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);	237,095✔
211	}
212
213	SSdbRow pOldRow = ppOldRow;	93,049✔
214	pOldRow->status = pRaw->status;	93,049✔
215	sdbPrintOper(pSdb, pOldRow, "update");	93,049✔
216
217	int32_t code = 0;	93,049✔
218	SdbUpdateFp updateFp = pSdb->updateFps[type];	93,049✔
219	if (updateFp != NULL) {	93,049!
220	code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);	93,049✔
221	}
222	sdbUnLock(pSdb, type);	93,049✔
223
224	// sdbUnLock(pSdb, type);
225	sdbFreeRow(pSdb, pNewRow, false);	93,049✔
226
227	pSdb->tableVer[pOldRow->type]++;	93,049✔
228	return code;	93,049✔
229	}
230
231	static int32_t sdbDeleteRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	57,749✔
232	int32_t type = pRow->type;	57,749✔
233	sdbWriteLock(pSdb, type);	57,749✔
234
235	SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);	57,749✔
236	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	57,749!
237	sdbUnLock(pSdb, type);	14✔
238	sdbFreeRow(pSdb, pRow, false);	14✔
239	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	14✔
240	return terrno;	14✔
241	}
242	SSdbRow pOldRow = ppOldRow;	57,735✔
243	pOldRow->status = pRaw->status;	57,735✔
244
245	(void)atomic_add_fetch_32(&pOldRow->refCount, 1);	57,735✔
246	sdbPrintOper(pSdb, pOldRow, "delete");	57,735✔
247
248	if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {	57,735!
249	sdbUnLock(pSdb, type);	×
250	sdbFreeRow(pSdb, pRow, false);	×
251	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	×
252	return terrno;	×
253	}
254	pSdb->tableVer[pOldRow->type]++;	57,735✔
255	sdbUnLock(pSdb, type);	57,735✔
256
257	sdbFreeRow(pSdb, pRow, false);	57,735✔
258
259	sdbCheckRow(pSdb, pOldRow);	57,735✔
260	return 0;	57,735✔
261	}
262
263	int32_t sdbWriteWithoutFree(SSdb pSdb, SSdbRaw pRaw) {	401,042✔
264	if (pRaw->type == SDB_CFG) {	401,042✔
265	mTrace("sdb write cfg");	158,150✔
266	}
267	SHashObj *hash = sdbGetHash(pSdb, pRaw->type);	401,042✔
268	if (hash == NULL) return terrno;	401,042✔
269
270	SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];	401,040✔
271	SSdbRow pRow = (decodeFp)(pRaw);	401,040✔
272	if (pRow == NULL) return terrno;	401,040!
273
274	pRow->type = pRaw->type;	401,040✔
275
276	int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);	401,040✔
277	int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;	401,040✔
278
279	switch (pRaw->status) {	401,040!
280	case SDB_STATUS_CREATING:	13,147✔
281	code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);	13,147✔
282	break;	13,147✔
283	case SDB_STATUS_READY:	330,144✔
284	case SDB_STATUS_UPDATE:
285	case SDB_STATUS_DROPPING:
286	code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);	330,144✔
287	break;	330,144✔
288	case SDB_STATUS_DROPPED:	57,749✔
289	code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);	57,749✔
290	break;	57,749✔
291	}
292
293	return code;	401,040✔
294	}
295
296	int32_t sdbWrite(SSdb pSdb, SSdbRaw pRaw) {	45,433✔
297	int32_t code = sdbWriteWithoutFree(pSdb, pRaw);	45,433✔
298	sdbFreeRaw(pRaw);	45,433✔
299	return code;	45,433✔
300	}
301
302	void sdbAcquireAll(SSdb pSdb, ESdbType type, const void *pKey, bool onlyReady) {	3,941,957✔
303	terrno = 0;	3,941,957✔
304
305	SHashObj *hash = sdbGetHash(pSdb, type);	3,941,954✔
306	if (hash == NULL) return NULL;	3,941,942✔
307
308	void *pRet = NULL;	3,941,941✔
309	int32_t keySize = sdbGetkeySize(pSdb, type, pKey);	3,941,941✔
310
311	sdbReadLock(pSdb, type);	3,941,934✔
312
313	SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);	3,941,957✔
314	if (ppRow == NULL \|\| *ppRow == NULL) {	3,941,971!
315	sdbUnLock(pSdb, type);	832,229✔
316	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	832,231✔
317	return NULL;	832,231✔
318	}
319
320	SSdbRow pRow = ppRow;	3,109,742✔
321	switch (pRow->status) {	3,109,742✔
322	case SDB_STATUS_READY:	3,103,666✔
323	(void)atomic_add_fetch_32(&pRow->refCount, 1);	3,103,666✔
324	pRet = pRow->pObj;	3,103,671✔
325	sdbPrintOper(pSdb, pRow, "acquire");	3,103,671✔
326	break;	3,103,666✔
327	case SDB_STATUS_CREATING:	4,121✔
328	terrno = TSDB_CODE_SDB_OBJ_CREATING;	4,121✔
329	break;	4,121✔
330	case SDB_STATUS_DROPPING:	1,954✔
331	terrno = TSDB_CODE_SDB_OBJ_DROPPING;	1,954✔
332	break;	1,954✔
333	default:	1✔
334	terrno = TSDB_CODE_APP_ERROR;	1✔
335	break;	×
336	}
337
338	if (pRet == NULL) {	3,109,741✔
339	if (!onlyReady) {	6,075!
340	terrno = 0;	×
341	(void)atomic_add_fetch_32(&pRow->refCount, 1);	×
342	pRet = pRow->pObj;	×
343	sdbPrintOper(pSdb, pRow, "acquire");	×
344	}
345	}
346
347	sdbUnLock(pSdb, type);	3,109,741✔
348	return pRet;	3,109,745✔
349	}
350
351	void sdbAcquire(SSdb pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }	3,939,615✔
352	void sdbAcquireNotReadyObj(SSdb pSdb, ESdbType type, const void *pKey) {	2,349✔
353	return sdbAcquireAll(pSdb, type, pKey, false);	2,349✔
354	}
355
356	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow) {	57,735✔
357	int32_t type = pRow->type;	57,735✔
358	sdbWriteLock(pSdb, type);	57,735✔
359
360	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	57,735✔
361	sdbPrintOper(pSdb, pRow, "check");	57,735✔
362	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	57,735!
363	sdbFreeRow(pSdb, pRow, true);	11,624✔
364	}
365
366	sdbUnLock(pSdb, type);	57,735✔
367	}	57,735✔
368
369	void sdbReleaseLock(SSdb pSdb, void pObj, bool lock) {	4,932,097✔
370	if (pObj == NULL) return;	4,932,097✔
371
372	SSdbRow pRow = (SSdbRow )((char *)pObj - sizeof(SSdbRow));	4,887,561✔
373	if (pRow->type >= SDB_MAX) return;	4,887,561✔
374
375	int32_t type = pRow->type;	4,887,560✔
376	if (lock) {	4,887,560✔
377	sdbWriteLock(pSdb, type);	4,883,825✔
378	}
379
380	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	4,887,905✔
381	sdbPrintOper(pSdb, pRow, "release");	4,887,942✔
382	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	4,887,901✔
383	sdbFreeRow(pSdb, pRow, true);	46,111✔
384	}
385
386	if (lock) {	4,887,901✔
387	sdbUnLock(pSdb, type);	4,884,151✔
388	}
389	}
390
391	void sdbRelease(SSdb pSdb, void pObj) { sdbReleaseLock(pSdb, pObj, true); }	4,928,363✔
392
393	void sdbFetch(SSdb pSdb, ESdbType type, void pIter, void *ppObj) {	2,100,426✔
394	*ppObj = NULL;	2,100,426✔
395
396	SHashObj *hash = sdbGetHash(pSdb, type);	2,100,426✔
397	if (hash == NULL) return NULL;	2,100,393✔
398
399	sdbReadLock(pSdb, type);	2,100,392✔
400
401	SSdbRow **ppRow = taosHashIterate(hash, pIter);	2,100,557✔
402	while (ppRow != NULL) {	2,112,817✔
403	SSdbRow pRow = ppRow;	1,560,691✔
404	if (pRow == NULL \|\| pRow->status != SDB_STATUS_READY) {	1,560,691!
405	ppRow = taosHashIterate(hash, ppRow);	12,277✔
406	continue;	12,275✔
407	}
408
409	(void)atomic_add_fetch_32(&pRow->refCount, 1);	1,548,414✔
410	sdbPrintOper(pSdb, pRow, "fetch");	1,548,423✔
411	*ppObj = pRow->pObj;	1,548,400✔
412	break;	1,548,400✔
413	}
414	sdbUnLock(pSdb, type);	2,100,526✔
415
416	return ppRow;	2,100,579✔
417	}
418
419	void sdbFetchAll(SSdb pSdb, ESdbType type, void pIter, void ppObj, ESdbStatus status, bool lock) {	295,507✔
420	*ppObj = NULL;	295,507✔
421
422	SHashObj *hash = sdbGetHash(pSdb, type);	295,507✔
423	if (hash == NULL) return NULL;	295,507!
424
425	if (lock) {	295,507✔
426	sdbReadLock(pSdb, type);	289,196✔
427	}
428
429	SSdbRow **ppRow = taosHashIterate(hash, pIter);	295,507✔
430	while (ppRow != NULL) {	295,507✔
431	SSdbRow pRow = ppRow;	232,218✔
432	if (pRow == NULL) {	232,218!
433	ppRow = taosHashIterate(hash, ppRow);	×
434	continue;	×
435	}
436
437	(void)atomic_add_fetch_32(&pRow->refCount, 1);	232,218✔
438	sdbPrintOper(pSdb, pRow, "fetch");	232,218✔
439	*ppObj = pRow->pObj;	232,218✔
440	*status = pRow->status;	232,218✔
441	break;	232,218✔
442	}
443	if (lock) {	295,507✔
444	sdbUnLock(pSdb, type);	289,196✔
445	}
446
447	return ppRow;	295,507✔
448	}
449
450	void sdbCancelFetch(SSdb pSdb, void pIter) {	232,110✔
451	if (pIter == NULL) return;	232,110✔
452	SSdbRow pRow = (SSdbRow **)pIter;	230,547✔
453	mTrace("cancel fetch row:%p", pRow);	230,547✔
454	SHashObj *hash = sdbGetHash(pSdb, pRow->type);	230,547✔
455	if (hash == NULL) return;	230,547!
456
457	int32_t type = pRow->type;	230,547✔
458	sdbReadLock(pSdb, type);	230,547✔
459	taosHashCancelIterate(hash, pIter);	230,547✔
460	sdbUnLock(pSdb, type);	230,547✔
461	}
462
463	void sdbCancelFetchByType(SSdb pSdb, void pIter, ESdbType type) {	×
464	if (pIter == NULL) return;	×
465	if (type >= SDB_MAX \|\| type < 0) return;	×
466	SHashObj *hash = sdbGetHash(pSdb, type);	×
467	if (hash == NULL) return;	×
468
469	sdbReadLock(pSdb, type);	×
470	taosHashCancelIterate(hash, pIter);	×
471	sdbUnLock(pSdb, type);	×
472	}
473
474	void sdbTraverse(SSdb pSdb, ESdbType type, sdbTraverseFp fp, void p1, void p2, void p3) {	22,795✔
475	SHashObj *hash = sdbGetHash(pSdb, type);	22,795✔
476	if (hash == NULL) return;	22,795!
477
478	sdbReadLock(pSdb, type);	22,795✔
479
480	SSdbRow **ppRow = taosHashIterate(hash, NULL);	22,795✔
481	while (ppRow != NULL) {	83,510✔
482	SSdbRow pRow = ppRow;	60,717✔
483	if (pRow->status == SDB_STATUS_READY) {	60,717✔
484	bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);	53,709✔
485	if (!isContinue) {	53,709✔
486	taosHashCancelIterate(hash, ppRow);	2✔
487	break;	2✔
488	}
489	}
490
491	ppRow = taosHashIterate(hash, ppRow);	60,715✔
492	}
493
494	sdbUnLock(pSdb, type);	22,795✔
495	}
496
497	int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {	392,871✔
498	SHashObj *hash = sdbGetHash(pSdb, type);	392,871✔
499	if (hash == NULL) return 0;	392,878!
500
501	sdbReadLock(pSdb, type);	392,878✔
502	int32_t size = taosHashGetSize(hash);	392,883✔
503	sdbUnLock(pSdb, type);	392,869✔
504
505	return size;	392,883✔
506	}
507
508	int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {	49,657✔
509	SHashObj *hash = sdbGetHash(pSdb, type);	49,657✔
510	if (hash == NULL) return -1;	49,657✔
511
512	if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;	49,656✔
513
514	int32_t maxId = 0;	49,650✔
515	sdbReadLock(pSdb, type);	49,650✔
516
517	SSdbRow **ppRow = taosHashIterate(hash, NULL);	49,650✔
518	while (ppRow != NULL) {	91,339✔
519	SSdbRow pRow = ppRow;	41,689✔
520	int32_t id = (int32_t )pRow->pObj;	41,689✔
521	maxId = TMAX(id, maxId);	41,689✔
522	ppRow = taosHashIterate(hash, ppRow);	41,689✔
523	}
524
525	sdbUnLock(pSdb, type);	49,650✔
526	maxId = TMAX(maxId, pSdb->maxId[type]);	49,650✔
527	return maxId + 1;	49,650✔
528	}
529
530	int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {	229,248✔
531	if (type >= SDB_MAX \|\| type < 0) {	229,248✔
532	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	1✔
533	return -1;	1✔
534	}
535
536	return pSdb->tableVer[type];	229,247✔
537	}
538
539	bool countValid(SMnode pMnode, void pObj, void p1, void p2, void *p3) {	×
540	int32_t *pInt = p1;	×
541	(*pInt) += 1;	×
542	return true;	×
543	}
544
545	int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {	×
546	int32_t num = 0;	×
547	sdbTraverse(pSdb, type, countValid, &num, 0, 0);	×
548	return num;	×
549	}

taosdata / TDengine / #3655

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous