#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/source/libs/sync/src/syncRequestVoteReply.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "syncRequestVoteReply.h"
#include "syncMessage.h"
#include "syncRaftStore.h"
#include "syncUtil.h"
#include "syncVoteMgr.h"

// TLA+ Spec
// HandleRequestVoteResponse(i, j, m) ==
//    \* This tallies votes even when the current state is not Candidate, but
//    \* they won't be looked at, so it doesn't matter.
//    /\ m.mterm = currentTerm[i]
//    /\ votesResponded' = [votesResponded EXCEPT ![i] =
//                              votesResponded[i] \cup {j}]
//    /\ \/ /\ m.mvoteGranted
//          /\ votesGranted' = [votesGranted EXCEPT ![i] =
//                                  votesGranted[i] \cup {j}]
//          /\ voterLog' = [voterLog EXCEPT ![i] =
//                              voterLog[i] @@ (j :> m.mlog)]
//       \/ /\ ~m.mvoteGranted
//          /\ UNCHANGED <<votesGranted, voterLog>>
//    /\ Discard(m)
//    /\ UNCHANGED <<serverVars, votedFor, leaderVars, logVars>>
//

int32_t syncNodeOnRequestVoteReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {
  int32_t               ret = 0;
  SyncRequestVoteReply* pMsg = pRpcMsg->pCont;

  // if already drop replica, do not process
  if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {
    syncLogRecvRequestVoteReply(ths, pMsg, "not in my config");

    TAOS_RETURN(TSDB_CODE_SYN_MISMATCHED_SIGNATURE);
  }
  SyncTerm currentTerm = raftStoreGetTerm(ths);
  // drop stale response
  if (pMsg->term < currentTerm) {
    syncLogRecvRequestVoteReply(ths, pMsg, "drop stale response");

    TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);
  }

  if (pMsg->term > currentTerm) {
    syncLogRecvRequestVoteReply(ths, pMsg, "error term");
    syncNodeStepDown(ths, pMsg->term, pMsg->destId);

    TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);
  }

  syncLogRecvRequestVoteReply(ths, pMsg, "");
  if (pMsg->term != currentTerm) return TSDB_CODE_SYN_INTERNAL_ERROR;

  // This tallies votes even when the current state is not Candidate,
  // but they won't be looked at, so it doesn't matter.
  if (ths->state == TAOS_SYNC_STATE_CANDIDATE) {
    if (ths->pVotesRespond->term != pMsg->term) {
      sNError(ths, "vote respond error vote-respond-mgr term:%" PRIu64 ", msg term:%" PRIu64 "",
              ths->pVotesRespond->term, pMsg->term);

      TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);
    }

    votesRespondAdd(ths->pVotesRespond, pMsg);
    if (pMsg->voteGranted) {
      // add vote
      voteGrantedVote(ths->pVotesGranted, pMsg);

      // maybe to leader
      if (voteGrantedMajority(ths->pVotesGranted)) {
        if (!ths->pVotesGranted->toLeader) {
          syncNodeCandidate2Leader(ths);

          // prevent to leader again!
          ths->pVotesGranted->toLeader = true;
        }
      }
    } else {
      ;
      // do nothing
      // UNCHANGED <<votesGranted, voterLog>>
    }
  }

  TAOS_RETURN(TSDB_CODE_SUCCESS);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "syncRequestVoteReply.h"
18	#include "syncMessage.h"
19	#include "syncRaftStore.h"
20	#include "syncUtil.h"
21	#include "syncVoteMgr.h"
22
23	// TLA+ Spec
24	// HandleRequestVoteResponse(i, j, m) ==
25	// \* This tallies votes even when the current state is not Candidate, but
26	// \* they won't be looked at, so it doesn't matter.
27	// /\ m.mterm = currentTerm[i]
28	// /\ votesResponded' = [votesResponded EXCEPT ![i] =
29	// votesResponded[i] \cup {j}]
30	// /\ \/ /\ m.mvoteGranted
31	// /\ votesGranted' = [votesGranted EXCEPT ![i] =
32	// votesGranted[i] \cup {j}]
33	// /\ voterLog' = [voterLog EXCEPT ![i] =
34	// voterLog[i] @@ (j :> m.mlog)]
35	// \/ /\ ~m.mvoteGranted
36	// /\ UNCHANGED <<votesGranted, voterLog>>
37	// /\ Discard(m)
38	// /\ UNCHANGED <<serverVars, votedFor, leaderVars, logVars>>
39	//
40
UNCOV 41	int32_t syncNodeOnRequestVoteReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {	×
UNCOV 42	int32_t ret = 0;	×
UNCOV 43	SyncRequestVoteReply* pMsg = pRpcMsg->pCont;	×
44
45	// if already drop replica, do not process
UNCOV 46	if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {	×
47	syncLogRecvRequestVoteReply(ths, pMsg, "not in my config");	×
48
49	TAOS_RETURN(TSDB_CODE_SYN_MISMATCHED_SIGNATURE);	×
50	}
UNCOV 51	SyncTerm currentTerm = raftStoreGetTerm(ths);	×
52	// drop stale response
UNCOV 53	if (pMsg->term < currentTerm) {	×
54	syncLogRecvRequestVoteReply(ths, pMsg, "drop stale response");	×
55
56	TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);	×
57	}
58
UNCOV 59	if (pMsg->term > currentTerm) {	×
UNCOV 60	syncLogRecvRequestVoteReply(ths, pMsg, "error term");	×
UNCOV 61	syncNodeStepDown(ths, pMsg->term, pMsg->destId);	×
62
UNCOV 63	TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);	×
64	}
65
UNCOV 66	syncLogRecvRequestVoteReply(ths, pMsg, "");	×
UNCOV 67	if (pMsg->term != currentTerm) return TSDB_CODE_SYN_INTERNAL_ERROR;	×
68
69	// This tallies votes even when the current state is not Candidate,
70	// but they won't be looked at, so it doesn't matter.
UNCOV 71	if (ths->state == TAOS_SYNC_STATE_CANDIDATE) {	×
UNCOV 72	if (ths->pVotesRespond->term != pMsg->term) {	×
73	sNError(ths, "vote respond error vote-respond-mgr term:%" PRIu64 ", msg term:%" PRIu64 "",	×
74	ths->pVotesRespond->term, pMsg->term);
75
76	TAOS_RETURN(TSDB_CODE_SYN_WRONG_TERM);	×
77	}
78
UNCOV 79	votesRespondAdd(ths->pVotesRespond, pMsg);	×
UNCOV 80	if (pMsg->voteGranted) {	×
81	// add vote
UNCOV 82	voteGrantedVote(ths->pVotesGranted, pMsg);	×
83
84	// maybe to leader
UNCOV 85	if (voteGrantedMajority(ths->pVotesGranted)) {	×
UNCOV 86	if (!ths->pVotesGranted->toLeader) {	×
UNCOV 87	syncNodeCandidate2Leader(ths);	×
88
89	// prevent to leader again!
UNCOV 90	ths->pVotesGranted->toLeader = true;	×
91	}
92	}
93	} else {
94	;
95	// do nothing
96	// UNCHANGED <<votesGranted, voterLog>>
97	}
98	}
99
UNCOV 100	TAOS_RETURN(TSDB_CODE_SUCCESS);	×
101	}

taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous