#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/source/libs/sync/src/syncAppendEntriesReply.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "syncAppendEntriesReply.h"
#include "syncCommit.h"
#include "syncIndexMgr.h"
#include "syncPipeline.h"
#include "syncMessage.h"
#include "syncRaftEntry.h"
#include "syncRaftStore.h"
#include "syncReplication.h"
#include "syncSnapshot.h"
#include "syncUtil.h"

// TLA+ Spec
// HandleAppendEntriesResponse(i, j, m) ==
//    /\ m.mterm = currentTerm[i]
//    /\ \/ /\ m.msuccess \* successful
//          /\ nextIndex'  = [nextIndex  EXCEPT ![i][j] = m.mmatchIndex + 1]
//          /\ matchIndex' = [matchIndex EXCEPT ![i][j] = m.mmatchIndex]
//       \/ /\ \lnot m.msuccess \* not successful
//          /\ nextIndex' = [nextIndex EXCEPT ![i][j] =
//                               Max({nextIndex[i][j] - 1, 1})]
//          /\ UNCHANGED <<matchIndex>>
//    /\ Discard(m)
//    /\ UNCHANGED <<serverVars, candidateVars, logVars, elections>>
//

int32_t syncNodeOnAppendEntriesReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {
  int32_t                 code = 0;
  SyncAppendEntriesReply* pMsg = (SyncAppendEntriesReply*)pRpcMsg->pCont;
  int32_t ret = 0;
  const STraceId*         trace = &pRpcMsg->info.traceId;
  char                    tbuf[40] = {0};

  // if already drop replica, do not process
  if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {
    syncLogRecvAppendEntriesReply(ths, pMsg, "not in my config");
    return 0;
  }

  // drop stale response
  if (pMsg->term < raftStoreGetTerm(ths)) {
    syncLogRecvAppendEntriesReply(ths, pMsg, "drop stale response");
    return 0;
  }

  if (ths->state == TAOS_SYNC_STATE_LEADER || ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {
    if (pMsg->term != raftStoreGetTerm(ths)) {
      syncLogRecvAppendEntriesReply(ths, pMsg, "error term");
      syncNodeStepDown(ths, pMsg->term, pMsg->srcId);
      return TSDB_CODE_SYN_WRONG_TERM;
    }

    sGTrace("vgId:%d, received append entries reply. srcId:0x%016" PRIx64 ",  term:%" PRId64 ", matchIndex:%" PRId64 "",
            pMsg->vgId, pMsg->srcId.addr, pMsg->term, pMsg->matchIndex);

    if (pMsg->success) {
      SyncIndex oldMatchIndex = syncIndexMgrGetIndex(ths->pMatchIndex, &(pMsg->srcId));
      if (pMsg->matchIndex > oldMatchIndex) {
        syncIndexMgrSetIndex(ths->pMatchIndex, &(pMsg->srcId), pMsg->matchIndex);
      }

      // commit if needed
      SyncIndex indexLikely = TMIN(pMsg->matchIndex, ths->pLogBuf->matchIndex);
      SyncIndex commitIndex = syncNodeCheckCommitIndex(ths, indexLikely);
      if (ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {
        if (commitIndex >= ths->assignedCommitIndex) {
          syncNodeStepDown(ths, pMsg->term, pMsg->destId);
        }
      } else {
        TAOS_CHECK_RETURN(syncLogBufferCommit(ths->pLogBuf, ths, commitIndex));
      }
    }

    // replicate log
    SSyncLogReplMgr* pMgr = syncNodeGetLogReplMgr(ths, &pMsg->srcId);
    if (pMgr == NULL) {
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
      if (terrno != 0) code = terrno;
      sError("vgId:%d, failed to get log repl mgr for src addr: 0x%016" PRIx64, ths->vgId, pMsg->srcId.addr);
      TAOS_RETURN(code);
    }
    TAOS_CHECK_RETURN(syncLogReplProcessReply(pMgr, ths, pMsg));
  }
  TAOS_RETURN(code);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "syncAppendEntriesReply.h"
18	#include "syncCommit.h"
19	#include "syncIndexMgr.h"
20	#include "syncPipeline.h"
21	#include "syncMessage.h"
22	#include "syncRaftEntry.h"
23	#include "syncRaftStore.h"
24	#include "syncReplication.h"
25	#include "syncSnapshot.h"
26	#include "syncUtil.h"
27
28	// TLA+ Spec
29	// HandleAppendEntriesResponse(i, j, m) ==
30	// /\ m.mterm = currentTerm[i]
31	// /\ \/ /\ m.msuccess \* successful
32	// /\ nextIndex' = [nextIndex EXCEPT ![i][j] = m.mmatchIndex + 1]
33	// /\ matchIndex' = [matchIndex EXCEPT ![i][j] = m.mmatchIndex]
34	// \/ /\ \lnot m.msuccess \* not successful
35	// /\ nextIndex' = [nextIndex EXCEPT ![i][j] =
36	// Max({nextIndex[i][j] - 1, 1})]
37	// /\ UNCHANGED <<matchIndex>>
38	// /\ Discard(m)
39	// /\ UNCHANGED <<serverVars, candidateVars, logVars, elections>>
40	//
41
UNCOV 42	int32_t syncNodeOnAppendEntriesReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {	×
UNCOV 43	int32_t code = 0;	×
UNCOV 44	SyncAppendEntriesReply* pMsg = (SyncAppendEntriesReply*)pRpcMsg->pCont;	×
UNCOV 45	int32_t ret = 0;	×
UNCOV 46	const STraceId* trace = &pRpcMsg->info.traceId;	×
UNCOV 47	char tbuf[40] = {0};	×
48
49	// if already drop replica, do not process
UNCOV 50	if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {	×
51	syncLogRecvAppendEntriesReply(ths, pMsg, "not in my config");	×
52	return 0;	×
53	}
54
55	// drop stale response
UNCOV 56	if (pMsg->term < raftStoreGetTerm(ths)) {	×
57	syncLogRecvAppendEntriesReply(ths, pMsg, "drop stale response");	×
58	return 0;	×
59	}
60
UNCOV 61	if (ths->state == TAOS_SYNC_STATE_LEADER \|\| ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {	×
UNCOV 62	if (pMsg->term != raftStoreGetTerm(ths)) {	×
63	syncLogRecvAppendEntriesReply(ths, pMsg, "error term");	×
64	syncNodeStepDown(ths, pMsg->term, pMsg->srcId);	×
65	return TSDB_CODE_SYN_WRONG_TERM;	×
66	}
67
UNCOV 68	sGTrace("vgId:%d, received append entries reply. srcId:0x%016" PRIx64 ", term:%" PRId64 ", matchIndex:%" PRId64 "",	×
69	pMsg->vgId, pMsg->srcId.addr, pMsg->term, pMsg->matchIndex);
70
UNCOV 71	if (pMsg->success) {	×
UNCOV 72	SyncIndex oldMatchIndex = syncIndexMgrGetIndex(ths->pMatchIndex, &(pMsg->srcId));	×
UNCOV 73	if (pMsg->matchIndex > oldMatchIndex) {	×
UNCOV 74	syncIndexMgrSetIndex(ths->pMatchIndex, &(pMsg->srcId), pMsg->matchIndex);	×
75	}
76
77	// commit if needed
UNCOV 78	SyncIndex indexLikely = TMIN(pMsg->matchIndex, ths->pLogBuf->matchIndex);	×
UNCOV 79	SyncIndex commitIndex = syncNodeCheckCommitIndex(ths, indexLikely);	×
UNCOV 80	if (ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {	×
81	if (commitIndex >= ths->assignedCommitIndex) {	×
82	syncNodeStepDown(ths, pMsg->term, pMsg->destId);	×
83	}
84	} else {
UNCOV 85	TAOS_CHECK_RETURN(syncLogBufferCommit(ths->pLogBuf, ths, commitIndex));	×
86	}
87	}
88
89	// replicate log
UNCOV 90	SSyncLogReplMgr* pMgr = syncNodeGetLogReplMgr(ths, &pMsg->srcId);	×
UNCOV 91	if (pMgr == NULL) {	×
UNCOV 92	code = TSDB_CODE_MND_RETURN_VALUE_NULL;	×
UNCOV 93	if (terrno != 0) code = terrno;	×
UNCOV 94	sError("vgId:%d, failed to get log repl mgr for src addr: 0x%016" PRIx64, ths->vgId, pMsg->srcId.addr);	×
UNCOV 95	TAOS_RETURN(code);	×
96	}
UNCOV 97	TAOS_CHECK_RETURN(syncLogReplProcessReply(pMgr, ths, pMsg));	×
98	}
UNCOV 99	TAOS_RETURN(code);	×
100	}

taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous