#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.33

/source/dnode/mnode/sdb/src/sdbHash.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "sdb.h"

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow);

const char *sdbTableName(ESdbType type) {
  switch (type) {
    case SDB_TRANS:
      return "trans";
    case SDB_CLUSTER:
      return "cluster";
    case SDB_MNODE:
      return "mnode";
    case SDB_QNODE:
      return "qnode";
    case SDB_SNODE:
      return "snode";
    case SDB_DNODE:
      return "dnode";
    case SDB_USER:
      return "user";
    case SDB_AUTH:
      return "auth";
    case SDB_ACCT:
      return "acct";
    case SDB_STREAM_CK:
      return "stream_ck";
    case SDB_STREAM:
      return "stream";
    case SDB_OFFSET:
      return "offset";
    case SDB_SUBSCRIBE:
      return "subscribe";
    case SDB_CONSUMER:
      return "consumer";
    case SDB_TOPIC:
      return "topic";
    case SDB_VGROUP:
      return "vgroup";
    case SDB_SMA:
      return "sma";
    case SDB_STB:
      return "stb";
    case SDB_DB:
      return "db";
    case SDB_FUNC:
      return "func";
    case SDB_IDX:
      return "idx";
    case SDB_VIEW:
      return "view";
    case SDB_STREAM_SEQ:
      return "stream_seq";
    case SDB_COMPACT:
      return "compact";
    case SDB_COMPACT_DETAIL:
      return "compact_detail";
    case SDB_GRANT:
      return "grant";
    case SDB_ARBGROUP:
      return "arb_group";
    case SDB_ANODE:
      return "anode";
    case SDB_CFG:
      return "config";
    default:
      return "undefine";
  }
}

const char *sdbStatusName(ESdbStatus status) {
  switch (status) {
    case SDB_STATUS_CREATING:
      return "creating";
    case SDB_STATUS_DROPPING:
      return "dropping";
    case SDB_STATUS_READY:
      return "ready";
    case SDB_STATUS_DROPPED:
      return "dropped";
    case SDB_STATUS_INIT:
      return "init";
    case SDB_STATUS_UPDATE:
      return "update";
    default:
      return "undefine";
  }
}

void sdbPrintOper(SSdb *pSdb, SSdbRow *pRow, const char *oper) {
#if 1
  EKeyType keyType = pSdb->keyTypes[pRow->type];

  if (keyType == SDB_KEY_BINARY) {
    mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT32) {
    mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), *(int32_t *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT64) {
    mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),
           *(int64_t *)pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else {
  }
#endif
}

static SHashObj *sdbGetHash(SSdb *pSdb, int32_t type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return NULL;
  }

  SHashObj *hash = pSdb->hashObjs[type];
  if (hash == NULL) {
    terrno = TSDB_CODE_APP_ERROR;
    return NULL;
  }

  return hash;
}

static int32_t sdbGetkeySize(SSdb *pSdb, ESdbType type, const void *pKey) {
  int32_t  keySize = 0;
  EKeyType keyType = pSdb->keyTypes[type];

  if (keyType == SDB_KEY_INT32) {
    keySize = sizeof(int32_t);
  } else if (keyType == SDB_KEY_BINARY) {
    keySize = strlen(pKey) + 1;
  } else {
    keySize = sizeof(int64_t);
  }

  return keySize;
}

static int32_t sdbInsertRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (pOldRow != NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;
    return terrno;
  }

  pRow->refCount = 0;
  pRow->status = pRaw->status;
  sdbPrintOper(pSdb, pRow, "insert");

  int32_t code = 0;
  if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    return code;
  }

  SdbInsertFp insertFp = pSdb->insertFps[pRow->type];
  if (insertFp != NULL) {
    code = (*insertFp)(pSdb, pRow->pObj);
    if (code != 0) {
      if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {
        mError("failed to remove row from hash");
      }
      sdbFreeRow(pSdb, pRow, false);
      sdbUnLock(pSdb, type);
      terrno = code;
      return terrno;
    }
  }

  sdbUnLock(pSdb, type);

  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int32_t *)pRow->pObj));
  }
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int64_t *)pRow->pObj));
  }
  pSdb->tableVer[pRow->type]++;

  return 0;
}

static int32_t sdbUpdateRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pNewRow, int32_t keySize) {
  int32_t type = pNewRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);
  }

  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;
  sdbPrintOper(pSdb, pOldRow, "update");

  int32_t     code = 0;
  SdbUpdateFp updateFp = pSdb->updateFps[type];
  if (updateFp != NULL) {
    code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);
  }
  sdbUnLock(pSdb, type);

  // sdbUnLock(pSdb, type);
  sdbFreeRow(pSdb, pNewRow, false);

  pSdb->tableVer[pOldRow->type]++;
  return code;
}

static int32_t sdbDeleteRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;

  (void)atomic_add_fetch_32(&pOldRow->refCount, 1);
  sdbPrintOper(pSdb, pOldRow, "delete");

  if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  pSdb->tableVer[pOldRow->type]++;
  sdbUnLock(pSdb, type);

  sdbFreeRow(pSdb, pRow, false);

  sdbCheckRow(pSdb, pOldRow);
  return 0;
}

int32_t sdbWriteWithoutFree(SSdb *pSdb, SSdbRaw *pRaw) {
  if (pRaw->type == SDB_CFG) {
    mTrace("sdb write cfg");
  }
  SHashObj *hash = sdbGetHash(pSdb, pRaw->type);
  if (hash == NULL) return terrno;

  SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];
  SSdbRow    *pRow = (*decodeFp)(pRaw);
  if (pRow == NULL) return terrno;

  pRow->type = pRaw->type;

  int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);
  int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;

  switch (pRaw->status) {
    case SDB_STATUS_CREATING:
      code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_READY:
    case SDB_STATUS_UPDATE:
    case SDB_STATUS_DROPPING:
      code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_DROPPED:
      code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);
      break;
  }

  return code;
}

int32_t sdbWrite(SSdb *pSdb, SSdbRaw *pRaw) {
  int32_t code = sdbWriteWithoutFree(pSdb, pRaw);
  sdbFreeRaw(pRaw);
  return code;
}

void *sdbAcquireAll(SSdb *pSdb, ESdbType type, const void *pKey, bool onlyReady) {
  terrno = 0;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  void   *pRet = NULL;
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);
  if (ppRow == NULL || *ppRow == NULL) {
    sdbUnLock(pSdb, type);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return NULL;
  }

  SSdbRow *pRow = *ppRow;
  switch (pRow->status) {
    case SDB_STATUS_READY:
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
      break;
    case SDB_STATUS_CREATING:
      terrno = TSDB_CODE_SDB_OBJ_CREATING;
      break;
    case SDB_STATUS_DROPPING:
      terrno = TSDB_CODE_SDB_OBJ_DROPPING;
      break;
    default:
      terrno = TSDB_CODE_APP_ERROR;
      break;
  }

  if (pRet == NULL) {
    if (!onlyReady) {
      terrno = 0;
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
    }
  }

  sdbUnLock(pSdb, type);
  return pRet;
}

void *sdbAcquire(SSdb *pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }
void *sdbAcquireNotReadyObj(SSdb *pSdb, ESdbType type, const void *pKey) {
  return sdbAcquireAll(pSdb, type, pKey, false);
}

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "check");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  sdbUnLock(pSdb, type);
}

void sdbReleaseLock(SSdb *pSdb, void *pObj, bool lock) {
  if (pObj == NULL) return;

  SSdbRow *pRow = (SSdbRow *)((char *)pObj - sizeof(SSdbRow));
  if (pRow->type >= SDB_MAX) return;

  int32_t type = pRow->type;
  if (lock) {
    sdbWriteLock(pSdb, type);
  }

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "release");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  if (lock) {
    sdbUnLock(pSdb, type);
  }
}

void sdbRelease(SSdb *pSdb, void *pObj) { sdbReleaseLock(pSdb, pObj, true); }

void *sdbFetch(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL || pRow->status != SDB_STATUS_READY) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    break;
  }
  sdbUnLock(pSdb, type);

  return ppRow;
}

void *sdbFetchAll(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj, ESdbStatus *status, bool lock) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  if (lock) {
    sdbReadLock(pSdb, type);
  }

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    *status = pRow->status;
    break;
  }
  if (lock) {
    sdbUnLock(pSdb, type);
  }

  return ppRow;
}

void sdbCancelFetch(SSdb *pSdb, void *pIter) {
  if (pIter == NULL) return;
  SSdbRow *pRow = *(SSdbRow **)pIter;
  mTrace("cancel fetch row:%p", pRow);
  SHashObj *hash = sdbGetHash(pSdb, pRow->type);
  if (hash == NULL) return;

  int32_t type = pRow->type;
  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbCancelFetchByType(SSdb *pSdb, void *pIter, ESdbType type) {
  if (pIter == NULL) return;
  if (type >= SDB_MAX || type < 0) return;
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbTraverse(SSdb *pSdb, ESdbType type, sdbTraverseFp fp, void *p1, void *p2, void *p3) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow->status == SDB_STATUS_READY) {
      bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);
      if (!isContinue) {
        taosHashCancelIterate(hash, ppRow);
        break;
      }
    }

    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
}

int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return 0;

  sdbReadLock(pSdb, type);
  int32_t size = taosHashGetSize(hash);
  sdbUnLock(pSdb, type);

  return size;
}

int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return -1;

  if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;

  int32_t maxId = 0;
  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    int32_t  id = *(int32_t *)pRow->pObj;
    maxId = TMAX(id, maxId);
    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
  maxId = TMAX(maxId, pSdb->maxId[type]);
  return maxId + 1;
}

int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return -1;
  }

  return pSdb->tableVer[type];
}

bool countValid(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
  int32_t *pInt = p1;
  (*pInt) += 1;
  return true;
}

int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {
  int32_t num = 0;
  sdbTraverse(pSdb, type, countValid, &num, 0, 0);
  return num;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "sdb.h"
18
19	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow);
20
21	const char *sdbTableName(ESdbType type) {	7,035✔
22	switch (type) {	7,035!
23	case SDB_TRANS:	2,590✔
24	return "trans";	2,590✔
25	case SDB_CLUSTER:	245✔
26	return "cluster";	245✔
27	case SDB_MNODE:	260✔
28	return "mnode";	260✔
29	case SDB_QNODE:	32✔
30	return "qnode";	32✔
31	case SDB_SNODE:	32✔
32	return "snode";	32✔
33	case SDB_DNODE:	630✔
34	return "dnode";	630✔
35	case SDB_USER:	450✔
36	return "user";	450✔
UNCOV 37	case SDB_AUTH:	×
UNCOV 38	return "auth";	×
39	case SDB_ACCT:	152✔
40	return "acct";	152✔
UNCOV 41	case SDB_STREAM_CK:	×
UNCOV 42	return "stream_ck";	×
43	case SDB_STREAM:	33✔
44	return "stream";	33✔
UNCOV 45	case SDB_OFFSET:	×
UNCOV 46	return "offset";	×
47	case SDB_SUBSCRIBE:	32✔
48	return "subscribe";	32✔
49	case SDB_CONSUMER:	77✔
50	return "consumer";	77✔
51	case SDB_TOPIC:	32✔
52	return "topic";	32✔
53	case SDB_VGROUP:	781✔
54	return "vgroup";	781✔
55	case SDB_SMA:	32✔
56	return "sma";	32✔
57	case SDB_STB:	377✔
58	return "stb";	377✔
59	case SDB_DB:	466✔
60	return "db";	466✔
61	case SDB_FUNC:	119✔
62	return "func";	119✔
63	case SDB_IDX:	171✔
64	return "idx";	171✔
65	case SDB_VIEW:	32✔
66	return "view";	32✔
67	case SDB_STREAM_SEQ:	32✔
68	return "stream_seq";	32✔
69	case SDB_COMPACT:	32✔
70	return "compact";	32✔
71	case SDB_COMPACT_DETAIL:	32✔
72	return "compact_detail";	32✔
73	case SDB_GRANT:	114✔
74	return "grant";	114✔
75	case SDB_ARBGROUP:	32✔
76	return "arb_group";	32✔
77	case SDB_ANODE:	32✔
78	return "anode";	32✔
79	case SDB_CFG:	216✔
80	return "config";	216✔
81	default:	2✔
82	return "undefine";	2✔
83	}
84	}
85
86	const char *sdbStatusName(ESdbStatus status) {	4,413✔
87	switch (status) {	4,413!
88	case SDB_STATUS_CREATING:	98✔
89	return "creating";	98✔
90	case SDB_STATUS_DROPPING:	44✔
91	return "dropping";	44✔
92	case SDB_STATUS_READY:	3,143✔
93	return "ready";	3,143✔
94	case SDB_STATUS_DROPPED:	793✔
95	return "dropped";	793✔
96	case SDB_STATUS_INIT:	334✔
97	return "init";	334✔
UNCOV 98	case SDB_STATUS_UPDATE:	×
UNCOV 99	return "update";	×
100	default:	1✔
101	return "undefine";	1✔
102	}
103	}
104
105	void sdbPrintOper(SSdb pSdb, SSdbRow pRow, const char *oper) {	3,933✔
106	#if 1
107	EKeyType keyType = pSdb->keyTypes[pRow->type];	3,933✔
108
109	if (keyType == SDB_KEY_BINARY) {	3,933✔
110	mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,	1,082!
111	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
112	} else if (keyType == SDB_KEY_INT32) {	2,851✔
113	mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (int32_t )pRow->pObj,	2,689!
114	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
115	} else if (keyType == SDB_KEY_INT64) {	162!
116	mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),	162!
117	(int64_t )pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
118	} else {
119	}
120	#endif
121	}	3,933✔
122
123	static SHashObj sdbGetHash(SSdb pSdb, int32_t type) {	3,399✔
124	if (type >= SDB_MAX \|\| type < 0) {	3,399!
125	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	1✔
126	return NULL;	1✔
127	}
128
129	SHashObj *hash = pSdb->hashObjs[type];	3,398✔
130	if (hash == NULL) {	3,398✔
131	terrno = TSDB_CODE_APP_ERROR;	4✔
132	return NULL;	4✔
133	}
134
135	return hash;	3,394✔
136	}
137
138	static int32_t sdbGetkeySize(SSdb pSdb, ESdbType type, const void pKey) {	1,607✔
139	int32_t keySize = 0;	1,607✔
140	EKeyType keyType = pSdb->keyTypes[type];	1,607✔
141
142	if (keyType == SDB_KEY_INT32) {	1,607✔
143	keySize = sizeof(int32_t);	1,087✔
144	} else if (keyType == SDB_KEY_BINARY) {	520✔
145	keySize = strlen(pKey) + 1;	501✔
146	} else {
147	keySize = sizeof(int64_t);	19✔
148	}
149
150	return keySize;	1,607✔
151	}
152
153	static int32_t sdbInsertRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	230✔
154	int32_t type = pRow->type;	230✔
155	sdbWriteLock(pSdb, type);	230✔
156
157	SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);	230✔
158	if (pOldRow != NULL) {	230!
159	sdbUnLock(pSdb, type);	×
160	sdbFreeRow(pSdb, pRow, false);	×
161	terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;	×
162	return terrno;	×
163	}
164
165	pRow->refCount = 0;	230✔
166	pRow->status = pRaw->status;	230✔
167	sdbPrintOper(pSdb, pRow, "insert");	230✔
168
169	int32_t code = 0;	230✔
170	if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {	230!
171	sdbUnLock(pSdb, type);	×
172	sdbFreeRow(pSdb, pRow, false);	×
173	return code;	×
174	}
175
176	SdbInsertFp insertFp = pSdb->insertFps[pRow->type];	230✔
177	if (insertFp != NULL) {	230!
178	code = (*insertFp)(pSdb, pRow->pObj);	230✔
179	if (code != 0) {	230!
180	if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {	×
181	mError("failed to remove row from hash");	×
182	}
183	sdbFreeRow(pSdb, pRow, false);	×
184	sdbUnLock(pSdb, type);	×
185	terrno = code;	×
186	return terrno;	×
187	}
188	}
189
190	sdbUnLock(pSdb, type);	230✔
191
192	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {	230✔
193	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int32_t )pRow->pObj));	148✔
194	}
195	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {	230✔
196	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int64_t )pRow->pObj));	12✔
197	}
198	pSdb->tableVer[pRow->type]++;	230✔
199
200	return 0;	230✔
201	}
202
203	static int32_t sdbUpdateRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pNewRow, int32_t keySize) {	377✔
204	int32_t type = pNewRow->type;	377✔
205	sdbWriteLock(pSdb, type);	377✔
206
207	SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);	377✔
208	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	377!
209	sdbUnLock(pSdb, type);	196✔
210	return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);	196✔
211	}
212
213	SSdbRow pOldRow = ppOldRow;	181✔
214	pOldRow->status = pRaw->status;	181✔
215	sdbPrintOper(pSdb, pOldRow, "update");	181✔
216
217	int32_t code = 0;	181✔
218	SdbUpdateFp updateFp = pSdb->updateFps[type];	181✔
219	if (updateFp != NULL) {	181!
220	code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);	181✔
221	}
222	sdbUnLock(pSdb, type);	181✔
223
224	// sdbUnLock(pSdb, type);
225	sdbFreeRow(pSdb, pNewRow, false);	181✔
226
227	pSdb->tableVer[pOldRow->type]++;	181✔
228	return code;	181✔
229	}
230
231	static int32_t sdbDeleteRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	153✔
232	int32_t type = pRow->type;	153✔
233	sdbWriteLock(pSdb, type);	153✔
234
235	SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);	153✔
236	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	153!
UNCOV 237	sdbUnLock(pSdb, type);	×
UNCOV 238	sdbFreeRow(pSdb, pRow, false);	×
UNCOV 239	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	×
UNCOV 240	return terrno;	×
241	}
242	SSdbRow pOldRow = ppOldRow;	153✔
243	pOldRow->status = pRaw->status;	153✔
244
245	(void)atomic_add_fetch_32(&pOldRow->refCount, 1);	153✔
246	sdbPrintOper(pSdb, pOldRow, "delete");	153✔
247
248	if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {	153!
249	sdbUnLock(pSdb, type);	×
250	sdbFreeRow(pSdb, pRow, false);	×
251	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	×
252	return terrno;	×
253	}
254	pSdb->tableVer[pOldRow->type]++;	153✔
255	sdbUnLock(pSdb, type);	153✔
256
257	sdbFreeRow(pSdb, pRow, false);	153✔
258
259	sdbCheckRow(pSdb, pOldRow);	153✔
260	return 0;	153✔
261	}
262
263	int32_t sdbWriteWithoutFree(SSdb pSdb, SSdbRaw pRaw) {	566✔
264	if (pRaw->type == SDB_CFG) {	566✔
265	mTrace("sdb write cfg");	8!
266	}
267	SHashObj *hash = sdbGetHash(pSdb, pRaw->type);	566✔
268	if (hash == NULL) return terrno;	566✔
269
270	SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];	564✔
271	SSdbRow pRow = (decodeFp)(pRaw);	564✔
272	if (pRow == NULL) return terrno;	564!
273
274	pRow->type = pRaw->type;	564✔
275
276	int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);	564✔
277	int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;	564✔
278
279	switch (pRaw->status) {	564!
280	case SDB_STATUS_CREATING:	34✔
281	code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);	34✔
282	break;	34✔
283	case SDB_STATUS_READY:	377✔
284	case SDB_STATUS_UPDATE:
285	case SDB_STATUS_DROPPING:
286	code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);	377✔
287	break;	377✔
288	case SDB_STATUS_DROPPED:	153✔
289	code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);	153✔
290	break;	153✔
291	}
292
293	return code;	564✔
294	}
295
296	int32_t sdbWrite(SSdb pSdb, SSdbRaw pRaw) {	121✔
297	int32_t code = sdbWriteWithoutFree(pSdb, pRaw);	121✔
298	sdbFreeRaw(pRaw);	121✔
299	return code;	121✔
300	}
301
302	void sdbAcquireAll(SSdb pSdb, ESdbType type, const void *pKey, bool onlyReady) {	1,044✔
303	terrno = 0;	1,044✔
304
305	SHashObj *hash = sdbGetHash(pSdb, type);	1,044✔
306	if (hash == NULL) return NULL;	1,044✔
307
308	void *pRet = NULL;	1,043✔
309	int32_t keySize = sdbGetkeySize(pSdb, type, pKey);	1,043✔
310
311	sdbReadLock(pSdb, type);	1,043✔
312
313	SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);	1,043✔
314	if (ppRow == NULL \|\| *ppRow == NULL) {	1,043!
315	sdbUnLock(pSdb, type);	94✔
316	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	94✔
317	return NULL;	94✔
318	}
319
320	SSdbRow pRow = ppRow;	949✔
321	switch (pRow->status) {	949!
322	case SDB_STATUS_READY:	942✔
323	(void)atomic_add_fetch_32(&pRow->refCount, 1);	942✔
324	pRet = pRow->pObj;	942✔
325	sdbPrintOper(pSdb, pRow, "acquire");	942✔
326	break;	942✔
327	case SDB_STATUS_CREATING:	1✔
328	terrno = TSDB_CODE_SDB_OBJ_CREATING;	1✔
329	break;	1✔
330	case SDB_STATUS_DROPPING:	6✔
331	terrno = TSDB_CODE_SDB_OBJ_DROPPING;	6✔
332	break;	6✔
UNCOV 333	default:	×
UNCOV 334	terrno = TSDB_CODE_APP_ERROR;	×
UNCOV 335	break;	×
336	}
337
338	if (pRet == NULL) {	949✔
339	if (!onlyReady) {	7!
340	terrno = 0;	×
341	(void)atomic_add_fetch_32(&pRow->refCount, 1);	×
342	pRet = pRow->pObj;	×
343	sdbPrintOper(pSdb, pRow, "acquire");	×
344	}
345	}
346
347	sdbUnLock(pSdb, type);	949✔
348	return pRet;	949✔
349	}
350
351	void sdbAcquire(SSdb pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }	1,036✔
352	void sdbAcquireNotReadyObj(SSdb pSdb, ESdbType type, const void *pKey) {	8✔
353	return sdbAcquireAll(pSdb, type, pKey, false);	8✔
354	}
355
356	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow) {	153✔
357	int32_t type = pRow->type;	153✔
358	sdbWriteLock(pSdb, type);	153✔
359
360	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	153✔
361	sdbPrintOper(pSdb, pRow, "check");	153✔
362	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	153!
363	sdbFreeRow(pSdb, pRow, true);	45✔
364	}
365
366	sdbUnLock(pSdb, type);	153✔
367	}	153✔
368
369	void sdbReleaseLock(SSdb pSdb, void pObj, bool lock) {	1,328✔
370	if (pObj == NULL) return;	1,328✔
371
372	SSdbRow pRow = (SSdbRow )((char *)pObj - sizeof(SSdbRow));	1,275✔
373	if (pRow->type >= SDB_MAX) return;	1,275✔
374
375	int32_t type = pRow->type;	1,274✔
376	if (lock) {	1,274✔
377	sdbWriteLock(pSdb, type);	1,266✔
378	}
379
380	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	1,274✔
381	sdbPrintOper(pSdb, pRow, "release");	1,274✔
382	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	1,274✔
383	sdbFreeRow(pSdb, pRow, true);	108✔
384	}
385
386	if (lock) {	1,274✔
387	sdbUnLock(pSdb, type);	1,266✔
388	}
389	}
390
391	void sdbRelease(SSdb pSdb, void pObj) { sdbReleaseLock(pSdb, pObj, true); }	1,320✔
392
393	void sdbFetch(SSdb pSdb, ESdbType type, void pIter, void *ppObj) {	811✔
394	*ppObj = NULL;	811✔
395
396	SHashObj *hash = sdbGetHash(pSdb, type);	811✔
397	if (hash == NULL) return NULL;	811✔
398
399	sdbReadLock(pSdb, type);	810✔
400
401	SSdbRow **ppRow = taosHashIterate(hash, pIter);	810✔
402	while (ppRow != NULL) {	817✔
403	SSdbRow pRow = ppRow;	298✔
404	if (pRow == NULL \|\| pRow->status != SDB_STATUS_READY) {	298!
405	ppRow = taosHashIterate(hash, ppRow);	7✔
406	continue;	7✔
407	}
408
409	(void)atomic_add_fetch_32(&pRow->refCount, 1);	291✔
410	sdbPrintOper(pSdb, pRow, "fetch");	291✔
411	*ppObj = pRow->pObj;	291✔
412	break;	291✔
413	}
414	sdbUnLock(pSdb, type);	810✔
415
416	return ppRow;	810✔
417	}
418
419	void sdbFetchAll(SSdb pSdb, ESdbType type, void pIter, void ppObj, ESdbStatus status, bool lock) {	58✔
420	*ppObj = NULL;	58✔
421
422	SHashObj *hash = sdbGetHash(pSdb, type);	58✔
423	if (hash == NULL) return NULL;	58!
424
425	if (lock) {	58✔
426	sdbReadLock(pSdb, type);	42✔
427	}
428
429	SSdbRow **ppRow = taosHashIterate(hash, pIter);	58✔
430	while (ppRow != NULL) {	58✔
431	SSdbRow pRow = ppRow;	29✔
432	if (pRow == NULL) {	29!
433	ppRow = taosHashIterate(hash, ppRow);	×
434	continue;	×
435	}
436
437	(void)atomic_add_fetch_32(&pRow->refCount, 1);	29✔
438	sdbPrintOper(pSdb, pRow, "fetch");	29✔
439	*ppObj = pRow->pObj;	29✔
440	*status = pRow->status;	29✔
441	break;	29✔
442	}
443	if (lock) {	58✔
444	sdbUnLock(pSdb, type);	42✔
445	}
446
447	return ppRow;	58✔
448	}
449
450	void sdbCancelFetch(SSdb pSdb, void pIter) {	67✔
451	if (pIter == NULL) return;	67✔
452	SSdbRow pRow = (SSdbRow **)pIter;	65✔
453	mTrace("cancel fetch row:%p", pRow);	65!
454	SHashObj *hash = sdbGetHash(pSdb, pRow->type);	65✔
455	if (hash == NULL) return;	65!
456
457	int32_t type = pRow->type;	65✔
458	sdbReadLock(pSdb, type);	65✔
459	taosHashCancelIterate(hash, pIter);	65✔
460	sdbUnLock(pSdb, type);	65✔
461	}
462
463	void sdbCancelFetchByType(SSdb pSdb, void pIter, ESdbType type) {	×
464	if (pIter == NULL) return;	×
465	if (type >= SDB_MAX \|\| type < 0) return;	×
466	SHashObj *hash = sdbGetHash(pSdb, type);	×
467	if (hash == NULL) return;	×
468
469	sdbReadLock(pSdb, type);	×
470	taosHashCancelIterate(hash, pIter);	×
471	sdbUnLock(pSdb, type);	×
472	}
473
474	void sdbTraverse(SSdb pSdb, ESdbType type, sdbTraverseFp fp, void p1, void p2, void p3) {	46✔
475	SHashObj *hash = sdbGetHash(pSdb, type);	46✔
476	if (hash == NULL) return;	46!
477
478	sdbReadLock(pSdb, type);	46✔
479
480	SSdbRow **ppRow = taosHashIterate(hash, NULL);	46✔
481	while (ppRow != NULL) {	74✔
482	SSdbRow pRow = ppRow;	30✔
483	if (pRow->status == SDB_STATUS_READY) {	30!
484	bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);	30✔
485	if (!isContinue) {	30✔
486	taosHashCancelIterate(hash, ppRow);	2✔
487	break;	2✔
488	}
489	}
490
491	ppRow = taosHashIterate(hash, ppRow);	28✔
492	}
493
494	sdbUnLock(pSdb, type);	46✔
495	}
496
497	int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {	661✔
498	SHashObj *hash = sdbGetHash(pSdb, type);	661✔
499	if (hash == NULL) return 0;	661!
500
501	sdbReadLock(pSdb, type);	661✔
502	int32_t size = taosHashGetSize(hash);	661✔
503	sdbUnLock(pSdb, type);	661✔
504
505	return size;	661✔
506	}
507
508	int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {	148✔
509	SHashObj *hash = sdbGetHash(pSdb, type);	148✔
510	if (hash == NULL) return -1;	148✔
511
512	if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;	147✔
513
514	int32_t maxId = 0;	141✔
515	sdbReadLock(pSdb, type);	141✔
516
517	SSdbRow **ppRow = taosHashIterate(hash, NULL);	141✔
518	while (ppRow != NULL) {	146✔
519	SSdbRow pRow = ppRow;	5✔
520	int32_t id = (int32_t )pRow->pObj;	5✔
521	maxId = TMAX(id, maxId);	5✔
522	ppRow = taosHashIterate(hash, ppRow);	5✔
523	}
524
525	sdbUnLock(pSdb, type);	141✔
526	maxId = TMAX(maxId, pSdb->maxId[type]);	141✔
527	return maxId + 1;	141✔
528	}
529
530	int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {	77✔
531	if (type >= SDB_MAX \|\| type < 0) {	77✔
532	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	1✔
533	return -1;	1✔
534	}
535
536	return pSdb->tableVer[type];	76✔
537	}
538
539	bool countValid(SMnode pMnode, void pObj, void p1, void p2, void *p3) {	×
540	int32_t *pInt = p1;	×
541	(*pInt) += 1;	×
542	return true;	×
543	}
544
545	int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {	×
546	int32_t num = 0;	×
547	sdbTraverse(pSdb, type, countValid, &num, 0, 0);	×
548	return num;	×
549	}

taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous