#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

38.46

/source/dnode/mnode/impl/src/mndIndexCom.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "mndIndex.h"
#include "mndIndexComm.h"
#include "mndSma.h"

static void *mndGetIdx(SMnode *pMnode, char *name, int type) {
  SSdb *pSdb = pMnode->pSdb;
  void *pIdx = sdbAcquire(pSdb, type, name);
  if (pIdx == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
    terrno = 0;
  }
  return pIdx;
}

int mndAcquireGlobalIdx(SMnode *pMnode, char *name, int type, SSIdx *idx) {
  SSmaObj *pSma = mndGetIdx(pMnode, name, SDB_SMA);
  SIdxObj *pIdx = mndGetIdx(pMnode, name, SDB_IDX);

  int32_t code = 0;

  if (pSma == NULL && pIdx == NULL) return 0;

  if (pSma != NULL) {
    if (type == SDB_SMA) {
      idx->type = SDB_SMA;
      idx->pIdx = pSma;
    } else {
      mndReleaseSma(pMnode, pSma);
      code = TSDB_CODE_MND_SMA_ALREADY_EXIST;
      TAOS_RETURN(code);
    }
  } else {
    if (type == SDB_IDX) {
      idx->type = SDB_IDX;
      idx->pIdx = pIdx;
    } else {
      mndReleaseIdx(pMnode, pIdx);
      code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
      TAOS_RETURN(code);
    }
  }
  TAOS_RETURN(code);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "mndIndex.h"
17	#include "mndIndexComm.h"
18	#include "mndSma.h"
19
20	static void mndGetIdx(SMnode pMnode, char *name, int type) {	18✔
21	SSdb *pSdb = pMnode->pSdb;	18✔
22	void *pIdx = sdbAcquire(pSdb, type, name);	18✔
23	if (pIdx == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {	18!
24	terrno = 0;	18✔
25	}
26	return pIdx;	18✔
27	}
28
29	int mndAcquireGlobalIdx(SMnode pMnode, char name, int type, SSIdx *idx) {	9✔
30	SSmaObj *pSma = mndGetIdx(pMnode, name, SDB_SMA);	9✔
31	SIdxObj *pIdx = mndGetIdx(pMnode, name, SDB_IDX);	9✔
32
33	int32_t code = 0;	9✔
34
35	if (pSma == NULL && pIdx == NULL) return 0;	9!
36
UNCOV 37	if (pSma != NULL) {	×
UNCOV 38	if (type == SDB_SMA) {	×
UNCOV 39	idx->type = SDB_SMA;	×
UNCOV 40	idx->pIdx = pSma;	×
41	} else {
UNCOV 42	mndReleaseSma(pMnode, pSma);	×
UNCOV 43	code = TSDB_CODE_MND_SMA_ALREADY_EXIST;	×
UNCOV 44	TAOS_RETURN(code);	×
45	}
46	} else {
UNCOV 47	if (type == SDB_IDX) {	×
UNCOV 48	idx->type = SDB_IDX;	×
UNCOV 49	idx->pIdx = pIdx;	×
50	} else {
UNCOV 51	mndReleaseIdx(pMnode, pIdx);	×
UNCOV 52	code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;	×
UNCOV 53	TAOS_RETURN(code);	×
54	}
55	}
UNCOV 56	TAOS_RETURN(code);	×
57	}

taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous