#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

14.46

/source/dnode/mgmt/mgmt_snode/src/smInt.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http:www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "smInt.h"
#include "libs/function/function.h"
#include "libs/function/tudf.h"

#ifdef USE_STREAM

static int32_t smRequire(const SMgmtInputOpt *pInput, bool *required) {
  return dmReadFile(pInput->path, pInput->name, required);
}

static void smInitOption(SSnodeMgmt *pMgmt, SSnodeOpt *pOption) { pOption->msgCb = pMgmt->msgCb; }

static void smClose(SSnodeMgmt *pMgmt) {
  if (pMgmt->pSnode != NULL) {
    smStopWorker(pMgmt);
    sndClose(pMgmt->pSnode);
    pMgmt->pSnode = NULL;
  }

  taosMemoryFree(pMgmt);
}
int32_t sndOpenWrapper(const char *path, SSnodeOpt *pOption, SSnode **pNode) {
  *pNode = sndOpen(path, pOption);
  if (*pNode == NULL) {
    return terrno;
  }
  return 0;
}
int32_t smOpen(SMgmtInputOpt *pInput, SMgmtOutputOpt *pOutput) {
  int32_t     code = 0;
  SSnodeMgmt *pMgmt = taosMemoryCalloc(1, sizeof(SSnodeMgmt));
  if (pMgmt == NULL) {
    code = terrno;
    return code;
  }

  pMgmt->pData = pInput->pData;
  pMgmt->path = pInput->path;
  pMgmt->name = pInput->name;
  pMgmt->msgCb = pInput->msgCb;
  pMgmt->msgCb.mgmt = pMgmt;
  pMgmt->msgCb.putToQueueFp = (PutToQueueFp)smPutMsgToQueue;

  SSnodeOpt option = {0};
  smInitOption(pMgmt, &option);

  code = sndOpenWrapper(pMgmt->path, &option, &pMgmt->pSnode);
  if (code != 0) {
    dError("failed to open snode since %s", tstrerror(code));
    smClose(pMgmt);
    return code;
  }

  tmsgReportStartup("snode-impl", "initialized");

  if ((code = smStartWorker(pMgmt)) != 0) {
    dError("failed to start snode worker since %s", tstrerror(code));
    smClose(pMgmt);
    return code;
  }
  tmsgReportStartup("snode-worker", "initialized");

  if ((code = udfcOpen()) != 0) {
    dError("failed to open udfc in snode since:%s", tstrerror(code));
    smClose(pMgmt);
    return code;
  }

  pOutput->pMgmt = pMgmt;
  return 0;
}

static int32_t smStartSnodes(SSnodeMgmt *pMgmt) { return sndInit(pMgmt->pSnode); }

SMgmtFunc smGetMgmtFunc() {
  SMgmtFunc mgmtFunc = {0};
  mgmtFunc.openFp = smOpen;
  mgmtFunc.startFp = (NodeStartFp)smStartSnodes;
  mgmtFunc.closeFp = (NodeCloseFp)smClose;
  mgmtFunc.createFp = (NodeCreateFp)smProcessCreateReq;
  mgmtFunc.dropFp = (NodeDropFp)smProcessDropReq;
  mgmtFunc.requiredFp = smRequire;
  mgmtFunc.getHandlesFp = smGetMsgHandles;

  return mgmtFunc;
}
#endif

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http:www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "smInt.h"
18	#include "libs/function/function.h"
19	#include "libs/function/tudf.h"
20
21	#ifdef USE_STREAM
22
23	static int32_t smRequire(const SMgmtInputOpt pInput, bool required) {	8✔
24	return dmReadFile(pInput->path, pInput->name, required);	8✔
25	}
26
UNCOV 27	static void smInitOption(SSnodeMgmt pMgmt, SSnodeOpt pOption) { pOption->msgCb = pMgmt->msgCb; }	×
28
UNCOV 29	static void smClose(SSnodeMgmt *pMgmt) {	×
UNCOV 30	if (pMgmt->pSnode != NULL) {	×
UNCOV 31	smStopWorker(pMgmt);	×
UNCOV 32	sndClose(pMgmt->pSnode);	×
UNCOV 33	pMgmt->pSnode = NULL;	×
34	}
35
UNCOV 36	taosMemoryFree(pMgmt);	×
UNCOV 37	}	×
UNCOV 38	int32_t sndOpenWrapper(const char path, SSnodeOpt pOption, SSnode **pNode) {	×
39	*pNode = sndOpen(path, pOption);	×
UNCOV 40	if (*pNode == NULL) {	×
UNCOV 41	return terrno;	×
42	}
UNCOV 43	return 0;	×
44	}
UNCOV 45	int32_t smOpen(SMgmtInputOpt pInput, SMgmtOutputOpt pOutput) {	×
UNCOV 46	int32_t code = 0;	×
47	SSnodeMgmt *pMgmt = taosMemoryCalloc(1, sizeof(SSnodeMgmt));	×
48	if (pMgmt == NULL) {	×
UNCOV 49	code = terrno;	×
UNCOV 50	return code;	×
51	}
52
UNCOV 53	pMgmt->pData = pInput->pData;	×
UNCOV 54	pMgmt->path = pInput->path;	×
UNCOV 55	pMgmt->name = pInput->name;	×
UNCOV 56	pMgmt->msgCb = pInput->msgCb;	×
UNCOV 57	pMgmt->msgCb.mgmt = pMgmt;	×
UNCOV 58	pMgmt->msgCb.putToQueueFp = (PutToQueueFp)smPutMsgToQueue;	×
59
UNCOV 60	SSnodeOpt option = {0};	×
UNCOV 61	smInitOption(pMgmt, &option);	×
62
63	code = sndOpenWrapper(pMgmt->path, &option, &pMgmt->pSnode);	×
64	if (code != 0) {	×
65	dError("failed to open snode since %s", tstrerror(code));	×
UNCOV 66	smClose(pMgmt);	×
UNCOV 67	return code;	×
68	}
69
UNCOV 70	tmsgReportStartup("snode-impl", "initialized");	×
71
72	if ((code = smStartWorker(pMgmt)) != 0) {	×
73	dError("failed to start snode worker since %s", tstrerror(code));	×
UNCOV 74	smClose(pMgmt);	×
UNCOV 75	return code;	×
76	}
UNCOV 77	tmsgReportStartup("snode-worker", "initialized");	×
78
79	if ((code = udfcOpen()) != 0) {	×
80	dError("failed to open udfc in snode since:%s", tstrerror(code));	×
UNCOV 81	smClose(pMgmt);	×
UNCOV 82	return code;	×
83	}
84
UNCOV 85	pOutput->pMgmt = pMgmt;	×
UNCOV 86	return 0;	×
87	}
88
UNCOV 89	static int32_t smStartSnodes(SSnodeMgmt *pMgmt) { return sndInit(pMgmt->pSnode); }	×
90
91	SMgmtFunc smGetMgmtFunc() {	8✔
92	SMgmtFunc mgmtFunc = {0};	8✔
93	mgmtFunc.openFp = smOpen;	8✔
94	mgmtFunc.startFp = (NodeStartFp)smStartSnodes;	8✔
95	mgmtFunc.closeFp = (NodeCloseFp)smClose;	8✔
96	mgmtFunc.createFp = (NodeCreateFp)smProcessCreateReq;	8✔
97	mgmtFunc.dropFp = (NodeDropFp)smProcessDropReq;	8✔
98	mgmtFunc.requiredFp = smRequire;	8✔
99	mgmtFunc.getHandlesFp = smGetMsgHandles;	8✔
100
101	return mgmtFunc;	8✔
102	}
103	#endif

taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous