#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.87

/source/dnode/mgmt/mgmt_qnode/src/qmHandle.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http:www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "qmInt.h"

void qmGetMonitorInfo(SQnodeMgmt *pMgmt, SMonQmInfo *qmInfo) {
  SQnodeLoad qload = {0};
  (void)qndGetLoad(pMgmt->pQnode, &qload);

  qload.dnodeId = pMgmt->pData->dnodeId;
}

void qmGetQnodeLoads(SQnodeMgmt *pMgmt, SQnodeLoad *pInfo) {
  (void)qndGetLoad(pMgmt->pQnode, pInfo);

  pInfo->dnodeId = pMgmt->pData->dnodeId;
}

int32_t qmProcessCreateReq(const SMgmtInputOpt *pInput, SRpcMsg *pMsg) {
  int32_t          code = 0;
  SDCreateQnodeReq createReq = {0};
  if (tDeserializeSCreateDropMQSNodeReq(pMsg->pCont, pMsg->contLen, &createReq) != 0) {
    code = TSDB_CODE_INVALID_MSG;
    return code;
  }

  if (pInput->pData->dnodeId != 0 && createReq.dnodeId != pInput->pData->dnodeId) {
    code = TSDB_CODE_INVALID_OPTION;
    dError("failed to create qnode since %s", tstrerror(code));
    tFreeSMCreateQnodeReq(&createReq);
    return code;
  }

  bool deployed = true;
  if ((code = dmWriteFile(pInput->path, pInput->name, deployed)) != 0) {
    dError("failed to write qnode file since %s", tstrerror(code));
    tFreeSMCreateQnodeReq(&createReq);
    return code;
  }

  tFreeSMCreateQnodeReq(&createReq);
  return 0;
}

int32_t qmProcessDropReq(const SMgmtInputOpt *pInput, SRpcMsg *pMsg) {
  int32_t        code = 0;
  SDDropQnodeReq dropReq = {0};
  if (tDeserializeSCreateDropMQSNodeReq(pMsg->pCont, pMsg->contLen, &dropReq) != 0) {
    code = TSDB_CODE_INVALID_MSG;
    return code;
  }

  if (pInput->pData->dnodeId != 0 && dropReq.dnodeId != pInput->pData->dnodeId) {
    code = TSDB_CODE_INVALID_OPTION;
    dError("failed to drop qnode since %s", tstrerror(code));
    tFreeSMCreateQnodeReq(&dropReq);
    return code;
  }

  bool deployed = false;
  if ((code = dmWriteFile(pInput->path, pInput->name, deployed)) != 0) {
    dError("failed to write qnode file since %s", tstrerror(code));
    tFreeSMCreateQnodeReq(&dropReq);
    return code;
  }

  tFreeSMCreateQnodeReq(&dropReq);
  return 0;
}

SArray *qmGetMsgHandles() {
  int32_t code = -1;
  SArray *pArray = taosArrayInit(16, sizeof(SMgmtHandle));
  if (pArray == NULL) goto _OVER;

  // Requests handled by VNODE
  if (dmSetMgmtHandle(pArray, TDMT_SCH_QUERY, qmPutNodeMsgToQueryQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_MERGE_QUERY, qmPutNodeMsgToQueryQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_QUERY_CONTINUE, qmPutNodeMsgToQueryQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_FETCH, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_MERGE_FETCH, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_FETCH_RSP, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_QUERY_HEARTBEAT, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;

  if (dmSetMgmtHandle(pArray, TDMT_SCH_CANCEL_TASK, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_DROP_TASK, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;
  if (dmSetMgmtHandle(pArray, TDMT_SCH_TASK_NOTIFY, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;

  code = 0;
_OVER:
  if (code != 0) {
    taosArrayDestroy(pArray);
    return NULL;
  } else {
    return pArray;
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http:www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "qmInt.h"
18
UNCOV 19	void qmGetMonitorInfo(SQnodeMgmt pMgmt, SMonQmInfo qmInfo) {	×
UNCOV 20	SQnodeLoad qload = {0};	×
UNCOV 21	(void)qndGetLoad(pMgmt->pQnode, &qload);	×
22
UNCOV 23	qload.dnodeId = pMgmt->pData->dnodeId;	×
UNCOV 24	}	×
25
UNCOV 26	void qmGetQnodeLoads(SQnodeMgmt pMgmt, SQnodeLoad pInfo) {	×
UNCOV 27	(void)qndGetLoad(pMgmt->pQnode, pInfo);	×
28
UNCOV 29	pInfo->dnodeId = pMgmt->pData->dnodeId;	×
UNCOV 30	}	×
31
32	int32_t qmProcessCreateReq(const SMgmtInputOpt pInput, SRpcMsg pMsg) {	3✔
33	int32_t code = 0;	3✔
34	SDCreateQnodeReq createReq = {0};	3✔
35	if (tDeserializeSCreateDropMQSNodeReq(pMsg->pCont, pMsg->contLen, &createReq) != 0) {	3!
36	code = TSDB_CODE_INVALID_MSG;	×
37	return code;	×
38	}
39
40	if (pInput->pData->dnodeId != 0 && createReq.dnodeId != pInput->pData->dnodeId) {	3!
41	code = TSDB_CODE_INVALID_OPTION;	1✔
42	dError("failed to create qnode since %s", tstrerror(code));	1!
43	tFreeSMCreateQnodeReq(&createReq);	1✔
44	return code;	1✔
45	}
46
47	bool deployed = true;	2✔
48	if ((code = dmWriteFile(pInput->path, pInput->name, deployed)) != 0) {	2!
49	dError("failed to write qnode file since %s", tstrerror(code));	×
50	tFreeSMCreateQnodeReq(&createReq);	×
51	return code;	×
52	}
53
54	tFreeSMCreateQnodeReq(&createReq);	2✔
55	return 0;	2✔
56	}
57
58	int32_t qmProcessDropReq(const SMgmtInputOpt pInput, SRpcMsg pMsg) {	1✔
59	int32_t code = 0;	1✔
60	SDDropQnodeReq dropReq = {0};	1✔
61	if (tDeserializeSCreateDropMQSNodeReq(pMsg->pCont, pMsg->contLen, &dropReq) != 0) {	1!
62	code = TSDB_CODE_INVALID_MSG;	×
63	return code;	×
64	}
65
66	if (pInput->pData->dnodeId != 0 && dropReq.dnodeId != pInput->pData->dnodeId) {	1!
67	code = TSDB_CODE_INVALID_OPTION;	×
68	dError("failed to drop qnode since %s", tstrerror(code));	×
69	tFreeSMCreateQnodeReq(&dropReq);	×
70	return code;	×
71	}
72
73	bool deployed = false;	1✔
74	if ((code = dmWriteFile(pInput->path, pInput->name, deployed)) != 0) {	1!
75	dError("failed to write qnode file since %s", tstrerror(code));	×
76	tFreeSMCreateQnodeReq(&dropReq);	×
77	return code;	×
78	}
79
80	tFreeSMCreateQnodeReq(&dropReq);	1✔
81	return 0;	1✔
82	}
83
84	SArray *qmGetMsgHandles() {	8✔
85	int32_t code = -1;	8✔
86	SArray *pArray = taosArrayInit(16, sizeof(SMgmtHandle));	8✔
87	if (pArray == NULL) goto _OVER;	8!
88
89	// Requests handled by VNODE
90	if (dmSetMgmtHandle(pArray, TDMT_SCH_QUERY, qmPutNodeMsgToQueryQueue, 1) == NULL) goto _OVER;	8!
91	if (dmSetMgmtHandle(pArray, TDMT_SCH_MERGE_QUERY, qmPutNodeMsgToQueryQueue, 1) == NULL) goto _OVER;	8!
92	if (dmSetMgmtHandle(pArray, TDMT_SCH_QUERY_CONTINUE, qmPutNodeMsgToQueryQueue, 1) == NULL) goto _OVER;	8!
93	if (dmSetMgmtHandle(pArray, TDMT_SCH_FETCH, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
94	if (dmSetMgmtHandle(pArray, TDMT_SCH_MERGE_FETCH, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
95	if (dmSetMgmtHandle(pArray, TDMT_SCH_FETCH_RSP, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
96	if (dmSetMgmtHandle(pArray, TDMT_SCH_QUERY_HEARTBEAT, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
97
98	if (dmSetMgmtHandle(pArray, TDMT_SCH_CANCEL_TASK, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
99	if (dmSetMgmtHandle(pArray, TDMT_SCH_DROP_TASK, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
100	if (dmSetMgmtHandle(pArray, TDMT_SCH_TASK_NOTIFY, qmPutNodeMsgToFetchQueue, 1) == NULL) goto _OVER;	8!
101
102	code = 0;	8✔
103	_OVER:	8✔
104	if (code != 0) {	8!
105	taosArrayDestroy(pArray);	×
106	return NULL;	×
107	} else {
108	return pArray;	8✔
109	}
110	}

taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous