• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3653

14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%
#3653

push

travis-ci

web-flow
feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

53.52
/source/client/src/clientSmlLine.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include <ctype.h>
17
#include <stdio.h>
18
#include <stdlib.h>
19
#include <string.h>
20

21
#include "clientSml.h"
22

23
#define IS_COMMA(sql,escapeChar) (*(sql) == COMMA && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
24
#define IS_SPACE(sql,escapeChar) (*(sql) == SPACE && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
25
#define IS_EQUAL(sql,escapeChar) (*(sql) == EQUAL && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
26

27
#define IS_SLASH_LETTER_IN_FIELD_VALUE(sql) (*((sql)-1) == SLASH && (*(sql) == QUOTE || *(sql) == SLASH))
28

29
#define IS_SLASH_LETTER_IN_TAG_FIELD_KEY(sql) \
30
  (*((sql)-1) == SLASH && (*(sql) == COMMA || *(sql) == SPACE || *(sql) == EQUAL || *(sql) == SLASH))
31

32
#define PROCESS_SLASH_IN_FIELD_VALUE(key, keyLen)  \
33
  for (int i = 1; i < keyLen; ++i) {               \
34
    if (IS_SLASH_LETTER_IN_FIELD_VALUE(key + i)) { \
35
      MOVE_FORWARD_ONE(key + i, keyLen - i);       \
36
      keyLen--;                                    \
37
    }                                              \
38
  }
39

40
#define PROCESS_SLASH_IN_TAG_FIELD_KEY(key, keyLen)  \
41
  for (int i = 1; i < keyLen; ++i) {                 \
42
    if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(key + i)) { \
43
      MOVE_FORWARD_ONE(key + i, keyLen - i);         \
44
      keyLen--;                                      \
45
    }                                                \
46
  }
47

48
#define BINARY_ADD_LEN (sizeof("\"\"")-1)    // "binary"   2 means length of ("")
49
#define NCHAR_ADD_LEN  (sizeof("L\"\"")-1)   // L"nchar"   3 means length of (L"")
50

51
uint8_t smlPrecisionConvert[] = {TSDB_TIME_PRECISION_NANO,    TSDB_TIME_PRECISION_HOURS, TSDB_TIME_PRECISION_MINUTES,
52
                                  TSDB_TIME_PRECISION_SECONDS, TSDB_TIME_PRECISION_MILLI, TSDB_TIME_PRECISION_MICRO,
53
                                  TSDB_TIME_PRECISION_NANO};
54

55
static int64_t smlParseInfluxTime(SSmlHandle *info, const char *data, int32_t len) {
5✔
56
  uint8_t toPrecision = info->currSTableMeta ? info->currSTableMeta->tableInfo.precision : TSDB_TIME_PRECISION_NANO;
5!
57

58
  if (unlikely(len == 0 || (len == 1 && data[0] == '0'))) {
5!
59
    return taosGetTimestampNs() / smlFactorNS[toPrecision];
1✔
60
  }
61

62
  uint8_t fromPrecision = smlPrecisionConvert[info->precision];
4✔
63

64
  int64_t ts = smlGetTimeValue(data, len, fromPrecision, toPrecision);
4✔
65
  if (unlikely(ts == -1)) {
4!
66
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid timestamp", data);
×
67
    return TSDB_CODE_SML_INVALID_DATA;
×
68
  }
69
  return ts;
4✔
70
}
71

72
int32_t smlParseValue(SSmlKv *pVal, SSmlMsgBuf *msg) {
100✔
73
  if (pVal->value[0] == '"') {  // binary
100✔
74
    if (pVal->length >= 2 && pVal->value[pVal->length - 1] == '"') {
7!
75
      pVal->type = TSDB_DATA_TYPE_BINARY;
6✔
76
      pVal->length -= BINARY_ADD_LEN;
6✔
77
      if (pVal->length > TSDB_MAX_BINARY_LEN - VARSTR_HEADER_SIZE) {
6!
78
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
79
      }
80
      pVal->value += (BINARY_ADD_LEN - 1);
6✔
81
      return TSDB_CODE_SUCCESS;
6✔
82
    }
83
    return TSDB_CODE_TSC_INVALID_VALUE;
1✔
84
  }
85

86
  if (pVal->value[0] == 'l' || pVal->value[0] == 'L') {  // nchar
93✔
87
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
2!
88
      pVal->type = TSDB_DATA_TYPE_NCHAR;
2✔
89
      pVal->length -= NCHAR_ADD_LEN;
2✔
90
      if (pVal->length > (TSDB_MAX_NCHAR_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE) {
2!
91
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
92
      }
93
      pVal->value += (NCHAR_ADD_LEN - 1);
2✔
94
      return TSDB_CODE_SUCCESS;
2✔
95
    }
96
    return TSDB_CODE_TSC_INVALID_VALUE;
×
97
  }
98

99
  if (pVal->value[0] == 'g' || pVal->value[0] == 'G') {  // geometry
91!
100
#ifdef USE_GEOS
UNCOV
101
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
×
UNCOV
102
      int32_t code = initCtxGeomFromText();
×
103
      if (code != TSDB_CODE_SUCCESS) {
×
UNCOV
104
        return code;
×
105
      }
UNCOV
106
      char *tmp = taosMemoryCalloc(pVal->length, 1);
×
107
      if (tmp == NULL) {
×
UNCOV
108
        return terrno;
×
109
      }
UNCOV
110
      (void)memcpy(tmp, pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN);
×
UNCOV
111
      code = doGeomFromText(tmp, (unsigned char **)&pVal->value, &pVal->length);
×
UNCOV
112
      taosMemoryFree(tmp);
×
UNCOV
113
      if (code != TSDB_CODE_SUCCESS) {
×
UNCOV
114
        return code;
×
115
      }
116

UNCOV
117
      pVal->type = TSDB_DATA_TYPE_GEOMETRY;
×
118
      if (pVal->length > TSDB_MAX_BINARY_LEN - VARSTR_HEADER_SIZE) {
×
119
        geosFreeBuffer((void *)(pVal->value));
×
UNCOV
120
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
121
      }
UNCOV
122
      return TSDB_CODE_SUCCESS;
×
123
    }
UNCOV
124
    return TSDB_CODE_TSC_INVALID_VALUE;
×
125
#else
126
    return TSDB_CODE_OPS_NOT_SUPPORT;
127
#endif
128
  }
129

130
  if (pVal->value[0] == 'b' || pVal->value[0] == 'B') {  // varbinary
91!
131
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
×
UNCOV
132
      pVal->type = TSDB_DATA_TYPE_VARBINARY;
×
UNCOV
133
      if(isHex(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN)){
×
UNCOV
134
        if(!isValidateHex(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN)){
×
UNCOV
135
          return TSDB_CODE_PAR_INVALID_VARBINARY;
×
136
        }
137

UNCOV
138
        void* data = NULL;
×
UNCOV
139
        uint32_t size = 0;
×
UNCOV
140
        if(taosHex2Ascii(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN, &data, &size) < 0){
×
141
          return terrno;
×
142
        }
143

UNCOV
144
        if (size + VARSTR_HEADER_SIZE > TSDB_MAX_VARBINARY_LEN) {
×
UNCOV
145
          taosMemoryFree(data);
×
UNCOV
146
          return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
147
        }
UNCOV
148
        pVal->value  = data;
×
149
        pVal->length = size;
×
150
      }else{
UNCOV
151
        pVal->length -= NCHAR_ADD_LEN;
×
UNCOV
152
        if (pVal->length > TSDB_MAX_VARBINARY_LEN - VARSTR_HEADER_SIZE) {
×
153
          return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
154
        }
UNCOV
155
        void *data = taosMemoryMalloc(pVal->length);
×
UNCOV
156
        if(data == NULL){
×
UNCOV
157
          return terrno;
×
158
        }
UNCOV
159
        (void)memcpy(data, pVal->value + (NCHAR_ADD_LEN - 1), pVal->length);
×
UNCOV
160
        pVal->value = data;
×
161
      }
162

UNCOV
163
      return TSDB_CODE_SUCCESS;
×
164
    }
UNCOV
165
    return TSDB_CODE_TSC_INVALID_VALUE;
×
166
  }
167

168
  if (pVal->value[0] == 't' || pVal->value[0] == 'T') {
91!
169
    if (pVal->length == 1 ||
3✔
170
        (pVal->length == 4 && (pVal->value[1] == 'r' || pVal->value[1] == 'R') &&
2!
171
         (pVal->value[2] == 'u' || pVal->value[2] == 'U') && (pVal->value[3] == 'e' || pVal->value[3] == 'E'))) {
1!
172
      pVal->i = TSDB_TRUE;
2✔
173
      pVal->type = TSDB_DATA_TYPE_BOOL;
2✔
174
      pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
2✔
175
      return TSDB_CODE_SUCCESS;
2✔
176
    }
177
    return TSDB_CODE_TSC_INVALID_VALUE;
1✔
178
  }
179

180
  if (pVal->value[0] == 'f' || pVal->value[0] == 'F') {
88!
181
    if (pVal->length == 1 ||
8✔
182
        (pVal->length == 5 && (pVal->value[1] == 'a' || pVal->value[1] == 'A') &&
7!
183
         (pVal->value[2] == 'l' || pVal->value[2] == 'L') && (pVal->value[3] == 's' || pVal->value[3] == 'S') &&
5!
184
         (pVal->value[4] == 'e' || pVal->value[4] == 'E'))) {
5!
185
      pVal->i = TSDB_FALSE;
6✔
186
      pVal->type = TSDB_DATA_TYPE_BOOL;
6✔
187
      pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
6✔
188
      return TSDB_CODE_SUCCESS;
6✔
189
    }
190
    return TSDB_CODE_TSC_INVALID_VALUE;
2✔
191
  }
192

193
  // number
194
  if (smlParseNumber(pVal, msg)) {
80✔
195
    pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
27✔
196
    return TSDB_CODE_SUCCESS;
27✔
197
  }
198

199
  return TSDB_CODE_TSC_INVALID_VALUE;
53✔
200
}
201

202
static int32_t smlProcessTagLine(SSmlHandle *info, char **sql, char *sqlEnd){
78✔
203
  SArray *preLineKV = info->preLineTagKV;
78✔
204
  taosArrayClearEx(preLineKV, freeSSmlKv);
78✔
205
  int     cnt = 0;
78✔
206

207
  while (*sql < sqlEnd) {
85!
208
    if (unlikely(IS_SPACE(*sql,NULL))) {
85!
209
      break;
71✔
210
    }
211

212
    // parse key
213
    const char *key = *sql;
81✔
214
    size_t      keyLen = 0;
81✔
215
    bool        keyEscaped = false;
81✔
216
    size_t      keyLenEscaped = 0;
81✔
217
    const char *escapeChar = NULL;
81✔
218

219
    while (*sql < sqlEnd) {
186!
220
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
186!
221
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", *sql);
5✔
222
        return TSDB_CODE_SML_INVALID_DATA;
7✔
223
      }
224
      if (unlikely(IS_EQUAL(*sql,escapeChar))) {
181!
225
        keyLen = *sql - key;
76✔
226
        (*sql)++;
76✔
227
        break;
76✔
228
      }
229
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
105!
UNCOV
230
        escapeChar = *sql;
×
UNCOV
231
        keyLenEscaped++;
×
UNCOV
232
        keyEscaped = true;
×
233
      }
234
      (*sql)++;
105✔
235
    }
236

237
    if (unlikely(IS_INVALID_COL_LEN(keyLen - keyLenEscaped))) {
76!
UNCOV
238
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid key or key is too long than 64", key);
×
UNCOV
239
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
×
240
    }
241

242
    // parse value
243
    const char *value = *sql;
76✔
244
    size_t      valueLen = 0;
76✔
245
    bool        valueEscaped = false;
76✔
246
    size_t      valueLenEscaped = 0;
76✔
247
    while (*sql < sqlEnd) {
202!
248
      // parse value
249
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
202!
250
        break;
74✔
251
      } else if (unlikely(IS_EQUAL(*sql,escapeChar))) {
128!
252
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", *sql);
2✔
253
        return TSDB_CODE_SML_INVALID_DATA;
2✔
254
      }
255

256
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
126!
UNCOV
257
        escapeChar = *sql;
×
UNCOV
258
        valueLenEscaped++;
×
UNCOV
259
        valueEscaped = true;
×
260
      }
261

262
      (*sql)++;
126✔
263
    }
264
    valueLen = *sql - value;
74✔
265

266
    if (unlikely(valueLen == 0)) {
74!
UNCOV
267
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid value", value);
×
268
      return TSDB_CODE_SML_INVALID_DATA;
×
269
    }
270

271
    if (unlikely(valueLen - valueLenEscaped > (TSDB_MAX_NCHAR_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE)) {
74!
UNCOV
272
      return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
273
    }
274

275
    if (keyEscaped) {
74!
UNCOV
276
      char *tmp = (char *)taosMemoryMalloc(keyLen);
×
UNCOV
277
      if (tmp == NULL){
×
UNCOV
278
        return terrno;
×
279
      }
UNCOV
280
      (void)memcpy(tmp, key, keyLen);
×
UNCOV
281
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, keyLen);
×
UNCOV
282
      key = tmp;
×
283
    }
284
    if (valueEscaped) {
74!
UNCOV
285
      char *tmp = (char *)taosMemoryMalloc(valueLen);
×
UNCOV
286
      if (tmp == NULL){
×
UNCOV
287
        return terrno;
×
288
      }
UNCOV
289
      (void)memcpy(tmp, value, valueLen);
×
UNCOV
290
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, valueLen);
×
UNCOV
291
      value = tmp;
×
292
    }
293
    SSmlKv kv = {.key = key,
74✔
294
        .keyLen = keyLen,
295
        .type = TSDB_DATA_TYPE_NCHAR,
296
        .value = value,
297
        .length = valueLen,
298
        .keyEscaped = keyEscaped,
299
        .valueEscaped = valueEscaped};
300
    if(taosArrayPush(preLineKV, &kv) == NULL){
74!
UNCOV
301
      return terrno;
×
302
    }
303

304
    if (info->dataFormat && !isSmlTagAligned(info, cnt, &kv)) {
74!
UNCOV
305
      return TSDB_CODE_SML_INVALID_DATA;
×
306
    }
307

308
    cnt++;
74✔
309
    if (IS_SPACE(*sql,escapeChar)) {
74!
310
      break;
311
    }
312
    (*sql)++;
7✔
313
  }
314
  return TSDB_CODE_SUCCESS;
71✔
315
}
316

317
static int32_t smlParseTagLine(SSmlHandle *info, char **sql, char *sqlEnd, SSmlLineInfo *elements) {
79✔
318
  int32_t code = 0;
79✔
319
  int32_t lino = 0;
79✔
320
  bool isSameCTable = IS_SAME_CHILD_TABLE;
79!
321
  if(isSameCTable){
79✔
322
    return TSDB_CODE_SUCCESS;
1✔
323
  }
324

325
  if(info->dataFormat){
78!
UNCOV
326
    SML_CHECK_CODE(smlProcessSuperTable(info, elements));
×
327
  }
328
  SML_CHECK_CODE(smlProcessTagLine(info, sql, sqlEnd));
78✔
329
  return smlProcessChildTable(info, elements);
71✔
330

331
END:
7✔
332
  if(info->reRun){
7!
UNCOV
333
    return TSDB_CODE_SUCCESS;
×
334
  }
335
  RETURN
7!
336
}
337

338
static int32_t smlParseColLine(SSmlHandle *info, char **sql, char *sqlEnd, SSmlLineInfo *currElement) {
72✔
339
  int cnt = 0;
72✔
340
  while (*sql < sqlEnd) {
103!
341
    if (unlikely(IS_SPACE(*sql,NULL))) {
103!
342
      break;
5✔
343
    }
344

345
    // parse key
346
    const char *key = *sql;
103✔
347
    size_t      keyLen = 0;
103✔
348
    bool        keyEscaped = false;
103✔
349
    size_t      keyLenEscaped = 0;
103✔
350
    const char *escapeChar = NULL;
103✔
351
    while (*sql < sqlEnd) {
295!
352
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
295!
353
        smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid data", *sql);
5✔
354
        return TSDB_CODE_SML_INVALID_DATA;
67✔
355
      }
356
      if (unlikely(IS_EQUAL(*sql,escapeChar))) {
290!
357
        keyLen = *sql - key;
98✔
358
        (*sql)++;
98✔
359
        break;
98✔
360
      }
361
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
192!
362
        escapeChar = *sql;
1✔
363
        keyLenEscaped++;
1✔
364
        keyEscaped = true;
1✔
365
      }
366
      (*sql)++;
192✔
367
    }
368

369
    if (unlikely(IS_INVALID_COL_LEN(keyLen - keyLenEscaped))) {
98!
UNCOV
370
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid key or key is too long than 64", key);
×
UNCOV
371
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
×
372
    }
373

374
    // parse value
375
    const char *value = *sql;
98✔
376
    size_t      valueLen = 0;
98✔
377
    bool        valueEscaped = false;
98✔
378
    size_t      valueLenEscaped = 0;
98✔
379
    int         quoteNum = 0;
98✔
380
    while (*sql < sqlEnd) {
802✔
381
      // parse value
382
      if (unlikely(*(*sql) == QUOTE && (*(*sql - 1) != SLASH || (*sql - 1) == escapeChar))) {
799!
383
        quoteNum++;
27✔
384
        (*sql)++;
27✔
385
        if(quoteNum > 2){
27✔
386
          break;
2✔
387
        }
388
        continue;
25✔
389
      }
390
      if (quoteNum % 2 == 0 && (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar)))) {
772!
391
        break;
93✔
392
      }
393
      if (IS_SLASH_LETTER_IN_FIELD_VALUE(*sql) && (*sql - 1) != escapeChar) {
679!
UNCOV
394
        escapeChar = *sql;
×
UNCOV
395
        valueEscaped = true;
×
UNCOV
396
        valueLenEscaped++;
×
397
      }
398

399
      (*sql)++;
679✔
400
    }
401
    valueLen = *sql - value;
98✔
402

403
    if (unlikely(quoteNum != 0 && quoteNum != 2)) {
98✔
404
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line unbalanced quotes", value);
5✔
405
      return TSDB_CODE_SML_INVALID_DATA;
5✔
406
    }
407
    if (unlikely(valueLen == 0)) {
93✔
408
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid value", value);
1✔
409
      return TSDB_CODE_SML_INVALID_DATA;
1✔
410
    }
411

412
    SSmlKv  kv = {.key = key, .keyLen = keyLen, .value = value, .length = valueLen};
92✔
413
    int32_t ret = smlParseValue(&kv, &info->msgBuf);
92✔
414
    if (ret != TSDB_CODE_SUCCESS) {
92✔
415
      uError("SML:0x%" PRIx64 " %s parse value error:%d.", info->id, __FUNCTION__, ret);
56!
416
      return ret;
56✔
417
    }
418

419
    if (keyEscaped) {
36✔
420
      char *tmp = (char *)taosMemoryMalloc(kv.keyLen);
1!
421
      if (tmp == NULL){
1!
UNCOV
422
        return terrno;
×
423
      }
424
      (void)memcpy(tmp, key, kv.keyLen);
1✔
425
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, kv.keyLen);
5!
426
      kv.key = tmp;
1✔
427
      kv.keyEscaped = keyEscaped;
1✔
428
    }
429

430
    if (valueEscaped) {
36!
UNCOV
431
      char *tmp = (char *)taosMemoryMalloc(kv.length);
×
UNCOV
432
      if (tmp == NULL){
×
UNCOV
433
        return terrno;
×
434
      }
UNCOV
435
      (void)memcpy(tmp, kv.value, kv.length);
×
UNCOV
436
      PROCESS_SLASH_IN_FIELD_VALUE(tmp, kv.length);
×
UNCOV
437
      if(kv.type == TSDB_DATA_TYPE_VARBINARY){
×
UNCOV
438
        taosMemoryFree((void*)kv.value);
×
439
      }
UNCOV
440
      kv.value = tmp;
×
UNCOV
441
      kv.valueEscaped = valueEscaped;
×
442
    }
443

444
    if (info->dataFormat) {
36!
445
      bool isAligned = isSmlColAligned(info, cnt, &kv);
×
UNCOV
446
      if (kv.type == TSDB_DATA_TYPE_BINARY && valueEscaped) {
×
UNCOV
447
        if (taosArrayPush(info->escapedStringList, &kv.value) == NULL){
×
UNCOV
448
          freeSSmlKv(&kv);
×
UNCOV
449
          return terrno;
×
450
        }
UNCOV
451
        kv.value = NULL;
×
452
      }
UNCOV
453
      freeSSmlKv(&kv);
×
UNCOV
454
      if(!isAligned){
×
UNCOV
455
        return TSDB_CODE_SUCCESS;
×
456
      }
457
    } else {
458
      if (currElement->colArray == NULL) {
36✔
459
        currElement->colArray = taosArrayInit_s(sizeof(SSmlKv), 1);
6✔
460
        if (currElement->colArray == NULL) {
6!
UNCOV
461
          freeSSmlKv(&kv);
×
462
          return terrno;
×
463
        }
464
      }
465
      if (taosArrayPush(currElement->colArray, &kv) == NULL){  // reserve for timestamp
72!
UNCOV
466
        freeSSmlKv(&kv);
×
UNCOV
467
        return terrno;
×
468
      }
469
    }
470

471
    cnt++;
36✔
472
    if (IS_SPACE(*sql,escapeChar)) {
36!
473
      break;
474
    }
475
    (*sql)++;
31✔
476
  }
477

478
  return TSDB_CODE_SUCCESS;
5✔
479
}
480

481
int32_t smlParseInfluxString(SSmlHandle *info, char *sql, char *sqlEnd, SSmlLineInfo *elements) {
80✔
482
  if (!sql) return TSDB_CODE_SML_INVALID_DATA;
80!
483
  JUMP_SPACE(sql, sqlEnd)
83!
484
  if (unlikely(*sql == COMMA)) return TSDB_CODE_SML_INVALID_DATA;
80✔
485
  elements->measure = sql;
79✔
486
  // parse measure
487
  size_t measureLenEscaped = 0;
79✔
488
  const char *escapeChar = NULL;
79✔
489
  while (sql < sqlEnd) {
255!
490
    if (unlikely(IS_COMMA(sql,escapeChar) || IS_SPACE(sql,escapeChar))) {
255!
491
      break;
79✔
492
    }
493

494
    if (unlikely((sql != elements->measure) && IS_SLASH_LETTER_IN_MEASUREMENT(sql))) {
176!
495
      elements->measureEscaped = true;
1✔
496
      escapeChar = sql;
1✔
497
      measureLenEscaped++;
1✔
498
      sql++;
1✔
499
      continue;
1✔
500
    }
501
    sql++;
175✔
502
  }
503
  elements->measureLen = sql - elements->measure;
79✔
504
  if (unlikely(IS_INVALID_TABLE_LEN(elements->measureLen - measureLenEscaped))) {
79!
UNCOV
505
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line measure is empty or too large than 192", NULL);
×
UNCOV
506
    return TSDB_CODE_TSC_INVALID_TABLE_ID_LENGTH;
×
507
  }
508

509
  // to get measureTagsLen before
510
  const char *tmp = sql;
79✔
511
  while (tmp < sqlEnd) {
480!
512
    if (unlikely(IS_SPACE(tmp,escapeChar))) {
480!
513
      break;
79✔
514
    }
515
    if(unlikely(IS_SLASH_LETTER_IN_TAG_FIELD_KEY(tmp))){
401!
UNCOV
516
      escapeChar = tmp;
×
517
    }
518
    tmp++;
401✔
519
  }
520
  elements->measureTagsLen = tmp - elements->measure;
79✔
521
  elements->measureTag = elements->measure;
79✔
522
  // parse tag
523
  if (*sql == COMMA) sql++;
79✔
524
  elements->tags = sql;
79✔
525

526
  int ret = smlParseTagLine(info, &sql, sqlEnd, elements);
79✔
527
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
79✔
528
    return ret;
7✔
529
  }
530
  if (unlikely(info->reRun)) {
72!
UNCOV
531
    return TSDB_CODE_SUCCESS;
×
532
  }
533

534
  sql = elements->measure + elements->measureTagsLen;
72✔
535
  elements->tagsLen = sql - elements->tags;
72✔
536

537
  // parse cols
538
  JUMP_SPACE(sql, sqlEnd)
150!
539
  elements->cols = sql;
72✔
540

541
  ret = smlParseColLine(info, &sql, sqlEnd, elements);
72✔
542
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
72✔
543
    return ret;
67✔
544
  }
545

546
  if (unlikely(info->reRun)) {
5!
UNCOV
547
    return TSDB_CODE_SUCCESS;
×
548
  }
549

550
  elements->colsLen = sql - elements->cols;
5✔
551
  if (unlikely(elements->colsLen == 0)) {
5!
UNCOV
552
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line cols is empty", NULL);
×
UNCOV
553
    return TSDB_CODE_SML_INVALID_DATA;
×
554
  }
555

556
  // parse timestamp
557
  JUMP_SPACE(sql, sqlEnd)
13✔
558
  elements->timestamp = sql;
5✔
559
  while (sql < sqlEnd) {
81✔
560
    if (unlikely(isspace(*sql))) {
78✔
561
      break;
2✔
562
    }
563
    sql++;
76✔
564
  }
565
  elements->timestampLen = sql - elements->timestamp;
5✔
566

567
  int64_t ts = smlParseInfluxTime(info, elements->timestamp, elements->timestampLen);
5✔
568
  if (unlikely(ts <= 0)) {
5!
UNCOV
569
    uError("SML:0x%" PRIx64 " %s error:%" PRId64, info->id, __FUNCTION__, ts);
×
UNCOV
570
    return TSDB_CODE_INVALID_TIMESTAMP;
×
571
  }
572

573
  SSmlKv kvTs = {0};
5✔
574
  smlBuildTsKv(&kvTs, ts);
5✔
575

576
  return smlParseEndLine(info, elements, &kvTs);
5✔
577
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc