#3653

Committed 14 Mar 2025 08:10AM UTC coverage: 22.565% (-41.0%) from 63.596%

Build # #3653

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(keep): support keep on super table level. (#30097)

* Feat: support use keep while create super table.

* Test(keep): add test for create super table with keep option.

* Feat(keep): Add tmsg for create keep.

* Feat(keep): support alter table option keep.

* Fix(keep): Add baisc test for alter table option.

* Fix(keep): memory leek.

* Feat(keep): add keep to metaEntry&metaCache and fix earliestTs with stn keep.

* Test(keep): add some cases for select with stb keep.

* Fix: fix ci core while alter stb.

* Feat(keep): delete expired data in super table level.

* Feat: remove get stb keep while query.

* Fix : build error.

* Revert "Fix : build error."

This reverts commit 0ed66e4e8.

* Revert "Feat(keep): delete expired data in super table level."

This reverts commit 36330f6b4.

* Fix : build errors.

* Feat : support restart taosd.

* Fix : alter table comment problems.

* Test : add tests for super table keep.

* Fix: change sdb stb reserve size.

* Test: add more tests.

* Feat: Disable normal tables and sub tables from setting the keep parameter

* Fix: add more checks to avoid unknown address.

* Docs: Add docs for stable keep.

* Fix: some review changes.

* Fix: review errors.

Run Details

49248 of 302527 branches covered (16.28%)

Branch coverage included in aggregate %.

53 of 99 new or added lines in 12 files covered. (53.54%)

155872 existing lines in 443 files now uncovered.

87359 of 302857 relevant lines covered (28.84%)

570004.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

22.62

/source/client/src/clientMsgHandler.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "catalog.h"
#include "clientInt.h"
#include "clientLog.h"
#include "clientMonitor.h"
#include "cmdnodes.h"
#include "command.h"
#include "os.h"
#include "query.h"
#include "systable.h"
#include "tdatablock.h"
#include "tdef.h"
#include "tglobal.h"
#include "tname.h"
#include "tversion.h"

extern SClientHbMgr clientHbMgr;

static void setErrno(SRequestObj* pRequest, int32_t code) {
  pRequest->code = code;
  terrno = code;
}

int32_t genericRspCallback(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  setErrno(pRequest, code);

  if (NEED_CLIENT_RM_TBLMETA_REQ(pRequest->type)) {
    if (removeMeta(pRequest->pTscObj, pRequest->targetTableList, IS_VIEW_REQUEST(pRequest->type)) != 0) {
      tscError("failed to remove meta data for table");
    }
  }

  taosMemoryFree(pMsg->pEpSet);
  taosMemoryFree(pMsg->pData);
  if (pRequest->body.queryFp != NULL) {
    doRequestCallback(pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

int32_t processConnectRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = acquireRequest(*(int64_t*)param);
  if (NULL == pRequest) {
    goto EXIT;
  }

  if (code != TSDB_CODE_SUCCESS) {
    goto End;
  }

  STscObj* pTscObj = pRequest->pTscObj;

  if (NULL == pTscObj->pAppInfo) {
    code = TSDB_CODE_TSC_DISCONNECTED;
    goto End;
  }

  SConnectRsp connectRsp = {0};
  if (tDeserializeSConnectRsp(pMsg->pData, pMsg->len, &connectRsp) != 0) {
    code = TSDB_CODE_TSC_INVALID_VERSION;
    goto End;
  }

  if ((code = taosCheckVersionCompatibleFromStr(td_version, connectRsp.sVer, 3)) != 0) {
    tscError("version not compatible. client version:%s, server version:%s", td_version, connectRsp.sVer);
    goto End;
  }

  int32_t now = taosGetTimestampSec();
  int32_t delta = abs(now - connectRsp.svrTimestamp);
  if (delta > timestampDeltaLimit) {
    code = TSDB_CODE_TIME_UNSYNCED;
    tscError("time diff:%ds is too big", delta);
    goto End;
  }

  if (connectRsp.epSet.numOfEps == 0) {
    code = TSDB_CODE_APP_ERROR;
    goto End;
  }

  int updateEpSet = 1;
  if (connectRsp.dnodeNum == 1) {
    SEpSet srcEpSet = getEpSet_s(&pTscObj->pAppInfo->mgmtEp);
    SEpSet dstEpSet = connectRsp.epSet;
    if (srcEpSet.numOfEps == 1) {
      if (rpcSetDefaultAddr(pTscObj->pAppInfo->pTransporter, srcEpSet.eps[srcEpSet.inUse].fqdn,
                            dstEpSet.eps[dstEpSet.inUse].fqdn) != 0) {
        tscError("failed to set default addr for rpc");
      }
      updateEpSet = 0;
    }
  }
  if (updateEpSet == 1 && !isEpsetEqual(&pTscObj->pAppInfo->mgmtEp.epSet, &connectRsp.epSet)) {
    SEpSet corEpSet = getEpSet_s(&pTscObj->pAppInfo->mgmtEp);

    SEpSet* pOrig = &corEpSet;
    SEp*    pOrigEp = &pOrig->eps[pOrig->inUse];
    SEp*    pNewEp = &connectRsp.epSet.eps[connectRsp.epSet.inUse];
    tscDebug("mnode epset updated from %d/%d=>%s:%d to %d/%d=>%s:%d in connRsp", pOrig->inUse, pOrig->numOfEps,
             pOrigEp->fqdn, pOrigEp->port, connectRsp.epSet.inUse, connectRsp.epSet.numOfEps, pNewEp->fqdn,
             pNewEp->port);
    updateEpSet_s(&pTscObj->pAppInfo->mgmtEp, &connectRsp.epSet);
  }

  for (int32_t i = 0; i < connectRsp.epSet.numOfEps; ++i) {
    tscDebug("QID:0x%" PRIx64 ", epSet.fqdn[%d]:%s port:%d, connObj:0x%" PRIx64, pRequest->requestId, i,
             connectRsp.epSet.eps[i].fqdn, connectRsp.epSet.eps[i].port, pTscObj->id);
  }

  pTscObj->sysInfo = connectRsp.sysInfo;
  pTscObj->connId = connectRsp.connId;
  pTscObj->acctId = connectRsp.acctId;
  tstrncpy(pTscObj->sVer, connectRsp.sVer, tListLen(pTscObj->sVer));
  tstrncpy(pTscObj->sDetailVer, connectRsp.sDetailVer, tListLen(pTscObj->sDetailVer));

  // update the appInstInfo
  pTscObj->pAppInfo->clusterId = connectRsp.clusterId;
  pTscObj->pAppInfo->serverCfg.monitorParas = connectRsp.monitorParas;
  pTscObj->pAppInfo->serverCfg.enableAuditDelete = connectRsp.enableAuditDelete;
  tscDebug("monitor paras from connect rsp, clusterId:0x%" PRIx64 ", threshold:%d scope:%d",
           connectRsp.clusterId, connectRsp.monitorParas.tsSlowLogThreshold, connectRsp.monitorParas.tsSlowLogScope);
  lastClusterId = connectRsp.clusterId;

  pTscObj->connType = connectRsp.connType;
  pTscObj->passInfo.ver = connectRsp.passVer;
  pTscObj->authVer = connectRsp.authVer;
  pTscObj->whiteListInfo.ver = connectRsp.whiteListVer;

  if (taosHashGet(appInfo.pInstMapByClusterId, &connectRsp.clusterId, LONG_BYTES) == NULL) {
    if (taosHashPut(appInfo.pInstMapByClusterId, &connectRsp.clusterId, LONG_BYTES, &pTscObj->pAppInfo,
                    POINTER_BYTES) != 0) {
      tscError("failed to put appInfo into appInfo.pInstMapByClusterId");
    } else {
#ifdef USE_MONITOR
      MonitorSlowLogData data = {0};
      data.clusterId = pTscObj->pAppInfo->clusterId;
      data.type = SLOW_LOG_READ_BEGINNIG;
      (void)monitorPutData2MonitorQueue(data);  // ignore
      monitorClientSlowQueryInit(connectRsp.clusterId);
      monitorClientSQLReqInit(connectRsp.clusterId);
#endif
    }
  }

  (void)taosThreadMutexLock(&clientHbMgr.lock);
  SAppHbMgr* pAppHbMgr = taosArrayGetP(clientHbMgr.appHbMgrs, pTscObj->appHbMgrIdx);
  if (pAppHbMgr) {
    if (hbRegisterConn(pAppHbMgr, pTscObj->id, connectRsp.clusterId, connectRsp.connType) != 0) {
      tscError("QID:0x%" PRIx64 ", failed to register conn to hbMgr", pRequest->requestId);
    }
  } else {
    (void)taosThreadMutexUnlock(&clientHbMgr.lock);
    code = TSDB_CODE_TSC_DISCONNECTED;
    goto End;
  }
  (void)taosThreadMutexUnlock(&clientHbMgr.lock);

  tscDebug("QID:0x%" PRIx64 ", clusterId:0x%" PRIx64 ", totalConn:%" PRId64, pRequest->requestId, connectRsp.clusterId,
           pTscObj->pAppInfo->numOfConns);

End:
  if (code != 0) {
    setErrno(pRequest, code);
  }
  if (tsem_post(&pRequest->body.rspSem) != 0) {
    tscError("failed to post semaphore");
  }

  if (pRequest) {
    (void)releaseRequest(pRequest->self);
  }

EXIT:
  taosMemoryFree(param);
  taosMemoryFree(pMsg->pEpSet);
  taosMemoryFree(pMsg->pData);
  return code;
}

SMsgSendInfo* buildMsgInfoImpl(SRequestObj* pRequest) {
  SMsgSendInfo* pMsgSendInfo = taosMemoryCalloc(1, sizeof(SMsgSendInfo));
  if (pMsgSendInfo == NULL) return pMsgSendInfo;
  pMsgSendInfo->requestObjRefId = pRequest->self;
  pMsgSendInfo->requestId = pRequest->requestId;
  pMsgSendInfo->param = pRequest;
  pMsgSendInfo->msgType = pRequest->type;
  pMsgSendInfo->target.type = TARGET_TYPE_MNODE;

  pMsgSendInfo->msgInfo = pRequest->body.requestMsg;
  pMsgSendInfo->fp = getMsgRspHandle(pRequest->type);
  return pMsgSendInfo;
}

int32_t processCreateDbRsp(void* param, SDataBuf* pMsg, int32_t code) {
  // todo rsp with the vnode id list
  SRequestObj* pRequest = param;
  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);
  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  } else {
    struct SCatalog* pCatalog = NULL;
    code = catalogGetHandle(pRequest->pTscObj->pAppInfo->clusterId, &pCatalog);
    if (TSDB_CODE_SUCCESS == code) {
      STscObj* pTscObj = pRequest->pTscObj;

      SRequestConnInfo conn = {.pTrans = pTscObj->pAppInfo->pTransporter,
                               .requestId = pRequest->requestId,
                               .requestObjRefId = pRequest->self,
                               .mgmtEps = getEpSet_s(&pTscObj->pAppInfo->mgmtEp)};
      char             dbFName[TSDB_DB_FNAME_LEN];
      (void)snprintf(dbFName, sizeof(dbFName) - 1, "%d.%s", pTscObj->acctId, TSDB_INFORMATION_SCHEMA_DB);
      if (catalogRefreshDBVgInfo(pCatalog, &conn, dbFName) != 0) {
        tscError("QID:0x%" PRIx64 ", failed to refresh db vg info", pRequest->requestId);
      }
      (void)snprintf(dbFName, sizeof(dbFName) - 1, "%d.%s", pTscObj->acctId, TSDB_PERFORMANCE_SCHEMA_DB);
      if (catalogRefreshDBVgInfo(pCatalog, &conn, dbFName) != 0) {
        tscError("QID:0x%" PRIx64 ", failed to refresh db vg info", pRequest->requestId);
      }
    }
  }

  if (pRequest->body.queryFp) {
    doRequestCallback(pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

int32_t processUseDbRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  if (TSDB_CODE_MND_DB_NOT_EXIST == code || TSDB_CODE_MND_DB_IN_CREATING == code ||
      TSDB_CODE_MND_DB_IN_DROPPING == code) {
    SUseDbRsp usedbRsp = {0};
    if (tDeserializeSUseDbRsp(pMsg->pData, pMsg->len, &usedbRsp) != 0) {
      tscError("QID:0x%" PRIx64 ", deserialize SUseDbRsp failed", pRequest->requestId);
    }
    struct SCatalog* pCatalog = NULL;

    if (usedbRsp.vgVersion >= 0) {  // cached in local
      int64_t clusterId = pRequest->pTscObj->pAppInfo->clusterId;
      int32_t code1 = catalogGetHandle(clusterId, &pCatalog);
      if (code1 != TSDB_CODE_SUCCESS) {
        tscWarn("QID:0x%" PRIx64 ", catalogGetHandle failed, clusterId:0x%" PRIx64 ", error:%s", pRequest->requestId, clusterId,
                tstrerror(code1));
      } else {
        if (catalogRemoveDB(pCatalog, usedbRsp.db, usedbRsp.uid) != 0) {
          tscError("QID:0x%" PRIx64 ", catalogRemoveDB failed, db:%s, uid:%" PRId64, pRequest->requestId, usedbRsp.db,
                   usedbRsp.uid);
        }
      }
    }
    tFreeSUsedbRsp(&usedbRsp);
  }

  if (code != TSDB_CODE_SUCCESS) {
    taosMemoryFree(pMsg->pData);
    taosMemoryFree(pMsg->pEpSet);
    setErrno(pRequest, code);

    if (pRequest->body.queryFp != NULL) {
      doRequestCallback(pRequest, pRequest->code);

    } else {
      if (tsem_post(&pRequest->body.rspSem) != 0) {
        tscError("failed to post semaphore");
      }
    }

    return code;
  }

  SUseDbRsp usedbRsp = {0};
  if (tDeserializeSUseDbRsp(pMsg->pData, pMsg->len, &usedbRsp) != 0) {
    tscError("QID:0x%" PRIx64 ", deserialize SUseDbRsp failed", pRequest->requestId);
  }

  if (strlen(usedbRsp.db) == 0) {
    taosMemoryFree(pMsg->pData);
    taosMemoryFree(pMsg->pEpSet);

    if (usedbRsp.errCode != 0) {
      return usedbRsp.errCode;
    } else {
      return TSDB_CODE_APP_ERROR;
    }
  }

  tscTrace("db:%s, usedbRsp received, numOfVgroups:%d", usedbRsp.db, usedbRsp.vgNum);
  for (int32_t i = 0; i < usedbRsp.vgNum; ++i) {
    SVgroupInfo* pInfo = taosArrayGet(usedbRsp.pVgroupInfos, i);
    if (pInfo == NULL) {
      continue;
    }
    tscTrace("vgId:%d, numOfEps:%d inUse:%d ", pInfo->vgId, pInfo->epSet.numOfEps, pInfo->epSet.inUse);
    for (int32_t j = 0; j < pInfo->epSet.numOfEps; ++j) {
      tscTrace("vgId:%d, index:%d epset:%s:%u", pInfo->vgId, j, pInfo->epSet.eps[j].fqdn, pInfo->epSet.eps[j].port);
    }
  }

  SName name = {0};
  if (tNameFromString(&name, usedbRsp.db, T_NAME_ACCT | T_NAME_DB) != TSDB_CODE_SUCCESS) {
    tscError("QID:0x%" PRIx64 ", failed to parse db name:%s", pRequest->requestId, usedbRsp.db);
  }

  SUseDbOutput output = {0};
  code = queryBuildUseDbOutput(&output, &usedbRsp);
  if (code != 0) {
    terrno = code;
    if (output.dbVgroup) taosHashCleanup(output.dbVgroup->vgHash);

    tscError("QID:0x%" PRIx64 ", failed to build use db output since %s", pRequest->requestId, terrstr());
  } else if (output.dbVgroup && output.dbVgroup->vgHash) {
    struct SCatalog* pCatalog = NULL;

    int32_t code1 = catalogGetHandle(pRequest->pTscObj->pAppInfo->clusterId, &pCatalog);
    if (code1 != TSDB_CODE_SUCCESS) {
      tscWarn("catalogGetHandle failed, clusterId:0x%" PRIx64 ", error:%s", pRequest->pTscObj->pAppInfo->clusterId,
              tstrerror(code1));
    } else {
      if (catalogUpdateDBVgInfo(pCatalog, output.db, output.dbId, output.dbVgroup) != 0) {
        tscError("QID:0x%" PRIx64 ", failed to update db vg info, db:%s, dbId:%" PRId64, pRequest->requestId, output.db,
                 output.dbId);
      }
      output.dbVgroup = NULL;
    }
  }

  taosMemoryFreeClear(output.dbVgroup);
  tFreeSUsedbRsp(&usedbRsp);

  char db[TSDB_DB_NAME_LEN] = {0};
  if (tNameGetDbName(&name, db) != TSDB_CODE_SUCCESS) {
    tscError("QID:0x%" PRIx64 ", failed to get db name since %s", pRequest->requestId, tstrerror(code));
  }

  setConnectionDB(pRequest->pTscObj, db);

  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);

  if (pRequest->body.queryFp != NULL) {
    doRequestCallback(pRequest, pRequest->code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return 0;
}

int32_t processCreateSTableRsp(void* param, SDataBuf* pMsg, int32_t code) {
  if (pMsg == NULL) {
    tscError("processCreateSTableRsp: invalid input param, pMsg is NULL");
    return TSDB_CODE_TSC_INVALID_INPUT;
  }
  if (param == NULL) {
    taosMemoryFree(pMsg->pEpSet);
    taosMemoryFree(pMsg->pData);
    tscError("processCreateSTableRsp: invalid input param, param is NULL");
    return TSDB_CODE_TSC_INVALID_INPUT;
  }

  SRequestObj* pRequest = param;

  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  } else {
    SMCreateStbRsp createRsp = {0};
    SDecoder       coder = {0};
    tDecoderInit(&coder, pMsg->pData, pMsg->len);
    if (pMsg->len > 0) {
      code = tDecodeSMCreateStbRsp(&coder, &createRsp);  // pMsg->len == 0
      if (code != TSDB_CODE_SUCCESS) {
        setErrno(pRequest, code);
      }
    }
    tDecoderClear(&coder);

    pRequest->body.resInfo.execRes.msgType = TDMT_MND_CREATE_STB;
    pRequest->body.resInfo.execRes.res = createRsp.pMeta;
  }

  taosMemoryFree(pMsg->pEpSet);
  taosMemoryFree(pMsg->pData);

  if (pRequest->body.queryFp != NULL) {
    SExecResult* pRes = &pRequest->body.resInfo.execRes;

    if (code == TSDB_CODE_SUCCESS) {
      SCatalog* pCatalog = NULL;
      int32_t   ret = catalogGetHandle(pRequest->pTscObj->pAppInfo->clusterId, &pCatalog);
      if (pRes->res != NULL) {
        ret = handleCreateTbExecRes(pRes->res, pCatalog);
      }

      if (ret != TSDB_CODE_SUCCESS) {
        code = ret;
      }
    }

    doRequestCallback(pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

int32_t processDropDbRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  } else {
    SDropDbRsp dropdbRsp = {0};
    if (tDeserializeSDropDbRsp(pMsg->pData, pMsg->len, &dropdbRsp) != 0) {
      tscError("QID:0x%" PRIx64 ", deserialize SDropDbRsp failed", pRequest->requestId);
    }
    struct SCatalog* pCatalog = NULL;
    code = catalogGetHandle(pRequest->pTscObj->pAppInfo->clusterId, &pCatalog);
    if (TSDB_CODE_SUCCESS == code) {
      if (catalogRemoveDB(pCatalog, dropdbRsp.db, dropdbRsp.uid) != 0) {
        tscError("QID:0x%" PRIx64 ", failed to remove db:%s", pRequest->requestId, dropdbRsp.db);
      }
      STscObj* pTscObj = pRequest->pTscObj;

      SRequestConnInfo conn = {.pTrans = pTscObj->pAppInfo->pTransporter,
                               .requestId = pRequest->requestId,
                               .requestObjRefId = pRequest->self,
                               .mgmtEps = getEpSet_s(&pTscObj->pAppInfo->mgmtEp)};
      char             dbFName[TSDB_DB_FNAME_LEN] = {0};
      (void)snprintf(dbFName, sizeof(dbFName) - 1, "%d.%s", pTscObj->acctId, TSDB_INFORMATION_SCHEMA_DB);
      if (catalogRefreshDBVgInfo(pCatalog, &conn, dbFName) != TSDB_CODE_SUCCESS) {
        tscError("QID:0x%" PRIx64 ", failed to refresh db vg info, db:%s", pRequest->requestId, dbFName);
      }
      (void)snprintf(dbFName, sizeof(dbFName) - 1, "%d.%s", pTscObj->acctId, TSDB_PERFORMANCE_SCHEMA_DB);
      if (catalogRefreshDBVgInfo(pCatalog, &conn, dbFName) != 0) {
        tscError("QID:0x%" PRIx64 ", failed to refresh db vg info, db:%s", pRequest->requestId, dbFName);
      }
    }
  }

  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);

  if (pRequest->body.queryFp != NULL) {
    doRequestCallback(pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

int32_t processAlterStbRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  } else {
    SMAlterStbRsp alterRsp = {0};
    SDecoder      coder = {0};
    tDecoderInit(&coder, pMsg->pData, pMsg->len);
    if (pMsg->len > 0) {
      code = tDecodeSMAlterStbRsp(&coder, &alterRsp);  // pMsg->len == 0
      if (code != TSDB_CODE_SUCCESS) {
        setErrno(pRequest, code);
      }
    }
    tDecoderClear(&coder);

    pRequest->body.resInfo.execRes.msgType = TDMT_MND_ALTER_STB;
    pRequest->body.resInfo.execRes.res = alterRsp.pMeta;
  }

  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);

  if (pRequest->body.queryFp != NULL) {
    SExecResult* pRes = &pRequest->body.resInfo.execRes;

    if (code == TSDB_CODE_SUCCESS) {
      SCatalog* pCatalog = NULL;
      int32_t   ret = catalogGetHandle(pRequest->pTscObj->pAppInfo->clusterId, &pCatalog);
      if (pRes->res != NULL) {
        ret = handleAlterTbExecRes(pRes->res, pCatalog);
      }

      if (ret != TSDB_CODE_SUCCESS) {
        code = ret;
      }
    }

    doRequestCallback(pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

static int32_t buildShowVariablesBlock(SArray* pVars, SSDataBlock** block) {
  int32_t      code = 0;
  int32_t      line = 0;
  SSDataBlock* pBlock = taosMemoryCalloc(1, sizeof(SSDataBlock));
  TSDB_CHECK_NULL(pBlock, code, line, END, terrno);
  pBlock->info.hasVarCol = true;

  pBlock->pDataBlock = taosArrayInit(SHOW_VARIABLES_RESULT_COLS, sizeof(SColumnInfoData));
  TSDB_CHECK_NULL(pBlock->pDataBlock, code, line, END, terrno);
  SColumnInfoData infoData = {0};
  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = SHOW_VARIABLES_RESULT_FIELD1_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = SHOW_VARIABLES_RESULT_FIELD2_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = SHOW_VARIABLES_RESULT_FIELD3_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = SHOW_VARIABLES_RESULT_FIELD4_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = SHOW_VARIABLES_RESULT_FIELD5_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  int32_t numOfCfg = taosArrayGetSize(pVars);
  code = blockDataEnsureCapacity(pBlock, numOfCfg);
  TSDB_CHECK_CODE(code, line, END);

  for (int32_t i = 0, c = 0; i < numOfCfg; ++i, c = 0) {
    SVariablesInfo* pInfo = taosArrayGet(pVars, i);
    TSDB_CHECK_NULL(pInfo, code, line, END, terrno);

    char name[TSDB_CONFIG_OPTION_LEN + VARSTR_HEADER_SIZE] = {0};
    STR_WITH_MAXSIZE_TO_VARSTR(name, pInfo->name, TSDB_CONFIG_OPTION_LEN + VARSTR_HEADER_SIZE);
    SColumnInfoData* pColInfo = taosArrayGet(pBlock->pDataBlock, c++);
    TSDB_CHECK_NULL(pColInfo, code, line, END, terrno);
    code = colDataSetVal(pColInfo, i, name, false);
    TSDB_CHECK_CODE(code, line, END);

    char value[TSDB_CONFIG_VALUE_LEN + VARSTR_HEADER_SIZE] = {0};
    STR_WITH_MAXSIZE_TO_VARSTR(value, pInfo->value, TSDB_CONFIG_VALUE_LEN + VARSTR_HEADER_SIZE);
    pColInfo = taosArrayGet(pBlock->pDataBlock, c++);
    TSDB_CHECK_NULL(pColInfo, code, line, END, terrno);
    code = colDataSetVal(pColInfo, i, value, false);
    TSDB_CHECK_CODE(code, line, END);

    char scope[TSDB_CONFIG_SCOPE_LEN + VARSTR_HEADER_SIZE] = {0};
    STR_WITH_MAXSIZE_TO_VARSTR(scope, pInfo->scope, TSDB_CONFIG_SCOPE_LEN + VARSTR_HEADER_SIZE);
    pColInfo = taosArrayGet(pBlock->pDataBlock, c++);
    TSDB_CHECK_NULL(pColInfo, code, line, END, terrno);
    code = colDataSetVal(pColInfo, i, scope, false);
    TSDB_CHECK_CODE(code, line, END);

    char category[TSDB_CONFIG_CATEGORY_LEN + VARSTR_HEADER_SIZE] = {0};
    STR_WITH_MAXSIZE_TO_VARSTR(category, pInfo->category, TSDB_CONFIG_CATEGORY_LEN + VARSTR_HEADER_SIZE);
    pColInfo = taosArrayGet(pBlock->pDataBlock, c++);
    TSDB_CHECK_NULL(pColInfo, code, line, END, terrno);
    code = colDataSetVal(pColInfo, i, category, false);
    TSDB_CHECK_CODE(code, line, END);

    char info[TSDB_CONFIG_INFO_LEN + VARSTR_HEADER_SIZE] = {0};
    STR_WITH_MAXSIZE_TO_VARSTR(info, pInfo->info, TSDB_CONFIG_INFO_LEN + VARSTR_HEADER_SIZE);
    pColInfo = taosArrayGet(pBlock->pDataBlock, c++);
    TSDB_CHECK_NULL(pColInfo, code, line, END, terrno);
    code = colDataSetVal(pColInfo, i, info, false);
    TSDB_CHECK_CODE(code, line, END);
  }

  pBlock->info.rows = numOfCfg;

  *block = pBlock;
  return code;

END:
  taosArrayDestroy(pBlock->pDataBlock);
  taosMemoryFree(pBlock);
  return code;
}

static int32_t buildShowVariablesRsp(SArray* pVars, SRetrieveTableRsp** pRsp) {
  SSDataBlock* pBlock = NULL;
  int32_t      code = buildShowVariablesBlock(pVars, &pBlock);
  if (code) {
    return code;
  }

  size_t dataEncodeBufSize = blockGetEncodeSize(pBlock);
  size_t rspSize = sizeof(SRetrieveTableRsp) + dataEncodeBufSize + PAYLOAD_PREFIX_LEN;
  *pRsp = taosMemoryCalloc(1, rspSize);
  if (NULL == *pRsp) {
    code = terrno;
    goto _exit;
  }

  (*pRsp)->useconds = 0;
  (*pRsp)->completed = 1;
  (*pRsp)->precision = 0;
  (*pRsp)->compressed = 0;

  (*pRsp)->numOfRows = htobe64((int64_t)pBlock->info.rows);
  (*pRsp)->numOfCols = htonl(SHOW_VARIABLES_RESULT_COLS);

  int32_t len = 0;
  if ((*pRsp)->numOfRows > 0) {
    len = blockEncode(pBlock, (*pRsp)->data + PAYLOAD_PREFIX_LEN, dataEncodeBufSize, SHOW_VARIABLES_RESULT_COLS);
    if (len < 0) {
      uError("buildShowVariablesRsp error, len:%d", len);
      code = terrno;
      goto _exit;
    }
    SET_PAYLOAD_LEN((*pRsp)->data, len, len);

    int32_t payloadLen = len + PAYLOAD_PREFIX_LEN;
    (*pRsp)->payloadLen = htonl(payloadLen);
    (*pRsp)->compLen = htonl(payloadLen);

    if (payloadLen != rspSize - sizeof(SRetrieveTableRsp)) {
      uError("buildShowVariablesRsp error, len:%d != rspSize - sizeof(SRetrieveTableRsp):%" PRIu64, len,
             (uint64_t)(rspSize - sizeof(SRetrieveTableRsp)));
      code = TSDB_CODE_TSC_INVALID_INPUT;
      goto _exit;
    }
  }

  blockDataDestroy(pBlock);
  pBlock = NULL;

  return TSDB_CODE_SUCCESS;
_exit:
  if (*pRsp) {
    taosMemoryFree(*pRsp);
    *pRsp = NULL;
  }
  if (pBlock) {
    blockDataDestroy(pBlock);
    pBlock = NULL;
  }
  return code;
}

int32_t processShowVariablesRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  } else {
    SShowVariablesRsp  rsp = {0};
    SRetrieveTableRsp* pRes = NULL;
    code = tDeserializeSShowVariablesRsp(pMsg->pData, pMsg->len, &rsp);
    if (TSDB_CODE_SUCCESS == code) {
      code = buildShowVariablesRsp(rsp.variables, &pRes);
    }
    if (TSDB_CODE_SUCCESS == code) {
      code = setQueryResultFromRsp(&pRequest->body.resInfo, pRes, false);
    }

    if (code != 0) {
      taosMemoryFree(pRes);
    }
    tFreeSShowVariablesRsp(&rsp);
  }

  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);

  if (pRequest->body.queryFp != NULL) {
    doRequestCallback(pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

static int32_t buildCompactDbBlock(SCompactDbRsp* pRsp, SSDataBlock** block) {
  int32_t      code = 0;
  int32_t      line = 0;
  SSDataBlock* pBlock = taosMemoryCalloc(1, sizeof(SSDataBlock));
  TSDB_CHECK_NULL(pBlock, code, line, END, terrno);
  pBlock->info.hasVarCol = true;

  pBlock->pDataBlock = taosArrayInit(COMPACT_DB_RESULT_COLS, sizeof(SColumnInfoData));
  TSDB_CHECK_NULL(pBlock->pDataBlock, code, line, END, terrno);
  SColumnInfoData infoData = {0};
  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = COMPACT_DB_RESULT_FIELD1_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  infoData.info.type = TSDB_DATA_TYPE_INT;
  infoData.info.bytes = tDataTypes[TSDB_DATA_TYPE_INT].bytes;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  infoData.info.type = TSDB_DATA_TYPE_VARCHAR;
  infoData.info.bytes = COMPACT_DB_RESULT_FIELD3_LEN;
  TSDB_CHECK_NULL(taosArrayPush(pBlock->pDataBlock, &infoData), code, line, END, terrno);

  code = blockDataEnsureCapacity(pBlock, 1);
  TSDB_CHECK_CODE(code, line, END);

  SColumnInfoData* pResultCol = taosArrayGet(pBlock->pDataBlock, 0);
  TSDB_CHECK_NULL(pResultCol, code, line, END, terrno);
  SColumnInfoData* pIdCol = taosArrayGet(pBlock->pDataBlock, 1);
  TSDB_CHECK_NULL(pIdCol, code, line, END, terrno);
  SColumnInfoData* pReasonCol = taosArrayGet(pBlock->pDataBlock, 2);
  TSDB_CHECK_NULL(pReasonCol, code, line, END, terrno);

  char result[COMPACT_DB_RESULT_FIELD1_LEN] = {0};
  char reason[COMPACT_DB_RESULT_FIELD3_LEN] = {0};
  if (pRsp->bAccepted) {
    STR_TO_VARSTR(result, "accepted");
    code = colDataSetVal(pResultCol, 0, result, false);
    TSDB_CHECK_CODE(code, line, END);
    code = colDataSetVal(pIdCol, 0, (void*)&pRsp->compactId, false);
    TSDB_CHECK_CODE(code, line, END);
    STR_TO_VARSTR(reason, "success");
    code = colDataSetVal(pReasonCol, 0, reason, false);
    TSDB_CHECK_CODE(code, line, END);
  } else {
    STR_TO_VARSTR(result, "rejected");
    code = colDataSetVal(pResultCol, 0, result, false);
    TSDB_CHECK_CODE(code, line, END);
    colDataSetNULL(pIdCol, 0);
    STR_TO_VARSTR(reason, "compaction is ongoing");
    code = colDataSetVal(pReasonCol, 0, reason, false);
    TSDB_CHECK_CODE(code, line, END);
  }
  pBlock->info.rows = 1;

  *block = pBlock;

  return TSDB_CODE_SUCCESS;
END:
  taosMemoryFree(pBlock);
  taosArrayDestroy(pBlock->pDataBlock);
  return code;
}

static int32_t buildRetriveTableRspForCompactDb(SCompactDbRsp* pCompactDb, SRetrieveTableRsp** pRsp) {
  SSDataBlock* pBlock = NULL;
  int32_t      code = buildCompactDbBlock(pCompactDb, &pBlock);
  if (code) {
    return code;
  }

  size_t dataEncodeBufSize = blockGetEncodeSize(pBlock);
  size_t rspSize = sizeof(SRetrieveTableRsp) + dataEncodeBufSize + PAYLOAD_PREFIX_LEN;
  *pRsp = taosMemoryCalloc(1, rspSize);
  if (NULL == *pRsp) {
    code = terrno;
    goto _exit;
  }

  (*pRsp)->useconds = 0;
  (*pRsp)->completed = 1;
  (*pRsp)->precision = 0;
  (*pRsp)->compressed = 0;
  (*pRsp)->compLen = 0;
  (*pRsp)->payloadLen = 0;
  (*pRsp)->numOfRows = htobe64((int64_t)pBlock->info.rows);
  (*pRsp)->numOfCols = htonl(COMPACT_DB_RESULT_COLS);

  int32_t len = blockEncode(pBlock, (*pRsp)->data + PAYLOAD_PREFIX_LEN, dataEncodeBufSize, COMPACT_DB_RESULT_COLS);
  if (len < 0) {
    uError("buildRetriveTableRspForCompactDb error, len:%d", len);
    code = terrno;
    goto _exit;
  }
  blockDataDestroy(pBlock);

  SET_PAYLOAD_LEN((*pRsp)->data, len, len);

  int32_t payloadLen = len + PAYLOAD_PREFIX_LEN;
  (*pRsp)->payloadLen = htonl(payloadLen);
  (*pRsp)->compLen = htonl(payloadLen);

  if (payloadLen != rspSize - sizeof(SRetrieveTableRsp)) {
    uError("buildRetriveTableRspForCompactDb error, len:%d != rspSize - sizeof(SRetrieveTableRsp):%" PRIu64, len,
           (uint64_t)(rspSize - sizeof(SRetrieveTableRsp)));
    code = TSDB_CODE_TSC_INVALID_INPUT;
    goto _exit;
  }

  return TSDB_CODE_SUCCESS;
_exit:
  if (*pRsp) {
    taosMemoryFree(*pRsp);
    *pRsp = NULL;
  }
  if (pBlock) {
    blockDataDestroy(pBlock);
    pBlock = NULL;
  }
  return code;
}

int32_t processCompactDbRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  } else {
    SCompactDbRsp      rsp = {0};
    SRetrieveTableRsp* pRes = NULL;
    code = tDeserializeSCompactDbRsp(pMsg->pData, pMsg->len, &rsp);
    if (TSDB_CODE_SUCCESS == code) {
      code = buildRetriveTableRspForCompactDb(&rsp, &pRes);
    }
    if (TSDB_CODE_SUCCESS == code) {
      code = setQueryResultFromRsp(&pRequest->body.resInfo, pRes, false);
    }

    if (code != 0) {
      taosMemoryFree(pRes);
    }
  }

  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);

  if (pRequest->body.queryFp != NULL) {
    pRequest->body.queryFp(((SSyncQueryParam*)pRequest->body.interParam)->userParam, pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }
  return code;
}

static int32_t setCreateStreamFailedRsp(void* param, SDataBuf* pMsg, int32_t code) {
  if (pMsg) {
    taosMemoryFree(pMsg->pEpSet);
    taosMemoryFree(pMsg->pData);
  }
  if (code != 0){
    tscError("setCreateStreamFailedRsp since %s", tstrerror(code));
  } else{
    tscInfo("setCreateStreamFailedRsp success");
  }
  return code;
}

void sendCreateStreamFailedMsg(SRequestObj* pRequest, char* streamName){
  int32_t code  = 0;
  tscInfo("send failed stream name to mgmt: %s", streamName);
  int32_t size = INT_BYTES + strlen(streamName);
  void *buf = taosMemoryMalloc(size);
  if (buf == NULL) {
    tscError("failed to strdup stream name: %s", terrstr());
    return;
  }
  *(int32_t*)buf = pRequest->code;
  memcpy(POINTER_SHIFT(buf, INT_BYTES), streamName, strlen(streamName));

  SMsgSendInfo* sendInfo = taosMemoryCalloc(1, sizeof(SMsgSendInfo));
  if (sendInfo == NULL) {
    taosMemoryFree(buf);
    tscError("failed to calloc msgSendInfo: %s", terrstr());
    return;
  }
  sendInfo->msgInfo = (SDataBuf){.pData = buf, .len = size, .handle = NULL};
  sendInfo->requestId = generateRequestId();
  sendInfo->requestObjRefId = 0;
  sendInfo->msgType = TDMT_MND_FAILED_STREAM;
  sendInfo->fp = setCreateStreamFailedRsp;

  SEpSet epSet = getEpSet_s(&pRequest->pTscObj->pAppInfo->mgmtEp);
  code = asyncSendMsgToServer(pRequest->pTscObj->pAppInfo->pTransporter, &epSet, NULL, sendInfo);
  if (code != 0) {
    tscError("failed to send failed stream name to mgmt since %s", tstrerror(code));
  }
}

static void processCreateStreamSecondPhaseRsp(void* param, void* res, int32_t code) {
  SRequestObj* pRequest = res;
  if (code != 0 && param != NULL){
    sendCreateStreamFailedMsg(pRequest, param);
  }
  taosMemoryFree(param);
  destroyRequest(pRequest);
}

static char* getStreamName(SRequestObj* pRequest){
  SCreateStreamStmt* pStmt = (SCreateStreamStmt*)(pRequest->pQuery->pRoot);
  SName   name;
  int32_t code = tNameSetDbName(&name, pRequest->pTscObj->acctId, pStmt->streamName, strlen(pStmt->streamName));
  if (TSDB_CODE_SUCCESS != code) {
    tscError("failed to set db name for stream since %s", tstrerror(code));
    return NULL;
  } else{
    char *streamName = taosMemoryCalloc(1, TSDB_STREAM_FNAME_LEN);
    (void)tNameGetFullDbName(&name, streamName);
    return streamName;
  }
}

void processCreateStreamSecondPhase(SRequestObj* pRequest){
  tscInfo("[create stream with histroy] create in second phase");
  char *streamName = getStreamName(pRequest);
  size_t sqlLen = strlen(pRequest->sqlstr);
  SRequestObj* pRequestNew = NULL;
  int32_t code = buildRequest(pRequest->pTscObj->id, pRequest->sqlstr, sqlLen, streamName, false, &pRequestNew, 0);
  if (code != TSDB_CODE_SUCCESS) {
    tscError("[create stream with histroy] create in second phase, build request failed since %s", tstrerror(code));
    return;
  }
  pRequestNew->source = pRequest->source;
  pRequestNew->body.queryFp = processCreateStreamSecondPhaseRsp;
  pRequestNew->streamRunHistory = true;
  doAsyncQuery(pRequestNew, false);
}

int32_t processCreateStreamFirstPhaseRsp(void* param, SDataBuf* pMsg, int32_t code) {
  SRequestObj* pRequest = param;
  if (code != TSDB_CODE_SUCCESS) {
    setErrno(pRequest, code);
  }

  if (NEED_CLIENT_RM_TBLMETA_REQ(pRequest->type)) {
    if (removeMeta(pRequest->pTscObj, pRequest->targetTableList, IS_VIEW_REQUEST(pRequest->type)) != 0) {
      tscError("failed to remove meta data for table");
    }
  }

  taosMemoryFree(pMsg->pData);
  taosMemoryFree(pMsg->pEpSet);

  if (code == 0 && !pRequest->streamRunHistory && tsStreamRunHistoryAsync){
    processCreateStreamSecondPhase(pRequest);
  }
  
  if (pRequest->body.queryFp != NULL) {
    pRequest->body.queryFp(((SSyncQueryParam*)pRequest->body.interParam)->userParam, pRequest, code);
  } else {
    if (tsem_post(&pRequest->body.rspSem) != 0) {
      tscError("failed to post semaphore");
    }
  }

  return code;
}

__async_send_cb_fn_t getMsgRspHandle(int32_t msgType) {
  switch (msgType) {
    case TDMT_MND_CONNECT:
      return processConnectRsp;
    case TDMT_MND_CREATE_DB:
      return processCreateDbRsp;
    case TDMT_MND_USE_DB:
      return processUseDbRsp;
    case TDMT_MND_CREATE_STB:
      return processCreateSTableRsp;
    case TDMT_MND_DROP_DB:
      return processDropDbRsp;
    case TDMT_MND_ALTER_STB:
      return processAlterStbRsp;
    case TDMT_MND_SHOW_VARIABLES:
      return processShowVariablesRsp;
    case TDMT_MND_CREATE_STREAM:
      return processCreateStreamFirstPhaseRsp;
    case TDMT_MND_COMPACT_DB:
      return processCompactDbRsp;
    default:
      return genericRspCallback;
  }
}


taosdata / TDengine / #3653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous