796b5d63-faf9-48e9-946d-5f649cf3d172

Committed 05 Mar 2025 05:11AM UTC coverage: 82.27% (+0.4%) from 81.87%

Build # 796b5d63-faf9-48e9-946d-5f649cf3d172

Build Type

push

circleci

Committed by

web-flow

Commit Message

Fix workbook comparisons, cleanup of included headers (#59)

This PR does the following:
1. Fixes issue https://github.com/xlnt-community/xlnt/issues/58. Please
read the issue for detailed infos.
2. Changes / removes a few definitions of `XLNT_API(_INTERNAL)` which
were defined in the wrong places (e.g. `.cpp` file, or in the header
although the function was implemented in the header too).
3. Cleans up many unnecessary or missing headers which I found along the
way.
4. Added `operator!=` to many classes to ease such comparisons and
improve programming experience.

Run Details

103 of 143 new or added lines in 20 files covered. (72.03%)

3 existing lines in 2 files now uncovered.

11554 of 14044 relevant lines covered (82.27%)

1176465.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.62

./source/packaging/uri.cpp

#include <xlnt/packaging/uri.hpp>

namespace xlnt {

uri::uri()
{
}

uri::uri(const std::string &uri_string)
    : path_(uri_string)
{
}

std::string uri::to_string() const
{
    return path_.string();
}

const path &uri::path() const
{
    return path_;
}

bool uri::operator==(const uri &other) const
{
    return to_string() == other.to_string();
}

bool uri::operator!=(const uri &other) const
{
    return !(*this == other);
}

} // namespace xlnt

1	#include <xlnt/packaging/uri.hpp>
2
3	namespace xlnt {
4
5	uri::uri()	7,208✔
6	{
7	}	7,208✔
8
9	uri::uri(const std::string &uri_string)	5,723✔
10	: path_(uri_string)	5,723✔
11	{
12	}	5,723✔
13
14	std::string uri::to_string() const	173,098✔
15	{
16	return path_.string();	173,098✔
17	}
18
19	const path &uri::path() const	55,085✔
20	{
21	return path_;	55,085✔
22	}
23
24	bool uri::operator==(const uri &other) const	86,402✔
25	{
26	return to_string() == other.to_string();	86,402✔
27	}
28
NEW 29	bool uri::operator!=(const uri &other) const	×
30	{
NEW 31	return !(*this == other);	×
32	}
33
34	} // namespace xlnt

xlnt-community / xlnt / 796b5d63-faf9-48e9-946d-5f649cf3d172

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous