#3625

Committed 26 Feb 2025 10:19AM UTC coverage: 63.633% (+0.1%) from 63.485%

Build # #3625

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #29914 from taosdata/feat/TS-5613-3.0

feat:[TS-5613]support bool in cast

Run Details

148738 of 299799 branches covered (49.61%)

Branch coverage included in aggregate %.

233124 of 300297 relevant lines covered (77.63%)

17654074.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.35

/source/libs/stream/src/streamQueue.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "streamInt.h"

#define MAX_STREAM_EXEC_BATCH_NUM 32
#define MAX_SMOOTH_BURST_RATIO    5  // 5 sec

// todo refactor:
// read data from input queue
typedef struct SQueueReader {
  SStreamQueue* pQueue;
  int32_t       taskLevel;
  int32_t       maxBlocks;     // maximum block in one batch
  int32_t       waitDuration;  // maximum wait time to format several block into a batch to process, unit: ms
} SQueueReader;

#define streamQueueCurItem(_q) ((_q)->qItem)

static bool streamTaskExtractAvailableToken(STokenBucket* pBucket, const char* id);
static void streamTaskPutbackToken(STokenBucket* pBucket);
static void streamTaskConsumeQuota(STokenBucket* pBucket, int32_t bytes);

static void streamQueueCleanup(SStreamQueue* pQueue) {
  SStreamQueueItem* qItem = NULL;
  while (1) {
    streamQueueNextItem(pQueue, &qItem);
    if (qItem == NULL) {
      break;
    }
    streamFreeQitem(qItem);
  }
  pQueue->status = STREAM_QUEUE__SUCESS;
}

int32_t streamQueueOpen(int64_t cap, SStreamQueue** pQ) {
  *pQ = NULL;
  int32_t code = 0;

  SStreamQueue* pQueue = taosMemoryCalloc(1, sizeof(SStreamQueue));
  if (pQueue == NULL) {
    return terrno;
  }

  code = taosOpenQueue(&pQueue->pQueue);
  if (code) {
    taosMemoryFreeClear(pQueue);
    return code;
  }

  code = taosAllocateQall(&pQueue->qall);
  if (code) {
    taosCloseQueue(pQueue->pQueue);
    taosMemoryFree(pQueue);
    return code;
  }

  pQueue->status = STREAM_QUEUE__SUCESS;
  taosSetQueueCapacity(pQueue->pQueue, cap);
  taosSetQueueMemoryCapacity(pQueue->pQueue, cap * 1024);

  *pQ = pQueue;
  return code;
}

void streamQueueClose(SStreamQueue* pQueue, int32_t taskId) {
  stDebug("s-task:0x%x free the queue:%p, items in queue:%d", taskId, pQueue->pQueue,
          taosQueueItemSize(pQueue->pQueue));
  streamQueueCleanup(pQueue);

  taosFreeQall(pQueue->qall);
  taosCloseQueue(pQueue->pQueue);
  taosMemoryFree(pQueue);
}

void streamQueueNextItem(SStreamQueue* pQueue, SStreamQueueItem** pItem) {
  *pItem = NULL;
  int8_t flag = atomic_exchange_8(&pQueue->status, STREAM_QUEUE__PROCESSING);

  if (flag == STREAM_QUEUE__FAILED) {
    *pItem = streamQueueCurItem(pQueue);
  } else {
    pQueue->qItem = NULL;
    (void) taosGetQitem(pQueue->qall, &pQueue->qItem);
    if (pQueue->qItem == NULL) {
      (void) taosReadAllQitems(pQueue->pQueue, pQueue->qall);
      (void) taosGetQitem(pQueue->qall, &pQueue->qItem);
    }

    *pItem = streamQueueCurItem(pQueue);
  }
}

void streamQueueProcessSuccess(SStreamQueue* queue) {
  if (atomic_load_8(&queue->status) != STREAM_QUEUE__PROCESSING) {
    stError("invalid queue status:%d, expect:%d", atomic_load_8(&queue->status), STREAM_QUEUE__PROCESSING);
    return;
  }

  queue->qItem = NULL;
  atomic_store_8(&queue->status, STREAM_QUEUE__SUCESS);
}

void streamQueueProcessFail(SStreamQueue* queue) {
  if (atomic_load_8(&queue->status) != STREAM_QUEUE__PROCESSING) {
    stError("invalid queue status:%d, expect:%d", atomic_load_8(&queue->status), STREAM_QUEUE__PROCESSING);
    return;
  }
  atomic_store_8(&queue->status, STREAM_QUEUE__FAILED);
}

bool streamQueueIsFull(const SStreamQueue* pQueue) {
  int32_t numOfItems = streamQueueGetNumOfItems(pQueue);
  if (numOfItems >= STREAM_TASK_QUEUE_CAPACITY) {
    return true;
  }

  return (SIZE_IN_MiB(taosQueueMemorySize(pQueue->pQueue)) >= STREAM_TASK_QUEUE_CAPACITY_IN_SIZE);
}

int32_t streamQueueGetNumOfItems(const SStreamQueue* pQueue) {
  int32_t numOfItems1 = taosQueueItemSize(pQueue->pQueue);
  int32_t numOfItems2 = taosQallItemSize(pQueue->qall);

  return numOfItems1 + numOfItems2;
}

int32_t streamQueueGetNumOfUnAccessedItems(const SStreamQueue* pQueue) {
  int32_t numOfItems1 = taosQueueItemSize(pQueue->pQueue);
  int32_t numOfItems2 = taosQallUnAccessedItemSize(pQueue->qall);

  return numOfItems1 + numOfItems2;
}

int32_t streamQueueGetItemSize(const SStreamQueue* pQueue) {
  return taosQueueMemorySize(pQueue->pQueue) + taosQallUnAccessedMemSize(pQueue->qall);
}

int32_t streamQueueItemGetSize(const SStreamQueueItem* pItem) {
  STaosQnode* p = (STaosQnode*)((char*)pItem - sizeof(STaosQnode));
  return p->dataSize;
}

void streamQueueItemIncSize(const SStreamQueueItem* pItem, int32_t size) {
  STaosQnode* p = (STaosQnode*)((char*)pItem - sizeof(STaosQnode));
  p->dataSize += size;
}

const char* streamQueueItemGetTypeStr(int32_t type) {
  switch (type) {
    case STREAM_INPUT__CHECKPOINT:
      return "checkpoint";
    case STREAM_INPUT__CHECKPOINT_TRIGGER:
      return "checkpoint-trigger";
    case STREAM_INPUT__TRANS_STATE:
      return "trans-state";
    case STREAM_INPUT__REF_DATA_BLOCK:
      return "ref-block";
    default:
      return "datablock";
  }
}

EExtractDataCode streamTaskGetDataFromInputQ(SStreamTask* pTask, SStreamQueueItem** pInput, int32_t* numOfBlocks,
                                             int32_t* blockSize) {
  const char* id = pTask->id.idStr;
  int32_t     taskLevel = pTask->info.taskLevel;

  *pInput = NULL;
  *numOfBlocks = 0;
  *blockSize = 0;

  // no available token in bucket for sink task, let's wait for a little bit
  if (taskLevel == TASK_LEVEL__SINK && (!streamTaskExtractAvailableToken(pTask->outputInfo.pTokenBucket, id))) {
    stDebug("s-task:%s no available token in bucket for sink data, wait for 10ms", id);
    return EXEC_AFTER_IDLE;
  }

  while (1) {
    if (streamTaskShouldPause(pTask) || streamTaskShouldStop(pTask)) {
      stDebug("s-task:%s task should pause, extract input blocks:%d", id, *numOfBlocks);
      return EXEC_CONTINUE;
    }

    SStreamQueueItem* qItem = NULL;
    streamQueueNextItem(pTask->inputq.queue, (SStreamQueueItem**)&qItem);
    if (qItem == NULL) {
      // restore the token to bucket
      if (*numOfBlocks > 0) {
        *blockSize = streamQueueItemGetSize(*pInput);
        if (taskLevel == TASK_LEVEL__SINK) {
          streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);
        }
      } else {
        streamTaskPutbackToken(pTask->outputInfo.pTokenBucket);
      }

      return EXEC_CONTINUE;
    }

    // do not merge blocks for sink node and check point data block
    int8_t type = qItem->type;
    if (type == STREAM_INPUT__CHECKPOINT || type == STREAM_INPUT__CHECKPOINT_TRIGGER ||
        type == STREAM_INPUT__TRANS_STATE || type == STREAM_INPUT__REF_DATA_BLOCK) {
      const char* p = streamQueueItemGetTypeStr(type);

      if (*pInput == NULL) {
        stDebug("s-task:%s %s msg extracted, start to process immediately", id, p);

        // restore the token to bucket in case of checkpoint/trans-state msg
        streamTaskPutbackToken(pTask->outputInfo.pTokenBucket);
        *blockSize = 0;
        *numOfBlocks = 1;
        *pInput = qItem;
        return EXEC_CONTINUE;
      } else {  // previous existed blocks needs to be handle, before handle the checkpoint msg block
        stDebug("s-task:%s %s msg extracted, handle previous blocks, numOfBlocks:%d", id, p, *numOfBlocks);
        *blockSize = streamQueueItemGetSize(*pInput);
        if (taskLevel == TASK_LEVEL__SINK) {
          streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);
        }

        streamQueueProcessFail(pTask->inputq.queue);
        return EXEC_CONTINUE;
      }
    } else {
      if (*pInput == NULL) {
        *pInput = qItem;
      } else { // merge current block failed, let's handle the already merged blocks.
        void*   newRet = NULL;
        int32_t code = streamQueueMergeQueueItem(*pInput, qItem, (SStreamQueueItem**)&newRet);
        if (newRet == NULL) {
          if (code != -1) {
            stError("s-task:%s failed to merge blocks from inputQ, numOfBlocks:%d, code:%s", id, *numOfBlocks,
                    tstrerror(code));
          }

          *blockSize = streamQueueItemGetSize(*pInput);
          if (taskLevel == TASK_LEVEL__SINK) {
            streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);
          }

          streamQueueProcessFail(pTask->inputq.queue);
          return EXEC_CONTINUE;
        }

        *pInput = newRet;
      }

      *numOfBlocks += 1;
      streamQueueProcessSuccess(pTask->inputq.queue);

      if (*numOfBlocks >= MAX_STREAM_EXEC_BATCH_NUM) {
        stDebug("s-task:%s batch size limit:%d reached, start to process blocks", id, MAX_STREAM_EXEC_BATCH_NUM);

        *blockSize = streamQueueItemGetSize(*pInput);
        if (taskLevel == TASK_LEVEL__SINK) {
          streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);
        }

        return EXEC_CONTINUE;
      }
    }
  }
}

int32_t streamTaskPutDataIntoInputQ(SStreamTask* pTask, SStreamQueueItem* pItem) {
  int8_t      type = pItem->type;
  STaosQueue* pQueue = pTask->inputq.queue->pQueue;
  int32_t     total = streamQueueGetNumOfItems(pTask->inputq.queue) + 1;

  if (type == STREAM_INPUT__DATA_SUBMIT) {
    SStreamDataSubmit* px = (SStreamDataSubmit*)pItem;
    if ((pTask->info.taskLevel == TASK_LEVEL__SOURCE) && streamQueueIsFull(pTask->inputq.queue)) {
      double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));
      stTrace(
          "s-task:%s inputQ is full, capacity(size:%d num:%dMiB), current(blocks:%d, size:%.2fMiB) stop to push data",
          pTask->id.idStr, STREAM_TASK_QUEUE_CAPACITY, STREAM_TASK_QUEUE_CAPACITY_IN_SIZE, total, size);
      streamDataSubmitDestroy(px);
      return TSDB_CODE_STREAM_INPUTQ_FULL;
    }

    int32_t msgLen = px->submit.msgLen;
    int64_t ver = px->submit.ver;

    int32_t code = taosWriteQitem(pQueue, pItem);
    if (code != TSDB_CODE_SUCCESS) {
      streamDataSubmitDestroy(px);
      return code;
    }

    double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));

    // use the local variable to avoid the pItem be freed by other threads, since it has been put into queue already.
    stDebug("s-task:%s submit enqueue msgLen:%d ver:%" PRId64 ", total in queue:%d, size:%.2fMiB", pTask->id.idStr,
            msgLen, ver, total, size + SIZE_IN_MiB(msgLen));
  } else if (type == STREAM_INPUT__DATA_BLOCK || type == STREAM_INPUT__REF_DATA_BLOCK) {
    if (streamQueueIsFull(pTask->inputq.queue)) {
      double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));

      stTrace("s-task:%s input queue is full, capacity:%d size:%d MiB, current(blocks:%d, size:%.2fMiB) abort",
              pTask->id.idStr, STREAM_TASK_QUEUE_CAPACITY, STREAM_TASK_QUEUE_CAPACITY_IN_SIZE, total, size);
      streamFreeQitem(pItem);
      return TSDB_CODE_STREAM_INPUTQ_FULL;
    }

    int32_t code = taosWriteQitem(pQueue, pItem);
    if (code != TSDB_CODE_SUCCESS) {
      streamFreeQitem(pItem);
      return code;
    }

    double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));
    stDebug("s-task:%s blockdata enqueue, total in queue:%d, size:%.2fMiB", pTask->id.idStr, total, size);
  } else if (type == STREAM_INPUT__CHECKPOINT || type == STREAM_INPUT__CHECKPOINT_TRIGGER ||
             type == STREAM_INPUT__TRANS_STATE || type == STREAM_INPUT__DATA_RETRIEVE) {
    int32_t code = taosWriteQitem(pQueue, pItem);
    if (code != TSDB_CODE_SUCCESS) {
      streamFreeQitem(pItem);
      return code;
    }

    double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));
    stDebug("s-task:%s level:%d %s blockdata enqueue, total in queue:%d, size:%.2fMiB", pTask->id.idStr,
            pTask->info.taskLevel, streamQueueItemGetTypeStr(type), total, size);
  } else if (type == STREAM_INPUT__GET_RES) {
    // use the default memory limit, refactor later.
    int32_t code = taosWriteQitem(pQueue, pItem);
    if (code != TSDB_CODE_SUCCESS) {
      streamFreeQitem(pItem);
      return code;
    }

    double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));
    stDebug("s-task:%s data res enqueue, current(blocks:%d, size:%.2fMiB)", pTask->id.idStr, total, size);
  } else {
    stError("s-task:%s invalid type:%d to put in inputQ", pTask->id.idStr, type);
    return TSDB_CODE_INVALID_PARA;
  }

  if (type != STREAM_INPUT__GET_RES && type != STREAM_INPUT__CHECKPOINT && type != STREAM_INPUT__CHECKPOINT_TRIGGER &&
      (pTask->info.delaySchedParam != 0)) {
    (void)atomic_val_compare_exchange_8(&pTask->schedInfo.status, TASK_TRIGGER_STATUS__INACTIVE,
                                        TASK_TRIGGER_STATUS__MAY_ACTIVE);
    stDebug("s-task:%s new data arrived, active the sched-trigger, triggerStatus:%d", pTask->id.idStr,
            pTask->schedInfo.status);
  }

  return 0;
}

int32_t streamTaskPutTranstateIntoInputQ(SStreamTask* pTask) {
  int32_t           code = 0;
  SStreamDataBlock* pTranstate = NULL;
  SSDataBlock*      pBlock = NULL;

  code = taosAllocateQitem(sizeof(SStreamDataBlock), DEF_QITEM, sizeof(SSDataBlock), (void**)&pTranstate);
  if (code) {
    return code;
  }

  pBlock = taosMemoryCalloc(1, sizeof(SSDataBlock));
  if (pBlock == NULL) {
    code = terrno;
    goto _err;
  }

  pTranstate->type = STREAM_INPUT__TRANS_STATE;

  pBlock->info.type = STREAM_TRANS_STATE;
  pBlock->info.rows = 1;
  pBlock->info.childId = pTask->info.selfChildId;

  pTranstate->blocks = taosArrayInit(4, sizeof(SSDataBlock));  // pBlock;
  if (pTranstate->blocks == NULL) {
    code = terrno;
    goto _err;
  }

  void* p = taosArrayPush(pTranstate->blocks, pBlock);
  if (p == NULL) {
    code = terrno;
    goto _err;
  }

  taosMemoryFree(pBlock);
  if (streamTaskPutDataIntoInputQ(pTask, (SStreamQueueItem*)pTranstate) < 0) {
    code = TSDB_CODE_OUT_OF_MEMORY;
    goto _err;
  }

  pTask->status.appendTranstateBlock = true;
  return TSDB_CODE_SUCCESS;

_err:
  taosMemoryFree(pBlock);
  taosFreeQitem(pTranstate);
  return code;
}

// the result should be put into the outputQ in any cases, the result may be lost otherwise.
int32_t streamTaskPutDataIntoOutputQ(SStreamTask* pTask, SStreamDataBlock* pBlock) {
  STaosQueue* pQueue = pTask->outputq.queue->pQueue;
  int32_t     code = taosWriteQitem(pQueue, pBlock);

  int32_t total = streamQueueGetNumOfItems(pTask->outputq.queue);
  double  size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));
  if (code != 0) {
    stError("s-task:%s failed to put res into outputQ, outputQ items:%d, size:%.2fMiB code:%s, result lost",
            pTask->id.idStr, total + 1, size, tstrerror(code));
  } else {
    if (streamQueueIsFull(pTask->outputq.queue)) {
      stWarn(
          "s-task:%s outputQ is full(outputQ items:%d, size:%.2fMiB), set the output status BLOCKING, wait for 500ms "
          "after handle this batch of blocks",
          pTask->id.idStr, total, size);
    } else {
      stDebug("s-task:%s data put into outputQ, outputQ items:%d, size:%.2fMiB", pTask->id.idStr, total, size);
    }
  }

  return code;
}

int32_t streamTaskInitTokenBucket(STokenBucket* pBucket, int32_t numCap, int32_t numRate, float quotaRate,
                                  const char* id) {
  if (numCap < 10 || numRate < 10 || pBucket == NULL) {
    stError("failed to init sink task bucket, cap:%d, rate:%d", numCap, numRate);
    return TSDB_CODE_INVALID_PARA;
  }

  pBucket->numCapacity = numCap;
  pBucket->numOfToken = numCap;
  pBucket->numRate = numRate;

  pBucket->quotaRate = quotaRate;
  pBucket->quotaCapacity = quotaRate * MAX_SMOOTH_BURST_RATIO;
  pBucket->quotaRemain = pBucket->quotaCapacity;

  pBucket->tokenFillTimestamp = taosGetTimestampMs();
  pBucket->quotaFillTimestamp = taosGetTimestampMs();
  stDebug("s-task:%s sink quotaRate:%.2fMiB, numRate:%d", id, quotaRate, numRate);
  return TSDB_CODE_SUCCESS;
}

static void fillTokenBucket(STokenBucket* pBucket, const char* id) {
  int64_t now = taosGetTimestampMs();

  int64_t deltaToken = now - pBucket->tokenFillTimestamp;
  if (pBucket->numOfToken < 0) {
    return;
  }

  int32_t incNum = (deltaToken / 1000.0) * pBucket->numRate;
  if (incNum > 0) {
    pBucket->numOfToken = TMIN(pBucket->numOfToken + incNum, pBucket->numCapacity);
    pBucket->tokenFillTimestamp = now;
  }

  // increase the new available quota as time goes on
  int64_t deltaQuota = now - pBucket->quotaFillTimestamp;
  double  incSize = (deltaQuota / 1000.0) * pBucket->quotaRate;
  if (incSize > 0) {
    pBucket->quotaRemain = TMIN(pBucket->quotaRemain + incSize, pBucket->quotaCapacity);
    pBucket->quotaFillTimestamp = now;
  }

  if (incNum > 0 || incSize > 0) {
    stTrace("token/quota available, token:%d inc:%d, token_TsDelta:%" PRId64
            ", quota:%.2fMiB inc:%.3fMiB quotaTs:%" PRId64 " now:%" PRId64 "ms, %s",
            pBucket->numOfToken, incNum, deltaToken, pBucket->quotaRemain, incSize, deltaQuota, now, id);
  }
}

bool streamTaskExtractAvailableToken(STokenBucket* pBucket, const char* id) {
  fillTokenBucket(pBucket, id);

  if (pBucket->numOfToken > 0) {
    if (pBucket->quotaRemain > 0) {
      pBucket->numOfToken -= 1;
      return true;
    } else {  // no available size quota now
      return false;
    }
  } else {
    return false;
  }
}

void streamTaskPutbackToken(STokenBucket* pBucket) {
  pBucket->numOfToken = TMIN(pBucket->numOfToken + 1, pBucket->numCapacity);
}

// size in KB
void streamTaskConsumeQuota(STokenBucket* pBucket, int32_t bytes) { pBucket->quotaRemain -= SIZE_IN_MiB(bytes); }

void streamTaskInputFail(SStreamTask* pTask) { atomic_store_8(&pTask->inputq.status, TASK_INPUT_STATUS__FAILED); }

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "streamInt.h"
17
18	#define MAX_STREAM_EXEC_BATCH_NUM 32
19	#define MAX_SMOOTH_BURST_RATIO 5 // 5 sec
20
21	// todo refactor:
22	// read data from input queue
23	typedef struct SQueueReader {
24	SStreamQueue* pQueue;
25	int32_t taskLevel;
26	int32_t maxBlocks; // maximum block in one batch
27	int32_t waitDuration; // maximum wait time to format several block into a batch to process, unit: ms
28	} SQueueReader;
29
30	#define streamQueueCurItem(_q) ((_q)->qItem)
31
32	static bool streamTaskExtractAvailableToken(STokenBucket* pBucket, const char* id);
33	static void streamTaskPutbackToken(STokenBucket* pBucket);
34	static void streamTaskConsumeQuota(STokenBucket* pBucket, int32_t bytes);
35
36	static void streamQueueCleanup(SStreamQueue* pQueue) {	29,450✔
37	SStreamQueueItem* qItem = NULL;	29,450✔
38	while (1) {
39	streamQueueNextItem(pQueue, &qItem);	29,728✔
40	if (qItem == NULL) {	29,755✔
41	break;	29,476✔
42	}
43	streamFreeQitem(qItem);	279✔
44	}
45	pQueue->status = STREAM_QUEUE__SUCESS;	29,476✔
46	}	29,476✔
47
48	int32_t streamQueueOpen(int64_t cap, SStreamQueue** pQ) {	29,441✔
49	*pQ = NULL;	29,441✔
50	int32_t code = 0;	29,441✔
51
52	SStreamQueue* pQueue = taosMemoryCalloc(1, sizeof(SStreamQueue));	29,441!
53	if (pQueue == NULL) {	29,477!
54	return terrno;	×
55	}
56
57	code = taosOpenQueue(&pQueue->pQueue);	29,477✔
58	if (code) {	29,459!
59	taosMemoryFreeClear(pQueue);	×
60	return code;	×
61	}
62
63	code = taosAllocateQall(&pQueue->qall);	29,459✔
64	if (code) {	29,478!
65	taosCloseQueue(pQueue->pQueue);	×
66	taosMemoryFree(pQueue);	×
67	return code;	×
68	}
69
70	pQueue->status = STREAM_QUEUE__SUCESS;	29,478✔
71	taosSetQueueCapacity(pQueue->pQueue, cap);	29,478✔
72	taosSetQueueMemoryCapacity(pQueue->pQueue, cap * 1024);	29,466✔
73
74	*pQ = pQueue;	29,468✔
75	return code;	29,468✔
76	}
77
78	void streamQueueClose(SStreamQueue* pQueue, int32_t taskId) {	29,452✔
79	stDebug("s-task:0x%x free the queue:%p, items in queue:%d", taskId, pQueue->pQueue,	29,452✔
80	taosQueueItemSize(pQueue->pQueue));
81	streamQueueCleanup(pQueue);	29,452✔
82
83	taosFreeQall(pQueue->qall);	29,463✔
84	taosCloseQueue(pQueue->pQueue);	29,473✔
85	taosMemoryFree(pQueue);	29,477!
86	}	29,481✔
87
88	void streamQueueNextItem(SStreamQueue* pQueue, SStreamQueueItem** pItem) {	715,336✔
89	*pItem = NULL;	715,336✔
90	int8_t flag = atomic_exchange_8(&pQueue->status, STREAM_QUEUE__PROCESSING);	715,336✔
91
92	if (flag == STREAM_QUEUE__FAILED) {	715,530✔
93	*pItem = streamQueueCurItem(pQueue);	3,450✔
94	} else {
95	pQueue->qItem = NULL;	712,080✔
96	(void) taosGetQitem(pQueue->qall, &pQueue->qItem);	712,080✔
97	if (pQueue->qItem == NULL) {	712,052✔
98	(void) taosReadAllQitems(pQueue->pQueue, pQueue->qall);	254,328✔
99	(void) taosGetQitem(pQueue->qall, &pQueue->qItem);	254,400✔
100	}
101
102	*pItem = streamQueueCurItem(pQueue);	712,090✔
103	}
104	}	715,540✔
105
106	void streamQueueProcessSuccess(SStreamQueue* queue) {	494,239✔
107	if (atomic_load_8(&queue->status) != STREAM_QUEUE__PROCESSING) {	494,239!
108	stError("invalid queue status:%d, expect:%d", atomic_load_8(&queue->status), STREAM_QUEUE__PROCESSING);	×
109	return;	×
110	}
111
112	queue->qItem = NULL;	494,233✔
113	atomic_store_8(&queue->status, STREAM_QUEUE__SUCESS);	494,233✔
114	}
115
116	void streamQueueProcessFail(SStreamQueue* queue) {	3,450✔
117	if (atomic_load_8(&queue->status) != STREAM_QUEUE__PROCESSING) {	3,450!
118	stError("invalid queue status:%d, expect:%d", atomic_load_8(&queue->status), STREAM_QUEUE__PROCESSING);	×
119	return;	×
120	}
121	atomic_store_8(&queue->status, STREAM_QUEUE__FAILED);	3,450✔
122	}
123
124	bool streamQueueIsFull(const SStreamQueue* pQueue) {	758,972✔
125	int32_t numOfItems = streamQueueGetNumOfItems(pQueue);	758,972✔
126	if (numOfItems >= STREAM_TASK_QUEUE_CAPACITY) {	759,148!
127	return true;	×
128	}
129
130	return (SIZE_IN_MiB(taosQueueMemorySize(pQueue->pQueue)) >= STREAM_TASK_QUEUE_CAPACITY_IN_SIZE);	759,148✔
131	}
132
133	int32_t streamQueueGetNumOfItems(const SStreamQueue* pQueue) {	1,514,205✔
134	int32_t numOfItems1 = taosQueueItemSize(pQueue->pQueue);	1,514,205✔
135	int32_t numOfItems2 = taosQallItemSize(pQueue->qall);	1,514,792✔
136
137	return numOfItems1 + numOfItems2;	1,514,720✔
138	}
139
140	int32_t streamQueueGetNumOfUnAccessedItems(const SStreamQueue* pQueue) {	56,082✔
141	int32_t numOfItems1 = taosQueueItemSize(pQueue->pQueue);	56,082✔
142	int32_t numOfItems2 = taosQallUnAccessedItemSize(pQueue->qall);	56,085✔
143
144	return numOfItems1 + numOfItems2;	56,085✔
145	}
146
147	int32_t streamQueueGetItemSize(const SStreamQueue* pQueue) {	63,478✔
148	return taosQueueMemorySize(pQueue->pQueue) + taosQallUnAccessedMemSize(pQueue->qall);	63,478✔
149	}
150
151	int32_t streamQueueItemGetSize(const SStreamQueueItem* pItem) {	494,225✔
152	STaosQnode* p = (STaosQnode)((char)pItem - sizeof(STaosQnode));	494,225✔
153	return p->dataSize;	494,225✔
154	}
155
156	void streamQueueItemIncSize(const SStreamQueueItem* pItem, int32_t size) {	436,738✔
157	STaosQnode* p = (STaosQnode)((char)pItem - sizeof(STaosQnode));	436,738✔
158	p->dataSize += size;	436,738✔
159	}	436,738✔
160
161	const char* streamQueueItemGetTypeStr(int32_t type) {	74,655✔
162	switch (type) {	74,655✔
163	case STREAM_INPUT__CHECKPOINT:	4,763✔
164	return "checkpoint";	4,763✔
165	case STREAM_INPUT__CHECKPOINT_TRIGGER:	18,944✔
166	return "checkpoint-trigger";	18,944✔
167	case STREAM_INPUT__TRANS_STATE:	16,282✔
168	return "trans-state";	16,282✔
169	case STREAM_INPUT__REF_DATA_BLOCK:	5,981✔
170	return "ref-block";	5,981✔
171	default:	28,685✔
172	return "datablock";	28,685✔
173	}
174	}
175
176	EExtractDataCode streamTaskGetDataFromInputQ(SStreamTask* pTask, SStreamQueueItem** pInput, int32_t* numOfBlocks,	151,446✔
177	int32_t* blockSize) {
178	const char* id = pTask->id.idStr;	151,446✔
179	int32_t taskLevel = pTask->info.taskLevel;	151,446✔
180
181	*pInput = NULL;	151,446✔
182	*numOfBlocks = 0;	151,446✔
183	*blockSize = 0;	151,446✔
184
185	// no available token in bucket for sink task, let's wait for a little bit
186	if (taskLevel == TASK_LEVEL__SINK && (!streamTaskExtractAvailableToken(pTask->outputInfo.pTokenBucket, id))) {	151,446!
187	stDebug("s-task:%s no available token in bucket for sink data, wait for 10ms", id);	×
188	return EXEC_AFTER_IDLE;	×
189	}
190
191	while (1) {	483,014✔
192	if (streamTaskShouldPause(pTask) \|\| streamTaskShouldStop(pTask)) {	634,463!
193	stDebug("s-task:%s task should pause, extract input blocks:%d", id, *numOfBlocks);	×
194	return EXEC_CONTINUE;	151,469✔
195	}
196
197	SStreamQueueItem* qItem = NULL;	634,356✔
198	streamQueueNextItem(pTask->inputq.queue, (SStreamQueueItem**)&qItem);	634,356✔
199	if (qItem == NULL) {	634,530✔
200	// restore the token to bucket
201	if (*numOfBlocks > 0) {	110,498✔
202	blockSize = streamQueueItemGetSize(pInput);	42,804✔
203	if (taskLevel == TASK_LEVEL__SINK) {	42,797✔
204	streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);	16,071✔
205	}
206	} else {
207	streamTaskPutbackToken(pTask->outputInfo.pTokenBucket);	67,694✔
208	}
209
210	return EXEC_CONTINUE;	110,458✔
211	}
212
213	// do not merge blocks for sink node and check point data block
214	int8_t type = qItem->type;	524,032✔
215	if (type == STREAM_INPUT__CHECKPOINT \|\| type == STREAM_INPUT__CHECKPOINT_TRIGGER \|\|	524,032✔
216	type == STREAM_INPUT__TRANS_STATE \|\| type == STREAM_INPUT__REF_DATA_BLOCK) {	498,988✔
217	const char* p = streamQueueItemGetTypeStr(type);	29,626✔
218
219	if (*pInput == NULL) {	29,617✔
220	stDebug("s-task:%s %s msg extracted, start to process immediately", id, p);	26,314✔
221
222	// restore the token to bucket in case of checkpoint/trans-state msg
223	streamTaskPutbackToken(pTask->outputInfo.pTokenBucket);	26,314✔
224	*blockSize = 0;	26,311✔
225	*numOfBlocks = 1;	26,311✔
226	*pInput = qItem;	26,311✔
227	return EXEC_CONTINUE;	26,311✔
228	} else { // previous existed blocks needs to be handle, before handle the checkpoint msg block
229	stDebug("s-task:%s %s msg extracted, handle previous blocks, numOfBlocks:%d", id, p, *numOfBlocks);	3,303✔
230	blockSize = streamQueueItemGetSize(pInput);	3,303✔
231	if (taskLevel == TASK_LEVEL__SINK) {	3,302✔
232	streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);	996✔
233	}
234
235	streamQueueProcessFail(pTask->inputq.queue);	3,302✔
236	return EXEC_CONTINUE;	3,302✔
237	}
238	} else {
239	if (*pInput == NULL) {	494,406✔
240	*pInput = qItem;	57,488✔
241	} else { // merge current block failed, let's handle the already merged blocks.
242	void* newRet = NULL;	436,918✔
243	int32_t code = streamQueueMergeQueueItem(pInput, qItem, (SStreamQueueItem*)&newRet);	436,918✔
244	if (newRet == NULL) {	436,912✔
245	if (code != -1) {	150!
246	stError("s-task:%s failed to merge blocks from inputQ, numOfBlocks:%d, code:%s", id, *numOfBlocks,	×
247	tstrerror(code));
248	}
249
250	blockSize = streamQueueItemGetSize(pInput);	150✔
251	if (taskLevel == TASK_LEVEL__SINK) {	148!
252	streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);	×
253	}
254
255	streamQueueProcessFail(pTask->inputq.queue);	148✔
256	return EXEC_CONTINUE;	148✔
257	}
258
259	*pInput = newRet;	436,762✔
260	}
261
262	*numOfBlocks += 1;	494,250✔
263	streamQueueProcessSuccess(pTask->inputq.queue);	494,250✔
264
265	if (*numOfBlocks >= MAX_STREAM_EXEC_BATCH_NUM) {	494,266✔
266	stDebug("s-task:%s batch size limit:%d reached, start to process blocks", id, MAX_STREAM_EXEC_BATCH_NUM);	11,252✔
267
268	blockSize = streamQueueItemGetSize(pInput);	11,252✔
269	if (taskLevel == TASK_LEVEL__SINK) {	11,250✔
270	streamTaskConsumeQuota(pTask->outputInfo.pTokenBucket, *blockSize);	16✔
271	}
272
273	return EXEC_CONTINUE;	11,250✔
274	}
275	}
276	}
277	}
278
279	int32_t streamTaskPutDataIntoInputQ(SStreamTask* pTask, SStreamQueueItem* pItem) {	520,822✔
280	int8_t type = pItem->type;	520,822✔
281	STaosQueue* pQueue = pTask->inputq.queue->pQueue;	520,822✔
282	int32_t total = streamQueueGetNumOfItems(pTask->inputq.queue) + 1;	520,822✔
283
284	if (type == STREAM_INPUT__DATA_SUBMIT) {	520,845✔
285	SStreamDataSubmit* px = (SStreamDataSubmit*)pItem;	444,259✔
286	if ((pTask->info.taskLevel == TASK_LEVEL__SOURCE) && streamQueueIsFull(pTask->inputq.queue)) {	444,259✔
287	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	14✔
288	stTrace(	14!
289	"s-task:%s inputQ is full, capacity(size:%d num:%dMiB), current(blocks:%d, size:%.2fMiB) stop to push data",
290	pTask->id.idStr, STREAM_TASK_QUEUE_CAPACITY, STREAM_TASK_QUEUE_CAPACITY_IN_SIZE, total, size);
291	streamDataSubmitDestroy(px);	14✔
292	return TSDB_CODE_STREAM_INPUTQ_FULL;	14✔
293	}
294
295	int32_t msgLen = px->submit.msgLen;	444,244✔
296	int64_t ver = px->submit.ver;	444,244✔
297
298	int32_t code = taosWriteQitem(pQueue, pItem);	444,244✔
299	if (code != TSDB_CODE_SUCCESS) {	444,253!
300	streamDataSubmitDestroy(px);	×
301	return code;	×
302	}
303
304	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	444,253✔
305
306	// use the local variable to avoid the pItem be freed by other threads, since it has been put into queue already.
307	stDebug("s-task:%s submit enqueue msgLen:%d ver:%" PRId64 ", total in queue:%d, size:%.2fMiB", pTask->id.idStr,	444,247✔
308	msgLen, ver, total, size + SIZE_IN_MiB(msgLen));
309	} else if (type == STREAM_INPUT__DATA_BLOCK \|\| type == STREAM_INPUT__REF_DATA_BLOCK) {	124,110✔
310	if (streamQueueIsFull(pTask->inputq.queue)) {	47,527!
311	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	×
312
313	stTrace("s-task:%s input queue is full, capacity:%d size:%d MiB, current(blocks:%d, size:%.2fMiB) abort",	×
314	pTask->id.idStr, STREAM_TASK_QUEUE_CAPACITY, STREAM_TASK_QUEUE_CAPACITY_IN_SIZE, total, size);
315	streamFreeQitem(pItem);	×
316	return TSDB_CODE_STREAM_INPUTQ_FULL;	×
317	}
318
319	int32_t code = taosWriteQitem(pQueue, pItem);	47,525✔
320	if (code != TSDB_CODE_SUCCESS) {	47,525!
321	streamFreeQitem(pItem);	×
322	return code;	×
323	}
324
325	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	47,525✔
326	stDebug("s-task:%s blockdata enqueue, total in queue:%d, size:%.2fMiB", pTask->id.idStr, total, size);	47,524✔
327	} else if (type == STREAM_INPUT__CHECKPOINT \|\| type == STREAM_INPUT__CHECKPOINT_TRIGGER \|\|	29,059✔
328	type == STREAM_INPUT__TRANS_STATE \|\| type == STREAM_INPUT__DATA_RETRIEVE) {	29,606✔
329	int32_t code = taosWriteQitem(pQueue, pItem);	24,417✔
330	if (code != TSDB_CODE_SUCCESS) {	24,419!
331	streamFreeQitem(pItem);	×
332	return code;	×
333	}
334
335	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	24,419✔
336	stDebug("s-task:%s level:%d %s blockdata enqueue, total in queue:%d, size:%.2fMiB", pTask->id.idStr,	24,420✔
337	pTask->info.taskLevel, streamQueueItemGetTypeStr(type), total, size);
338	} else if (type == STREAM_INPUT__GET_RES) {	4,642!
339	// use the default memory limit, refactor later.
340	int32_t code = taosWriteQitem(pQueue, pItem);	4,642✔
341	if (code != TSDB_CODE_SUCCESS) {	4,642!
342	streamFreeQitem(pItem);	×
343	return code;	×
344	}
345
346	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	4,642✔
347	stDebug("s-task:%s data res enqueue, current(blocks:%d, size:%.2fMiB)", pTask->id.idStr, total, size);	4,642✔
348	} else {
349	stError("s-task:%s invalid type:%d to put in inputQ", pTask->id.idStr, type);	×
350	return TSDB_CODE_INVALID_PARA;	×
351	}
352
353	if (type != STREAM_INPUT__GET_RES && type != STREAM_INPUT__CHECKPOINT && type != STREAM_INPUT__CHECKPOINT_TRIGGER &&	520,834✔
354	(pTask->info.delaySchedParam != 0)) {	501,442✔
355	(void)atomic_val_compare_exchange_8(&pTask->schedInfo.status, TASK_TRIGGER_STATUS__INACTIVE,	11,563✔
356	TASK_TRIGGER_STATUS__MAY_ACTIVE);
357	stDebug("s-task:%s new data arrived, active the sched-trigger, triggerStatus:%d", pTask->id.idStr,	11,563✔
358	pTask->schedInfo.status);
359	}
360
361	return 0;	520,828✔
362	}
363
364	int32_t streamTaskPutTranstateIntoInputQ(SStreamTask* pTask) {	2,241✔
365	int32_t code = 0;	2,241✔
366	SStreamDataBlock* pTranstate = NULL;	2,241✔
367	SSDataBlock* pBlock = NULL;	2,241✔
368
369	code = taosAllocateQitem(sizeof(SStreamDataBlock), DEF_QITEM, sizeof(SSDataBlock), (void**)&pTranstate);	2,241✔
370	if (code) {	2,241!
371	return code;	×
372	}
373
374	pBlock = taosMemoryCalloc(1, sizeof(SSDataBlock));	2,241!
375	if (pBlock == NULL) {	2,240!
376	code = terrno;	×
377	goto _err;	×
378	}
379
380	pTranstate->type = STREAM_INPUT__TRANS_STATE;	2,240✔
381
382	pBlock->info.type = STREAM_TRANS_STATE;	2,240✔
383	pBlock->info.rows = 1;	2,240✔
384	pBlock->info.childId = pTask->info.selfChildId;	2,240✔
385
386	pTranstate->blocks = taosArrayInit(4, sizeof(SSDataBlock)); // pBlock;	2,240✔
387	if (pTranstate->blocks == NULL) {	2,241!
388	code = terrno;	×
389	goto _err;	×
390	}
391
392	void* p = taosArrayPush(pTranstate->blocks, pBlock);	2,241✔
393	if (p == NULL) {	2,241!
394	code = terrno;	×
395	goto _err;	×
396	}
397
398	taosMemoryFree(pBlock);	2,241!
399	if (streamTaskPutDataIntoInputQ(pTask, (SStreamQueueItem*)pTranstate) < 0) {	2,240!
400	code = TSDB_CODE_OUT_OF_MEMORY;	×
401	goto _err;	×
402	}
403
404	pTask->status.appendTranstateBlock = true;	2,240✔
405	return TSDB_CODE_SUCCESS;	2,240✔
406
407	_err:	×
408	taosMemoryFree(pBlock);	×
409	taosFreeQitem(pTranstate);	×
410	return code;	×
411	}
412
413	// the result should be put into the outputQ in any cases, the result may be lost otherwise.
414	int32_t streamTaskPutDataIntoOutputQ(SStreamTask* pTask, SStreamDataBlock* pBlock) {	23,763✔
415	STaosQueue* pQueue = pTask->outputq.queue->pQueue;	23,763✔
416	int32_t code = taosWriteQitem(pQueue, pBlock);	23,763✔
417
418	int32_t total = streamQueueGetNumOfItems(pTask->outputq.queue);	23,764✔
419	double size = SIZE_IN_MiB(taosQueueMemorySize(pQueue));	23,764✔
420	if (code != 0) {	23,766!
421	stError("s-task:%s failed to put res into outputQ, outputQ items:%d, size:%.2fMiB code:%s, result lost",	×
422	pTask->id.idStr, total + 1, size, tstrerror(code));
423	} else {
424	if (streamQueueIsFull(pTask->outputq.queue)) {	23,766!
425	stWarn(	×
426	"s-task:%s outputQ is full(outputQ items:%d, size:%.2fMiB), set the output status BLOCKING, wait for 500ms "
427	"after handle this batch of blocks",
428	pTask->id.idStr, total, size);
429	} else {
430	stDebug("s-task:%s data put into outputQ, outputQ items:%d, size:%.2fMiB", pTask->id.idStr, total, size);	23,766✔
431	}
432	}
433
434	return code;	23,764✔
435	}
436
437	int32_t streamTaskInitTokenBucket(STokenBucket* pBucket, int32_t numCap, int32_t numRate, float quotaRate,	14,727✔
438	const char* id) {
439	if (numCap < 10 \|\| numRate < 10 \|\| pBucket == NULL) {	14,727!
440	stError("failed to init sink task bucket, cap:%d, rate:%d", numCap, numRate);	×
441	return TSDB_CODE_INVALID_PARA;	×
442	}
443
444	pBucket->numCapacity = numCap;	14,738✔
445	pBucket->numOfToken = numCap;	14,738✔
446	pBucket->numRate = numRate;	14,738✔
447
448	pBucket->quotaRate = quotaRate;	14,738✔
449	pBucket->quotaCapacity = quotaRate * MAX_SMOOTH_BURST_RATIO;	14,738✔
450	pBucket->quotaRemain = pBucket->quotaCapacity;	14,738✔
451
452	pBucket->tokenFillTimestamp = taosGetTimestampMs();	14,736✔
453	pBucket->quotaFillTimestamp = taosGetTimestampMs();	14,739✔
454	stDebug("s-task:%s sink quotaRate:%.2fMiB, numRate:%d", id, quotaRate, numRate);	14,739✔
455	return TSDB_CODE_SUCCESS;	14,739✔
456	}
457
458	static void fillTokenBucket(STokenBucket* pBucket, const char* id) {	56,882✔
459	int64_t now = taosGetTimestampMs();	56,880✔
460
461	int64_t deltaToken = now - pBucket->tokenFillTimestamp;	56,880✔
462	if (pBucket->numOfToken < 0) {	56,880!
463	return;	×
464	}
465
466	int32_t incNum = (deltaToken / 1000.0) * pBucket->numRate;	56,880✔
467	if (incNum > 0) {	56,880✔
468	pBucket->numOfToken = TMIN(pBucket->numOfToken + incNum, pBucket->numCapacity);	29,297✔
469	pBucket->tokenFillTimestamp = now;	29,297✔
470	}
471
472	// increase the new available quota as time goes on
473	int64_t deltaQuota = now - pBucket->quotaFillTimestamp;	56,880✔
474	double incSize = (deltaQuota / 1000.0) * pBucket->quotaRate;	56,880✔
475	if (incSize > 0) {	56,880✔
476	pBucket->quotaRemain = TMIN(pBucket->quotaRemain + incSize, pBucket->quotaCapacity);	38,137✔
477	pBucket->quotaFillTimestamp = now;	38,137✔
478	}
479
480	if (incNum > 0 \|\| incSize > 0) {	56,880✔
481	stTrace("token/quota available, token:%d inc:%d, token_TsDelta:%" PRId64	38,112✔
482	", quota:%.2fMiB inc:%.3fMiB quotaTs:%" PRId64 " now:%" PRId64 "ms, %s",
483	pBucket->numOfToken, incNum, deltaToken, pBucket->quotaRemain, incSize, deltaQuota, now, id);
484	}
485	}
486
487	bool streamTaskExtractAvailableToken(STokenBucket* pBucket, const char* id) {	56,881✔
488	fillTokenBucket(pBucket, id);	56,881✔
489
490	if (pBucket->numOfToken > 0) {	56,896!
491	if (pBucket->quotaRemain > 0) {	56,898!
492	pBucket->numOfToken -= 1;	56,898✔
493	return true;	56,898✔
494	} else { // no available size quota now
495	return false;	×
496	}
497	} else {
498	return false;	×
499	}
500	}
501
502	void streamTaskPutbackToken(STokenBucket* pBucket) {	93,972✔
503	pBucket->numOfToken = TMIN(pBucket->numOfToken + 1, pBucket->numCapacity);	93,972✔
504	}	93,972✔
505
506	// size in KB
507	void streamTaskConsumeQuota(STokenBucket* pBucket, int32_t bytes) { pBucket->quotaRemain -= SIZE_IN_MiB(bytes); }	17,084✔
508
509	void streamTaskInputFail(SStreamTask* pTask) { atomic_store_8(&pTask->inputq.status, TASK_INPUT_STATUS__FAILED); }	×

taosdata / TDengine / #3625

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous