• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3608

12 Feb 2025 05:57AM UTC coverage: 63.066% (+1.4%) from 61.715%
#3608

push

travis-ci

web-flow
Merge pull request #29746 from taosdata/merge/mainto3.02

merge: from main to 3.0 branch

140199 of 286257 branches covered (48.98%)

Branch coverage included in aggregate %.

89 of 161 new or added lines in 18 files covered. (55.28%)

3211 existing lines in 190 files now uncovered.

218998 of 283298 relevant lines covered (77.3%)

5949310.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.61
/source/dnode/mgmt/mgmt_vnode/src/vmFile.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http:www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "tjson.h"
18
#include "vmInt.h"
19

20
#define MAX_CONTENT_LEN 2 * 1024 * 1024
21

22
int32_t vmGetAllVnodeListFromHash(SVnodeMgmt *pMgmt, int32_t *numOfVnodes, SVnodeObj ***ppVnodes) {
15,470✔
23
  (void)taosThreadRwlockRdlock(&pMgmt->lock);
15,470✔
24

25
  int32_t num = 0;
15,470✔
26
  int32_t size = taosHashGetSize(pMgmt->runngingHash);
15,470✔
27
  int32_t closedSize = taosHashGetSize(pMgmt->closedHash);
15,470✔
28
  size += closedSize;
15,470✔
29
  SVnodeObj **pVnodes = taosMemoryCalloc(size, sizeof(SVnodeObj *));
15,470!
30
  if (pVnodes == NULL) {
15,470!
31
    (void)taosThreadRwlockUnlock(&pMgmt->lock);
×
32
    return terrno;
×
33
  }
34

35
  void *pIter = taosHashIterate(pMgmt->runngingHash, NULL);
15,470✔
36
  while (pIter) {
72,906✔
37
    SVnodeObj **ppVnode = pIter;
57,436✔
38
    SVnodeObj  *pVnode = *ppVnode;
57,436✔
39
    if (pVnode && num < size) {
114,872!
40
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
57,436✔
41
      dTrace("vgId:%d,acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
57,436✔
42
      pVnodes[num++] = (*ppVnode);
57,436✔
43
      pIter = taosHashIterate(pMgmt->runngingHash, pIter);
57,436✔
44
    } else {
UNCOV
45
      taosHashCancelIterate(pMgmt->runngingHash, pIter);
×
46
    }
47
  }
48

49
  pIter = taosHashIterate(pMgmt->closedHash, NULL);
15,470✔
50
  while (pIter) {
15,470!
51
    SVnodeObj **ppVnode = pIter;
×
52
    SVnodeObj  *pVnode = *ppVnode;
×
53
    if (pVnode && num < size) {
×
54
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
×
55
      dTrace("vgId:%d, acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
×
56
      pVnodes[num++] = (*ppVnode);
×
57
      pIter = taosHashIterate(pMgmt->closedHash, pIter);
×
58
    } else {
59
      taosHashCancelIterate(pMgmt->closedHash, pIter);
×
60
    }
61
  }
62

63
  (void)taosThreadRwlockUnlock(&pMgmt->lock);
15,470✔
64
  *numOfVnodes = num;
15,470✔
65
  *ppVnodes = pVnodes;
15,470✔
66

67
  return 0;
15,470✔
68
}
69

70
int32_t vmGetAllVnodeListFromHashWithCreating(SVnodeMgmt *pMgmt, int32_t *numOfVnodes, SVnodeObj ***ppVnodes) {
8,576✔
71
  (void)taosThreadRwlockRdlock(&pMgmt->lock);
8,576✔
72

73
  int32_t num = 0;
8,576✔
74
  int32_t size = taosHashGetSize(pMgmt->runngingHash);
8,576✔
75
  int32_t creatingSize = taosHashGetSize(pMgmt->creatingHash);
8,576✔
76
  size += creatingSize;
8,576✔
77
  SVnodeObj **pVnodes = taosMemoryCalloc(size, sizeof(SVnodeObj *));
8,576!
78
  if (pVnodes == NULL) {
8,576!
79
    (void)taosThreadRwlockUnlock(&pMgmt->lock);
×
80
    return terrno;
×
81
  }
82

83
  void *pIter = taosHashIterate(pMgmt->runngingHash, NULL);
8,576✔
84
  while (pIter) {
24,970✔
85
    SVnodeObj **ppVnode = pIter;
16,394✔
86
    SVnodeObj  *pVnode = *ppVnode;
16,394✔
87
    if (pVnode && num < size) {
32,788!
88
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
16,394✔
89
      dTrace("vgId:%d,acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
16,394✔
90
      pVnodes[num++] = (*ppVnode);
16,394✔
91
      pIter = taosHashIterate(pMgmt->runngingHash, pIter);
16,394✔
92
    } else {
93
      taosHashCancelIterate(pMgmt->runngingHash, pIter);
×
94
    }
95
  }
96

97
  pIter = taosHashIterate(pMgmt->creatingHash, NULL);
8,576✔
98
  while (pIter) {
16,611✔
99
    SVnodeObj **ppVnode = pIter;
8,035✔
100
    SVnodeObj  *pVnode = *ppVnode;
8,035✔
101
    if (pVnode && num < size) {
16,070!
102
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
8,035✔
103
      dTrace("vgId:%d, acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
8,035✔
104
      pVnodes[num++] = (*ppVnode);
8,035✔
105
      pIter = taosHashIterate(pMgmt->creatingHash, pIter);
8,035✔
106
    } else {
107
      taosHashCancelIterate(pMgmt->creatingHash, pIter);
×
108
    }
109
  }
110
  (void)taosThreadRwlockUnlock(&pMgmt->lock);
8,576✔
111

112
  *numOfVnodes = num;
8,576✔
113
  *ppVnodes = pVnodes;
8,576✔
114

115
  return 0;
8,576✔
116
}
117

118
int32_t vmGetVnodeListFromHash(SVnodeMgmt *pMgmt, int32_t *numOfVnodes, SVnodeObj ***ppVnodes) {
5,962✔
119
  (void)taosThreadRwlockRdlock(&pMgmt->lock);
5,962✔
120

121
  int32_t     num = 0;
5,962✔
122
  int32_t     size = taosHashGetSize(pMgmt->runngingHash);
5,962✔
123
  SVnodeObj **pVnodes = taosMemoryCalloc(size, sizeof(SVnodeObj *));
5,962!
124
  if (pVnodes == NULL) {
5,962!
125
    (void)taosThreadRwlockUnlock(&pMgmt->lock);
×
126
    return terrno;
×
127
  }
128

129
  void *pIter = taosHashIterate(pMgmt->runngingHash, NULL);
5,962✔
130
  while (pIter) {
17,816✔
131
    SVnodeObj **ppVnode = pIter;
11,854✔
132
    SVnodeObj  *pVnode = *ppVnode;
11,854✔
133
    if (pVnode && num < size) {
23,708!
134
      int32_t refCount = atomic_add_fetch_32(&pVnode->refCount, 1);
11,854✔
135
      dTrace("vgId:%d, acquire vnode, vnode:%p, ref:%d", pVnode->vgId, pVnode, refCount);
11,854✔
136
      pVnodes[num++] = (*ppVnode);
11,854✔
137
      pIter = taosHashIterate(pMgmt->runngingHash, pIter);
11,854✔
138
    } else {
139
      taosHashCancelIterate(pMgmt->runngingHash, pIter);
×
140
    }
141
  }
142

143
  (void)taosThreadRwlockUnlock(&pMgmt->lock);
5,962✔
144
  *numOfVnodes = num;
5,962✔
145
  *ppVnodes = pVnodes;
5,962✔
146

147
  return 0;
5,962✔
148
}
149

150
static int32_t vmDecodeVnodeList(SJson *pJson, SVnodeMgmt *pMgmt, SWrapperCfg **ppCfgs, int32_t *numOfVnodes) {
362✔
151
  int32_t      code = -1;
362✔
152
  SWrapperCfg *pCfgs = NULL;
362✔
153
  *ppCfgs = NULL;
362✔
154

155
  SJson *vnodes = tjsonGetObjectItem(pJson, "vnodes");
362✔
156
  if (vnodes == NULL) return TSDB_CODE_INVALID_JSON_FORMAT;
362!
157

158
  int32_t vnodesNum = cJSON_GetArraySize(vnodes);
362✔
159
  if (vnodesNum > 0) {
362✔
160
    pCfgs = taosMemoryCalloc(vnodesNum, sizeof(SWrapperCfg));
360!
161
    if (pCfgs == NULL) return terrno;
360!
162
  }
163

164
  for (int32_t i = 0; i < vnodesNum; ++i) {
1,291✔
165
    SJson *vnode = tjsonGetArrayItem(vnodes, i);
929✔
166
    if (vnode == NULL) {
929!
167
      code = TSDB_CODE_INVALID_JSON_FORMAT;
×
168
      goto _OVER;
×
169
    }
170

171
    SWrapperCfg *pCfg = &pCfgs[i];
929✔
172
    tjsonGetInt32ValueFromDouble(vnode, "vgId", pCfg->vgId, code);
929✔
173
    if (code != 0) goto _OVER;
929!
174
    tjsonGetInt32ValueFromDouble(vnode, "dropped", pCfg->dropped, code);
929✔
175
    if (code != 0) goto _OVER;
929!
176
    tjsonGetInt32ValueFromDouble(vnode, "vgVersion", pCfg->vgVersion, code);
929✔
177
    if (code != 0) goto _OVER;
929!
178
    tjsonGetInt32ValueFromDouble(vnode, "diskPrimary", pCfg->diskPrimary, code);
929✔
179
    if (code != 0) goto _OVER;
929!
180
    tjsonGetInt32ValueFromDouble(vnode, "toVgId", pCfg->toVgId, code);
929✔
181
    if (code != 0) goto _OVER;
929!
182

183
    snprintf(pCfg->path, sizeof(pCfg->path), "%s%svnode%d", pMgmt->path, TD_DIRSEP, pCfg->vgId);
929✔
184
  }
185

186
  code = 0;
362✔
187
  *ppCfgs = pCfgs;
362✔
188
  *numOfVnodes = vnodesNum;
362✔
189

190
_OVER:
362✔
191
  if (*ppCfgs == NULL) taosMemoryFree(pCfgs);
362!
192
  return code;
362✔
193
}
194

195
int32_t vmGetVnodeListFromFile(SVnodeMgmt *pMgmt, SWrapperCfg **ppCfgs, int32_t *numOfVnodes) {
2,152✔
196
  int32_t      code = -1;
2,152✔
197
  TdFilePtr    pFile = NULL;
2,152✔
198
  char        *pData = NULL;
2,152✔
199
  SJson       *pJson = NULL;
2,152✔
200
  char         file[PATH_MAX] = {0};
2,152✔
201
  SWrapperCfg *pCfgs = NULL;
2,152✔
202
  snprintf(file, sizeof(file), "%s%svnodes.json", pMgmt->path, TD_DIRSEP);
2,152✔
203

204
  if (taosStatFile(file, NULL, NULL, NULL) < 0) {
2,152✔
205
    code = terrno;
1,790✔
206
    dInfo("vnode file:%s not exist, reason:%s", file, tstrerror(code));
1,790!
207
    code = 0;
1,790✔
208
    return code;
1,790✔
209
  }
210

211
  pFile = taosOpenFile(file, TD_FILE_READ);
362✔
212
  if (pFile == NULL) {
362!
213
    code = terrno;
×
214
    dError("failed to open vnode file:%s since %s", file, tstrerror(code));
×
215
    goto _OVER;
×
216
  }
217

218
  int64_t size = 0;
362✔
219
  code = taosFStatFile(pFile, &size, NULL);
362✔
220
  if (code != 0) {
362!
221
    dError("failed to fstat mnode file:%s since %s", file, tstrerror(code));
×
222
    goto _OVER;
×
223
  }
224

225
  pData = taosMemoryMalloc(size + 1);
362!
226
  if (pData == NULL) {
362!
227
    code = terrno;
×
228
    goto _OVER;
×
229
  }
230

231
  if (taosReadFile(pFile, pData, size) != size) {
362!
232
    code = terrno;
×
233
    dError("failed to read vnode file:%s since %s", file, tstrerror(code));
×
234
    goto _OVER;
×
235
  }
236

237
  pData[size] = '\0';
362✔
238

239
  pJson = tjsonParse(pData);
362✔
240
  if (pJson == NULL) {
362!
241
    code = TSDB_CODE_INVALID_JSON_FORMAT;
×
242
    goto _OVER;
×
243
  }
244

245
  if (vmDecodeVnodeList(pJson, pMgmt, ppCfgs, numOfVnodes) < 0) {
362!
246
    code = TSDB_CODE_INVALID_JSON_FORMAT;
×
247
    goto _OVER;
×
248
  }
249

250
  code = 0;
362✔
251
  dInfo("succceed to read vnode file %s", file);
362!
252

253
_OVER:
×
254
  if (pData != NULL) taosMemoryFree(pData);
362!
255
  if (pJson != NULL) cJSON_Delete(pJson);
362!
256
  if (pFile != NULL) taosCloseFile(&pFile);
362!
257

258
  if (code != 0) {
362!
259
    dError("failed to read vnode file:%s since %s", file, tstrerror(code));
×
260
  }
261
  return code;
362✔
262
}
263

264
static int32_t vmEncodeVnodeList(SJson *pJson, SVnodeObj **ppVnodes, int32_t numOfVnodes) {
15,470✔
265
  int32_t code = 0;
15,470✔
266
  SJson  *vnodes = tjsonCreateArray();
15,470✔
267
  if (vnodes == NULL) {
15,470!
268
    return terrno;
×
269
  }
270
  if ((code = tjsonAddItemToObject(pJson, "vnodes", vnodes)) < 0) {
15,470!
271
    tjsonDelete(vnodes);
×
272
    return code;
×
273
  };
274

275
  for (int32_t i = 0; i < numOfVnodes; ++i) {
72,896✔
276
    SVnodeObj *pVnode = ppVnodes[i];
57,428✔
277
    if (pVnode == NULL) continue;
57,428!
278

279
    SJson *vnode = tjsonCreateObject();
57,428✔
280
    if (vnode == NULL) return terrno;
57,431!
281
    if ((code = tjsonAddDoubleToObject(vnode, "vgId", pVnode->vgId)) < 0) return code;
57,431!
282
    if ((code = tjsonAddDoubleToObject(vnode, "dropped", pVnode->dropped)) < 0) return code;
57,431!
283
    if ((code = tjsonAddDoubleToObject(vnode, "vgVersion", pVnode->vgVersion)) < 0) return code;
57,433!
284
    if ((code = tjsonAddDoubleToObject(vnode, "diskPrimary", pVnode->diskPrimary)) < 0) return code;
57,433!
285
    if (pVnode->toVgId) {
57,430✔
286
      if ((code = tjsonAddDoubleToObject(vnode, "toVgId", pVnode->toVgId)) < 0) return code;
30!
287
    }
288
    if ((code = tjsonAddItemToArray(vnodes, vnode)) < 0) return code;
57,430!
289
  }
290

291
  return 0;
15,468✔
292
}
293

294
int32_t vmWriteVnodeListToFile(SVnodeMgmt *pMgmt) {
15,470✔
295
  int32_t     code = -1;
15,470✔
296
  char       *buffer = NULL;
15,470✔
297
  SJson      *pJson = NULL;
15,470✔
298
  TdFilePtr   pFile = NULL;
15,470✔
299
  SVnodeObj **ppVnodes = NULL;
15,470✔
300
  char        file[PATH_MAX] = {0};
15,470✔
301
  char        realfile[PATH_MAX] = {0};
15,470✔
302
  int32_t     lino = 0;
15,470✔
303
  int32_t     ret = -1;
15,470✔
304

305
  int32_t nBytes = snprintf(file, sizeof(file), "%s%svnodes_tmp.json", pMgmt->path, TD_DIRSEP);
15,470✔
306
  if (nBytes <= 0 || nBytes >= sizeof(file)) {
15,470!
307
    return TSDB_CODE_OUT_OF_RANGE;
×
308
  }
309

310
  nBytes = snprintf(realfile, sizeof(realfile), "%s%svnodes.json", pMgmt->path, TD_DIRSEP);
15,470✔
311
  if (nBytes <= 0 || nBytes >= sizeof(realfile)) {
15,470!
312
    return TSDB_CODE_OUT_OF_RANGE;
×
313
  }
314

315
  int32_t numOfVnodes = 0;
15,470✔
316
  TAOS_CHECK_GOTO(vmGetAllVnodeListFromHash(pMgmt, &numOfVnodes, &ppVnodes), &lino, _OVER);
15,470!
317

318
  // terrno = TSDB_CODE_OUT_OF_MEMORY;
319
  pJson = tjsonCreateObject();
15,470✔
320
  if (pJson == NULL) {
15,470!
321
    code = terrno;
×
322
    goto _OVER;
×
323
  }
324
  TAOS_CHECK_GOTO(vmEncodeVnodeList(pJson, ppVnodes, numOfVnodes), &lino, _OVER);
15,470!
325

326
  buffer = tjsonToString(pJson);
15,470✔
327
  if (buffer == NULL) {
15,469!
328
    code = TSDB_CODE_INVALID_JSON_FORMAT;
×
329
    lino = __LINE__;
×
330
    goto _OVER;
×
331
  }
332

333
  code = taosThreadMutexLock(&pMgmt->fileLock);
15,469✔
334
  if (code != 0) {
15,470!
335
    lino = __LINE__;
×
336
    goto _OVER;
×
337
  }
338

339
  pFile = taosOpenFile(file, TD_FILE_CREATE | TD_FILE_WRITE | TD_FILE_TRUNC | TD_FILE_WRITE_THROUGH);
15,470✔
340
  if (pFile == NULL) {
15,470!
341
    code = terrno;
×
342
    lino = __LINE__;
×
343
    goto _OVER1;
×
344
  }
345

346
  int32_t len = strlen(buffer);
15,470✔
347
  if (taosWriteFile(pFile, buffer, len) <= 0) {
15,470!
348
    code = terrno;
×
349
    lino = __LINE__;
×
350
    goto _OVER1;
×
351
  }
352
  if (taosFsyncFile(pFile) < 0) {
15,470!
353
    code = TAOS_SYSTEM_ERROR(errno);
×
354
    lino = __LINE__;
×
355
    goto _OVER1;
×
356
  }
357

358
  code = taosCloseFile(&pFile);
15,470✔
359
  if (code != 0) {
15,470!
360
    code = TAOS_SYSTEM_ERROR(errno);
×
361
    lino = __LINE__;
×
362
    goto _OVER1;
×
363
  }
364
  TAOS_CHECK_GOTO(taosRenameFile(file, realfile), &lino, _OVER1);
15,470!
365

366
  dInfo("succeed to write vnodes file:%s, vnodes:%d", realfile, numOfVnodes);
15,470!
367

368
_OVER1:
×
369
  ret = taosThreadMutexUnlock(&pMgmt->fileLock);
15,470✔
370
  if (ret != 0) {
15,470!
371
    dError("failed to unlock since %s", tstrerror(ret));
×
372
  }
373

374
_OVER:
15,470✔
375
  if (pJson != NULL) tjsonDelete(pJson);
15,470!
376
  if (buffer != NULL) taosMemoryFree(buffer);
15,470!
377
  if (pFile != NULL) taosCloseFile(&pFile);
15,470!
378
  if (ppVnodes != NULL) {
15,470!
379
    for (int32_t i = 0; i < numOfVnodes; ++i) {
72,906✔
380
      SVnodeObj *pVnode = ppVnodes[i];
57,436✔
381
      if (pVnode != NULL) {
57,436!
382
        vmReleaseVnode(pMgmt, pVnode);
57,436✔
383
      }
384
    }
385
    taosMemoryFree(ppVnodes);
15,470!
386
  }
387

388
  if (code != 0) {
15,470!
389
    dError("failed to write vnodes file:%s at line:%d since %s, vnodes:%d", realfile, lino, tstrerror(code),
×
390
           numOfVnodes);
391
  }
392
  return code;
15,470✔
393
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc