• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 13213873811

08 Feb 2025 08:17AM UTC coverage: 22.323%. Remained the same
13213873811

Pull #4973

github

zhangzujian
feature: add support for specifying pod's routes by subnet's .spec.routes

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Pull Request #4973: feature: add support for specifying pod's routes by subnet's .spec.routes

0 of 9 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

10376 of 46481 relevant lines covered (22.32%)

0.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/pkg/daemon/handler.go
1
package daemon
2

3
import (
4
        "context"
5
        "encoding/json"
6
        "fmt"
7
        "net"
8
        "net/http"
9
        "slices"
10
        "strconv"
11
        "time"
12

13
        "github.com/emicklei/go-restful/v3"
14
        v1 "k8s.io/api/core/v1"
15
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
16
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
17
        "k8s.io/apimachinery/pkg/labels"
18
        "k8s.io/client-go/kubernetes"
19
        "k8s.io/klog/v2"
20

21
        kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
22
        clientset "github.com/kubeovn/kube-ovn/pkg/client/clientset/versioned"
23
        "github.com/kubeovn/kube-ovn/pkg/ovs"
24
        "github.com/kubeovn/kube-ovn/pkg/request"
25
        "github.com/kubeovn/kube-ovn/pkg/util"
26
)
27

28
const (
29
        gatewayCheckModeDisabled = iota
30
        gatewayCheckModePing
31
        gatewayCheckModeArping
32
        gatewayCheckModePingNotConcerned
33
        gatewayCheckModeArpingNotConcerned
34
)
35

36
type cniServerHandler struct {
37
        Config        *Configuration
38
        KubeClient    kubernetes.Interface
39
        KubeOvnClient clientset.Interface
40
        Controller    *Controller
41
}
42

43
func createCniServerHandler(config *Configuration, controller *Controller) *cniServerHandler {
×
44
        csh := &cniServerHandler{KubeClient: config.KubeClient, KubeOvnClient: config.KubeOvnClient, Config: config, Controller: controller}
×
45
        return csh
×
46
}
×
47

48
func (csh cniServerHandler) providerExists(provider string) (*kubeovnv1.Subnet, bool) {
×
49
        if util.IsOvnProvider(provider) {
×
50
                return nil, true
×
51
        }
×
52
        subnets, _ := csh.Controller.subnetsLister.List(labels.Everything())
×
53
        for _, subnet := range subnets {
×
54
                if subnet.Spec.Provider == provider {
×
55
                        return subnet.DeepCopy(), true
×
56
                }
×
57
        }
58
        return nil, false
×
59
}
60

61
func (csh cniServerHandler) handleAdd(req *restful.Request, resp *restful.Response) {
×
62
        podRequest := request.CniRequest{}
×
63
        if err := req.ReadEntity(&podRequest); err != nil {
×
64
                errMsg := fmt.Errorf("parse add request failed %w", err)
×
65
                klog.Error(errMsg)
×
66
                if err := resp.WriteHeaderAndEntity(http.StatusBadRequest, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
67
                        klog.Errorf("failed to write response, %v", err)
×
68
                }
×
69
                return
×
70
        }
71
        klog.V(5).Infof("request body is %v", podRequest)
×
72
        podSubnet, exist := csh.providerExists(podRequest.Provider)
×
73
        if !exist {
×
74
                errMsg := fmt.Errorf("provider %s not bind to any subnet", podRequest.Provider)
×
75
                klog.Error(errMsg)
×
76
                if err := resp.WriteHeaderAndEntity(http.StatusBadRequest, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
77
                        klog.Errorf("failed to write response, %v", err)
×
78
                }
×
79
                return
×
80
        }
81

82
        klog.Infof("add port request: %v", podRequest)
×
83
        if err := csh.validatePodRequest(&podRequest); err != nil {
×
84
                klog.Error(err)
×
85
                if err := resp.WriteHeaderAndEntity(http.StatusBadRequest, request.CniResponse{Err: err.Error()}); err != nil {
×
86
                        klog.Errorf("failed to write response, %v", err)
×
87
                }
×
88
                return
×
89
        }
90

91
        var gatewayCheckMode int
×
92
        var macAddr, ip, ipAddr, cidr, gw, subnet, ingress, egress, providerNetwork, ifName, nicType, podNicName, vmName, latency, limit, loss, jitter, u2oInterconnectionIP, oldPodName string
×
93
        var routes []request.Route
×
94
        var isDefaultRoute bool
×
95
        var pod *v1.Pod
×
96
        var err error
×
97
        for i := 0; i < 20; i++ {
×
98
                if pod, err = csh.Controller.podsLister.Pods(podRequest.PodNamespace).Get(podRequest.PodName); err != nil {
×
99
                        errMsg := fmt.Errorf("get pod %s/%s failed %w", podRequest.PodNamespace, podRequest.PodName, err)
×
100
                        klog.Error(errMsg)
×
101
                        if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
102
                                klog.Errorf("failed to write response, %v", err)
×
103
                        }
×
104
                        return
×
105
                }
106
                if pod.Annotations[fmt.Sprintf(util.AllocatedAnnotationTemplate, podRequest.Provider)] != "true" {
×
107
                        klog.Infof("wait address for pod %s/%s provider %s", podRequest.PodNamespace, podRequest.PodName, podRequest.Provider)
×
108
                        // wait controller assign an address
×
109
                        cniWaitAddressResult.WithLabelValues(nodeName).Inc()
×
110
                        time.Sleep(1 * time.Second)
×
111
                        continue
×
112
                }
113

114
                if err := util.ValidatePodNetwork(pod.Annotations); err != nil {
×
115
                        klog.Errorf("validate pod %s/%s failed, %v", podRequest.PodNamespace, podRequest.PodName, err)
×
116
                        // wait controller assign an address
×
117
                        cniWaitAddressResult.WithLabelValues(nodeName).Inc()
×
118
                        time.Sleep(1 * time.Second)
×
119
                        continue
×
120
                }
121
                ip = pod.Annotations[fmt.Sprintf(util.IPAddressAnnotationTemplate, podRequest.Provider)]
×
122
                cidr = pod.Annotations[fmt.Sprintf(util.CidrAnnotationTemplate, podRequest.Provider)]
×
123
                gw = pod.Annotations[fmt.Sprintf(util.GatewayAnnotationTemplate, podRequest.Provider)]
×
124
                subnet = pod.Annotations[fmt.Sprintf(util.LogicalSwitchAnnotationTemplate, podRequest.Provider)]
×
125
                ingress = pod.Annotations[fmt.Sprintf(util.IngressRateAnnotationTemplate, podRequest.Provider)]
×
126
                egress = pod.Annotations[fmt.Sprintf(util.EgressRateAnnotationTemplate, podRequest.Provider)]
×
127
                latency = pod.Annotations[fmt.Sprintf(util.NetemQosLatencyAnnotationTemplate, podRequest.Provider)]
×
128
                limit = pod.Annotations[fmt.Sprintf(util.NetemQosLimitAnnotationTemplate, podRequest.Provider)]
×
129
                loss = pod.Annotations[fmt.Sprintf(util.NetemQosLossAnnotationTemplate, podRequest.Provider)]
×
130
                jitter = pod.Annotations[fmt.Sprintf(util.NetemQosJitterAnnotationTemplate, podRequest.Provider)]
×
131
                providerNetwork = pod.Annotations[fmt.Sprintf(util.ProviderNetworkTemplate, podRequest.Provider)]
×
132
                vmName = pod.Annotations[fmt.Sprintf(util.VMAnnotationTemplate, podRequest.Provider)]
×
133
                ipAddr, err = util.GetIPAddrWithMask(ip, cidr)
×
134
                if err != nil {
×
135
                        errMsg := fmt.Errorf("failed to get ip address with mask, %w", err)
×
136
                        klog.Error(errMsg)
×
137
                        if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
138
                                klog.Errorf("failed to write response, %v", err)
×
139
                        }
×
140
                        return
×
141
                }
142
                oldPodName = podRequest.PodName
×
143
                if s := pod.Annotations[fmt.Sprintf(util.RoutesAnnotationTemplate, podRequest.Provider)]; s != "" {
×
144
                        if err = json.Unmarshal([]byte(s), &routes); err != nil {
×
145
                                errMsg := fmt.Errorf("invalid routes for pod %s/%s: %w", pod.Namespace, pod.Name, err)
×
146
                                klog.Error(errMsg)
×
147
                                if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
148
                                        klog.Errorf("failed to write response: %v", err)
×
149
                                }
×
150
                                return
×
151
                        }
152
                }
153
                if ifName = podRequest.IfName; ifName == "" {
×
154
                        ifName = "eth0"
×
155
                }
×
156

157
                // For Support kubevirt hotplug dpdk nic, forbidden set the volume name
158
                if podRequest.VhostUserSocketConsumption == util.ConsumptionKubevirt {
×
159
                        podRequest.VhostUserSocketVolumeName = util.VhostUserSocketVolumeName
×
160
                }
×
161

162
                switch {
×
163
                case podRequest.DeviceID != "":
×
164
                        nicType = util.OffloadType
×
165
                case podRequest.VhostUserSocketVolumeName != "":
×
166
                        nicType = util.DpdkType
×
167
                        if err = createShortSharedDir(pod, podRequest.VhostUserSocketVolumeName, podRequest.VhostUserSocketConsumption, csh.Config.KubeletDir); err != nil {
×
168
                                klog.Error(err.Error())
×
169
                                if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: err.Error()}); err != nil {
×
170
                                        klog.Errorf("failed to write response: %v", err)
×
171
                                }
×
172
                                return
×
173
                        }
174
                default:
×
175
                        nicType = pod.Annotations[fmt.Sprintf(util.PodNicAnnotationTemplate, podRequest.Provider)]
×
176
                }
177

178
                switch pod.Annotations[fmt.Sprintf(util.DefaultRouteAnnotationTemplate, podRequest.Provider)] {
×
179
                case "true":
×
180
                        isDefaultRoute = true
×
181
                case "false":
×
182
                        isDefaultRoute = false
×
183
                default:
×
184
                        isDefaultRoute = ifName == "eth0"
×
185
                }
186

187
                if isDefaultRoute && pod.Annotations[fmt.Sprintf(util.RoutedAnnotationTemplate, podRequest.Provider)] != "true" && util.IsOvnProvider(podRequest.Provider) {
×
188
                        klog.Infof("wait route ready for pod %s/%s provider %s", podRequest.PodNamespace, podRequest.PodName, podRequest.Provider)
×
189
                        cniWaitRouteResult.WithLabelValues(nodeName).Inc()
×
190
                        time.Sleep(1 * time.Second)
×
191
                        continue
×
192
                }
193

194
                if vmName != "" {
×
195
                        podRequest.PodName = vmName
×
196
                }
×
197

198
                break
×
199
        }
200

201
        if pod.Annotations[fmt.Sprintf(util.AllocatedAnnotationTemplate, podRequest.Provider)] != "true" {
×
202
                err := fmt.Errorf("no address allocated to pod %s/%s provider %s, please see kube-ovn-controller logs to find errors", pod.Namespace, pod.Name, podRequest.Provider)
×
203
                klog.Error(err)
×
204
                if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: err.Error()}); err != nil {
×
205
                        klog.Errorf("failed to write response, %v", err)
×
206
                }
×
207
                return
×
208
        }
209

210
        if subnet == "" && podSubnet != nil {
×
211
                subnet = podSubnet.Name
×
212
        }
×
213
        if err := csh.UpdateIPCR(podRequest, subnet, ip); err != nil {
×
214
                if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: err.Error()}); err != nil {
×
215
                        klog.Errorf("failed to write response, %v", err)
×
216
                }
×
217
                return
×
218
        }
219

220
        if isDefaultRoute && pod.Annotations[fmt.Sprintf(util.RoutedAnnotationTemplate, podRequest.Provider)] != "true" && util.IsOvnProvider(podRequest.Provider) {
×
221
                err := fmt.Errorf("route is not ready for pod %s/%s provider %s, please see kube-ovn-controller logs to find errors", pod.Namespace, pod.Name, podRequest.Provider)
×
222
                klog.Error(err)
×
223
                if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: err.Error()}); err != nil {
×
224
                        klog.Errorf("failed to write response, %v", err)
×
225
                }
×
226
                return
×
227
        }
228

NEW
229
        if podSubnet, err = csh.Controller.subnetsLister.Get(subnet); err != nil {
×
NEW
230
                errMsg := fmt.Errorf("failed to get subnet %q: %w", subnet, err)
×
NEW
231
                klog.Error(errMsg)
×
NEW
232
                if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
NEW
233
                        klog.Errorf("failed to write response: %v", err)
×
UNCOV
234
                }
×
NEW
235
                return
×
236
        }
237

NEW
238
        var mtu int
×
NEW
239
        routes = slices.Concat(podRequest.Routes, podSubnet.Spec.Routes, routes)
×
NEW
240
        if util.IsOvnProvider(podRequest.Provider) {
×
241
                if podSubnet.Status.U2OInterconnectionIP == "" && podSubnet.Spec.U2OInterconnection {
×
242
                        errMsg := fmt.Errorf("failed to generate u2o ip on subnet %s", podSubnet.Name)
×
243
                        klog.Error(errMsg)
×
244
                        return
×
245
                }
×
246

247
                if podSubnet.Status.U2OInterconnectionIP != "" && podSubnet.Spec.U2OInterconnection {
×
248
                        u2oInterconnectionIP = podSubnet.Status.U2OInterconnectionIP
×
249
                }
×
250

251
                subnetHasVlan := podSubnet.Spec.Vlan != ""
×
252
                detectIPConflict := csh.Config.EnableArpDetectIPConflict && subnetHasVlan
×
253
                // skip ping check gateway for pods during live migration
×
254
                if pod.Annotations[util.MigrationJobAnnotation] == "" {
×
255
                        if subnetHasVlan && !podSubnet.Spec.LogicalGateway {
×
256
                                if podSubnet.Spec.DisableGatewayCheck {
×
257
                                        gatewayCheckMode = gatewayCheckModeArpingNotConcerned
×
258
                                } else {
×
259
                                        gatewayCheckMode = gatewayCheckModeArping
×
260
                                }
×
261
                        } else {
×
262
                                if podSubnet.Spec.DisableGatewayCheck {
×
263
                                        gatewayCheckMode = gatewayCheckModePingNotConcerned
×
264
                                } else {
×
265
                                        gatewayCheckMode = gatewayCheckModePing
×
266
                                }
×
267
                        }
268
                } else {
×
269
                        // do not perform ipv4 conflict detection during VM live migration
×
270
                        detectIPConflict = false
×
271
                }
×
272
                if pod.Annotations[fmt.Sprintf(util.ActivationStrategyTemplate, podRequest.Provider)] != "" {
×
273
                        gatewayCheckMode = gatewayCheckModeDisabled
×
274
                }
×
275

276
                if podSubnet.Spec.Mtu > 0 {
×
277
                        mtu = int(podSubnet.Spec.Mtu)
×
278
                } else {
×
279
                        if providerNetwork != "" && !podSubnet.Spec.LogicalGateway && !podSubnet.Spec.U2OInterconnection {
×
280
                                node, err := csh.Controller.nodesLister.Get(csh.Config.NodeName)
×
281
                                if err != nil {
×
282
                                        errMsg := fmt.Errorf("failed to get node %s: %w", csh.Config.NodeName, err)
×
283
                                        klog.Error(errMsg)
×
284
                                        if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
285
                                                klog.Errorf("failed to write response: %v", err)
×
286
                                        }
×
287
                                        return
×
288
                                }
289
                                mtuStr := node.Labels[fmt.Sprintf(util.ProviderNetworkMtuTemplate, providerNetwork)]
×
290
                                if mtuStr != "" {
×
291
                                        if mtu, err = strconv.Atoi(mtuStr); err != nil || mtu <= 0 {
×
292
                                                errMsg := fmt.Errorf("failed to parse provider network MTU %s: %w", mtuStr, err)
×
293
                                                klog.Error(errMsg)
×
294
                                                if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
295
                                                        klog.Errorf("failed to write response: %v", err)
×
296
                                                }
×
297
                                                return
×
298
                                        }
299
                                }
300
                        } else {
×
301
                                mtu = csh.Config.MTU
×
302
                        }
×
303
                }
304

305
                macAddr = pod.Annotations[fmt.Sprintf(util.MacAddressAnnotationTemplate, podRequest.Provider)]
×
306
                klog.Infof("create container interface %s mac %s, ip %s, cidr %s, gw %s, custom routes %v", ifName, macAddr, ipAddr, cidr, gw, routes)
×
307
                podNicName = ifName
×
308
                switch nicType {
×
309
                case util.InternalType:
×
310
                        podNicName, routes, err = csh.configureNicWithInternalPort(podRequest.PodName, podRequest.PodNamespace, podRequest.Provider, podRequest.NetNs, podRequest.ContainerID, ifName, macAddr, mtu, ipAddr, gw, isDefaultRoute, detectIPConflict, routes, podRequest.DNS.Nameservers, podRequest.DNS.Search, ingress, egress, podRequest.DeviceID, nicType, latency, limit, loss, jitter, gatewayCheckMode, u2oInterconnectionIP)
×
311
                case util.DpdkType:
×
312
                        err = csh.configureDpdkNic(podRequest.PodName, podRequest.PodNamespace, podRequest.Provider, podRequest.NetNs, podRequest.ContainerID, ifName, macAddr, mtu, ipAddr, gw, ingress, egress, getShortSharedDir(pod.UID, podRequest.VhostUserSocketVolumeName), podRequest.VhostUserSocketName, podRequest.VhostUserSocketConsumption)
×
313
                        routes = nil
×
314
                default:
×
315
                        routes, err = csh.configureNic(podRequest.PodName, podRequest.PodNamespace, podRequest.Provider, podRequest.NetNs, podRequest.ContainerID, podRequest.VfDriver, ifName, macAddr, mtu, ipAddr, gw, isDefaultRoute, detectIPConflict, routes, podRequest.DNS.Nameservers, podRequest.DNS.Search, ingress, egress, podRequest.DeviceID, nicType, latency, limit, loss, jitter, gatewayCheckMode, u2oInterconnectionIP, oldPodName)
×
316
                }
317
                if err != nil {
×
318
                        errMsg := fmt.Errorf("configure nic %s for pod %s/%s failed: %w", ifName, podRequest.PodName, podRequest.PodNamespace, err)
×
319
                        klog.Error(errMsg)
×
320
                        if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
321
                                klog.Errorf("failed to write response, %v", err)
×
322
                        }
×
323
                        return
×
324
                }
325

326
                ifaceID := ovs.PodNameToPortName(podRequest.PodName, podRequest.PodNamespace, podRequest.Provider)
×
327
                if err = ovs.ConfigInterfaceMirror(csh.Config.EnableMirror, pod.Annotations[fmt.Sprintf(util.MirrorControlAnnotationTemplate, podRequest.Provider)], ifaceID); err != nil {
×
328
                        klog.Errorf("failed mirror to mirror0, %v", err)
×
329
                        return
×
330
                }
×
331

332
                if err = csh.Controller.addEgressConfig(podSubnet, ip); err != nil {
×
333
                        errMsg := fmt.Errorf("failed to add egress configuration: %w", err)
×
334
                        klog.Error(errMsg)
×
335
                        if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
336
                                klog.Errorf("failed to write response, %v", err)
×
337
                        }
×
338
                        return
×
339
                }
340
        } else if len(routes) != 0 {
×
341
                hasDefaultRoute := make(map[string]bool, 2)
×
342
                for _, r := range routes {
×
343
                        if r.Destination == "" {
×
344
                                hasDefaultRoute[util.CheckProtocol(r.Gateway)] = true
×
345
                                continue
×
346
                        }
347
                        if _, cidr, err := net.ParseCIDR(r.Destination); err == nil {
×
348
                                if ones, _ := cidr.Mask.Size(); ones == 0 {
×
349
                                        hasDefaultRoute[util.CheckProtocol(r.Gateway)] = true
×
350
                                }
×
351
                        }
352
                }
353
                if len(hasDefaultRoute) != 0 {
×
354
                        // remove existing default route so other CNI plugins, such as macvlan, can add the new default route correctly
×
355
                        if err = csh.removeDefaultRoute(podRequest.NetNs, hasDefaultRoute[kubeovnv1.ProtocolIPv4], hasDefaultRoute[kubeovnv1.ProtocolIPv6]); err != nil {
×
356
                                errMsg := fmt.Errorf("failed to remove existing default route for interface %s of pod %s/%s: %w", podRequest.IfName, podRequest.PodNamespace, podRequest.PodName, err)
×
357
                                klog.Error(errMsg)
×
358
                                if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
359
                                        klog.Errorf("failed to write response: %v", err)
×
360
                                }
×
361
                                return
×
362
                        }
363
                }
364
        }
365

366
        response := &request.CniResponse{
×
367
                Protocol:   util.CheckProtocol(cidr),
×
368
                IPAddress:  ip,
×
369
                MacAddress: macAddr,
×
370
                CIDR:       cidr,
×
371
                PodNicName: podNicName,
×
372
                Routes:     routes,
×
373
                Mtu:        mtu,
×
374
        }
×
375
        if isDefaultRoute {
×
376
                response.Gateway = gw
×
377
        }
×
378
        if err := resp.WriteHeaderAndEntity(http.StatusOK, response); err != nil {
×
379
                klog.Errorf("failed to write response, %v", err)
×
380
        }
×
381
}
382

383
func (csh cniServerHandler) UpdateIPCR(podRequest request.CniRequest, subnet, ip string) error {
×
384
        ipCRName := ovs.PodNameToPortName(podRequest.PodName, podRequest.PodNamespace, podRequest.Provider)
×
385
        for i := 0; i < 20; i++ {
×
386
                ipCR, err := csh.KubeOvnClient.KubeovnV1().IPs().Get(context.Background(), ipCRName, metav1.GetOptions{})
×
387
                if err != nil {
×
388
                        err = fmt.Errorf("failed to get ip crd for %s, %w", ip, err)
×
389
                        // maybe create a backup pod with previous annotations
×
390
                        klog.Error(err)
×
391
                } else if ipCR.Spec.NodeName != csh.Config.NodeName {
×
392
                        ipCR := ipCR.DeepCopy()
×
393
                        ipCR.Spec.NodeName = csh.Config.NodeName
×
394
                        ipCR.Spec.AttachIPs = []string{}
×
395
                        ipCR.Labels[subnet] = ""
×
396
                        ipCR.Labels[util.NodeNameLabel] = csh.Config.NodeName
×
397
                        ipCR.Spec.AttachSubnets = []string{}
×
398
                        ipCR.Spec.AttachMacs = []string{}
×
399
                        if _, err := csh.KubeOvnClient.KubeovnV1().IPs().Update(context.Background(), ipCR, metav1.UpdateOptions{}); err != nil {
×
400
                                err = fmt.Errorf("failed to update ip crd for %s, %w", ip, err)
×
401
                                klog.Error(err)
×
402
                        } else {
×
403
                                return nil
×
404
                        }
×
405
                }
406
                if err != nil {
×
407
                        klog.Warningf("wait pod ip %s to be ready", ipCRName)
×
408
                        time.Sleep(1 * time.Second)
×
409
                } else {
×
410
                        return nil
×
411
                }
×
412
        }
413
        // update ip spec node is not that necessary, so we just log the error
414
        return nil
×
415
}
416

417
func (csh cniServerHandler) handleDel(req *restful.Request, resp *restful.Response) {
×
418
        var podRequest request.CniRequest
×
419
        if err := req.ReadEntity(&podRequest); err != nil {
×
420
                errMsg := fmt.Errorf("parse del request failed %w", err)
×
421
                klog.Error(errMsg)
×
422
                if err := resp.WriteHeaderAndEntity(http.StatusBadRequest, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
423
                        klog.Errorf("failed to write response, %v", err)
×
424
                }
×
425
                return
×
426
        }
427

428
        // Try to get the Pod, but if it fails due to not being found, log a warning and continue.
429
        pod, err := csh.Controller.podsLister.Pods(podRequest.PodNamespace).Get(podRequest.PodName)
×
430
        if err != nil && !k8serrors.IsNotFound(err) {
×
431
                errMsg := fmt.Errorf("failed to retrieve Pod %s/%s: %w", podRequest.PodNamespace, podRequest.PodName, err)
×
432
                klog.Error(errMsg)
×
433
                if err := resp.WriteHeaderAndEntity(http.StatusBadRequest, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
434
                        klog.Errorf("failed to write response, %v", err)
×
435
                }
×
436
                return
×
437
        }
438

439
        if podRequest.NetNs == "" {
×
440
                klog.Infof("skip del port request: %v", podRequest)
×
441
                resp.WriteHeader(http.StatusNoContent)
×
442
                return
×
443
        }
×
444

445
        klog.Infof("del port request: %v", podRequest)
×
446
        if err := csh.validatePodRequest(&podRequest); err != nil {
×
447
                klog.Error(err)
×
448
                if err := resp.WriteHeaderAndEntity(http.StatusBadRequest, request.CniResponse{Err: err.Error()}); err != nil {
×
449
                        klog.Errorf("failed to write response, %v", err)
×
450
                }
×
451
                return
×
452
        }
453

454
        var nicType string
×
455
        var vmName string
×
456

×
457
        // If the Pod was found, process its annotations and labels.
×
458
        if pod != nil {
×
459
                if pod.Annotations != nil && (util.IsOvnProvider(podRequest.Provider) || podRequest.CniType == util.CniTypeName) {
×
460
                        subnet := pod.Annotations[fmt.Sprintf(util.LogicalSwitchAnnotationTemplate, podRequest.Provider)]
×
461
                        if subnet != "" {
×
462
                                ip := pod.Annotations[fmt.Sprintf(util.IPAddressAnnotationTemplate, podRequest.Provider)]
×
463
                                if err = csh.Controller.removeEgressConfig(subnet, ip); err != nil {
×
464
                                        errMsg := fmt.Errorf("failed to remove egress configuration: %w", err)
×
465
                                        klog.Error(errMsg)
×
466
                                        if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
467
                                                klog.Errorf("failed to write response, %v", err)
×
468
                                        }
×
469
                                        return
×
470
                                }
471
                        }
472

473
                        switch {
×
474
                        case podRequest.DeviceID != "":
×
475
                                nicType = util.OffloadType
×
476
                        case podRequest.VhostUserSocketVolumeName != "":
×
477
                                nicType = util.DpdkType
×
478
                                if err = removeShortSharedDir(pod, podRequest.VhostUserSocketVolumeName, podRequest.VhostUserSocketConsumption); err != nil {
×
479
                                        klog.Error(err.Error())
×
480
                                        if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: err.Error()}); err != nil {
×
481
                                                klog.Errorf("failed to write response: %v", err)
×
482
                                        }
×
483
                                        return
×
484
                                }
485
                        default:
×
486
                                nicType = pod.Annotations[fmt.Sprintf(util.PodNicAnnotationTemplate, podRequest.Provider)]
×
487
                        }
488

489
                        vmName = pod.Annotations[fmt.Sprintf(util.VMAnnotationTemplate, podRequest.Provider)]
×
490
                        if vmName != "" {
×
491
                                podRequest.PodName = vmName
×
492
                        }
×
493
                }
494
        } else {
×
495
                // If the Pod is not found, assign a default value.
×
496
                klog.Warningf("Pod %s not found, proceeding with NIC deletion using ContainerID and NetNs", podRequest.PodName)
×
497
                switch {
×
498
                case podRequest.DeviceID != "":
×
499
                        nicType = util.OffloadType
×
500
                case podRequest.VhostUserSocketVolumeName != "":
×
501
                        nicType = util.DpdkType
×
502
                default:
×
503
                        nicType = util.VethType
×
504
                }
505
        }
506

507
        // For Support kubevirt hotplug dpdk nic, forbidden set the volume name
508
        if podRequest.VhostUserSocketConsumption == util.ConsumptionKubevirt {
×
509
                podRequest.VhostUserSocketVolumeName = util.VhostUserSocketVolumeName
×
510
        }
×
511

512
        // Proceed to delete the NIC regardless of whether the Pod was found or not.
513
        err = csh.deleteNic(podRequest.PodName, podRequest.PodNamespace, podRequest.ContainerID, podRequest.NetNs, podRequest.DeviceID, podRequest.IfName, nicType)
×
514
        if err != nil {
×
515
                errMsg := fmt.Errorf("del nic failed %w", err)
×
516
                klog.Error(errMsg)
×
517
                if err := resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
×
518
                        klog.Errorf("failed to write response, %v", err)
×
519
                }
×
520
                return
×
521
        }
522
        resp.WriteHeader(http.StatusNoContent)
×
523
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc