TuringLang / DynamicPPL.jl / 13156283797

Pull #779

github

Remove samplers from VarInfo - indexing  (#793)

* Remove selector stuff from varinfo tests

* Implement link and invlink for varnames rather than samplers

* Replace set_retained_vns_del_by_spl! with set_retained_vns_del!

* Make linking tests more extensive

* Remove sampler indexing from link methods (but not invlink)

* Remove indexing by samplers from invlink

* Work towards removing sampler indexing with StaticTransformation

* Fix invlink/link for TypedVarInfo and StaticTransformation

* Fix a test in models.jl

* Move some functions to utils.jl, add tests and docstrings

* Fix a docstring typo

* Various simplification to link/invlink

* Improve a docstring

* Style improvements

* Fix broken link/invlink dispatch cascade for VectorVarInfo

* Fix some more broken dispatch cascades

* Apply suggestions from code review

Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>

* Remove comments that messed with docstrings

* Apply suggestions from code review

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>

* Fix issues surfaced in code review

* Simplify link/invlink arguments

* Fix a bug in unflatten VarNamedVector

* Rename VarNameCollection -> VarNameTuple

* Remove test of a removed varname_namedtuple method

* Apply suggestions from code review

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>

* Respond to review feedback

* Remove _default_sampler and a dead argument of maybe_invlink_before_eval

* Fix a typo in a comment

* Add HISTORY entry, fix one set_retained_vns_del! method

* Remove some VarInfo getindex with samplers stuff

* Remove some index setting with samplers

* Remove more sampler indexing

* Remove unflatten with samplers

* Clean up some setindex stuff

* Remove a bunch of varinfo.jl internal functions that used samplers/space, update HISTORY.md

* Fix HISTORY.md

* Miscalleanous small fixes

* Fix a bug in VarInfo c... (continued)

184 of 243 new or added lines in 11 files covered. (75.72%)

3609 of 4203 relevant lines covered (85.87%)

395322.01 hits per line