• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3592

24 Jan 2025 08:57AM UTC coverage: 63.546% (-0.1%) from 63.688%
#3592

push

travis-ci

web-flow
Merge pull request #29638 from taosdata/docs/TS-5846-3.0

enh: TDengine modify taosBenchmark new query rule cases and add doc

141205 of 285630 branches covered (49.44%)

Branch coverage included in aggregate %.

220039 of 282844 relevant lines covered (77.8%)

18746126.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.69
/source/dnode/vnode/src/tsdb/tsdbCacheRead.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "functionMgt.h"
17
#include "functionResInfo.h"
18
#include "taoserror.h"
19
#include "tarray.h"
20
#include "tcommon.h"
21
#include "tsdb.h"
22
#include "tsdbDataFileRW.h"
23
#include "tsdbReadUtil.h"
24

25
#define HASTYPE(_type, _t) (((_type) & (_t)) == (_t))
26

27
static int32_t setFirstLastResColToNull(SColumnInfoData* pCol, int32_t row) {
22✔
28
  int32_t        code = TSDB_CODE_SUCCESS;
22✔
29
  int32_t        lino = 0;
22✔
30
  char*          buf = NULL;
22✔
31
  SFirstLastRes* pRes = NULL;
22✔
32

33
  TSDB_CHECK_NULL(pCol, code, lino, _end, TSDB_CODE_INVALID_PARA);
22!
34

35
  buf = taosMemoryCalloc(1, pCol->info.bytes);
22!
36
  TSDB_CHECK_NULL(buf, code, lino, _end, terrno);
22!
37

38
  pRes = (SFirstLastRes*)((char*)buf + VARSTR_HEADER_SIZE);
22✔
39
  pRes->bytes = 0;
22✔
40
  pRes->hasResult = true;
22✔
41
  pRes->isNull = true;
22✔
42
  varDataSetLen(buf, pCol->info.bytes - VARSTR_HEADER_SIZE);
22✔
43
  code = colDataSetVal(pCol, row, buf, false);
22✔
44
  TSDB_CHECK_CODE(code, lino, _end);
22!
45

46
_end:
22✔
47
  if (code != TSDB_CODE_SUCCESS) {
22!
48
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
49
  }
50
  if (buf != NULL) {
22!
51
    taosMemoryFreeClear(buf);
22!
52
  }
53
  return code;
22✔
54
}
55

56
static int32_t saveOneRowForLastRaw(SLastCol* pColVal, SCacheRowsReader* pReader, const int32_t slotId,
3,042✔
57
                                    SColumnInfoData* pColInfoData, int32_t numOfRows) {
58
  int32_t  code = TSDB_CODE_SUCCESS;
3,042✔
59
  int32_t  lino = 0;
3,042✔
60
  SColVal* pVal = NULL;
3,042✔
61

62
  TSDB_CHECK_NULL(pColVal, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,042!
63
  TSDB_CHECK_NULL(pColInfoData, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,042!
64

65
  pVal = &pColVal->colVal;
3,042✔
66

67
  // allNullRow = false;
68
  if (IS_VAR_DATA_TYPE(pColVal->colVal.value.type)) {
3,042!
69
    if (!COL_VAL_IS_VALUE(&pColVal->colVal)) {
170✔
70
      colDataSetNULL(pColInfoData, numOfRows);
80✔
71
    } else {
72
      TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
90!
73
      varDataSetLen(pReader->transferBuf[slotId], pVal->value.nData);
90✔
74

75
      memcpy(varDataVal(pReader->transferBuf[slotId]), pVal->value.pData, pVal->value.nData);
90✔
76
      code = colDataSetVal(pColInfoData, numOfRows, pReader->transferBuf[slotId], false);
90✔
77
      TSDB_CHECK_CODE(code, lino, _end);
90!
78
    }
79
  } else {
80
    code = colDataSetVal(pColInfoData, numOfRows, (const char*)&pVal->value.val, !COL_VAL_IS_VALUE(pVal));
2,872✔
81
    TSDB_CHECK_CODE(code, lino, _end);
2,871!
82
  }
83

84
_end:
2,871✔
85
  if (code != TSDB_CODE_SUCCESS) {
3,041!
86
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
87
  }
88
  return code;
3,041✔
89
}
90

91
static int32_t saveOneRow(SArray* pRow, SSDataBlock* pBlock, SCacheRowsReader* pReader, const int32_t* slotIds,
3,130✔
92
                          const int32_t* dstSlotIds, void** pRes, const char* idStr) {
93
  int32_t code = TSDB_CODE_SUCCESS;
3,130✔
94
  int32_t lino = 0;
3,130✔
95
  int32_t numOfRows = 0;
3,130✔
96
  SArray* funcTypeBlockArray = NULL;
3,130✔
97

98
  TSDB_CHECK_NULL(pBlock, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,130!
99
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,130!
100
  if (pReader->numOfCols > 0) {
3,130!
101
    TSDB_CHECK_NULL(slotIds, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,131!
102
    TSDB_CHECK_NULL(dstSlotIds, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,131!
103
    TSDB_CHECK_NULL(pRes, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,131!
104
  }
105

106
  numOfRows = pBlock->info.rows;
3,130✔
107

108
  if (HASTYPE(pReader->type, CACHESCAN_RETRIEVE_LAST)) {
3,130✔
109
    uint64_t       ts = TSKEY_MIN;
1,793✔
110
    SFirstLastRes* p = NULL;
1,793✔
111
    col_id_t       colId = -1;
1,793✔
112

113
    funcTypeBlockArray = taosArrayInit(pReader->numOfCols, sizeof(int32_t));
1,793✔
114
    TSDB_CHECK_NULL(funcTypeBlockArray, code, lino, _end, terrno);
1,793!
115

116
    for (int32_t i = 0; i < pReader->numOfCols; ++i) {
5,003✔
117
      SColumnInfoData* pColInfoData = taosArrayGet(pBlock->pDataBlock, dstSlotIds[i]);
3,210✔
118
      TSDB_CHECK_NULL(pColInfoData, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,209!
119

120
      int32_t funcType = FUNCTION_TYPE_CACHE_LAST;
3,209✔
121
      if (pReader->pFuncTypeList != NULL && taosArrayGetSize(pReader->pFuncTypeList) > i) {
3,209✔
122
        void* pVal = taosArrayGet(pReader->pFuncTypeList, i);
788✔
123
        TSDB_CHECK_NULL(pVal, code, lino, _end, TSDB_CODE_INVALID_PARA);
788!
124

125
        funcType = *(int32_t*)pVal;
788✔
126
        pVal = taosArrayGet(pReader->pFuncTypeList, i);
788✔
127
        TSDB_CHECK_NULL(pVal, code, lino, _end, TSDB_CODE_INVALID_PARA);
788!
128

129
        void* px = taosArrayInsert(funcTypeBlockArray, dstSlotIds[i], pVal);
788✔
130
        TSDB_CHECK_NULL(px, code, lino, _end, terrno);
788✔
131
      }
132

133
      if (slotIds[i] == -1) {
3,208✔
134
        if (FUNCTION_TYPE_CACHE_LAST_ROW == funcType) {
22!
135
          colDataSetNULL(pColInfoData, numOfRows);
×
136
          continue;
×
137
        }
138

139
        code = setFirstLastResColToNull(pColInfoData, numOfRows);
22✔
140
        TSDB_CHECK_CODE(code, lino, _end);
22!
141
        continue;
22✔
142
      }
143

144
      int32_t   slotId = slotIds[i];
3,186✔
145
      SLastCol* pColVal = (SLastCol*)taosArrayGet(pRow, i);
3,186✔
146
      TSDB_CHECK_NULL(pColVal, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,186!
147

148
      colId = pColVal->colVal.cid;
3,186✔
149
      if (FUNCTION_TYPE_CACHE_LAST_ROW == funcType) {
3,186✔
150
        code = saveOneRowForLastRaw(pColVal, pReader, slotId, pColInfoData, numOfRows);
415✔
151
        TSDB_CHECK_CODE(code, lino, _end);
415!
152

153
        continue;
415✔
154
      }
155

156
      p = (SFirstLastRes*)varDataVal(pRes[i]);
2,771✔
157

158
      p->ts = pColVal->rowKey.ts;
2,771✔
159
      ts = p->ts;
2,771✔
160
      p->isNull = !COL_VAL_IS_VALUE(&pColVal->colVal);
2,771✔
161
      // allNullRow = p->isNull & allNullRow;
162
      if (!p->isNull) {
2,771✔
163
        if (IS_VAR_DATA_TYPE(pColVal->colVal.value.type)) {
2,759!
164
          varDataSetLen(p->buf, pColVal->colVal.value.nData);
424✔
165

166
          memcpy(varDataVal(p->buf), pColVal->colVal.value.pData, pColVal->colVal.value.nData);
424✔
167
          p->bytes = pColVal->colVal.value.nData + VARSTR_HEADER_SIZE;  // binary needs to plus the header size
424✔
168
        } else {
169
          memcpy(p->buf, &pColVal->colVal.value.val, pReader->pSchema->columns[slotId].bytes);
2,335✔
170
          p->bytes = pReader->pSchema->columns[slotId].bytes;
2,335✔
171
        }
172
      }
173

174
      // pColInfoData->info.bytes includes the VARSTR_HEADER_SIZE, need to subtract it
175
      p->hasResult = true;
2,771✔
176
      varDataSetLen(pRes[i], pColInfoData->info.bytes - VARSTR_HEADER_SIZE);
2,771✔
177
      code = colDataSetVal(pColInfoData, numOfRows, (const char*)pRes[i], false);
2,771✔
178
      TSDB_CHECK_CODE(code, lino, _end);
2,773!
179
    }
180

181
    for (int32_t idx = 0; idx < taosArrayGetSize(pBlock->pDataBlock); ++idx) {
6,984✔
182
      SColumnInfoData* pCol = taosArrayGet(pBlock->pDataBlock, idx);
5,190✔
183
      TSDB_CHECK_NULL(pCol, code, lino, _end, TSDB_CODE_INVALID_PARA);
5,191!
184

185
      if (idx < funcTypeBlockArray->size) {
5,191✔
186
        void* pVal = taosArrayGet(funcTypeBlockArray, idx);
788✔
187
        TSDB_CHECK_NULL(pVal, code, lino, _end, TSDB_CODE_INVALID_PARA);
788!
188

189
        int32_t funcType = *(int32_t*)pVal;
788✔
190
        if (FUNCTION_TYPE_CACHE_LAST_ROW == funcType) {
788✔
191
          continue;
415✔
192
        }
193
      }
194

195
      if (pCol->info.colId == PRIMARYKEY_TIMESTAMP_COL_ID && pCol->info.type == TSDB_DATA_TYPE_TIMESTAMP) {
4,776✔
196
        if (ts == TSKEY_MIN) {
731✔
197
          colDataSetNULL(pCol, numOfRows);
22!
198
        } else {
199
          code = colDataSetVal(pCol, numOfRows, (const char*)&ts, false);
709✔
200
          TSDB_CHECK_CODE(code, lino, _end);
709!
201
        }
202
        continue;
731✔
203
      } else if (pReader->numOfCols == 1 && idx != dstSlotIds[0] && (pCol->info.colId == colId || colId == -1)) {
4,045✔
204
        if (p && !p->isNull) {
269!
205
          code = colDataSetVal(pCol, numOfRows, p->buf, false);
247✔
206
          TSDB_CHECK_CODE(code, lino, _end);
247!
207
        } else {
208
          colDataSetNULL(pCol, numOfRows);
22!
209
        }
210
      }
211
    }
212

213
    // pBlock->info.rows += allNullRow ? 0 : 1;
214
    ++pBlock->info.rows;
1,792✔
215
  } else if (HASTYPE(pReader->type, CACHESCAN_RETRIEVE_LAST_ROW)) {
1,337!
216
    for (int32_t i = 0; i < pReader->numOfCols; ++i) {
4,303✔
217
      SColumnInfoData* pColInfoData = taosArrayGet(pBlock->pDataBlock, dstSlotIds[i]);
2,966✔
218
      TSDB_CHECK_NULL(pColInfoData, code, lino, _end, TSDB_CODE_INVALID_PARA);
2,965!
219

220
      int32_t slotId = slotIds[i];
2,965✔
221
      if (slotId == -1) {
2,965✔
222
        colDataSetNULL(pColInfoData, numOfRows);
339!
223
        continue;
339✔
224
      }
225

226
      SLastCol* pColVal = (SLastCol*)taosArrayGet(pRow, i);
2,626✔
227
      TSDB_CHECK_NULL(pColVal, code, lino, _end, TSDB_CODE_INVALID_PARA);
2,628!
228

229
      code = saveOneRowForLastRaw(pColVal, pReader, slotId, pColInfoData, numOfRows);
2,628✔
230
      TSDB_CHECK_CODE(code, lino, _end);
2,626!
231
    }
232

233
    // pBlock->info.rows += allNullRow ? 0 : 1;
234
    ++pBlock->info.rows;
1,337✔
235
  } else {
236
    tsdbError("invalid retrieve type:%d, %s", pReader->type, idStr);
×
237
    code = TSDB_CODE_INVALID_PARA;
×
238
    TSDB_CHECK_CODE(code, lino, _end);
×
239
  }
240

241
_end:
×
242
  if (code != TSDB_CODE_SUCCESS) {
3,129!
243
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
244
  }
245
  if (funcTypeBlockArray != NULL) {
3,130✔
246
    taosArrayDestroy(funcTypeBlockArray);
1,792✔
247
  }
248
  return code;
3,129✔
249
}
250

251
static int32_t setTableSchema(SCacheRowsReader* p, uint64_t suid, const char* idstr) {
3,560✔
252
  int32_t code = TSDB_CODE_SUCCESS;
3,560✔
253
  int32_t lino = 0;
3,560✔
254
  int32_t numOfTables = 0;
3,560✔
255

256
  TSDB_CHECK_NULL(p, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,560!
257

258
  numOfTables = p->numOfTables;
3,560✔
259

260
  if (suid != 0) {
3,560✔
261
    code = metaGetTbTSchemaNotNull(p->pVnode->pMeta, suid, -1, 1, &p->pSchema);
3,440✔
262
    if (TSDB_CODE_SUCCESS != code) {
3,445!
263
      tsdbWarn("stable:%" PRIu64 " has been dropped, failed to retrieve cached rows, %s", suid, idstr);
×
264
      if (code == TSDB_CODE_NOT_FOUND) {
×
265
        code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
266
      }
267
      TSDB_CHECK_CODE(code, lino, _end);
×
268
    }
269
  } else {
270
    for (int32_t i = 0; i < numOfTables; ++i) {
120!
271
      uint64_t uid = p->pTableList[i].uid;
121✔
272
      code = metaGetTbTSchemaMaybeNull(p->pVnode->pMeta, uid, -1, 1, &p->pSchema);
121✔
273
      TSDB_CHECK_CODE(code, lino, _end);
121!
274
      if (p->pSchema != NULL) {
121!
275
        break;
121✔
276
      }
277

278
      tsdbWarn("table:%" PRIu64 " has been dropped, failed to retrieve cached rows, %s", uid, idstr);
×
279
    }
280

281
    // all queried tables have been dropped already, return immediately.
282
    if (p->pSchema == NULL) {
120!
283
      tsdbWarn("all queried tables has been dropped, try next group, %s", idstr);
×
284
      code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
285
      TSDB_CHECK_CODE(code, lino, _end);
×
286
    }
287
  }
288

289
_end:
120✔
290
  if (code != TSDB_CODE_SUCCESS) {
3,565!
291
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
292
  }
293
  return code;
3,563✔
294
}
295

296
int32_t tsdbReuseCacherowsReader(void* reader, void* pTableIdList, int32_t numOfTables) {
291✔
297
  int32_t           code = TSDB_CODE_SUCCESS;
291✔
298
  int32_t           lino = 0;
291✔
299
  SCacheRowsReader* pReader = (SCacheRowsReader*)reader;
291✔
300

301
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
291!
302

303
  pReader->pTableList = pTableIdList;
291✔
304
  pReader->numOfTables = numOfTables;
291✔
305
  pReader->lastTs = INT64_MIN;
291✔
306
  destroySttBlockReader(pReader->pLDataIterArray, NULL);
291✔
307
  pReader->pLDataIterArray = taosArrayInit(4, POINTER_BYTES);
291✔
308
  TSDB_CHECK_NULL(pReader->pLDataIterArray, code, lino, _end, terrno);
291!
309

310
_end:
291✔
311
  if (code != TSDB_CODE_SUCCESS) {
291!
312
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
313
  }
314
  return code;
291✔
315
}
316

317
int32_t tsdbCacherowsReaderOpen(void* pVnode, int32_t type, void* pTableIdList, int32_t numOfTables, int32_t numOfCols,
3,554✔
318
                                SArray* pCidList, int32_t* pSlotIds, uint64_t suid, void** pReader, const char* idstr,
319
                                SArray* pFuncTypeList, SColumnInfo* pPkCol, int32_t numOfPks) {
320
  int32_t           code = TSDB_CODE_SUCCESS;
3,554✔
321
  int32_t           lino = 0;
3,554✔
322
  SCacheRowsReader* p = NULL;
3,554✔
323

324
  TSDB_CHECK_NULL(pVnode, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,554!
325
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
3,554!
326

327
  *pReader = NULL;
3,554✔
328
  p = taosMemoryCalloc(1, sizeof(SCacheRowsReader));
3,554!
329
  TSDB_CHECK_NULL(p, code, lino, _end, terrno);
3,560!
330

331
  p->type = type;
3,560✔
332
  p->pVnode = pVnode;
3,560✔
333
  p->pTsdb = p->pVnode->pTsdb;
3,560✔
334
  p->info.verRange = (SVersionRange){.minVer = 0, .maxVer = INT64_MAX};
3,560✔
335
  p->info.suid = suid;
3,560✔
336
  p->numOfCols = numOfCols;
3,560✔
337
  p->pCidList = pCidList;
3,560✔
338
  p->pSlotIds = pSlotIds;
3,560✔
339
  p->pFuncTypeList = pFuncTypeList;
3,560✔
340

341
  p->rowKey.numOfPKs = numOfPks;
3,560✔
342
  if (numOfPks > 0) {
3,560✔
343
    TSDB_CHECK_NULL(pPkCol, code, lino, _end, TSDB_CODE_INVALID_PARA);
36!
344
    p->rowKey.pks[0].type = pPkCol->type;
36✔
345
    if (IS_VAR_DATA_TYPE(pPkCol->type)) {
36!
346
      p->rowKey.pks[0].pData = taosMemoryCalloc(1, pPkCol->bytes);
×
347
      if (p->rowKey.pks[0].pData == NULL) {
×
348
        taosMemoryFreeClear(p);
×
349
        code = terrno;
×
350
        TSDB_CHECK_CODE(code, lino, _end);
×
351
      }
352
    }
353

354
    p->pkColumn = *pPkCol;
36✔
355
  }
356

357
  if (numOfTables == 0) {
3,560!
358
    *pReader = p;
×
359
    p = NULL;
×
360
    goto _end;
×
361
  }
362

363
  p->pTableList = pTableIdList;
3,560✔
364
  p->numOfTables = numOfTables;
3,560✔
365

366
  code = setTableSchema(p, suid, idstr);
3,560✔
367
  TSDB_CHECK_CODE(code, lino, _end);
3,562!
368

369
  p->transferBuf = taosMemoryCalloc(p->pSchema->numOfCols, POINTER_BYTES);
3,562!
370
  TSDB_CHECK_NULL(p->transferBuf, code, lino, _end, terrno);
3,564!
371

372
  for (int32_t i = 0; i < p->pSchema->numOfCols; ++i) {
82,973✔
373
    if (IS_VAR_DATA_TYPE(p->pSchema->columns[i].type)) {
79,389!
374
      p->transferBuf[i] = taosMemoryMalloc(p->pSchema->columns[i].bytes);
9,049!
375
      TSDB_CHECK_NULL(p->transferBuf[i], code, lino, _end, terrno);
9,069!
376
    }
377
  }
378

379
  if (idstr != NULL) {
3,584✔
380
    p->idstr = taosStrdup(idstr);
3,565!
381
    TSDB_CHECK_NULL(p->idstr, code, lino, _end, terrno);
3,564!
382
  }
383
  code = taosThreadMutexInit(&p->readerMutex, NULL);
3,583✔
384
  TSDB_CHECK_CODE(code, lino, _end);
3,563!
385

386
  p->lastTs = INT64_MIN;
3,563✔
387

388
  *pReader = p;
3,563✔
389
  p = NULL;
3,563✔
390

391
_end:
3,563✔
392
  if (code != TSDB_CODE_SUCCESS) {
3,563!
393
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
394
    *pReader = NULL;
×
395
  }
396
  if (p != NULL) {
3,563!
397
    tsdbCacherowsReaderClose(p);
×
398
  }
399
  return code;
3,563✔
400
}
401

402
void tsdbCacherowsReaderClose(void* pReader) {
3,568✔
403
  SCacheRowsReader* p = pReader;
3,568✔
404
  if (p == NULL) {
3,568!
405
    return;
×
406
  }
407

408
  if (p->pSchema != NULL && p->transferBuf != NULL) {
3,568!
409
    for (int32_t i = 0; i < p->pSchema->numOfCols; ++i) {
83,165✔
410
      taosMemoryFreeClear(p->transferBuf[i]);
79,597!
411
    }
412

413
    taosMemoryFree(p->transferBuf);
3,568!
414
    taosMemoryFree(p->pSchema);
3,569!
415
  }
416

417
  taosMemoryFree(p->pCurrSchema);
3,567!
418

419
  if (p->rowKey.numOfPKs > 0) {
3,569✔
420
    for (int32_t i = 0; i < p->rowKey.numOfPKs; i++) {
72✔
421
      if (IS_VAR_DATA_TYPE(p->rowKey.pks[i].type)) {
36!
422
        taosMemoryFree(p->rowKey.pks[i].pData);
×
423
      }
424
    }
425
  }
426

427
  if (p->pLDataIterArray) {
3,569✔
428
    destroySttBlockReader(p->pLDataIterArray, NULL);
128✔
429
    p->pLDataIterArray = NULL;
128✔
430
  }
431

432
  if (p->pFileReader) {
3,569!
433
    tsdbDataFileReaderClose(&p->pFileReader);
×
434
    p->pFileReader = NULL;
×
435
  }
436

437
  taosMemoryFree((void*)p->idstr);
3,569!
438
  (void)taosThreadMutexDestroy(&p->readerMutex);
3,567✔
439

440
  if (p->pTableMap) {
3,566✔
441
    void*   pe = NULL;
2,798✔
442
    int32_t iter = 0;
2,798✔
443
    while ((pe = tSimpleHashIterate(p->pTableMap, pe, &iter)) != NULL) {
7,467✔
444
      STableLoadInfo* pInfo = *(STableLoadInfo**)pe;
4,669✔
445
      taosArrayDestroy(pInfo->pTombData);
4,669✔
446
      pInfo->pTombData = NULL;
4,669✔
447
    }
448

449
    tSimpleHashCleanup(p->pTableMap);
2,800✔
450
  }
451
  if (p->uidList) {
3,569✔
452
    taosMemoryFree(p->uidList);
12!
453
  }
454

455
  taosMemoryFree(pReader);
3,569!
456
}
457

458
static int32_t tsdbCacheQueryReseek(void* pQHandle) {
×
459
  int32_t           code = 0;
×
460
  SCacheRowsReader* pReader = pQHandle;
×
461

462
  code = taosThreadMutexTryLock(&pReader->readerMutex);
×
463
  if (code == 0) {
×
464
    // pause current reader's state if not paused, save ts & version for resuming
465
    // just wait for the big all tables' snapshot untaking for now
466

467
    code = TSDB_CODE_VND_QUERY_BUSY;
×
468
    (void)taosThreadMutexUnlock(&pReader->readerMutex);
×
469

470
    return code;
×
471
  } else if (code == EBUSY) {
×
472
    return TSDB_CODE_VND_QUERY_BUSY;
×
473
  } else {
474
    return -1;
×
475
  }
476
}
477

478
int32_t tsdbRetrieveCacheRows(void* pReader, SSDataBlock* pResBlock, const int32_t* slotIds, const int32_t* dstSlotIds,
5,378✔
479
                              SArray* pTableUidList, bool* pGotAll) {
480
  int32_t           code = TSDB_CODE_SUCCESS;
5,378✔
481
  int32_t           lino = 0;
5,378✔
482
  bool              hasRes = false;
5,378✔
483
  SArray*           pRow = NULL;
5,378✔
484
  void**            pRes = NULL;
5,378✔
485
  SCacheRowsReader* pr = NULL;
5,378✔
486
  int32_t           pkBufLen = 0;
5,378✔
487

488
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
5,378!
489
  TSDB_CHECK_NULL(pResBlock, code, lino, _end, TSDB_CODE_INVALID_PARA);
5,378!
490

491
  pr = pReader;
5,378✔
492

493
  pr->pReadSnap = NULL;
5,378✔
494
  pRow = taosArrayInit(TARRAY_SIZE(pr->pCidList), sizeof(SLastCol));
5,378✔
495
  TSDB_CHECK_NULL(pRow, code, lino, _end, terrno);
5,382!
496

497
  pRes = taosMemoryCalloc(pr->numOfCols, POINTER_BYTES);
5,382!
498
  TSDB_CHECK_NULL(pRes, code, lino, _end, terrno);
5,386!
499

500
  pkBufLen = (pr->rowKey.numOfPKs > 0) ? pr->pkColumn.bytes : 0;
5,386✔
501
  for (int32_t j = 0; j < pr->numOfCols; ++j) {
15,696✔
502
    int32_t bytes = (slotIds[j] == -1) ? 1 : pr->pSchema->columns[slotIds[j]].bytes;
10,307✔
503

504
    pRes[j] = taosMemoryCalloc(1, sizeof(SFirstLastRes) + bytes + pkBufLen + VARSTR_HEADER_SIZE);
10,307!
505
    TSDB_CHECK_NULL(pRes[j], code, lino, _end, terrno);
10,310!
506

507
    SFirstLastRes* p = (SFirstLastRes*)varDataVal(pRes[j]);
10,310✔
508
    p->ts = INT64_MIN;
10,310✔
509
  }
510

511
  (void)taosThreadMutexLock(&pr->readerMutex);
5,389✔
512
  code = tsdbTakeReadSnap2((STsdbReader*)pr, tsdbCacheQueryReseek, &pr->pReadSnap, pr->idstr);
5,380✔
513
  TSDB_CHECK_CODE(code, lino, _end);
5,382!
514

515
  int8_t ltype = (pr->type & CACHESCAN_RETRIEVE_LAST) >> 3;
5,382✔
516

517
  STableKeyInfo* pTableList = pr->pTableList;
5,382✔
518

519
  // retrieve the only one last row of all tables in the uid list.
520
  if (HASTYPE(pr->type, CACHESCAN_RETRIEVE_TYPE_SINGLE)) {
5,382✔
521
    SArray* pLastCols = taosArrayInit(pr->numOfCols, sizeof(SLastCol));
1,531✔
522
    TSDB_CHECK_NULL(pLastCols, code, lino, _end, terrno);
1,530!
523

524
    for (int32_t i = 0; i < pr->numOfCols; ++i) {
3,950✔
525
      int32_t slotId = slotIds[i];
2,422✔
526
      if (slotId == -1) {
2,422✔
527
        SLastCol p = {.rowKey.ts = INT64_MIN, .colVal.value.type = TSDB_DATA_TYPE_BOOL, .colVal.flag = CV_FLAG_NULL};
267✔
528
        void*    px = taosArrayPush(pLastCols, &p);
267✔
529
        TSDB_CHECK_NULL(px, code, lino, _end, terrno);
267!
530
        continue;
267✔
531
      }
532
      struct STColumn* pCol = &pr->pSchema->columns[slotId];
2,155✔
533
      SLastCol         p = {.rowKey.ts = INT64_MIN, .colVal.value.type = pCol->type, .colVal.flag = CV_FLAG_NULL};
2,155✔
534

535
      if (pr->rowKey.numOfPKs > 0) {
2,155!
536
        p.rowKey.numOfPKs = pr->rowKey.numOfPKs;
×
537
        for (int32_t j = 0; j < pr->rowKey.numOfPKs; j++) {
×
538
          p.rowKey.pks[j].type = pr->pkColumn.type;
×
539
          if (IS_VAR_DATA_TYPE(pr->pkColumn.type)) {
×
540
            p.rowKey.pks[j].pData = taosMemoryCalloc(1, pr->pkColumn.bytes);
×
541
            TSDB_CHECK_NULL(p.rowKey.pks[j].pData, code, lino, _end, terrno);
×
542
          }
543
        }
544
      }
545

546
      if (IS_VAR_DATA_TYPE(pCol->type)) {
2,155!
547
        p.colVal.value.pData = taosMemoryCalloc(pCol->bytes, sizeof(char));
166!
548
        TSDB_CHECK_NULL(p.colVal.value.pData, code, lino, _end, terrno);
168!
549
      }
550

551
      void* px = taosArrayPush(pLastCols, &p);
2,153✔
552
      TSDB_CHECK_NULL(px, code, lino, _end, terrno);
2,153!
553
    }
554

555
    int64_t st = taosGetTimestampUs();
1,526✔
556
    int64_t totalLastTs = INT64_MAX;
1,526✔
557
    for (int32_t i = 0; i < pr->numOfTables; ++i) {
5,695✔
558
      tb_uid_t uid = pTableList[i].uid;
4,164✔
559

560
      code = tsdbCacheGetBatch(pr->pTsdb, uid, pRow, pr, ltype);
4,164✔
561
      if (code == -1) {  // fix the invalid return code
4,169!
562
        code = 0;
×
563
      }
564
      TSDB_CHECK_CODE(code, lino, _end);
4,169!
565

566
      if (TARRAY_SIZE(pRow) <= 0 || COL_VAL_IS_NONE(&((SLastCol*)TARRAY_DATA(pRow))[0].colVal)) {
4,169!
567
        taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
2,259✔
568
        continue;
2,259✔
569
      }
570

571
      {
572
        bool    hasNotNullRow = true;
1,910✔
573
        int64_t singleTableLastTs = INT64_MAX;
1,910✔
574
        for (int32_t k = 0; k < pr->numOfCols; ++k) {
5,279✔
575
          if (slotIds[k] == -1) continue;
3,369✔
576
          SLastCol* p = taosArrayGet(pLastCols, k);
3,281✔
577
          if (p == NULL) {
3,281!
578
            return TSDB_CODE_INVALID_PARA;
×
579
          }
580

581
          SLastCol* pColVal = (SLastCol*)taosArrayGet(pRow, k);
3,281✔
582
          if (pColVal == NULL) {
3,281!
583
            return TSDB_CODE_INVALID_PARA;
×
584
          }
585

586
          if (tRowKeyCompare(&pColVal->rowKey, &p->rowKey) > 0) {
3,281✔
587
            if (!COL_VAL_IS_VALUE(&pColVal->colVal) && HASTYPE(pr->type, CACHESCAN_RETRIEVE_LAST)) {
2,342✔
588
              if (!COL_VAL_IS_VALUE(&p->colVal)) {
169✔
589
                hasNotNullRow = false;
127✔
590
              }
591
              // For all of cols is null, the last null col of last table will be save
592
              if (i != pr->numOfTables - 1 || k != pr->numOfCols - 1 || hasRes) {
169!
593
                continue;
169✔
594
              }
595
            }
596

597
            hasRes = true;
2,173✔
598
            p->rowKey.ts = pColVal->rowKey.ts;
2,173✔
599
            for (int32_t j = 0; j < p->rowKey.numOfPKs; j++) {
2,173!
600
              if (IS_VAR_DATA_TYPE(p->rowKey.pks[j].type)) {
×
601
                memcpy(p->rowKey.pks[j].pData, pColVal->rowKey.pks[j].pData, pColVal->rowKey.pks[j].nData);
×
602
                p->rowKey.pks[j].nData = pColVal->rowKey.pks[j].nData;
×
603
              } else {
604
                p->rowKey.pks[j].val = pColVal->rowKey.pks[j].val;
×
605
              }
606
            }
607

608
            if (k == 0) {
2,173✔
609
              if (TARRAY_SIZE(pTableUidList) == 0) {
1,255✔
610
                void* px = taosArrayPush(pTableUidList, &uid);
882✔
611
                TSDB_CHECK_NULL(px, code, lino, _end, terrno);
882!
612
              } else {
613
                taosArraySet(pTableUidList, 0, &uid);
373✔
614
              }
615
            }
616

617
            if (pColVal->rowKey.ts < singleTableLastTs && HASTYPE(pr->type, CACHESCAN_RETRIEVE_LAST)) {
2,173✔
618
              singleTableLastTs = pColVal->rowKey.ts;
1,054✔
619
            }
620

621
            if (p->colVal.value.type != pColVal->colVal.value.type) {
2,173!
622
              // check for type/cid mismatch
623
              tsdbError("last cache type mismatch, uid:%" PRIu64
×
624
                        ", schema-type:%d, slotId:%d, cache-type:%d, cache-col:%d",
625
                        uid, p->colVal.value.type, slotIds[k], pColVal->colVal.value.type, pColVal->colVal.cid);
626
              taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
×
627
              code = TSDB_CODE_INVALID_PARA;
×
628
              goto _end;
×
629
            }
630

631
            if (!IS_VAR_DATA_TYPE(pColVal->colVal.value.type)) {
2,173!
632
              p->colVal = pColVal->colVal;
1,987✔
633
            } else {
634
              if (COL_VAL_IS_VALUE(&pColVal->colVal)) {
186✔
635
                memcpy(p->colVal.value.pData, pColVal->colVal.value.pData, pColVal->colVal.value.nData);
143✔
636
              }
637

638
              p->colVal.value.nData = pColVal->colVal.value.nData;
186✔
639
              p->colVal.value.type = pColVal->colVal.value.type;
186✔
640
              p->colVal.flag = pColVal->colVal.flag;
186✔
641
              p->colVal.cid = pColVal->colVal.cid;
186✔
642
            }
643
          }
644
        }
645

646
        if (hasNotNullRow) {
1,910✔
647
          if (INT64_MAX == totalLastTs || (INT64_MAX != singleTableLastTs && totalLastTs < singleTableLastTs)) {
1,900✔
648
            totalLastTs = singleTableLastTs;
1,400✔
649
          }
650
          double cost = (taosGetTimestampUs() - st) / 1000.0;
1,900✔
651
          if (cost > tsCacheLazyLoadThreshold) {
1,900✔
652
            // pr->lastTs = totalLastTs;
653
          }
654
        }
655
      }
656

657
      taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
1,910✔
658
    }
659

660
    if (hasRes) {
1,531✔
661
      code = saveOneRow(pLastCols, pResBlock, pr, slotIds, dstSlotIds, pRes, pr->idstr);
882✔
662
      TSDB_CHECK_CODE(code, lino, _end);
882!
663
    }
664

665
    taosArrayDestroyEx(pLastCols, tsdbCacheFreeSLastColItem);
1,531✔
666
  } else if (HASTYPE(pr->type, CACHESCAN_RETRIEVE_TYPE_ALL)) {
3,851!
667
    int32_t i = pr->tableIndex;
3,851✔
668
    for (; i < pr->numOfTables; ++i) {
5,845✔
669
      tb_uid_t uid = pTableList[i].uid;
3,516✔
670

671
      if ((code = tsdbCacheGetBatch(pr->pTsdb, uid, pRow, pr, ltype)) != 0) {
3,516!
672
        if (code == -1) {  // fix the invalid return code
×
673
          code = 0;
×
674
        }
675
        TSDB_CHECK_CODE(code, lino, _end);
×
676
      }
677

678
      if (TARRAY_SIZE(pRow) <= 0 || COL_VAL_IS_NONE(&((SLastCol*)TARRAY_DATA(pRow))[0].colVal)) {
3,520!
679
        taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
1,272✔
680
        continue;
1,272✔
681
      }
682

683
      code = saveOneRow(pRow, pResBlock, pr, slotIds, dstSlotIds, pRes, pr->idstr);
2,248✔
684
      TSDB_CHECK_CODE(code, lino, _end);
2,247!
685

686
      taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
2,247✔
687

688
      void* px = taosArrayPush(pTableUidList, &uid);
2,247✔
689
      TSDB_CHECK_NULL(px, code, lino, _end, terrno);
2,247!
690

691
      ++pr->tableIndex;
2,247✔
692
      if (pResBlock->info.rows >= pResBlock->info.capacity) {
2,247✔
693
        break;
1,525✔
694
      }
695
    }
696

697
    if (pGotAll && i == pr->numOfTables) {
3,854✔
698
      *pGotAll = true;
2,329✔
699
    }
700
  } else {
701
    code = TSDB_CODE_INVALID_PARA;
×
702
    TSDB_CHECK_CODE(code, lino, _end);
×
703
  }
704

705
_end:
×
706
  tsdbUntakeReadSnap2((STsdbReader*)pr, pr->pReadSnap, true);
5,385✔
707
  pr->pReadSnap = NULL;
5,386✔
708

709
  if (pr->pCurFileSet) {
5,386✔
710
    pr->pCurFileSet = NULL;
10✔
711
  }
712

713
  (void)taosThreadMutexUnlock(&pr->readerMutex);
5,386✔
714

715
  if (pRes != NULL) {
5,386!
716
    for (int32_t j = 0; j < pr->numOfCols; ++j) {
15,696✔
717
      taosMemoryFree(pRes[j]);
10,312!
718
    }
719
  }
720

721
  taosMemoryFree(pRes);
5,384!
722
  taosArrayDestroy(pRow);
5,385✔
723

724
  if (code != TSDB_CODE_SUCCESS) {
5,384!
725
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
726
  }
727
  return code;
5,384✔
728
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc