13037994271

Committed 29 Jan 2025 06:30PM UTC coverage: 1.302% (+0.3%) from 1.05%

Build # 13037994271

Build Type

push

github

Committed by

RinyVT

Commit Message

[BUGFIX] Fixed CSP issues in Cornerstone form element and Dashboard backend module, fixed some more dark mode styling issues

Run Details

8 of 28 new or added lines in 2 files covered. (28.57%)

35 of 2688 relevant lines covered (1.3%)

0.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.0

/Classes/Controller/DashboardController.php

<?php

declare(strict_types=1);

namespace YoastSeoForTypo3\YoastSeo\Controller;

use Psr\Http\Message\ResponseInterface;
use TYPO3\CMS\Core\Domain\ConsumableString;
use TYPO3\CMS\Core\Information\Typo3Version;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class DashboardController extends AbstractBackendController
{
    public function indexAction(): ResponseInterface
    {
        return $this->returnResponse(
            'Dashboard/Index',
            ['nonce' => $this->getNonce()]
        );
    }

    protected function getNonce(): string
    {
        if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 12) {
            return '';
        }
        /** @var ConsumableString|null $nonceAttribute */
        $nonceAttribute = $this->request->getAttribute('nonce');
        if ($nonceAttribute instanceof ConsumableString) {
            return $nonceAttribute->consume();
        }
        return '';
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace YoastSeoForTypo3\YoastSeo\Controller;
6
7	use Psr\Http\Message\ResponseInterface;
8	use TYPO3\CMS\Core\Domain\ConsumableString;
9	use TYPO3\CMS\Core\Information\Typo3Version;
10	use TYPO3\CMS\Core\Utility\GeneralUtility;
11
12	class DashboardController extends AbstractBackendController
13	{
14	public function indexAction(): ResponseInterface
15	{
16	return $this->returnResponse(	1✔
17	'Dashboard/Index',	1✔
18	['nonce' => $this->getNonce()]	1✔
19	);	1✔
20	}
21
22	protected function getNonce(): string
23	{
24	if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() < 12) {	1✔
NEW 25	return '';	×
26	}
27	/** @var ConsumableString\|null $nonceAttribute */
28	$nonceAttribute = $this->request->getAttribute('nonce');	1✔
29	if ($nonceAttribute instanceof ConsumableString) {	1✔
NEW 30	return $nonceAttribute->consume();	×
31	}
32	return '';	1✔
33	}
34	}

Yoast / Yoast-SEO-for-TYPO3 / 13037994271

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous