12972571759

Committed 26 Jan 2025 07:28AM UTC coverage: 75.836% (-1.7%) from 77.556%

Build # 12972571759

Build Type

push

github

Committed by

web-flow

Commit Message

Eliminate warnings (#274)

* Turn on more warnings.

* Exclude externals from warnings.

* Fix warnings in modParser

* Fix warnings in commons

* More mod parser fixes

* More fixes in OS layer

* Fixes for localization db

* Parser helper fixes

* Parser fixes

* Converter version updates

* ModLoader updates

* ConverterVersion updates

* GameVersion updates

* Update a few 'find path' functions

* Deprecate some more functions.

* Add missing file to cmake, fix compile errors.

* Add another function duplicate

* Sort some headers

* using statements

* Another override

* path -> u8path in overrides.

* Review comment.

* Include path fix.

* Formatting.

* Apply warnings stuff to MSVC project

* Make zip external

* Fix borken tests.

* Linux updates

* Disable warning on linux

* More formatting.

* Revert "Disable warning on linux"

This reverts commit 93dcb523b.

* Disable a linux warning.

* Fix last commit

* Formatting

* Try again.

* Try again

* Turn off unknown pragmas

* Restore function.

* Undo bad formatting.

* Fix some tests on linux.

* Fix another test.

* UTF16ToUTF8() on linux

* Reference instead of copy

* Only set up coverage if this is a top-level project

Run Details

279 of 358 new or added lines in 13 files covered. (77.93%)

38 existing lines in 2 files now uncovered.

1836 of 2421 relevant lines covered (75.84%)

240.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

12.5

/ModLoader/ModParser.h

#ifndef MOD_PARSER_H
#define MOD_PARSER_H


#include <filesystem>

#include "../ConvenientParser.h"
#include <set>



namespace commonItems
{
class ModParser: convenientParser
{
  public:
        ModParser() = default;
        void parseMod(std::istream& theStream);
        void parseMod(const std::filesystem::path& fileName);
        [[deprecated("Use std::filesystem::path version")]] void parseMod(const std::string& fileName);

        void parseMetadata(std::istream& theStream);
        void parseMetadata(const std::filesystem::path& fileName);
        [[deprecated("Use std::filesystem::path version")]] void parseMetadata(const std::string& fileName);

        [[nodiscard]] const auto& getName() const { return name_; }
        [[nodiscard]] const auto& getFilesystemPath() const { return path_; }
        [[deprecated("Use getFilesystemPath()")]] [[nodiscard]] const std::string getPath() const { return path_.string(); }
        [[nodiscard]] auto isValid() const { return !name_.empty() && !path_.empty(); }
        [[nodiscard]] auto isCompressed() const { return compressed_; }
        [[nodiscard]] const auto& getDependencies() const { return dependencies_; }
        [[nodiscard]] const auto& getFilesystemReplacedPaths() const { return replacedPaths_; }
        [[deprecated("Use getFilesystemReplacedPaths()")]] [[nodiscard]] const std::set<std::string> getReplacedPaths() const;

        void setPath(const std::filesystem::path& path) { path_ = path; }
        [[deprecated("Use std::filesystem::path version")]] void setPath(const std::string& path);

  private:
        void registerKeys();

        std::string name_;
        std::filesystem::path path_;
        bool compressed_ = false;
        std::set<std::string> dependencies_;
        std::set<std::filesystem::path> replacedPaths_;
};
} // namespace commonItems

#endif // MOD_PARSER_H

1	#ifndef MOD_PARSER_H
2	#define MOD_PARSER_H
3
4
5	#include <filesystem>
6
7	#include "../ConvenientParser.h"
8	#include <set>
9
10
11
12	namespace commonItems
13	{
14	class ModParser: convenientParser
15	{
16	public:
17	ModParser() = default;	×
18	void parseMod(std::istream& theStream);
19	void parseMod(const std::filesystem::path& fileName);
20	[[deprecated("Use std::filesystem::path version")]] void parseMod(const std::string& fileName);
21
22	void parseMetadata(std::istream& theStream);
23	void parseMetadata(const std::filesystem::path& fileName);
24	[[deprecated("Use std::filesystem::path version")]] void parseMetadata(const std::string& fileName);
25
NEW 26	[[nodiscard]] const auto& getName() const { return name_; }	×
NEW 27	[[nodiscard]] const auto& getFilesystemPath() const { return path_; }	×
28	[[deprecated("Use getFilesystemPath()")]] [[nodiscard]] const std::string getPath() const { return path_.string(); }
NEW 29	[[nodiscard]] auto isValid() const { return !name_.empty() && !path_.empty(); }	×
NEW 30	[[nodiscard]] auto isCompressed() const { return compressed_; }	×
NEW 31	[[nodiscard]] const auto& getDependencies() const { return dependencies_; }	×
NEW 32	[[nodiscard]] const auto& getFilesystemReplacedPaths() const { return replacedPaths_; }	×
33	[[deprecated("Use getFilesystemReplacedPaths()")]] [[nodiscard]] const std::set<std::string> getReplacedPaths() const;
34
35	void setPath(const std::filesystem::path& path) { path_ = path; }	14✔
36	[[deprecated("Use std::filesystem::path version")]] void setPath(const std::string& path);
37
38	private:
39	void registerKeys();
40
41	std::string name_;
42	std::filesystem::path path_;
43	bool compressed_ = false;
44	std::set<std::string> dependencies_;
45	std::set<std::filesystem::path> replacedPaths_;
46	};
47	} // namespace commonItems
48
49	#endif // MOD_PARSER_H

ParadoxGameConverters / commonItems / 12972571759

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous