• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3588

24 Jan 2025 08:57AM UTC coverage: 63.555% (+0.006%) from 63.549%
#3588

push

travis-ci

web-flow
Merge pull request #29638 from taosdata/docs/TS-5846-3.0

enh: TDengine modify taosBenchmark new query rule cases and add doc

141359 of 285622 branches covered (49.49%)

Branch coverage included in aggregate %.

219930 of 282844 relevant lines covered (77.76%)

19382902.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

63.59
/source/libs/executor/src/countwindowoperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "executorInt.h"
17
#include "filter.h"
18
#include "function.h"
19
#include "functionMgt.h"
20
#include "operator.h"
21
#include "querytask.h"
22
#include "tcommon.h"
23
#include "tcompare.h"
24
#include "tdatablock.h"
25
#include "ttime.h"
26

27
typedef struct SCountWindowResult {
28
  int32_t    winRows;
29
  SResultRow row;
30
} SCountWindowResult;
31

32
typedef struct SCountWindowSupp {
33
  SArray* pWinStates;
34
  int32_t stateIndex;
35
  int32_t curStateIndex;
36
} SCountWindowSupp;
37

38
typedef struct SCountWindowOperatorInfo {
39
  SOptrBasicInfo     binfo;
40
  SAggSupporter      aggSup;
41
  SExprSupp          scalarSup;
42
  int32_t            tsSlotId;  // primary timestamp column slot id
43
  STimeWindowAggSupp twAggSup;
44
  uint64_t           groupId;  // current group id, used to identify the data block from different groups
45
  SResultRow*        pRow;
46
  int32_t            windowCount;
47
  int32_t            windowSliding;
48
  SCountWindowSupp   countSup;
49
  SSDataBlock*       pPreDataBlock;
50
  int32_t            preStateIndex;
51
} SCountWindowOperatorInfo;
52

53
void destroyCountWindowOperatorInfo(void* param) {
373✔
54
  SCountWindowOperatorInfo* pInfo = (SCountWindowOperatorInfo*)param;
373✔
55
  if (pInfo == NULL) {
373!
56
    return;
×
57
  }
58
  cleanupBasicInfo(&pInfo->binfo);
373✔
59
  colDataDestroy(&pInfo->twAggSup.timeWindowData);
373✔
60

61
  cleanupAggSup(&pInfo->aggSup);
373✔
62
  cleanupExprSupp(&pInfo->scalarSup);
373✔
63
  taosArrayDestroy(pInfo->countSup.pWinStates);
373✔
64
  taosMemoryFreeClear(param);
373!
65
}
66

67
static int32_t countWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes);
68

69
static void clearWinStateBuff(SCountWindowResult* pBuff) { pBuff->winRows = 0; }
5,385✔
70

71
static SCountWindowResult* getCountWinStateInfo(SCountWindowSupp* pCountSup) {
10,092✔
72
  SCountWindowResult* pBuffInfo = taosArrayGet(pCountSup->pWinStates, pCountSup->stateIndex);
10,092✔
73
  pCountSup->curStateIndex = pCountSup->stateIndex;
10,092✔
74
  if (!pBuffInfo) {
10,092!
75
    terrno = TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
76
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
×
77
    return NULL;
×
78
  }
79
  int32_t size = taosArrayGetSize(pCountSup->pWinStates);
10,092✔
80
  if (size == 0) {
10,092!
81
    terrno = TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
82
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
×
83
    return NULL;
×
84
  }
85
  pCountSup->stateIndex = (pCountSup->stateIndex + 1) % size;
10,092✔
86
  return pBuffInfo;
10,092✔
87
}
88

89
static int32_t setCountWindowOutputBuff(SExprSupp* pExprSup, SCountWindowSupp* pCountSup, SResultRow** pResult,
10,092✔
90
                                        SCountWindowResult** ppResBuff) {
91
  int32_t             code = TSDB_CODE_SUCCESS;
10,092✔
92
  int32_t             lino = 0;
10,092✔
93
  SCountWindowResult* pBuff = getCountWinStateInfo(pCountSup);
10,092✔
94
  QUERY_CHECK_NULL(pBuff, code, lino, _end, terrno);
10,092!
95
  (*pResult) = &pBuff->row;
10,092✔
96
  code = setResultRowInitCtx(*pResult, pExprSup->pCtx, pExprSup->numOfExprs, pExprSup->rowEntryInfoOffset);
10,092✔
97
  (*ppResBuff) = pBuff;
10,092✔
98

99
_end:
10,092✔
100
  if (code != TSDB_CODE_SUCCESS) {
10,092!
101
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
102
  }
103
  return code;
10,092✔
104
}
105

106
static int32_t updateCountWindowInfo(int32_t start, int32_t blockRows, int32_t countWinRows, int32_t* pCurrentRows) {
6,287✔
107
  int32_t rows = TMIN(countWinRows - (*pCurrentRows), blockRows - start);
6,287✔
108
  (*pCurrentRows) += rows;
6,287✔
109
  return rows;
6,287✔
110
}
111

112
void doCountWindowAggImpl(SOperatorInfo* pOperator, SSDataBlock* pBlock) {
4,139✔
113
  int32_t                   code = TSDB_CODE_SUCCESS;
4,139✔
114
  int32_t                   lino = 0;
4,139✔
115
  SExecTaskInfo*            pTaskInfo = pOperator->pTaskInfo;
4,139✔
116
  SExprSupp*                pExprSup = &pOperator->exprSupp;
4,139✔
117
  SCountWindowOperatorInfo* pInfo = pOperator->info;
4,139✔
118
  SSDataBlock*              pRes = pInfo->binfo.pRes;
4,139✔
119
  SColumnInfoData*          pColInfoData = taosArrayGet(pBlock->pDataBlock, pInfo->tsSlotId);
4,139✔
120
  QUERY_CHECK_NULL(pColInfoData, code, lino, _end, terrno);
4,139!
121
  TSKEY* tsCols = (TSKEY*)pColInfoData->pData;
4,139✔
122
  int32_t numOfBuff = taosArrayGetSize(pInfo->countSup.pWinStates);
4,139✔
123
  if (numOfBuff == 0) {
4,139!
124
    code = TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
125
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
126
    T_LONG_JMP(pTaskInfo->env, code);
×
127
  }
128
  pInfo->countSup.stateIndex = (pInfo->preStateIndex + 1) % numOfBuff;
4,139✔
129

130
  int32_t newSize = pRes->info.rows + pBlock->info.rows / pInfo->windowSliding + 1;
4,139✔
131
  if (newSize > pRes->info.capacity) {
4,139!
132
    code = blockDataEnsureCapacity(pRes, newSize);
×
133
    QUERY_CHECK_CODE(code, lino, _end);
×
134
  }
135

136
  for (int32_t i = 0; i < pBlock->info.rows;) {
10,426✔
137
    SCountWindowResult* pBuffInfo = NULL;
6,287✔
138
    code = setCountWindowOutputBuff(pExprSup, &pInfo->countSup, &pInfo->pRow, &pBuffInfo);
6,287✔
139
    if (code != TSDB_CODE_SUCCESS) {
6,287!
140
      qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
141
      T_LONG_JMP(pTaskInfo->env, code);
×
142
    }
143
    int32_t prevRows = pBuffInfo->winRows;
6,287✔
144
    int32_t num = updateCountWindowInfo(i, pBlock->info.rows, pInfo->windowCount, &pBuffInfo->winRows);
6,287✔
145
    int32_t step = num;
6,287✔
146
    if (prevRows == 0) {
6,287✔
147
      pInfo->pRow->win.skey = tsCols[i];
5,385✔
148
    }
149
    pInfo->pRow->win.ekey = tsCols[num + i - 1];
6,287✔
150

151
    updateTimeWindowInfo(&pInfo->twAggSup.timeWindowData, &pInfo->pRow->win, 0);
6,287✔
152
    code = applyAggFunctionOnPartialTuples(pTaskInfo, pExprSup->pCtx, &pInfo->twAggSup.timeWindowData, i, num,
6,287✔
153
                                           pBlock->info.rows, pExprSup->numOfExprs);
6,287✔
154
    QUERY_CHECK_CODE(code, lino, _end);
6,287!
155
    if (pInfo->windowCount != pInfo->windowSliding) {
6,287✔
156
      if (prevRows <= pInfo->windowSliding) {
538!
157
        if (pBuffInfo->winRows > pInfo->windowSliding) {
538✔
158
          step = pInfo->windowSliding - prevRows;
506✔
159
        } else {
160
          step = pInfo->windowSliding;
32✔
161
        }
162
      } else {
163
        step = 0;
×
164
      }
165
    }
166
    if (pBuffInfo->winRows == pInfo->windowCount) {
6,287✔
167
      doUpdateNumOfRows(pExprSup->pCtx, pInfo->pRow, pExprSup->numOfExprs, pExprSup->rowEntryInfoOffset);
2,751✔
168
      code = copyResultrowToDataBlock(pExprSup->pExprInfo, pExprSup->numOfExprs, pInfo->pRow, pExprSup->pCtx, pRes,
2,751✔
169
                                      pExprSup->rowEntryInfoOffset, pTaskInfo);
2,751✔
170
      QUERY_CHECK_CODE(code, lino, _end);
2,751!
171
      pRes->info.rows += pInfo->pRow->numOfRows;
2,751✔
172
      clearWinStateBuff(pBuffInfo);
2,751✔
173
      pInfo->preStateIndex = pInfo->countSup.curStateIndex;
2,751✔
174
      clearResultRowInitFlag(pExprSup->pCtx, pExprSup->numOfExprs);
2,751✔
175
    }
176
    i += step;
6,287✔
177
  }
178

179
  code = doFilter(pRes, pOperator->exprSupp.pFilterInfo, NULL);
4,139✔
180
  QUERY_CHECK_CODE(code, lino, _end);
4,139!
181

182
_end:
4,139✔
183
  if (code != TSDB_CODE_SUCCESS) {
4,139!
184
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
185
    pTaskInfo->code = code;
×
186
    T_LONG_JMP(pTaskInfo->env, code);
×
187
  }
188
}
4,139✔
189

190
static void buildCountResult(SExprSupp* pExprSup, SCountWindowSupp* pCountSup, SExecTaskInfo* pTaskInfo,
3,573✔
191
                             SFilterInfo* pFilterInfo, int32_t preStateIndex, SSDataBlock* pBlock) {
192
  SResultRow* pResultRow = NULL;
3,573✔
193
  int32_t     code = TSDB_CODE_SUCCESS;
3,573✔
194
  int32_t     lino = 0;
3,573✔
195
  int32_t     numOfBuff = taosArrayGetSize(pCountSup->pWinStates);
3,573✔
196
  int32_t     newSize = pBlock->info.rows + numOfBuff;
3,573✔
197
  if (newSize > pBlock->info.capacity) {
3,573!
198
    code = blockDataEnsureCapacity(pBlock, newSize);
×
199
    QUERY_CHECK_CODE(code, lino, _end);
×
200
  }
201
  pCountSup->stateIndex = (preStateIndex + 1) % numOfBuff;
3,573✔
202
  for (int32_t i = 0; i < numOfBuff; i++) {
7,378✔
203
    SCountWindowResult* pBuff = NULL;
3,805✔
204
    code = setCountWindowOutputBuff(pExprSup, pCountSup, &pResultRow, &pBuff);
3,805✔
205
    QUERY_CHECK_CODE(code, lino, _end);
3,805!
206
    if (pBuff->winRows == 0) {
3,805✔
207
      continue;
1,171✔
208
    }
209
    doUpdateNumOfRows(pExprSup->pCtx, pResultRow, pExprSup->numOfExprs, pExprSup->rowEntryInfoOffset);
2,634✔
210
    code = copyResultrowToDataBlock(pExprSup->pExprInfo, pExprSup->numOfExprs, pResultRow, pExprSup->pCtx, pBlock,
2,634✔
211
                                    pExprSup->rowEntryInfoOffset, pTaskInfo);
2,634✔
212
    QUERY_CHECK_CODE(code, lino, _end);
2,634!
213
    pBlock->info.rows += pResultRow->numOfRows;
2,634✔
214
    clearWinStateBuff(pBuff);
2,634✔
215
    clearResultRowInitFlag(pExprSup->pCtx, pExprSup->numOfExprs);
2,634✔
216
  }
217
  code = doFilter(pBlock, pFilterInfo, NULL);
3,573✔
218
  QUERY_CHECK_CODE(code, lino, _end);
3,573!
219

220
_end:
3,573✔
221
  if (code != TSDB_CODE_SUCCESS) {
3,573!
222
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
223
    T_LONG_JMP(pTaskInfo->env, code);
×
224
  }
225
}
3,573✔
226

227
static int32_t countWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
2,671✔
228
  int32_t                   code = TSDB_CODE_SUCCESS;
2,671✔
229
  int32_t                   lino = 0;
2,671✔
230
  SCountWindowOperatorInfo* pInfo = pOperator->info;
2,671✔
231
  SExecTaskInfo*            pTaskInfo = pOperator->pTaskInfo;
2,671✔
232
  SExprSupp*                pExprSup = &pOperator->exprSupp;
2,671✔
233
  int32_t                   order = pInfo->binfo.inputTsOrder;
2,671✔
234
  SSDataBlock*              pRes = pInfo->binfo.pRes;
2,671✔
235

236
  blockDataCleanup(pRes);
2,671✔
237

238
  while (1) {
4,139✔
239
    SSDataBlock* pBlock = NULL;
6,810✔
240
    if (pInfo->pPreDataBlock == NULL) { 
6,810✔
241
      pBlock = getNextBlockFromDownstream(pOperator, 0);
3,926✔
242
    } else {
243
      pBlock = pInfo->pPreDataBlock;
2,884✔
244
      pInfo->pPreDataBlock = NULL;
2,884✔
245
    }
246

247
    if (pBlock == NULL) {
6,810✔
248
      break;
689✔
249
    }
250

251
    pRes->info.scanFlag = pBlock->info.scanFlag;
6,121✔
252
    code = setInputDataBlock(pExprSup, pBlock, order, MAIN_SCAN, true);
6,121✔
253
    QUERY_CHECK_CODE(code, lino, _end);
6,121!
254

255
    code = blockDataUpdateTsWindow(pBlock, pInfo->tsSlotId);
6,121✔
256
    QUERY_CHECK_CODE(code, lino, _end);
6,121!
257

258
    // there is an scalar expression that needs to be calculated right before apply the group aggregation.
259
    if (pInfo->scalarSup.pExprInfo != NULL) {
6,121!
260
      code = projectApplyFunctions(pInfo->scalarSup.pExprInfo, pBlock, pBlock, pInfo->scalarSup.pCtx,
×
261
                                   pInfo->scalarSup.numOfExprs, NULL);
262
      QUERY_CHECK_CODE(code, lino, _end);
×
263
    }
264

265
    if (pInfo->groupId == 0) {
6,121✔
266
      pInfo->groupId = pBlock->info.id.groupId;
353✔
267
    } else if (pInfo->groupId != pBlock->info.id.groupId) {
5,768✔
268
      pInfo->pPreDataBlock = pBlock;
2,884✔
269
      pRes->info.id.groupId = pInfo->groupId;
2,884✔
270
      buildCountResult(pExprSup, &pInfo->countSup, pTaskInfo, pOperator->exprSupp.pFilterInfo, pInfo->preStateIndex, pRes);
2,884✔
271
      pInfo->groupId = pBlock->info.id.groupId;
2,884✔
272
      if (pRes->info.rows > 0) {
2,884✔
273
        (*ppRes) = pRes;
1,982✔
274
        return code;
1,982✔
275
      }
276
    }
277

278
    doCountWindowAggImpl(pOperator, pBlock);
4,139✔
279
    if (pRes->info.rows >= pOperator->resultInfo.threshold) {
4,139!
280
      pRes->info.id.groupId = pInfo->groupId;
×
281
      (*ppRes) = pRes;
×
282
      return code;
×
283
    }
284
  }
285

286
  pRes->info.id.groupId = pInfo->groupId;
689✔
287
  buildCountResult(pExprSup, &pInfo->countSup, pTaskInfo, pOperator->exprSupp.pFilterInfo, pInfo->preStateIndex, pRes);
689✔
288

289
_end:
689✔
290
  if (code != TSDB_CODE_SUCCESS) {
689!
291
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
292
    pTaskInfo->code = code;
×
293
    T_LONG_JMP(pTaskInfo->env, code);
×
294
  }
295
  (*ppRes) = pRes->info.rows == 0 ? NULL : pRes;
689✔
296
  return code;
689✔
297
}
298

299
int32_t createCountwindowOperatorInfo(SOperatorInfo* downstream, SPhysiNode* physiNode,
373✔
300
                                             SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
301
  QRY_PARAM_CHECK(pOptrInfo);
373!
302

303
  int32_t                   code = TSDB_CODE_SUCCESS;
373✔
304
  int32_t                   lino = 0;
373✔
305
  SCountWindowOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SCountWindowOperatorInfo));
373!
306
  SOperatorInfo*            pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
373!
307
  if (pInfo == NULL || pOperator == NULL) {
373!
308
    code = terrno;
×
309
    goto _error;
×
310
  }
311

312
  pOperator->exprSupp.hasWindowOrGroup = true;
373✔
313

314
  SCountWinodwPhysiNode* pCountWindowNode = (SCountWinodwPhysiNode*)physiNode;
373✔
315

316
  pInfo->tsSlotId = ((SColumnNode*)pCountWindowNode->window.pTspk)->slotId;
373✔
317

318
  if (pCountWindowNode->window.pExprs != NULL) {
373!
319
    int32_t    numOfScalarExpr = 0;
×
320
    SExprInfo* pScalarExprInfo = NULL;
×
321
    code = createExprInfo(pCountWindowNode->window.pExprs, NULL, &pScalarExprInfo, &numOfScalarExpr);
×
322
    QUERY_CHECK_CODE(code, lino, _error);
×
323
    code = initExprSupp(&pInfo->scalarSup, pScalarExprInfo, numOfScalarExpr, &pTaskInfo->storageAPI.functionStore);
×
324
    QUERY_CHECK_CODE(code, lino, _error);
×
325
  }
326

327
  size_t     keyBufSize = 0;
373✔
328
  int32_t    num = 0;
373✔
329
  SExprInfo* pExprInfo = NULL;
373✔
330
  code = createExprInfo(pCountWindowNode->window.pFuncs, NULL, &pExprInfo, &num);
373✔
331
  QUERY_CHECK_CODE(code, lino, _error);
373!
332

333
  initResultSizeInfo(&pOperator->resultInfo, 4096);
373✔
334

335
  code = initAggSup(&pOperator->exprSupp, &pInfo->aggSup, pExprInfo, num, keyBufSize, pTaskInfo->id.str,
373✔
336
                    pTaskInfo->streamInfo.pState, &pTaskInfo->storageAPI.functionStore);
373✔
337
  QUERY_CHECK_CODE(code, lino, _error);
373!
338

339
  SSDataBlock* pResBlock = createDataBlockFromDescNode(pCountWindowNode->window.node.pOutputDataBlockDesc);
373✔
340
  QUERY_CHECK_NULL(pResBlock, code, lino, _error, terrno);
373!
341
  initBasicInfo(&pInfo->binfo, pResBlock);
373✔
342

343
  code = blockDataEnsureCapacity(pResBlock, pOperator->resultInfo.capacity);
373✔
344
  QUERY_CHECK_CODE(code, lino, _error);
373!
345

346
  initResultRowInfo(&pInfo->binfo.resultRowInfo);
373✔
347
  pInfo->binfo.inputTsOrder = physiNode->inputTsOrder;
373✔
348
  pInfo->binfo.outputTsOrder = physiNode->outputTsOrder;
373✔
349
  pInfo->windowCount = pCountWindowNode->windowCount;
373✔
350
  pInfo->windowSliding = pCountWindowNode->windowSliding;
373✔
351
  // sizeof(SCountWindowResult)
352
  int32_t itemSize = sizeof(int32_t) + pInfo->aggSup.resultRowSize;
373✔
353
  int32_t numOfItem = 1;
373✔
354
  if (pInfo->windowCount != pInfo->windowSliding) {
373✔
355
    numOfItem = pInfo->windowCount / pInfo->windowSliding + 1;
50✔
356
  }
357

358
  pInfo->countSup.pWinStates = taosArrayInit_s(itemSize, numOfItem);
373✔
359
  if (!pInfo->countSup.pWinStates) {
373!
360
    goto _error;
×
361
  }
362

363
  pInfo->countSup.stateIndex = 0;
373✔
364
  pInfo->pPreDataBlock = NULL;
373✔
365
  pInfo->preStateIndex = 0;
373✔
366

367
  code = filterInitFromNode((SNode*)pCountWindowNode->window.node.pConditions, &pOperator->exprSupp.pFilterInfo, 0);
373✔
368
  QUERY_CHECK_CODE(code, lino, _error);
373!
369

370
  code = initExecTimeWindowInfo(&pInfo->twAggSup.timeWindowData, &pTaskInfo->window);
373✔
371
  QUERY_CHECK_CODE(code, lino, _error);
373!
372

373
  setOperatorInfo(pOperator, "CountWindowOperator", QUERY_NODE_PHYSICAL_PLAN_MERGE_COUNT, true, OP_NOT_OPENED, pInfo,
373✔
374
                  pTaskInfo);
375
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, countWindowAggregateNext, NULL, destroyCountWindowOperatorInfo,
373✔
376
                                         optrDefaultBufFn, NULL, optrDefaultGetNextExtFn, NULL);
377

378
  code = appendDownstream(pOperator, &downstream, 1);
373✔
379
  if (code != TSDB_CODE_SUCCESS) {
373!
380
    goto _error;
×
381
  }
382

383
  *pOptrInfo = pOperator;
373✔
384
  return TSDB_CODE_SUCCESS;
373✔
385

386
_error:
×
387
  if (pInfo != NULL) {
×
388
    destroyCountWindowOperatorInfo(pInfo);
×
389
  }
390

391
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
392
  pTaskInfo->code = code;
×
393
  return code;
×
394
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc