• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3586

22 Jan 2025 05:37AM UTC coverage: 63.643% (-0.004%) from 63.647%
#3586

push

travis-ci

web-flow
Merge pull request #29612 from taosdata/fix/TD-33556

fix:[TD-33556] tmq close elegantly to avoid invalid read in TD-32585

140971 of 284575 branches covered (49.54%)

Branch coverage included in aggregate %.

19 of 27 new or added lines in 2 files covered. (70.37%)

655 existing lines in 114 files now uncovered.

219468 of 281768 relevant lines covered (77.89%)

19335507.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.52
/source/dnode/mnode/sdb/src/sdbHash.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "sdb.h"
18

19
static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow);
20

21
const char *sdbTableName(ESdbType type) {
1,611,819✔
22
  switch (type) {
1,611,819✔
23
    case SDB_TRANS:
239,151✔
24
      return "trans";
239,151✔
25
    case SDB_CLUSTER:
19,228✔
26
      return "cluster";
19,228✔
27
    case SDB_MNODE:
32,495✔
28
      return "mnode";
32,495✔
29
    case SDB_QNODE:
17,239✔
30
      return "qnode";
17,239✔
31
    case SDB_SNODE:
6,767✔
32
      return "snode";
6,767✔
33
    case SDB_DNODE:
108,205✔
34
      return "dnode";
108,205✔
35
    case SDB_USER:
37,859✔
36
      return "user";
37,859✔
37
    case SDB_AUTH:
2✔
38
      return "auth";
2✔
39
    case SDB_ACCT:
12,297✔
40
      return "acct";
12,297✔
41
    case SDB_STREAM_CK:
2✔
42
      return "stream_ck";
2✔
43
    case SDB_STREAM:
48,078✔
44
      return "stream";
48,078✔
45
    case SDB_OFFSET:
2✔
46
      return "offset";
2✔
47
    case SDB_SUBSCRIBE:
10,482✔
48
      return "subscribe";
10,482✔
49
    case SDB_CONSUMER:
14,234✔
50
      return "consumer";
14,234✔
51
    case SDB_TOPIC:
9,145✔
52
      return "topic";
9,145✔
53
    case SDB_VGROUP:
285,556✔
54
      return "vgroup";
285,556✔
55
    case SDB_SMA:
32,419✔
56
      return "sma";
32,419✔
57
    case SDB_STB:
114,480✔
58
      return "stb";
114,480✔
59
    case SDB_DB:
81,222✔
60
      return "db";
81,222✔
61
    case SDB_FUNC:
6,784✔
62
      return "func";
6,784✔
63
    case SDB_IDX:
51,505✔
64
      return "idx";
51,505✔
65
    case SDB_VIEW:
7,734✔
66
      return "view";
7,734✔
67
    case SDB_STREAM_SEQ:
6,601✔
68
      return "stream_seq";
6,601✔
69
    case SDB_COMPACT:
6,631✔
70
      return "compact";
6,631✔
71
    case SDB_COMPACT_DETAIL:
6,781✔
72
      return "compact_detail";
6,781✔
73
    case SDB_GRANT:
13,715✔
74
      return "grant";
13,715✔
75
    case SDB_ARBGROUP:
6,699✔
76
      return "arb_group";
6,699✔
77
    case SDB_ANODE:
6,612✔
78
      return "anode";
6,612✔
79
    case SDB_CFG:
429,891✔
80
      return "config";
429,891✔
81
    default:
3✔
82
      return "undefine";
3✔
83
  }
84
}
85

86
const char *sdbStatusName(ESdbStatus status) {
973,540✔
87
  switch (status) {
973,540✔
88
    case SDB_STATUS_CREATING:
27,078✔
89
      return "creating";
27,078✔
90
    case SDB_STATUS_DROPPING:
8,641✔
91
      return "dropping";
8,641✔
92
    case SDB_STATUS_READY:
865,748✔
93
      return "ready";
865,748✔
94
    case SDB_STATUS_DROPPED:
62,572✔
95
      return "dropped";
62,572✔
96
    case SDB_STATUS_INIT:
9,474✔
97
      return "init";
9,474✔
98
    case SDB_STATUS_UPDATE:
26✔
99
      return "update";
26✔
100
    default:
1✔
101
      return "undefine";
1✔
102
  }
103
}
104

105
void sdbPrintOper(SSdb *pSdb, SSdbRow *pRow, const char *oper) {
390,468,524✔
106
#if 1
107
  EKeyType keyType = pSdb->keyTypes[pRow->type];
390,468,524✔
108

109
  if (keyType == SDB_KEY_BINARY) {
390,468,524✔
110
    mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,
45,916,442✔
111
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
112
  } else if (keyType == SDB_KEY_INT32) {
344,552,082✔
113
    mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), *(int32_t *)pRow->pObj,
344,191,607✔
114
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
115
  } else if (keyType == SDB_KEY_INT64) {
360,475!
116
    mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),
396,853✔
117
           *(int64_t *)pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
118
  } else {
119
  }
120
#endif
121
}
390,468,524✔
122

123
static SHashObj *sdbGetHash(SSdb *pSdb, int32_t type) {
206,982,521✔
124
  if (type >= SDB_MAX || type < 0) {
206,982,521!
125
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
×
126
    return NULL;
1✔
127
  }
128

129
  SHashObj *hash = pSdb->hashObjs[type];
206,983,876✔
130
  if (hash == NULL) {
206,983,876✔
131
    terrno = TSDB_CODE_APP_ERROR;
4✔
132
    return NULL;
4✔
133
  }
134

135
  return hash;
206,983,872✔
136
}
137

138
static int32_t sdbGetkeySize(SSdb *pSdb, ESdbType type, const void *pKey) {
32,691,036✔
139
  int32_t  keySize = 0;
32,691,036✔
140
  EKeyType keyType = pSdb->keyTypes[type];
32,691,036✔
141

142
  if (keyType == SDB_KEY_INT32) {
32,691,036✔
143
    keySize = sizeof(int32_t);
21,068,243✔
144
  } else if (keyType == SDB_KEY_BINARY) {
11,622,793✔
145
    keySize = strlen(pKey) + 1;
11,603,202✔
146
  } else {
147
    keySize = sizeof(int64_t);
19,591✔
148
  }
149

150
  return keySize;
32,691,036✔
151
}
152

153
static int32_t sdbInsertRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
251,912✔
154
  int32_t type = pRow->type;
251,912✔
155
  sdbWriteLock(pSdb, type);
251,912✔
156

157
  SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);
251,912✔
158
  if (pOldRow != NULL) {
251,912!
159
    sdbUnLock(pSdb, type);
×
160
    sdbFreeRow(pSdb, pRow, false);
×
161
    terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;
×
162
    return terrno;
×
163
  }
164

165
  pRow->refCount = 0;
251,912✔
166
  pRow->status = pRaw->status;
251,912✔
167
  sdbPrintOper(pSdb, pRow, "insert");
251,912✔
168

169
  int32_t code = 0;
251,912✔
170
  if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {
251,912!
171
    sdbUnLock(pSdb, type);
×
172
    sdbFreeRow(pSdb, pRow, false);
×
173
    return code;
×
174
  }
175

176
  SdbInsertFp insertFp = pSdb->insertFps[pRow->type];
251,912✔
177
  if (insertFp != NULL) {
251,912!
178
    code = (*insertFp)(pSdb, pRow->pObj);
251,912✔
179
    if (code != 0) {
251,912!
180
      if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {
×
181
        mError("failed to remove row from hash");
×
182
      }
183
      sdbFreeRow(pSdb, pRow, false);
×
184
      sdbUnLock(pSdb, type);
×
185
      terrno = code;
×
186
      return terrno;
×
187
    }
188
  }
189

190
  sdbUnLock(pSdb, type);
251,912✔
191

192
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {
251,912✔
193
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int32_t *)pRow->pObj));
64,136✔
194
  }
195
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {
251,912✔
196
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int64_t *)pRow->pObj));
2,215✔
197
  }
198
  pSdb->tableVer[pRow->type]++;
251,912✔
199

200
  return 0;
251,912✔
201
}
202

203
static int32_t sdbUpdateRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pNewRow, int32_t keySize) {
341,945✔
204
  int32_t type = pNewRow->type;
341,945✔
205
  sdbWriteLock(pSdb, type);
341,945✔
206

207
  SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);
341,945✔
208
  if (ppOldRow == NULL || *ppOldRow == NULL) {
341,945!
209
    sdbUnLock(pSdb, type);
237,866✔
210
    return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);
237,866✔
211
  }
212

213
  SSdbRow *pOldRow = *ppOldRow;
104,079✔
214
  pOldRow->status = pRaw->status;
104,079✔
215
  sdbPrintOper(pSdb, pOldRow, "update");
104,079✔
216

217
  int32_t     code = 0;
104,079✔
218
  SdbUpdateFp updateFp = pSdb->updateFps[type];
104,079✔
219
  if (updateFp != NULL) {
104,079!
220
    code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);
104,079✔
221
  }
222
  sdbUnLock(pSdb, type);
104,079✔
223

224
  // sdbUnLock(pSdb, type);
225
  sdbFreeRow(pSdb, pNewRow, false);
104,079✔
226

227
  pSdb->tableVer[pOldRow->type]++;
104,079✔
228
  return code;
104,079✔
229
}
230

231
static int32_t sdbDeleteRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
66,312✔
232
  int32_t type = pRow->type;
66,312✔
233
  sdbWriteLock(pSdb, type);
66,312✔
234

235
  SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);
66,312✔
236
  if (ppOldRow == NULL || *ppOldRow == NULL) {
66,312!
237
    sdbUnLock(pSdb, type);
22✔
238
    sdbFreeRow(pSdb, pRow, false);
22✔
239
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
22✔
240
    return terrno;
22✔
241
  }
242
  SSdbRow *pOldRow = *ppOldRow;
66,290✔
243
  pOldRow->status = pRaw->status;
66,290✔
244

245
  (void)atomic_add_fetch_32(&pOldRow->refCount, 1);
66,290✔
246
  sdbPrintOper(pSdb, pOldRow, "delete");
66,290✔
247

248
  if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {
66,290!
249
    sdbUnLock(pSdb, type);
×
250
    sdbFreeRow(pSdb, pRow, false);
×
251
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
×
252
    return terrno;
×
253
  }
254
  pSdb->tableVer[pOldRow->type]++;
66,290✔
255
  sdbUnLock(pSdb, type);
66,290✔
256

257
  sdbFreeRow(pSdb, pRow, false);
66,290✔
258

259
  sdbCheckRow(pSdb, pOldRow);
66,290✔
260
  return 0;
66,290✔
261
}
262

263
int32_t sdbWriteWithoutFree(SSdb *pSdb, SSdbRaw *pRaw) {
422,305✔
264
  if (pRaw->type == SDB_CFG) {
422,305✔
265
    mTrace("sdb write cfg");
154,930✔
266
  }
267
  SHashObj *hash = sdbGetHash(pSdb, pRaw->type);
422,305✔
268
  if (hash == NULL) return terrno;
422,305✔
269

270
  SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];
422,303✔
271
  SSdbRow    *pRow = (*decodeFp)(pRaw);
422,303✔
272
  if (pRow == NULL) return terrno;
422,303!
273

274
  pRow->type = pRaw->type;
422,303✔
275

276
  int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);
422,303✔
277
  int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;
422,303✔
278

279
  switch (pRaw->status) {
422,303!
280
    case SDB_STATUS_CREATING:
14,046✔
281
      code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);
14,046✔
282
      break;
14,046✔
283
    case SDB_STATUS_READY:
341,945✔
284
    case SDB_STATUS_UPDATE:
285
    case SDB_STATUS_DROPPING:
286
      code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);
341,945✔
287
      break;
341,945✔
288
    case SDB_STATUS_DROPPED:
66,312✔
289
      code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);
66,312✔
290
      break;
66,312✔
291
  }
292

293
  return code;
422,303✔
294
}
295

296
int32_t sdbWrite(SSdb *pSdb, SSdbRaw *pRaw) {
48,413✔
297
  int32_t code = sdbWriteWithoutFree(pSdb, pRaw);
48,413✔
298
  sdbFreeRaw(pRaw);
48,413✔
299
  return code;
48,413✔
300
}
301

302
void *sdbAcquireAll(SSdb *pSdb, ESdbType type, const void *pKey, bool onlyReady) {
32,268,611✔
303
  terrno = 0;
32,268,611✔
304

305
  SHashObj *hash = sdbGetHash(pSdb, type);
32,268,676✔
306
  if (hash == NULL) return NULL;
32,268,253✔
307

308
  void   *pRet = NULL;
32,268,252✔
309
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);
32,268,252✔
310

311
  sdbReadLock(pSdb, type);
32,269,872✔
312

313
  SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);
32,274,503✔
314
  if (ppRow == NULL || *ppRow == NULL) {
32,275,181!
315
    sdbUnLock(pSdb, type);
1,877,340✔
316
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
1,877,588✔
317
    return NULL;
1,877,584✔
318
  }
319

320
  SSdbRow *pRow = *ppRow;
30,397,841✔
321
  switch (pRow->status) {
30,397,841✔
322
    case SDB_STATUS_READY:
30,391,196✔
323
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
30,391,196✔
324
      pRet = pRow->pObj;
30,392,431✔
325
      sdbPrintOper(pSdb, pRow, "acquire");
30,392,431✔
326
      break;
30,391,334✔
327
    case SDB_STATUS_CREATING:
4,567✔
328
      terrno = TSDB_CODE_SDB_OBJ_CREATING;
4,567✔
329
      break;
4,567✔
330
    case SDB_STATUS_DROPPING:
1,730✔
331
      terrno = TSDB_CODE_SDB_OBJ_DROPPING;
1,730✔
332
      break;
1,730✔
333
    default:
348✔
334
      terrno = TSDB_CODE_APP_ERROR;
348✔
UNCOV
335
      break;
×
336
  }
337

338
  if (pRet == NULL) {
30,397,631✔
339
    if (!onlyReady) {
6,297!
340
      terrno = 0;
×
341
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
×
342
      pRet = pRow->pObj;
×
343
      sdbPrintOper(pSdb, pRow, "acquire");
×
344
    }
345
  }
346

347
  sdbUnLock(pSdb, type);
30,397,631✔
348
  return pRet;
30,397,632✔
349
}
350

351
void *sdbAcquire(SSdb *pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }
32,265,177✔
352
void *sdbAcquireNotReadyObj(SSdb *pSdb, ESdbType type, const void *pKey) {
2,147✔
353
  return sdbAcquireAll(pSdb, type, pKey, false);
2,147✔
354
}
355

356
static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow) {
66,290✔
357
  int32_t type = pRow->type;
66,290✔
358
  sdbWriteLock(pSdb, type);
66,290✔
359

360
  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
66,290✔
361
  sdbPrintOper(pSdb, pRow, "check");
66,290✔
362
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
66,290!
363
    sdbFreeRow(pSdb, pRow, true);
17,199✔
364
  }
365

366
  sdbUnLock(pSdb, type);
66,290✔
367
}
66,290✔
368

369
void sdbReleaseLock(SSdb *pSdb, void *pObj, bool lock) {
194,981,930✔
370
  if (pObj == NULL) return;
194,981,930✔
371

372
  SSdbRow *pRow = (SSdbRow *)((char *)pObj - sizeof(SSdbRow));
194,565,927✔
373
  if (pRow->type >= SDB_MAX) return;
194,565,927✔
374

375
  int32_t type = pRow->type;
194,565,926✔
376
  if (lock) {
194,565,926!
377
    sdbWriteLock(pSdb, type);
194,569,276✔
378
  }
379

380
  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
194,619,900✔
381
  sdbPrintOper(pSdb, pRow, "release");
194,637,456✔
382
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
194,630,321✔
383
    sdbFreeRow(pSdb, pRow, true);
49,091✔
384
  }
385

386
  if (lock) {
194,630,321✔
387
    sdbUnLock(pSdb, type);
194,627,251✔
388
  }
389
}
390

391
void sdbRelease(SSdb *pSdb, void *pObj) { sdbReleaseLock(pSdb, pObj, true); }
194,969,438✔
392

393
void *sdbFetch(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj) {
165,924,847✔
394
  *ppObj = NULL;
165,924,847✔
395

396
  SHashObj *hash = sdbGetHash(pSdb, type);
165,924,847✔
397
  if (hash == NULL) return NULL;
165,922,737✔
398

399
  sdbReadLock(pSdb, type);
165,922,736✔
400

401
  SSdbRow **ppRow = taosHashIterate(hash, pIter);
165,924,752✔
402
  while (ppRow != NULL) {
165,968,314✔
403
    SSdbRow *pRow = *ppRow;
163,353,944✔
404
    if (pRow == NULL || pRow->status != SDB_STATUS_READY) {
163,353,944!
405
      ppRow = taosHashIterate(hash, ppRow);
32,115✔
406
      continue;
31,930✔
407
    }
408

409
    (void)atomic_add_fetch_32(&pRow->refCount, 1);
163,321,829✔
410
    sdbPrintOper(pSdb, pRow, "fetch");
163,318,430✔
411
    *ppObj = pRow->pObj;
163,306,298✔
412
    break;
163,306,298✔
413
  }
414
  sdbUnLock(pSdb, type);
165,920,668✔
415

416
  return ppRow;
165,928,647✔
417
}
418

419
void *sdbFetchAll(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj, ESdbStatus *status, bool lock) {
1,041,343✔
420
  *ppObj = NULL;
1,041,343✔
421

422
  SHashObj *hash = sdbGetHash(pSdb, type);
1,041,343✔
423
  if (hash == NULL) return NULL;
1,041,320!
424

425
  if (lock) {
1,041,320✔
426
    sdbReadLock(pSdb, type);
1,035,570✔
427
  }
428

429
  SSdbRow **ppRow = taosHashIterate(hash, pIter);
1,041,316✔
430
  while (ppRow != NULL) {
1,041,433✔
431
    SSdbRow *pRow = *ppRow;
928,051✔
432
    if (pRow == NULL) {
928,051!
433
      ppRow = taosHashIterate(hash, ppRow);
×
434
      continue;
×
435
    }
436

437
    (void)atomic_add_fetch_32(&pRow->refCount, 1);
928,051✔
438
    sdbPrintOper(pSdb, pRow, "fetch");
928,033✔
439
    *ppObj = pRow->pObj;
927,959✔
440
    *status = pRow->status;
927,959✔
441
    break;
927,959✔
442
  }
443
  if (lock) {
1,041,341✔
444
    sdbUnLock(pSdb, type);
1,035,590✔
445
  }
446

447
  return ppRow;
1,041,342✔
448
}
449

450
void sdbCancelFetch(SSdb *pSdb, void *pIter) {
5,312,042✔
451
  if (pIter == NULL) return;
5,312,042✔
452
  SSdbRow *pRow = *(SSdbRow **)pIter;
5,310,089✔
453
  mTrace("cancel fetch row:%p", pRow);
5,310,089✔
454
  SHashObj *hash = sdbGetHash(pSdb, pRow->type);
5,310,089✔
455
  if (hash == NULL) return;
5,310,096!
456

457
  int32_t type = pRow->type;
5,310,096✔
458
  sdbReadLock(pSdb, type);
5,310,096✔
459
  taosHashCancelIterate(hash, pIter);
5,310,138✔
460
  sdbUnLock(pSdb, type);
5,310,161✔
461
}
462

463
void sdbCancelFetchByType(SSdb *pSdb, void *pIter, ESdbType type) {
×
464
  if (pIter == NULL) return;
×
465
  if (type >= SDB_MAX || type < 0) return;
×
466
  SHashObj *hash = sdbGetHash(pSdb, type);
×
467
  if (hash == NULL) return;
×
468

469
  sdbReadLock(pSdb, type);
×
470
  taosHashCancelIterate(hash, pIter);
×
471
  sdbUnLock(pSdb, type);
×
472
}
473

474
void sdbTraverse(SSdb *pSdb, ESdbType type, sdbTraverseFp fp, void *p1, void *p2, void *p3) {
668,831✔
475
  SHashObj *hash = sdbGetHash(pSdb, type);
668,831✔
476
  if (hash == NULL) return;
668,829!
477

478
  sdbReadLock(pSdb, type);
668,829✔
479

480
  SSdbRow **ppRow = taosHashIterate(hash, NULL);
668,836✔
481
  while (ppRow != NULL) {
30,928,608✔
482
    SSdbRow *pRow = *ppRow;
30,261,910✔
483
    if (pRow->status == SDB_STATUS_READY) {
30,261,910✔
484
      bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);
30,252,551✔
485
      if (!isContinue) {
30,081,200✔
486
        taosHashCancelIterate(hash, ppRow);
2✔
487
        break;
2✔
488
      }
489
    }
490

491
    ppRow = taosHashIterate(hash, ppRow);
30,090,557✔
492
  }
493

494
  sdbUnLock(pSdb, type);
666,700✔
495
}
496

497
int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {
1,335,247✔
498
  SHashObj *hash = sdbGetHash(pSdb, type);
1,335,247✔
499
  if (hash == NULL) return 0;
1,335,148!
500

501
  sdbReadLock(pSdb, type);
1,335,148✔
502
  int32_t size = taosHashGetSize(hash);
1,335,299✔
503
  sdbUnLock(pSdb, type);
1,335,192✔
504

505
  return size;
1,335,313✔
506
}
507

508
int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {
53,967✔
509
  SHashObj *hash = sdbGetHash(pSdb, type);
53,967✔
510
  if (hash == NULL) return -1;
53,967✔
511

512
  if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;
53,966✔
513

514
  int32_t maxId = 0;
53,960✔
515
  sdbReadLock(pSdb, type);
53,960✔
516

517
  SSdbRow **ppRow = taosHashIterate(hash, NULL);
53,960✔
518
  while (ppRow != NULL) {
117,654✔
519
    SSdbRow *pRow = *ppRow;
63,694✔
520
    int32_t  id = *(int32_t *)pRow->pObj;
63,694✔
521
    maxId = TMAX(id, maxId);
63,694✔
522
    ppRow = taosHashIterate(hash, ppRow);
63,694✔
523
  }
524

525
  sdbUnLock(pSdb, type);
53,960✔
526
  maxId = TMAX(maxId, pSdb->maxId[type]);
53,960✔
527
  return maxId + 1;
53,960✔
528
}
529

530
int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {
591,774✔
531
  if (type >= SDB_MAX || type < 0) {
591,774✔
532
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
1✔
533
    return -1;
1✔
534
  }
535

536
  return pSdb->tableVer[type];
591,773✔
537
}
538

539
bool countValid(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
×
540
  int32_t *pInt = p1;
×
541
  (*pInt) += 1;
×
542
  return true;
×
543
}
544

545
int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {
×
546
  int32_t num = 0;
×
547
  sdbTraverse(pSdb, type, countValid, &num, 0, 0);
×
548
  return num;
×
549
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc