#3586

Committed 22 Jan 2025 05:37AM UTC coverage: 63.643% (-0.004%) from 63.647%

Build # #3586

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #29612 from taosdata/fix/TD-33556

fix:[TD-33556] tmq close elegantly to avoid invalid read in TD-32585

Run Details

140971 of 284575 branches covered (49.54%)

Branch coverage included in aggregate %.

19 of 27 new or added lines in 2 files covered. (70.37%)

655 existing lines in 114 files now uncovered.

219468 of 281768 relevant lines covered (77.89%)

19335507.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.83

/source/dnode/mnode/impl/src/mndShow.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "mndShow.h"
#include "mndPrivilege.h"
#include "mndUser.h"
#include "systable.h"

#define SHOW_STEP_SIZE            100
#define SHOW_COLS_STEP_SIZE       4096
#define SHOW_PRIVILEGES_STEP_SIZE 2048

static SShowObj *mndCreateShowObj(SMnode *pMnode, SRetrieveTableReq *pReq);
static void      mndFreeShowObj(SShowObj *pShow);
static SShowObj *mndAcquireShowObj(SMnode *pMnode, int64_t showId);
static void      mndReleaseShowObj(SShowObj *pShow, bool forceRemove);
static bool      mndCheckRetrieveFinished(SShowObj *pShow);
static int32_t   mndProcessRetrieveSysTableReq(SRpcMsg *pReq);

int32_t mndInitShow(SMnode *pMnode) {
  int32_t    code = 0;
  SShowMgmt *pMgmt = &pMnode->showMgmt;

  pMgmt->cache = taosCacheInit(TSDB_DATA_TYPE_INT, 5000, true, (__cache_free_fn_t)mndFreeShowObj, "show");
  if (pMgmt->cache == NULL) {
    code = TSDB_CODE_OUT_OF_MEMORY;
    mError("failed to alloc show cache since %s", tstrerror(code));
    TAOS_RETURN(code);
  }

  mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveSysTableReq);
  TAOS_RETURN(code);
}

void mndCleanupShow(SMnode *pMnode) {
  SShowMgmt *pMgmt = &pMnode->showMgmt;
  if (pMgmt->cache != NULL) {
    taosCacheCleanup(pMgmt->cache);
    pMgmt->cache = NULL;
  }
}

static int32_t convertToRetrieveType(char *name, int32_t len) {
  int32_t type = -1;

  if (strncasecmp(name, TSDB_INS_TABLE_DNODES, len) == 0) {
    type = TSDB_MGMT_TABLE_DNODE;
  } else if (strncasecmp(name, TSDB_INS_TABLE_MNODES, len) == 0) {
    type = TSDB_MGMT_TABLE_MNODE;
    /*
      } else if (strncasecmp(name, TSDB_INS_TABLE_MODULES, len) == 0) {
        type = TSDB_MGMT_TABLE_MODULE;
    */
  } else if (strncasecmp(name, TSDB_INS_TABLE_QNODES, len) == 0) {
    type = TSDB_MGMT_TABLE_QNODE;
  } else if (strncasecmp(name, TSDB_INS_TABLE_SNODES, len) == 0) {
    type = TSDB_MGMT_TABLE_SNODE;
  } else if (strncasecmp(name, TSDB_INS_TABLE_ANODES, len) == 0) {
    type = TSDB_MGMT_TABLE_ANODE;
  } else if (strncasecmp(name, TSDB_INS_TABLE_ANODES_FULL, len) == 0) {
    type = TSDB_MGMT_TABLE_ANODE_FULL;
  } else if (strncasecmp(name, TSDB_INS_TABLE_ARBGROUPS, len) == 0) {
    type = TSDB_MGMT_TABLE_ARBGROUP;
  } else if (strncasecmp(name, TSDB_INS_TABLE_CLUSTER, len) == 0) {
    type = TSDB_MGMT_TABLE_CLUSTER;
  } else if (strncasecmp(name, TSDB_INS_TABLE_DATABASES, len) == 0) {
    type = TSDB_MGMT_TABLE_DB;
  } else if (strncasecmp(name, TSDB_INS_TABLE_FUNCTIONS, len) == 0) {
    type = TSDB_MGMT_TABLE_FUNC;
  } else if (strncasecmp(name, TSDB_INS_TABLE_INDEXES, len) == 0) {
    type = TSDB_MGMT_TABLE_INDEX;
  } else if (strncasecmp(name, TSDB_INS_TABLE_STABLES, len) == 0) {
    type = TSDB_MGMT_TABLE_STB;
  } else if (strncasecmp(name, TSDB_INS_TABLE_TABLES, len) == 0) {
    type = TSDB_MGMT_TABLE_TABLE;
  } else if (strncasecmp(name, TSDB_INS_TABLE_TAGS, len) == 0) {
    type = TSDB_MGMT_TABLE_TAG;
  } else if (strncasecmp(name, TSDB_INS_TABLE_COLS, len) == 0) {
    type = TSDB_MGMT_TABLE_COL;
  } else if (strncasecmp(name, TSDB_INS_TABLE_TABLE_DISTRIBUTED, len) == 0) {
    //    type = TSDB_MGMT_TABLE_DIST;
  } else if (strncasecmp(name, TSDB_INS_TABLE_USERS, len) == 0) {
    type = TSDB_MGMT_TABLE_USER;
  } else if (strncasecmp(name, TSDB_INS_TABLE_USERS_FULL, len) == 0) {
    type = TSDB_MGMT_TABLE_USER_FULL;
  } else if (strncasecmp(name, TSDB_INS_TABLE_LICENCES, len) == 0) {
    type = TSDB_MGMT_TABLE_GRANTS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_VGROUPS, len) == 0) {
    type = TSDB_MGMT_TABLE_VGROUP;
  } else if (strncasecmp(name, TSDB_PERFS_TABLE_CONSUMERS, len) == 0) {
    type = TSDB_MGMT_TABLE_CONSUMERS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_SUBSCRIPTIONS, len) == 0) {
    type = TSDB_MGMT_TABLE_SUBSCRIPTIONS;
  } else if (strncasecmp(name, TSDB_PERFS_TABLE_TRANS, len) == 0) {
    type = TSDB_MGMT_TABLE_TRANS;
  } else if (strncasecmp(name, TSDB_PERFS_TABLE_SMAS, len) == 0) {
    type = TSDB_MGMT_TABLE_SMAS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_CONFIGS, len) == 0) {
    type = TSDB_MGMT_TABLE_CONFIGS;
  } else if (strncasecmp(name, TSDB_PERFS_TABLE_CONNECTIONS, len) == 0) {
    type = TSDB_MGMT_TABLE_CONNS;
  } else if (strncasecmp(name, TSDB_PERFS_TABLE_QUERIES, len) == 0) {
    type = TSDB_MGMT_TABLE_QUERIES;
  } else if (strncasecmp(name, TSDB_INS_TABLE_VNODES, len) == 0) {
    type = TSDB_MGMT_TABLE_VNODES;
  } else if (strncasecmp(name, TSDB_INS_TABLE_TOPICS, len) == 0) {
    type = TSDB_MGMT_TABLE_TOPICS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_STREAMS, len) == 0) {
    type = TSDB_MGMT_TABLE_STREAMS;
  } else if (strncasecmp(name, TSDB_PERFS_TABLE_APPS, len) == 0) {
    type = TSDB_MGMT_TABLE_APPS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_STREAM_TASKS, len) == 0) {
    type = TSDB_MGMT_TABLE_STREAM_TASKS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_USER_PRIVILEGES, len) == 0) {
    type = TSDB_MGMT_TABLE_PRIVILEGES;
  } else if (strncasecmp(name, TSDB_INS_TABLE_VIEWS, len) == 0) {
    type = TSDB_MGMT_TABLE_VIEWS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_COMPACTS, len) == 0) {
    type = TSDB_MGMT_TABLE_COMPACT;
  } else if (strncasecmp(name, TSDB_INS_TABLE_COMPACT_DETAILS, len) == 0) {
    type = TSDB_MGMT_TABLE_COMPACT_DETAIL;
  } else if (strncasecmp(name, TSDB_INS_TABLE_TRANSACTION_DETAILS, len) == 0) {
    type = TSDB_MGMT_TABLE_TRANSACTION_DETAIL;
  } else if (strncasecmp(name, TSDB_INS_TABLE_GRANTS_FULL, len) == 0) {
    type = TSDB_MGMT_TABLE_GRANTS_FULL;
  } else if (strncasecmp(name, TSDB_INS_TABLE_GRANTS_LOGS, len) == 0) {
    type = TSDB_MGMT_TABLE_GRANTS_LOGS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_MACHINES, len) == 0) {
    type = TSDB_MGMT_TABLE_MACHINES;
  } else if (strncasecmp(name, TSDB_INS_TABLE_ENCRYPTIONS, len) == 0) {
    type = TSDB_MGMT_TABLE_ENCRYPTIONS;
  } else if (strncasecmp(name, TSDB_INS_TABLE_TSMAS, len) == 0) {
    type = TSDB_MGMT_TABLE_TSMAS;
  } else if (strncasecmp(name, TSDB_INS_DISK_USAGE, len) == 0) {
    type = TSDB_MGMT_TABLE_USAGE;
  } else if (strncasecmp(name, TSDB_INS_TABLE_FILESETS, len) == 0) {
    type = TSDB_MGMT_TABLE_FILESETS;
  } else {
    mError("invalid show name:%s len:%d", name, len);
  }

  return type;
}

static SShowObj *mndCreateShowObj(SMnode *pMnode, SRetrieveTableReq *pReq) {
  SShowMgmt *pMgmt = &pMnode->showMgmt;

  int64_t showId = atomic_add_fetch_64(&pMgmt->showId, 1);
  if (showId == 0) atomic_add_fetch_64(&pMgmt->showId, 1);

  int32_t size = sizeof(SShowObj);

  SShowObj showObj = {0};

  showObj.id = showId;
  showObj.pMnode = pMnode;
  showObj.type = convertToRetrieveType(pReq->tb, tListLen(pReq->tb));
  (void)memcpy(showObj.db, pReq->db, TSDB_DB_FNAME_LEN);
  tstrncpy(showObj.filterTb, pReq->filterTb, TSDB_TABLE_NAME_LEN);

  int32_t   keepTime = tsShellActivityTimer * 6 * 1000;
  SShowObj *pShow = taosCachePut(pMgmt->cache, &showId, sizeof(int64_t), &showObj, size, keepTime);
  if (pShow == NULL) {
    terrno = TSDB_CODE_OUT_OF_MEMORY;
    mError("show:0x%" PRIx64 ", failed to put into cache since %s", showId, terrstr());
    return NULL;
  }

  mTrace("show:0x%" PRIx64 ", is created, data:%p", showId, pShow);
  return pShow;
}

static void mndFreeShowObj(SShowObj *pShow) {
  SMnode    *pMnode = pShow->pMnode;
  SShowMgmt *pMgmt = &pMnode->showMgmt;

  ShowFreeIterFp freeFp = pMgmt->freeIterFps[pShow->type];
  if (freeFp != NULL) {
    if (pShow->pIter != NULL) {
      mTrace("show:0x%" PRIx64 ", is destroying, data:%p, pIter:%p, ", pShow->id, pShow, pShow->pIter);

      (*freeFp)(pMnode, pShow->pIter);

      pShow->pIter = NULL;
    }
  }

  mTrace("show:0x%" PRIx64 ", is destroyed, data:%p", pShow->id, pShow);
}

static SShowObj *mndAcquireShowObj(SMnode *pMnode, int64_t showId) {
  SShowMgmt *pMgmt = &pMnode->showMgmt;

  SShowObj *pShow = taosCacheAcquireByKey(pMgmt->cache, &showId, sizeof(showId));
  if (pShow == NULL) {
    mError("show:0x%" PRIx64 ", already destroyed", showId);
    return NULL;
  }

  mTrace("show:0x%" PRIx64 ", acquired from cache, data:%p", pShow->id, pShow);
  return pShow;
}

static void mndReleaseShowObj(SShowObj *pShow, bool forceRemove) {
  if (pShow == NULL) return;
  mTrace("show:0x%" PRIx64 ", released from cache, data:%p force:%d", pShow->id, pShow, forceRemove);

  // A bug in tcache.c
  forceRemove = 0;

  SMnode    *pMnode = pShow->pMnode;
  SShowMgmt *pMgmt = &pMnode->showMgmt;
  taosCacheRelease(pMgmt->cache, (void **)(&pShow), forceRemove);
}

static int32_t mndProcessRetrieveSysTableReq(SRpcMsg *pReq) {
  int32_t    code = 0;
  SMnode    *pMnode = pReq->info.node;
  SShowMgmt *pMgmt = &pMnode->showMgmt;
  SShowObj  *pShow = NULL;
  int32_t    rowsToRead = SHOW_STEP_SIZE;
  int32_t    size = 0;
  int32_t    rowsRead = 0;
  mDebug("mndProcessRetrieveSysTableReq start");
  SRetrieveTableReq retrieveReq = {0};
  TAOS_CHECK_RETURN(tDeserializeSRetrieveTableReq(pReq->pCont, pReq->contLen, &retrieveReq));

  mDebug("process to retrieve systable req db:%s, tb:%s, compactId:%" PRId64, retrieveReq.db, retrieveReq.tb,
         retrieveReq.compactId);

  if (retrieveReq.showId == 0) {
    STableMetaRsp *pMeta = taosHashGet(pMnode->infosMeta, retrieveReq.tb, strlen(retrieveReq.tb));
    if (pMeta == NULL) {
      pMeta = taosHashGet(pMnode->perfsMeta, retrieveReq.tb, strlen(retrieveReq.tb));
      if (pMeta == NULL) {
        code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
        mError("failed to process show-retrieve req:%p since %s", pShow, tstrerror(code));
        TAOS_RETURN(code);
      }
    }

    pShow = mndCreateShowObj(pMnode, &retrieveReq);
    if (pShow == NULL) {
      code = terrno;
      mError("failed to process show-meta req since %s", tstrerror(code));
      TAOS_RETURN(code);
    }

    pShow->pMeta = pMeta;
    pShow->numOfColumns = pShow->pMeta->numOfColumns;
  } else {
    pShow = mndAcquireShowObj(pMnode, retrieveReq.showId);
    if (pShow == NULL) {
      code = TSDB_CODE_MND_INVALID_SHOWOBJ;
      mError("failed to process show-retrieve req:%p since %s", pShow, tstrerror(code));
      TAOS_RETURN(code);
    }
  }

  if (pShow->type == TSDB_MGMT_TABLE_COL) {  // expend capacity for ins_columns
    rowsToRead = SHOW_COLS_STEP_SIZE;
  } else if (pShow->type == TSDB_MGMT_TABLE_PRIVILEGES) {
    rowsToRead = SHOW_PRIVILEGES_STEP_SIZE;
  }
  ShowRetrieveFp retrieveFp = pMgmt->retrieveFps[pShow->type];
  if (retrieveFp == NULL) {
    mndReleaseShowObj(pShow, false);
    code = TSDB_CODE_MSG_NOT_PROCESSED;
    mError("show:0x%" PRIx64 ", failed to retrieve data since %s", pShow->id, tstrerror(code));
    TAOS_RETURN(code);
  }

  mDebug("show:0x%" PRIx64 ", start retrieve data, type:%d", pShow->id, pShow->type);
  if (retrieveReq.user[0] != 0) {
    (void)memcpy(pReq->info.conn.user, retrieveReq.user, TSDB_USER_LEN);
  } else {
    (void)memcpy(pReq->info.conn.user, TSDB_DEFAULT_USER, strlen(TSDB_DEFAULT_USER) + 1);
  }
  code = -1;
  if (retrieveReq.db[0] &&
      (code = mndCheckShowPrivilege(pMnode, pReq->info.conn.user, pShow->type, retrieveReq.db)) != 0) {
    TAOS_RETURN(code);
  }
  if (pShow->type == TSDB_MGMT_TABLE_USER_FULL) {
    if (strcmp(pReq->info.conn.user, "root") != 0) {
      mError("The operation is not permitted, user:%s, pShow->type:%d", pReq->info.conn.user, pShow->type);
      code = TSDB_CODE_MND_NO_RIGHTS;
      TAOS_RETURN(code);
    }
  }

  int32_t numOfCols = pShow->pMeta->numOfColumns;

  SSDataBlock *pBlock = NULL;
  code = createDataBlock(&pBlock);
  if (code) {
    TAOS_RETURN(code);
  }

  for (int32_t i = 0; i < numOfCols; ++i) {
    SColumnInfoData idata = {0};

    SSchema *p = &pShow->pMeta->pSchemas[i];

    idata.info.bytes = p->bytes;
    idata.info.type = p->type;
    idata.info.colId = p->colId;
    TAOS_CHECK_RETURN(blockDataAppendColInfo(pBlock, &idata));
  }

  TAOS_CHECK_RETURN(blockDataEnsureCapacity(pBlock, rowsToRead));

  if (mndCheckRetrieveFinished(pShow)) {
    mDebug("show:0x%" PRIx64 ", read finished, numOfRows:%d", pShow->id, pShow->numOfRows);
    rowsRead = 0;
  } else {
    rowsRead = (*retrieveFp)(pReq, pShow, pBlock, rowsToRead);
    if (rowsRead < 0) {
      code = rowsRead;
      mDebug("show:0x%" PRIx64 ", retrieve completed", pShow->id);
      mndReleaseShowObj(pShow, true);
      blockDataDestroy(pBlock);
      TAOS_RETURN(code);
    }

    pBlock->info.rows = rowsRead;
    mDebug("show:0x%" PRIx64 ", stop retrieve data, rowsRead:%d numOfRows:%d", pShow->id, rowsRead, pShow->numOfRows);
  }

  size_t dataEncodeBufSize = blockGetEncodeSize(pBlock);
  size = sizeof(SRetrieveMetaTableRsp) + sizeof(int32_t) + sizeof(SSysTableSchema) * pShow->pMeta->numOfColumns +
         dataEncodeBufSize;

  SRetrieveMetaTableRsp *pRsp = rpcMallocCont(size);
  if (pRsp == NULL) {
    mError("show:0x%" PRIx64 ", failed to retrieve data since %s", pShow->id, tstrerror(code));
    code = terrno;
    goto _exit;
  }

  pRsp->handle = htobe64(pShow->id);

  if (rowsRead > 0) {
    char    *pStart = pRsp->data;
    SSchema *ps = pShow->pMeta->pSchemas;

    *(int32_t *)pStart = htonl(pShow->pMeta->numOfColumns);
    pStart += sizeof(int32_t);  // number of columns

    for (int32_t i = 0; i < pShow->pMeta->numOfColumns; ++i) {
      SSysTableSchema *pSchema = (SSysTableSchema *)pStart;
      pSchema->bytes = htonl(ps[i].bytes);
      pSchema->colId = htons(ps[i].colId);
      pSchema->type = ps[i].type;

      pStart += sizeof(SSysTableSchema);
    }

    int32_t len = blockEncode(pBlock, pStart, dataEncodeBufSize, pShow->pMeta->numOfColumns);
    if (len < 0) {
      mError("show:0x%" PRIx64 ", failed to retrieve data since %s", pShow->id, tstrerror(code));
      code = terrno;
      return code;
    }
  }

  pRsp->numOfRows = htonl(rowsRead);
  pRsp->precision = TSDB_TIME_PRECISION_MILLI;  // millisecond time precision
  pReq->info.rsp = pRsp;
  pReq->info.rspLen = size;

  if (rowsRead == 0 || mndCheckRetrieveFinished(pShow)) {
    pRsp->completed = 1;
    mDebug("show:0x%" PRIx64 ", retrieve completed", pShow->id);
    mndReleaseShowObj(pShow, true);
  } else {
    mDebug("show:0x%" PRIx64 ", retrieve not completed yet", pShow->id);
    mndReleaseShowObj(pShow, false);
  }

  blockDataDestroy(pBlock);
  return TSDB_CODE_SUCCESS;
_exit:
  mndReleaseShowObj(pShow, false);
  blockDataDestroy(pBlock);
  if (pRsp) {
    rpcFreeCont(pRsp);
  }
  return code;
}

static bool mndCheckRetrieveFinished(SShowObj *pShow) {
  if (pShow->pIter == NULL && pShow->numOfRows != 0) {
    return true;
  }
  return false;
}

void mndAddShowRetrieveHandle(SMnode *pMnode, EShowType showType, ShowRetrieveFp fp) {
  SShowMgmt *pMgmt = &pMnode->showMgmt;
  pMgmt->retrieveFps[showType] = fp;
}

void mndAddShowFreeIterHandle(SMnode *pMnode, EShowType showType, ShowFreeIterFp fp) {
  SShowMgmt *pMgmt = &pMnode->showMgmt;
  pMgmt->freeIterFps[showType] = fp;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "mndShow.h"
18	#include "mndPrivilege.h"
19	#include "mndUser.h"
20	#include "systable.h"
21
22	#define SHOW_STEP_SIZE 100
23	#define SHOW_COLS_STEP_SIZE 4096
24	#define SHOW_PRIVILEGES_STEP_SIZE 2048
25
26	static SShowObj mndCreateShowObj(SMnode pMnode, SRetrieveTableReq *pReq);
27	static void mndFreeShowObj(SShowObj *pShow);
28	static SShowObj mndAcquireShowObj(SMnode pMnode, int64_t showId);
29	static void mndReleaseShowObj(SShowObj *pShow, bool forceRemove);
30	static bool mndCheckRetrieveFinished(SShowObj *pShow);
31	static int32_t mndProcessRetrieveSysTableReq(SRpcMsg *pReq);
32
33	int32_t mndInitShow(SMnode *pMnode) {	1,631✔
34	int32_t code = 0;	1,631✔
35	SShowMgmt *pMgmt = &pMnode->showMgmt;	1,631✔
36
37	pMgmt->cache = taosCacheInit(TSDB_DATA_TYPE_INT, 5000, true, (__cache_free_fn_t)mndFreeShowObj, "show");	1,631✔
38	if (pMgmt->cache == NULL) {	1,631!
39	code = TSDB_CODE_OUT_OF_MEMORY;	×
40	mError("failed to alloc show cache since %s", tstrerror(code));	×
41	TAOS_RETURN(code);	×
42	}
43
44	mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveSysTableReq);	1,631✔
45	TAOS_RETURN(code);	1,631✔
46	}
47
48	void mndCleanupShow(SMnode *pMnode) {	1,630✔
49	SShowMgmt *pMgmt = &pMnode->showMgmt;	1,630✔
50	if (pMgmt->cache != NULL) {	1,630!
51	taosCacheCleanup(pMgmt->cache);	1,630✔
52	pMgmt->cache = NULL;	1,630✔
53	}
54	}	1,630✔
55
56	static int32_t convertToRetrieveType(char *name, int32_t len) {	217,853✔
57	int32_t type = -1;	217,853✔
58
59	if (strncasecmp(name, TSDB_INS_TABLE_DNODES, len) == 0) {	217,853✔
60	type = TSDB_MGMT_TABLE_DNODE;	7,240✔
61	} else if (strncasecmp(name, TSDB_INS_TABLE_MNODES, len) == 0) {	210,613✔
62	type = TSDB_MGMT_TABLE_MNODE;	4,433✔
63	/*
64	} else if (strncasecmp(name, TSDB_INS_TABLE_MODULES, len) == 0) {
65	type = TSDB_MGMT_TABLE_MODULE;
66	*/
67	} else if (strncasecmp(name, TSDB_INS_TABLE_QNODES, len) == 0) {	206,180✔
68	type = TSDB_MGMT_TABLE_QNODE;	2,179✔
69	} else if (strncasecmp(name, TSDB_INS_TABLE_SNODES, len) == 0) {	204,001✔
70	type = TSDB_MGMT_TABLE_SNODE;	2,197✔
71	} else if (strncasecmp(name, TSDB_INS_TABLE_ANODES, len) == 0) {	201,804✔
72	type = TSDB_MGMT_TABLE_ANODE;	3✔
73	} else if (strncasecmp(name, TSDB_INS_TABLE_ANODES_FULL, len) == 0) {	201,801✔
74	type = TSDB_MGMT_TABLE_ANODE_FULL;	1✔
75	} else if (strncasecmp(name, TSDB_INS_TABLE_ARBGROUPS, len) == 0) {	201,800!
76	type = TSDB_MGMT_TABLE_ARBGROUP;	×
77	} else if (strncasecmp(name, TSDB_INS_TABLE_CLUSTER, len) == 0) {	201,800✔
78	type = TSDB_MGMT_TABLE_CLUSTER;	4,316✔
79	} else if (strncasecmp(name, TSDB_INS_TABLE_DATABASES, len) == 0) {	197,484✔
80	type = TSDB_MGMT_TABLE_DB;	27,571✔
81	} else if (strncasecmp(name, TSDB_INS_TABLE_FUNCTIONS, len) == 0) {	169,913✔
82	type = TSDB_MGMT_TABLE_FUNC;	7,231✔
83	} else if (strncasecmp(name, TSDB_INS_TABLE_INDEXES, len) == 0) {	162,682✔
84	type = TSDB_MGMT_TABLE_INDEX;	6,790✔
85	} else if (strncasecmp(name, TSDB_INS_TABLE_STABLES, len) == 0) {	155,892✔
86	type = TSDB_MGMT_TABLE_STB;	8,393✔
87	} else if (strncasecmp(name, TSDB_INS_TABLE_TABLES, len) == 0) {	147,499!
88	type = TSDB_MGMT_TABLE_TABLE;	×
89	} else if (strncasecmp(name, TSDB_INS_TABLE_TAGS, len) == 0) {	147,499!
90	type = TSDB_MGMT_TABLE_TAG;	×
91	} else if (strncasecmp(name, TSDB_INS_TABLE_COLS, len) == 0) {	147,499✔
92	type = TSDB_MGMT_TABLE_COL;	13,320✔
93	} else if (strncasecmp(name, TSDB_INS_TABLE_TABLE_DISTRIBUTED, len) == 0) {	134,179✔
94	// type = TSDB_MGMT_TABLE_DIST;
95	} else if (strncasecmp(name, TSDB_INS_TABLE_USERS, len) == 0) {	134,152✔
96	type = TSDB_MGMT_TABLE_USER;	5,073✔
97	} else if (strncasecmp(name, TSDB_INS_TABLE_USERS_FULL, len) == 0) {	129,079!
98	type = TSDB_MGMT_TABLE_USER_FULL;	×
99	} else if (strncasecmp(name, TSDB_INS_TABLE_LICENCES, len) == 0) {	129,079✔
100	type = TSDB_MGMT_TABLE_GRANTS;	5,758✔
101	} else if (strncasecmp(name, TSDB_INS_TABLE_VGROUPS, len) == 0) {	123,321✔
102	type = TSDB_MGMT_TABLE_VGROUP;	10,699✔
103	} else if (strncasecmp(name, TSDB_PERFS_TABLE_CONSUMERS, len) == 0) {	112,622✔
104	type = TSDB_MGMT_TABLE_CONSUMERS;	8,001✔
105	} else if (strncasecmp(name, TSDB_INS_TABLE_SUBSCRIPTIONS, len) == 0) {	104,621✔
106	type = TSDB_MGMT_TABLE_SUBSCRIPTIONS;	5,850✔
107	} else if (strncasecmp(name, TSDB_PERFS_TABLE_TRANS, len) == 0) {	98,771✔
108	type = TSDB_MGMT_TABLE_TRANS;	7,470✔
109	} else if (strncasecmp(name, TSDB_PERFS_TABLE_SMAS, len) == 0) {	91,301!
110	type = TSDB_MGMT_TABLE_SMAS;	×
111	} else if (strncasecmp(name, TSDB_INS_TABLE_CONFIGS, len) == 0) {	91,301✔
112	type = TSDB_MGMT_TABLE_CONFIGS;	1,442✔
113	} else if (strncasecmp(name, TSDB_PERFS_TABLE_CONNECTIONS, len) == 0) {	89,859✔
114	type = TSDB_MGMT_TABLE_CONNS;	6,509✔
115	} else if (strncasecmp(name, TSDB_PERFS_TABLE_QUERIES, len) == 0) {	83,350✔
116	type = TSDB_MGMT_TABLE_QUERIES;	11,516✔
117	} else if (strncasecmp(name, TSDB_INS_TABLE_VNODES, len) == 0) {	71,834✔
118	type = TSDB_MGMT_TABLE_VNODES;	5,156✔
119	} else if (strncasecmp(name, TSDB_INS_TABLE_TOPICS, len) == 0) {	66,678✔
120	type = TSDB_MGMT_TABLE_TOPICS;	5,072✔
121	} else if (strncasecmp(name, TSDB_INS_TABLE_STREAMS, len) == 0) {	61,606✔
122	type = TSDB_MGMT_TABLE_STREAMS;	11,242✔
123	} else if (strncasecmp(name, TSDB_PERFS_TABLE_APPS, len) == 0) {	50,364✔
124	type = TSDB_MGMT_TABLE_APPS;	10,792✔
125	} else if (strncasecmp(name, TSDB_INS_TABLE_STREAM_TASKS, len) == 0) {	39,572✔
126	type = TSDB_MGMT_TABLE_STREAM_TASKS;	20,677✔
127	} else if (strncasecmp(name, TSDB_INS_TABLE_USER_PRIVILEGES, len) == 0) {	18,895✔
128	type = TSDB_MGMT_TABLE_PRIVILEGES;	4,333✔
129	} else if (strncasecmp(name, TSDB_INS_TABLE_VIEWS, len) == 0) {	14,562✔
130	type = TSDB_MGMT_TABLE_VIEWS;	6,526✔
131	} else if (strncasecmp(name, TSDB_INS_TABLE_COMPACTS, len) == 0) {	8,036✔
132	type = TSDB_MGMT_TABLE_COMPACT;	2,240✔
133	} else if (strncasecmp(name, TSDB_INS_TABLE_COMPACT_DETAILS, len) == 0) {	5,796✔
134	type = TSDB_MGMT_TABLE_COMPACT_DETAIL;	5,751✔
135	} else if (strncasecmp(name, TSDB_INS_TABLE_TRANSACTION_DETAILS, len) == 0) {	45!
136	type = TSDB_MGMT_TABLE_TRANSACTION_DETAIL;	×
137	} else if (strncasecmp(name, TSDB_INS_TABLE_GRANTS_FULL, len) == 0) {	45✔
138	type = TSDB_MGMT_TABLE_GRANTS_FULL;	6✔
139	} else if (strncasecmp(name, TSDB_INS_TABLE_GRANTS_LOGS, len) == 0) {	39✔
140	type = TSDB_MGMT_TABLE_GRANTS_LOGS;	6✔
141	} else if (strncasecmp(name, TSDB_INS_TABLE_MACHINES, len) == 0) {	33✔
142	type = TSDB_MGMT_TABLE_MACHINES;	6✔
143	} else if (strncasecmp(name, TSDB_INS_TABLE_ENCRYPTIONS, len) == 0) {	27!
144	type = TSDB_MGMT_TABLE_ENCRYPTIONS;	×
145	} else if (strncasecmp(name, TSDB_INS_TABLE_TSMAS, len) == 0) {	27!
UNCOV 146	type = TSDB_MGMT_TABLE_TSMAS;	×
147	} else if (strncasecmp(name, TSDB_INS_DISK_USAGE, len) == 0) {	27!
148	type = TSDB_MGMT_TABLE_USAGE;	×
149	} else if (strncasecmp(name, TSDB_INS_TABLE_FILESETS, len) == 0) {	27!
150	type = TSDB_MGMT_TABLE_FILESETS;	×
151	} else {
152	mError("invalid show name:%s len:%d", name, len);	27!
153	}
154
155	return type;	217,811✔
156	}
157
158	static SShowObj mndCreateShowObj(SMnode pMnode, SRetrieveTableReq *pReq) {	217,795✔
159	SShowMgmt *pMgmt = &pMnode->showMgmt;	217,795✔
160
161	int64_t showId = atomic_add_fetch_64(&pMgmt->showId, 1);	217,795✔
162	if (showId == 0) atomic_add_fetch_64(&pMgmt->showId, 1);	218,075!
163
164	int32_t size = sizeof(SShowObj);	218,075✔
165
166	SShowObj showObj = {0};	218,075✔
167
168	showObj.id = showId;	218,075✔
169	showObj.pMnode = pMnode;	218,075✔
170	showObj.type = convertToRetrieveType(pReq->tb, tListLen(pReq->tb));	218,075✔
171	(void)memcpy(showObj.db, pReq->db, TSDB_DB_FNAME_LEN);	217,832✔
172	tstrncpy(showObj.filterTb, pReq->filterTb, TSDB_TABLE_NAME_LEN);	217,832✔
173
174	int32_t keepTime = tsShellActivityTimer * 6 * 1000;	217,832✔
175	SShowObj *pShow = taosCachePut(pMgmt->cache, &showId, sizeof(int64_t), &showObj, size, keepTime);	217,832✔
176	if (pShow == NULL) {	218,037!
177	terrno = TSDB_CODE_OUT_OF_MEMORY;	×
178	mError("show:0x%" PRIx64 ", failed to put into cache since %s", showId, terrstr());	×
179	return NULL;	×
180	}
181
182	mTrace("show:0x%" PRIx64 ", is created, data:%p", showId, pShow);	218,037✔
183	return pShow;	218,018✔
184	}
185
186	static void mndFreeShowObj(SShowObj *pShow) {	218,123✔
187	SMnode *pMnode = pShow->pMnode;	218,123✔
188	SShowMgmt *pMgmt = &pMnode->showMgmt;	218,123✔
189
190	ShowFreeIterFp freeFp = pMgmt->freeIterFps[pShow->type];	218,123✔
191	if (freeFp != NULL) {	218,123✔
192	if (pShow->pIter != NULL) {	204,267!
193	mTrace("show:0x%" PRIx64 ", is destroying, data:%p, pIter:%p, ", pShow->id, pShow, pShow->pIter);	×
194
195	(*freeFp)(pMnode, pShow->pIter);	×
196
197	pShow->pIter = NULL;	×
198	}
199	}
200
201	mTrace("show:0x%" PRIx64 ", is destroyed, data:%p", pShow->id, pShow);	218,123✔
202	}	218,123✔
203
204	static SShowObj mndAcquireShowObj(SMnode pMnode, int64_t showId) {	6,792✔
205	SShowMgmt *pMgmt = &pMnode->showMgmt;	6,792✔
206
207	SShowObj *pShow = taosCacheAcquireByKey(pMgmt->cache, &showId, sizeof(showId));	6,792✔
208	if (pShow == NULL) {	6,794!
209	mError("show:0x%" PRIx64 ", already destroyed", showId);	×
210	return NULL;	×
211	}
212
213	mTrace("show:0x%" PRIx64 ", acquired from cache, data:%p", pShow->id, pShow);	6,794!
214	return pShow;	6,794✔
215	}
216
217	static void mndReleaseShowObj(SShowObj *pShow, bool forceRemove) {	224,658✔
218	if (pShow == NULL) return;	224,658!
219	mTrace("show:0x%" PRIx64 ", released from cache, data:%p force:%d", pShow->id, pShow, forceRemove);	224,658✔
220
221	// A bug in tcache.c
222	forceRemove = 0;	224,658✔
223
224	SMnode *pMnode = pShow->pMnode;	224,658✔
225	SShowMgmt *pMgmt = &pMnode->showMgmt;	224,658✔
226	taosCacheRelease(pMgmt->cache, (void **)(&pShow), forceRemove);	224,658✔
227	}
228
229	static int32_t mndProcessRetrieveSysTableReq(SRpcMsg *pReq) {	224,799✔
230	int32_t code = 0;	224,799✔
231	SMnode *pMnode = pReq->info.node;	224,799✔
232	SShowMgmt *pMgmt = &pMnode->showMgmt;	224,799✔
233	SShowObj *pShow = NULL;	224,799✔
234	int32_t rowsToRead = SHOW_STEP_SIZE;	224,799✔
235	int32_t size = 0;	224,799✔
236	int32_t rowsRead = 0;	224,799✔
237	mDebug("mndProcessRetrieveSysTableReq start");	224,799✔
238	SRetrieveTableReq retrieveReq = {0};	224,799✔
239	TAOS_CHECK_RETURN(tDeserializeSRetrieveTableReq(pReq->pCont, pReq->contLen, &retrieveReq));	224,799✔
240
241	mDebug("process to retrieve systable req db:%s, tb:%s, compactId:%" PRId64, retrieveReq.db, retrieveReq.tb,	224,760✔
242	retrieveReq.compactId);
243
244	if (retrieveReq.showId == 0) {	224,815✔
245	STableMetaRsp *pMeta = taosHashGet(pMnode->infosMeta, retrieveReq.tb, strlen(retrieveReq.tb));	218,024✔
246	if (pMeta == NULL) {	217,858✔
247	pMeta = taosHashGet(pMnode->perfsMeta, retrieveReq.tb, strlen(retrieveReq.tb));	44,295✔
248	if (pMeta == NULL) {	44,327!
249	code = TSDB_CODE_PAR_TABLE_NOT_EXIST;	×
250	mError("failed to process show-retrieve req:%p since %s", pShow, tstrerror(code));	×
251	TAOS_RETURN(code);	×
252	}
253	}
254
255	pShow = mndCreateShowObj(pMnode, &retrieveReq);	217,890✔
256	if (pShow == NULL) {	217,980✔
257	code = terrno;	34✔
258	mError("failed to process show-meta req since %s", tstrerror(code));	×
259	TAOS_RETURN(code);	×
260	}
261
262	pShow->pMeta = pMeta;	217,946✔
263	pShow->numOfColumns = pShow->pMeta->numOfColumns;	217,946✔
264	} else {
265	pShow = mndAcquireShowObj(pMnode, retrieveReq.showId);	6,791✔
266	if (pShow == NULL) {	6,793✔
267	code = TSDB_CODE_MND_INVALID_SHOWOBJ;	58✔
268	mError("failed to process show-retrieve req:%p since %s", pShow, tstrerror(code));	58!
269	TAOS_RETURN(code);	58✔
270	}
271	}
272
273	if (pShow->type == TSDB_MGMT_TABLE_COL) { // expend capacity for ins_columns	224,681✔
274	rowsToRead = SHOW_COLS_STEP_SIZE;	13,320✔
275	} else if (pShow->type == TSDB_MGMT_TABLE_PRIVILEGES) {	211,361✔
276	rowsToRead = SHOW_PRIVILEGES_STEP_SIZE;	4,335✔
277	}
278	ShowRetrieveFp retrieveFp = pMgmt->retrieveFps[pShow->type];	224,681✔
279	if (retrieveFp == NULL) {	224,681!
280	mndReleaseShowObj(pShow, false);	×
281	code = TSDB_CODE_MSG_NOT_PROCESSED;	×
282	mError("show:0x%" PRIx64 ", failed to retrieve data since %s", pShow->id, tstrerror(code));	×
283	TAOS_RETURN(code);	×
284	}
285
286	mDebug("show:0x%" PRIx64 ", start retrieve data, type:%d", pShow->id, pShow->type);	224,681✔
287	if (retrieveReq.user[0] != 0) {	224,616✔
288	(void)memcpy(pReq->info.conn.user, retrieveReq.user, TSDB_USER_LEN);	224,594✔
289	} else {
290	(void)memcpy(pReq->info.conn.user, TSDB_DEFAULT_USER, strlen(TSDB_DEFAULT_USER) + 1);	22✔
291	}
292	code = -1;	224,616✔
293	if (retrieveReq.db[0] &&	227,453✔
294	(code = mndCheckShowPrivilege(pMnode, pReq->info.conn.user, pShow->type, retrieveReq.db)) != 0) {	2,837✔
295	TAOS_RETURN(code);	4✔
296	}
297	if (pShow->type == TSDB_MGMT_TABLE_USER_FULL) {	224,612!
298	if (strcmp(pReq->info.conn.user, "root") != 0) {	×
299	mError("The operation is not permitted, user:%s, pShow->type:%d", pReq->info.conn.user, pShow->type);	×
300	code = TSDB_CODE_MND_NO_RIGHTS;	×
301	TAOS_RETURN(code);	×
302	}
303	}
304
305	int32_t numOfCols = pShow->pMeta->numOfColumns;	224,612✔
306
307	SSDataBlock *pBlock = NULL;	224,612✔
308	code = createDataBlock(&pBlock);	224,612✔
309	if (code) {	224,657!
310	TAOS_RETURN(code);	×
311	}
312
313	for (int32_t i = 0; i < numOfCols; ++i) {	3,483,497✔
314	SColumnInfoData idata = {0};	3,258,220✔
315
316	SSchema *p = &pShow->pMeta->pSchemas[i];	3,258,220✔
317
318	idata.info.bytes = p->bytes;	3,258,220✔
319	idata.info.type = p->type;	3,258,220✔
320	idata.info.colId = p->colId;	3,258,220✔
321	TAOS_CHECK_RETURN(blockDataAppendColInfo(pBlock, &idata));	3,258,220!
322	}
323
324	TAOS_CHECK_RETURN(blockDataEnsureCapacity(pBlock, rowsToRead));	225,277!
325
326	if (mndCheckRetrieveFinished(pShow)) {	224,742!
327	mDebug("show:0x%" PRIx64 ", read finished, numOfRows:%d", pShow->id, pShow->numOfRows);	×
328	rowsRead = 0;	×
329	} else {
330	rowsRead = (*retrieveFp)(pReq, pShow, pBlock, rowsToRead);	224,747✔
331	if (rowsRead < 0) {	224,805✔
332	code = rowsRead;	3✔
333	mDebug("show:0x%" PRIx64 ", retrieve completed", pShow->id);	3!
334	mndReleaseShowObj(pShow, true);	3✔
335	blockDataDestroy(pBlock);	3✔
336	TAOS_RETURN(code);	3✔
337	}
338
339	pBlock->info.rows = rowsRead;	224,802✔
340	mDebug("show:0x%" PRIx64 ", stop retrieve data, rowsRead:%d numOfRows:%d", pShow->id, rowsRead, pShow->numOfRows);	224,802✔
341	}
342
343	size_t dataEncodeBufSize = blockGetEncodeSize(pBlock);	224,802✔
344	size = sizeof(SRetrieveMetaTableRsp) + sizeof(int32_t) + sizeof(SSysTableSchema) * pShow->pMeta->numOfColumns +	224,664✔
345	dataEncodeBufSize;
346
347	SRetrieveMetaTableRsp *pRsp = rpcMallocCont(size);	224,664✔
348	if (pRsp == NULL) {	224,733!
349	mError("show:0x%" PRIx64 ", failed to retrieve data since %s", pShow->id, tstrerror(code));	×
350	code = terrno;	×
351	goto _exit;	×
352	}
353
354	pRsp->handle = htobe64(pShow->id);	224,733✔
355
356	if (rowsRead > 0) {	224,769✔
357	char *pStart = pRsp->data;	176,748✔
358	SSchema *ps = pShow->pMeta->pSchemas;	176,748✔
359
360	(int32_t )pStart = htonl(pShow->pMeta->numOfColumns);	176,748✔
361	pStart += sizeof(int32_t); // number of columns	176,748✔
362
363	for (int32_t i = 0; i < pShow->pMeta->numOfColumns; ++i) {	3,030,396✔
364	SSysTableSchema pSchema = (SSysTableSchema )pStart;	2,853,648✔
365	pSchema->bytes = htonl(ps[i].bytes);	2,853,648✔
366	pSchema->colId = htons(ps[i].colId);	2,853,648✔
367	pSchema->type = ps[i].type;	2,853,648✔
368
369	pStart += sizeof(SSysTableSchema);	2,853,648✔
370	}
371
372	int32_t len = blockEncode(pBlock, pStart, dataEncodeBufSize, pShow->pMeta->numOfColumns);	176,748✔
373	if (len < 0) {	176,829!
374	mError("show:0x%" PRIx64 ", failed to retrieve data since %s", pShow->id, tstrerror(code));	×
375	code = terrno;	×
376	return code;	×
377	}
378	}
379
380	pRsp->numOfRows = htonl(rowsRead);	224,850✔
381	pRsp->precision = TSDB_TIME_PRECISION_MILLI; // millisecond time precision	224,850✔
382	pReq->info.rsp = pRsp;	224,850✔
383	pReq->info.rspLen = size;	224,850✔
384
385	if (rowsRead == 0 \|\| mndCheckRetrieveFinished(pShow)) {	224,850✔
386	pRsp->completed = 1;	218,103✔
387	mDebug("show:0x%" PRIx64 ", retrieve completed", pShow->id);	218,103✔
388	mndReleaseShowObj(pShow, true);	218,103✔
389	} else {
390	mDebug("show:0x%" PRIx64 ", retrieve not completed yet", pShow->id);	6,790✔
391	mndReleaseShowObj(pShow, false);	6,790✔
392	}
393
394	blockDataDestroy(pBlock);	224,784✔
395	return TSDB_CODE_SUCCESS;	224,857✔
396	_exit:	×
397	mndReleaseShowObj(pShow, false);	×
398	blockDataDestroy(pBlock);	×
399	if (pRsp) {	×
400	rpcFreeCont(pRsp);	×
401	}
402	return code;	×
403	}
404
405	static bool mndCheckRetrieveFinished(SShowObj *pShow) {	401,451✔
406	if (pShow->pIter == NULL && pShow->numOfRows != 0) {	401,451✔
407	return true;	169,975✔
408	}
409	return false;	231,476✔
410	}
411
412	void mndAddShowRetrieveHandle(SMnode *pMnode, EShowType showType, ShowRetrieveFp fp) {	61,978✔
413	SShowMgmt *pMgmt = &pMnode->showMgmt;	61,978✔
414	pMgmt->retrieveFps[showType] = fp;	61,978✔
415	}	61,978✔
416
417	void mndAddShowFreeIterHandle(SMnode *pMnode, EShowType showType, ShowFreeIterFp fp) {	57,085✔
418	SShowMgmt *pMgmt = &pMnode->showMgmt;	57,085✔
419	pMgmt->freeIterFps[showType] = fp;	57,085✔
420	}	57,085✔

taosdata / TDengine / #3586

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous