12830307476

Committed 17 Jan 2025 01:46PM UTC coverage: 83.237%. First build

Build # 12830307476

Build Type

Pull #4114

github

Committed by

web-flow

Commit Message

Merge 09b970aca into dea27c53b

Pull Request Pull Request #4114: (Improve order flow) Add error logging

Run Details

14 of 16 new or added lines in 2 files covered. (87.5%)

16744 of 20116 relevant lines covered (83.24%)

1.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.83

/cg/services/orders/validation/errors/validation_errors.py

from pydantic import BaseModel

from cg.services.orders.validation.errors.case_errors import CaseError
from cg.services.orders.validation.errors.case_sample_errors import CaseSampleError
from cg.services.orders.validation.errors.order_errors import OrderError
from cg.services.orders.validation.errors.sample_errors import SampleError


class ValidationErrors(BaseModel):
    order_errors: list[OrderError] = []
    case_errors: list[CaseError] = []
    sample_errors: list[SampleError] = []
    case_sample_errors: list[CaseSampleError] = []

    @property
    def is_empty(self) -> bool:
        """Return True if there are no errors in any of the attributes."""
        return all(not getattr(self, field) for field in self.model_fields)

    def get_error_message(self) -> str:
        """Gets a string documenting all errors."""
        error_string = ""
        for error in self.order_errors:
            error_string += f"Problem with {error.field}: {error.message} \n"
        for error in self.case_errors:
            error_string += (
                f"Problem with {error.field} in case {error.case_index}: {error.message} \n"
            )
        for error in self.case_sample_errors:
            error_string += f"Problem with {error.field} in case {error.case_index} sample {error.sample_index}: {error.message} \n"
        for error in self.sample_errors:
            error_string += (
                f"Problem with {error.field} in sample {error.sample_index}: {error.message} \n"
            )
        return error_string

1	from pydantic import BaseModel	1✔
2
3	from cg.services.orders.validation.errors.case_errors import CaseError	1✔
4	from cg.services.orders.validation.errors.case_sample_errors import CaseSampleError	1✔
5	from cg.services.orders.validation.errors.order_errors import OrderError	1✔
6	from cg.services.orders.validation.errors.sample_errors import SampleError	1✔
7
8
9	class ValidationErrors(BaseModel):	1✔
10	order_errors: list[OrderError] = []	1✔
11	case_errors: list[CaseError] = []	1✔
12	sample_errors: list[SampleError] = []	1✔
13	case_sample_errors: list[CaseSampleError] = []	1✔
14
15	@property	1✔
16	def is_empty(self) -> bool:	1✔
17	"""Return True if there are no errors in any of the attributes."""
18	return all(not getattr(self, field) for field in self.model_fields)	1✔
19
20	def get_error_message(self) -> str:	1✔
21	"""Gets a string documenting all errors."""
22	error_string = ""	1✔
23	for error in self.order_errors:	1✔
24	error_string += f"Problem with {error.field}: {error.message} \n"	1✔
25	for error in self.case_errors:	1✔
26	error_string += (	1✔
27	f"Problem with {error.field} in case {error.case_index}: {error.message} \n"
28	)
29	for error in self.case_sample_errors:	1✔
30	error_string += f"Problem with {error.field} in case {error.case_index} sample {error.sample_index}: {error.message} \n"	1✔
31	for error in self.sample_errors:	1✔
NEW 32	error_string += (	×
33	f"Problem with {error.field} in sample {error.sample_index}: {error.message} \n"
34	)
35	return error_string	1✔

Clinical-Genomics / cg / 12830307476

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous