• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 12786017924

15 Jan 2025 10:08AM UTC coverage: 22.329% (+0.3%) from 22.034%
12786017924

push

github

web-flow
[performance] in large-scale clusters, init node router policy too slow (#4895)

* [performance] init node router policy too slow, in large clusters

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

* [fix] uncomment

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

* [fix] code standards

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

* [fix] delete whitespace

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

* [fix] empty logical_router_policy slice parameters

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

* [fix] uncomment

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

* [fix] variable name

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

---------

Signed-off-by: cmdy <zhang_lin66@foxmail.com>

229 of 445 new or added lines in 6 files covered. (51.46%)

6 existing lines in 2 files now uncovered.

10374 of 46460 relevant lines covered (22.33%)

0.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/pkg/controller/vpc.go
1
package controller
2

3
import (
4
        "context"
5
        "encoding/json"
6
        "errors"
7
        "fmt"
8
        "maps"
9
        "math"
10
        "net"
11
        "reflect"
12
        "slices"
13
        "sort"
14
        "strings"
15
        "time"
16

17
        v1 "k8s.io/api/core/v1"
18
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
19
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
20
        "k8s.io/apimachinery/pkg/labels"
21
        "k8s.io/apimachinery/pkg/types"
22
        "k8s.io/client-go/tools/cache"
23
        "k8s.io/klog/v2"
24

25
        kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
26
        "github.com/kubeovn/kube-ovn/pkg/ovsdb/ovnnb"
27
        "github.com/kubeovn/kube-ovn/pkg/util"
28
)
29

30
func (c *Controller) enqueueAddVpc(obj interface{}) {
×
31
        vpc := obj.(*kubeovnv1.Vpc)
×
32
        key := cache.MetaObjectToName(vpc).String()
×
33
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !ok {
×
34
                klog.V(3).Infof("enqueue add vpc %s", key)
×
35
                c.addOrUpdateVpcQueue.Add(key)
×
36
        }
×
37
}
38

39
func vpcBFDPortChanged(oldObj, newObj *kubeovnv1.BFDPort) bool {
×
40
        if oldObj == nil && newObj == nil {
×
41
                return false
×
42
        }
×
43
        if oldObj == nil || newObj == nil {
×
44
                return true
×
45
        }
×
46
        return oldObj.Enabled != newObj.Enabled || oldObj.IP != newObj.IP || !reflect.DeepEqual(oldObj.NodeSelector, newObj.NodeSelector)
×
47
}
48

49
func (c *Controller) enqueueUpdateVpc(oldObj, newObj interface{}) {
×
50
        oldVpc := oldObj.(*kubeovnv1.Vpc)
×
51
        newVpc := newObj.(*kubeovnv1.Vpc)
×
52

×
53
        if !newVpc.DeletionTimestamp.IsZero() ||
×
54
                !slices.Equal(oldVpc.Spec.Namespaces, newVpc.Spec.Namespaces) ||
×
55
                !reflect.DeepEqual(oldVpc.Spec.StaticRoutes, newVpc.Spec.StaticRoutes) ||
×
56
                !reflect.DeepEqual(oldVpc.Spec.PolicyRoutes, newVpc.Spec.PolicyRoutes) ||
×
57
                !reflect.DeepEqual(oldVpc.Spec.VpcPeerings, newVpc.Spec.VpcPeerings) ||
×
58
                !maps.Equal(oldVpc.Annotations, newVpc.Annotations) ||
×
59
                !slices.Equal(oldVpc.Spec.ExtraExternalSubnets, newVpc.Spec.ExtraExternalSubnets) ||
×
60
                oldVpc.Spec.EnableExternal != newVpc.Spec.EnableExternal ||
×
61
                oldVpc.Spec.EnableBfd != newVpc.Spec.EnableBfd ||
×
62
                vpcBFDPortChanged(oldVpc.Spec.BFDPort, newVpc.Spec.BFDPort) ||
×
63
                oldVpc.Labels[util.VpcExternalLabel] != newVpc.Labels[util.VpcExternalLabel] {
×
64
                // TODO:// label VpcExternalLabel replace with spec enable external
×
65

×
66
                if newVpc.Annotations == nil {
×
67
                        newVpc.Annotations = make(map[string]string)
×
68
                }
×
69
                newVpc.Annotations[util.VpcLastPolicies] = convertPolicies(oldVpc.Spec.PolicyRoutes)
×
70

×
71
                key := cache.MetaObjectToName(newVpc).String()
×
72
                klog.Infof("enqueue update vpc %s", key)
×
73
                c.addOrUpdateVpcQueue.Add(key)
×
74
        }
75
}
76

77
func (c *Controller) enqueueDelVpc(obj interface{}) {
×
78
        vpc := obj.(*kubeovnv1.Vpc)
×
79
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !vpc.Status.Default || !ok {
×
80
                klog.V(3).Infof("enqueue delete vpc %s", vpc.Name)
×
81
                c.delVpcQueue.Add(vpc)
×
82
        }
×
83
}
84

85
func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error {
×
86
        c.vpcKeyMutex.LockKey(vpc.Name)
×
87
        defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }()
×
88
        klog.Infof("handle delete vpc %s", vpc.Name)
×
89

×
90
        // should delete vpc subnets first
×
91
        var err error
×
92
        for _, subnet := range vpc.Status.Subnets {
×
93
                if _, err = c.subnetsLister.Get(subnet); err != nil {
×
94
                        if k8serrors.IsNotFound(err) {
×
95
                                continue
×
96
                        }
97
                        err = fmt.Errorf("failed to get subnet %s for vpc %s: %w", subnet, vpc.Name, err)
×
98
                } else {
×
99
                        err = fmt.Errorf("failed to delete vpc %s, please delete subnet %s first", vpc.Name, subnet)
×
100
                }
×
101
                klog.Error(err)
×
102
                return err
×
103
        }
104

105
        if err := c.deleteVpcLb(vpc); err != nil {
×
106
                klog.Error(err)
×
107
                return err
×
108
        }
×
109

110
        if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
111
                klog.Errorf("failed to delete external connection for vpc %s, error %v", vpc.Name, err)
×
112
                return err
×
113
        }
×
114

115
        for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
116
                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)
×
117
                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
118
                        klog.Error(err)
×
119
                        return err
×
120
                }
×
121
        }
122

123
        if err := c.deleteVpcRouter(vpc.Status.Router); err != nil {
×
124
                klog.Error(err)
×
125
                return err
×
126
        }
×
127

128
        return nil
×
129
}
130

131
func (c *Controller) handleUpdateVpcStatus(key string) error {
×
132
        c.vpcKeyMutex.LockKey(key)
×
133
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
134
        klog.Infof("handle status update for vpc %s", key)
×
135

×
136
        cachedVpc, err := c.vpcsLister.Get(key)
×
137
        if err != nil {
×
138
                if k8serrors.IsNotFound(err) {
×
139
                        return nil
×
140
                }
×
141
                klog.Error(err)
×
142
                return err
×
143
        }
144
        vpc := cachedVpc.DeepCopy()
×
145

×
146
        subnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
147
        if err != nil {
×
148
                klog.Error(err)
×
149
                return err
×
150
        }
×
151

152
        change := false
×
153
        if vpc.Status.DefaultLogicalSwitch != defaultSubnet {
×
154
                change = true
×
155
        }
×
156

157
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
158
        vpc.Status.Subnets = subnets
×
159
        if !vpc.Spec.BFDPort.IsEnabled() && !vpc.Status.BFDPort.IsEmpty() {
×
160
                vpc.Status.BFDPort.Clear()
×
161
        }
×
162
        bytes, err := vpc.Status.Bytes()
×
163
        if err != nil {
×
164
                klog.Error(err)
×
165
                return err
×
166
        }
×
167

168
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
169
        if err != nil {
×
170
                klog.Error(err)
×
171
                return err
×
172
        }
×
173
        if change {
×
174
                for _, ns := range vpc.Spec.Namespaces {
×
175
                        c.addNamespaceQueue.Add(ns)
×
176
                }
×
177
        }
178

179
        natGws, err := c.vpcNatGatewayLister.List(labels.Everything())
×
180
        if err != nil {
×
181
                klog.Error(err)
×
182
                return err
×
183
        }
×
184
        for _, gw := range natGws {
×
185
                if key == gw.Spec.Vpc {
×
186
                        c.updateVpcSubnetQueue.Add(gw.Name)
×
187
                }
×
188
        }
189
        return nil
×
190
}
191

192
type VpcLoadBalancer struct {
193
        TCPLoadBalancer      string
194
        TCPSessLoadBalancer  string
195
        UDPLoadBalancer      string
196
        UDPSessLoadBalancer  string
197
        SctpLoadBalancer     string
198
        SctpSessLoadBalancer string
199
}
200

201
func (c *Controller) GenVpcLoadBalancer(vpcKey string) *VpcLoadBalancer {
×
202
        if vpcKey == c.config.ClusterRouter || vpcKey == "" {
×
203
                return &VpcLoadBalancer{
×
204
                        TCPLoadBalancer:      c.config.ClusterTCPLoadBalancer,
×
205
                        TCPSessLoadBalancer:  c.config.ClusterTCPSessionLoadBalancer,
×
206
                        UDPLoadBalancer:      c.config.ClusterUDPLoadBalancer,
×
207
                        UDPSessLoadBalancer:  c.config.ClusterUDPSessionLoadBalancer,
×
208
                        SctpLoadBalancer:     c.config.ClusterSctpLoadBalancer,
×
209
                        SctpSessLoadBalancer: c.config.ClusterSctpSessionLoadBalancer,
×
210
                }
×
211
        }
×
212
        return &VpcLoadBalancer{
×
213
                TCPLoadBalancer:      fmt.Sprintf("vpc-%s-tcp-load", vpcKey),
×
214
                TCPSessLoadBalancer:  fmt.Sprintf("vpc-%s-tcp-sess-load", vpcKey),
×
215
                UDPLoadBalancer:      fmt.Sprintf("vpc-%s-udp-load", vpcKey),
×
216
                UDPSessLoadBalancer:  fmt.Sprintf("vpc-%s-udp-sess-load", vpcKey),
×
217
                SctpLoadBalancer:     fmt.Sprintf("vpc-%s-sctp-load", vpcKey),
×
218
                SctpSessLoadBalancer: fmt.Sprintf("vpc-%s-sctp-sess-load", vpcKey),
×
219
        }
×
220
}
221

222
func (c *Controller) addLoadBalancer(vpc string) (*VpcLoadBalancer, error) {
×
223
        vpcLbConfig := c.GenVpcLoadBalancer(vpc)
×
224
        if err := c.initLB(vpcLbConfig.TCPLoadBalancer, string(v1.ProtocolTCP), false); err != nil {
×
225
                return nil, err
×
226
        }
×
227
        if err := c.initLB(vpcLbConfig.TCPSessLoadBalancer, string(v1.ProtocolTCP), true); err != nil {
×
228
                return nil, err
×
229
        }
×
230
        if err := c.initLB(vpcLbConfig.UDPLoadBalancer, string(v1.ProtocolUDP), false); err != nil {
×
231
                return nil, err
×
232
        }
×
233
        if err := c.initLB(vpcLbConfig.UDPSessLoadBalancer, string(v1.ProtocolUDP), true); err != nil {
×
234
                return nil, err
×
235
        }
×
236
        if err := c.initLB(vpcLbConfig.SctpLoadBalancer, string(v1.ProtocolSCTP), false); err != nil {
×
237
                return nil, err
×
238
        }
×
239
        if err := c.initLB(vpcLbConfig.SctpSessLoadBalancer, string(v1.ProtocolSCTP), true); err != nil {
×
240
                return nil, err
×
241
        }
×
242

243
        return vpcLbConfig, nil
×
244
}
245

246
func (c *Controller) handleAddOrUpdateVpc(key string) error {
×
247
        c.vpcKeyMutex.LockKey(key)
×
248
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
249
        klog.Infof("handle add/update vpc %s", key)
×
250

×
251
        cachedVpc, err := c.vpcsLister.Get(key)
×
252
        if err != nil {
×
253
                if k8serrors.IsNotFound(err) {
×
254
                        return nil
×
255
                }
×
256
                klog.Error(err)
×
257
                return err
×
258
        }
259

260
        vpc, err := c.formatVpc(cachedVpc.DeepCopy())
×
261
        if err != nil {
×
262
                klog.Errorf("failed to format vpc %s: %v", key, err)
×
263
                return err
×
264
        }
×
265
        if err = c.createVpcRouter(key); err != nil {
×
266
                klog.Errorf("failed to create vpc router for vpc %s: %v", key, err)
×
267
                return err
×
268
        }
×
269

270
        var newPeers []string
×
271
        for _, peering := range vpc.Spec.VpcPeerings {
×
272
                if err = util.CheckCidrs(peering.LocalConnectIP); err != nil {
×
273
                        klog.Errorf("invalid cidr %s", peering.LocalConnectIP)
×
274
                        return err
×
275
                }
×
276

277
                newPeers = append(newPeers, peering.RemoteVpc)
×
278
                if err := c.OVNNbClient.CreatePeerRouterPort(vpc.Name, peering.RemoteVpc, peering.LocalConnectIP); err != nil {
×
279
                        klog.Errorf("create peer router port for vpc %s, %v", vpc.Name, err)
×
280
                        return err
×
281
                }
×
282
        }
283
        for _, oldPeer := range vpc.Status.VpcPeerings {
×
284
                if !slices.Contains(newPeers, oldPeer) {
×
285
                        if err = c.OVNNbClient.DeleteLogicalRouterPort(fmt.Sprintf("%s-%s", vpc.Name, oldPeer)); err != nil {
×
286
                                klog.Errorf("delete peer router port for vpc %s, %v", vpc.Name, err)
×
287
                                return err
×
288
                        }
×
289
                }
290
        }
291

292
        // handle static route
293
        var (
×
294
                staticExistedRoutes []*ovnnb.LogicalRouterStaticRoute
×
295
                staticTargetRoutes  []*kubeovnv1.StaticRoute
×
296
                staticRouteMapping  map[string][]*kubeovnv1.StaticRoute
×
297
        )
×
298

×
299
        staticExistedRoutes, err = c.OVNNbClient.ListLogicalRouterStaticRoutes(vpc.Name, nil, nil, "", nil)
×
300
        if err != nil {
×
301
                klog.Errorf("failed to get vpc %s static route list, %v", vpc.Name, err)
×
302
                return err
×
303
        }
×
304

305
        var externalSubnet *kubeovnv1.Subnet
×
306
        externalSubnetExist := false
×
307
        if c.config.EnableEipSnat {
×
308
                externalSubnet, err = c.subnetsLister.Get(c.config.ExternalGatewaySwitch)
×
309
                if err != nil {
×
310
                        klog.Warningf("enable-eip-snat need external subnet %s to be exist: %v", c.config.ExternalGatewaySwitch, err)
×
311
                } else {
×
312
                        externalSubnetExist = true
×
313
                }
×
314
        }
315

316
        staticRouteMapping = c.getRouteTablesByVpc(vpc)
×
317
        staticTargetRoutes = vpc.Spec.StaticRoutes
×
318
        if vpc.Name == c.config.ClusterRouter {
×
319
                if _, ok := staticRouteMapping[util.MainRouteTable]; !ok {
×
320
                        staticRouteMapping[util.MainRouteTable] = nil
×
321
                }
×
322

323
                joinSubnet, err := c.subnetsLister.Get(c.config.NodeSwitch)
×
324
                if err != nil {
×
325
                        if !k8serrors.IsNotFound(err) {
×
326
                                klog.Errorf("failed to get node switch subnet %s: %v", c.config.NodeSwitch, err)
×
327
                                return err
×
328
                        }
×
329
                        c.addOrUpdateVpcQueue.Add(vpc.Name)
×
330
                        return nil
×
331
                }
332
                gatewayV4, gatewayV6 := util.SplitStringIP(joinSubnet.Spec.Gateway)
×
333
                if gatewayV4 != "" {
×
334
                        for table := range staticRouteMapping {
×
335
                                staticTargetRoutes = append(
×
336
                                        staticTargetRoutes,
×
337
                                        &kubeovnv1.StaticRoute{
×
338
                                                Policy:     kubeovnv1.PolicyDst,
×
339
                                                CIDR:       "0.0.0.0/0",
×
340
                                                NextHopIP:  gatewayV4,
×
341
                                                RouteTable: table,
×
342
                                        },
×
343
                                )
×
344
                        }
×
345
                }
346
                if gatewayV6 != "" {
×
347
                        for table := range staticRouteMapping {
×
348
                                staticTargetRoutes = append(
×
349
                                        staticTargetRoutes,
×
350
                                        &kubeovnv1.StaticRoute{
×
351
                                                Policy:     kubeovnv1.PolicyDst,
×
352
                                                CIDR:       "::/0",
×
353
                                                NextHopIP:  gatewayV6,
×
354
                                                RouteTable: table,
×
355
                                        },
×
356
                                )
×
357
                        }
×
358
                }
359
                if c.config.EnableEipSnat {
×
360
                        cm, err := c.configMapsLister.ConfigMaps(c.config.ExternalGatewayConfigNS).Get(util.ExternalGatewayConfig)
×
361
                        if err == nil {
×
362
                                nextHop := cm.Data["external-gw-addr"]
×
363
                                if nextHop == "" {
×
364
                                        if !externalSubnetExist {
×
365
                                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)
×
366
                                                klog.Error(err)
×
367
                                                return err
×
368
                                        }
×
369
                                        nextHop = externalSubnet.Spec.Gateway
×
370
                                        if nextHop == "" {
×
371
                                                klog.Errorf("no available gateway address")
×
372
                                                return errors.New("no available gateway address")
×
373
                                        }
×
374
                                }
375
                                if strings.Contains(nextHop, "/") {
×
376
                                        nextHop = strings.Split(nextHop, "/")[0]
×
377
                                }
×
378

379
                                lr, err := c.OVNNbClient.GetLogicalRouter(vpc.Name, false)
×
380
                                if err != nil {
×
381
                                        klog.Errorf("failed to get logical router %s: %v", vpc.Name, err)
×
382
                                        return err
×
383
                                }
×
384

385
                                for _, nat := range lr.Nat {
×
386
                                        info, err := c.OVNNbClient.GetNATByUUID(nat)
×
387
                                        if err != nil {
×
388
                                                klog.Errorf("failed to get nat ip info for vpc %s, %v", vpc.Name, err)
×
389
                                                return err
×
390
                                        }
×
391
                                        if info.LogicalIP != "" {
×
392
                                                for table := range staticRouteMapping {
×
393
                                                        staticTargetRoutes = append(
×
394
                                                                staticTargetRoutes,
×
395
                                                                &kubeovnv1.StaticRoute{
×
396
                                                                        Policy:     kubeovnv1.PolicySrc,
×
397
                                                                        CIDR:       info.LogicalIP,
×
398
                                                                        NextHopIP:  nextHop,
×
399
                                                                        RouteTable: table,
×
400
                                                                },
×
401
                                                        )
×
402
                                                }
×
403
                                        }
404
                                }
405
                        }
406
                }
407
        }
408

409
        routeNeedDel, routeNeedAdd, err := diffStaticRoute(staticExistedRoutes, staticTargetRoutes)
×
410
        if err != nil {
×
411
                klog.Errorf("failed to diff vpc %s static route, %v", vpc.Name, err)
×
412
                return err
×
413
        }
×
414

415
        for _, item := range routeNeedDel {
×
416
                klog.Infof("vpc %s del static route: %+v", vpc.Name, item)
×
417
                policy := convertPolicy(item.Policy)
×
418
                if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(vpc.Name, &item.RouteTable, &policy, item.CIDR, item.NextHopIP); err != nil {
×
419
                        klog.Errorf("del vpc %s static route failed, %v", vpc.Name, err)
×
420
                        return err
×
421
                }
×
422
        }
423

424
        for _, item := range routeNeedAdd {
×
425
                if item.BfdID != "" {
×
426
                        klog.Infof("vpc %s add static ecmp route: %+v", vpc.Name, item)
×
427
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
428
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, &item.BfdID, nil, item.NextHopIP,
×
429
                        ); err != nil {
×
430
                                klog.Errorf("failed to add bfd static route to vpc %s , %v", vpc.Name, err)
×
431
                                return err
×
432
                        }
×
433
                } else {
×
434
                        klog.Infof("vpc %s add static route: %+v", vpc.Name, item)
×
435
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
436
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, nil, nil, item.NextHopIP,
×
437
                        ); err != nil {
×
438
                                klog.Errorf("failed to add normal static route to vpc %s , %v", vpc.Name, err)
×
439
                                return err
×
440
                        }
×
441
                }
442
        }
443

444
        // handle policy route
445
        var (
×
446
                policyRouteExisted, policyRouteNeedDel, policyRouteNeedAdd []*kubeovnv1.PolicyRoute
×
447
                policyRouteLogical                                         []*ovnnb.LogicalRouterPolicy
×
448
                externalIDs                                                = map[string]string{"vendor": util.CniTypeName}
×
449
        )
×
450

×
451
        if vpc.Name == c.config.ClusterRouter {
×
452
                policyRouteExisted = reversePolicies(vpc.Annotations[util.VpcLastPolicies])
×
453
                // diff list
×
454
                policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithExisted(policyRouteExisted, vpc.Spec.PolicyRoutes)
×
455
        } else {
×
456
                if vpc.Spec.PolicyRoutes == nil {
×
457
                        // do not clean default vpc policy routes
×
458
                        if err = c.OVNNbClient.ClearLogicalRouterPolicy(vpc.Name); err != nil {
×
459
                                klog.Errorf("clean all vpc %s policy route failed, %v", vpc.Name, err)
×
460
                                return err
×
461
                        }
×
462
                } else {
×
463
                        policyRouteLogical, err = c.OVNNbClient.ListLogicalRouterPolicies(vpc.Name, -1, nil, true)
×
464
                        if err != nil {
×
465
                                klog.Errorf("failed to get vpc %s policy route list, %v", vpc.Name, err)
×
466
                                return err
×
467
                        }
×
468
                        // diff vpc policy route
469
                        policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithLogical(policyRouteLogical, vpc.Spec.PolicyRoutes)
×
470
                }
471
        }
472
        // delete policies non-exist
473
        for _, item := range policyRouteNeedDel {
×
474
                klog.Infof("delete policy route for router: %s, priority: %d, match %s", vpc.Name, item.Priority, item.Match)
×
475
                if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpc.Name, item.Priority, item.Match); err != nil {
×
476
                        klog.Errorf("del vpc %s policy route failed, %v", vpc.Name, err)
×
477
                        return err
×
478
                }
×
479
        }
480
        // add new policies
481
        for _, item := range policyRouteNeedAdd {
×
482
                klog.Infof("add policy route for router: %s, match %s, action %s, nexthop %s, externalID %v", c.config.ClusterRouter, item.Match, string(item.Action), item.NextHopIP, externalIDs)
×
483
                if err = c.OVNNbClient.AddLogicalRouterPolicy(vpc.Name, item.Priority, item.Match, string(item.Action), []string{item.NextHopIP}, nil, externalIDs); err != nil {
×
484
                        klog.Errorf("add policy route to vpc %s failed, %v", vpc.Name, err)
×
485
                        return err
×
486
                }
×
487
        }
488

489
        vpc.Status.Router = key
×
490
        vpc.Status.Standby = true
×
491
        vpc.Status.VpcPeerings = newPeers
×
492
        if c.config.EnableLb {
×
493
                vpcLb, err := c.addLoadBalancer(key)
×
494
                if err != nil {
×
495
                        klog.Error(err)
×
496
                        return err
×
497
                }
×
498
                vpc.Status.TCPLoadBalancer = vpcLb.TCPLoadBalancer
×
499
                vpc.Status.TCPSessionLoadBalancer = vpcLb.TCPSessLoadBalancer
×
500
                vpc.Status.UDPLoadBalancer = vpcLb.UDPLoadBalancer
×
501
                vpc.Status.UDPSessionLoadBalancer = vpcLb.UDPSessLoadBalancer
×
502
                vpc.Status.SctpLoadBalancer = vpcLb.SctpLoadBalancer
×
503
                vpc.Status.SctpSessionLoadBalancer = vpcLb.SctpSessLoadBalancer
×
504
        }
505
        bytes, err := vpc.Status.Bytes()
×
506
        if err != nil {
×
507
                klog.Error(err)
×
508
                return err
×
509
        }
×
510
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
511
        if err != nil {
×
512
                klog.Error(err)
×
513
                return err
×
514
        }
×
515

516
        if len(vpc.Annotations) != 0 && strings.ToLower(vpc.Annotations[util.VpcLbAnnotation]) == "on" {
×
517
                if err = c.createVpcLb(vpc); err != nil {
×
518
                        klog.Error(err)
×
519
                        return err
×
520
                }
×
521
        } else if err = c.deleteVpcLb(vpc); err != nil {
×
522
                klog.Error(err)
×
523
                return err
×
524
        }
×
525

526
        subnets, err := c.subnetsLister.List(labels.Everything())
×
527
        if err != nil {
×
528
                klog.Error(err)
×
529
                return err
×
530
        }
×
531
        custVpcEnableExternalMultiHopEcmp := false
×
532
        for _, subnet := range subnets {
×
533
                if subnet.Spec.Vpc == key {
×
534
                        c.addOrUpdateSubnetQueue.Add(subnet.Name)
×
535
                        if vpc.Name != util.DefaultVpc && vpc.Spec.EnableBfd && subnet.Spec.EnableEcmp {
×
536
                                custVpcEnableExternalMultiHopEcmp = true
×
537
                        }
×
538
                }
539
        }
540

541
        if vpc.Name != util.DefaultVpc {
×
542
                if cachedVpc.Spec.EnableExternal {
×
543
                        if !externalSubnetExist {
×
544
                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)
×
545
                                klog.Error(err)
×
546
                                return err
×
547
                        }
×
548
                        if externalSubnet.Spec.LogicalGateway {
×
549
                                klog.Infof("no need to handle external connection for logical gw external subnet %s", c.config.ExternalGatewaySwitch)
×
550
                                return nil
×
551
                        }
×
552
                        if !cachedVpc.Status.EnableExternal {
×
553
                                // connect vpc to default external
×
554
                                klog.Infof("connect external network with vpc %s", vpc.Name)
×
555
                                if err := c.handleAddVpcExternalSubnet(key, c.config.ExternalGatewaySwitch); err != nil {
×
556
                                        klog.Errorf("failed to add default external connection for vpc %s, error %v", key, err)
×
557
                                        return err
×
558
                                }
×
559
                        }
560
                        if vpc.Spec.EnableBfd {
×
561
                                // create bfd between lrp and physical switch gw
×
562
                                // bfd status down means current lrp binding chassis node external nic lost external network connectivity
×
563
                                // should switch lrp to another node
×
564
                                lrpEipName := fmt.Sprintf("%s-%s", key, c.config.ExternalGatewaySwitch)
×
565
                                v4ExtGw, _ := util.SplitStringIP(externalSubnet.Spec.Gateway)
×
566
                                // TODO: dualstack
×
567
                                if _, err := c.OVNNbClient.CreateBFD(lrpEipName, v4ExtGw, c.config.BfdMinRx, c.config.BfdMinTx, c.config.BfdDetectMult, nil); err != nil {
×
568
                                        klog.Error(err)
×
569
                                        return err
×
570
                                }
×
571
                                // TODO: support multi external nic
572
                                if custVpcEnableExternalMultiHopEcmp {
×
573
                                        klog.Infof("remove normal static ecmp route for vpc %s", vpc.Name)
×
574
                                        // auto remove normal type static route, if using ecmp based bfd
×
575
                                        if err := c.reconcileCustomVpcDelNormalStaticRoute(vpc.Name); err != nil {
×
576
                                                klog.Errorf("failed to reconcile del vpc %q normal static route", vpc.Name)
×
577
                                                return err
×
578
                                        }
×
579
                                }
580
                        }
581
                        if cachedVpc.Spec.ExtraExternalSubnets != nil {
×
582
                                sort.Strings(vpc.Spec.ExtraExternalSubnets)
×
583
                        }
×
584
                        // add external subnets only in spec and delete external subnets only in status
585
                        if !slices.Equal(vpc.Spec.ExtraExternalSubnets, vpc.Status.ExtraExternalSubnets) {
×
586
                                for _, subnetStatus := range cachedVpc.Status.ExtraExternalSubnets {
×
587
                                        if !slices.Contains(cachedVpc.Spec.ExtraExternalSubnets, subnetStatus) {
×
588
                                                klog.Infof("delete external subnet %s connection for vpc %s", subnetStatus, vpc.Name)
×
589
                                                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnetStatus); err != nil {
×
590
                                                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnetStatus, vpc.Name, err)
×
591
                                                        return err
×
592
                                                }
×
593
                                        }
594
                                }
595
                                for _, subnetSpec := range cachedVpc.Spec.ExtraExternalSubnets {
×
596
                                        if !slices.Contains(cachedVpc.Status.ExtraExternalSubnets, subnetSpec) {
×
597
                                                klog.Infof("connect external subnet %s with vpc %s", subnetSpec, vpc.Name)
×
598
                                                if err := c.handleAddVpcExternalSubnet(key, subnetSpec); err != nil {
×
599
                                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnetSpec, key, err)
×
600
                                                        return err
×
601
                                                }
×
602
                                        }
603
                                }
604
                                if err := c.updateVpcAddExternalStatus(key, true); err != nil {
×
605
                                        klog.Errorf("failed to update additional external subnets status, %v", err)
×
606
                                        return err
×
607
                                }
×
608
                        }
609
                }
610

611
                if !cachedVpc.Spec.EnableBfd && cachedVpc.Status.EnableBfd {
×
612
                        lrpEipName := fmt.Sprintf("%s-%s", key, c.config.ExternalGatewaySwitch)
×
613
                        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpEipName, ""); err != nil {
×
614
                                klog.Error(err)
×
615
                                return err
×
616
                        }
×
617
                        if err := c.handleDeleteVpcStaticRoute(key); err != nil {
×
618
                                klog.Errorf("failed to delete bfd route for vpc %s, error %v", key, err)
×
619
                                return err
×
620
                        }
×
621
                }
622

623
                if !cachedVpc.Spec.EnableExternal && cachedVpc.Status.EnableExternal {
×
624
                        // disconnect vpc to default external
×
625
                        if err := c.handleDelVpcExternalSubnet(key, c.config.ExternalGatewaySwitch); err != nil {
×
626
                                klog.Errorf("failed to delete external connection for vpc %s, error %v", key, err)
×
627
                                return err
×
628
                        }
×
629
                }
630

631
                if cachedVpc.Status.ExtraExternalSubnets != nil && !cachedVpc.Spec.EnableExternal {
×
632
                        // disconnect vpc to extra external subnets
×
633
                        for _, subnet := range cachedVpc.Status.ExtraExternalSubnets {
×
634
                                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)
×
635
                                if err := c.handleDelVpcExternalSubnet(key, subnet); err != nil {
×
636
                                        klog.Error(err)
×
637
                                        return err
×
638
                                }
×
639
                        }
640
                        if err := c.updateVpcAddExternalStatus(key, false); err != nil {
×
641
                                klog.Errorf("failed to update additional external subnets status, %v", err)
×
642
                                return err
×
643
                        }
×
644
                }
645
        }
646

647
        bfdPortName, bfdPortNodes, err := c.reconcileVpcBfdLRP(vpc)
×
648
        if err != nil {
×
649
                klog.Error(err)
×
650
                return err
×
651
        }
×
652
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
653
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{}
×
654
        } else {
×
655
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{
×
656
                        Name:  bfdPortName,
×
657
                        IP:    vpc.Spec.BFDPort.IP,
×
658
                        Nodes: bfdPortNodes,
×
659
                }
×
660
        }
×
661
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().
×
662
                UpdateStatus(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
663
                klog.Error(err)
×
664
                return err
×
665
        }
×
666

667
        return nil
×
668
}
669

670
func (c *Controller) reconcileVpcBfdLRP(vpc *kubeovnv1.Vpc) (string, []string, error) {
×
671
        portName := "bfd@" + vpc.Name
×
672
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
673
                if err := c.OVNNbClient.DeleteLogicalRouterPort(portName); err != nil {
×
674
                        err = fmt.Errorf("failed to delete BFD LRP %s: %w", portName, err)
×
675
                        klog.Error(err)
×
676
                        return portName, nil, err
×
677
                }
×
678
                if err := c.OVNNbClient.DeleteHAChassisGroup(portName); err != nil {
×
679
                        err = fmt.Errorf("failed to delete HA chassis group %s: %w", portName, err)
×
680
                        klog.Error(err)
×
681
                        return portName, nil, err
×
682
                }
×
683
                return portName, nil, nil
×
684
        }
685

686
        var err error
×
687
        chassisCount := 3
×
688
        selector := labels.Everything()
×
689
        if vpc.Spec.BFDPort.NodeSelector != nil {
×
690
                chassisCount = math.MaxInt
×
691
                if selector, err = metav1.LabelSelectorAsSelector(vpc.Spec.BFDPort.NodeSelector); err != nil {
×
692
                        err = fmt.Errorf("failed to parse node selector %q: %w", vpc.Spec.BFDPort.NodeSelector.String(), err)
×
693
                        klog.Error(err)
×
694
                        return portName, nil, err
×
695
                }
×
696
        }
697

698
        nodes, err := c.nodesLister.List(selector)
×
699
        if err != nil {
×
700
                err = fmt.Errorf("failed to list nodes with selector %q: %w", vpc.Spec.BFDPort.NodeSelector, err)
×
701
                klog.Error(err)
×
702
                return portName, nil, err
×
703
        }
×
704
        if len(nodes) == 0 {
×
705
                err = fmt.Errorf("no nodes found by selector %q", selector.String())
×
706
                klog.Error(err)
×
707
                return portName, nil, err
×
708
        }
×
709

710
        nodeNames := make([]string, 0, len(nodes))
×
711
        chassisCount = min(chassisCount, len(nodes))
×
712
        chassisNames := make([]string, 0, chassisCount)
×
713
        for _, nodes := range nodes[:chassisCount] {
×
714
                chassis, err := c.OVNSbClient.GetChassisByHost(nodes.Name)
×
715
                if err != nil {
×
716
                        err = fmt.Errorf("failed to get chassis of node %s: %w", nodes.Name, err)
×
717
                        klog.Error(err)
×
718
                        return portName, nil, err
×
719
                }
×
720
                chassisNames = append(chassisNames, chassis.Name)
×
721
                nodeNames = append(nodeNames, nodes.Name)
×
722
        }
723

724
        networks := strings.Split(vpc.Spec.BFDPort.IP, ",")
×
725
        if err = c.OVNNbClient.CreateLogicalRouterPort(vpc.Name, portName, "", networks); err != nil {
×
726
                klog.Error(err)
×
727
                return portName, nil, err
×
728
        }
×
729
        if err = c.OVNNbClient.UpdateLogicalRouterPortNetworks(portName, networks); err != nil {
×
730
                klog.Error(err)
×
731
                return portName, nil, err
×
732
        }
×
733
        if err = c.OVNNbClient.UpdateLogicalRouterPortOptions(portName, map[string]string{"bfd-only": "true"}); err != nil {
×
734
                klog.Error(err)
×
735
                return portName, nil, err
×
736
        }
×
737
        if err = c.OVNNbClient.CreateHAChassisGroup(portName, chassisNames, map[string]string{"lrp": portName}); err != nil {
×
738
                klog.Error(err)
×
739
                return portName, nil, err
×
740
        }
×
741
        if err = c.OVNNbClient.SetLogicalRouterPortHAChassisGroup(portName, portName); err != nil {
×
742
                klog.Error(err)
×
743
                return portName, nil, err
×
744
        }
×
745

746
        return portName, nodeNames, nil
×
747
}
748

749
func (c *Controller) addPolicyRouteToVpc(vpcName string, policy *kubeovnv1.PolicyRoute, externalIDs map[string]string) error {
×
750
        var (
×
751
                nextHops []string
×
752
                err      error
×
753
        )
×
754

×
755
        if policy.NextHopIP != "" {
×
756
                nextHops = strings.Split(policy.NextHopIP, ",")
×
757
        }
×
758

759
        if err = c.OVNNbClient.AddLogicalRouterPolicy(vpcName, policy.Priority, policy.Match, string(policy.Action), nextHops, nil, externalIDs); err != nil {
×
760
                klog.Errorf("add policy route to vpc %s failed, %v", vpcName, err)
×
761
                return err
×
762
        }
×
763
        return nil
×
764
}
765

NEW
766
func buildExternalIDsMapKey(match, action string, priority int) string {
×
NEW
767
        return fmt.Sprintf("%s-%s-%d", match, action, priority)
×
NEW
768
}
×
769

NEW
770
func (c *Controller) batchAddPolicyRouteToVpc(name string, policies []*kubeovnv1.PolicyRoute, externalIDs map[string]map[string]string) error {
×
NEW
771
        if len(policies) == 0 {
×
NEW
772
                return nil
×
NEW
773
        }
×
NEW
774
        start := time.Now()
×
NEW
775
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
NEW
776
        for _, policy := range policies {
×
NEW
777
                var nextHops []string
×
NEW
778
                if policy.NextHopIP != "" {
×
NEW
779
                        nextHops = strings.Split(policy.NextHopIP, ",")
×
NEW
780
                }
×
NEW
781
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
NEW
782
                        Priority:    policy.Priority,
×
NEW
783
                        Nexthops:    nextHops,
×
NEW
784
                        Action:      string(policy.Action),
×
NEW
785
                        Match:       policy.Match,
×
NEW
786
                        ExternalIDs: externalIDs[buildExternalIDsMapKey(policy.Match, string(policy.Action), policy.Priority)],
×
NEW
787
                })
×
788
        }
789

NEW
790
        if err := c.OVNNbClient.BatchAddLogicalRouterPolicy(name, routerPolicies...); err != nil {
×
NEW
791
                klog.Errorf("batch add policy route to vpc %s failed, %v", name, err)
×
NEW
792
                return err
×
NEW
793
        }
×
NEW
794
        klog.Infof("take to %v batch add policy route to vpc %s policies %d", time.Since(start), name, len(policies))
×
NEW
795
        return nil
×
796
}
797

798
func (c *Controller) deletePolicyRouteFromVpc(vpcName string, priority int, match string) error {
×
799
        var (
×
800
                vpc, cachedVpc *kubeovnv1.Vpc
×
801
                err            error
×
802
        )
×
803

×
804
        if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpcName, priority, match); err != nil {
×
805
                klog.Error(err)
×
806
                return err
×
807
        }
×
808

809
        cachedVpc, err = c.vpcsLister.Get(vpcName)
×
810
        if err != nil {
×
811
                if k8serrors.IsNotFound(err) {
×
812
                        return nil
×
813
                }
×
814
                klog.Error(err)
×
815
                return err
×
816
        }
817
        vpc = cachedVpc.DeepCopy()
×
818
        // make sure custom policies not be deleted
×
819
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
820
        if err != nil {
×
821
                klog.Error(err)
×
822
                return err
×
823
        }
×
824
        return nil
×
825
}
826

NEW
827
func (c *Controller) batchDeletePolicyRouteFromVpc(name string, policies []*kubeovnv1.PolicyRoute) error {
×
NEW
828
        var (
×
NEW
829
                vpc, cachedVpc *kubeovnv1.Vpc
×
NEW
830
                err            error
×
NEW
831
        )
×
NEW
832

×
NEW
833
        start := time.Now()
×
NEW
834
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
NEW
835
        for _, policy := range policies {
×
NEW
836
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
NEW
837
                        Priority: policy.Priority,
×
NEW
838
                        Match:    policy.Match,
×
NEW
839
                })
×
NEW
840
        }
×
841

NEW
842
        if err = c.OVNNbClient.BatchDeleteLogicalRouterPolicy(name, routerPolicies); err != nil {
×
NEW
843
                return err
×
NEW
844
        }
×
NEW
845
        klog.V(3).Infof("take to %v batch delete policy route from vpc %s policies %d", time.Since(start), name, len(policies))
×
NEW
846

×
NEW
847
        cachedVpc, err = c.vpcsLister.Get(name)
×
NEW
848
        if err != nil {
×
NEW
849
                if k8serrors.IsNotFound(err) {
×
NEW
850
                        return nil
×
NEW
851
                }
×
NEW
852
                klog.Error(err)
×
NEW
853
                return err
×
854
        }
NEW
855
        vpc = cachedVpc.DeepCopy()
×
NEW
856
        // make sure custom policies not be deleted
×
NEW
857
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
NEW
858
        if err != nil {
×
NEW
859
                klog.Error(err)
×
NEW
860
                return err
×
NEW
861
        }
×
NEW
862
        return nil
×
863
}
864

865
func (c *Controller) addStaticRouteToVpc(name string, route *kubeovnv1.StaticRoute) error {
×
866
        if route.BfdID != "" {
×
867
                klog.Infof("vpc %s add static ecmp route: %+v", name, route)
×
868
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
869
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, &route.BfdID, nil, route.NextHopIP,
×
870
                ); err != nil {
×
871
                        klog.Errorf("failed to add bfd static route to vpc %s , %v", name, err)
×
872
                        return err
×
873
                }
×
874
        } else {
×
875
                klog.Infof("vpc %s add static route: %+v", name, route)
×
876
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
877
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, nil, nil, route.NextHopIP,
×
878
                ); err != nil {
×
879
                        klog.Errorf("failed to add normal static route to vpc %s , %v", name, err)
×
880
                        return err
×
881
                }
×
882
        }
883
        return nil
×
884
}
885

886
func (c *Controller) deleteStaticRouteFromVpc(name, table, cidr, nextHop string, policy kubeovnv1.RoutePolicy) error {
×
887
        var (
×
888
                policyStr string
×
889
                err       error
×
890
        )
×
891

×
892
        policyStr = convertPolicy(policy)
×
893
        if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(name, &table, &policyStr, cidr, nextHop); err != nil {
×
894
                klog.Errorf("del vpc %s static route failed, %v", name, err)
×
895
                return err
×
896
        }
×
897

898
        return nil
×
899
}
900

NEW
901
func (c *Controller) batchDeleteStaticRouteFromVpc(name string, staticRoutes []*kubeovnv1.StaticRoute) error {
×
NEW
902
        var (
×
NEW
903
                vpc, cachedVpc *kubeovnv1.Vpc
×
NEW
904
                err            error
×
NEW
905
        )
×
NEW
906
        start := time.Now()
×
NEW
907
        routeCount := len(staticRoutes)
×
NEW
908
        delRoutes := make([]*ovnnb.LogicalRouterStaticRoute, 0, routeCount)
×
NEW
909
        for _, sr := range staticRoutes {
×
NEW
910
                policyStr := convertPolicy(sr.Policy)
×
NEW
911
                newRoute := &ovnnb.LogicalRouterStaticRoute{
×
NEW
912
                        RouteTable: sr.RouteTable,
×
NEW
913
                        Nexthop:    sr.NextHopIP,
×
NEW
914
                        Policy:     &policyStr,
×
NEW
915
                        IPPrefix:   sr.CIDR,
×
NEW
916
                }
×
NEW
917
                delRoutes = append(delRoutes, newRoute)
×
NEW
918
        }
×
NEW
919
        if err = c.OVNNbClient.BatchDeleteLogicalRouterStaticRoute(name, delRoutes); err != nil {
×
NEW
920
                klog.Errorf("batch del vpc %s static route %d failed, %v", name, routeCount, err)
×
NEW
921
                return err
×
NEW
922
        }
×
NEW
923
        klog.V(3).Infof("take to %v batch delete static route from vpc %s static routes %d", time.Since(start), name, len(delRoutes))
×
NEW
924

×
NEW
925
        cachedVpc, err = c.vpcsLister.Get(name)
×
NEW
926
        if err != nil {
×
NEW
927
                if k8serrors.IsNotFound(err) {
×
NEW
928
                        return nil
×
NEW
929
                }
×
NEW
930
                klog.Error(err)
×
NEW
931
                return err
×
932
        }
NEW
933
        vpc = cachedVpc.DeepCopy()
×
NEW
934
        // make sure custom policies not be deleted
×
NEW
935
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
NEW
936
        if err != nil {
×
NEW
937
                klog.Error(err)
×
NEW
938
                return err
×
NEW
939
        }
×
NEW
940
        return nil
×
941
}
942

943
func diffPolicyRouteWithExisted(exists, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
944
        var (
×
945
                dels, adds []*kubeovnv1.PolicyRoute
×
946
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
947
                key        string
×
948
                ok         bool
×
949
        )
×
950

×
951
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
952
        for _, item := range exists {
×
953
                existsMap[getPolicyRouteItemKey(item)] = item
×
954
        }
×
955
        // load policies to add
956
        for _, item := range target {
×
957
                key = getPolicyRouteItemKey(item)
×
958

×
959
                if _, ok = existsMap[key]; ok {
×
960
                        delete(existsMap, key)
×
961
                } else {
×
962
                        adds = append(adds, item)
×
963
                }
×
964
        }
965
        // load policies to delete
966
        for _, item := range existsMap {
×
967
                dels = append(dels, item)
×
968
        }
×
969
        return dels, adds
×
970
}
971

972
func diffPolicyRouteWithLogical(exists []*ovnnb.LogicalRouterPolicy, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
973
        var (
×
974
                dels, adds []*kubeovnv1.PolicyRoute
×
975
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
976
                key        string
×
977
                ok         bool
×
978
        )
×
979
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
980

×
981
        for _, item := range exists {
×
982
                policy := &kubeovnv1.PolicyRoute{
×
983
                        Priority: item.Priority,
×
984
                        Match:    item.Match,
×
985
                        Action:   kubeovnv1.PolicyRouteAction(item.Action),
×
986
                }
×
987
                existsMap[getPolicyRouteItemKey(policy)] = policy
×
988
        }
×
989

990
        for _, item := range target {
×
991
                key = getPolicyRouteItemKey(item)
×
992

×
993
                if _, ok = existsMap[key]; ok {
×
994
                        delete(existsMap, key)
×
995
                } else {
×
996
                        adds = append(adds, item)
×
997
                }
×
998
        }
999

1000
        for _, item := range existsMap {
×
1001
                dels = append(dels, item)
×
1002
        }
×
1003
        return dels, adds
×
1004
}
1005

1006
func getPolicyRouteItemKey(item *kubeovnv1.PolicyRoute) (key string) {
×
1007
        return fmt.Sprintf("%d:%s:%s:%s", item.Priority, item.Match, item.Action, item.NextHopIP)
×
1008
}
×
1009

1010
func diffStaticRoute(exist []*ovnnb.LogicalRouterStaticRoute, target []*kubeovnv1.StaticRoute) (routeNeedDel, routeNeedAdd []*kubeovnv1.StaticRoute, err error) {
×
1011
        existRouteMap := make(map[string]*kubeovnv1.StaticRoute, len(exist))
×
1012
        for _, item := range exist {
×
1013
                policy := kubeovnv1.PolicyDst
×
1014
                if item.Policy != nil && *item.Policy == ovnnb.LogicalRouterStaticRoutePolicySrcIP {
×
1015
                        policy = kubeovnv1.PolicySrc
×
1016
                }
×
1017
                route := &kubeovnv1.StaticRoute{
×
1018
                        Policy:     policy,
×
1019
                        CIDR:       item.IPPrefix,
×
1020
                        NextHopIP:  item.Nexthop,
×
1021
                        RouteTable: item.RouteTable,
×
1022
                        ECMPMode:   util.StaticRouteBfdEcmp,
×
1023
                }
×
1024
                if item.BFD != nil {
×
1025
                        route.BfdID = *item.BFD
×
1026
                }
×
1027
                existRouteMap[getStaticRouteItemKey(route)] = route
×
1028
        }
1029

1030
        for _, item := range target {
×
1031
                key := getStaticRouteItemKey(item)
×
1032
                if _, ok := existRouteMap[key]; ok {
×
1033
                        delete(existRouteMap, key)
×
1034
                } else {
×
1035
                        routeNeedAdd = append(routeNeedAdd, item)
×
1036
                }
×
1037
        }
1038
        for _, item := range existRouteMap {
×
1039
                routeNeedDel = append(routeNeedDel, item)
×
1040
        }
×
1041
        return
×
1042
}
1043

1044
func getStaticRouteItemKey(item *kubeovnv1.StaticRoute) string {
×
1045
        var key string
×
1046
        if item.Policy == kubeovnv1.PolicyDst {
×
1047
                key = fmt.Sprintf("%s:dst:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1048
        } else {
×
1049
                key = fmt.Sprintf("%s:src:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1050
        }
×
1051
        return key
×
1052
}
1053

1054
func (c *Controller) formatVpc(vpc *kubeovnv1.Vpc) (*kubeovnv1.Vpc, error) {
×
1055
        var changed bool
×
1056
        for _, item := range vpc.Spec.StaticRoutes {
×
1057
                // check policy
×
1058
                if item.Policy == "" {
×
1059
                        item.Policy = kubeovnv1.PolicyDst
×
1060
                        changed = true
×
1061
                }
×
1062
                if item.Policy != kubeovnv1.PolicyDst && item.Policy != kubeovnv1.PolicySrc {
×
1063
                        return nil, fmt.Errorf("unknown policy type: %q", item.Policy)
×
1064
                }
×
1065
                // check cidr
1066
                if strings.Contains(item.CIDR, "/") {
×
1067
                        if _, _, err := net.ParseCIDR(item.CIDR); err != nil {
×
1068
                                return nil, fmt.Errorf("invalid cidr %q: %w", item.CIDR, err)
×
1069
                        }
×
1070
                } else if ip := net.ParseIP(item.CIDR); ip == nil {
×
1071
                        return nil, fmt.Errorf("invalid ip %q", item.CIDR)
×
1072
                }
×
1073
                // check next hop ip
1074
                if ip := net.ParseIP(item.NextHopIP); ip == nil {
×
1075
                        return nil, fmt.Errorf("invalid next hop ip %q", item.NextHopIP)
×
1076
                }
×
1077
        }
1078

1079
        for _, route := range vpc.Spec.PolicyRoutes {
×
1080
                if route.Action != kubeovnv1.PolicyRouteActionReroute {
×
1081
                        if route.NextHopIP != "" {
×
1082
                                route.NextHopIP = ""
×
1083
                                changed = true
×
1084
                        }
×
1085
                } else {
×
1086
                        // ecmp policy route may reroute to multiple next hop ips
×
1087
                        for _, ipStr := range strings.Split(route.NextHopIP, ",") {
×
1088
                                if ip := net.ParseIP(ipStr); ip == nil {
×
1089
                                        err := fmt.Errorf("invalid next hop ips: %s", route.NextHopIP)
×
1090
                                        klog.Error(err)
×
1091
                                        return nil, err
×
1092
                                }
×
1093
                        }
1094
                }
1095
        }
1096

1097
        if changed {
×
1098
                newVpc, err := c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
1099
                if err != nil {
×
1100
                        klog.Errorf("failed to update vpc %s: %v", vpc.Name, err)
×
1101
                        return nil, err
×
1102
                }
×
1103
                return newVpc, nil
×
1104
        }
1105

1106
        return vpc, nil
×
1107
}
1108

1109
func convertPolicies(list []*kubeovnv1.PolicyRoute) string {
×
1110
        if list == nil {
×
1111
                return ""
×
1112
        }
×
1113

1114
        var (
×
1115
                res []byte
×
1116
                err error
×
1117
        )
×
1118

×
1119
        if res, err = json.Marshal(list); err != nil {
×
1120
                klog.Errorf("failed to serialize policy routes %v , reason : %v", list, err)
×
1121
                return ""
×
1122
        }
×
1123
        return string(res)
×
1124
}
1125

1126
func reversePolicies(origin string) []*kubeovnv1.PolicyRoute {
×
1127
        if origin == "" {
×
1128
                return nil
×
1129
        }
×
1130

1131
        var (
×
1132
                list []*kubeovnv1.PolicyRoute
×
1133
                err  error
×
1134
        )
×
1135

×
1136
        if err = json.Unmarshal([]byte(origin), &list); err != nil {
×
1137
                klog.Errorf("failed to deserialize policy routes %v , reason : %v", list, err)
×
1138
                return nil
×
1139
        }
×
1140
        return list
×
1141
}
1142

1143
func convertPolicy(origin kubeovnv1.RoutePolicy) string {
×
1144
        if origin == kubeovnv1.PolicyDst {
×
1145
                return ovnnb.LogicalRouterStaticRoutePolicyDstIP
×
1146
        }
×
1147
        return ovnnb.LogicalRouterStaticRoutePolicySrcIP
×
1148
}
1149

1150
func reversePolicy(origin ovnnb.LogicalRouterStaticRoutePolicy) kubeovnv1.RoutePolicy {
×
1151
        if origin == ovnnb.LogicalRouterStaticRoutePolicyDstIP {
×
1152
                return kubeovnv1.PolicyDst
×
1153
        }
×
1154
        return kubeovnv1.PolicySrc
×
1155
}
1156

1157
func (c *Controller) getVpcSubnets(vpc *kubeovnv1.Vpc) (subnets []string, defaultSubnet string, err error) {
×
1158
        subnets = []string{}
×
1159
        allSubnets, err := c.subnetsLister.List(labels.Everything())
×
1160
        if err != nil {
×
1161
                klog.Error(err)
×
1162
                return nil, "", err
×
1163
        }
×
1164

1165
        for _, subnet := range allSubnets {
×
1166
                if subnet.Spec.Vpc != vpc.Name || !subnet.DeletionTimestamp.IsZero() || !isOvnSubnet(subnet) {
×
1167
                        continue
×
1168
                }
1169

1170
                subnets = append(subnets, subnet.Name)
×
1171
                if subnet.Spec.Default {
×
1172
                        defaultSubnet = subnet.Name
×
1173
                }
×
1174

1175
                if vpc.Name != util.DefaultVpc && vpc.Spec.DefaultSubnet != "" && vpc.Spec.DefaultSubnet == subnet.Name {
×
1176
                        defaultSubnet = vpc.Spec.DefaultSubnet
×
1177
                }
×
1178
        }
1179
        return
×
1180
}
1181

1182
// createVpcRouter create router to connect logical switches in vpc
1183
func (c *Controller) createVpcRouter(lr string) error {
×
1184
        if err := c.OVNNbClient.CreateLogicalRouter(lr); err != nil {
×
1185
                klog.Errorf("create logical router %s failed: %v", lr, err)
×
1186
                return err
×
1187
        }
×
1188

1189
        vpcRouter, err := c.OVNNbClient.GetLogicalRouter(lr, false)
×
1190
        if err != nil {
×
1191
                klog.Errorf("get logical router %s failed: %v", lr, err)
×
1192
                return err
×
1193
        }
×
1194

1195
        vpcRouter.Options = map[string]string{"always_learn_from_arp_request": "false", "dynamic_neigh_routers": "true", "mac_binding_age_threshold": "300"}
×
1196
        err = c.OVNNbClient.UpdateLogicalRouter(vpcRouter, &vpcRouter.Options)
×
1197
        if err != nil {
×
1198
                klog.Errorf("update logical router %s failed: %v", lr, err)
×
1199
                return err
×
1200
        }
×
1201
        return nil
×
1202
}
1203

1204
// deleteVpcRouter delete router to connect logical switches in vpc
1205
func (c *Controller) deleteVpcRouter(lr string) error {
×
1206
        return c.OVNNbClient.DeleteLogicalRouter(lr)
×
1207
}
×
1208

1209
func (c *Controller) handleAddVpcExternalSubnet(key, subnet string) error {
×
1210
        cachedSubnet, err := c.subnetsLister.Get(subnet)
×
1211
        if err != nil {
×
1212
                klog.Error(err)
×
1213
                return err
×
1214
        }
×
1215
        lrpEipName := fmt.Sprintf("%s-%s", key, subnet)
×
1216
        cachedEip, err := c.ovnEipsLister.Get(lrpEipName)
×
1217
        var needCreateEip bool
×
1218
        if err != nil {
×
1219
                if !k8serrors.IsNotFound(err) {
×
1220
                        klog.Error(err)
×
1221
                        return err
×
1222
                }
×
1223
                needCreateEip = true
×
1224
        }
1225
        var v4ip, v6ip, mac string
×
1226
        klog.V(3).Infof("create vpc lrp eip %s", lrpEipName)
×
1227
        if needCreateEip {
×
1228
                if v4ip, v6ip, mac, err = c.acquireIPAddress(subnet, lrpEipName, lrpEipName); err != nil {
×
1229
                        klog.Errorf("failed to acquire ip address for lrp eip %s, %v", lrpEipName, err)
×
1230
                        return err
×
1231
                }
×
1232
                if err := c.createOrUpdateOvnEipCR(lrpEipName, subnet, v4ip, v6ip, mac, util.OvnEipTypeLRP); err != nil {
×
1233
                        klog.Errorf("failed to create ovn eip for lrp %s: %v", lrpEipName, err)
×
1234
                        return err
×
1235
                }
×
1236
        } else {
×
1237
                v4ip = cachedEip.Spec.V4Ip
×
1238
                mac = cachedEip.Spec.MacAddress
×
1239
        }
×
1240
        if v4ip == "" || mac == "" {
×
1241
                err := fmt.Errorf("lrp '%s' ip or mac should not be empty", lrpEipName)
×
1242
                klog.Error(err)
×
1243
                return err
×
1244
        }
×
1245
        // init lrp gw chassis group
1246
        chassises := []string{}
×
1247
        sel, _ := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{MatchLabels: map[string]string{util.ExGatewayLabel: "true"}})
×
1248
        gwNodes, err := c.nodesLister.List(sel)
×
1249
        if err != nil {
×
1250
                klog.Errorf("failed to list external gw nodes, %v", err)
×
1251
                return err
×
1252
        }
×
1253
        for _, gwNode := range gwNodes {
×
1254
                annoChassisName := gwNode.Annotations[util.ChassisAnnotation]
×
1255
                if annoChassisName == "" {
×
1256
                        err := fmt.Errorf("node %s has no chassis annotation, kube-ovn-cni not ready", gwNode.Name)
×
1257
                        klog.Error(err)
×
1258
                        return err
×
1259
                }
×
1260
                klog.Infof("get node %s chassis: %s", gwNode.Name, annoChassisName)
×
1261
                chassis, err := c.OVNSbClient.GetChassis(annoChassisName, false)
×
1262
                if err != nil {
×
1263
                        klog.Errorf("failed to get node %s chassis: %s, %v", gwNode.Name, annoChassisName, err)
×
1264
                        return err
×
1265
                }
×
1266
                chassises = append(chassises, chassis.Name)
×
1267
        }
1268

1269
        if len(chassises) == 0 {
×
1270
                err := errors.New("no external gw nodes")
×
1271
                klog.Error(err)
×
1272
                return err
×
1273
        }
×
1274

1275
        v4ipCidr, err := util.GetIPAddrWithMask(v4ip, cachedSubnet.Spec.CIDRBlock)
×
1276
        if err != nil {
×
1277
                klog.Error(err)
×
1278
                return err
×
1279
        }
×
1280
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1281
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1282

×
1283
        if err := c.OVNNbClient.CreateLogicalPatchPort(subnet, key, lspName, lrpName, v4ipCidr, mac, chassises...); err != nil {
×
1284
                klog.Errorf("failed to connect router '%s' to external: %v", key, err)
×
1285
                return err
×
1286
        }
×
1287

1288
        cachedVpc, err := c.vpcsLister.Get(key)
×
1289
        if err != nil {
×
1290
                if k8serrors.IsNotFound(err) {
×
1291
                        return nil
×
1292
                }
×
1293
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1294
                return err
×
1295
        }
1296
        if subnet == c.config.ExternalGatewaySwitch {
×
1297
                vpc := cachedVpc.DeepCopy()
×
1298
                vpc.Status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1299
                bytes, err := vpc.Status.Bytes()
×
1300
                if err != nil {
×
1301
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1302
                        return err
×
1303
                }
×
1304
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1305
                        vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1306
                        err := fmt.Errorf("failed to patch vpc %s status, %w", vpc.Name, err)
×
1307
                        klog.Error(err)
×
1308
                        return err
×
1309
                }
×
1310
        }
1311
        if _, err = c.ovnEipsLister.Get(lrpEipName); err != nil {
×
1312
                err := fmt.Errorf("failed to get ovn eip %s, %w", lrpEipName, err)
×
1313
                klog.Error(err)
×
1314
                return err
×
1315
        }
×
1316
        return nil
×
1317
}
1318

1319
func (c *Controller) handleDeleteVpcStaticRoute(key string) error {
×
1320
        vpc, err := c.vpcsLister.Get(key)
×
1321
        if err != nil {
×
1322
                if k8serrors.IsNotFound(err) {
×
1323
                        return nil
×
1324
                }
×
1325
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1326
                return err
×
1327
        }
1328
        needUpdate := false
×
1329
        newStaticRoutes := make([]*kubeovnv1.StaticRoute, 0, len(vpc.Spec.StaticRoutes))
×
1330
        for _, route := range vpc.Spec.StaticRoutes {
×
1331
                if route.ECMPMode != util.StaticRouteBfdEcmp {
×
1332
                        newStaticRoutes = append(newStaticRoutes, route)
×
1333
                        needUpdate = true
×
1334
                }
×
1335
        }
1336
        // keep non ecmp bfd routes
1337
        vpc.Spec.StaticRoutes = newStaticRoutes
×
1338
        if needUpdate {
×
1339
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
1340
                        klog.Errorf("failed to update vpc spec static route %s, %v", vpc.Name, err)
×
1341
                        return err
×
1342
                }
×
1343
        }
1344
        if err = c.patchVpcBfdStatus(vpc.Name); err != nil {
×
1345
                klog.Errorf("failed to patch vpc %s, %v", vpc.Name, err)
×
1346
                return err
×
1347
        }
×
1348
        return nil
×
1349
}
1350

1351
func (c *Controller) handleDelVpcExternalSubnet(key, subnet string) error {
×
1352
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1353
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1354
        klog.V(3).Infof("delete vpc lrp %s", lrpName)
×
1355
        if err := c.OVNNbClient.RemoveLogicalPatchPort(lspName, lrpName); err != nil {
×
1356
                klog.Errorf("failed to disconnect router '%s' to external, %v", key, err)
×
1357
                return err
×
1358
        }
×
1359

1360
        if err := c.config.KubeOvnClient.KubeovnV1().OvnEips().Delete(context.Background(), lrpName, metav1.DeleteOptions{}); err != nil {
×
1361
                if !k8serrors.IsNotFound(err) {
×
1362
                        klog.Errorf("failed to delete ovn eip %s, %v", lrpName, err)
×
1363
                        return err
×
1364
                }
×
1365
        }
1366
        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpName, ""); err != nil {
×
1367
                klog.Error(err)
×
1368
                return err
×
1369
        }
×
1370
        cachedVpc, err := c.vpcsLister.Get(key)
×
1371
        if err != nil {
×
1372
                if k8serrors.IsNotFound(err) {
×
1373
                        return nil
×
1374
                }
×
1375
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1376
                return err
×
1377
        }
1378
        if subnet == c.config.ExternalGatewaySwitch {
×
1379
                vpc := cachedVpc.DeepCopy()
×
1380
                vpc.Status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1381
                vpc.Status.EnableBfd = cachedVpc.Spec.EnableBfd
×
1382
                bytes, err := vpc.Status.Bytes()
×
1383
                if err != nil {
×
1384
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1385
                        return err
×
1386
                }
×
1387
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1388
                        vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1389
                        if k8serrors.IsNotFound(err) {
×
1390
                                return nil
×
1391
                        }
×
1392
                        klog.Errorf("failed to patch vpc %s, %v", key, err)
×
1393
                        return err
×
1394
                }
1395
        }
1396
        return nil
×
1397
}
1398

1399
func (c *Controller) patchVpcBfdStatus(key string) error {
×
1400
        cachedVpc, err := c.vpcsLister.Get(key)
×
1401
        if err != nil {
×
1402
                if k8serrors.IsNotFound(err) {
×
1403
                        return nil
×
1404
                }
×
1405
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1406
                return err
×
1407
        }
1408

1409
        if cachedVpc.Status.EnableBfd != cachedVpc.Spec.EnableBfd {
×
1410
                status := cachedVpc.Status.DeepCopy()
×
1411
                status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1412
                status.EnableBfd = cachedVpc.Spec.EnableBfd
×
1413
                bytes, err := status.Bytes()
×
1414
                if err != nil {
×
1415
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1416
                        return err
×
1417
                }
×
1418
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1419
                        cachedVpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1420
                        klog.Error(err)
×
1421
                        return err
×
1422
                }
×
1423
        }
1424
        return nil
×
1425
}
1426

1427
func (c *Controller) getRouteTablesByVpc(vpc *kubeovnv1.Vpc) map[string][]*kubeovnv1.StaticRoute {
×
1428
        rtbs := make(map[string][]*kubeovnv1.StaticRoute)
×
1429
        for _, route := range vpc.Spec.StaticRoutes {
×
1430
                rtbs[route.RouteTable] = append(rtbs[route.RouteTable], route)
×
1431
        }
×
1432
        return rtbs
×
1433
}
1434

1435
func (c *Controller) updateVpcAddExternalStatus(key string, addExternalStatus bool) error {
×
1436
        cachedVpc, err := c.vpcsLister.Get(key)
×
1437
        if err != nil {
×
1438
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1439
                return err
×
1440
        }
×
1441
        vpc := cachedVpc.DeepCopy()
×
1442
        if addExternalStatus && vpc.Spec.ExtraExternalSubnets != nil {
×
1443
                sort.Strings(vpc.Spec.ExtraExternalSubnets)
×
1444
                vpc.Status.ExtraExternalSubnets = vpc.Spec.ExtraExternalSubnets
×
1445
        } else {
×
1446
                vpc.Status.ExtraExternalSubnets = nil
×
1447
        }
×
1448
        bytes, err := vpc.Status.Bytes()
×
1449
        if err != nil {
×
1450
                klog.Errorf("failed to get vpc bytes, %v", err)
×
1451
                return err
×
1452
        }
×
1453
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1454
                vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1455
                klog.Errorf("failed to patch vpc %s, %v", key, err)
×
1456
                return err
×
1457
        }
×
1458

1459
        return nil
×
1460
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc