12777046822

Committed 14 Jan 2025 09:44PM UTC coverage: 71.801%. First build

Build # 12777046822

Build Type

Pull #376

github

Committed by

balanza

Commit Message

handle context cancellation

Pull Request Pull Request #376: Handle context cancellation in `corosync-cmapctl` gatherer

Run Details

26 of 46 new or added lines in 3 files covered. (56.52%)

4074 of 5674 relevant lines covered (71.8%)

20.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/pkg/utils/commandexecutor.go

package utils

import (
        "context"
        "os/exec"
        "syscall"

        log "github.com/sirupsen/logrus"
)

//go:generate mockery --name=CommandExecutor

type CommandExecutor interface {
        Exec(name string, arg ...string) ([]byte, error)
        ExecContext(ctx context.Context, name string, arg ...string) ([]byte, error)
}

type Executor struct{}

func (e Executor) Exec(name string, arg ...string) ([]byte, error) {
        cmd := exec.Command(name, arg...)

        return cmd.Output()
}

func (e Executor) ExecContext(ctx context.Context, name string, arg ...string) ([]byte, error) {
        cmd := exec.Command(name, arg...)
        cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}

        go func() {
                <-ctx.Done()
                err := syscall.Kill(-cmd.Process.Pid, syscall.SIGKILL)
                if err != nil {
                        log.Errorf("Error killing process group: %v", err)
                }
        }()

        return cmd.Output()
}

1	package utils
2
3	import (
4	"context"
5	"os/exec"
6	"syscall"
7
8	log "github.com/sirupsen/logrus"
9	)
10
11	//go:generate mockery --name=CommandExecutor
12
13	type CommandExecutor interface {
14	Exec(name string, arg ...string) ([]byte, error)
15	ExecContext(ctx context.Context, name string, arg ...string) ([]byte, error)
16	}
17
18	type Executor struct{}
19
20	func (e Executor) Exec(name string, arg ...string) ([]byte, error) {	×
21	cmd := exec.Command(name, arg...)	×
NEW 22		×
NEW 23	return cmd.Output()	×
NEW 24	}	×
25
NEW 26	func (e Executor) ExecContext(ctx context.Context, name string, arg ...string) ([]byte, error) {	×
NEW 27	cmd := exec.Command(name, arg...)	×
NEW 28	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}	×
NEW 29		×
NEW 30	go func() {	×
NEW 31	<-ctx.Done()	×
NEW 32	err := syscall.Kill(-cmd.Process.Pid, syscall.SIGKILL)	×
NEW 33	if err != nil {	×
NEW 34	log.Errorf("Error killing process group: %v", err)	×
NEW 35	}	×
36	}()
37
38	return cmd.Output()	×
39	}

trento-project / agent / 12777046822

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous