pyiron / pyiron_workflow / 12601836875

Build # 12601836875

Build Type

push

github

Committed by web-flow

Commit Message

Draft: Ruff (#520)

* add ruff linter/formatter to CI

* show diff

* enable common ruff rules

* exclude some files from formatting

* sort imports

* apply ruff auto-fixes

* apply unsafe fixes -- NEEDS REVIEW!

* ignore line-length violations as they are covered by the formatter

* reset _version and add it to excludes

* fix logger reimport

* fix over-eager optimizations in tests

* format fixes

* some custom fixes

* deactivate F401 for main include

* Get rid of creator and wrapper caches

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* De-abstract HasCreator

* Remove unused import

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Ignore unused imports in init files\n\nwe specify APIs this way

* Remove ABC

I personally like to use it as an indicator to devs that there's no intention of actually instantiating this class itself, but ruff insists that they are _only_ for specifying interfaces, and without and abstractmethod this doesn't make the cut. I acquiesce.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Don't use lru_cache

The operation is simple enough that the savings must have been minimal, and this is not used repeatedly (only when parsing class definitions to start with, e.g. at initial import), so any minor cost is going to be tolerable anyhow.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Use a more descriptive variable

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Use more descriptive variables

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Use more specific settings field

Per ruff deprecation warning

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>

* Keep the Workflow import separate

It was placed intentionally separate from the other imports to distinguish the pyironic single-import user interface from the more standard user/dev public API imports.... (continued)

Run Details

3070 of 3355 relevant lines covered (91.51%)

0.92 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available