• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3571

31 Dec 2024 08:57AM UTC coverage: 63.276% (+0.3%) from 62.94%
#3571

push

travis-ci

web-flow
Merge pull request #29434 from taosdata/enh/3.0/TD-33266-2

Fix(cover):fix some review errors in pr 29417.

140094 of 284342 branches covered (49.27%)

Branch coverage included in aggregate %.

217978 of 281543 relevant lines covered (77.42%)

20036556.91 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

67.43
/source/dnode/vnode/src/meta/metaEntry.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "meta.h"
17

18
int meteEncodeColCmprEntry(SEncoder *pCoder, const SMetaEntry *pME) {
506,606✔
19
  const SColCmprWrapper *pw = &pME->colCmpr;
506,606✔
20
  TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pw->nCols));
1,013,212!
21
  TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pw->version));
1,013,212!
22
  uDebug("encode cols:%d", pw->nCols);
506,606✔
23

24
  for (int32_t i = 0; i < pw->nCols; i++) {
5,083,876✔
25
    SColCmpr *p = &pw->pColCmpr[i];
4,577,349✔
26
    TAOS_CHECK_RETURN(tEncodeI16v(pCoder, p->id));
9,154,698!
27
    TAOS_CHECK_RETURN(tEncodeU32(pCoder, p->alg));
9,154,698!
28
  }
29
  return 0;
506,527✔
30
}
31
int meteDecodeColCmprEntry(SDecoder *pDecoder, SMetaEntry *pME) {
21,864,881✔
32
  SColCmprWrapper *pWrapper = &pME->colCmpr;
21,864,881✔
33
  TAOS_CHECK_RETURN(tDecodeI32v(pDecoder, &pWrapper->nCols));
43,612,641!
34
  if (pWrapper->nCols == 0) {
21,747,760!
35
    return 0;
×
36
  }
37

38
  TAOS_CHECK_RETURN(tDecodeI32v(pDecoder, &pWrapper->version));
43,470,068!
39
  uDebug("dencode cols:%d", pWrapper->nCols);
21,722,308✔
40
  pWrapper->pColCmpr = (SColCmpr *)tDecoderMalloc(pDecoder, pWrapper->nCols * sizeof(SColCmpr));
21,722,394✔
41
  if (pWrapper->pColCmpr == NULL) {
21,897,840!
42
    return terrno;
×
43
  }
44

45
  for (int i = 0; i < pWrapper->nCols; i++) {
454,163,739✔
46
    SColCmpr *p = &pWrapper->pColCmpr[i];
433,594,640✔
47
    TAOS_CHECK_RETURN(tDecodeI16v(pDecoder, &p->id));
863,581,116!
48
    TAOS_CHECK_RETURN(tDecodeU32(pDecoder, &p->alg));
862,252,375!
49
  }
50
  return 0;
20,569,099✔
51
}
52
static FORCE_INLINE int32_t metatInitDefaultSColCmprWrapper(SDecoder *pDecoder, SColCmprWrapper *pCmpr,
53
                                                            SSchemaWrapper *pSchema) {
54
  pCmpr->nCols = pSchema->nCols;
×
55
  if ((pCmpr->pColCmpr = (SColCmpr *)tDecoderMalloc(pDecoder, pCmpr->nCols * sizeof(SColCmpr))) == NULL) {
24!
56
    return terrno;
×
57
  }
58

59
  for (int32_t i = 0; i < pCmpr->nCols; i++) {
255!
60
    SColCmpr *pColCmpr = &pCmpr->pColCmpr[i];
231✔
61
    SSchema  *pColSchema = &pSchema->pSchema[i];
231✔
62
    pColCmpr->id = pColSchema->colId;
231✔
63
    pColCmpr->alg = createDefaultColCmprByType(pColSchema->type);
231✔
64
  }
65
  return 0;
24✔
66
}
67

68
static int32_t metaCloneColCmpr(const SColCmprWrapper *pSrc, SColCmprWrapper *pDst) {
241,667✔
69
  if (pSrc->nCols > 0) {
241,667✔
70
    pDst->nCols = pSrc->nCols;
231,037✔
71
    pDst->version = pSrc->version;
231,037✔
72
    pDst->pColCmpr = (SColCmpr *)taosMemoryCalloc(pSrc->nCols, sizeof(SColCmpr));
231,037!
73
    if (NULL == pDst->pColCmpr) {
231,085!
74
      return terrno;
×
75
    }
76
    memcpy(pDst->pColCmpr, pSrc->pColCmpr, pSrc->nCols * sizeof(SColCmpr));
231,085✔
77
  }
78
  return 0;
241,715✔
79
}
80

81
static void metaCloneColCmprFree(SColCmprWrapper *pCmpr) {
241,703✔
82
  if (pCmpr) {
241,703!
83
    taosMemoryFreeClear(pCmpr->pColCmpr);
241,717!
84
  }
85
}
241,729✔
86

87
int metaEncodeEntry(SEncoder *pCoder, const SMetaEntry *pME) {
515,876✔
88
  TAOS_CHECK_RETURN(tStartEncode(pCoder));
515,876✔
89
  TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->version));
1,033,480!
90
  TAOS_CHECK_RETURN(tEncodeI8(pCoder, pME->type));
1,033,480!
91
  TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->uid));
1,033,480!
92

93
  if (pME->type > 0) {
516,740✔
94
    if (pME->name == NULL) {
506,971!
95
      return TSDB_CODE_INVALID_PARA;
×
96
    }
97

98
    TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->name));
1,013,942!
99

100
    if (pME->type == TSDB_SUPER_TABLE) {
506,971✔
101
      TAOS_CHECK_RETURN(tEncodeI8(pCoder, pME->flags));
156,924!
102
      TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->stbEntry.schemaRow));
156,924!
103
      TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->stbEntry.schemaTag));
156,924!
104
      if (TABLE_IS_ROLLUP(pME->flags)) {
78,462✔
105
        TAOS_CHECK_RETURN(tEncodeSRSmaParam(pCoder, &pME->stbEntry.rsmaParam));
13!
106
      }
107
    } else if (pME->type == TSDB_CHILD_TABLE) {
428,509✔
108
      TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ctbEntry.btime));
797,876!
109
      TAOS_CHECK_RETURN(tEncodeI32(pCoder, pME->ctbEntry.ttlDays));
797,876!
110
      TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ctbEntry.commentLen));
797,876!
111
      if (pME->ctbEntry.commentLen > 0) {
398,938✔
112
        TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->ctbEntry.comment));
140!
113
      }
114
      TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ctbEntry.suid));
797,876!
115
      TAOS_CHECK_RETURN(tEncodeTag(pCoder, (const STag *)pME->ctbEntry.pTags));
398,938!
116
    } else if (pME->type == TSDB_NORMAL_TABLE) {
29,571✔
117
      TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ntbEntry.btime));
58,780!
118
      TAOS_CHECK_RETURN(tEncodeI32(pCoder, pME->ntbEntry.ttlDays));
58,780!
119
      TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ntbEntry.commentLen));
58,780!
120
      if (pME->ntbEntry.commentLen > 0) {
29,390✔
121
        TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->ntbEntry.comment));
140!
122
      }
123
      TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ntbEntry.ncid));
58,780!
124
      TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->ntbEntry.schemaRow));
58,780!
125
    } else if (pME->type == TSDB_TSMA_TABLE) {
181✔
126
      TAOS_CHECK_RETURN(tEncodeTSma(pCoder, pME->smaEntry.tsma));
62!
127
    } else {
128
      metaError("meta/entry: invalide table type: %" PRId8 " encode failed.", pME->type);
119!
129
      return TSDB_CODE_INVALID_PARA;
×
130
    }
131
    TAOS_CHECK_RETURN(meteEncodeColCmprEntry(pCoder, pME));
506,845!
132
  }
133

134
  tEndEncode(pCoder);
516,335✔
135
  return 0;
516,440✔
136
}
137

138
int metaDecodeEntry(SDecoder *pCoder, SMetaEntry *pME) {
31,449,014✔
139
  TAOS_CHECK_RETURN(tStartDecode(pCoder));
31,449,014!
140
  TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->version));
62,730,260!
141
  TAOS_CHECK_RETURN(tDecodeI8(pCoder, &pME->type));
62,213,768!
142
  TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->uid));
61,960,134!
143

144
  if (pME->type > 0) {
30,947,943!
145
    TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->name));
62,143,418!
146

147
    if (pME->type == TSDB_SUPER_TABLE) {
31,106,347✔
148
      TAOS_CHECK_RETURN(tDecodeI8(pCoder, &pME->flags));
39,107,819!
149
      TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->stbEntry.schemaRow));
33,631,037!
150
      TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->stbEntry.schemaTag));
33,412,454!
151
      if (TABLE_IS_ROLLUP(pME->flags)) {
19,326,214✔
152
        TAOS_CHECK_RETURN(tDecodeSRSmaParam(pCoder, &pME->stbEntry.rsmaParam));
267!
153
      }
154
    } else if (pME->type == TSDB_CHILD_TABLE) {
11,543,325✔
155
      TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ctbEntry.btime));
19,186,844!
156
      TAOS_CHECK_RETURN(tDecodeI32(pCoder, &pME->ctbEntry.ttlDays));
19,153,129!
157
      TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ctbEntry.commentLen));
19,156,795!
158
      if (pME->ctbEntry.commentLen > 0) {
9,591,890✔
159
        TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->ctbEntry.comment));
290!
160
      }
161
      TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ctbEntry.suid));
19,172,702!
162
      TAOS_CHECK_RETURN(tDecodeTag(pCoder, (STag **)&pME->ctbEntry.pTags));
9,580,812!
163
    } else if (pME->type == TSDB_NORMAL_TABLE) {
1,944,705!
164
      TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ntbEntry.btime));
4,381,419!
165
      TAOS_CHECK_RETURN(tDecodeI32(pCoder, &pME->ntbEntry.ttlDays));
4,379,524!
166
      TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ntbEntry.commentLen));
4,380,531!
167
      if (pME->ntbEntry.commentLen > 0) {
2,191,425✔
168
        TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->ntbEntry.comment));
332!
169
      }
170
      TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ntbEntry.ncid));
4,382,705!
171
      TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->ntbEntry.schemaRow));
4,159,894!
172
    } else if (pME->type == TSDB_TSMA_TABLE) {
×
173
      pME->smaEntry.tsma = tDecoderMalloc(pCoder, sizeof(STSma));
2✔
174
      if (!pME->smaEntry.tsma) {
2!
175
        return terrno;
×
176
      }
177
      TAOS_CHECK_RETURN(tDecodeTSma(pCoder, pME->smaEntry.tsma, true));
2!
178
    } else {
179
      metaError("meta/entry: invalide table type: %" PRId8 " decode failed.", pME->type);
×
180
      return TSDB_CODE_INVALID_PARA;
×
181
    }
182
    if (pME->type == TSDB_SUPER_TABLE) {
31,519,001✔
183
      if (TABLE_IS_COL_COMPRESSED(pME->flags)) {
19,680,870!
184
        TAOS_CHECK_RETURN(meteDecodeColCmprEntry(pCoder, pME));
19,693,666!
185

186
        if (pME->colCmpr.nCols == 0) {
19,554,187!
187
          TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->stbEntry.schemaRow));
×
188
        }
189
      } else {
190
        TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->stbEntry.schemaRow));
×
191
        TABLE_SET_COL_COMPRESSED(pME->flags);
24✔
192
      }
193
    } else if (pME->type == TSDB_NORMAL_TABLE) {
11,838,131✔
194
      if (!tDecodeIsEnd(pCoder)) {
2,195,780!
195
        uDebug("set type: %d, tableName:%s", pME->type, pME->name);
2,195,978✔
196
        TAOS_CHECK_RETURN(meteDecodeColCmprEntry(pCoder, pME));
2,195,979✔
197
        if (pME->colCmpr.nCols == 0) {
2,191,012!
198
          TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->ntbEntry.schemaRow));
×
199
        }
200
      } else {
201
        uDebug("set default type: %d, tableName:%s", pME->type, pME->name);
×
202
        TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->ntbEntry.schemaRow));
×
203
      }
204
      TABLE_SET_COL_COMPRESSED(pME->flags);
2,191,012✔
205
    }
206
  }
207

208
  tEndDecode(pCoder);
31,298,446✔
209
  return 0;
31,218,432✔
210
}
211

212
static int32_t metaCloneSchema(const SSchemaWrapper *pSrc, SSchemaWrapper *pDst) {
459,761✔
213
  if (pSrc == NULL || pDst == NULL) {
459,761!
214
    return TSDB_CODE_INVALID_PARA;
×
215
  }
216

217
  pDst->nCols = pSrc->nCols;
459,803✔
218
  pDst->version = pSrc->version;
459,803✔
219
  pDst->pSchema = (SSchema *)taosMemoryMalloc(pSrc->nCols * sizeof(SSchema));
459,803!
220
  if (pDst->pSchema == NULL) {
459,816!
221
    return terrno;
×
222
  }
223
  memcpy(pDst->pSchema, pSrc->pSchema, pSrc->nCols * sizeof(SSchema));
459,816✔
224
  return TSDB_CODE_SUCCESS;
459,816✔
225
}
226

227
static void metaCloneSchemaFree(SSchemaWrapper *pSchema) {
459,759✔
228
  if (pSchema) {
459,759!
229
    taosMemoryFreeClear(pSchema->pSchema);
459,776!
230
  }
231
}
459,809✔
232

233
void metaCloneEntryFree(SMetaEntry **ppEntry) {
241,683✔
234
  if (ppEntry == NULL || *ppEntry == NULL) {
241,683!
235
    return;
×
236
  }
237

238
  taosMemoryFreeClear((*ppEntry)->name);
241,722!
239

240
  if ((*ppEntry)->type < 0) {
241,737!
241
    taosMemoryFreeClear(*ppEntry);
×
242
    return;
×
243
  }
244

245
  if (TSDB_SUPER_TABLE == (*ppEntry)->type) {
241,737✔
246
    metaCloneSchemaFree(&(*ppEntry)->stbEntry.schemaRow);
228,800✔
247
    metaCloneSchemaFree(&(*ppEntry)->stbEntry.schemaTag);
228,803✔
248
  } else if (TSDB_CHILD_TABLE == (*ppEntry)->type) {
12,937✔
249
    taosMemoryFreeClear((*ppEntry)->ctbEntry.comment);
10,657!
250
    taosMemoryFreeClear((*ppEntry)->ctbEntry.pTags);
10,657!
251
  } else if (TSDB_NORMAL_TABLE == (*ppEntry)->type) {
2,280✔
252
    metaCloneSchemaFree(&(*ppEntry)->ntbEntry.schemaRow);
2,262✔
253
    taosMemoryFreeClear((*ppEntry)->ntbEntry.comment);
2,262!
254
  } else {
255
    return;
18✔
256
  }
257
  metaCloneColCmprFree(&(*ppEntry)->colCmpr);
241,717✔
258

259
  taosMemoryFreeClear(*ppEntry);
241,720!
260
  return;
241,751✔
261
}
262

263
int32_t metaCloneEntry(const SMetaEntry *pEntry, SMetaEntry **ppEntry) {
241,611✔
264
  int32_t code = TSDB_CODE_SUCCESS;
241,611✔
265

266
  if (NULL == pEntry || NULL == ppEntry) {
241,611!
267
    return TSDB_CODE_INVALID_PARA;
×
268
  }
269

270
  *ppEntry = (SMetaEntry *)taosMemoryCalloc(1, sizeof(SMetaEntry));
241,662!
271
  if (NULL == *ppEntry) {
241,742!
272
    return terrno;
×
273
  }
274

275
  (*ppEntry)->version = pEntry->version;
241,742✔
276
  (*ppEntry)->type = pEntry->type;
241,742✔
277
  (*ppEntry)->uid = pEntry->uid;
241,742✔
278

279
  if (pEntry->type < 0) {
241,742!
280
    return TSDB_CODE_SUCCESS;
×
281
  }
282

283
  if (pEntry->name) {
241,742!
284
    (*ppEntry)->name = tstrdup(pEntry->name);
241,747✔
285
    if (NULL == (*ppEntry)->name) {
241,684!
286
      code = terrno;
×
287
      metaCloneEntryFree(ppEntry);
×
288
      return code;
×
289
    }
290
  }
291

292
  if (pEntry->type == TSDB_SUPER_TABLE) {
241,728✔
293
    (*ppEntry)->flags = pEntry->flags;
228,812✔
294

295
    code = metaCloneSchema(&pEntry->stbEntry.schemaRow, &(*ppEntry)->stbEntry.schemaRow);
228,812✔
296
    if (code) {
228,757!
297
      metaCloneEntryFree(ppEntry);
×
298
      return code;
×
299
    }
300

301
    code = metaCloneSchema(&pEntry->stbEntry.schemaTag, &(*ppEntry)->stbEntry.schemaTag);
228,757✔
302
    if (code) {
228,779!
303
      metaCloneEntryFree(ppEntry);
×
304
      return code;
×
305
    }
306
  } else if (pEntry->type == TSDB_CHILD_TABLE) {
12,916✔
307
    (*ppEntry)->ctbEntry.btime = pEntry->ctbEntry.btime;
10,654✔
308
    (*ppEntry)->ctbEntry.ttlDays = pEntry->ctbEntry.ttlDays;
10,654✔
309
    (*ppEntry)->ctbEntry.suid = pEntry->ctbEntry.suid;
10,654✔
310

311
    // comment
312
    (*ppEntry)->ctbEntry.commentLen = pEntry->ctbEntry.commentLen;
10,654✔
313
    if (pEntry->ctbEntry.commentLen > 0) {
10,654✔
314
      (*ppEntry)->ctbEntry.comment = taosMemoryMalloc(pEntry->ctbEntry.commentLen + 1);
40!
315
      if (NULL == (*ppEntry)->ctbEntry.comment) {
40!
316
        code = terrno;
×
317
        metaCloneEntryFree(ppEntry);
×
318
        return code;
×
319
      }
320
      memcpy((*ppEntry)->ctbEntry.comment, pEntry->ctbEntry.comment, pEntry->ctbEntry.commentLen + 1);
40✔
321
    }
322

323
    // tags
324
    STag *pTags = (STag *)pEntry->ctbEntry.pTags;
10,654✔
325
    (*ppEntry)->ctbEntry.pTags = taosMemoryCalloc(1, pTags->len);
10,654!
326
    if (NULL == (*ppEntry)->ctbEntry.pTags) {
10,648!
327
      code = terrno;
×
328
      metaCloneEntryFree(ppEntry);
×
329
      return code;
×
330
    }
331
    memcpy((*ppEntry)->ctbEntry.pTags, pEntry->ctbEntry.pTags, pTags->len);
10,648✔
332
  } else if (pEntry->type == TSDB_NORMAL_TABLE) {
2,262!
333
    (*ppEntry)->ntbEntry.btime = pEntry->ntbEntry.btime;
2,262✔
334
    (*ppEntry)->ntbEntry.ttlDays = pEntry->ntbEntry.ttlDays;
2,262✔
335
    (*ppEntry)->ntbEntry.ncid = pEntry->ntbEntry.ncid;
2,262✔
336

337
    // schema
338
    code = metaCloneSchema(&pEntry->ntbEntry.schemaRow, &(*ppEntry)->ntbEntry.schemaRow);
2,262✔
339
    if (code) {
2,262!
340
      metaCloneEntryFree(ppEntry);
×
341
      return code;
×
342
    }
343

344
    // comment
345
    (*ppEntry)->ntbEntry.commentLen = pEntry->ntbEntry.commentLen;
2,262✔
346
    if (pEntry->ntbEntry.commentLen > 0) {
2,262✔
347
      (*ppEntry)->ntbEntry.comment = taosMemoryMalloc(pEntry->ntbEntry.commentLen + 1);
44!
348
      if (NULL == (*ppEntry)->ntbEntry.comment) {
44!
349
        code = terrno;
×
350
        metaCloneEntryFree(ppEntry);
×
351
        return code;
×
352
      }
353
      memcpy((*ppEntry)->ntbEntry.comment, pEntry->ntbEntry.comment, pEntry->ntbEntry.commentLen + 1);
44✔
354
    }
355
  } else {
356
    return TSDB_CODE_INVALID_PARA;
×
357
  }
358

359
  code = metaCloneColCmpr(&pEntry->colCmpr, &(*ppEntry)->colCmpr);
241,689✔
360
  if (code) {
241,694!
361
    metaCloneEntryFree(ppEntry);
×
362
    return code;
×
363
  }
364

365
  return code;
241,729✔
366
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc