• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3567

26 Dec 2024 02:00AM UTC coverage: 62.733% (+0.3%) from 62.422%
#3567

push

travis-ci

web-flow
Merge pull request #29290 from taosdata/enh/TD-33262-3.0

enh: test coverage of tfs

138620 of 284159 branches covered (48.78%)

Branch coverage included in aggregate %.

20 of 25 new or added lines in 3 files covered. (80.0%)

606 existing lines in 128 files now uncovered.

216140 of 281347 relevant lines covered (76.82%)

18804943.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

67.76
/source/dnode/vnode/src/meta/metaEntry.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "meta.h"
17

18
int meteEncodeColCmprEntry(SEncoder *pCoder, const SMetaEntry *pME) {
439,683✔
19
  const SColCmprWrapper *pw = &pME->colCmpr;
439,683✔
20
  TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pw->nCols));
879,366!
21
  TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pw->version));
879,366!
22
  uDebug("encode cols:%d", pw->nCols);
439,683✔
23

24
  for (int32_t i = 0; i < pw->nCols; i++) {
5,981,871✔
25
    SColCmpr *p = &pw->pColCmpr[i];
5,542,341✔
26
    TAOS_CHECK_RETURN(tEncodeI16v(pCoder, p->id));
11,084,682!
27
    TAOS_CHECK_RETURN(tEncodeU32(pCoder, p->alg));
11,084,682!
28
  }
29
  return 0;
439,530✔
30
}
31
int meteDecodeColCmprEntry(SDecoder *pDecoder, SMetaEntry *pME) {
21,286,791✔
32
  SColCmprWrapper *pWrapper = &pME->colCmpr;
21,286,791✔
33
  TAOS_CHECK_RETURN(tDecodeI32v(pDecoder, &pWrapper->nCols));
42,447,500!
34
  if (pWrapper->nCols == 0) {
21,160,709!
35
    return 0;
×
36
  }
37

38
  TAOS_CHECK_RETURN(tDecodeI32v(pDecoder, &pWrapper->version));
42,309,894!
39
  uDebug("dencode cols:%d", pWrapper->nCols);
21,149,185✔
40
  pWrapper->pColCmpr = (SColCmpr *)tDecoderMalloc(pDecoder, pWrapper->nCols * sizeof(SColCmpr));
21,149,261!
41
  if (pWrapper->pColCmpr == NULL) {
21,312,265!
42
    return terrno;
×
43
  }
44

45
  for (int i = 0; i < pWrapper->nCols; i++) {
442,583,888✔
46
    SColCmpr *p = &pWrapper->pColCmpr[i];
423,241,395✔
47
    TAOS_CHECK_RETURN(tDecodeI16v(pDecoder, &p->id));
846,218,891!
48
    TAOS_CHECK_RETURN(tDecodeU32(pDecoder, &p->alg));
844,249,119!
49
  }
50
  return 0;
19,342,493✔
51
}
52
static FORCE_INLINE int32_t metatInitDefaultSColCmprWrapper(SDecoder *pDecoder, SColCmprWrapper *pCmpr,
53
                                                            SSchemaWrapper *pSchema) {
54
  pCmpr->nCols = pSchema->nCols;
×
55
  if ((pCmpr->pColCmpr = (SColCmpr *)tDecoderMalloc(pDecoder, pCmpr->nCols * sizeof(SColCmpr))) == NULL) {
26!
56
    return terrno;
×
57
  }
58

59
  for (int32_t i = 0; i < pCmpr->nCols; i++) {
338!
60
    SColCmpr *pColCmpr = &pCmpr->pColCmpr[i];
312✔
61
    SSchema  *pColSchema = &pSchema->pSchema[i];
312✔
62
    pColCmpr->id = pColSchema->colId;
312✔
63
    pColCmpr->alg = createDefaultColCmprByType(pColSchema->type);
312✔
64
  }
65
  return 0;
26✔
66
}
67

68
static int32_t metaCloneColCmpr(const SColCmprWrapper *pSrc, SColCmprWrapper *pDst) {
208,826✔
69
  if (pSrc->nCols > 0) {
208,826✔
70
    pDst->nCols = pSrc->nCols;
198,382✔
71
    pDst->version = pSrc->version;
198,382✔
72
    pDst->pColCmpr = (SColCmpr *)taosMemoryCalloc(pSrc->nCols, sizeof(SColCmpr));
198,382!
73
    if (NULL == pDst->pColCmpr) {
198,466!
74
      return terrno;
×
75
    }
76
    memcpy(pDst->pColCmpr, pSrc->pColCmpr, pSrc->nCols * sizeof(SColCmpr));
198,466✔
77
  }
78
  return 0;
208,910✔
79
}
80

81
static void metaCloneColCmprFree(SColCmprWrapper *pCmpr) {
208,906✔
82
  if (pCmpr) {
208,906!
83
    taosMemoryFreeClear(pCmpr->pColCmpr);
208,916!
84
  }
85
}
208,913✔
86

87
int metaEncodeEntry(SEncoder *pCoder, const SMetaEntry *pME) {
448,790✔
88
  TAOS_CHECK_RETURN(tStartEncode(pCoder));
448,790✔
89
  TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->version));
898,942!
90
  TAOS_CHECK_RETURN(tEncodeI8(pCoder, pME->type));
898,942!
91
  TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->uid));
898,942!
92

93
  if (pME->type > 0) {
449,471✔
94
    if (pME->name == NULL) {
439,829!
95
      return TSDB_CODE_INVALID_PARA;
×
96
    }
97

98
    TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->name));
879,658!
99

100
    if (pME->type == TSDB_SUPER_TABLE) {
439,829✔
101
      TAOS_CHECK_RETURN(tEncodeI8(pCoder, pME->flags));
142,188!
102
      TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->stbEntry.schemaRow));
142,188!
103
      TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->stbEntry.schemaTag));
142,188!
104
      if (TABLE_IS_ROLLUP(pME->flags)) {
71,094✔
105
        TAOS_CHECK_RETURN(tEncodeSRSmaParam(pCoder, &pME->stbEntry.rsmaParam));
14!
106
      }
107
    } else if (pME->type == TSDB_CHILD_TABLE) {
368,735✔
108
      TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ctbEntry.btime));
680,066!
109
      TAOS_CHECK_RETURN(tEncodeI32(pCoder, pME->ctbEntry.ttlDays));
680,066!
110
      TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ctbEntry.commentLen));
680,066!
111
      if (pME->ctbEntry.commentLen > 0) {
340,033✔
112
        TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->ctbEntry.comment));
84!
113
      }
114
      TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ctbEntry.suid));
680,066!
115
      TAOS_CHECK_RETURN(tEncodeTag(pCoder, (const STag *)pME->ctbEntry.pTags));
340,033!
116
    } else if (pME->type == TSDB_NORMAL_TABLE) {
28,702✔
117
      TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ntbEntry.btime));
57,134!
118
      TAOS_CHECK_RETURN(tEncodeI32(pCoder, pME->ntbEntry.ttlDays));
57,134!
119
      TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ntbEntry.commentLen));
57,134!
120
      if (pME->ntbEntry.commentLen > 0) {
28,567✔
121
        TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->ntbEntry.comment));
116!
122
      }
123
      TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ntbEntry.ncid));
57,134!
124
      TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->ntbEntry.schemaRow));
57,134!
125
    } else if (pME->type == TSDB_TSMA_TABLE) {
135✔
126
      TAOS_CHECK_RETURN(tEncodeTSma(pCoder, pME->smaEntry.tsma));
56!
127
    } else {
128
      metaError("meta/entry: invalide table type: %" PRId8 " encode failed.", pME->type);
79!
129
      return TSDB_CODE_INVALID_PARA;
×
130
    }
131
    TAOS_CHECK_RETURN(meteEncodeColCmprEntry(pCoder, pME));
439,726!
132
  }
133

134
  tEndEncode(pCoder);
449,170✔
135
  return 0;
449,235✔
136
}
137

138
int metaDecodeEntry(SDecoder *pCoder, SMetaEntry *pME) {
30,603,398✔
139
  TAOS_CHECK_RETURN(tStartDecode(pCoder));
30,603,398!
140
  TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->version));
60,999,628!
141
  TAOS_CHECK_RETURN(tDecodeI8(pCoder, &pME->type));
60,379,513!
142
  TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->uid));
60,040,418!
143

144
  if (pME->type > 0) {
29,991,688!
145
    TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->name));
60,381,680!
146

147
    if (pME->type == TSDB_SUPER_TABLE) {
30,267,302✔
148
      TAOS_CHECK_RETURN(tDecodeI8(pCoder, &pME->flags));
38,133,645!
149
      TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->stbEntry.schemaRow));
40,468,423!
150
      TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->stbEntry.schemaTag));
39,766,638!
151
      if (TABLE_IS_ROLLUP(pME->flags)) {
18,360,367✔
152
        TAOS_CHECK_RETURN(tDecodeSRSmaParam(pCoder, &pME->stbEntry.rsmaParam));
267!
153
      }
154
    } else if (pME->type == TSDB_CHILD_TABLE) {
11,195,809✔
155
      TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ctbEntry.btime));
18,637,288!
156
      TAOS_CHECK_RETURN(tDecodeI32(pCoder, &pME->ctbEntry.ttlDays));
18,603,798!
157
      TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ctbEntry.commentLen));
18,602,896!
158
      if (pME->ctbEntry.commentLen > 0) {
9,311,235✔
159
        TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->ctbEntry.comment));
174!
160
      }
161
      TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ctbEntry.suid));
18,615,864!
162
      TAOS_CHECK_RETURN(tDecodeTag(pCoder, (STag **)&pME->ctbEntry.pTags));
9,304,629!
163
    } else if (pME->type == TSDB_NORMAL_TABLE) {
1,870,658!
164
      TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ntbEntry.btime));
4,186,104!
165
      TAOS_CHECK_RETURN(tDecodeI32(pCoder, &pME->ntbEntry.ttlDays));
4,183,546!
166
      TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ntbEntry.commentLen));
4,183,052!
167
      if (pME->ntbEntry.commentLen > 0) {
2,092,130✔
168
        TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->ntbEntry.comment));
252!
169
      }
170
      TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ntbEntry.ncid));
4,185,122!
171
      TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->ntbEntry.schemaRow));
4,215,029!
172
    } else if (pME->type == TSDB_TSMA_TABLE) {
×
173
      pME->smaEntry.tsma = tDecoderMalloc(pCoder, sizeof(STSma));
3✔
174
      if (!pME->smaEntry.tsma) {
3!
175
        return terrno;
×
176
      }
177
      TAOS_CHECK_RETURN(tDecodeTSma(pCoder, pME->smaEntry.tsma, true));
3!
178
    } else {
179
      metaError("meta/entry: invalide table type: %" PRId8 " decode failed.", pME->type);
×
180
      return TSDB_CODE_INVALID_PARA;
×
181
    }
182
    if (pME->type == TSDB_SUPER_TABLE) {
30,661,460✔
183
      if (TABLE_IS_COL_COMPRESSED(pME->flags)) {
19,198,618!
184
        TAOS_CHECK_RETURN(meteDecodeColCmprEntry(pCoder, pME));
19,211,469!
185

186
        if (pME->colCmpr.nCols == 0) {
19,075,674!
187
          TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->stbEntry.schemaRow));
×
188
        }
189
      } else {
190
        TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->stbEntry.schemaRow));
×
191
        TABLE_SET_COL_COMPRESSED(pME->flags);
26✔
192
      }
193
    } else if (pME->type == TSDB_NORMAL_TABLE) {
11,462,842✔
194
      if (!tDecodeIsEnd(pCoder)) {
2,097,958!
195
        uDebug("set type: %d, tableName:%s", pME->type, pME->name);
2,098,175✔
196
        TAOS_CHECK_RETURN(meteDecodeColCmprEntry(pCoder, pME));
2,098,179✔
197
        if (pME->colCmpr.nCols == 0) {
2,093,471!
198
          TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->ntbEntry.schemaRow));
×
199
        }
200
      } else {
201
        uDebug("set default type: %d, tableName:%s", pME->type, pME->name);
×
202
        TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->ntbEntry.schemaRow));
×
203
      }
204
      TABLE_SET_COL_COMPRESSED(pME->flags);
2,093,471✔
205
    }
206
  }
207

208
  tEndDecode(pCoder);
30,411,365✔
209
  return 0;
30,383,946✔
210
}
211

212
static int32_t metaCloneSchema(const SSchemaWrapper *pSrc, SSchemaWrapper *pDst) {
394,509✔
213
  if (pSrc == NULL || pDst == NULL) {
394,509!
214
    return TSDB_CODE_INVALID_PARA;
×
215
  }
216

217
  pDst->nCols = pSrc->nCols;
394,539✔
218
  pDst->version = pSrc->version;
394,539✔
219
  pDst->pSchema = (SSchema *)taosMemoryMalloc(pSrc->nCols * sizeof(SSchema));
394,539!
220
  if (pDst->pSchema == NULL) {
394,542!
221
    return terrno;
×
222
  }
223
  memcpy(pDst->pSchema, pSrc->pSchema, pSrc->nCols * sizeof(SSchema));
394,542✔
224
  return TSDB_CODE_SUCCESS;
394,542✔
225
}
226

227
static void metaCloneSchemaFree(SSchemaWrapper *pSchema) {
394,544✔
228
  if (pSchema) {
394,544!
229
    taosMemoryFreeClear(pSchema->pSchema);
394,563!
230
  }
231
}
394,608✔
232

233
void metaCloneEntryFree(SMetaEntry **ppEntry) {
208,893✔
234
  if (ppEntry == NULL || *ppEntry == NULL) {
208,893!
235
    return;
×
236
  }
237

238
  taosMemoryFreeClear((*ppEntry)->name);
208,906!
239

240
  if ((*ppEntry)->type < 0) {
208,926!
241
    taosMemoryFreeClear(*ppEntry);
×
242
    return;
×
243
  }
244

245
  if (TSDB_SUPER_TABLE == (*ppEntry)->type) {
208,926✔
246
    metaCloneSchemaFree(&(*ppEntry)->stbEntry.schemaRow);
196,210✔
247
    metaCloneSchemaFree(&(*ppEntry)->stbEntry.schemaTag);
196,213✔
248
  } else if (TSDB_CHILD_TABLE == (*ppEntry)->type) {
12,716✔
249
    taosMemoryFreeClear((*ppEntry)->ctbEntry.comment);
10,467!
250
    taosMemoryFreeClear((*ppEntry)->ctbEntry.pTags);
10,467!
251
  } else if (TSDB_NORMAL_TABLE == (*ppEntry)->type) {
2,249✔
252
    metaCloneSchemaFree(&(*ppEntry)->ntbEntry.schemaRow);
2,234✔
253
    taosMemoryFreeClear((*ppEntry)->ntbEntry.comment);
2,234!
254
  } else {
255
    return;
15✔
256
  }
257
  metaCloneColCmprFree(&(*ppEntry)->colCmpr);
208,927✔
258

259
  taosMemoryFreeClear(*ppEntry);
208,921!
260
  return;
208,945✔
261
}
262

263
int32_t metaCloneEntry(const SMetaEntry *pEntry, SMetaEntry **ppEntry) {
208,815✔
264
  int32_t code = TSDB_CODE_SUCCESS;
208,815✔
265

266
  if (NULL == pEntry || NULL == ppEntry) {
208,815!
267
    return TSDB_CODE_INVALID_PARA;
×
268
  }
269

270
  *ppEntry = (SMetaEntry *)taosMemoryCalloc(1, sizeof(SMetaEntry));
208,855!
271
  if (NULL == *ppEntry) {
208,938!
272
    return terrno;
×
273
  }
274

275
  (*ppEntry)->version = pEntry->version;
208,938✔
276
  (*ppEntry)->type = pEntry->type;
208,938✔
277
  (*ppEntry)->uid = pEntry->uid;
208,938✔
278

279
  if (pEntry->type < 0) {
208,938!
280
    return TSDB_CODE_SUCCESS;
×
281
  }
282

283
  if (pEntry->name) {
208,938!
284
    (*ppEntry)->name = tstrdup(pEntry->name);
208,938✔
285
    if (NULL == (*ppEntry)->name) {
208,867!
286
      code = terrno;
×
287
      metaCloneEntryFree(ppEntry);
×
288
      return code;
×
289
    }
290
  }
291

292
  if (pEntry->type == TSDB_SUPER_TABLE) {
208,879✔
293
    (*ppEntry)->flags = pEntry->flags;
196,173✔
294

295
    code = metaCloneSchema(&pEntry->stbEntry.schemaRow, &(*ppEntry)->stbEntry.schemaRow);
196,173✔
296
    if (code) {
196,142!
297
      metaCloneEntryFree(ppEntry);
×
298
      return code;
×
299
    }
300

301
    code = metaCloneSchema(&pEntry->stbEntry.schemaTag, &(*ppEntry)->stbEntry.schemaTag);
196,142✔
302
    if (code) {
196,149!
303
      metaCloneEntryFree(ppEntry);
×
304
      return code;
×
305
    }
306
  } else if (pEntry->type == TSDB_CHILD_TABLE) {
12,706✔
307
    (*ppEntry)->ctbEntry.btime = pEntry->ctbEntry.btime;
10,472✔
308
    (*ppEntry)->ctbEntry.ttlDays = pEntry->ctbEntry.ttlDays;
10,472✔
309
    (*ppEntry)->ctbEntry.suid = pEntry->ctbEntry.suid;
10,472✔
310

311
    // comment
312
    (*ppEntry)->ctbEntry.commentLen = pEntry->ctbEntry.commentLen;
10,472✔
313
    if (pEntry->ctbEntry.commentLen > 0) {
10,472✔
314
      (*ppEntry)->ctbEntry.comment = taosMemoryMalloc(pEntry->ctbEntry.commentLen + 1);
24!
315
      if (NULL == (*ppEntry)->ctbEntry.comment) {
24!
316
        code = terrno;
×
317
        metaCloneEntryFree(ppEntry);
×
318
        return code;
×
319
      }
320
      memcpy((*ppEntry)->ctbEntry.comment, pEntry->ctbEntry.comment, pEntry->ctbEntry.commentLen + 1);
24✔
321
    }
322

323
    // tags
324
    STag *pTags = (STag *)pEntry->ctbEntry.pTags;
10,472✔
325
    (*ppEntry)->ctbEntry.pTags = taosMemoryCalloc(1, pTags->len);
10,472!
326
    if (NULL == (*ppEntry)->ctbEntry.pTags) {
10,475!
327
      code = terrno;
×
328
      metaCloneEntryFree(ppEntry);
×
329
      return code;
×
330
    }
331
    memcpy((*ppEntry)->ctbEntry.pTags, pEntry->ctbEntry.pTags, pTags->len);
10,475✔
332
  } else if (pEntry->type == TSDB_NORMAL_TABLE) {
2,234!
333
    (*ppEntry)->ntbEntry.btime = pEntry->ntbEntry.btime;
2,234✔
334
    (*ppEntry)->ntbEntry.ttlDays = pEntry->ntbEntry.ttlDays;
2,234✔
335
    (*ppEntry)->ntbEntry.ncid = pEntry->ntbEntry.ncid;
2,234✔
336

337
    // schema
338
    code = metaCloneSchema(&pEntry->ntbEntry.schemaRow, &(*ppEntry)->ntbEntry.schemaRow);
2,234✔
339
    if (code) {
2,234!
340
      metaCloneEntryFree(ppEntry);
×
341
      return code;
×
342
    }
343

344
    // comment
345
    (*ppEntry)->ntbEntry.commentLen = pEntry->ntbEntry.commentLen;
2,234✔
346
    if (pEntry->ntbEntry.commentLen > 0) {
2,234✔
347
      (*ppEntry)->ntbEntry.comment = taosMemoryMalloc(pEntry->ntbEntry.commentLen + 1);
36!
348
      if (NULL == (*ppEntry)->ntbEntry.comment) {
36!
349
        code = terrno;
×
350
        metaCloneEntryFree(ppEntry);
×
351
        return code;
×
352
      }
353
      memcpy((*ppEntry)->ntbEntry.comment, pEntry->ntbEntry.comment, pEntry->ntbEntry.commentLen + 1);
36✔
354
    }
355
  } else {
UNCOV
356
    return TSDB_CODE_INVALID_PARA;
×
357
  }
358

359
  code = metaCloneColCmpr(&pEntry->colCmpr, &(*ppEntry)->colCmpr);
208,858✔
360
  if (code) {
208,906✔
361
    metaCloneEntryFree(ppEntry);
2✔
362
    return code;
×
363
  }
364

365
  return code;
208,904✔
366
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc