12439481725

Committed 20 Dec 2024 10:39PM UTC coverage: 99.615%. Remained the same

Build # 12439481725

Build Type

Pull #4616

github

Committed by

web-flow

Commit Message

Merge 1be1e48a9 into 361877178

Pull Request Pull Request #4616: refactor: Swap pointercapture capture group w/ if-else

Run Details

1192 of 1223 branches covered (97.47%)

777 of 780 relevant lines covered (99.62%)

12692.32 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.3

/src/diff/props.js

import { IS_NON_DIMENSIONAL, SVG_NAMESPACE } from '../constants';
import options from '../options';

function setStyle(style, key, value) {
        if (key[0] == '-') {
                style.setProperty(key, value == null ? '' : value);
        } else if (value == null) {
                style[key] = '';
        } else if (typeof value != 'number' || IS_NON_DIMENSIONAL.test(key)) {
                style[key] = value;
        } else {
                style[key] = value + 'px';
        }
}

// A logical clock to solve issues like https://github.com/preactjs/preact/issues/3927.
// When the DOM performs an event it leaves micro-ticks in between bubbling up which means that
// an event can trigger on a newly reated DOM-node while the event bubbles up.
//
// Originally inspired by Vue
// (https://github.com/vuejs/core/blob/caeb8a68811a1b0f79/packages/runtime-dom/src/modules/events.ts#L90-L101),
// but modified to use a logical clock instead of Date.now() in case event handlers get attached
// and events get dispatched during the same millisecond.
//
// The clock is incremented after each new event dispatch. This allows 1 000 000 new events
// per second for over 280 years before the value reaches Number.MAX_SAFE_INTEGER (2**53 - 1).
let eventClock = 0;

/**
 * Set a property value on a DOM node
 * @param {import('../internal').PreactElement} dom The DOM node to modify
 * @param {string} name The name of the property to set
 * @param {*} value The value to set the property to
 * @param {*} oldValue The old value the property had
 * @param {string} namespace Whether or not this DOM node is an SVG node or not
 */
export function setProperty(dom, name, value, oldValue, namespace) {
        let useCapture;

        o: if (name == 'style') {
                if (typeof value == 'string') {
                        dom.style.cssText = value;
                } else {
                        if (typeof oldValue == 'string') {
                                dom.style.cssText = oldValue = '';
                        }

                        if (oldValue) {
                                for (name in oldValue) {
                                        if (!(value && name in value)) {
                                                setStyle(dom.style, name, '');
                                        }
                                }
                        }

                        if (value) {
                                for (name in value) {
                                        if (!oldValue || value[name] !== oldValue[name]) {
                                                setStyle(dom.style, name, value[name]);
                                        }
                                }
                        }
                }
        }
        // Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
        else if (name[0] == 'o' && name[1] == 'n') {
                if (/PointerCapture$/i.test(name)) {
                        useCapture = false;
                } else {
                        useCapture = name !== (name = name.replace(/Capture$/i, ''));
                }

                // Infer correct casing for DOM built-in events:
                if (
                        name.toLowerCase() in dom ||
                        name == 'onFocusOut' ||
                        name == 'onFocusIn'
                )
                        name = name.toLowerCase().slice(2);
                else name = name.slice(2);

                if (!dom._listeners) dom._listeners = {};
                dom._listeners[name + useCapture] = value;

                if (value) {
                        if (!oldValue) {
                                value._attached = eventClock;
                                dom.addEventListener(
                                        name,
                                        useCapture ? eventProxyCapture : eventProxy,
                                        useCapture
                                );
                        } else {
                                value._attached = oldValue._attached;
                        }
                } else {
                        dom.removeEventListener(
                                name,
                                useCapture ? eventProxyCapture : eventProxy,
                                useCapture
                        );
                }
        } else {
                if (namespace == SVG_NAMESPACE) {
                        // Normalize incorrect prop usage for SVG:
                        // - xlink:href / xlinkHref --> href (xlink:href was removed from SVG and isn't needed)
                        // - className --> class
                        name = name.replace(/xlink(H|:h)/, 'h').replace(/sName$/, 's');
                } else if (
                        name != 'width' &&
                        name != 'height' &&
                        name != 'href' &&
                        name != 'list' &&
                        name != 'form' &&
                        // Default value in browsers is `-1` and an empty string is
                        // cast to `0` instead
                        name != 'tabIndex' &&
                        name != 'download' &&
                        name != 'rowSpan' &&
                        name != 'colSpan' &&
                        name != 'role' &&
                        name != 'popover' &&
                        name in dom
                ) {
                        try {
                                dom[name] = value == null ? '' : value;
                                // labelled break is 1b smaller here than a return statement (sorry)
                                break o;
                        } catch (e) {}
                }

                // aria- and data- attributes have no boolean representation.
                // A `false` value is different from the attribute not being
                // present, so we can't remove it. For non-boolean aria
                // attributes we could treat false as a removal, but the
                // amount of exceptions would cost too many bytes. On top of
                // that other frameworks generally stringify `false`.

                if (typeof value == 'function') {
                        // never serialize functions as attribute values
                } else if (value != null && (value !== false || name[4] == '-')) {
                        dom.setAttribute(name, name == 'popover' && value == true ? '' : value);
                } else {
                        dom.removeAttribute(name);
                }
        }
}

/**
 * Create an event proxy function.
 * @param {boolean} useCapture Is the event handler for the capture phase.
 * @private
 */
function createEventProxy(useCapture) {
        /**
         * Proxy an event to hooked event handlers
         * @param {import('../internal').PreactEvent} e The event object from the browser
         * @private
         */
        return function (e) {
                if (this._listeners) {
                        const eventHandler = this._listeners[e.type + useCapture];
                        if (e._dispatched == null) {
                                e._dispatched = eventClock++;

                                // When `e._dispatched` is smaller than the time when the targeted event
                                // handler was attached we know we have bubbled up to an element that was added
                                // during patching the DOM.
                        } else if (e._dispatched < eventHandler._attached) {
                                return;
                        }
                        return eventHandler(options.event ? options.event(e) : e);
                }
        };
}

const eventProxy = createEventProxy(false);
const eventProxyCapture = createEventProxy(true);

1	import { IS_NON_DIMENSIONAL, SVG_NAMESPACE } from '../constants';
2	import options from '../options';
3
4	function setStyle(style, key, value) {
5	if (key[0] == '-') {	46✔
6	style.setProperty(key, value == null ? '' : value);	12✔
7	} else if (value == null) {	34✔
8	style[key] = '';
9	} else if (typeof value != 'number' \|\| IS_NON_DIMENSIONAL.test(key)) {	73✔
10	style[key] = value;
11	} else {
12	style[key] = value + 'px';
13	}
14	}
15
16	// A logical clock to solve issues like https://github.com/preactjs/preact/issues/3927.
17	// When the DOM performs an event it leaves micro-ticks in between bubbling up which means that
18	// an event can trigger on a newly reated DOM-node while the event bubbles up.
19	//
20	// Originally inspired by Vue
21	// (https://github.com/vuejs/core/blob/caeb8a68811a1b0f79/packages/runtime-dom/src/modules/events.ts#L90-L101),
22	// but modified to use a logical clock instead of Date.now() in case event handlers get attached
23	// and events get dispatched during the same millisecond.
24	//
25	// The clock is incremented after each new event dispatch. This allows 1 000 000 new events
26	// per second for over 280 years before the value reaches Number.MAX_SAFE_INTEGER (2**53 - 1).
27	let eventClock = 0;
28
29	/**
30	* Set a property value on a DOM node
31	* @param {import('../internal').PreactElement} dom The DOM node to modify
32	* @param {string} name The name of the property to set
33	* @param {*} value The value to set the property to
34	* @param {*} oldValue The old value the property had
35	* @param {string} namespace Whether or not this DOM node is an SVG node or not
36	*/
37	export function setProperty(dom, name, value, oldValue, namespace) {
38	let useCapture;
39
40	o: if (name == 'style') {	631✔
41	if (typeof value == 'string') {	41✔
42	dom.style.cssText = value;	6✔
43	} else {
44	if (typeof oldValue == 'string') {	37✔
45	dom.style.cssText = oldValue = '';
46	}
47
48	if (oldValue) {	35✔
49	for (name in oldValue) {	20✔
50	if (!(value && name in value)) {	21✔
51	setStyle(dom.style, name, '');
52	}
53	}
54	}
55
56	if (value) {	35✔
57	for (name in value) {	34✔
58	if (!oldValue \|\| value[name] !== oldValue[name]) {	49✔
59	setStyle(dom.style, name, value[name]);
60	}
61	}
62	}
63	}
64	}
65	// Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
66	else if (name[0] == 'o' && name[1] == 'n') {	590✔
67	if (/PointerCapture$/i.test(name)) {
68	useCapture = false;	164✔
69	} else {
70	useCapture = name !== (name = name.replace(/Capture$/i, ''));
71	}
72
73	// Infer correct casing for DOM built-in events:
74	if (
75	name.toLowerCase() in dom \|\|	379✔
76	name == 'onFocusOut' \|\|
77	name == 'onFocusIn'
78	)
79	name = name.toLowerCase().slice(2);
80	else name = name.slice(2);
81
82	if (!dom._listeners) dom._listeners = {};	273✔
83	dom._listeners[name + useCapture] = value;
84
85	if (value) {	164✔
86	if (!oldValue) {	150✔
87	value._attached = eventClock;
88	dom.addEventListener(
89	name,
90	useCapture ? eventProxyCapture : eventProxy,	118✔
91	useCapture
92	);
93	} else {
94	value._attached = oldValue._attached;
95	}
96	} else {
97	dom.removeEventListener(
98	name,
99	useCapture ? eventProxyCapture : eventProxy,	14!
100	useCapture
101	);
102	}
103	} else {
104	if (namespace == SVG_NAMESPACE) {	426✔
105	// Normalize incorrect prop usage for SVG:
106	// - xlink:href / xlinkHref --> href (xlink:href was removed from SVG and isn't needed)
107	// - className --> class
108	name = name.replace(/xlink(H\|:h)/, 'h').replace(/sName$/, 's');	73✔
109	} else if (	353✔
110	name != 'width' &&	4,044✔
111	name != 'height' &&
112	name != 'href' &&
113	name != 'list' &&
114	name != 'form' &&
115	// Default value in browsers is `-1` and an empty string is
116	// cast to `0` instead
117	name != 'tabIndex' &&
118	name != 'download' &&
119	name != 'rowSpan' &&
120	name != 'colSpan' &&
121	name != 'role' &&
122	name != 'popover' &&
123	name in dom
124	) {
125	try {	218✔
126	dom[name] = value == null ? '' : value;	218✔
127	// labelled break is 1b smaller here than a return statement (sorry)
128	break o;	214✔
129	} catch (e) {}
130	}
131
132	// aria- and data- attributes have no boolean representation.
133	// A `false` value is different from the attribute not being
134	// present, so we can't remove it. For non-boolean aria
135	// attributes we could treat false as a removal, but the
136	// amount of exceptions would cost too many bytes. On top of
137	// that other frameworks generally stringify `false`.
138
139	if (typeof value == 'function') {	212✔
140	// never serialize functions as attribute values
141	} else if (value != null && (value !== false \|\| name[4] == '-')) {	621✔
142	dom.setAttribute(name, name == 'popover' && value == true ? '' : value);	376✔
143	} else {
144	dom.removeAttribute(name);
145	}
146	}
147	}
148
149	/**
150	* Create an event proxy function.
151	* @param {boolean} useCapture Is the event handler for the capture phase.
152	* @private
153	*/
154	function createEventProxy(useCapture) {
155	/**
156	* Proxy an event to hooked event handlers
157	* @param {import('../internal').PreactEvent} e The event object from the browser
158	* @private
159	*/
160	return function (e) {	192✔
161	if (this._listeners) {	66✔
162	const eventHandler = this._listeners[e.type + useCapture];	66✔
163	if (e._dispatched == null) {	66✔
164	e._dispatched = eventClock++;	63✔
165
166	// When `e._dispatched` is smaller than the time when the targeted event
167	// handler was attached we know we have bubbled up to an element that was added
168	// during patching the DOM.
169	} else if (e._dispatched < eventHandler._attached) {	3!
170	return;	×
171	}
172	return eventHandler(options.event ? options.event(e) : e);	66✔
173	}
174	};
175	}
176
177	const eventProxy = createEventProxy(false);
178	const eventProxyCapture = createEventProxy(true);

preactjs / preact / 12439481725

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous