• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3562

20 Dec 2024 09:57AM UTC coverage: 26.655% (-32.2%) from 58.812%
#3562

push

travis-ci

web-flow
Merge pull request #29229 from taosdata/enh/TS-5749-3.0

enh: seperate tsdb async tasks to different thread pools

21498 of 109421 branches covered (19.65%)

Branch coverage included in aggregate %.

66 of 96 new or added lines in 7 files covered. (68.75%)

39441 existing lines in 157 files now uncovered.

35007 of 102566 relevant lines covered (34.13%)

53922.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.62
/source/dnode/vnode/src/tsdb/tsdbMemTable.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tsdb.h"
17
#include "util/tsimplehash.h"
18

19
#define MEM_MIN_HASH 1024
20
#define SL_MAX_LEVEL 5
21

22
// sizeof(SMemSkipListNode) + sizeof(SMemSkipListNode *) * (l) * 2
23
#define SL_NODE_SIZE(l)               (sizeof(SMemSkipListNode) + ((l) << 4))
24
#define SL_NODE_FORWARD(n, l)         ((n)->forwards[l])
25
#define SL_NODE_BACKWARD(n, l)        ((n)->forwards[(n)->level + (l)])
26
#define SL_GET_NODE_FORWARD(n, l)     ((SMemSkipListNode *)atomic_load_ptr(&SL_NODE_FORWARD(n, l)))
27
#define SL_GET_NODE_BACKWARD(n, l)    ((SMemSkipListNode *)atomic_load_ptr(&SL_NODE_BACKWARD(n, l)))
28
#define SL_SET_NODE_FORWARD(n, l, p)  atomic_store_ptr(&SL_NODE_FORWARD(n, l), p)
29
#define SL_SET_NODE_BACKWARD(n, l, p) atomic_store_ptr(&SL_NODE_BACKWARD(n, l), p)
30

31
#define SL_MOVE_BACKWARD 0x1
32
#define SL_MOVE_FROM_POS 0x2
33

34
static void    tbDataMovePosTo(STbData *pTbData, SMemSkipListNode **pos, STsdbRowKey *pKey, int32_t flags);
35
static int32_t tsdbGetOrCreateTbData(SMemTable *pMemTable, tb_uid_t suid, tb_uid_t uid, STbData **ppTbData);
36
static int32_t tsdbInsertRowDataToTable(SMemTable *pMemTable, STbData *pTbData, int64_t version,
37
                                        SSubmitTbData *pSubmitTbData, int32_t *affectedRows);
38
static int32_t tsdbInsertColDataToTable(SMemTable *pMemTable, STbData *pTbData, int64_t version,
39
                                        SSubmitTbData *pSubmitTbData, int32_t *affectedRows);
40

41
static int32_t tTbDataCmprFn(const SRBTreeNode *n1, const SRBTreeNode *n2) {
80✔
42
  STbData *tbData1 = TCONTAINER_OF(n1, STbData, rbtn);
80✔
43
  STbData *tbData2 = TCONTAINER_OF(n2, STbData, rbtn);
80✔
44
  if (tbData1->suid < tbData2->suid) return -1;
80✔
45
  if (tbData1->suid > tbData2->suid) return 1;
58✔
46
  if (tbData1->uid < tbData2->uid) return -1;
39✔
47
  if (tbData1->uid > tbData2->uid) return 1;
23!
48
  return 0;
×
49
}
50

51
int32_t tsdbMemTableCreate(STsdb *pTsdb, SMemTable **ppMemTable) {
566✔
52
  int32_t    code = 0;
566✔
53
  SMemTable *pMemTable = NULL;
566✔
54

55
  pMemTable = (SMemTable *)taosMemoryCalloc(1, sizeof(*pMemTable));
566!
56
  if (pMemTable == NULL) {
566!
57
    code = terrno;
×
58
    goto _err;
×
59
  }
60
  taosInitRWLatch(&pMemTable->latch);
566✔
61
  pMemTable->pTsdb = pTsdb;
566✔
62
  pMemTable->pPool = pTsdb->pVnode->inUse;
566✔
63
  pMemTable->nRef = 1;
566✔
64
  pMemTable->minVer = VERSION_MAX;
566✔
65
  pMemTable->maxVer = VERSION_MIN;
566✔
66
  pMemTable->minKey = TSKEY_MAX;
566✔
67
  pMemTable->maxKey = TSKEY_MIN;
566✔
68
  pMemTable->nRow = 0;
566✔
69
  pMemTable->nDel = 0;
566✔
70
  pMemTable->nTbData = 0;
566✔
71
  pMemTable->nBucket = MEM_MIN_HASH;
566✔
72
  pMemTable->aBucket = (STbData **)taosMemoryCalloc(pMemTable->nBucket, sizeof(STbData *));
566!
73
  if (pMemTable->aBucket == NULL) {
566!
74
    code = terrno;
×
75
    taosMemoryFree(pMemTable);
×
76
    goto _err;
×
77
  }
78
  vnodeBufPoolRef(pMemTable->pPool);
566✔
79
  tRBTreeCreate(pMemTable->tbDataTree, tTbDataCmprFn);
566✔
80

81
  *ppMemTable = pMemTable;
566✔
82
  return code;
566✔
83

84
_err:
×
85
  *ppMemTable = NULL;
×
86
  return code;
×
87
}
88

89
void tsdbMemTableDestroy(SMemTable *pMemTable, bool proactive) {
566✔
90
  if (pMemTable) {
566!
91
    vnodeBufPoolUnRef(pMemTable->pPool, proactive);
566✔
92
    taosMemoryFree(pMemTable->aBucket);
566!
93
    taosMemoryFree(pMemTable);
566!
94
  }
95
}
566✔
96

97
static FORCE_INLINE STbData *tsdbGetTbDataFromMemTableImpl(SMemTable *pMemTable, tb_uid_t suid, tb_uid_t uid) {
98
  STbData *pTbData = pMemTable->aBucket[TABS(uid) % pMemTable->nBucket];
125,715✔
99

100
  while (pTbData) {
125,715✔
101
    if (pTbData->uid == uid) break;
60,351!
UNCOV
102
    pTbData = pTbData->next;
×
103
  }
104

105
  return pTbData;
125,715✔
106
}
107

108
STbData *tsdbGetTbDataFromMemTable(SMemTable *pMemTable, tb_uid_t suid, tb_uid_t uid) {
80,694✔
109
  STbData *pTbData;
110

111
  taosRLockLatch(&pMemTable->latch);
80,694✔
112
  pTbData = tsdbGetTbDataFromMemTableImpl(pMemTable, suid, uid);
80,735✔
113
  taosRUnLockLatch(&pMemTable->latch);
80,735✔
114

115
  return pTbData;
80,738✔
116
}
117

118
int32_t tsdbInsertTableData(STsdb *pTsdb, int64_t version, SSubmitTbData *pSubmitTbData, int32_t *affectedRows) {
44,980✔
119
  int32_t    code = 0;
44,980✔
120
  SMemTable *pMemTable = pTsdb->mem;
44,980✔
121
  STbData   *pTbData = NULL;
44,980✔
122
  tb_uid_t   suid = pSubmitTbData->suid;
44,980✔
123
  tb_uid_t   uid = pSubmitTbData->uid;
44,980✔
124

125
  if (tsBypassFlag & TSDB_BYPASS_RB_TSDB_WRITE_MEM) {
44,980!
126
    goto _err;
×
127
  }
128

129
  // create/get STbData to op
130
  code = tsdbGetOrCreateTbData(pMemTable, suid, uid, &pTbData);
44,980✔
131
  if (code) {
44,980!
132
    goto _err;
×
133
  }
134

135
  // do insert impl
136
  if (pSubmitTbData->flags & SUBMIT_REQ_COLUMN_DATA_FORMAT) {
44,980!
UNCOV
137
    code = tsdbInsertColDataToTable(pMemTable, pTbData, version, pSubmitTbData, affectedRows);
×
138
  } else {
139
    code = tsdbInsertRowDataToTable(pMemTable, pTbData, version, pSubmitTbData, affectedRows);
44,980✔
140
  }
141
  if (code) goto _err;
44,980!
142

143
  // update
144
  pMemTable->minVer = TMIN(pMemTable->minVer, version);
44,980✔
145
  pMemTable->maxVer = TMAX(pMemTable->maxVer, version);
44,980✔
146

147
  return code;
44,980✔
148

149
_err:
×
150
  terrno = code;
×
151
  return code;
×
152
}
153

UNCOV
154
int32_t tsdbDeleteTableData(STsdb *pTsdb, int64_t version, tb_uid_t suid, tb_uid_t uid, TSKEY sKey, TSKEY eKey) {
×
UNCOV
155
  int32_t    code = 0;
×
UNCOV
156
  SMemTable *pMemTable = pTsdb->mem;
×
UNCOV
157
  STbData   *pTbData = NULL;
×
UNCOV
158
  SVBufPool *pPool = pTsdb->pVnode->inUse;
×
159

160
  // check if table exists
161
  SMetaInfo info;
UNCOV
162
  code = metaGetInfo(pTsdb->pVnode->pMeta, uid, &info, NULL);
×
UNCOV
163
  if (code) {
×
164
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
165
    goto _err;
×
166
  }
UNCOV
167
  if (info.suid != suid) {
×
168
    code = TSDB_CODE_INVALID_MSG;
×
169
    goto _err;
×
170
  }
171

UNCOV
172
  code = tsdbGetOrCreateTbData(pMemTable, suid, uid, &pTbData);
×
UNCOV
173
  if (code) {
×
174
    goto _err;
×
175
  }
176

177
  // do delete
UNCOV
178
  SDelData *pDelData = (SDelData *)vnodeBufPoolMalloc(pPool, sizeof(*pDelData));
×
UNCOV
179
  if (pDelData == NULL) {
×
180
    code = terrno;
×
181
    goto _err;
×
182
  }
UNCOV
183
  pDelData->version = version;
×
UNCOV
184
  pDelData->sKey = sKey;
×
UNCOV
185
  pDelData->eKey = eKey;
×
UNCOV
186
  pDelData->pNext = NULL;
×
UNCOV
187
  taosWLockLatch(&pTbData->lock);
×
UNCOV
188
  if (pTbData->pHead == NULL) {
×
UNCOV
189
    pTbData->pHead = pTbData->pTail = pDelData;
×
190
  } else {
UNCOV
191
    pTbData->pTail->pNext = pDelData;
×
UNCOV
192
    pTbData->pTail = pDelData;
×
193
  }
UNCOV
194
  taosWUnLockLatch(&pTbData->lock);
×
195

UNCOV
196
  pMemTable->nDel++;
×
UNCOV
197
  pMemTable->minVer = TMIN(pMemTable->minVer, version);
×
UNCOV
198
  pMemTable->maxVer = TMAX(pMemTable->maxVer, version);
×
199

UNCOV
200
  if (tsdbCacheDel(pTsdb, suid, uid, sKey, eKey) != 0) {
×
201
    tsdbError("vgId:%d, failed to delete cache data from table suid:%" PRId64 " uid:%" PRId64 " skey:%" PRId64
×
202
              " eKey:%" PRId64 " at version %" PRId64,
203
              TD_VID(pTsdb->pVnode), suid, uid, sKey, eKey, version);
204
  }
205

UNCOV
206
  tsdbTrace("vgId:%d, delete data from table suid:%" PRId64 " uid:%" PRId64 " skey:%" PRId64 " eKey:%" PRId64
×
207
            " at version %" PRId64,
208
            TD_VID(pTsdb->pVnode), suid, uid, sKey, eKey, version);
UNCOV
209
  return code;
×
210

211
_err:
×
212
  tsdbError("vgId:%d, failed to delete data from table suid:%" PRId64 " uid:%" PRId64 " skey:%" PRId64 " eKey:%" PRId64
×
213
            " at version %" PRId64 " since %s",
214
            TD_VID(pTsdb->pVnode), suid, uid, sKey, eKey, version, tstrerror(code));
215
  return code;
×
216
}
217

218
int32_t tsdbTbDataIterCreate(STbData *pTbData, STsdbRowKey *pFrom, int8_t backward, STbDataIter **ppIter) {
11,397✔
219
  int32_t code = 0;
11,397✔
220

221
  (*ppIter) = (STbDataIter *)taosMemoryCalloc(1, sizeof(STbDataIter));
11,397!
222
  if ((*ppIter) == NULL) {
11,397!
223
    code = terrno;
×
224
    goto _exit;
×
225
  }
226

227
  tsdbTbDataIterOpen(pTbData, pFrom, backward, *ppIter);
11,397✔
228

229
_exit:
11,397✔
230
  return code;
11,397✔
231
}
232

233
void *tsdbTbDataIterDestroy(STbDataIter *pIter) {
11,397✔
234
  if (pIter) {
11,397!
235
    taosMemoryFree(pIter);
11,397!
236
  }
237
  return NULL;
11,397✔
238
}
239

240
void tsdbTbDataIterOpen(STbData *pTbData, STsdbRowKey *pFrom, int8_t backward, STbDataIter *pIter) {
11,563✔
241
  SMemSkipListNode *pos[SL_MAX_LEVEL];
242
  SMemSkipListNode *pHead;
243
  SMemSkipListNode *pTail;
244

245
  pHead = pTbData->sl.pHead;
11,563✔
246
  pTail = pTbData->sl.pTail;
11,563✔
247
  pIter->pTbData = pTbData;
11,563✔
248
  pIter->backward = backward;
11,563✔
249
  pIter->pRow = NULL;
11,563✔
250
  if (pFrom == NULL) {
11,563✔
251
    // create from head or tail
252
    if (backward) {
15!
253
      pIter->pNode = SL_GET_NODE_BACKWARD(pTbData->sl.pTail, 0);
15✔
254
    } else {
UNCOV
255
      pIter->pNode = SL_GET_NODE_FORWARD(pTbData->sl.pHead, 0);
×
256
    }
257
  } else {
258
    // create from a key
259
    if (backward) {
11,548✔
260
      tbDataMovePosTo(pTbData, pos, pFrom, SL_MOVE_BACKWARD);
27✔
261
      pIter->pNode = SL_GET_NODE_BACKWARD(pos[0], 0);
27✔
262
    } else {
263
      tbDataMovePosTo(pTbData, pos, pFrom, 0);
11,521✔
264
      pIter->pNode = SL_GET_NODE_FORWARD(pos[0], 0);
11,521✔
265
    }
266
  }
267
}
11,563✔
268

269
bool tsdbTbDataIterNext(STbDataIter *pIter) {
1,638,239✔
270
  pIter->pRow = NULL;
1,638,239✔
271
  if (pIter->backward) {
1,638,239✔
272
    if (pIter->pNode == pIter->pTbData->sl.pHead) {
23,552!
273
      return false;
×
274
    }
275

276
    pIter->pNode = SL_GET_NODE_BACKWARD(pIter->pNode, 0);
23,552✔
277
    if (pIter->pNode == pIter->pTbData->sl.pHead) {
23,552✔
278
      return false;
38✔
279
    }
280
  } else {
281
    if (pIter->pNode == pIter->pTbData->sl.pTail) {
1,614,687!
282
      return false;
×
283
    }
284

285
    pIter->pNode = SL_GET_NODE_FORWARD(pIter->pNode, 0);
1,614,687✔
286
    if (pIter->pNode == pIter->pTbData->sl.pTail) {
1,614,685✔
287
      return false;
6,335✔
288
    }
289
  }
290

291
  return true;
1,631,864✔
292
}
293

294
int64_t tsdbCountTbDataRows(STbData *pTbData) {
×
295
  SMemSkipListNode *pNode = pTbData->sl.pHead;
×
296
  int64_t           rowsNum = 0;
×
297

298
  while (NULL != pNode) {
×
299
    pNode = SL_GET_NODE_FORWARD(pNode, 0);
×
300
    if (pNode == pTbData->sl.pTail) {
×
301
      return rowsNum;
×
302
    }
303

304
    rowsNum++;
×
305
  }
306

307
  return rowsNum;
×
308
}
309

310
void tsdbMemTableCountRows(SMemTable *pMemTable, SSHashObj *pTableMap, int64_t *rowsNum) {
×
311
  taosRLockLatch(&pMemTable->latch);
×
312
  for (int32_t i = 0; i < pMemTable->nBucket; ++i) {
×
313
    STbData *pTbData = pMemTable->aBucket[i];
×
314
    while (pTbData) {
×
315
      void *p = tSimpleHashGet(pTableMap, &pTbData->uid, sizeof(pTbData->uid));
×
316
      if (p == NULL) {
×
317
        pTbData = pTbData->next;
×
318
        continue;
×
319
      }
320

321
      *rowsNum += tsdbCountTbDataRows(pTbData);
×
322
      pTbData = pTbData->next;
×
323
    }
324
  }
325
  taosRUnLockLatch(&pMemTable->latch);
×
326
}
×
327

328
typedef int32_t (*__tsdb_cache_update)(SMemTable *imem, int64_t suid, int64_t uid);
329

330
int32_t tsdbMemTableSaveToCache(SMemTable *pMemTable, void *func) {
5✔
331
  int32_t             code = 0;
5✔
332
  __tsdb_cache_update cb = (__tsdb_cache_update)func;
5✔
333

334
  for (int32_t i = 0; i < pMemTable->nBucket; ++i) {
5,125✔
335
    STbData *pTbData = pMemTable->aBucket[i];
5,120✔
336
    while (pTbData) {
5,135✔
337
      code = (*cb)(pMemTable, pTbData->suid, pTbData->uid);
15✔
338
      if (code) {
15!
339
        TAOS_RETURN(code);
×
340
      }
341

342
      pTbData = pTbData->next;
15✔
343
    }
344
  }
345

346
  return code;
5✔
347
}
348

UNCOV
349
static int32_t tsdbMemTableRehash(SMemTable *pMemTable) {
×
UNCOV
350
  int32_t code = 0;
×
351

UNCOV
352
  int32_t   nBucket = pMemTable->nBucket * 2;
×
UNCOV
353
  STbData **aBucket = (STbData **)taosMemoryCalloc(nBucket, sizeof(STbData *));
×
UNCOV
354
  if (aBucket == NULL) {
×
355
    code = terrno;
×
356
    goto _exit;
×
357
  }
358

UNCOV
359
  for (int32_t iBucket = 0; iBucket < pMemTable->nBucket; iBucket++) {
×
UNCOV
360
    STbData *pTbData = pMemTable->aBucket[iBucket];
×
361

UNCOV
362
    while (pTbData) {
×
UNCOV
363
      STbData *pNext = pTbData->next;
×
364

UNCOV
365
      int32_t idx = TABS(pTbData->uid) % nBucket;
×
UNCOV
366
      pTbData->next = aBucket[idx];
×
UNCOV
367
      aBucket[idx] = pTbData;
×
368

UNCOV
369
      pTbData = pNext;
×
370
    }
371
  }
372

UNCOV
373
  taosMemoryFree(pMemTable->aBucket);
×
UNCOV
374
  pMemTable->nBucket = nBucket;
×
UNCOV
375
  pMemTable->aBucket = aBucket;
×
376

UNCOV
377
_exit:
×
UNCOV
378
  return code;
×
379
}
380

381
static int32_t tsdbGetOrCreateTbData(SMemTable *pMemTable, tb_uid_t suid, tb_uid_t uid, STbData **ppTbData) {
44,980✔
382
  int32_t code = 0;
44,980✔
383

384
  // get
385
  STbData *pTbData = tsdbGetTbDataFromMemTableImpl(pMemTable, suid, uid);
44,980✔
386
  if (pTbData) goto _exit;
44,980✔
387

388
  // create
389
  SVBufPool *pPool = pMemTable->pTsdb->pVnode->inUse;
132✔
390
  int8_t     maxLevel = pMemTable->pTsdb->pVnode->config.tsdbCfg.slLevel;
132✔
391

392
  pTbData = vnodeBufPoolMallocAligned(pPool, sizeof(*pTbData) + SL_NODE_SIZE(maxLevel) * 2);
132✔
393
  if (pTbData == NULL) {
132!
394
    code = terrno;
×
395
    goto _exit;
×
396
  }
397
  pTbData->suid = suid;
132✔
398
  pTbData->uid = uid;
132✔
399
  pTbData->minKey = TSKEY_MAX;
132✔
400
  pTbData->maxKey = TSKEY_MIN;
132✔
401
  pTbData->pHead = NULL;
132✔
402
  pTbData->pTail = NULL;
132✔
403
  pTbData->sl.seed = taosRand();
132✔
404
  pTbData->sl.size = 0;
132✔
405
  pTbData->sl.maxLevel = maxLevel;
132✔
406
  pTbData->sl.level = 0;
132✔
407
  pTbData->sl.pHead = (SMemSkipListNode *)&pTbData[1];
132✔
408
  pTbData->sl.pTail = (SMemSkipListNode *)POINTER_SHIFT(pTbData->sl.pHead, SL_NODE_SIZE(maxLevel));
132✔
409
  pTbData->sl.pHead->level = maxLevel;
132✔
410
  pTbData->sl.pTail->level = maxLevel;
132✔
411
  for (int8_t iLevel = 0; iLevel < maxLevel; iLevel++) {
792✔
412
    SL_NODE_FORWARD(pTbData->sl.pHead, iLevel) = pTbData->sl.pTail;
660✔
413
    SL_NODE_BACKWARD(pTbData->sl.pTail, iLevel) = pTbData->sl.pHead;
660✔
414

415
    SL_NODE_BACKWARD(pTbData->sl.pHead, iLevel) = NULL;
660✔
416
    SL_NODE_FORWARD(pTbData->sl.pTail, iLevel) = NULL;
660✔
417
  }
418
  taosInitRWLatch(&pTbData->lock);
132✔
419

420
  taosWLockLatch(&pMemTable->latch);
132✔
421

422
  if (pMemTable->nTbData >= pMemTable->nBucket) {
132!
UNCOV
423
    code = tsdbMemTableRehash(pMemTable);
×
UNCOV
424
    if (code) {
×
425
      taosWUnLockLatch(&pMemTable->latch);
×
426
      goto _exit;
×
427
    }
428
  }
429

430
  int32_t idx = TABS(uid) % pMemTable->nBucket;
132✔
431
  pTbData->next = pMemTable->aBucket[idx];
132✔
432
  pMemTable->aBucket[idx] = pTbData;
132✔
433
  pMemTable->nTbData++;
132✔
434

435
  if (tRBTreePut(pMemTable->tbDataTree, pTbData->rbtn) == NULL) {
132!
436
    taosWUnLockLatch(&pMemTable->latch);
×
437
    code = TSDB_CODE_INTERNAL_ERROR;
×
438
    goto _exit;
×
439
  }
440

441
  taosWUnLockLatch(&pMemTable->latch);
132✔
442

443
_exit:
44,980✔
444
  if (code) {
44,980!
445
    *ppTbData = NULL;
×
446
  } else {
447
    *ppTbData = pTbData;
44,980✔
448
  }
449
  return code;
44,980✔
450
}
451

452
static void tbDataMovePosTo(STbData *pTbData, SMemSkipListNode **pos, STsdbRowKey *pKey, int32_t flags) {
56,528✔
453
  SMemSkipListNode *px;
454
  SMemSkipListNode *pn;
455
  STsdbRowKey       tKey;
456
  int32_t           backward = flags & SL_MOVE_BACKWARD;
56,528✔
457
  int32_t           fromPos = flags & SL_MOVE_FROM_POS;
56,528✔
458

459
  if (backward) {
56,528✔
460
    px = pTbData->sl.pTail;
45,007✔
461

462
    if (!fromPos) {
45,007!
463
      for (int8_t iLevel = pTbData->sl.level; iLevel < pTbData->sl.maxLevel; iLevel++) {
56,109✔
464
        pos[iLevel] = px;
11,102✔
465
      }
466
    }
467

468
    if (pTbData->sl.level) {
45,007✔
469
      if (fromPos) px = pos[pTbData->sl.level - 1];
44,875!
470

471
      for (int8_t iLevel = pTbData->sl.level - 1; iLevel >= 0; iLevel--) {
258,808✔
472
        pn = SL_GET_NODE_BACKWARD(px, iLevel);
213,933✔
473
        while (pn != pTbData->sl.pHead) {
220,793✔
474
          tsdbRowGetKey(&pn->row, &tKey);
220,355✔
475

476
          int32_t c = tsdbRowKeyCmpr(&tKey, pKey);
220,355✔
477
          if (c <= 0) {
220,355✔
478
            break;
213,495✔
479
          } else {
480
            px = pn;
6,860✔
481
            pn = SL_GET_NODE_BACKWARD(px, iLevel);
6,860✔
482
          }
483
        }
484

485
        pos[iLevel] = px;
213,933✔
486
      }
487
    }
488
  } else {
489
    px = pTbData->sl.pHead;
11,521✔
490

491
    if (!fromPos) {
11,521!
492
      for (int8_t iLevel = pTbData->sl.level; iLevel < pTbData->sl.maxLevel; iLevel++) {
17,901✔
493
        pos[iLevel] = px;
6,380✔
494
      }
495
    }
496

497
    if (pTbData->sl.level) {
11,521!
498
      if (fromPos) px = pos[pTbData->sl.level - 1];
11,521!
499

500
      for (int8_t iLevel = pTbData->sl.level - 1; iLevel >= 0; iLevel--) {
62,744✔
501
        pn = SL_GET_NODE_FORWARD(px, iLevel);
51,224✔
502
        while (pn != pTbData->sl.pTail) {
62,336✔
503
          tsdbRowGetKey(&pn->row, &tKey);
59,818✔
504

505
          int32_t c = tsdbRowKeyCmpr(&tKey, pKey);
59,817✔
506
          if (c >= 0) {
59,817✔
507
            break;
48,705✔
508
          } else {
509
            px = pn;
11,112✔
510
            pn = SL_GET_NODE_FORWARD(px, iLevel);
11,112✔
511
          }
512
        }
513

514
        pos[iLevel] = px;
51,223✔
515
      }
516
    }
517
  }
518
}
56,527✔
519

520
static FORCE_INLINE int8_t tsdbMemSkipListRandLevel(SMemSkipList *pSl) {
521
  int8_t level = 1;
48,980✔
522
  int8_t tlevel = TMIN(pSl->maxLevel, pSl->level + 1);
48,980✔
523

524
  while ((taosRandR(&pSl->seed) & 0x3) == 0 && level < tlevel) {
65,261✔
525
    level++;
16,281✔
526
  }
527

528
  return level;
48,980✔
529
}
530
static int32_t tbDataDoPut(SMemTable *pMemTable, STbData *pTbData, SMemSkipListNode **pos, TSDBROW *pRow,
48,980✔
531
                           int8_t forward) {
532
  int32_t           code = 0;
48,980✔
533
  int8_t            level;
534
  SMemSkipListNode *pNode = NULL;
48,980✔
535
  SVBufPool        *pPool = pMemTable->pTsdb->pVnode->inUse;
48,980✔
536
  int64_t           nSize;
537

538
  // create node
539
  level = tsdbMemSkipListRandLevel(&pTbData->sl);
48,980✔
540
  nSize = SL_NODE_SIZE(level);
48,980✔
541
  if (pRow->type == TSDBROW_ROW_FMT) {
48,980!
542
    pNode = (SMemSkipListNode *)vnodeBufPoolMallocAligned(pPool, nSize + pRow->pTSRow->len);
48,980✔
543
  } else if (pRow->type == TSDBROW_COL_FMT) {
×
UNCOV
544
    pNode = (SMemSkipListNode *)vnodeBufPoolMallocAligned(pPool, nSize);
×
545
  }
546
  if (pNode == NULL) {
48,980!
547
    code = terrno;
×
548
    goto _exit;
×
549
  }
550

551
  pNode->level = level;
48,980✔
552
  pNode->row = *pRow;
48,980✔
553
  if (pRow->type == TSDBROW_ROW_FMT) {
48,980!
554
    pNode->row.pTSRow = (SRow *)((char *)pNode + nSize);
48,980✔
555
    memcpy(pNode->row.pTSRow, pRow->pTSRow, pRow->pTSRow->len);
48,980✔
556
  }
557

558
  // set node
559
  if (forward) {
48,980✔
560
    for (int8_t iLevel = 0; iLevel < level; iLevel++) {
9,343✔
561
      SL_NODE_FORWARD(pNode, iLevel) = SL_NODE_FORWARD(pos[iLevel], iLevel);
5,343✔
562
      SL_NODE_BACKWARD(pNode, iLevel) = pos[iLevel];
5,343✔
563
    }
564
  } else {
565
    for (int8_t iLevel = 0; iLevel < level; iLevel++) {
104,898✔
566
      SL_NODE_FORWARD(pNode, iLevel) = pos[iLevel];
59,918✔
567
      SL_NODE_BACKWARD(pNode, iLevel) = SL_NODE_BACKWARD(pos[iLevel], iLevel);
59,918✔
568
    }
569
  }
570

571
  // set forward and backward
572
  if (forward) {
48,980✔
573
    for (int8_t iLevel = level - 1; iLevel >= 0; iLevel--) {
9,343✔
574
      SMemSkipListNode *pNext = pos[iLevel]->forwards[iLevel];
5,343✔
575

576
      SL_SET_NODE_FORWARD(pos[iLevel], iLevel, pNode);
5,343✔
577
      SL_SET_NODE_BACKWARD(pNext, iLevel, pNode);
5,343✔
578

579
      pos[iLevel] = pNode;
5,343✔
580
    }
581
  } else {
582
    for (int8_t iLevel = level - 1; iLevel >= 0; iLevel--) {
104,898✔
583
      SMemSkipListNode *pPrev = pos[iLevel]->forwards[pos[iLevel]->level + iLevel];
59,918✔
584

585
      SL_SET_NODE_FORWARD(pPrev, iLevel, pNode);
59,918✔
586
      SL_SET_NODE_BACKWARD(pos[iLevel], iLevel, pNode);
59,918✔
587

588
      pos[iLevel] = pNode;
59,918✔
589
    }
590
  }
591

592
  pTbData->sl.size++;
48,980✔
593
  if (pTbData->sl.level < pNode->level) {
48,980✔
594
    pTbData->sl.level = pNode->level;
322✔
595
  }
596

597
_exit:
48,658✔
598
  return code;
48,980✔
599
}
600

UNCOV
601
static int32_t tsdbInsertColDataToTable(SMemTable *pMemTable, STbData *pTbData, int64_t version,
×
602
                                        SSubmitTbData *pSubmitTbData, int32_t *affectedRows) {
UNCOV
603
  int32_t code = 0;
×
604

UNCOV
605
  SVBufPool *pPool = pMemTable->pTsdb->pVnode->inUse;
×
UNCOV
606
  int32_t    nColData = TARRAY_SIZE(pSubmitTbData->aCol);
×
UNCOV
607
  SColData  *aColData = (SColData *)TARRAY_DATA(pSubmitTbData->aCol);
×
608

609
  // copy and construct block data
UNCOV
610
  SBlockData *pBlockData = vnodeBufPoolMalloc(pPool, sizeof(*pBlockData));
×
UNCOV
611
  if (pBlockData == NULL) {
×
612
    code = terrno;
×
613
    goto _exit;
×
614
  }
615

UNCOV
616
  pBlockData->suid = pTbData->suid;
×
UNCOV
617
  pBlockData->uid = pTbData->uid;
×
UNCOV
618
  pBlockData->nRow = aColData[0].nVal;
×
UNCOV
619
  pBlockData->aUid = NULL;
×
UNCOV
620
  pBlockData->aVersion = vnodeBufPoolMalloc(pPool, aColData[0].nData);
×
UNCOV
621
  if (pBlockData->aVersion == NULL) {
×
622
    code = terrno;
×
623
    goto _exit;
×
624
  }
UNCOV
625
  for (int32_t i = 0; i < pBlockData->nRow; i++) {  // todo: here can be optimized
×
UNCOV
626
    pBlockData->aVersion[i] = version;
×
627
  }
628

UNCOV
629
  pBlockData->aTSKEY = vnodeBufPoolMalloc(pPool, aColData[0].nData);
×
UNCOV
630
  if (pBlockData->aTSKEY == NULL) {
×
631
    code = terrno;
×
632
    goto _exit;
×
633
  }
UNCOV
634
  memcpy(pBlockData->aTSKEY, aColData[0].pData, aColData[0].nData);
×
635

UNCOV
636
  pBlockData->nColData = nColData - 1;
×
UNCOV
637
  pBlockData->aColData = vnodeBufPoolMalloc(pPool, sizeof(SColData) * pBlockData->nColData);
×
UNCOV
638
  if (pBlockData->aColData == NULL) {
×
639
    code = terrno;
×
640
    goto _exit;
×
641
  }
642

UNCOV
643
  for (int32_t iColData = 0; iColData < pBlockData->nColData; ++iColData) {
×
UNCOV
644
    code = tColDataCopy(&aColData[iColData + 1], &pBlockData->aColData[iColData], (xMallocFn)vnodeBufPoolMalloc, pPool);
×
UNCOV
645
    if (code) goto _exit;
×
646
  }
647

648
  // loop to add each row to the skiplist
649
  SMemSkipListNode *pos[SL_MAX_LEVEL];
UNCOV
650
  TSDBROW           tRow = tsdbRowFromBlockData(pBlockData, 0);
×
651
  STsdbRowKey       key;
652

653
  // first row
UNCOV
654
  tsdbRowGetKey(&tRow, &key);
×
UNCOV
655
  tbDataMovePosTo(pTbData, pos, &key, SL_MOVE_BACKWARD);
×
UNCOV
656
  if ((code = tbDataDoPut(pMemTable, pTbData, pos, &tRow, 0))) goto _exit;
×
UNCOV
657
  pTbData->minKey = TMIN(pTbData->minKey, key.key.ts);
×
658

659
  // remain row
UNCOV
660
  ++tRow.iRow;
×
UNCOV
661
  if (tRow.iRow < pBlockData->nRow) {
×
UNCOV
662
    for (int8_t iLevel = pos[0]->level; iLevel < pTbData->sl.maxLevel; iLevel++) {
×
UNCOV
663
      pos[iLevel] = SL_NODE_BACKWARD(pos[iLevel], iLevel);
×
664
    }
665

UNCOV
666
    while (tRow.iRow < pBlockData->nRow) {
×
UNCOV
667
      tsdbRowGetKey(&tRow, &key);
×
668

UNCOV
669
      if (SL_NODE_FORWARD(pos[0], 0) != pTbData->sl.pTail) {
×
UNCOV
670
        tbDataMovePosTo(pTbData, pos, &key, SL_MOVE_FROM_POS);
×
671
      }
672

UNCOV
673
      if ((code = tbDataDoPut(pMemTable, pTbData, pos, &tRow, 1))) goto _exit;
×
674

UNCOV
675
      ++tRow.iRow;
×
676
    }
677
  }
678

UNCOV
679
  if (key.key.ts >= pTbData->maxKey) {
×
UNCOV
680
    pTbData->maxKey = key.key.ts;
×
681
  }
682

UNCOV
683
  if (!TSDB_CACHE_NO(pMemTable->pTsdb->pVnode->config) && !tsUpdateCacheBatch) {
×
684
    if (tsdbCacheColFormatUpdate(pMemTable->pTsdb, pTbData->suid, pTbData->uid, pBlockData) != 0) {
×
685
      tsdbError("vgId:%d, failed to update cache data from table suid:%" PRId64 " uid:%" PRId64 " at version %" PRId64,
×
686
                TD_VID(pMemTable->pTsdb->pVnode), pTbData->suid, pTbData->uid, version);
687
    }
688
  }
689

690
  // SMemTable
UNCOV
691
  pMemTable->minKey = TMIN(pMemTable->minKey, pTbData->minKey);
×
UNCOV
692
  pMemTable->maxKey = TMAX(pMemTable->maxKey, pTbData->maxKey);
×
UNCOV
693
  pMemTable->nRow += pBlockData->nRow;
×
694

UNCOV
695
  if (affectedRows) *affectedRows = pBlockData->nRow;
×
696

697
_exit:
×
UNCOV
698
  return code;
×
699
}
700

701
static int32_t tsdbInsertRowDataToTable(SMemTable *pMemTable, STbData *pTbData, int64_t version,
44,980✔
702
                                        SSubmitTbData *pSubmitTbData, int32_t *affectedRows) {
703
  int32_t code = 0;
44,980✔
704

705
  int32_t           nRow = TARRAY_SIZE(pSubmitTbData->aRowP);
44,980✔
706
  SRow            **aRow = (SRow **)TARRAY_DATA(pSubmitTbData->aRowP);
44,980✔
707
  STsdbRowKey       key;
708
  SMemSkipListNode *pos[SL_MAX_LEVEL];
709
  TSDBROW           tRow = {.type = TSDBROW_ROW_FMT, .version = version};
44,980✔
710
  int32_t           iRow = 0;
44,980✔
711

712
  // backward put first data
713
  tRow.pTSRow = aRow[iRow++];
44,980✔
714
  tsdbRowGetKey(&tRow, &key);
44,980✔
715
  tbDataMovePosTo(pTbData, pos, &key, SL_MOVE_BACKWARD);
44,980✔
716
  code = tbDataDoPut(pMemTable, pTbData, pos, &tRow, 0);
44,980✔
717
  if (code) goto _exit;
44,980!
718

719
  pTbData->minKey = TMIN(pTbData->minKey, key.key.ts);
44,980✔
720

721
  // forward put rest data
722
  if (iRow < nRow) {
44,980✔
723
    for (int8_t iLevel = pos[0]->level; iLevel < pTbData->sl.maxLevel; iLevel++) {
18,661✔
724
      pos[iLevel] = SL_NODE_BACKWARD(pos[iLevel], iLevel);
14,661✔
725
    }
726

727
    while (iRow < nRow) {
8,000✔
728
      tRow.pTSRow = aRow[iRow];
4,000✔
729
      tsdbRowGetKey(&tRow, &key);
4,000✔
730

731
      if (SL_NODE_FORWARD(pos[0], 0) != pTbData->sl.pTail) {
4,000!
UNCOV
732
        tbDataMovePosTo(pTbData, pos, &key, SL_MOVE_FROM_POS);
×
733
      }
734

735
      code = tbDataDoPut(pMemTable, pTbData, pos, &tRow, 1);
4,000✔
736
      if (code) goto _exit;
4,000!
737

738
      iRow++;
4,000✔
739
    }
740
  }
741

742
  if (key.key.ts >= pTbData->maxKey) {
44,980✔
743
    pTbData->maxKey = key.key.ts;
44,280✔
744
  }
745
  if (!TSDB_CACHE_NO(pMemTable->pTsdb->pVnode->config) && !tsUpdateCacheBatch) {
44,980!
746
    TAOS_UNUSED(tsdbCacheRowFormatUpdate(pMemTable->pTsdb, pTbData->suid, pTbData->uid, version, nRow, aRow));
×
747
  }
748

749
  // SMemTable
750
  pMemTable->minKey = TMIN(pMemTable->minKey, pTbData->minKey);
44,980✔
751
  pMemTable->maxKey = TMAX(pMemTable->maxKey, pTbData->maxKey);
44,980✔
752
  pMemTable->nRow += nRow;
44,980✔
753

754
  if (affectedRows) *affectedRows = nRow;
44,980!
755

756
_exit:
×
757
  return code;
44,980✔
758
}
759

UNCOV
760
int32_t tsdbGetNRowsInTbData(STbData *pTbData) { return pTbData->sl.size; }
×
761

762
int32_t tsdbRefMemTable(SMemTable *pMemTable, SQueryNode *pQNode) {
16,987✔
763
  int32_t code = 0;
16,987✔
764

765
  int32_t nRef = atomic_fetch_add_32(&pMemTable->nRef, 1);
16,987✔
766
  if (nRef <= 0) {
16,995!
767
    tsdbError("vgId:%d, memtable ref count is invalid, ref:%d", TD_VID(pMemTable->pTsdb->pVnode), nRef);
×
768
  }
769

770
  vnodeBufPoolRegisterQuery(pMemTable->pPool, pQNode);
16,995✔
771

772
_exit:
16,995✔
773
  return code;
16,995✔
774
}
775

776
void tsdbUnrefMemTable(SMemTable *pMemTable, SQueryNode *pNode, bool proactive) {
17,009✔
777
  if (pNode) {
17,009✔
778
    vnodeBufPoolDeregisterQuery(pMemTable->pPool, pNode, proactive);
16,996✔
779
  }
780

781
  if (atomic_sub_fetch_32(&pMemTable->nRef, 1) == 0) {
17,009✔
782
    tsdbMemTableDestroy(pMemTable, proactive);
13✔
783
  }
784
}
17,009✔
785

786
static FORCE_INLINE int32_t tbDataPCmprFn(const void *p1, const void *p2) {
787
  STbData *pTbData1 = *(STbData **)p1;
788
  STbData *pTbData2 = *(STbData **)p2;
789

790
  if (pTbData1->suid < pTbData2->suid) {
791
    return -1;
792
  } else if (pTbData1->suid > pTbData2->suid) {
793
    return 1;
794
  }
795

796
  if (pTbData1->uid < pTbData2->uid) {
797
    return -1;
798
  } else if (pTbData1->uid > pTbData2->uid) {
799
    return 1;
800
  }
801

802
  return 0;
803
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc