• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3562

20 Dec 2024 09:57AM UTC coverage: 26.655% (-32.2%) from 58.812%
#3562

push

travis-ci

web-flow
Merge pull request #29229 from taosdata/enh/TS-5749-3.0

enh: seperate tsdb async tasks to different thread pools

21498 of 109421 branches covered (19.65%)

Branch coverage included in aggregate %.

66 of 96 new or added lines in 7 files covered. (68.75%)

39441 existing lines in 157 files now uncovered.

35007 of 102566 relevant lines covered (34.13%)

53922.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.81
/source/dnode/vnode/src/tsdb/tsdbCommit2.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tsdbCommit2.h"
17

18
// extern dependencies
19
typedef struct {
20
  int32_t    fid;
21
  STFileSet *fset;
22
} SFileSetCommitInfo;
23

24
typedef struct {
25
  STsdb  *tsdb;
26
  int32_t minutes;
27
  int8_t  precision;
28
  int32_t minRow;
29
  int32_t maxRow;
30
  int8_t  cmprAlg;
31
  int32_t sttTrigger;
32
  int32_t szPage;
33
  int64_t compactVersion;
34
  int64_t cid;
35
  int64_t now;
36

37
  struct {
38
    SFileSetCommitInfo *info;
39

40
    int32_t expLevel;
41
    SDiskID did;
42
    TSKEY   minKey;
43
    TSKEY   maxKey;
44
    TABLEID tbid[1];
45
    bool    hasTSData;
46

47
    bool      skipTsRow;
48
    SHashObj *pColCmprObj;
49
  } ctx[1];
50

51
  // reader
52
  TSttFileReaderArray sttReaderArray[1];
53
  // iter
54
  TTsdbIterArray dataIterArray[1];
55
  SIterMerger   *dataIterMerger;
56
  TTsdbIterArray tombIterArray[1];
57
  SIterMerger   *tombIterMerger;
58
  // writer
59
  SFSetWriter *writer;
60

61
  TFileOpArray fopArray[1];
62
} SCommitter2;
63

64
static int32_t tsdbCommitOpenWriter(SCommitter2 *committer) {
21✔
65
  int32_t code = 0;
21✔
66
  int32_t lino = 0;
21✔
67

68
  SFSetWriterConfig config = {
21✔
69
      .tsdb = committer->tsdb,
21✔
70
      .toSttOnly = true,
71
      .compactVersion = committer->compactVersion,
21✔
72
      .minRow = committer->minRow,
21✔
73
      .maxRow = committer->maxRow,
21✔
74
      .szPage = committer->szPage,
21✔
75
      .cmprAlg = committer->cmprAlg,
21✔
76
      .fid = committer->ctx->info->fid,
21✔
77
      .cid = committer->cid,
21✔
78
      .did = committer->ctx->did,
79
      .level = 0,
80
  };
81

82
  if (committer->sttTrigger == 1) {
21!
UNCOV
83
    config.toSttOnly = false;
×
84

UNCOV
85
    if (committer->ctx->info->fset) {
×
UNCOV
86
      for (int32_t ftype = TSDB_FTYPE_MIN; ftype < TSDB_FTYPE_MAX; ftype++) {
×
UNCOV
87
        if (committer->ctx->info->fset->farr[ftype] != NULL) {
×
UNCOV
88
          config.files[ftype].exist = true;
×
UNCOV
89
          config.files[ftype].file = committer->ctx->info->fset->farr[ftype]->f[0];
×
90
        }
91
      }
92
    }
93
  }
94

95
  TAOS_CHECK_GOTO(tsdbFSetWriterOpen(&config, &committer->writer), &lino, _exit);
21!
96

97
_exit:
21✔
98
  if (code) {
21!
99
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
100
              tstrerror(code));
101
  }
102
  return code;
21✔
103
}
104

105
static int32_t tsdbCommitCloseWriter(SCommitter2 *committer) {
21✔
106
  return tsdbFSetWriterClose(&committer->writer, 0, committer->fopArray);
21✔
107
}
108

109
static int32_t tsdbCommitTSData(SCommitter2 *committer) {
21✔
110
  int32_t   code = 0;
21✔
111
  int32_t   lino = 0;
21✔
112
  int64_t   numOfRow = 0;
21✔
113
  SMetaInfo info;
114

115
  committer->ctx->hasTSData = false;
21✔
116

117
  committer->ctx->tbid->suid = 0;
21✔
118
  committer->ctx->tbid->uid = 0;
21✔
119
  for (SRowInfo *row; (row = tsdbIterMergerGetData(committer->dataIterMerger)) != NULL;) {
11,925✔
120
    if (row->uid != committer->ctx->tbid->uid) {
11,874✔
121
      committer->ctx->tbid->suid = row->suid;
62✔
122
      committer->ctx->tbid->uid = row->uid;
62✔
123

124
      if (metaGetInfo(committer->tsdb->pVnode->pMeta, row->uid, &info, NULL) != 0) {
62!
125
        TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->dataIterMerger, committer->ctx->tbid), &lino, _exit);
×
UNCOV
126
        continue;
×
127
      }
128
    }
129

130
    int64_t ts = TSDBROW_TS(&row->row);
11,880!
131
    if (ts > committer->ctx->maxKey) {
11,880✔
132
      TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->dataIterMerger, committer->ctx->tbid), &lino, _exit);
35!
133
      continue;
35✔
134
    }
135

136
    committer->ctx->hasTSData = true;
11,845✔
137
    numOfRow++;
11,845✔
138

139
    TAOS_CHECK_GOTO(tsdbFSetWriteRow(committer->writer, row), &lino, _exit);
11,845!
140
    TAOS_CHECK_GOTO(tsdbIterMergerNext(committer->dataIterMerger), &lino, _exit);
11,876!
141
  }
142

143
_exit:
21✔
144
  if (code) {
21!
145
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
146
              tstrerror(code));
147
  } else {
148
    tsdbDebug("vgId:%d fid:%d commit %" PRId64 " rows", TD_VID(committer->tsdb->pVnode), committer->ctx->info->fid,
21✔
149
              numOfRow);
150
  }
151
  return code;
21✔
152
}
153

154
static int32_t tsdbCommitTombData(SCommitter2 *committer) {
21✔
155
  int32_t   code = 0;
21✔
156
  int32_t   lino = 0;
21✔
157
  int64_t   numRecord = 0;
21✔
158
  SMetaInfo info;
159

160
  // if no history data and no new timestamp data, skip tomb data
161
  if (committer->ctx->info->fset || committer->ctx->hasTSData) {
21!
162
    committer->ctx->tbid->suid = 0;
21✔
163
    committer->ctx->tbid->uid = 0;
21✔
164
    for (STombRecord *record; (record = tsdbIterMergerGetTombRecord(committer->tombIterMerger));) {
21!
UNCOV
165
      if (record->uid != committer->ctx->tbid->uid) {
×
UNCOV
166
        committer->ctx->tbid->suid = record->suid;
×
UNCOV
167
        committer->ctx->tbid->uid = record->uid;
×
168

UNCOV
169
        if (metaGetInfo(committer->tsdb->pVnode->pMeta, record->uid, &info, NULL) != 0) {
×
UNCOV
170
          TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->tombIterMerger, committer->ctx->tbid), &lino, _exit);
×
UNCOV
171
          continue;
×
172
        }
173
      }
174

UNCOV
175
      if (record->ekey < committer->ctx->minKey) {
×
176
        // do nothing
UNCOV
177
      } else if (record->skey > committer->ctx->maxKey) {
×
178
        // committer->ctx->nextKey = TMIN(record->skey, committer->ctx->nextKey);
179
      } else {
UNCOV
180
        record->skey = TMAX(record->skey, committer->ctx->minKey);
×
UNCOV
181
        record->ekey = TMIN(record->ekey, committer->ctx->maxKey);
×
182

UNCOV
183
        numRecord++;
×
UNCOV
184
        TAOS_CHECK_GOTO(tsdbFSetWriteTombRecord(committer->writer, record), &lino, _exit);
×
185
      }
186

UNCOV
187
      TAOS_CHECK_GOTO(tsdbIterMergerNext(committer->tombIterMerger), &lino, _exit);
×
188
    }
189
  }
190

191
_exit:
21✔
192
  if (code) {
21!
193
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
194
              tstrerror(code));
195
  } else {
196
    tsdbDebug("vgId:%d fid:%d commit %" PRId64 " tomb records", TD_VID(committer->tsdb->pVnode),
21✔
197
              committer->ctx->info->fid, numRecord);
198
  }
199
  return code;
21✔
200
}
201

202
static void tsdbCommitCloseReader(SCommitter2 *committer) {
21✔
203
  TARRAY2_CLEAR(committer->sttReaderArray, tsdbSttFileReaderClose);
21!
204
  return;
21✔
205
}
206

207
static int32_t tsdbCommitOpenReader(SCommitter2 *committer) {
21✔
208
  int32_t code = 0;
21✔
209
  int32_t lino = 0;
21✔
210

211
  if (committer->ctx->info->fset == NULL                        //
21✔
212
      || committer->sttTrigger > 1                              //
5!
UNCOV
213
      || TARRAY2_SIZE(committer->ctx->info->fset->lvlArr) == 0  //
×
214
  ) {
215
    return 0;
21✔
216
  }
217

218
  SSttLvl *lvl;
UNCOV
219
  TARRAY2_FOREACH(committer->ctx->info->fset->lvlArr, lvl) {
×
UNCOV
220
    STFileObj *fobj = NULL;
×
UNCOV
221
    TARRAY2_FOREACH(lvl->fobjArr, fobj) {
×
222
      SSttFileReader *sttReader;
223

UNCOV
224
      SSttFileReaderConfig config = {
×
UNCOV
225
          .tsdb = committer->tsdb,
×
UNCOV
226
          .szPage = committer->szPage,
×
227
          .file = fobj->f[0],
228
      };
229

UNCOV
230
      TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &sttReader), &lino, _exit);
×
231

UNCOV
232
      TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->sttReaderArray, sttReader), &lino, _exit);
×
233

UNCOV
234
      STFileOp op = {
×
235
          .optype = TSDB_FOP_REMOVE,
UNCOV
236
          .fid = fobj->f->fid,
×
237
          .of = fobj->f[0],
238
      };
239

UNCOV
240
      TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->fopArray, op), &lino, _exit);
×
241
    }
242
  }
243

UNCOV
244
_exit:
×
UNCOV
245
  if (code) {
×
246
    tsdbCommitCloseReader(committer);
×
247
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
248
              tstrerror(code));
249
  }
UNCOV
250
  return code;
×
251
}
252

253
static void tsdbCommitCloseIter(SCommitter2 *committer) {
21✔
254
  tsdbIterMergerClose(&committer->tombIterMerger);
21✔
255
  tsdbIterMergerClose(&committer->dataIterMerger);
21✔
256
  TARRAY2_CLEAR(committer->tombIterArray, tsdbIterClose);
42!
257
  TARRAY2_CLEAR(committer->dataIterArray, tsdbIterClose);
42!
258
  return;
21✔
259
}
260

261
static int32_t tsdbCommitOpenIter(SCommitter2 *committer) {
21✔
262
  int32_t code = 0;
21✔
263
  int32_t lino = 0;
21✔
264

265
  STsdbIter      *iter;
266
  STsdbIterConfig config = {0};
21✔
267

268
  // mem data iter
269
  config.type = TSDB_ITER_TYPE_MEMT;
21✔
270
  config.memt = committer->tsdb->imem;
21✔
271
  config.from->version = VERSION_MIN;
21✔
272
  config.from->key = (SRowKey){
21✔
273
      .ts = committer->ctx->minKey,
21✔
274
      .numOfPKs = 0,
275
  };
276

277
  TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
21!
278
  TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->dataIterArray, iter), &lino, _exit);
42!
279

280
  // mem tomb iter
281
  config.type = TSDB_ITER_TYPE_MEMT_TOMB;
21✔
282
  config.memt = committer->tsdb->imem;
21✔
283

284
  TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
21!
285
  TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->tombIterArray, iter), &lino, _exit);
42!
286

287
  // STT
288
  SSttFileReader *sttReader;
289
  TARRAY2_FOREACH(committer->sttReaderArray, sttReader) {
21!
290
    // data iter
UNCOV
291
    config.type = TSDB_ITER_TYPE_STT;
×
UNCOV
292
    config.sttReader = sttReader;
×
293

UNCOV
294
    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
×
UNCOV
295
    TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->dataIterArray, iter), &lino, _exit);
×
296

297
    // tomb iter
UNCOV
298
    config.type = TSDB_ITER_TYPE_STT_TOMB;
×
UNCOV
299
    config.sttReader = sttReader;
×
300

UNCOV
301
    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
×
302

UNCOV
303
    TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->tombIterArray, iter), &lino, _exit);
×
304
  }
305

306
  // open merger
307
  TAOS_CHECK_GOTO(tsdbIterMergerOpen(committer->dataIterArray, &committer->dataIterMerger, false), &lino, _exit);
21!
308
  TAOS_CHECK_GOTO(tsdbIterMergerOpen(committer->tombIterArray, &committer->tombIterMerger, true), &lino, _exit);
21!
309

310
_exit:
21✔
311
  if (code) {
21!
312
    tsdbCommitCloseIter(committer);
×
313
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
314
              tstrerror(code));
315
  }
316
  return code;
21✔
317
}
318

319
static int32_t tsdbCommitFileSetBegin(SCommitter2 *committer) {
21✔
320
  int32_t code = 0;
21✔
321
  int32_t lino = 0;
21✔
322
  STsdb  *tsdb = committer->tsdb;
21✔
323

324
  // check if can commit
325
  tsdbFSCheckCommit(tsdb, committer->ctx->info->fid);
21✔
326

327
  committer->ctx->expLevel = tsdbFidLevel(committer->ctx->info->fid, &tsdb->keepCfg, committer->now);
21✔
328
  tsdbFidKeyRange(committer->ctx->info->fid, committer->minutes, committer->precision, &committer->ctx->minKey,
21✔
329
                  &committer->ctx->maxKey);
330

331
  TAOS_CHECK_GOTO(tfsAllocDisk(committer->tsdb->pVnode->pTfs, committer->ctx->expLevel, &committer->ctx->did), &lino,
21!
332
                  _exit);
333

334
  if (tfsMkdirRecurAt(committer->tsdb->pVnode->pTfs, committer->tsdb->path, committer->ctx->did) != 0) {
21!
335
    tsdbError("vgId:%d failed to create directory %s", TD_VID(committer->tsdb->pVnode), committer->tsdb->path);
×
336
  }
337
  committer->ctx->tbid->suid = 0;
21✔
338
  committer->ctx->tbid->uid = 0;
21✔
339

340
  TAOS_CHECK_GOTO(tsdbCommitOpenReader(committer), &lino, _exit);
21!
341
  TAOS_CHECK_GOTO(tsdbCommitOpenIter(committer), &lino, _exit);
21!
342
  TAOS_CHECK_GOTO(tsdbCommitOpenWriter(committer), &lino, _exit);
21!
343

344
_exit:
21✔
345
  if (code) {
21!
346
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
347
  } else {
348
    tsdbDebug("vgId:%d %s done, fid:%d minKey:%" PRId64 " maxKey:%" PRId64 " expLevel:%d", TD_VID(tsdb->pVnode),
21✔
349
              __func__, committer->ctx->info->fid, committer->ctx->minKey, committer->ctx->maxKey,
350
              committer->ctx->expLevel);
351
  }
352
  return code;
21✔
353
}
354

355
static int32_t tsdbCommitFileSetEnd(SCommitter2 *committer) {
21✔
356
  int32_t code = 0;
21✔
357
  int32_t lino = 0;
21✔
358

359
  TAOS_CHECK_GOTO(tsdbCommitCloseWriter(committer), &lino, _exit);
21!
360
  tsdbCommitCloseIter(committer);
21✔
361
  tsdbCommitCloseReader(committer);
21✔
362

363
_exit:
21✔
364
  if (code) {
21!
365
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
366
              tstrerror(code));
367
  } else {
368
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(committer->tsdb->pVnode), __func__, committer->ctx->info->fid);
21✔
369
  }
370
  return code;
21✔
371
}
372

373
static int32_t tsdbCommitFileSet(SCommitter2 *committer) {
21✔
374
  int32_t code = 0;
21✔
375
  int32_t lino = 0;
21✔
376

377
  TAOS_CHECK_GOTO(tsdbCommitFileSetBegin(committer), &lino, _exit);
21!
378
  TAOS_CHECK_GOTO(tsdbCommitTSData(committer), &lino, _exit);
21!
379
  TAOS_CHECK_GOTO(tsdbCommitTombData(committer), &lino, _exit);
21!
380
  TAOS_CHECK_GOTO(tsdbCommitFileSetEnd(committer), &lino, _exit);
21!
381

382
_exit:
21✔
383
  if (code) {
21!
384
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
385
              tstrerror(code));
386
  } else {
387
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(committer->tsdb->pVnode), __func__, committer->ctx->info->fid);
21✔
388
  }
389
  return code;
21✔
390
}
391

392
static int32_t tFileSetCommitInfoCompare(const void *arg1, const void *arg2) {
81✔
393
  SFileSetCommitInfo *info1 = (SFileSetCommitInfo *)arg1;
81✔
394
  SFileSetCommitInfo *info2 = (SFileSetCommitInfo *)arg2;
81✔
395

396
  if (info1->fid < info2->fid) {
81✔
397
    return -1;
19✔
398
  } else if (info1->fid > info2->fid) {
62!
UNCOV
399
    return 1;
×
400
  } else {
401
    return 0;
62✔
402
  }
403
}
404

405
static int32_t tFileSetCommitInfoPCompare(const void *arg1, const void *arg2) {
19✔
406
  return tFileSetCommitInfoCompare(*(SFileSetCommitInfo **)arg1, *(SFileSetCommitInfo **)arg2);
19✔
407
}
408

409
static uint32_t tFileSetCommitInfoHash(const void *arg) {
104✔
410
  SFileSetCommitInfo *info = (SFileSetCommitInfo *)arg;
104✔
411
  return MurmurHash3_32((const char *)&info->fid, sizeof(info->fid));
104✔
412
}
413

414
static void tsdbCommitInfoDestroy(STsdb *pTsdb) {
10✔
415
  if (pTsdb->commitInfo) {
10!
416
    for (int32_t i = 0; i < taosArrayGetSize(pTsdb->commitInfo->arr); i++) {
31✔
417
      SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(pTsdb->commitInfo->arr, i);
21✔
418
      int32_t             ret = vHashDrop(pTsdb->commitInfo->ht, info);
21✔
419
      tsdbTFileSetClear(&info->fset);
21✔
420
      taosMemoryFree(info);
21!
421
    }
422

423
    vHashDestroy(&pTsdb->commitInfo->ht);
10✔
424
    taosArrayDestroy(pTsdb->commitInfo->arr);
10✔
425
    pTsdb->commitInfo->arr = NULL;
10✔
426
    taosMemoryFreeClear(pTsdb->commitInfo);
10!
427
  }
428
  return;
10✔
429
}
430

431
static int32_t tsdbCommitInfoInit(STsdb *pTsdb) {
10✔
432
  int32_t code = 0;
10✔
433
  int32_t lino = 0;
10✔
434

435
  pTsdb->commitInfo = taosMemoryCalloc(1, sizeof(*pTsdb->commitInfo));
10!
436
  if (pTsdb->commitInfo == NULL) {
10!
437
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
438
  }
439

440
  TAOS_CHECK_GOTO(vHashInit(&pTsdb->commitInfo->ht, tFileSetCommitInfoHash, tFileSetCommitInfoCompare), &lino, _exit);
10!
441

442
  pTsdb->commitInfo->arr = taosArrayInit(0, sizeof(SFileSetCommitInfo *));
10✔
443
  if (pTsdb->commitInfo->arr == NULL) {
10!
444
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
445
  }
446

447
_exit:
10✔
448
  if (code) {
10!
449
    tsdbCommitInfoDestroy(pTsdb);
×
450
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(pTsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
451
  }
452
  return code;
10✔
453
}
454

455
static int32_t tsdbCommitInfoAdd(STsdb *tsdb, int32_t fid) {
21✔
456
  int32_t code = 0;
21✔
457
  int32_t lino = 0;
21✔
458

459
  SFileSetCommitInfo *tinfo;
460

461
  if ((tinfo = taosMemoryMalloc(sizeof(*tinfo))) == NULL) {
21!
462
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
463
  }
464
  tinfo->fid = fid;
21✔
465
  tinfo->fset = NULL;
21✔
466

467
  TAOS_CHECK_GOTO(vHashPut(tsdb->commitInfo->ht, tinfo), &lino, _exit);
21!
468

469
  if ((taosArrayPush(tsdb->commitInfo->arr, &tinfo)) == NULL) {
42!
470
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
471
  }
472
  taosArraySort(tsdb->commitInfo->arr, tFileSetCommitInfoPCompare);
21✔
473

474
_exit:
21✔
475
  if (code) {
21!
476
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
477
  }
478
  return code;
21✔
479
}
480

481
static int32_t tsdbCommitInfoBuild(STsdb *tsdb) {
10✔
482
  int32_t code = 0;
10✔
483
  int32_t lino = 0;
10✔
484

485
  STFileSet  *fset = NULL;
10✔
486
  SRBTreeIter iter;
487

488
  TAOS_CHECK_GOTO(tsdbCommitInfoInit(tsdb), &lino, _exit);
10!
489

490
  // scan time-series data
491
  iter = tRBTreeIterCreate(tsdb->imem->tbDataTree, 1);
10✔
492
  for (SRBTreeNode *node = tRBTreeIterNext(&iter); node; node = tRBTreeIterNext(&iter)) {
37✔
493
    STbData *pTbData = TCONTAINER_OF(node, STbData, rbtn);
27✔
494

495
    // scan time-series data
496
    STsdbRowKey from = {
27✔
497
        .key.ts = INT64_MIN,
498
        .key.numOfPKs = 0,
499
        .version = INT64_MIN,
500
    };
501
    for (;;) {
62✔
502
      int64_t     minKey, maxKey;
503
      STbDataIter tbDataIter = {0};
89✔
504
      TSDBROW    *row;
505
      int32_t     fid;
506

507
      tsdbTbDataIterOpen(pTbData, &from, 0, &tbDataIter);
89✔
508
      if ((row = tsdbTbDataIterGet(&tbDataIter)) == NULL) {
89✔
509
        break;
27✔
510
      }
511

512
      fid = tsdbKeyFid(TSDBROW_TS(row), tsdb->keepCfg.days, tsdb->keepCfg.precision);
62!
513
      tsdbFidKeyRange(fid, tsdb->keepCfg.days, tsdb->keepCfg.precision, &minKey, &maxKey);
62✔
514

515
      SFileSetCommitInfo *info;
516
      SFileSetCommitInfo  tinfo = {
62✔
517
           .fid = fid,
518
      };
519
      int32_t ret = vHashGet(tsdb->commitInfo->ht, &tinfo, (void **)&info);
62✔
520
      if (info == NULL) {
62✔
521
        TAOS_CHECK_GOTO(tsdbCommitInfoAdd(tsdb, fid), &lino, _exit);
21!
522
      }
523

524
      from.key.ts = maxKey + 1;
62✔
525
    }
526
  }
527

528
  (void)taosThreadMutexLock(&tsdb->mutex);
10✔
529

530
  // scan tomb data
531
  if (tsdb->imem->nDel > 0) {
10!
UNCOV
532
    TARRAY2_FOREACH(tsdb->pFS->fSetArr, fset) {
×
UNCOV
533
      if (tsdbTFileSetIsEmpty(fset)) {
×
UNCOV
534
        continue;
×
535
      }
536

537
      SFileSetCommitInfo *info;
UNCOV
538
      SFileSetCommitInfo  tinfo = {
×
UNCOV
539
           .fid = fset->fid,
×
540
      };
541

542
      // check if the file set already on the commit list
UNCOV
543
      int32_t ret = vHashGet(tsdb->commitInfo->ht, &tinfo, (void **)&info);
×
UNCOV
544
      if (info != NULL) {
×
UNCOV
545
        continue;
×
546
      }
547

548
      int64_t minKey, maxKey;
UNCOV
549
      bool    hasDataToCommit = false;
×
UNCOV
550
      tsdbFidKeyRange(fset->fid, tsdb->keepCfg.days, tsdb->keepCfg.precision, &minKey, &maxKey);
×
UNCOV
551
      iter = tRBTreeIterCreate(tsdb->imem->tbDataTree, 1);
×
UNCOV
552
      for (SRBTreeNode *node = tRBTreeIterNext(&iter); node; node = tRBTreeIterNext(&iter)) {
×
UNCOV
553
        STbData *pTbData = TCONTAINER_OF(node, STbData, rbtn);
×
UNCOV
554
        for (SDelData *pDelData = pTbData->pHead; pDelData; pDelData = pDelData->pNext) {
×
UNCOV
555
          if (pDelData->sKey > maxKey || pDelData->eKey < minKey) {
×
UNCOV
556
            continue;
×
557
          } else {
UNCOV
558
            hasDataToCommit = true;
×
UNCOV
559
            if ((code = tsdbCommitInfoAdd(tsdb, fset->fid))) {
×
560
              (void)taosThreadMutexUnlock(&tsdb->mutex);
×
561
              TSDB_CHECK_CODE(code, lino, _exit);
×
562
            }
UNCOV
563
            break;
×
564
          }
565
        }
566

UNCOV
567
        if (hasDataToCommit) {
×
UNCOV
568
          break;
×
569
        }
570
      }
571
    }
572
  }
573

574
  // begin tasks on file set
575
  for (int i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
31✔
576
    SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
21✔
577
    tsdbBeginTaskOnFileSet(tsdb, info->fid, EVA_TASK_COMMIT, &fset);
21✔
578
    if (fset) {
21✔
579
      code = tsdbTFileSetInitCopy(tsdb, fset, &info->fset);
5✔
580
      if (code) {
5!
581
        (void)taosThreadMutexUnlock(&tsdb->mutex);
×
582
        TAOS_CHECK_GOTO(code, &lino, _exit);
×
583
      }
584
    }
585
  }
586

587
  (void)taosThreadMutexUnlock(&tsdb->mutex);
10✔
588

589
_exit:
10✔
590
  if (code) {
10!
591
    tsdbCommitInfoDestroy(tsdb);
×
592
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
593
  }
594
  return code;
10✔
595
}
596

597
static int32_t tsdbOpenCommitter(STsdb *tsdb, SCommitInfo *info, SCommitter2 *committer) {
10✔
598
  int32_t code = 0;
10✔
599
  int32_t lino = 0;
10✔
600

601
  committer->tsdb = tsdb;
10✔
602
  committer->minutes = tsdb->keepCfg.days;
10✔
603
  committer->precision = tsdb->keepCfg.precision;
10✔
604
  committer->minRow = info->info.config.tsdbCfg.minRows;
10✔
605
  committer->maxRow = info->info.config.tsdbCfg.maxRows;
10✔
606
  committer->cmprAlg = info->info.config.tsdbCfg.compression;
10✔
607
  committer->sttTrigger = info->info.config.sttTrigger;
10✔
608
  committer->szPage = info->info.config.tsdbPageSize;
10✔
609
  committer->compactVersion = INT64_MAX;
10✔
610
  committer->cid = tsdbFSAllocEid(tsdb->pFS);
10✔
611
  committer->now = taosGetTimestampSec();
10✔
612

613
  TAOS_CHECK_GOTO(tsdbCommitInfoBuild(tsdb), &lino, _exit);
10!
614

615
_exit:
10✔
616
  if (code) {
10!
617
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
618
  } else {
619
    tsdbDebug("vgId:%d %s done", TD_VID(tsdb->pVnode), __func__);
10✔
620
  }
621
  return code;
10✔
622
}
623

624
static int32_t tsdbCloseCommitter(SCommitter2 *committer, int32_t eno) {
10✔
625
  int32_t code = 0;
10✔
626
  int32_t lino = 0;
10✔
627

628
  if (eno == 0) {
10!
629
    TAOS_CHECK_GOTO(tsdbFSEditBegin(committer->tsdb->pFS, committer->fopArray, TSDB_FEDIT_COMMIT), &lino, _exit);
10!
630
  } else {
631
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
632
              tstrerror(eno));
633
  }
634

635
  TARRAY2_DESTROY(committer->dataIterArray, NULL);
10!
636
  TARRAY2_DESTROY(committer->tombIterArray, NULL);
10!
637
  TARRAY2_DESTROY(committer->sttReaderArray, NULL);
10!
638
  TARRAY2_DESTROY(committer->fopArray, NULL);
10!
639
  TARRAY2_DESTROY(committer->sttReaderArray, NULL);
10!
640

641
_exit:
10✔
642
  if (code) {
10!
643
    tsdbError("vgId:%d %s failed at %s:%d since %s, eid:%" PRId64, TD_VID(committer->tsdb->pVnode), __func__, __FILE__,
×
644
              lino, tstrerror(code), committer->cid);
645
  } else {
646
    tsdbDebug("vgId:%d %s done, eid:%" PRId64, TD_VID(committer->tsdb->pVnode), __func__, committer->cid);
10✔
647
  }
648
  return code;
10✔
649
}
650

651
int32_t tsdbPreCommit(STsdb *tsdb) {
13✔
652
  (void)taosThreadMutexLock(&tsdb->mutex);
13✔
653
  ASSERT_CORE(tsdb->imem == NULL, "imem should be null to commit mem");
13!
654
  tsdb->imem = tsdb->mem;
13✔
655
  tsdb->mem = NULL;
13✔
656
  (void)taosThreadMutexUnlock(&tsdb->mutex);
13✔
657
  return 0;
13✔
658
}
659

660
int32_t tsdbCommitBegin(STsdb *tsdb, SCommitInfo *info) {
13✔
661
  if (!tsdb) return 0;
13!
662

663
  int32_t code = 0;
13✔
664
  int32_t lino = 0;
13✔
665

666
  SMemTable *imem = tsdb->imem;
13✔
667
  int64_t    nRow = imem->nRow;
13✔
668
  int64_t    nDel = imem->nDel;
13✔
669

670
  if ((nRow == 0 && nDel == 0) || (tsBypassFlag & TSDB_BYPASS_RB_TSDB_COMMIT)) {
13!
671
    (void)taosThreadMutexLock(&tsdb->mutex);
3✔
672
    tsdb->imem = NULL;
3✔
673
    (void)taosThreadMutexUnlock(&tsdb->mutex);
3✔
674
    tsdbUnrefMemTable(imem, NULL, true);
3✔
675
  } else {
676
    SCommitter2 committer = {0};
10✔
677

678
    TAOS_CHECK_GOTO(tsdbOpenCommitter(tsdb, info, &committer), &lino, _exit);
10!
679

680
    for (int32_t i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
31✔
681
      committer.ctx->info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
21✔
682
      TAOS_CHECK_GOTO(tsdbCommitFileSet(&committer), &lino, _exit);
21!
683
    }
684

685
    TAOS_CHECK_GOTO(tsdbCloseCommitter(&committer, code), &lino, _exit);
10!
686
  }
687

688
_exit:
13✔
689
  if (code) {
13!
690
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
691
  } else {
692
    tsdbInfo("vgId:%d %s done, nRow:%" PRId64 " nDel:%" PRId64, TD_VID(tsdb->pVnode), __func__, nRow, nDel);
13!
693
  }
694
  return code;
13✔
695
}
696

697
int32_t tsdbCommitCommit(STsdb *tsdb) {
13✔
698
  int32_t code = 0;
13✔
699
  int32_t lino = 0;
13✔
700

701
  if (tsdb->imem) {
13✔
702
    SMemTable *pMemTable = tsdb->imem;
10✔
703

704
    (void)taosThreadMutexLock(&tsdb->mutex);
10✔
705

706
    if ((code = tsdbFSEditCommit(tsdb->pFS))) {
10!
707
      (void)taosThreadMutexUnlock(&tsdb->mutex);
×
708
      TSDB_CHECK_CODE(code, lino, _exit);
×
709
    }
710
    tsdb->imem = NULL;
10✔
711

712
    for (int32_t i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
31✔
713
      SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
21✔
714
      if (info->fset) {
21✔
715
        tsdbFinishTaskOnFileSet(tsdb, info->fid, EVA_TASK_COMMIT);
5✔
716
      }
717
    }
718

719
    (void)taosThreadMutexUnlock(&tsdb->mutex);
10✔
720

721
    tsdbCommitInfoDestroy(tsdb);
10✔
722
    tsdbUnrefMemTable(pMemTable, NULL, true);
10✔
723
  }
724

725
_exit:
3✔
726
  if (code) {
13!
727
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
728
  } else {
729
    tsdbInfo("vgId:%d %s done", TD_VID(tsdb->pVnode), __func__);
13!
730
  }
731
  return code;
13✔
732
}
733

734
int32_t tsdbCommitAbort(STsdb *pTsdb) {
×
735
  int32_t code = 0;
×
736
  int32_t lino = 0;
×
737

738
  if (pTsdb->imem == NULL) goto _exit;
×
739

740
  TAOS_CHECK_GOTO(tsdbFSEditAbort(pTsdb->pFS), &lino, _exit);
×
741

742
  (void)taosThreadMutexLock(&pTsdb->mutex);
×
743
  for (int32_t i = 0; i < taosArrayGetSize(pTsdb->commitInfo->arr); i++) {
×
744
    SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(pTsdb->commitInfo->arr, i);
×
745
    if (info->fset) {
×
NEW
746
      tsdbFinishTaskOnFileSet(pTsdb, info->fid, EVA_TASK_COMMIT);
×
747
    }
748
  }
749
  (void)taosThreadMutexUnlock(&pTsdb->mutex);
×
750
  tsdbCommitInfoDestroy(pTsdb);
×
751

752
_exit:
×
753
  if (code) {
×
754
    tsdbError("vgId:%d, %s failed at line %d since %s", TD_VID(pTsdb->pVnode), __func__, lino, tstrerror(code));
×
755
  } else {
756
    tsdbInfo("vgId:%d %s done", TD_VID(pTsdb->pVnode), __func__);
×
757
  }
758
  return code;
×
759
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc