#3562

Committed 20 Dec 2024 09:57AM UTC coverage: 26.655% (-32.2%) from 58.812%

Build # #3562

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #29229 from taosdata/enh/TS-5749-3.0

enh: seperate tsdb async tasks to different thread pools

Run Details

21498 of 109421 branches covered (19.65%)

Branch coverage included in aggregate %.

66 of 96 new or added lines in 7 files covered. (68.75%)

39441 existing lines in 157 files now uncovered.

35007 of 102566 relevant lines covered (34.13%)

53922.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/source/dnode/vnode/src/meta/metaSma.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "meta.h"
#include "vnodeInt.h"

static int metaHandleSmaEntry(SMeta *pMeta, const SMetaEntry *pME);
static int metaSaveSmaToDB(SMeta *pMeta, const SMetaEntry *pME);

int32_t metaCreateTSma(SMeta *pMeta, int64_t version, SSmaCfg *pCfg) {
  // TODO: Validate the cfg
  // The table uid should exists and be super table or normal table.
  // Check other cfg value

  SMetaEntry  me = {0};
  int         kLen = 0;
  int         vLen = 0;
  const void *pKey = NULL;
  const void *pVal = NULL;
  void       *pBuf = NULL;
  int32_t     szBuf = 0;
  void       *p = NULL;
  SMetaReader mr = {0};
  int32_t     code = 0;

  // validate req
  // save smaIndex
  metaReaderDoInit(&mr, pMeta, META_READER_LOCK);
  if (metaReaderGetTableEntryByUidCache(&mr, pCfg->indexUid) == 0) {
#if 1
    metaReaderClear(&mr);
    return terrno = TSDB_CODE_TSMA_ALREADY_EXIST;
#else
    metaReaderClear(&mr);
    return 0;
#endif
  }
  metaReaderClear(&mr);

  // set structs
  me.version = version;
  me.type = TSDB_TSMA_TABLE;
  me.uid = pCfg->indexUid;
  me.name = pCfg->indexName;
  me.smaEntry.tsma = pCfg;

  code = metaHandleSmaEntry(pMeta, &me);
  if (code) goto _err;

  metaDebug("vgId:%d, tsma is created, name:%s uid:%" PRId64, TD_VID(pMeta->pVnode), pCfg->indexName, pCfg->indexUid);

  return 0;

_err:
  metaError("vgId:%d, failed to create tsma:%s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pCfg->indexName,
            pCfg->indexUid, tstrerror(terrno));
  return code;
}

int32_t metaDropTSma(SMeta *pMeta, int64_t indexUid) {
  // TODO: Validate the cfg
  // TODO: add atomicity

#ifdef META_REFACT
#else
  if (metaRemoveSmaFromDb(pMeta, indexUid) < 0) {
    // TODO: handle error
    return -1;
  }
#endif
  return TSDB_CODE_SUCCESS;
}

static int metaSaveSmaToDB(SMeta *pMeta, const SMetaEntry *pME) {
  STbDbKey tbDbKey;
  void    *pKey = NULL;
  void    *pVal = NULL;
  int      kLen = 0;
  int      vLen = 0;
  SEncoder coder = {0};

  // set key and value
  tbDbKey.version = pME->version;
  tbDbKey.uid = pME->uid;

  pKey = &tbDbKey;
  kLen = sizeof(tbDbKey);

  int32_t ret = 0;
  tEncodeSize(metaEncodeEntry, pME, vLen, ret);
  if (ret < 0) {
    goto _err;
  }

  pVal = taosMemoryMalloc(vLen);
  if (pVal == NULL) {
    terrno = terrno;
    goto _err;
  }

  tEncoderInit(&coder, pVal, vLen);

  if (metaEncodeEntry(&coder, pME) < 0) {
    goto _err;
  }

  tEncoderClear(&coder);

  // write to table.db
  if (tdbTbInsert(pMeta->pTbDb, pKey, kLen, pVal, vLen, pMeta->txn) < 0) {
    goto _err;
  }

  taosMemoryFree(pVal);
  return 0;

_err:
  taosMemoryFree(pVal);
  return -1;
}

static int metaUpdateUidIdx(SMeta *pMeta, const SMetaEntry *pME) {
  SUidIdxVal uidIdxVal = {.suid = pME->smaEntry.tsma->indexUid, .version = pME->version, .skmVer = 0};
  return tdbTbInsert(pMeta->pUidIdx, &pME->uid, sizeof(tb_uid_t), &uidIdxVal, sizeof(uidIdxVal), pMeta->txn);
}

static int metaUpdateNameIdx(SMeta *pMeta, const SMetaEntry *pME) {
  return tdbTbInsert(pMeta->pNameIdx, pME->name, strlen(pME->name) + 1, &pME->uid, sizeof(tb_uid_t), pMeta->txn);
}

static int metaUpdateSmaIdx(SMeta *pMeta, const SMetaEntry *pME) {
  SSmaIdxKey smaIdxKey = {.uid = pME->smaEntry.tsma->tableUid, .smaUid = pME->smaEntry.tsma->indexUid};

  return tdbTbInsert(pMeta->pSmaIdx, &smaIdxKey, sizeof(smaIdxKey), NULL, 0, pMeta->txn);
}

static int metaHandleSmaEntry(SMeta *pMeta, const SMetaEntry *pME) {
  int32_t code = 0;
  metaWLock(pMeta);

  // save to table.db
  if ((code = metaSaveSmaToDB(pMeta, pME)) < 0) goto _err;

  // update uid.idx
  if ((code = metaUpdateUidIdx(pMeta, pME)) < 0) goto _err;

  // update name.idx
  if ((code = metaUpdateNameIdx(pMeta, pME)) < 0) goto _err;

  // update sma.idx
  if ((code = metaUpdateSmaIdx(pMeta, pME)) < 0) goto _err;

  metaULock(pMeta);
  return 0;

_err:
  metaULock(pMeta);
  return code;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "meta.h"
17	#include "vnodeInt.h"
18
19	static int metaHandleSmaEntry(SMeta pMeta, const SMetaEntry pME);
20	static int metaSaveSmaToDB(SMeta pMeta, const SMetaEntry pME);
21
UNCOV 22	int32_t metaCreateTSma(SMeta pMeta, int64_t version, SSmaCfg pCfg) {	×
23	// TODO: Validate the cfg
24	// The table uid should exists and be super table or normal table.
25	// Check other cfg value
26
UNCOV 27	SMetaEntry me = {0};	×
UNCOV 28	int kLen = 0;	×
UNCOV 29	int vLen = 0;	×
UNCOV 30	const void *pKey = NULL;	×
UNCOV 31	const void *pVal = NULL;	×
UNCOV 32	void *pBuf = NULL;	×
UNCOV 33	int32_t szBuf = 0;	×
UNCOV 34	void *p = NULL;	×
UNCOV 35	SMetaReader mr = {0};	×
UNCOV 36	int32_t code = 0;	×
37
38	// validate req
39	// save smaIndex
UNCOV 40	metaReaderDoInit(&mr, pMeta, META_READER_LOCK);	×
UNCOV 41	if (metaReaderGetTableEntryByUidCache(&mr, pCfg->indexUid) == 0) {	×
42	#if 1
43	metaReaderClear(&mr);	×
44	return terrno = TSDB_CODE_TSMA_ALREADY_EXIST;	×
45	#else
46	metaReaderClear(&mr);
47	return 0;
48	#endif
49	}
UNCOV 50	metaReaderClear(&mr);	×
51
52	// set structs
UNCOV 53	me.version = version;	×
UNCOV 54	me.type = TSDB_TSMA_TABLE;	×
UNCOV 55	me.uid = pCfg->indexUid;	×
UNCOV 56	me.name = pCfg->indexName;	×
UNCOV 57	me.smaEntry.tsma = pCfg;	×
58
UNCOV 59	code = metaHandleSmaEntry(pMeta, &me);	×
UNCOV 60	if (code) goto _err;	×
61
UNCOV 62	metaDebug("vgId:%d, tsma is created, name:%s uid:%" PRId64, TD_VID(pMeta->pVnode), pCfg->indexName, pCfg->indexUid);	×
63
UNCOV 64	return 0;	×
65
66	_err:	×
67	metaError("vgId:%d, failed to create tsma:%s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pCfg->indexName,	×
68	pCfg->indexUid, tstrerror(terrno));
69	return code;	×
70	}
71
72	int32_t metaDropTSma(SMeta *pMeta, int64_t indexUid) {	×
73	// TODO: Validate the cfg
74	// TODO: add atomicity
75
76	#ifdef META_REFACT
77	#else
78	if (metaRemoveSmaFromDb(pMeta, indexUid) < 0) {
79	// TODO: handle error
80	return -1;
81	}
82	#endif
83	return TSDB_CODE_SUCCESS;	×
84	}
85
UNCOV 86	static int metaSaveSmaToDB(SMeta pMeta, const SMetaEntry pME) {	×
87	STbDbKey tbDbKey;
UNCOV 88	void *pKey = NULL;	×
UNCOV 89	void *pVal = NULL;	×
UNCOV 90	int kLen = 0;	×
UNCOV 91	int vLen = 0;	×
UNCOV 92	SEncoder coder = {0};	×
93
94	// set key and value
UNCOV 95	tbDbKey.version = pME->version;	×
UNCOV 96	tbDbKey.uid = pME->uid;	×
97
UNCOV 98	pKey = &tbDbKey;	×
UNCOV 99	kLen = sizeof(tbDbKey);	×
100
UNCOV 101	int32_t ret = 0;	×
UNCOV 102	tEncodeSize(metaEncodeEntry, pME, vLen, ret);	×
UNCOV 103	if (ret < 0) {	×
104	goto _err;	×
105	}
106
UNCOV 107	pVal = taosMemoryMalloc(vLen);	×
UNCOV 108	if (pVal == NULL) {	×
109	terrno = terrno;	×
110	goto _err;	×
111	}
112
UNCOV 113	tEncoderInit(&coder, pVal, vLen);	×
114
UNCOV 115	if (metaEncodeEntry(&coder, pME) < 0) {	×
116	goto _err;	×
117	}
118
UNCOV 119	tEncoderClear(&coder);	×
120
121	// write to table.db
UNCOV 122	if (tdbTbInsert(pMeta->pTbDb, pKey, kLen, pVal, vLen, pMeta->txn) < 0) {	×
123	goto _err;	×
124	}
125
UNCOV 126	taosMemoryFree(pVal);	×
UNCOV 127	return 0;	×
128
129	_err:	×
130	taosMemoryFree(pVal);	×
131	return -1;	×
132	}
133
UNCOV 134	static int metaUpdateUidIdx(SMeta pMeta, const SMetaEntry pME) {	×
UNCOV 135	SUidIdxVal uidIdxVal = {.suid = pME->smaEntry.tsma->indexUid, .version = pME->version, .skmVer = 0};	×
UNCOV 136	return tdbTbInsert(pMeta->pUidIdx, &pME->uid, sizeof(tb_uid_t), &uidIdxVal, sizeof(uidIdxVal), pMeta->txn);	×
137	}
138
UNCOV 139	static int metaUpdateNameIdx(SMeta pMeta, const SMetaEntry pME) {	×
UNCOV 140	return tdbTbInsert(pMeta->pNameIdx, pME->name, strlen(pME->name) + 1, &pME->uid, sizeof(tb_uid_t), pMeta->txn);	×
141	}
142
UNCOV 143	static int metaUpdateSmaIdx(SMeta pMeta, const SMetaEntry pME) {	×
UNCOV 144	SSmaIdxKey smaIdxKey = {.uid = pME->smaEntry.tsma->tableUid, .smaUid = pME->smaEntry.tsma->indexUid};	×
145
UNCOV 146	return tdbTbInsert(pMeta->pSmaIdx, &smaIdxKey, sizeof(smaIdxKey), NULL, 0, pMeta->txn);	×
147	}
148
UNCOV 149	static int metaHandleSmaEntry(SMeta pMeta, const SMetaEntry pME) {	×
UNCOV 150	int32_t code = 0;	×
UNCOV 151	metaWLock(pMeta);	×
152
153	// save to table.db
UNCOV 154	if ((code = metaSaveSmaToDB(pMeta, pME)) < 0) goto _err;	×
155
156	// update uid.idx
UNCOV 157	if ((code = metaUpdateUidIdx(pMeta, pME)) < 0) goto _err;	×
158
159	// update name.idx
UNCOV 160	if ((code = metaUpdateNameIdx(pMeta, pME)) < 0) goto _err;	×
161
162	// update sma.idx
UNCOV 163	if ((code = metaUpdateSmaIdx(pMeta, pME)) < 0) goto _err;	×
164
UNCOV 165	metaULock(pMeta);	×
UNCOV 166	return 0;	×
167
168	_err:	×
169	metaULock(pMeta);	×
170	return code;	×
171	}

taosdata / TDengine / #3562

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous