#3562

Committed 20 Dec 2024 09:57AM UTC coverage: 26.655% (-32.2%) from 58.812%

Build # #3562

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #29229 from taosdata/enh/TS-5749-3.0

enh: seperate tsdb async tasks to different thread pools

Run Details

21498 of 109421 branches covered (19.65%)

Branch coverage included in aggregate %.

66 of 96 new or added lines in 7 files covered. (68.75%)

39441 existing lines in 157 files now uncovered.

35007 of 102566 relevant lines covered (34.13%)

53922.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.0

/source/client/src/clientMonitorSql.c

 /*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
#include "clientInt.h"
#include "clientMonitor.h"
#include "clientLog.h"
#include "tglobal.h"

const char* selectMonitorName = "taos_sql_req:count";
const char* selectMonitorHelp = "count for select sql";
const int   selectMonitorLabelCount = 4;
const char* selectMonitorLabels[] = {"cluster_id", "sql_type", "username", "result"};

void monitorClientSQLReqInit(int64_t clusterId) {
  monitorCreateClient(clusterId);
  monitorCreateClientCounter(clusterId, selectMonitorName, selectMonitorHelp, selectMonitorLabelCount, selectMonitorLabels);
}

void clientSQLReqLog(int64_t clusterId, const char* user, SQL_RESULT_CODE result, int8_t type) {
  const char* typeStr;
  switch (type) {
    case MONITORSQLTYPEDELETE:
      typeStr = "delete";
      break;
    case MONITORSQLTYPEINSERT:
      typeStr = "insert";
      break;
    default:
      typeStr = "select";
      break;
  }
  char clusterIdStr[32] = {0};
  if (snprintf(clusterIdStr, sizeof(clusterIdStr), "%" PRId64, clusterId) < 0){
    uError("failed to generate clusterId:%" PRId64, clusterId);
  }
  const char* selectMonitorLabelValues[] = {clusterIdStr, typeStr, user, monitorResultStr(result)};
  monitorCounterInc(clusterId, selectMonitorName, selectMonitorLabelValues);
}

void sqlReqLog(int64_t rid,  bool killed, int32_t code, int8_t type) {
  SQL_RESULT_CODE result = SQL_RESULT_SUCCESS;
  if (TSDB_CODE_SUCCESS != code) {
    result = SQL_RESULT_FAILED;
  }
  // to do Distinguish active Kill events
  // else if (killed) {
  //   result = SQL_RESULT_CANCEL;
  // }

  STscObj* pTscObj = acquireTscObj(rid);
  if (pTscObj != NULL) {
    if (pTscObj->pAppInfo == NULL) {
      tscLog("sqlReqLog, not found pAppInfo");
    } else {
      clientSQLReqLog(pTscObj->pAppInfo->clusterId, pTscObj->user, result, type);
    }
    (void)releaseTscObj(rid);
  } else {
    tscLog("sqlReqLog, not found rid");
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15	#include "clientInt.h"
16	#include "clientMonitor.h"
17	#include "clientLog.h"
18	#include "tglobal.h"
19
20	const char* selectMonitorName = "taos_sql_req:count";
21	const char* selectMonitorHelp = "count for select sql";
22	const int selectMonitorLabelCount = 4;
23	const char* selectMonitorLabels[] = {"cluster_id", "sql_type", "username", "result"};
24
25	void monitorClientSQLReqInit(int64_t clusterId) {	214✔
26	monitorCreateClient(clusterId);	214✔
27	monitorCreateClientCounter(clusterId, selectMonitorName, selectMonitorHelp, selectMonitorLabelCount, selectMonitorLabels);	214✔
28	}	214✔
29
30	void clientSQLReqLog(int64_t clusterId, const char* user, SQL_RESULT_CODE result, int8_t type) {	6,116✔
31	const char* typeStr;
32	switch (type) {	6,116!
UNCOV 33	case MONITORSQLTYPEDELETE:	×
UNCOV 34	typeStr = "delete";	×
UNCOV 35	break;	×
36	case MONITORSQLTYPEINSERT:	5,913✔
37	typeStr = "insert";	5,913✔
38	break;	5,913✔
39	default:	203✔
40	typeStr = "select";	203✔
41	break;	203✔
42	}
43	char clusterIdStr[32] = {0};	6,116✔
44	if (snprintf(clusterIdStr, sizeof(clusterIdStr), "%" PRId64, clusterId) < 0){	6,116!
45	uError("failed to generate clusterId:%" PRId64, clusterId);	×
46	}
47	const char* selectMonitorLabelValues[] = {clusterIdStr, typeStr, user, monitorResultStr(result)};	6,116✔
48	monitorCounterInc(clusterId, selectMonitorName, selectMonitorLabelValues);	6,116✔
49	}	6,116✔
50
51	void sqlReqLog(int64_t rid, bool killed, int32_t code, int8_t type) {	6,118✔
52	SQL_RESULT_CODE result = SQL_RESULT_SUCCESS;	6,118✔
53	if (TSDB_CODE_SUCCESS != code) {	6,118✔
54	result = SQL_RESULT_FAILED;	27✔
55	}
56	// to do Distinguish active Kill events
57	// else if (killed) {
58	// result = SQL_RESULT_CANCEL;
59	// }
60
61	STscObj* pTscObj = acquireTscObj(rid);	6,118✔
62	if (pTscObj != NULL) {	6,118✔
63	if (pTscObj->pAppInfo == NULL) {	6,116!
64	tscLog("sqlReqLog, not found pAppInfo");	×
65	} else {
66	clientSQLReqLog(pTscObj->pAppInfo->clusterId, pTscObj->user, result, type);	6,116✔
67	}
68	(void)releaseTscObj(rid);	6,116✔
69	} else {
70	tscLog("sqlReqLog, not found rid");	2✔
71	}
72	}	6,118✔

taosdata / TDengine / #3562

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous