• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3561

19 Dec 2024 03:15AM UTC coverage: 58.812% (-1.3%) from 60.124%
#3561

push

travis-ci

web-flow
Merge pull request #29213 from taosdata/merge/mainto3.0

merge: from main to 3.0 branch

130770 of 287658 branches covered (45.46%)

Branch coverage included in aggregate %.

32 of 78 new or added lines in 4 files covered. (41.03%)

7347 existing lines in 166 files now uncovered.

205356 of 283866 relevant lines covered (72.34%)

7187865.64 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

52.84
/source/dnode/mnode/impl/src/mndCompactDetail.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15
#include "mndCompactDetail.h"
16
#include "mndDb.h"
17
#include "mndShow.h"
18
#include "mndTrans.h"
19

20
#define MND_COMPACT_VER_NUMBER 1
21

22
int32_t mndInitCompactDetail(SMnode *pMnode) {
1,366✔
23
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COMPACT_DETAIL, mndRetrieveCompactDetail);
1,366✔
24

25
  SSdbTable table = {
1,366✔
26
      .sdbType = SDB_COMPACT_DETAIL,
27
      .keyType = SDB_KEY_INT64,
28
      .encodeFp = (SdbEncodeFp)mndCompactDetailActionEncode,
29
      .decodeFp = (SdbDecodeFp)mndCompactDetailActionDecode,
30
      .insertFp = (SdbInsertFp)mndCompactDetailActionInsert,
31
      .updateFp = (SdbUpdateFp)mndCompactDetailActionUpdate,
32
      .deleteFp = (SdbDeleteFp)mndCompactDetailActionDelete,
33
  };
34

35
  return sdbSetTable(pMnode->pSdb, table);
1,366✔
36
}
37

38
void mndCleanupCompactDetail(SMnode *pMnode) { mDebug("mnd compact detail cleanup"); }
1,365✔
39

40
int32_t mndRetrieveCompactDetail(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
×
41
  SMnode            *pMnode = pReq->info.node;
×
42
  SSdb              *pSdb = pMnode->pSdb;
×
43
  int32_t            numOfRows = 0;
×
44
  SCompactDetailObj *pCompactDetail = NULL;
×
45
  char              *sep = NULL;
×
46
  SDbObj            *pDb = NULL;
×
47

48
  if (strlen(pShow->db) > 0) {
×
49
    sep = strchr(pShow->db, '.');
×
50
    if (sep &&
×
51
        ((0 == strcmp(sep + 1, TSDB_INFORMATION_SCHEMA_DB) || (0 == strcmp(sep + 1, TSDB_PERFORMANCE_SCHEMA_DB))))) {
×
52
      sep++;
×
53
    } else {
54
      pDb = mndAcquireDb(pMnode, pShow->db);
×
55
      if (pDb == NULL) return terrno;
×
56
    }
57
  }
58

59
  while (numOfRows < rows) {
×
60
    pShow->pIter = sdbFetch(pSdb, SDB_COMPACT_DETAIL, pShow->pIter, (void **)&pCompactDetail);
×
61
    if (pShow->pIter == NULL) break;
×
62

63
    SColumnInfoData *pColInfo;
64
    SName            n;
65
    int32_t          cols = 0;
×
66

67
    char tmpBuf[TSDB_SHOW_SQL_LEN + VARSTR_HEADER_SIZE] = {0};
×
68

69
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
70
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->compactId, false),
×
71
                                   pSdb, pCompactDetail);
72

73
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
74
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->vgId, false), pSdb,
×
75
                                   pCompactDetail);
76

77
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
78
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->dnodeId, false),
×
79
                                   pSdb, pCompactDetail);
80

81
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
82
    TAOS_CHECK_RETURN_WITH_RELEASE(
×
83
        colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->numberFileset, false), pSdb, pCompactDetail);
84

85
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
86
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->finished, false),
×
87
                                   pSdb, pCompactDetail);
88

89
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
90
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->startTime, false),
×
91
                                   pSdb, pCompactDetail);
92

93
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
94
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->progress, false),
×
95
                                   pSdb, pCompactDetail);
96

97
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
×
98
    TAOS_CHECK_RETURN_WITH_RELEASE(
×
99
        colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->remainingTime, false), pSdb, pCompactDetail);
100

101
    numOfRows++;
×
102
    sdbRelease(pSdb, pCompactDetail);
×
103
  }
104

105
  pShow->numOfRows += numOfRows;
×
106
  mndReleaseDb(pMnode, pDb);
×
107
  return numOfRows;
×
108
}
109

110
void tFreeCompactDetailObj(SCompactDetailObj *pCompact) {}
2✔
111

112
static int32_t tSerializeSCompactDetailObj(void *buf, int32_t bufLen, const SCompactDetailObj *pObj) {
8✔
113
  SEncoder encoder = {0};
8✔
114
  int32_t  code = 0;
8✔
115
  int32_t  lino;
116
  int32_t  tlen;
117
  tEncoderInit(&encoder, buf, bufLen);
8✔
118

119
  TAOS_CHECK_EXIT(tStartEncode(&encoder));
8!
120
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->compactDetailId));
16!
121
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->compactId));
16!
122
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->vgId));
16!
123
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->dnodeId));
16!
124
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->numberFileset));
16!
125
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->finished));
16!
126
  TAOS_CHECK_EXIT(tEncodeI64(&encoder, pObj->startTime));
16!
127
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->newNumberFileset));
16!
128
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->newFinished));
24!
129
  // 1. add progress and remaining time
130
  TAOS_CHECK_EXIT(tEncodeI32v(&encoder, pObj->progress));
16!
131
  TAOS_CHECK_EXIT(tEncodeI64v(&encoder, pObj->remainingTime));
16!
132

133
  tEndEncode(&encoder);
8✔
134

135
_exit:
8✔
136
  if (code) {
8!
137
    tlen = code;
×
138
  } else {
139
    tlen = encoder.pos;
8✔
140
  }
141
  tEncoderClear(&encoder);
8✔
142
  return tlen;
8✔
143
}
144

145
static int32_t tDeserializeSCompactDetailObj(void *buf, int32_t bufLen, SCompactDetailObj *pObj) {
2✔
146
  int32_t  code = 0;
2✔
147
  int32_t  lino;
148
  SDecoder decoder = {0};
2✔
149
  tDecoderInit(&decoder, buf, bufLen);
2✔
150

151
  TAOS_CHECK_EXIT(tStartDecode(&decoder));
2!
152
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->compactDetailId));
4!
153
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->compactId));
4!
154
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->vgId));
4!
155
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->dnodeId));
4!
156
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->numberFileset));
4!
157
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->finished));
4!
158
  TAOS_CHECK_EXIT(tDecodeI64(&decoder, &pObj->startTime));
4!
159
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->newNumberFileset));
4!
160
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->newFinished));
4!
161
  // 1. add progress and remaining time decode
162
  if (!tDecodeIsEnd(&decoder)) {
2!
163
    TAOS_CHECK_EXIT(tDecodeI32v(&decoder, &pObj->progress));
4!
164
    TAOS_CHECK_EXIT(tDecodeI64v(&decoder, &pObj->remainingTime));
4!
165
  } else {
166
    pObj->progress = 0;
×
167
    pObj->remainingTime = 0;
×
168
  }
169

170
  tEndDecode(&decoder);
2✔
171

172
_exit:
2✔
173
  tDecoderClear(&decoder);
2✔
174
  return code;
2✔
175
}
176

177
SSdbRaw *mndCompactDetailActionEncode(SCompactDetailObj *pCompact) {
4✔
178
  int32_t code = 0;
4✔
179
  int32_t lino = 0;
4✔
180
  terrno = TSDB_CODE_SUCCESS;
4✔
181

182
  void    *buf = NULL;
4✔
183
  SSdbRaw *pRaw = NULL;
4✔
184

185
  int32_t tlen = tSerializeSCompactDetailObj(NULL, 0, pCompact);
4✔
186
  if (tlen < 0) {
4!
187
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
188
    goto OVER;
×
189
  }
190

191
  int32_t size = sizeof(int32_t) + tlen;
4✔
192
  pRaw = sdbAllocRaw(SDB_COMPACT_DETAIL, MND_COMPACT_VER_NUMBER, size);
4✔
193
  if (pRaw == NULL) {
4!
194
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
195
    goto OVER;
×
196
  }
197

198
  buf = taosMemoryMalloc(tlen);
4!
199
  if (buf == NULL) {
4!
200
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
201
    goto OVER;
×
202
  }
203

204
  tlen = tSerializeSCompactDetailObj(buf, tlen, pCompact);
4✔
205
  if (tlen < 0) {
4!
206
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
207
    goto OVER;
×
208
  }
209

210
  int32_t dataPos = 0;
4✔
211
  SDB_SET_INT32(pRaw, dataPos, tlen, OVER);
4!
212
  SDB_SET_BINARY(pRaw, dataPos, buf, tlen, OVER);
4!
213
  SDB_SET_DATALEN(pRaw, dataPos, OVER);
4!
214

215
OVER:
4✔
216
  taosMemoryFreeClear(buf);
4!
217
  if (terrno != TSDB_CODE_SUCCESS) {
4!
218
    mError("compact detail:%" PRId32 ", failed to encode to raw:%p since %s", pCompact->compactId, pRaw, terrstr());
×
219
    sdbFreeRaw(pRaw);
×
220
    return NULL;
×
221
  }
222

223
  mTrace("compact detail:%" PRId32 ", encode to raw:%p, row:%p", pCompact->compactId, pRaw, pCompact);
4!
224
  return pRaw;
4✔
225
}
226

227
SSdbRow *mndCompactDetailActionDecode(SSdbRaw *pRaw) {
2✔
228
  int32_t            code = 0;
2✔
229
  int32_t            lino = 0;
2✔
230
  SSdbRow           *pRow = NULL;
2✔
231
  SCompactDetailObj *pCompact = NULL;
2✔
232
  void              *buf = NULL;
2✔
233
  terrno = TSDB_CODE_SUCCESS;
2✔
234

235
  int8_t sver = 0;
2✔
236
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) {
2!
237
    goto OVER;
×
238
  }
239

240
  if (sver != MND_COMPACT_VER_NUMBER) {
2!
241
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
242
    mError("compact detail read invalid ver, data ver: %d, curr ver: %d", sver, MND_COMPACT_VER_NUMBER);
×
243
    goto OVER;
×
244
  }
245

246
  pRow = sdbAllocRow(sizeof(SCompactObj));
2✔
247
  if (pRow == NULL) {
2!
248
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
249
    goto OVER;
×
250
  }
251

252
  pCompact = sdbGetRowObj(pRow);
2✔
253
  if (pCompact == NULL) {
2!
254
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
255
    goto OVER;
×
256
  }
257

258
  int32_t tlen;
259
  int32_t dataPos = 0;
2✔
260
  SDB_GET_INT32(pRaw, dataPos, &tlen, OVER);
2!
261
  buf = taosMemoryMalloc(tlen + 1);
2!
262
  if (buf == NULL) {
2!
263
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
264
    goto OVER;
×
265
  }
266
  SDB_GET_BINARY(pRaw, dataPos, buf, tlen, OVER);
2!
267

268
  if ((terrno = tDeserializeSCompactDetailObj(buf, tlen, pCompact)) < 0) {
2!
269
    goto OVER;
×
270
  }
271

272
OVER:
2✔
273
  taosMemoryFreeClear(buf);
2!
274
  if (terrno != TSDB_CODE_SUCCESS) {
2!
275
    mError("compact detail:%" PRId32 ", failed to decode from raw:%p since %s", pCompact->compactId, pRaw, terrstr());
×
276
    taosMemoryFreeClear(pRow);
×
277
    return NULL;
×
278
  }
279

280
  mTrace("compact detail:%" PRId32 ", decode from raw:%p, row:%p", pCompact->compactId, pRaw, pCompact);
2!
281
  return pRow;
2✔
282
}
283

284
int32_t mndCompactDetailActionInsert(SSdb *pSdb, SCompactDetailObj *pCompact) {
2✔
285
  mTrace("compact detail:%" PRId32 ", perform insert action", pCompact->compactId);
2!
286
  return 0;
2✔
287
}
288

289
int32_t mndCompactDetailActionDelete(SSdb *pSdb, SCompactDetailObj *pCompact) {
2✔
290
  mTrace("compact detail:%" PRId32 ", perform insert action", pCompact->compactId);
2!
291
  tFreeCompactDetailObj(pCompact);
2✔
292
  return 0;
2✔
293
}
294

UNCOV
295
int32_t mndCompactDetailActionUpdate(SSdb *pSdb, SCompactDetailObj *pOldCompact, SCompactDetailObj *pNewCompact) {
×
UNCOV
296
  mTrace("compact detail:%" PRId32 ", perform update action, old row:%p new row:%p", pOldCompact->compactId,
×
297
         pOldCompact, pNewCompact);
298

UNCOV
299
  pOldCompact->numberFileset = pNewCompact->numberFileset;
×
UNCOV
300
  pOldCompact->finished = pNewCompact->finished;
×
301

UNCOV
302
  return 0;
×
303
}
304

305
int32_t mndAddCompactDetailToTran(SMnode *pMnode, STrans *pTrans, SCompactObj *pCompact, SVgObj *pVgroup,
2✔
306
                                  SVnodeGid *pVgid, int32_t index) {
307
  int32_t           code = 0;
2✔
308
  SCompactDetailObj compactDetail = {0};
2✔
309
  compactDetail.compactDetailId = index;
2✔
310
  compactDetail.compactId = pCompact->compactId;
2✔
311
  compactDetail.vgId = pVgroup->vgId;
2✔
312
  compactDetail.dnodeId = pVgid->dnodeId;
2✔
313
  compactDetail.startTime = taosGetTimestampMs();
2✔
314
  compactDetail.numberFileset = -1;
2✔
315
  compactDetail.finished = -1;
2✔
316
  compactDetail.newNumberFileset = -1;
2✔
317
  compactDetail.newFinished = -1;
2✔
318

319
  mInfo("compact:%d, add compact detail to trans, index:%d, vgId:%d, dnodeId:%d", compactDetail.compactId,
2!
320
        compactDetail.compactDetailId, compactDetail.vgId, compactDetail.dnodeId);
321

322
  SSdbRaw *pVgRaw = mndCompactDetailActionEncode(&compactDetail);
2✔
323
  if (pVgRaw == NULL) return -1;
2!
324
  if (mndTransAppendCommitlog(pTrans, pVgRaw) != 0) {
2!
325
    sdbFreeRaw(pVgRaw);
×
326
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
327
    if (terrno != 0) code = terrno;
×
328
    TAOS_RETURN(code);
×
329
  }
330
  code = sdbSetRawStatus(pVgRaw, SDB_STATUS_READY);
2✔
331

332
  TAOS_RETURN(code);
2✔
333
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc