• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3558

17 Dec 2024 06:05AM UTC coverage: 59.778% (+1.6%) from 58.204%
#3558

push

travis-ci

web-flow
Merge pull request #29179 from taosdata/merge/mainto3.0

merge: form main to 3.0 branch

132787 of 287595 branches covered (46.17%)

Branch coverage included in aggregate %.

104 of 191 new or added lines in 5 files covered. (54.45%)

6085 existing lines in 168 files now uncovered.

209348 of 284746 relevant lines covered (73.52%)

8164844.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.23
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "tmsg.h"
21
#include "ttypes.h"
22

23
#include "executorInt.h"
24
#include "tcommon.h"
25
#include "thash.h"
26
#include "ttime.h"
27

28
#include "function.h"
29
#include "operator.h"
30
#include "querynodes.h"
31
#include "querytask.h"
32
#include "tdatablock.h"
33
#include "tfill.h"
34

35
typedef struct STimeRange {
36
  TSKEY    skey;
37
  TSKEY    ekey;
38
  uint64_t groupId;
39
} STimeRange;
40

41
typedef struct SFillOperatorInfo {
42
  struct SFillInfo* pFillInfo;
43
  SSDataBlock*      pRes;
44
  SSDataBlock*      pFinalRes;
45
  int64_t           totalInputRows;
46
  void**            p;
47
  SSDataBlock*      existNewGroupBlock;
48
  STimeWindow       win;
49
  SColMatchInfo     matchInfo;
50
  int32_t           primaryTsCol;
51
  int32_t           primarySrcSlotId;
52
  uint64_t          curGroupId;  // current handled group id
53
  SExprInfo*        pExprInfo;
54
  int32_t           numOfExpr;
55
  SExprSupp         noFillExprSupp;
56
  SExprSupp         fillNullExprSupp;
57
} SFillOperatorInfo;
58

59
static void destroyFillOperatorInfo(void* param);
60
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
61
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
62
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
63

64
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
5,209✔
65
                                               SResultInfo* pResultInfo, int32_t order) {
66
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
5,209✔
67
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
5,209✔
68
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
5,209✔
69

70
  //  int32_t order = TSDB_ORDER_ASC;
71
  int32_t scanFlag = MAIN_SCAN;
5,209✔
72
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
73
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
5,209✔
74

75
  blockDataCleanup(pInfo->pRes);
5,209✔
76
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
5,209✔
77

78
  reviseFillStartAndEndKey(pOperator->info, order);
5,209✔
79

80
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
10,418✔
81
                                         : pInfo->existNewGroupBlock->info.window.skey;
5,209!
82
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
5,209✔
83

84
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
5,209✔
85
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
5,209✔
86
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
104✔
87
    if (code != TSDB_CODE_SUCCESS) {
104!
88
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
89
      T_LONG_JMP(pTaskInfo->env, code);
×
90
    }
91
  }
92

93
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
5,209✔
94
  int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
5,209✔
95
  if (code != TSDB_CODE_SUCCESS) {
5,209!
96
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
97
    T_LONG_JMP(pTaskInfo->env, code);
×
98
  }
99

100
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
5,209✔
101
  pInfo->existNewGroupBlock = NULL;
5,209✔
102
}
5,209✔
103

104
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
41,287✔
105
                                            SResultInfo* pResultInfo, int32_t order) {
106
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
41,287✔
107
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
41,287✔
108
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
1,671✔
109
    int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows);
1,671✔
110
    if (code != TSDB_CODE_SUCCESS) {
1,671!
UNCOV
111
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
UNCOV
112
      T_LONG_JMP(pTaskInfo->env, code);
×
113
    }
114
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
1,671✔
115
    return;
1,671✔
116
  }
117

118
  // handle the cached new group data block
119
  if (pInfo->existNewGroupBlock) {
39,615✔
120
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
4,403✔
121
  }
122
}
123

124
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
24,442✔
125
  int32_t            code = TSDB_CODE_SUCCESS;
24,442✔
126
  int32_t            lino = 0;
24,442✔
127
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
24,442✔
128
  SFillOperatorInfo* pInfo = pOperator->info;
24,442✔
129
  SExprSupp*         pSup = &pOperator->exprSupp;
24,442✔
130
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
24,442✔
131
  QUERY_CHECK_CODE(code, lino, _end);
24,443!
132
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL);
24,443✔
133
  QUERY_CHECK_CODE(code, lino, _end);
24,442!
134

135
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
136
  pInfo->pRes->info.rows = 0;
24,442✔
137
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
24,442✔
138
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
24,442✔
139
  QUERY_CHECK_CODE(code, lino, _end);
24,443!
140

141
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
24,443✔
142
                               NULL);
143
  QUERY_CHECK_CODE(code, lino, _end);
24,443!
144

145
  if (pInfo->fillNullExprSupp.pExprInfo) {
24,443✔
146
    pInfo->pRes->info.rows = 0;
118✔
147
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
118✔
148
    QUERY_CHECK_CODE(code, lino, _end);
118!
149
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
118✔
150
        pInfo->fillNullExprSupp.numOfExprs, NULL);
151
  }
152

153
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
24,443✔
154

155
_end:
24,443✔
156
  if (code != TSDB_CODE_SUCCESS) {
24,443!
157
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
158
    T_LONG_JMP(pTaskInfo->env, code);
×
159
  }
160
}
24,443✔
161

162
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
104✔
163
  int32_t code = TSDB_CODE_SUCCESS;
104✔
164
  int32_t lino = 0;
104✔
165
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
863✔
166
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
759✔
167
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
571✔
168
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
571!
169
      key->isNull = true;
571✔
170
    }
171
  }
172

173
_end:
104✔
174
  if (code != TSDB_CODE_SUCCESS) {
104!
175
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
176
  }
177
  return code;
104✔
178
}
179

180
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
28,702✔
181
  int32_t            code = TSDB_CODE_SUCCESS;
28,702✔
182
  int32_t            lino = 0;
28,702✔
183
  SFillOperatorInfo* pInfo = pOperator->info;
28,702✔
184
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
28,702✔
185
  if (pInfo == NULL || pTaskInfo == NULL) {
28,702!
186
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
187
    return NULL;
×
188
  }
189

190
  SResultInfo* pResultInfo = &pOperator->resultInfo;
28,704✔
191
  SSDataBlock* pResBlock = pInfo->pFinalRes;
28,704✔
192
  if (pResBlock == NULL) {
28,704!
193
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
194
    return NULL;
×
195
  }
196

197
  blockDataCleanup(pResBlock);
28,704✔
198

199
  int32_t order = pInfo->pFillInfo->order;
28,703✔
200

201
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
28,703✔
202
#if 0
203
  // the scan order may be different from the output result order for agg interval operator.
204
  if (pDownstream->operatorType == QUERY_NODE_PHYSICAL_PLAN_HASH_INTERVAL) {
205
    order = ((SIntervalAggOperatorInfo*) pDownstream->info)->resultTsOrder;
206
  } else {
207
    order = pInfo->pFillInfo->order;
208
  }
209
#endif
210

211
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
28,703✔
212
  if (pResBlock->info.rows > 0) {
28,700✔
213
    pResBlock->info.id.groupId = pInfo->curGroupId;
6,074✔
214
    return pResBlock;
6,074✔
215
  }
216

217
  while (1) {
13,392✔
218
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
36,018✔
219
    if (pBlock == NULL) {
36,020✔
220
      if (pInfo->totalInputRows == 0 &&
16,786✔
221
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
6,678✔
222
        setOperatorCompleted(pOperator);
6,658✔
223
        return NULL;
6,658✔
224
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
10,128✔
225
        reviseFillStartAndEndKey(pInfo, order);
10✔
226
      }
227

228
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
10,128✔
229
    } else {
230
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
19,234✔
231
      pBlock->info.dataLoad = 1;
19,234✔
232
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
19,234✔
233
      QUERY_CHECK_CODE(code, lino, _end);
19,234!
234

235
      blockDataCleanup(pInfo->pRes);
19,234✔
236
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
19,233✔
237
      QUERY_CHECK_CODE(code, lino, _end);
19,234!
238
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
19,234✔
239
      QUERY_CHECK_CODE(code, lino, _end);
19,234!
240
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
19,234✔
241

242
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
33,261✔
243
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
14,026✔
244
          reviseFillStartAndEndKey(pInfo, order);
5,412✔
245
        }
246

247
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
14,026✔
248
        pInfo->totalInputRows += pInfo->pRes->info.rows;
14,026✔
249

250
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
14,026✔
251
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
14,026✔
252
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
14,025✔
253
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
5,209!
254
        pInfo->existNewGroupBlock = pBlock;
5,209✔
255

256
        // Fill the previous group data block, before handle the data block of new group.
257
        // Close the fill operation for previous group data block
258
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
5,209✔
259
        pInfo->pFillInfo->prev.key = 0;
5,209✔
260
      }
261
    }
262

263
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
29,365✔
264
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
29,365✔
265
    QUERY_CHECK_CODE(code, lino, _end);
29,364!
266

267
    // current group has no more result to return
268
    if (pResBlock->info.rows > 0) {
29,364✔
269
      // 1. The result in current group not reach the threshold of output result, continue
270
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
271
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
23,216✔
272
        pResBlock->info.id.groupId = pInfo->curGroupId;
10,630✔
273
        return pResBlock;
10,630✔
274
      }
275

276
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
12,586✔
277
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
12,586!
278
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
279
        return pResBlock;
×
280
      }
281
    } else if (pInfo->existNewGroupBlock) {  // try next group
6,148✔
282
      blockDataCleanup(pResBlock);
806✔
283

284
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
806✔
285
      if (pResBlock->info.rows > pResultInfo->threshold) {
806!
286
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
287
        return pResBlock;
×
288
      }
289
    } else {
290
      return NULL;
5,342✔
291
    }
292
  }
293

UNCOV
294
_end:
×
UNCOV
295
  if (code != TSDB_CODE_SUCCESS) {
×
UNCOV
296
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
UNCOV
297
    T_LONG_JMP(pTaskInfo->env, code);
×
298
  }
299
  return NULL;
×
300
}
301

302
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
28,666✔
303
  int32_t            code = TSDB_CODE_SUCCESS;
28,666✔
304
  SFillOperatorInfo* pInfo = pOperator->info;
28,666✔
305
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
28,666✔
306

307
  if (pOperator->status == OP_EXEC_DONE) {
28,666!
308
    (*ppRes) = NULL;
×
309
    return code;
×
310
  }
311

312
  SSDataBlock* fillResult = NULL;
28,666✔
313
  while (true) {
314
    fillResult = doFillImpl(pOperator);
28,704✔
315
    if (fillResult == NULL) {
28,705✔
316
      setOperatorCompleted(pOperator);
12,000✔
317
      break;
12,000✔
318
    }
319

320
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo);
16,705✔
321
    if (code != TSDB_CODE_SUCCESS) {
16,705!
322
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
323
      pTaskInfo->code = code;
×
324
      T_LONG_JMP(pTaskInfo->env, code);
×
325
    }
326
    if (fillResult->info.rows > 0) {
16,705✔
327
      break;
16,667✔
328
    }
329
  }
330

331
  if (fillResult != NULL) {
28,667✔
332
    pOperator->resultInfo.totalRows += fillResult->info.rows;
16,667✔
333
  }
334

335
  (*ppRes) = fillResult;
28,667✔
336
  return code;
28,667✔
337
}
338

339
void destroyFillOperatorInfo(void* param) {
12,080✔
340
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
12,080✔
341
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
12,080✔
342
  blockDataDestroy(pInfo->pRes);
12,079✔
343
  pInfo->pRes = NULL;
12,080✔
344
  blockDataDestroy(pInfo->pFinalRes);
12,080✔
345
  pInfo->pFinalRes = NULL;
12,080✔
346

347
  cleanupExprSupp(&pInfo->noFillExprSupp);
12,080✔
348
  cleanupExprSupp(&pInfo->fillNullExprSupp);
12,080✔
349

350
  taosMemoryFreeClear(pInfo->p);
12,080!
351
  taosArrayDestroy(pInfo->matchInfo.pList);
12,080✔
352
  taosMemoryFreeClear(param);
12,080!
353
}
12,080✔
354

355
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr, int32_t numOfCols, SExprInfo* pNotFillExpr,
12,080✔
356
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr, int32_t numOfFillNullExprs,
357
                            SNodeListNode* pValNode, STimeWindow win, int32_t capacity, const char* id,
358
                            SInterval* pInterval, int32_t fillType, int32_t order, SExecTaskInfo* pTaskInfo) {
359
  SFillColInfo* pColInfo =
360
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols, pFillNullExpr, numOfFillNullExprs, pValNode);
12,080✔
361
  if (!pColInfo) {
12,078✔
362
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
1!
363
    return terrno;
1✔
364
  }
365

366
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
12,077✔
367

368
  //  STimeWindow w = {0};
369
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
370
  pInfo->pFillInfo = NULL;
12,077✔
371
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols, numOfFillNullExprs, capacity, pInterval,
12,077✔
372
                                    fillType, pColInfo, pInfo->primaryTsCol, order, id, pTaskInfo, &pInfo->pFillInfo);
12,077✔
373
  if (code != TSDB_CODE_SUCCESS) {
12,079✔
374
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
1!
375
    return code;
×
376
  }
377

378
  if (order == TSDB_ORDER_ASC) {
12,078✔
379
    pInfo->win.skey = win.skey;
10,644✔
380
    pInfo->win.ekey = win.ekey;
10,644✔
381
  } else {
382
    pInfo->win.skey = win.ekey;
1,434✔
383
    pInfo->win.ekey = win.skey;
1,434✔
384
  }
385
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
12,078!
386
  if (!pInfo->p) {
12,080!
387
    return terrno;
×
388
  }
389

390
  if (pInfo->pFillInfo == NULL) {
12,080!
391
    taosMemoryFree(pInfo->pFillInfo);
×
392
    taosMemoryFree(pInfo->p);
×
393
    return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
394
  } else {
395
    return TSDB_CODE_SUCCESS;
12,080✔
396
  }
397
}
398

399
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
12,078✔
400
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
12,078✔
401
    return false;
182✔
402
  }
403

404
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
12,305✔
405
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
12,237✔
406
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
12,237!
407
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
12,244✔
408
      return true;
11,828✔
409
    }
410
  }
411
  return false;
68✔
412
}
413

414
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
12,074✔
415
                                           const char* idStr) {
416
  bool wstartExist = isWstartColumnExist(pInfo);
12,074✔
417

418
  if (wstartExist == false) {
12,080✔
419
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
246!
420
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
421
      return TSDB_CODE_QRY_SYS_ERROR;
×
422
    }
423

424
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
246!
425
    if (pExpr == NULL) {
246!
426
      return terrno;
×
427
    }
428

429
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
246✔
430
    if (code != TSDB_CODE_SUCCESS) {
246!
431
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
432
      pExprSupp->numOfExprs += 1;
×
433
      pExprSupp->pExprInfo = pExpr;
×
434
      return code;
×
435
    }
436

437
    pExprSupp->numOfExprs += 1;
246✔
438
    pExprSupp->pExprInfo = pExpr;
246✔
439
  }
440

441
  return TSDB_CODE_SUCCESS;
12,080✔
442
}
443

444
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
12,070✔
445
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
446
  QRY_PARAM_CHECK(pOptrInfo);
12,070!
447
  int32_t code = 0;
12,070✔
448
  int32_t lino = 0;
12,070✔
449

450
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
12,070!
451
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
12,074!
452
  if (pInfo == NULL || pOperator == NULL) {
12,078!
UNCOV
453
    code = terrno;
×
454
    goto _error;
×
455
  }
456

457
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
12,078✔
458
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
12,079!
459
  SExprInfo* pExprInfo = NULL;
12,079✔
460

461
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
12,079✔
462
  QUERY_CHECK_CODE(code, lino, _error);
12,078!
463

464
  pOperator->exprSupp.pExprInfo = pExprInfo;
12,078✔
465
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
12,078✔
466

467
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
12,078✔
468
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
12,078✔
469
  QUERY_CHECK_CODE(code, lino, _error);
12,080!
470

471
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
12,080✔
472
  QUERY_CHECK_CODE(code, lino, _error);
12,078!
473

474
  code =
475
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
12,078✔
476
  QUERY_CHECK_CODE(code, lino, _error);
12,075!
477

478
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
12,075✔
479
                        &pInfo->fillNullExprSupp.numOfExprs);
480
  QUERY_CHECK_CODE(code, lino, _error);
12,075!
481
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
12,075✔
482
                      &pTaskInfo->storageAPI.functionStore);
483
  QUERY_CHECK_CODE(code, lino, _error);
12,077!
484

485
  SInterval* pInterval =
12,077✔
486
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
12,077✔
487
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
4,217✔
488
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
12,077✔
489

490
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
12,077✔
491
  int32_t type = convertFillType(pPhyFillNode->mode);
12,077✔
492

493
  SResultInfo* pResultInfo = &pOperator->resultInfo;
12,075✔
494

495
  initResultSizeInfo(&pOperator->resultInfo, 4096);
12,075✔
496
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
12,077✔
497
  if (code != TSDB_CODE_SUCCESS) {
12,080!
498
    goto _error;
×
499
  }
500
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
12,080✔
501
  if (code != TSDB_CODE_SUCCESS) {
12,078!
502
    goto _error;
×
503
  }
504

505
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
12,078✔
506
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
12,078✔
507

508
  int32_t numOfOutputCols = 0;
12,078✔
509
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
12,078✔
510
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
511

512
  QUERY_CHECK_CODE(code, lino, _error);
12,080!
513
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
12,080✔
514
                      pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
515
                      (SNodeListNode*)pPhyFillNode->pValues, pPhyFillNode->timeRange, pResultInfo->capacity,
12,080✔
516
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo);
12,080✔
517
  if (code != TSDB_CODE_SUCCESS) {
12,079!
518
    goto _error;
×
519
  }
520

521
  pInfo->pFinalRes = NULL;
12,079✔
522

523
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
12,079✔
524
  if (code) {
12,080!
525
    goto _error;
×
526
  }
527

528
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
12,080✔
529
  if (code != TSDB_CODE_SUCCESS) {
12,079!
530
    goto _error;
×
531
  }
532

533
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0);
12,079✔
534
  if (code != TSDB_CODE_SUCCESS) {
12,079!
535
    goto _error;
×
536
  }
537

538
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
12,079✔
539
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
12,079✔
540
                                         optrDefaultGetNextExtFn, NULL);
541

542
  code = appendDownstream(pOperator, &downstream, 1);
12,077✔
543
  if (code != TSDB_CODE_SUCCESS) {
12,079!
544
    goto _error;
×
545
  }
546

547
  *pOptrInfo = pOperator;
12,079✔
548
  return TSDB_CODE_SUCCESS;
12,079✔
549

550
_error:
×
551
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
552

553
  if (pInfo != NULL) {
×
554
    destroyFillOperatorInfo(pInfo);
×
555
  }
556
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
557
  pTaskInfo->code = code;
×
558
  return code;
×
559
}
560

561
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
10,631✔
562
  int64_t skey, ekey, next;
563
  if (order == TSDB_ORDER_ASC) {
10,631✔
564
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
9,908✔
565
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
9,908✔
566

567
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
9,908✔
568
    next = ekey;
9,909✔
569
    while (next < pInfo->win.ekey) {
62,646✔
570
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
52,738✔
571
                         pInfo->pFillInfo->interval.precision, NULL);
52,738✔
572
      ekey = next > pInfo->win.ekey ? ekey : next;
52,737✔
573
    }
574
    pInfo->win.ekey = ekey;
9,908✔
575
  } else {
576
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
723✔
577
    next = skey;
723✔
578
    while (next < pInfo->win.skey) {
5,582✔
579
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
4,859✔
580
                         pInfo->pFillInfo->interval.precision, NULL);
4,859✔
581
      skey = next > pInfo->win.skey ? skey : next;
4,859✔
582
    }
583
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
723✔
584
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
723✔
585
  }
586
}
10,631✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc