• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3557

16 Dec 2024 01:23AM UTC coverage: 58.204% (+33.4%) from 24.813%
#3557

push

travis-ci

web-flow
Merge pull request #29105 from taosdata/fix/3_liaohj

enh: update the mnode epset in stream hb rsp.

128414 of 285296 branches covered (45.01%)

Branch coverage included in aggregate %.

36 of 64 new or added lines in 5 files covered. (56.25%)

225 existing lines in 34 files now uncovered.

201842 of 282116 relevant lines covered (71.55%)

19596843.67 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.36
/source/dnode/mnode/impl/src/mndMnode.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndMnode.h"
18
#include "audit.h"
19
#include "mndCluster.h"
20
#include "mndDnode.h"
21
#include "mndPrivilege.h"
22
#include "mndShow.h"
23
#include "mndSync.h"
24
#include "mndTrans.h"
25
#include "tmisce.h"
26

27
#define MNODE_VER_NUMBER   2
28
#define MNODE_RESERVE_SIZE 64
29

30
static int32_t  mndCreateDefaultMnode(SMnode *pMnode);
31
static SSdbRaw *mndMnodeActionEncode(SMnodeObj *pObj);
32
static SSdbRow *mndMnodeActionDecode(SSdbRaw *pRaw);
33
static int32_t  mndMnodeActionInsert(SSdb *pSdb, SMnodeObj *pObj);
34
static int32_t  mndMnodeActionDelete(SSdb *pSdb, SMnodeObj *pObj);
35
static int32_t  mndMnodeActionUpdate(SSdb *pSdb, SMnodeObj *pOld, SMnodeObj *pNew);
36
static int32_t  mndProcessCreateMnodeReq(SRpcMsg *pReq);
37
static int32_t  mndProcessAlterMnodeReq(SRpcMsg *pReq);
38
static int32_t  mndProcessDropMnodeReq(SRpcMsg *pReq);
39
static int32_t  mndRetrieveMnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
40
static void     mndCancelGetNextMnode(SMnode *pMnode, void *pIter);
41
static void     mndReloadSyncConfig(SMnode *pMnode);
42

43
int32_t mndInitMnode(SMnode *pMnode) {
1,652✔
44
  SSdbTable table = {
1,652✔
45
      .sdbType = SDB_MNODE,
46
      .keyType = SDB_KEY_INT32,
47
      .deployFp = (SdbDeployFp)mndCreateDefaultMnode,
48
      .encodeFp = (SdbEncodeFp)mndMnodeActionEncode,
49
      .decodeFp = (SdbDecodeFp)mndMnodeActionDecode,
50
      .insertFp = (SdbInsertFp)mndMnodeActionInsert,
51
      .updateFp = (SdbUpdateFp)mndMnodeActionUpdate,
52
      .deleteFp = (SdbDeleteFp)mndMnodeActionDelete,
53
  };
54

55
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_MNODE, mndProcessCreateMnodeReq);
1,652✔
56
  mndSetMsgHandle(pMnode, TDMT_DND_CREATE_MNODE_RSP, mndTransProcessRsp);
1,652✔
57
  mndSetMsgHandle(pMnode, TDMT_DND_ALTER_MNODE_TYPE_RSP, mndTransProcessRsp);
1,652✔
58
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_MNODE, mndProcessAlterMnodeReq);
1,652✔
59
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_MNODE_RSP, mndTransProcessRsp);
1,652✔
60
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_MNODE, mndProcessDropMnodeReq);
1,652✔
61
  mndSetMsgHandle(pMnode, TDMT_DND_DROP_MNODE_RSP, mndTransProcessRsp);
1,652✔
62

63
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_MNODE, mndRetrieveMnodes);
1,652✔
64
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_MNODE, mndCancelGetNextMnode);
1,652✔
65

66
  return sdbSetTable(pMnode->pSdb, table);
1,652✔
67
}
68

69
void mndCleanupMnode(SMnode *pMnode) {}
1,651✔
70

71
SMnodeObj *mndAcquireMnode(SMnode *pMnode, int32_t mnodeId) {
97,142✔
72
  terrno = 0;
97,142✔
73
  SMnodeObj *pObj = sdbAcquire(pMnode->pSdb, SDB_MNODE, &mnodeId);
97,141✔
74
  if (pObj == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
97,142✔
75
    terrno = TSDB_CODE_MND_MNODE_NOT_EXIST;
34,727✔
76
  }
77
  return pObj;
97,142✔
78
}
79

80
void mndReleaseMnode(SMnode *pMnode, SMnodeObj *pObj) {
62,335✔
81
  SSdb *pSdb = pMnode->pSdb;
62,335✔
82
  sdbRelease(pMnode->pSdb, pObj);
62,335✔
83
}
62,335✔
84

85
static int32_t mndCreateDefaultMnode(SMnode *pMnode) {
1,171✔
86
  int32_t   code = 0;
1,171✔
87
  SMnodeObj mnodeObj = {0};
1,171✔
88
  mnodeObj.id = 1;
1,171✔
89
  mnodeObj.createdTime = taosGetTimestampMs();
1,171✔
90
  mnodeObj.updateTime = mnodeObj.createdTime;
1,171✔
91

92
  SSdbRaw *pRaw = mndMnodeActionEncode(&mnodeObj);
1,171✔
93
  if (pRaw == NULL) {
1,171!
94
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
95
    if (terrno != 0) code = terrno;
×
96
    return -1;
×
97
  }
98
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRaw, SDB_STATUS_READY));
1,171!
99

100
  mInfo("mnode:%d, will be created when deploying, raw:%p", mnodeObj.id, pRaw);
1,171!
101

102
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, NULL, "create-mnode");
1,171✔
103
  if (pTrans == NULL) {
1,171!
104
    sdbFreeRaw(pRaw);
×
105
    mError("mnode:%d, failed to create since %s", mnodeObj.id, terrstr());
×
106
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
107
    if (terrno != 0) code = terrno;
×
108
    return -1;
×
109
  }
110
  mInfo("trans:%d, used to create mnode:%d", pTrans->id, mnodeObj.id);
1,171!
111

112
  if ((code = mndTransAppendCommitlog(pTrans, pRaw)) != 0) {
1,171!
113
    mError("trans:%d, failed to append commit log since %s", pTrans->id, terrstr());
×
114
    mndTransDrop(pTrans);
×
115
    TAOS_RETURN(code);
×
116
  }
117
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRaw, SDB_STATUS_READY));
1,171!
118

119
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) {
1,171!
120
    mError("trans:%d, failed to prepare since %s", pTrans->id, terrstr());
×
121
    mndTransDrop(pTrans);
×
122
    return -1;
×
123
  }
124

125
  mndTransDrop(pTrans);
1,171✔
126
  TAOS_RETURN(code);
1,171✔
127
}
128

129
static SSdbRaw *mndMnodeActionEncode(SMnodeObj *pObj) {
4,815✔
130
  int32_t code = 0;
4,815✔
131
  int32_t lino = 0;
4,815✔
132
  terrno = TSDB_CODE_OUT_OF_MEMORY;
4,815✔
133

134
  SSdbRaw *pRaw = sdbAllocRaw(SDB_MNODE, MNODE_VER_NUMBER, sizeof(SMnodeObj) + MNODE_RESERVE_SIZE);
4,815✔
135
  if (pRaw == NULL) goto _OVER;
4,815!
136

137
  int32_t dataPos = 0;
4,815✔
138
  SDB_SET_INT32(pRaw, dataPos, pObj->id, _OVER)
4,815!
139
  SDB_SET_INT64(pRaw, dataPos, pObj->createdTime, _OVER)
4,815!
140
  SDB_SET_INT64(pRaw, dataPos, pObj->updateTime, _OVER)
4,815!
141
  SDB_SET_INT32(pRaw, dataPos, pObj->role, _OVER)
4,815!
142
  SDB_SET_INT64(pRaw, dataPos, pObj->lastIndex, _OVER)
4,815!
143
  SDB_SET_RESERVE(pRaw, dataPos, MNODE_RESERVE_SIZE, _OVER)
4,815!
144

145
  terrno = 0;
4,815✔
146

147
_OVER:
4,815✔
148
  if (terrno != 0) {
4,815!
149
    mError("mnode:%d, failed to encode to raw:%p since %s", pObj->id, pRaw, terrstr());
×
150
    sdbFreeRaw(pRaw);
×
151
    return NULL;
×
152
  }
153

154
  mTrace("mnode:%d, encode to raw:%p, row:%p", pObj->id, pRaw, pObj);
4,815✔
155
  return pRaw;
4,815✔
156
}
157

158
static SSdbRow *mndMnodeActionDecode(SSdbRaw *pRaw) {
2,482✔
159
  int32_t code = 0;
2,482✔
160
  int32_t lino = 0;
2,482✔
161
  terrno = TSDB_CODE_OUT_OF_MEMORY;
2,482✔
162
  SSdbRow   *pRow = NULL;
2,482✔
163
  SMnodeObj *pObj = NULL;
2,482✔
164

165
  int8_t sver = 0;
2,482✔
166
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) return NULL;
2,482!
167

168
  if (sver != 1 && sver != 2) {
2,482!
169
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
170
    goto _OVER;
×
171
  }
172

173
  pRow = sdbAllocRow(sizeof(SMnodeObj));
2,482✔
174
  if (pRow == NULL) goto _OVER;
2,482!
175

176
  pObj = sdbGetRowObj(pRow);
2,482✔
177
  if (pObj == NULL) goto _OVER;
2,482!
178

179
  int32_t dataPos = 0;
2,482✔
180
  SDB_GET_INT32(pRaw, dataPos, &pObj->id, _OVER)
2,482!
181
  SDB_GET_INT64(pRaw, dataPos, &pObj->createdTime, _OVER)
2,482!
182
  SDB_GET_INT64(pRaw, dataPos, &pObj->updateTime, _OVER)
2,482!
183
  if (sver >= 2) {
2,482!
184
    SDB_GET_INT32(pRaw, dataPos, &pObj->role, _OVER)
2,482!
185
    SDB_GET_INT64(pRaw, dataPos, &pObj->lastIndex, _OVER)
2,482!
186
  }
187
  SDB_GET_RESERVE(pRaw, dataPos, MNODE_RESERVE_SIZE, _OVER)
2,482!
188

189
  terrno = 0;
2,482✔
190

191
_OVER:
2,482✔
192
  if (terrno != 0) {
2,482!
193
    mError("mnode:%d, failed to decode from raw:%p since %s", pObj == NULL ? 0 : pObj->id, pRaw, terrstr());
×
194
    taosMemoryFreeClear(pRow);
×
195
    return NULL;
×
196
  }
197

198
  mTrace("mnode:%d, decode from raw:%p, row:%p", pObj->id, pRaw, pObj);
2,482✔
199
  return pRow;
2,482✔
200
}
201

202
static int32_t mndMnodeActionInsert(SSdb *pSdb, SMnodeObj *pObj) {
2,247✔
203
  int32_t code = 0;
2,247✔
204
  mTrace("mnode:%d, perform insert action, row:%p", pObj->id, pObj);
2,247✔
205
  pObj->pDnode = sdbAcquireNotReadyObj(pSdb, SDB_DNODE, &pObj->id);
2,247✔
206
  if (pObj->pDnode == NULL) {
2,247!
207
    mError("mnode:%d, failed to perform insert action since %s", pObj->id, terrstr());
×
208
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
209
    if (terrno != 0) code = terrno;
×
210
    int32_t code = 0;
×
211
  }
212

213
  pObj->syncState = TAOS_SYNC_STATE_OFFLINE;
2,247✔
214
  mndReloadSyncConfig(pSdb->pMnode);
2,247✔
215
  TAOS_RETURN(code);
2,247✔
216
}
217

218
static int32_t mndMnodeActionDelete(SSdb *pSdb, SMnodeObj *pObj) {
2,481✔
219
  mTrace("mnode:%d, perform delete action, row:%p", pObj->id, pObj);
2,481✔
220
  if (pObj->pDnode != NULL) {
2,481✔
221
    sdbRelease(pSdb, pObj->pDnode);
2,246✔
222
    pObj->pDnode = NULL;
2,246✔
223
  }
224

225
  return 0;
2,481✔
226
}
227

228
static int32_t mndMnodeActionUpdate(SSdb *pSdb, SMnodeObj *pOld, SMnodeObj *pNew) {
219✔
229
  mTrace("mnode:%d, perform update action, old row:%p new row:%p", pOld->id, pOld, pNew);
219!
230
  pOld->role = pNew->role;
219✔
231
  pOld->updateTime = pNew->updateTime;
219✔
232
  pOld->lastIndex = pNew->lastIndex;
219✔
233
  mndReloadSyncConfig(pSdb->pMnode);
219✔
234

235
  return 0;
219✔
236
}
237

238
bool mndIsMnode(SMnode *pMnode, int32_t dnodeId) {
261,649✔
239
  SSdb *pSdb = pMnode->pSdb;
261,649✔
240

241
  SMnodeObj *pObj = sdbAcquire(pSdb, SDB_MNODE, &dnodeId);
261,649✔
242
  if (pObj == NULL) {
261,648✔
243
    return false;
183,125✔
244
  }
245

246
  sdbRelease(pSdb, pObj);
78,523✔
247
  return true;
78,523✔
248
}
249

250
void mndGetMnodeEpSet(SMnode *pMnode, SEpSet *pEpSet) {
519,478✔
251
  if (pMnode == NULL || pEpSet == NULL) {
519,478!
NEW
252
    return;
×
253
  }
254

255
  SSdb   *pSdb = pMnode->pSdb;
519,510✔
256
  int32_t totalMnodes = sdbGetSize(pSdb, SDB_MNODE);
519,510✔
257
  if (totalMnodes == 0) {
519,521✔
258
    syncGetRetryEpSet(pMnode->syncMgmt.sync, pEpSet);
24✔
259
    return;
24✔
260
  }
261

262
  void *pIter = NULL;
519,497✔
263
  while (1) {
565,047✔
264
    SMnodeObj *pObj = NULL;
1,084,544✔
265
    pIter = sdbFetch(pSdb, SDB_MNODE, pIter, (void **)&pObj);
1,084,544✔
266
    if (pIter == NULL) break;
1,084,538✔
267

268
    if (pObj->id == pMnode->selfDnodeId) {
565,020✔
269
      if (mndIsLeader(pMnode)) {
519,446✔
270
        pEpSet->inUse = pEpSet->numOfEps;
498,190✔
271
      } else {
272
        pEpSet->inUse = (pEpSet->numOfEps + 1) % totalMnodes;
21,281✔
273
        // pEpSet->inUse = 0;
274
      }
275
    }
276
    if (pObj->pDnode != NULL) {
565,045✔
277
      if (addEpIntoEpSet(pEpSet, pObj->pDnode->fqdn, pObj->pDnode->port) != 0) {
565,037!
UNCOV
278
        mError("mnode:%d, failed to add ep:%s:%d into epset", pObj->id, pObj->pDnode->fqdn, pObj->pDnode->port);
×
279
      }
280
      sdbRelease(pSdb, pObj);
564,978✔
281
    }
282

283
    if (pEpSet->numOfEps == 0) {
565,060!
UNCOV
284
      syncGetRetryEpSet(pMnode->syncMgmt.sync, pEpSet);
×
285
    }
286

287
    if (pEpSet->inUse >= pEpSet->numOfEps) {
565,060✔
288
      pEpSet->inUse = 0;
14,261✔
289
    }
290
    epsetSort(pEpSet);
565,060✔
291
  }
292
}
293

294
static int32_t mndSetCreateMnodeRedoLogs(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj) {
95✔
295
  int32_t  code = 0;
95✔
296
  SSdbRaw *pRedoRaw = mndMnodeActionEncode(pObj);
95✔
297
  if (pRedoRaw == NULL) {
95!
298
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
299
    if (terrno != 0) code = terrno;
×
300
    TAOS_RETURN(code);
×
301
  }
302
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
95!
303
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
95!
304
  TAOS_RETURN(code);
95✔
305
}
306

307
int32_t mndSetRestoreCreateMnodeRedoLogs(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj) {
×
308
  int32_t  code = 0;
×
UNCOV
309
  SSdbRaw *pRedoRaw = mndMnodeActionEncode(pObj);
×
UNCOV
310
  if (pRedoRaw == NULL) {
×
311
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
312
    if (terrno != 0) code = terrno;
×
313
    TAOS_RETURN(code);
×
314
  }
315
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
×
316
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
×
317
  TAOS_RETURN(code);
×
318
}
319

320
static int32_t mndSetCreateMnodeUndoLogs(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj) {
×
321
  int32_t  code = 0;
×
UNCOV
322
  SSdbRaw *pUndoRaw = mndMnodeActionEncode(pObj);
×
UNCOV
323
  if (pUndoRaw == NULL) {
×
324
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
325
    if (terrno != 0) code = terrno;
×
326
    TAOS_RETURN(code);
×
327
  }
328
  TAOS_CHECK_RETURN(mndTransAppendUndolog(pTrans, pUndoRaw));
×
329
  TAOS_CHECK_RETURN(sdbSetRawStatus(pUndoRaw, SDB_STATUS_DROPPED));
×
330
  TAOS_RETURN(code);
×
331
}
332

333
int32_t mndSetCreateMnodeCommitLogs(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj) {
97✔
334
  int32_t  code = 0;
97✔
335
  SSdbRaw *pCommitRaw = mndMnodeActionEncode(pObj);
97✔
336
  if (pCommitRaw == NULL) {
97!
337
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
338
    if (terrno != 0) code = terrno;
×
339
    TAOS_RETURN(code);
×
340
  }
341
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
97!
342
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
97!
343
  TAOS_RETURN(code);
97✔
344
}
345

346
static int32_t mndBuildCreateMnodeRedoAction(STrans *pTrans, SDCreateMnodeReq *pCreateReq, SEpSet *pCreateEpSet) {
97✔
347
  int32_t code = 0;
97✔
348
  int32_t contLen = tSerializeSDCreateMnodeReq(NULL, 0, pCreateReq);
97✔
349
  void   *pReq = taosMemoryMalloc(contLen);
97!
350
  if (pReq == NULL) {
97!
351
    code = terrno;
×
352
    return code;
×
353
  }
354
  code = tSerializeSDCreateMnodeReq(pReq, contLen, pCreateReq);
97✔
355
  if (code < 0) {
97!
356
    taosMemoryFree(pReq);
×
UNCOV
357
    TAOS_RETURN(code);
×
358
  }
359

360
  STransAction action = {
97✔
361
      .epSet = *pCreateEpSet,
362
      .pCont = pReq,
363
      .contLen = contLen,
364
      .msgType = TDMT_DND_CREATE_MNODE,
365
      .acceptableCode = TSDB_CODE_MNODE_ALREADY_DEPLOYED,
366
  };
367

368
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
97!
UNCOV
369
    taosMemoryFree(pReq);
×
UNCOV
370
    TAOS_RETURN(code);
×
371
  }
372
  TAOS_RETURN(code);
97✔
373
}
374

375
static int32_t mndBuildAlterMnodeTypeRedoAction(STrans *pTrans, SDAlterMnodeTypeReq *pAlterMnodeTypeReq,
97✔
376
                                                SEpSet *pAlterMnodeTypeEpSet) {
377
  int32_t code = 0;
97✔
378
  int32_t contLen = tSerializeSDCreateMnodeReq(NULL, 0, pAlterMnodeTypeReq);
97✔
379
  void   *pReq = taosMemoryMalloc(contLen);
97!
380
  if (pReq == NULL) {
97!
381
    code = terrno;
×
382
    return code;
×
383
  }
384
  code = tSerializeSDCreateMnodeReq(pReq, contLen, pAlterMnodeTypeReq);
97✔
385
  if (code < 0) {
97!
386
    taosMemoryFree(pReq);
×
UNCOV
387
    TAOS_RETURN(code);
×
388
  }
389

390
  STransAction action = {
97✔
391
      .epSet = *pAlterMnodeTypeEpSet,
392
      .pCont = pReq,
393
      .contLen = contLen,
394
      .msgType = TDMT_DND_ALTER_MNODE_TYPE,
395
      .retryCode = TSDB_CODE_MNODE_NOT_CATCH_UP,
396
      .acceptableCode = TSDB_CODE_MNODE_ALREADY_IS_VOTER,
397
  };
398

399
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
97!
UNCOV
400
    taosMemoryFree(pReq);
×
UNCOV
401
    TAOS_RETURN(code);
×
402
  }
403
  TAOS_RETURN(code);
97✔
404
}
405

UNCOV
406
static int32_t mndBuildAlterMnodeRedoAction(STrans *pTrans, SDCreateMnodeReq *pAlterReq, SEpSet *pAlterEpSet) {
×
407
  int32_t code = 0;
×
UNCOV
408
  int32_t contLen = tSerializeSDCreateMnodeReq(NULL, 0, pAlterReq);
×
UNCOV
409
  void   *pReq = taosMemoryMalloc(contLen);
×
410
  if (pReq == NULL) {
×
411
    code = terrno;
×
412
    return code;
×
413
  }
414
  code = tSerializeSDCreateMnodeReq(pReq, contLen, pAlterReq);
×
415
  if (code < 0) {
×
416
    taosMemoryFree(pReq);
×
UNCOV
417
    TAOS_RETURN(code);
×
418
  }
419
  STransAction action = {
×
420
      .epSet = *pAlterEpSet,
421
      .pCont = pReq,
422
      .contLen = contLen,
423
      .msgType = TDMT_MND_ALTER_MNODE,
424
      .acceptableCode = 0,
425
  };
426

UNCOV
427
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
UNCOV
428
    taosMemoryFree(pReq);
×
UNCOV
429
    TAOS_RETURN(code);
×
430
  }
431

432
  TAOS_RETURN(code);
×
433
}
434

435
static int32_t mndBuildDropMnodeRedoAction(STrans *pTrans, SDDropMnodeReq *pDropReq, SEpSet *pDroprEpSet) {
6✔
436
  int32_t code = 0;
6✔
437
  int32_t contLen = tSerializeSCreateDropMQSNodeReq(NULL, 0, pDropReq);
6✔
438
  void   *pReq = taosMemoryMalloc(contLen);
6!
439
  if (pReq == NULL) {
6!
440
    code = terrno;
×
441
    return code;
×
442
  }
443
  code = tSerializeSCreateDropMQSNodeReq(pReq, contLen, pDropReq);
6✔
444
  if (code < 0) {
6!
445
    taosMemoryFree(pReq);
×
UNCOV
446
    TAOS_RETURN(code);
×
447
  }
448

449
  STransAction action = {
6✔
450
      .epSet = *pDroprEpSet,
451
      .pCont = pReq,
452
      .contLen = contLen,
453
      .msgType = TDMT_DND_DROP_MNODE,
454
      .acceptableCode = TSDB_CODE_MNODE_NOT_DEPLOYED,
455
  };
456

457
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
6!
UNCOV
458
    taosMemoryFree(pReq);
×
UNCOV
459
    TAOS_RETURN(code);
×
460
  }
461
  TAOS_RETURN(code);
6✔
462
}
463

464
static int32_t mndSetCreateMnodeRedoActions(SMnode *pMnode, STrans *pTrans, SDnodeObj *pDnode, SMnodeObj *pObj) {
95✔
465
  SSdb            *pSdb = pMnode->pSdb;
95✔
466
  void            *pIter = NULL;
95✔
467
  int32_t          numOfReplicas = 0;
95✔
468
  int32_t          numOfLearnerReplicas = 0;
95✔
469
  SDCreateMnodeReq createReq = {0};
95✔
470
  SEpSet           createEpset = {0};
95✔
471

472
  while (1) {
141✔
473
    SMnodeObj *pMObj = NULL;
236✔
474
    pIter = sdbFetch(pSdb, SDB_MNODE, pIter, (void **)&pMObj);
236✔
475
    if (pIter == NULL) break;
236✔
476

477
    if (pMObj->role == TAOS_SYNC_ROLE_VOTER) {
141!
478
      createReq.replicas[numOfReplicas].id = pMObj->id;
141✔
479
      createReq.replicas[numOfReplicas].port = pMObj->pDnode->port;
141✔
480
      memcpy(createReq.replicas[numOfReplicas].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
141✔
481
      numOfReplicas++;
141✔
482
    } else {
483
      createReq.learnerReplicas[numOfLearnerReplicas].id = pMObj->id;
×
484
      createReq.learnerReplicas[numOfLearnerReplicas].port = pMObj->pDnode->port;
×
485
      memcpy(createReq.learnerReplicas[numOfLearnerReplicas].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
×
UNCOV
486
      numOfLearnerReplicas++;
×
487
    }
488

489
    sdbRelease(pSdb, pMObj);
141✔
490
  }
491

492
  createReq.replica = numOfReplicas;
95✔
493
  createReq.learnerReplica = numOfLearnerReplicas + 1;
95✔
494
  createReq.learnerReplicas[numOfLearnerReplicas].id = pDnode->id;
95✔
495
  createReq.learnerReplicas[numOfLearnerReplicas].port = pDnode->port;
95✔
496
  memcpy(createReq.learnerReplicas[numOfLearnerReplicas].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
95✔
497

498
  createReq.lastIndex = pObj->lastIndex;
95✔
499

500
  createEpset.inUse = 0;
95✔
501
  createEpset.numOfEps = 1;
95✔
502
  createEpset.eps[0].port = pDnode->port;
95✔
503
  memcpy(createEpset.eps[0].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
95✔
504

505
  TAOS_CHECK_RETURN(mndBuildCreateMnodeRedoAction(pTrans, &createReq, &createEpset));
95!
506

507
  TAOS_RETURN(0);
95✔
508
}
509

510
int32_t mndSetRestoreCreateMnodeRedoActions(SMnode *pMnode, STrans *pTrans, SDnodeObj *pDnode, SMnodeObj *pObj) {
2✔
511
  SSdb            *pSdb = pMnode->pSdb;
2✔
512
  void            *pIter = NULL;
2✔
513
  SDCreateMnodeReq createReq = {0};
2✔
514
  SEpSet           createEpset = {0};
2✔
515

516
  while (1) {
6✔
517
    SMnodeObj *pMObj = NULL;
8✔
518
    pIter = sdbFetch(pSdb, SDB_MNODE, pIter, (void **)&pMObj);
8✔
519
    if (pIter == NULL) break;
8✔
520

521
    if (pMObj->id == pDnode->id) {
6✔
522
      sdbRelease(pSdb, pMObj);
2✔
523
      continue;
2✔
524
    }
525

526
    if (pMObj->role == TAOS_SYNC_ROLE_VOTER) {
4!
527
      createReq.replicas[createReq.replica].id = pMObj->id;
4✔
528
      createReq.replicas[createReq.replica].port = pMObj->pDnode->port;
4✔
529
      memcpy(createReq.replicas[createReq.replica].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
4✔
530
      createReq.replica++;
4✔
531
    } else {
532
      createReq.learnerReplicas[createReq.learnerReplica].id = pMObj->id;
×
533
      createReq.learnerReplicas[createReq.learnerReplica].port = pMObj->pDnode->port;
×
534
      memcpy(createReq.learnerReplicas[createReq.learnerReplica].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
×
UNCOV
535
      createReq.learnerReplica++;
×
536
    }
537

538
    sdbRelease(pSdb, pMObj);
4✔
539
  }
540

541
  createReq.learnerReplicas[createReq.learnerReplica].id = pDnode->id;
2✔
542
  createReq.learnerReplicas[createReq.learnerReplica].port = pDnode->port;
2✔
543
  memcpy(createReq.learnerReplicas[createReq.learnerReplica].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
2✔
544
  createReq.learnerReplica++;
2✔
545

546
  createReq.lastIndex = pObj->lastIndex;
2✔
547

548
  createEpset.inUse = 0;
2✔
549
  createEpset.numOfEps = 1;
2✔
550
  createEpset.eps[0].port = pDnode->port;
2✔
551
  memcpy(createEpset.eps[0].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
2✔
552

553
  TAOS_CHECK_RETURN(mndBuildCreateMnodeRedoAction(pTrans, &createReq, &createEpset));
2!
554

555
  TAOS_RETURN(0);
2✔
556
}
557

558
static int32_t mndSetAlterMnodeTypeRedoActions(SMnode *pMnode, STrans *pTrans, SDnodeObj *pDnode, SMnodeObj *pObj) {
95✔
559
  SSdb               *pSdb = pMnode->pSdb;
95✔
560
  void               *pIter = NULL;
95✔
561
  SDAlterMnodeTypeReq alterReq = {0};
95✔
562
  SEpSet              createEpset = {0};
95✔
563

564
  while (1) {
141✔
565
    SMnodeObj *pMObj = NULL;
236✔
566
    pIter = sdbFetch(pSdb, SDB_MNODE, pIter, (void **)&pMObj);
236✔
567
    if (pIter == NULL) break;
236✔
568

569
    if (pMObj->role == TAOS_SYNC_ROLE_VOTER) {
141!
570
      alterReq.replicas[alterReq.replica].id = pMObj->id;
141✔
571
      alterReq.replicas[alterReq.replica].port = pMObj->pDnode->port;
141✔
572
      memcpy(alterReq.replicas[alterReq.replica].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
141✔
573
      alterReq.replica++;
141✔
574
    } else {
575
      alterReq.learnerReplicas[alterReq.learnerReplica].id = pMObj->id;
×
576
      alterReq.learnerReplicas[alterReq.learnerReplica].port = pMObj->pDnode->port;
×
577
      memcpy(alterReq.learnerReplicas[alterReq.learnerReplica].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
×
UNCOV
578
      alterReq.learnerReplica++;
×
579
    }
580

581
    sdbRelease(pSdb, pMObj);
141✔
582
  }
583

584
  alterReq.replicas[alterReq.replica].id = pDnode->id;
95✔
585
  alterReq.replicas[alterReq.replica].port = pDnode->port;
95✔
586
  memcpy(alterReq.replicas[alterReq.replica].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
95✔
587
  alterReq.replica++;
95✔
588

589
  alterReq.lastIndex = pObj->lastIndex;
95✔
590

591
  createEpset.inUse = 0;
95✔
592
  createEpset.numOfEps = 1;
95✔
593
  createEpset.eps[0].port = pDnode->port;
95✔
594
  memcpy(createEpset.eps[0].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
95✔
595

596
  TAOS_CHECK_RETURN(mndBuildAlterMnodeTypeRedoAction(pTrans, &alterReq, &createEpset));
95!
597

598
  TAOS_RETURN(0);
95✔
599
}
600

601
int32_t mndSetRestoreAlterMnodeTypeRedoActions(SMnode *pMnode, STrans *pTrans, SDnodeObj *pDnode, SMnodeObj *pObj) {
2✔
602
  SSdb               *pSdb = pMnode->pSdb;
2✔
603
  void               *pIter = NULL;
2✔
604
  SDAlterMnodeTypeReq alterReq = {0};
2✔
605
  SEpSet              createEpset = {0};
2✔
606

607
  while (1) {
6✔
608
    SMnodeObj *pMObj = NULL;
8✔
609
    pIter = sdbFetch(pSdb, SDB_MNODE, pIter, (void **)&pMObj);
8✔
610
    if (pIter == NULL) break;
8✔
611

612
    if (pMObj->id == pDnode->id) {
6✔
613
      sdbRelease(pSdb, pMObj);
2✔
614
      continue;
2✔
615
    }
616

617
    if (pMObj->role == TAOS_SYNC_ROLE_VOTER) {
4!
618
      alterReq.replicas[alterReq.replica].id = pMObj->id;
4✔
619
      alterReq.replicas[alterReq.replica].port = pMObj->pDnode->port;
4✔
620
      memcpy(alterReq.replicas[alterReq.replica].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
4✔
621
      alterReq.replica++;
4✔
622
    } else {
623
      alterReq.learnerReplicas[alterReq.learnerReplica].id = pMObj->id;
×
624
      alterReq.learnerReplicas[alterReq.learnerReplica].port = pMObj->pDnode->port;
×
625
      memcpy(alterReq.learnerReplicas[alterReq.learnerReplica].fqdn, pMObj->pDnode->fqdn, TSDB_FQDN_LEN);
×
UNCOV
626
      alterReq.learnerReplica++;
×
627
    }
628

629
    sdbRelease(pSdb, pMObj);
4✔
630
  }
631

632
  alterReq.replicas[alterReq.replica].id = pDnode->id;
2✔
633
  alterReq.replicas[alterReq.replica].port = pDnode->port;
2✔
634
  memcpy(alterReq.replicas[alterReq.replica].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
2✔
635
  alterReq.replica++;
2✔
636

637
  alterReq.lastIndex = pObj->lastIndex;
2✔
638

639
  createEpset.inUse = 0;
2✔
640
  createEpset.numOfEps = 1;
2✔
641
  createEpset.eps[0].port = pDnode->port;
2✔
642
  memcpy(createEpset.eps[0].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
2✔
643

644
  TAOS_CHECK_RETURN(mndBuildAlterMnodeTypeRedoAction(pTrans, &alterReq, &createEpset));
2!
645

646
  TAOS_RETURN(0);
2✔
647
}
648

649
static int32_t mndCreateMnode(SMnode *pMnode, SRpcMsg *pReq, SDnodeObj *pDnode, SMCreateMnodeReq *pCreate) {
95✔
650
  int32_t code = -1;
95✔
651

652
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pReq, "create-mnode");
95✔
653
  if (pTrans == NULL) {
95!
654
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
655
    if (terrno != 0) code = terrno;
×
656
    goto _OVER;
×
657
  }
658
  mndTransSetSerial(pTrans);
95✔
659
  mInfo("trans:%d, used to create mnode:%d", pTrans->id, pCreate->dnodeId);
95!
660
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
95!
661

662
  SMnodeObj mnodeObj = {0};
95✔
663
  mnodeObj.id = pDnode->id;
95✔
664
  mnodeObj.createdTime = taosGetTimestampMs();
95✔
665
  mnodeObj.updateTime = mnodeObj.createdTime;
95✔
666
  mnodeObj.role = TAOS_SYNC_ROLE_LEARNER;
95✔
667
  mnodeObj.lastIndex = pMnode->applied;
95✔
668

669
  TAOS_CHECK_GOTO(mndSetCreateMnodeRedoActions(pMnode, pTrans, pDnode, &mnodeObj), NULL, _OVER);
95!
670
  TAOS_CHECK_GOTO(mndSetCreateMnodeRedoLogs(pMnode, pTrans, &mnodeObj), NULL, _OVER);
95!
671

672
  SMnodeObj mnodeLeaderObj = {0};
95✔
673
  mnodeLeaderObj.id = pDnode->id;
95✔
674
  mnodeLeaderObj.createdTime = taosGetTimestampMs();
95✔
675
  mnodeLeaderObj.updateTime = mnodeLeaderObj.createdTime;
95✔
676
  mnodeLeaderObj.role = TAOS_SYNC_ROLE_VOTER;
95✔
677
  mnodeLeaderObj.lastIndex = pMnode->applied + 1;
95✔
678

679
  TAOS_CHECK_GOTO(mndSetAlterMnodeTypeRedoActions(pMnode, pTrans, pDnode, &mnodeLeaderObj), NULL, _OVER);
95!
680
  TAOS_CHECK_GOTO(mndSetCreateMnodeCommitLogs(pMnode, pTrans, &mnodeLeaderObj), NULL, _OVER);
95!
681
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
95!
682

683
  code = 0;
95✔
684

685
_OVER:
95✔
686
  mndTransDrop(pTrans);
95✔
687
  TAOS_RETURN(code);
95✔
688
}
689

690
static int32_t mndProcessCreateMnodeReq(SRpcMsg *pReq) {
190✔
691
  SMnode          *pMnode = pReq->info.node;
190✔
692
  int32_t          code = -1;
190✔
693
  SMnodeObj       *pObj = NULL;
190✔
694
  SDnodeObj       *pDnode = NULL;
190✔
695
  SMCreateMnodeReq createReq = {0};
190✔
696

697
  TAOS_CHECK_GOTO(tDeserializeSCreateDropMQSNodeReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
190!
698

699
  mInfo("mnode:%d, start to create", createReq.dnodeId);
190!
700
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_CREATE_MNODE), NULL, _OVER);
190✔
701

702
  pObj = mndAcquireMnode(pMnode, createReq.dnodeId);
189✔
703
  if (pObj != NULL) {
189✔
704
    code = TSDB_CODE_MND_MNODE_ALREADY_EXIST;
40✔
705
    goto _OVER;
40✔
706
  } else if (terrno != TSDB_CODE_MND_MNODE_NOT_EXIST) {
149!
707
    goto _OVER;
×
708
  }
709

710
  pDnode = mndAcquireDnode(pMnode, createReq.dnodeId);
149✔
711
  if (pDnode == NULL) {
149✔
712
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
8✔
713
    goto _OVER;
8✔
714
  }
715

716
  if (sdbGetSize(pMnode->pSdb, SDB_MNODE) >= 3) {
141✔
717
    code = TSDB_CODE_MND_TOO_MANY_MNODES;
2✔
718
    goto _OVER;
2✔
719
  }
720

721
  if (!mndIsDnodeOnline(pDnode, taosGetTimestampMs())) {
139✔
722
    code = TSDB_CODE_DNODE_OFFLINE;
44✔
723
    goto _OVER;
44✔
724
  }
725

726
  code = mndCreateMnode(pMnode, pReq, pDnode, &createReq);
95✔
727
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
95!
728

729
  char    obj[40] = {0};
95✔
730
  int32_t bytes = snprintf(obj, sizeof(obj), "%d", createReq.dnodeId);
95✔
731
  if ((uint32_t)bytes < sizeof(obj)) {
95!
732
    auditRecord(pReq, pMnode->clusterId, "createMnode", "", obj, createReq.sql, createReq.sqlLen);
95✔
733
  } else {
734
    mError("mnode:%d, failed to audit create req since %s", createReq.dnodeId, tstrerror(TSDB_CODE_OUT_OF_RANGE));
×
735
  }
736

UNCOV
737
_OVER:
×
738
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
190!
739
    mError("mnode:%d, failed to create since %s", createReq.dnodeId, terrstr());
95!
740
  }
741

742
  mndReleaseMnode(pMnode, pObj);
190✔
743
  mndReleaseDnode(pMnode, pDnode);
190✔
744
  tFreeSMCreateQnodeReq(&createReq);
190✔
745

746
  TAOS_RETURN(code);
190✔
747
}
748

749
static int32_t mndSetDropMnodeRedoLogs(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj) {
8✔
750
  int32_t  code = 0;
8✔
751
  SSdbRaw *pRedoRaw = mndMnodeActionEncode(pObj);
8✔
752
  if (pRedoRaw == NULL) {
8!
753
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
754
    if (terrno != 0) code = terrno;
×
755
    TAOS_RETURN(code);
×
756
  }
757
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
8!
758
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
8!
759
  TAOS_RETURN(code);
8✔
760
}
761

762
static int32_t mndSetDropMnodeCommitLogs(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj) {
8✔
763
  int32_t  code = 0;
8✔
764
  SSdbRaw *pCommitRaw = mndMnodeActionEncode(pObj);
8✔
765
  if (pCommitRaw == NULL) {
8!
766
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
767
    if (terrno != 0) code = terrno;
×
768
    TAOS_RETURN(code);
×
769
  }
770
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
8!
771
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
8!
772
  TAOS_RETURN(code);
8✔
773
}
774

775
static int32_t mndSetDropMnodeRedoActions(SMnode *pMnode, STrans *pTrans, SDnodeObj *pDnode, SMnodeObj *pObj,
8✔
776
                                          bool force) {
777
  int32_t        code = 0;
8✔
778
  SSdb          *pSdb = pMnode->pSdb;
8✔
779
  void          *pIter = NULL;
8✔
780
  SDDropMnodeReq dropReq = {0};
8✔
781
  SEpSet         dropEpSet = {0};
8✔
782

783
  dropReq.dnodeId = pDnode->id;
8✔
784
  dropEpSet.numOfEps = 1;
8✔
785
  dropEpSet.eps[0].port = pDnode->port;
8✔
786
  memcpy(dropEpSet.eps[0].fqdn, pDnode->fqdn, TSDB_FQDN_LEN);
8✔
787

788
  int32_t totalMnodes = sdbGetSize(pSdb, SDB_MNODE);
8✔
789
  if (totalMnodes == 2) {
8✔
790
    if (force) {
2!
UNCOV
791
      mError("cant't force drop dnode, since a mnode on it and replica is 2");
×
792
      code = TSDB_CODE_MNODE_ONLY_TWO_MNODE;
×
793
      TAOS_RETURN(code);
×
794
    }
795
    mInfo("vgId:1, has %d mnodes, exec redo log first", totalMnodes);
2!
796
    TAOS_CHECK_RETURN(mndSetDropMnodeRedoLogs(pMnode, pTrans, pObj));
2!
797
    if (!force) {
2!
798
      TAOS_CHECK_RETURN(mndBuildDropMnodeRedoAction(pTrans, &dropReq, &dropEpSet));
2!
799
    }
800
  } else if (totalMnodes == 3) {
6!
801
    mInfo("vgId:1, has %d mnodes, exec redo action first", totalMnodes);
6!
802
    if (!force) {
6✔
803
      TAOS_CHECK_RETURN(mndBuildDropMnodeRedoAction(pTrans, &dropReq, &dropEpSet));
4!
804
    }
805
    TAOS_CHECK_RETURN(mndSetDropMnodeRedoLogs(pMnode, pTrans, pObj));
6!
806
  } else {
807
    TAOS_RETURN(-1);
×
808
  }
809

810
  TAOS_RETURN(code);
8✔
811
}
812

813
int32_t mndSetDropMnodeInfoToTrans(SMnode *pMnode, STrans *pTrans, SMnodeObj *pObj, bool force) {
8✔
814
  if (pObj == NULL) return 0;
8!
815
  pObj->lastIndex = pMnode->applied;
8✔
816
  TAOS_CHECK_RETURN(mndSetDropMnodeRedoActions(pMnode, pTrans, pObj->pDnode, pObj, force));
8!
817
  TAOS_CHECK_RETURN(mndSetDropMnodeCommitLogs(pMnode, pTrans, pObj));
8!
818
  return 0;
8✔
819
}
820

821
static int32_t mndDropMnode(SMnode *pMnode, SRpcMsg *pReq, SMnodeObj *pObj) {
4✔
822
  int32_t code = -1;
4✔
823
  STrans *pTrans = NULL;
4✔
824

825
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pReq, "drop-mnode");
4✔
826
  if (pTrans == NULL) {
4!
827
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
828
    if (terrno != 0) code = terrno;
×
829
    goto _OVER;
×
830
  }
831
  mndTransSetSerial(pTrans);
4✔
832
  mInfo("trans:%d, used to drop mnode:%d", pTrans->id, pObj->id);
4!
833
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
4!
834

835
  TAOS_CHECK_GOTO(mndSetDropMnodeInfoToTrans(pMnode, pTrans, pObj, false), NULL, _OVER);
4!
836
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
4!
837

838
  code = 0;
4✔
839

840
_OVER:
4✔
841
  mndTransDrop(pTrans);
4✔
842
  TAOS_RETURN(code);
4✔
843
}
844

845
static int32_t mndProcessDropMnodeReq(SRpcMsg *pReq) {
20✔
846
  SMnode        *pMnode = pReq->info.node;
20✔
847
  int32_t        code = -1;
20✔
848
  SMnodeObj     *pObj = NULL;
20✔
849
  SMDropMnodeReq dropReq = {0};
20✔
850

851
  TAOS_CHECK_GOTO(tDeserializeSCreateDropMQSNodeReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
20!
852

853
  mInfo("mnode:%d, start to drop", dropReq.dnodeId);
20!
854
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_DROP_MNODE), NULL, _OVER);
20✔
855

856
  if (dropReq.dnodeId <= 0) {
19!
857
    code = TSDB_CODE_INVALID_MSG;
×
858
    goto _OVER;
×
859
  }
860

861
  pObj = mndAcquireMnode(pMnode, dropReq.dnodeId);
19✔
862
  if (pObj == NULL) {
19✔
863
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
7✔
864
    if (terrno != 0) code = terrno;
7!
865
    goto _OVER;
7✔
866
  }
867

868
  if (pMnode->selfDnodeId == dropReq.dnodeId) {
12✔
869
    code = TSDB_CODE_MND_CANT_DROP_LEADER;
6✔
870
    goto _OVER;
6✔
871
  }
872

873
  if (sdbGetSize(pMnode->pSdb, SDB_MNODE) <= 1) {
6!
874
    code = TSDB_CODE_MND_TOO_FEW_MNODES;
×
UNCOV
875
    goto _OVER;
×
876
  }
877

878
  if (!mndIsDnodeOnline(pObj->pDnode, taosGetTimestampMs())) {
6✔
879
    code = TSDB_CODE_DNODE_OFFLINE;
2✔
880
    goto _OVER;
2✔
881
  }
882

883
  code = mndDropMnode(pMnode, pReq, pObj);
4✔
884
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
4!
885

886
  char obj[40] = {0};
4✔
887
  sprintf(obj, "%d", dropReq.dnodeId);
4✔
888

889
  auditRecord(pReq, pMnode->clusterId, "dropMnode", "", obj, dropReq.sql, dropReq.sqlLen);
4✔
890

891
_OVER:
20✔
892
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
20!
893
    mError("mnode:%d, failed to drop since %s", dropReq.dnodeId, terrstr());
16!
894
  }
895

896
  mndReleaseMnode(pMnode, pObj);
20✔
897
  tFreeSMCreateQnodeReq(&dropReq);
20✔
898
  TAOS_RETURN(code);
20✔
899
}
900

901
static int32_t mndRetrieveMnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
4,480✔
902
  SMnode    *pMnode = pReq->info.node;
4,480✔
903
  SSdb      *pSdb = pMnode->pSdb;
4,480✔
904
  int32_t    numOfRows = 0;
4,480✔
905
  int32_t    cols = 0;
4,480✔
906
  SMnodeObj *pObj = NULL;
4,480✔
907
  SMnodeObj *pSelfObj = NULL;
4,480✔
908
  ESdbStatus objStatus = 0;
4,480✔
909
  char      *pWrite;
910
  int64_t    curMs = taosGetTimestampMs();
4,484✔
911
  int        code = 0;
4,484✔
912

913
  pSelfObj = sdbAcquire(pSdb, SDB_MNODE, &pMnode->selfDnodeId);
4,484✔
914
  if (pSelfObj == NULL) {
4,484!
915
    mError("mnode:%d, failed to acquire self %s", pMnode->selfDnodeId, terrstr());
×
UNCOV
916
    goto _out;
×
917
  }
918

919
  while (numOfRows < rows) {
9,187✔
920
    pShow->pIter = sdbFetchAll(pSdb, SDB_MNODE, pShow->pIter, (void **)&pObj, &objStatus, true);
9,181✔
921
    if (pShow->pIter == NULL) break;
9,190✔
922

923
    cols = 0;
4,703✔
924
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
4,703✔
925
    code = colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->id, false);
4,702✔
926
    if (code != 0) {
4,695!
927
      mError("mnode:%d, failed to set col data val since %s", pObj->id, tstrerror(code));
×
928
      sdbCancelFetch(pSdb, pShow->pIter);
×
929
      sdbRelease(pSdb, pObj);
×
930
      goto _out;
×
931
    }
932

933
    char b1[TSDB_EP_LEN + VARSTR_HEADER_SIZE] = {0};
4,695✔
934
    STR_WITH_MAXSIZE_TO_VARSTR(b1, pObj->pDnode->ep, TSDB_EP_LEN + VARSTR_HEADER_SIZE);
4,695✔
935

936
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
4,695✔
937
    code = colDataSetVal(pColInfo, numOfRows, b1, false);
4,695✔
938
    if (code != 0) {
4,696!
UNCOV
939
      mError("mnode:%d, failed to set col data val since %s", pObj->id, tstrerror(code));
×
940
      sdbCancelFetch(pSdb, pShow->pIter);
×
941
      sdbRelease(pSdb, pObj);
×
942
      goto _out;
×
943
    }
944

945
    char role[20] = "offline";
4,696✔
946
    if (pObj->id == pMnode->selfDnodeId) {
4,696✔
947
      snprintf(role, sizeof(role), "%s%s", syncStr(TAOS_SYNC_STATE_LEADER), pMnode->restored ? "" : "*");
4,480!
948
    }
949
    bool isDnodeOnline = mndIsDnodeOnline(pObj->pDnode, curMs);
4,694✔
950
    if (isDnodeOnline) {
4,700✔
951
      tstrncpy(role, syncStr(pObj->syncState), sizeof(role));
4,655✔
952
      if (pObj->syncState == TAOS_SYNC_STATE_LEADER && pObj->id != pMnode->selfDnodeId) {
4,656!
953
        tstrncpy(role, syncStr(TAOS_SYNC_STATE_ERROR), sizeof(role));
×
954
        mError("mnode:%d, is leader too", pObj->id);
×
955
      }
956
    }
957
    char b2[12 + VARSTR_HEADER_SIZE] = {0};
4,701✔
958
    STR_WITH_MAXSIZE_TO_VARSTR(b2, role, pShow->pMeta->pSchemas[cols].bytes);
4,701✔
959
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
4,701✔
960
    code = colDataSetVal(pColInfo, numOfRows, (const char *)b2, false);
4,697✔
961
    if (code != 0) goto _err;
4,695!
962

963
    const char *status = "ready";
4,695✔
964
    if (objStatus == SDB_STATUS_CREATING) status = "creating";
4,695!
965
    if (objStatus == SDB_STATUS_DROPPING) status = "dropping";
4,695!
966
    if (!isDnodeOnline) status = "offline";
4,695✔
967
    char b3[9 + VARSTR_HEADER_SIZE] = {0};
4,695✔
968
    STR_WITH_MAXSIZE_TO_VARSTR(b3, status, pShow->pMeta->pSchemas[cols].bytes);
4,695✔
969
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
4,695✔
970
    code = colDataSetVal(pColInfo, numOfRows, (const char *)b3, false);
4,696✔
971
    if (code != 0) goto _err;
4,696!
972

973
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
4,696✔
974
    code = colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->createdTime, false);
4,691✔
975
    if (code != 0) goto _err;
4,684!
976

977
    int64_t roleTimeMs = (isDnodeOnline) ? pObj->roleTimeMs : 0;
4,684✔
978
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
4,684✔
979
    code = colDataSetVal(pColInfo, numOfRows, (const char *)&roleTimeMs, false);
4,682✔
980
    if (code != 0) goto _err;
4,689!
981

982
    numOfRows++;
4,689✔
983
    sdbRelease(pSdb, pObj);
4,689✔
984
  }
985

986
  pShow->numOfRows += numOfRows;
4,493✔
987

988
_out:
4,493✔
989
  sdbRelease(pSdb, pSelfObj);
4,493✔
990
  return numOfRows;
4,487✔
991

992
_err:
×
993
  mError("mnode:%d, failed to set col data val since %s", pObj->id, tstrerror(code));
×
994
  sdbCancelFetch(pSdb, pShow->pIter);
×
UNCOV
995
  sdbRelease(pSdb, pObj);
×
996
  sdbRelease(pSdb, pSelfObj);
×
997
  return numOfRows;
×
998
}
999

1000
static void mndCancelGetNextMnode(SMnode *pMnode, void *pIter) {
×
1001
  SSdb *pSdb = pMnode->pSdb;
×
UNCOV
1002
  sdbCancelFetchByType(pSdb, pIter, SDB_MNODE);
×
UNCOV
1003
}
×
1004

1005
static int32_t mndProcessAlterMnodeReq(SRpcMsg *pReq) {
×
1006
#if 1
1007
  return 0;
×
1008
#else
1009
  int32_t         code = 0;
1010
  SMnode         *pMnode = pReq->info.node;
1011
  SDAlterMnodeReq alterReq = {0};
1012

1013
  TAOS_CHECK_RETURN(tDeserializeSDCreateMnodeReq(pReq->pCont, pReq->contLen, &alterReq));
1014

1015
  SMnodeOpt option = {.deploy = true, .numOfReplicas = alterReq.replica, .selfIndex = -1};
1016
  memcpy(option.replicas, alterReq.replicas, sizeof(alterReq.replicas));
1017
  for (int32_t i = 0; i < option.numOfReplicas; ++i) {
1018
    if (alterReq.replicas[i].id == pMnode->selfDnodeId) {
1019
      option.selfIndex = i;
1020
    }
1021
  }
1022

1023
  if (option.selfIndex == -1) {
1024
    mInfo("alter mnode not processed since selfIndex is -1", terrstr());
1025
    return 0;
1026
  }
1027

1028
  if ((code = mndWriteFile(pMnode->path, &option)) != 0) {
1029
    mError("failed to write mnode file since %s", terrstr());
1030
    TAOS_RETURN(code);
1031
  }
1032

1033
  SSyncCfg cfg = {.replicaNum = alterReq.replica, .myIndex = -1};
1034
  for (int32_t i = 0; i < alterReq.replica; ++i) {
1035
    SNodeInfo *pNode = &cfg.nodeInfo[i];
1036
    tstrncpy(pNode->nodeFqdn, alterReq.replicas[i].fqdn, sizeof(pNode->nodeFqdn));
1037
    pNode->nodePort = alterReq.replicas[i].port;
1038
    if (alterReq.replicas[i].id == pMnode->selfDnodeId) {
1039
      cfg.myIndex = i;
1040
    }
1041
  }
1042

1043
  if (cfg.myIndex == -1) {
1044
    mError("failed to alter mnode since myindex is -1");
1045
    return -1;
1046
  } else {
1047
    mInfo("start to alter mnode sync, replica:%d myIndex:%d", cfg.replicaNum, cfg.myIndex);
1048
    for (int32_t i = 0; i < alterReq.replica; ++i) {
1049
      SNodeInfo *pNode = &cfg.nodeInfo[i];
1050
      mInfo("index:%d, fqdn:%s port:%d", i, pNode->nodeFqdn, pNode->nodePort);
1051
    }
1052
  }
1053

1054
  code = syncReconfig(pMnode->syncMgmt.sync, &cfg);
1055
  if (code != 0) {
1056
    mError("failed to sync reconfig since %s", terrstr());
1057
  } else {
1058
    mInfo("alter mnode sync success");
1059
  }
1060

1061
  TAOS_RETURN(code);
1062
#endif
1063
}
1064

1065
static void mndReloadSyncConfig(SMnode *pMnode) {
2,466✔
1066
  SSdb      *pSdb = pMnode->pSdb;
2,466✔
1067
  SMnodeObj *pObj = NULL;
2,466✔
1068
  ESdbStatus objStatus = 0;
2,466✔
1069
  void      *pIter = NULL;
2,466✔
1070
  int32_t    updatingMnodes = 0;
2,466✔
1071
  int32_t    readyMnodes = 0;
2,466✔
1072
  int32_t    code = 0;
2,466✔
1073
  SSyncCfg   cfg = {
2,466✔
1074
        .myIndex = -1,
1075
        .lastIndex = 0,
1076
  };
1077
  SyncIndex maxIndex = 0;
2,466✔
1078

1079
  while (1) {
1080
    pIter = sdbFetchAll(pSdb, SDB_MNODE, pIter, (void **)&pObj, &objStatus, false);
6,129✔
1081
    if (pIter == NULL) break;
6,129✔
1082
    if (objStatus == SDB_STATUS_CREATING || objStatus == SDB_STATUS_DROPPING) {
3,663✔
1083
      mInfo("vgId:1, has updating mnode:%d, status:%s", pObj->id, sdbStatusName(objStatus));
307!
1084
      updatingMnodes++;
307✔
1085
    }
1086
    if (objStatus == SDB_STATUS_READY) {
3,663✔
1087
      mInfo("vgId:1, has ready mnode:%d, status:%s", pObj->id, sdbStatusName(objStatus));
3,356!
1088
      readyMnodes++;
3,356✔
1089
    }
1090

1091
    if (objStatus == SDB_STATUS_READY || objStatus == SDB_STATUS_CREATING) {
3,663✔
1092
      SNodeInfo *pNode = &cfg.nodeInfo[cfg.totalReplicaNum];
3,644✔
1093
      pNode->nodeId = pObj->pDnode->id;
3,644✔
1094
      pNode->clusterId = mndGetClusterId(pMnode);
3,644✔
1095
      pNode->nodePort = pObj->pDnode->port;
3,644✔
1096
      pNode->nodeRole = pObj->role;
3,644✔
1097
      tstrncpy(pNode->nodeFqdn, pObj->pDnode->fqdn, TSDB_FQDN_LEN);
3,644✔
1098
      code = tmsgUpdateDnodeInfo(&pNode->nodeId, &pNode->clusterId, pNode->nodeFqdn, &pNode->nodePort);
3,644✔
1099
      if (code != 0) {
3,644!
UNCOV
1100
        mError("mnode:%d, failed to update dnode info since %s", pObj->id, terrstr());
×
1101
      }
1102
      mInfo("vgId:1, ep:%s:%u dnode:%d", pNode->nodeFqdn, pNode->nodePort, pNode->nodeId);
3,644!
1103
      if (pObj->pDnode->id == pMnode->selfDnodeId) {
3,644✔
1104
        cfg.myIndex = cfg.totalReplicaNum;
2,048✔
1105
      }
1106
      if (pNode->nodeRole == TAOS_SYNC_ROLE_VOTER) {
3,644✔
1107
        cfg.replicaNum++;
3,356✔
1108
      }
1109
      cfg.totalReplicaNum++;
3,644✔
1110
      if (pObj->lastIndex > cfg.lastIndex) {
3,644✔
1111
        cfg.lastIndex = pObj->lastIndex;
1,151✔
1112
      }
1113
    }
1114

1115
    if (objStatus == SDB_STATUS_DROPPING) {
3,663✔
1116
      if (pObj->lastIndex > cfg.lastIndex) {
19!
1117
        cfg.lastIndex = pObj->lastIndex;
19✔
1118
      }
1119
    }
1120

1121
    mInfo("vgId:1, mnode:%d, role:%d, lastIndex:%" PRId64, pObj->id, pObj->role, pObj->lastIndex);
3,663!
1122

1123
    sdbReleaseLock(pSdb, pObj, false);
3,663✔
1124
  }
1125

1126
  // if (readyMnodes <= 0 || updatingMnodes <= 0) {
1127
  //   mInfo("vgId:1, mnode sync not reconfig since readyMnodes:%d updatingMnodes:%d", readyMnodes, updatingMnodes);
1128
  //   return;
1129
  // }
1130

1131
  if (cfg.myIndex == -1) {
2,466✔
1132
#if 1
1133
    mInfo("vgId:1, mnode sync not reconfig since selfIndex is -1");
418!
1134
#else
1135
    // cannot reconfig because the leader may fail to elect after reboot
1136
    mInfo("vgId:1, mnode sync not reconfig since selfIndex is -1, do sync stop oper");
1137
    syncStop(pMnode->syncMgmt.sync);
1138
#endif
1139
    return;
418✔
1140
  }
1141

1142
  if (pMnode->syncMgmt.sync > 0) {
2,048✔
1143
    mInfo("vgId:1, mnode sync reconfig, totalReplica:%d replica:%d myIndex:%d", cfg.totalReplicaNum, cfg.replicaNum,
1,673!
1144
          cfg.myIndex);
1145

1146
    for (int32_t i = 0; i < cfg.totalReplicaNum; ++i) {
4,128✔
1147
      SNodeInfo *pNode = &cfg.nodeInfo[i];
2,455✔
1148
      mInfo("vgId:1, index:%d, ep:%s:%u dnode:%d cluster:%" PRId64 " role:%d", i, pNode->nodeFqdn, pNode->nodePort,
2,455!
1149
            pNode->nodeId, pNode->clusterId, pNode->nodeRole);
1150
    }
1151

1152
    int32_t code = syncReconfig(pMnode->syncMgmt.sync, &cfg);
1,673✔
1153
    if (code != 0) {
1,673!
UNCOV
1154
      mError("vgId:1, mnode sync reconfig failed since %s", terrstr());
×
1155
    } else {
1156
      mInfo("vgId:1, mnode sync reconfig success");
1,673!
1157
    }
1158
  }
1159
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc