12357371374

Committed 16 Dec 2024 04:51PM UTC coverage: 89.867% (-0.2%) from 90.091%

Build # 12357371374

Build Type

Pull #2194

github

Committed by

jmealy

Commit Message

use random value for target_all in tests, pr comments

Pull Request Pull Request #2194: Allow targeting of all safes for outreach campaigns

Run Details

2811 of 3504 branches covered (80.22%)

Branch coverage included in aggregate %.

10 of 18 new or added lines in 5 files covered. (55.56%)

25 existing lines in 5 files now uncovered.

9605 of 10312 relevant lines covered (93.14%)

434.67 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/domain/targeted-messaging/entities/create-outreach.dto.entity.ts

import { DB_MAX_SAFE_INTEGER } from '@/domain/common/constants';
import { z } from 'zod';

export const CreateOutreachDtoSchema = z.object({
  name: z.string(),
  startDate: z.coerce.date(),
  endDate: z.coerce.date(),
  sourceId: z
    .number()
    .int()
    .gte(1)
    .lte(DB_MAX_SAFE_INTEGER - 1),
  type: z.string(),
  teamName: z.string(),
  sourceFile: z.string().nullish().default(null),
  sourceFileProcessedDate: z.coerce.date().nullish().default(null),
  sourceFileChecksum: z.string().nullish().default(null),
  targetAll: z.boolean(),
});

export class CreateOutreachDto
  implements z.infer<typeof CreateOutreachDtoSchema>
{
  name: string;
  startDate: Date;
  endDate: Date;
  sourceId: number;
  type: string;
  teamName: string;
  sourceFile: string | null;
  sourceFileProcessedDate: Date | null;
  sourceFileChecksum: string | null;
  targetAll: boolean;

  constructor(props: CreateOutreachDto) {
    this.name = props.name;
    this.startDate = props.startDate;
    this.endDate = props.endDate;
    this.sourceId = props.sourceId;
    this.type = props.type;
    this.teamName = props.teamName;
    this.sourceFile = props.sourceFile;
    this.sourceFileProcessedDate = props.sourceFileProcessedDate;
    this.sourceFileChecksum = props.sourceFileChecksum;
    this.targetAll = props.targetAll;
  }
}

1	import { DB_MAX_SAFE_INTEGER } from '@/domain/common/constants';	×
2	import { z } from 'zod';	×
3
4	export const CreateOutreachDtoSchema = z.object({	×
5	name: z.string(),
6	startDate: z.coerce.date(),
7	endDate: z.coerce.date(),
8	sourceId: z
9	.number()
10	.int()
11	.gte(1)
12	.lte(DB_MAX_SAFE_INTEGER - 1),
13	type: z.string(),
14	teamName: z.string(),
15	sourceFile: z.string().nullish().default(null),
16	sourceFileProcessedDate: z.coerce.date().nullish().default(null),
17	sourceFileChecksum: z.string().nullish().default(null),
18	targetAll: z.boolean(),
19	});
20
21	export class CreateOutreachDto	×
22	implements z.infer<typeof CreateOutreachDtoSchema>
23	{
24	name: string;
25	startDate: Date;
26	endDate: Date;
27	sourceId: number;
28	type: string;
29	teamName: string;
30	sourceFile: string \| null;
31	sourceFileProcessedDate: Date \| null;
32	sourceFileChecksum: string \| null;
33	targetAll: boolean;
34
35	constructor(props: CreateOutreachDto) {
36	this.name = props.name;	×
37	this.startDate = props.startDate;	×
38	this.endDate = props.endDate;	×
39	this.sourceId = props.sourceId;	×
40	this.type = props.type;	×
41	this.teamName = props.teamName;	×
42	this.sourceFile = props.sourceFile;	×
43	this.sourceFileProcessedDate = props.sourceFileProcessedDate;	×
44	this.sourceFileChecksum = props.sourceFileChecksum;	×
NEW 45	this.targetAll = props.targetAll;	×
46	}
47	}

safe-global / safe-client-gateway / 12357371374

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous