OpenRefine / OpenRefine / 12323206160

push

github

chore: Deprecate EngineConfig::reconstruct (#7033)

This method returns null when supplied with an invalid argument, which
is bad practice. Instead of swallowing the exception and printing its
stack trace, it should rather let the exception flow to the caller.
Because fixing this behaviour would be a breaking change, I have deprecated
the method and introduced a new one with the better behaviour.
I have also introduced EngineConfig::defaultRowBased, as the reconstruct
was overwhelmingly being used to build a default row-based engine
configuration.

5376 of 12388 branches covered (43.4%)

Branch coverage included in aggregate %.

13454 of 25812 relevant lines covered (52.12%)

2.39 hits per line