• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3546

03 Dec 2024 10:02AM UTC coverage: 60.691% (-0.1%) from 60.839%
#3546

push

travis-ci

web-flow
Merge pull request #29015 from taosdata/fix/TS-5668

[TS-5668] fix(keeper): fix endpoint value too long for column/tag and eliminate warnings

120577 of 253823 branches covered (47.5%)

Branch coverage included in aggregate %.

201666 of 277134 relevant lines covered (72.77%)

18719900.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.66
/source/libs/stream/src/streamUpdate.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tcompare.h"
17
#include "tdatablock.h"
18
#include "tencode.h"
19
#include "tstreamUpdate.h"
20
#include "ttime.h"
21
#include "tutil.h"
22

23
#define DEFAULT_FALSE_POSITIVE   0.01
24
#define DEFAULT_BUCKET_SIZE      131072
25
#define DEFAULT_MAP_CAPACITY     131072
26
#define DEFAULT_MAP_SIZE         (DEFAULT_MAP_CAPACITY * 100)
27
#define ROWS_PER_MILLISECOND     1
28
#define MAX_NUM_SCALABLE_BF      64
29
#define MIN_NUM_SCALABLE_BF      10
30
#define DEFAULT_PREADD_BUCKET    1
31
#define MAX_INTERVAL             MILLISECOND_PER_MINUTE
32
#define MIN_INTERVAL             (MILLISECOND_PER_SECOND * 10)
33
#define DEFAULT_EXPECTED_ENTRIES 10000
34

35
static int64_t adjustExpEntries(int64_t entries) { return TMIN(DEFAULT_EXPECTED_ENTRIES, entries); }
124,006,078✔
36

37
int compareKeyTs(void* pTs1, void* pTs2, void* pPkVal, __compar_fn_t cmpPkFn) {
20,161,341✔
38
  return compareInt64Val(pTs1, pTs2);
20,161,341✔
39
}
40

41
int compareKeyTsAndPk(void* pValue1, void* pTs, void* pPkVal, __compar_fn_t cmpPkFn) {
7,696,600✔
42
  int res = compareInt64Val(pValue1, pTs);
7,696,600✔
43
  if (res != 0) {
7,696,601!
44
    return res;
7,696,610✔
45
  } else {
46
    void* pk1 = (char*)pValue1 + sizeof(TSKEY);
×
47
    return cmpPkFn(pk1, pPkVal);
×
48
  }
49
}
50

51
int32_t getKeyBuff(TSKEY ts, int64_t tbUid, void* pVal, int32_t len, char* buff) {
52,872,220✔
52
  *(TSKEY*)buff = ts;
52,872,220✔
53
  memcpy(buff + sizeof(TSKEY), &tbUid, sizeof(int64_t));
52,872,220✔
54
  if (len == 0) {
52,872,220✔
55
    return sizeof(TSKEY) + sizeof(int64_t);
27,181,781✔
56
  }
57
  memcpy(buff, pVal, len);
25,690,439✔
58
  return sizeof(TSKEY) + sizeof(int64_t) + len;
25,690,439✔
59
}
60

61
int32_t getValueBuff(TSKEY ts, char* pVal, int32_t len, char* buff) {
27,849,672✔
62
  *(TSKEY*)buff = ts;
27,849,672✔
63
  if (len == 0) {
27,849,672✔
64
    return sizeof(TSKEY);
20,169,520✔
65
  }
66
  memcpy(buff + sizeof(TSKEY), pVal, len);
7,680,152✔
67
  return sizeof(TSKEY) + len;
7,680,152✔
68
}
69

70
int32_t windowSBfAdd(SUpdateInfo* pInfo, uint64_t count) {
3,811,600✔
71
  int32_t code = TSDB_CODE_SUCCESS;
3,811,600✔
72
  int32_t lino = 0;
3,811,600✔
73
  if (pInfo->numSBFs < count) {
3,811,600✔
74
    count = pInfo->numSBFs;
3,782,681✔
75
  }
76
  for (uint64_t i = 0; i < count; ++i) {
127,587,994✔
77
    int64_t      rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
123,981,180✔
78
    SScalableBf* tsSBF = NULL;
123,887,647✔
79
    code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &tsSBF);
123,887,647✔
80
    QUERY_CHECK_CODE(code, lino, _error);
124,339,826!
81
    void* res = taosArrayPush(pInfo->pTsSBFs, &tsSBF);
124,339,826✔
82
    if (!res) {
123,776,394!
83
      code = terrno;
×
84
      QUERY_CHECK_CODE(code, lino, _error);
×
85
    }
86
  }
87

88
_error:
3,606,814✔
89
  if (code != TSDB_CODE_SUCCESS) {
3,606,814!
90
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
91
  }
92
  return code;
3,800,739✔
93
}
94

95
static void clearItemHelper(void* p) {
127,935,406✔
96
  SScalableBf** pBf = p;
127,935,406✔
97
  tScalableBfDestroy(*pBf);
127,935,406✔
98
}
128,306,778✔
99

100
void windowSBfDelete(SUpdateInfo* pInfo, uint64_t count) {
3,804,333✔
101
  if (count < pInfo->numSBFs) {
3,804,333✔
102
    for (uint64_t i = 0; i < count; ++i) {
46,395✔
103
      SScalableBf* pTsSBFs = taosArrayGetP(pInfo->pTsSBFs, 0);
25,626✔
104
      tScalableBfDestroy(pTsSBFs);
25,626✔
105
      taosArrayRemove(pInfo->pTsSBFs, 0);
25,626✔
106
    }
107
  } else {
108
    taosArrayClearEx(pInfo->pTsSBFs, clearItemHelper);
3,783,563✔
109
  }
110
  pInfo->minTS += pInfo->interval * count;
3,809,420✔
111
}
3,809,420✔
112

113
static int64_t adjustInterval(int64_t interval, int32_t precision) {
5,665✔
114
  int64_t val = interval;
5,665✔
115
  if (precision != TSDB_TIME_PRECISION_MILLI) {
5,665✔
116
    val = convertTimePrecision(interval, precision, TSDB_TIME_PRECISION_MILLI);
119✔
117
  }
118

119
  if (val <= 0 || val > MAX_INTERVAL) {
5,665✔
120
    val = MAX_INTERVAL;
1,762✔
121
  } else if (val < MIN_INTERVAL) {
3,903✔
122
    val = MIN_INTERVAL;
471✔
123
  }
124

125
  if (precision != TSDB_TIME_PRECISION_MILLI) {
5,665✔
126
    val = convertTimePrecision(val, TSDB_TIME_PRECISION_MILLI, precision);
119✔
127
  }
128
  return val;
5,665✔
129
}
130

131
static int64_t adjustWatermark(int64_t adjInterval, int64_t originInt, int64_t watermark) {
5,665✔
132
  if (watermark <= adjInterval) {
5,665✔
133
    watermark = TMAX(originInt / adjInterval, 1) * adjInterval;
5,431✔
134
  }
135

136
  if (watermark > MAX_NUM_SCALABLE_BF * adjInterval) {
5,665✔
137
    watermark = MAX_NUM_SCALABLE_BF * adjInterval;
235✔
138
  }
139
  return watermark;
5,665✔
140
}
141

142
int32_t updateInfoInitP(SInterval* pInterval, int64_t watermark, bool igUp, int8_t pkType, int32_t pkLen,
3,517✔
143
                        SUpdateInfo** ppInfo) {
144
  return updateInfoInit(pInterval->interval, pInterval->precision, watermark, igUp, pkType, pkLen, ppInfo);
3,517✔
145
}
146

147
int32_t updateInfoInit(int64_t interval, int32_t precision, int64_t watermark, bool igUp, int8_t pkType, int32_t pkLen,
5,665✔
148
                       SUpdateInfo** ppInfo) {
149
  int32_t      code = TSDB_CODE_SUCCESS;
5,665✔
150
  int32_t      lino = 0;
5,665✔
151
  SUpdateInfo* pInfo = taosMemoryCalloc(1, sizeof(SUpdateInfo));
5,665✔
152
  if (pInfo == NULL) {
5,665!
153
    code = terrno;
×
154
    QUERY_CHECK_CODE(code, lino, _end);
×
155
  }
156
  pInfo->pTsBuckets = NULL;
5,665✔
157
  pInfo->pTsSBFs = NULL;
5,665✔
158
  pInfo->minTS = INT64_MIN;
5,665✔
159
  pInfo->interval = adjustInterval(interval, precision);
5,665✔
160
  pInfo->watermark = adjustWatermark(pInfo->interval, interval, watermark);
5,665✔
161
  pInfo->numSBFs = 0;
5,665✔
162

163
  uint64_t bfSize = 0;
5,665✔
164
  if (!igUp) {
5,665✔
165
    bfSize = (uint64_t)(pInfo->watermark / pInfo->interval);
5,220✔
166
    pInfo->numSBFs = bfSize;
5,220✔
167

168
    pInfo->pTsSBFs = taosArrayInit(bfSize, sizeof(void*));
5,220✔
169
    if (pInfo->pTsSBFs == NULL) {
5,220!
170
      updateInfoDestroy(pInfo);
×
171
      code = terrno;
×
172
      QUERY_CHECK_CODE(code, lino, _end);
×
173
    }
174
    code = windowSBfAdd(pInfo, bfSize);
5,220✔
175
    QUERY_CHECK_CODE(code, lino, _end);
5,220!
176

177
    pInfo->pTsBuckets = taosArrayInit(DEFAULT_BUCKET_SIZE, sizeof(TSKEY));
5,220✔
178
    if (pInfo->pTsBuckets == NULL) {
5,220!
179
      updateInfoDestroy(pInfo);
×
180
      code = terrno;
×
181
      QUERY_CHECK_CODE(code, lino, _end);
×
182
    }
183

184
    TSKEY dumy = INT64_MIN;
5,220✔
185
    for (uint64_t i = 0; i < DEFAULT_BUCKET_SIZE; ++i) {
470,958,503✔
186
      void* tmp = taosArrayPush(pInfo->pTsBuckets, &dumy);
470,712,387✔
187
      if (!tmp) {
470,953,283!
188
        code = terrno;
×
189
        QUERY_CHECK_CODE(code, lino, _end);
×
190
      }
191
    }
192
    pInfo->numBuckets = DEFAULT_BUCKET_SIZE;
246,116✔
193
    pInfo->pCloseWinSBF = NULL;
246,116✔
194
  }
195
  _hash_fn_t hashFn = taosGetDefaultHashFunction(TSDB_DATA_TYPE_UBIGINT);
246,561✔
196
  pInfo->pMap = taosHashInit(DEFAULT_MAP_CAPACITY, hashFn, true, HASH_NO_LOCK);
5,665✔
197
  if (!pInfo->pMap) {
5,665!
198
    code = terrno;
×
199
    QUERY_CHECK_CODE(code, lino, _end);
×
200
  }
201
  pInfo->maxDataVersion = 0;
5,665✔
202
  pInfo->pkColLen = pkLen;
5,665✔
203
  pInfo->pkColType = pkType;
5,665✔
204
  pInfo->pKeyBuff = taosMemoryCalloc(1, sizeof(TSKEY) + sizeof(int64_t) + pkLen);
5,665✔
205
  if (!pInfo->pKeyBuff) {
5,665!
206
    code = terrno;
×
207
    QUERY_CHECK_CODE(code, lino, _end);
×
208
  }
209
  pInfo->pValueBuff = taosMemoryCalloc(1, sizeof(TSKEY) + pkLen);
5,665✔
210
  if (!pInfo->pValueBuff) {
5,665!
211
    code = terrno;
×
212
    QUERY_CHECK_CODE(code, lino, _end);
×
213
  }
214
  if (pkLen != 0) {
5,665✔
215
    pInfo->comparePkRowFn = compareKeyTsAndPk;
35✔
216
    pInfo->comparePkCol = getKeyComparFunc(pkType, TSDB_ORDER_ASC);
35✔
217
  } else {
218
    pInfo->comparePkRowFn = compareKeyTs;
5,630✔
219
    pInfo->comparePkCol = NULL;
5,630✔
220
  }
221
  (*ppInfo) = pInfo;
5,665✔
222

223
_end:
5,665✔
224
  if (code != TSDB_CODE_SUCCESS) {
5,665!
225
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
226
  }
227
  return code;
5,665✔
228
}
229

230
static int32_t getSBf(SUpdateInfo* pInfo, TSKEY ts, SScalableBf** ppSBf) {
133,542,047✔
231
  int32_t code = TSDB_CODE_SUCCESS;
133,542,047✔
232
  int32_t lino = 0;
133,542,047✔
233
  if (pInfo->minTS == INT64_MIN) {
133,542,047✔
234
    pInfo->minTS = (TSKEY)(ts / pInfo->interval * pInfo->interval);
1,849✔
235
  }
236
  int64_t index = (int64_t)((ts - pInfo->minTS) / pInfo->interval);
133,542,047✔
237
  if (index < 0) {
133,542,047✔
238
    (*ppSBf) = NULL;
100,082,258✔
239
    goto _end;
100,082,258✔
240
  }
241
  if (index >= pInfo->numSBFs) {
33,459,789✔
242
    uint64_t count = index + 1 - pInfo->numSBFs;
3,804,397✔
243
    windowSBfDelete(pInfo, count);
3,804,397✔
244
    code = windowSBfAdd(pInfo, count);
3,807,807✔
245
    QUERY_CHECK_CODE(code, lino, _end);
3,795,515!
246

247
    index = pInfo->numSBFs - 1;
3,795,515✔
248
  }
249
  SScalableBf* res = taosArrayGetP(pInfo->pTsSBFs, index);
33,450,907✔
250
  if (res == NULL) {
33,726,712✔
251
    int64_t rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
3,406✔
252
    code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &res);
×
253
    QUERY_CHECK_CODE(code, lino, _end);
×
254

255
    void* tmp = taosArrayPush(pInfo->pTsSBFs, &res);
×
256
    if (!tmp) {
×
257
      code = terrno;
×
258
      QUERY_CHECK_CODE(code, lino, _end);
×
259
    }
260
  }
261
  (*ppSBf) = res;
33,723,306✔
262

263
_end:
133,805,564✔
264
  if (code != TSDB_CODE_SUCCESS) {
133,805,564!
265
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
266
  }
267
  return code;
133,532,879✔
268
}
269

270
bool updateInfoIsTableInserted(SUpdateInfo* pInfo, int64_t tbUid) {
103,573✔
271
  void* pVal = taosHashGet(pInfo->pMap, &tbUid, sizeof(int64_t));
103,573✔
272
  if (pVal || taosHashGetSize(pInfo->pMap) >= DEFAULT_MAP_SIZE) return true;
103,593!
273
  return false;
5,454✔
274
}
275

276
int32_t updateInfoFillBlockData(SUpdateInfo* pInfo, SSDataBlock* pBlock, int32_t primaryTsCol, int32_t primaryKeyCol,
59,263✔
277
                                TSKEY* pMaxResTs) {
278
  int32_t code = TSDB_CODE_SUCCESS;
59,263✔
279
  int32_t lino = 0;
59,263✔
280
  if (pBlock == NULL || pBlock->info.rows == 0) {
59,263!
281
    (*pMaxResTs) = INT64_MIN;
×
282
    goto _end;
×
283
  }
284
  TSKEY   maxTs = INT64_MIN;
59,263✔
285
  void*   pPkVal = NULL;
59,263✔
286
  void*   pMaxPkVal = NULL;
59,263✔
287
  int32_t maxLen = 0;
59,263✔
288
  int32_t len = 0;
59,263✔
289
  int64_t tbUid = pBlock->info.id.uid;
59,263✔
290

291
  SColumnInfoData* pColDataInfo = taosArrayGet(pBlock->pDataBlock, primaryTsCol);
59,263✔
292
  SColumnInfoData* pPkDataInfo = NULL;
59,263✔
293
  if (primaryKeyCol >= 0) {
59,263✔
294
    pPkDataInfo = taosArrayGet(pBlock->pDataBlock, primaryKeyCol);
53,491✔
295
  }
296

297
  for (int32_t i = 0; i < pBlock->info.rows; i++) {
106,197,979✔
298
    TSKEY ts = ((TSKEY*)pColDataInfo->pData)[i];
106,140,811✔
299
    if (maxTs < ts) {
106,140,811✔
300
      maxTs = ts;
106,138,861✔
301
      if (primaryKeyCol >= 0) {
106,138,861✔
302
        pMaxPkVal = colDataGetData(pPkDataInfo, i);
90,186,198!
303
        maxLen = colDataGetRowLength(pPkDataInfo, i);
90,186,198✔
304
      }
305
    }
306
    SScalableBf* pSBf = NULL;
106,140,811✔
307
    code = getSBf(pInfo, ts, &pSBf);
106,140,811✔
308
    QUERY_CHECK_CODE(code, lino, _end);
106,110,552!
309

310
    if (pSBf) {
106,110,552✔
311
      if (primaryKeyCol >= 0) {
25,129,649✔
312
        pPkVal = colDataGetData(pPkDataInfo, i);
18,157,356!
313
        len = colDataGetRowLength(pPkDataInfo, i);
18,157,356✔
314
      }
315
      int32_t buffLen = getKeyBuff(ts, tbUid, pPkVal, len, pInfo->pKeyBuff);
25,129,649✔
316
      // we don't care whether the data is updated or not
317
      int32_t winRes = 0;
25,125,330✔
318
      code = tScalableBfPut(pSBf, pInfo->pKeyBuff, buffLen, &winRes);
25,125,330✔
319
      QUERY_CHECK_CODE(code, lino, _end);
25,157,813!
320
    }
321
  }
322
  void* pMaxTs = taosHashGet(pInfo->pMap, &tbUid, sizeof(int64_t));
57,168✔
323
  if (pMaxTs == NULL || pInfo->comparePkRowFn(pMaxTs, &maxTs, pMaxPkVal, pInfo->comparePkCol) == -1) {
59,263!
324
    int32_t valueLen = getValueBuff(maxTs, pMaxPkVal, maxLen, pInfo->pValueBuff);
59,263✔
325
    code = taosHashPut(pInfo->pMap, &tbUid, sizeof(int64_t), pInfo->pValueBuff, valueLen);
59,263✔
326
    QUERY_CHECK_CODE(code, lino, _end);
59,263!
327
  }
328
  (*pMaxResTs) = maxTs;
59,263✔
329

330
_end:
59,263✔
331
  if (code != TSDB_CODE_SUCCESS) {
59,263!
332
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
333
  }
334
  return code;
59,263✔
335
}
336

337
bool updateInfoIsUpdated(SUpdateInfo* pInfo, uint64_t tableId, TSKEY ts, void* pPkVal, int32_t len) {
27,850,408✔
338
  int32_t code = TSDB_CODE_SUCCESS;
27,850,408✔
339
  int32_t lino = 0;
27,850,408✔
340
  int32_t res = TSDB_CODE_FAILED;
27,850,408✔
341
  int32_t buffLen = 0;
27,850,408✔
342

343
  buffLen = getKeyBuff(ts, tableId, pPkVal, len, pInfo->pKeyBuff);
27,850,408✔
344
  void**   pMapMaxTs = taosHashGet(pInfo->pMap, &tableId, sizeof(uint64_t));
27,855,838✔
345
  uint64_t index = ((uint64_t)tableId) % pInfo->numBuckets;
27,838,398✔
346
  TSKEY    maxTs = *(TSKEY*)taosArrayGet(pInfo->pTsBuckets, index);
27,838,398✔
347
  if (maxTs != INT64_MIN && ts < maxTs - pInfo->watermark) {
27,848,073!
348
    // this window has been closed.
349
    if (pInfo->pCloseWinSBF) {
×
350
      code = tScalableBfPut(pInfo->pCloseWinSBF, pInfo->pKeyBuff, buffLen, &res);
×
351
      QUERY_CHECK_CODE(code, lino, _end);
×
352
      if (res == TSDB_CODE_SUCCESS) {
×
353
        return false;
×
354
      } else {
355
        return true;
×
356
      }
357
    }
358
    return true;
×
359
  }
360

361
  SScalableBf* pSBf = NULL;
27,848,073✔
362
  code = getSBf(pInfo, ts, &pSBf);
27,848,073✔
363
  QUERY_CHECK_CODE(code, lino, _end);
27,836,647!
364

365
  int32_t size = taosHashGetSize(pInfo->pMap);
27,836,647✔
366
  if ((!pMapMaxTs && size < DEFAULT_MAP_SIZE) ||
27,817,863!
367
      (pMapMaxTs && pInfo->comparePkRowFn(pMapMaxTs, &ts, pPkVal, pInfo->comparePkCol) == -1)) {
27,824,843✔
368
    int32_t valueLen = getValueBuff(ts, pPkVal, len, pInfo->pValueBuff);
27,801,251✔
369
    code = taosHashPut(pInfo->pMap, &tableId, sizeof(uint64_t), pInfo->pValueBuff, valueLen);
27,813,591✔
370
    QUERY_CHECK_CODE(code, lino, _end);
27,847,702!
371

372
    // pSBf may be a null pointer
373
    if (pSBf) {
27,847,702✔
374
      res = tScalableBfPutNoCheck(pSBf, pInfo->pKeyBuff, buffLen);
8,644,039✔
375
    }
376
    return false;
27,846,551✔
377
  }
378

379
  // pSBf may be a null pointer
380
  if (pSBf) {
7,547✔
381
    code = tScalableBfPut(pSBf, pInfo->pKeyBuff, buffLen, &res);
4,783✔
382
    QUERY_CHECK_CODE(code, lino, _end);
4,785!
383
  }
384

385
  if (!pMapMaxTs && maxTs < ts) {
7,549!
386
    taosArraySet(pInfo->pTsBuckets, index, &ts);
×
387
    return false;
×
388
  }
389

390
  if (ts < pInfo->minTS) {
7,549✔
391
    return true;
3,674✔
392
  } else if (res == TSDB_CODE_SUCCESS) {
3,875✔
393
    return false;
550✔
394
  }
395

396
_end:
3,325✔
397
  if (code != TSDB_CODE_SUCCESS) {
3,325!
398
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
399
  }
400
  // check from tsdb api
401
  return true;
3,325✔
402
}
403

404
void updateInfoDestroy(SUpdateInfo* pInfo) {
10,102✔
405
  if (pInfo == NULL) {
10,102✔
406
    return;
2,782✔
407
  }
408
  taosArrayDestroy(pInfo->pTsBuckets);
7,320✔
409

410
  uint64_t size = taosArrayGetSize(pInfo->pTsSBFs);
7,321✔
411
  for (uint64_t i = 0; i < size; i++) {
88,720✔
412
    SScalableBf* pSBF = taosArrayGetP(pInfo->pTsSBFs, i);
81,399✔
413
    tScalableBfDestroy(pSBF);
81,386✔
414
  }
415

416
  taosArrayDestroy(pInfo->pTsSBFs);
7,321✔
417
  taosMemoryFreeClear(pInfo->pKeyBuff);
7,321!
418
  taosMemoryFreeClear(pInfo->pValueBuff);
7,320!
419
  taosHashCleanup(pInfo->pMap);
7,320✔
420
  updateInfoDestoryColseWinSBF(pInfo);
7,321✔
421
  taosMemoryFree(pInfo);
7,321✔
422
}
423

424
void updateInfoAddCloseWindowSBF(SUpdateInfo* pInfo) {
546✔
425
  if (pInfo->pCloseWinSBF) {
546!
426
    return;
×
427
  }
428
  int64_t rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
546✔
429
  int32_t code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &pInfo->pCloseWinSBF);
546✔
430
  if (code != TSDB_CODE_SUCCESS) {
546!
431
    pInfo->pCloseWinSBF = NULL;
×
432
    uError("%s failed to add close window SBF since %s", __func__, tstrerror(code));
×
433
  }
434
}
435

436
void updateInfoDestoryColseWinSBF(SUpdateInfo* pInfo) {
48,630✔
437
  if (!pInfo || !pInfo->pCloseWinSBF) {
48,630✔
438
    return;
48,084✔
439
  }
440
  tScalableBfDestroy(pInfo->pCloseWinSBF);
546✔
441
  pInfo->pCloseWinSBF = NULL;
546✔
442
}
443

444
int32_t updateInfoSerialize(SEncoder* pEncoder, const SUpdateInfo* pInfo) {
3,649✔
445
  int32_t code = TSDB_CODE_SUCCESS;
3,649✔
446
  int32_t lino = 0;
3,649✔
447
  if (!pInfo) {
3,649✔
448
    if (tEncodeI32(pEncoder, -1) < 0) {
12!
449
      code = TSDB_CODE_FAILED;
×
450
      QUERY_CHECK_CODE(code, lino, _end);
×
451
    }
452
    uDebug("%s line:%d. it did not have updateinfo", __func__, __LINE__);
12!
453
    return TSDB_CODE_SUCCESS;
12✔
454
  }
455

456
  int32_t size = taosArrayGetSize(pInfo->pTsBuckets);
3,637✔
457
  if (tEncodeI32(pEncoder, size) < 0) {
3,637!
458
    code = TSDB_CODE_FAILED;
×
459
    QUERY_CHECK_CODE(code, lino, _end);
×
460
  }
461

462
  for (int32_t i = 0; i < size; i++) {
287,997,392!
463
    TSKEY* pTs = (TSKEY*)taosArrayGet(pInfo->pTsBuckets, i);
288,157,625✔
464
    if (tEncodeI64(pEncoder, *pTs) < 0) {
575,987,510!
465
      code = TSDB_CODE_FAILED;
×
466
      QUERY_CHECK_CODE(code, lino, _end);
×
467
    }
468
  }
469

470
  if (tEncodeU64(pEncoder, pInfo->numBuckets) < 0) {
×
471
    code = TSDB_CODE_FAILED;
×
472
    QUERY_CHECK_CODE(code, lino, _end);
×
473
  }
474

475
  int32_t sBfSize = taosArrayGetSize(pInfo->pTsSBFs);
✔
476
  if (tEncodeI32(pEncoder, sBfSize) < 0) {
3,638!
477
    code = TSDB_CODE_FAILED;
×
478
    QUERY_CHECK_CODE(code, lino, _end);
×
479
  }
480
  for (int32_t i = 0; i < sBfSize; i++) {
54,513✔
481
    SScalableBf* pSBf = taosArrayGetP(pInfo->pTsSBFs, i);
50,875✔
482
    if (tScalableBfEncode(pSBf, pEncoder) < 0) {
50,871!
483
      code = TSDB_CODE_FAILED;
×
484
      QUERY_CHECK_CODE(code, lino, _end);
×
485
    }
486
  }
487

488
  if (tEncodeU64(pEncoder, pInfo->numSBFs) < 0) {
7,276!
489
    code = TSDB_CODE_FAILED;
×
490
    QUERY_CHECK_CODE(code, lino, _end);
×
491
  }
492
  if (tEncodeI64(pEncoder, pInfo->interval) < 0) {
7,276!
493
    code = TSDB_CODE_FAILED;
×
494
    QUERY_CHECK_CODE(code, lino, _end);
×
495
  }
496
  if (tEncodeI64(pEncoder, pInfo->watermark) < 0) {
7,276!
497
    code = TSDB_CODE_FAILED;
×
498
    QUERY_CHECK_CODE(code, lino, _end);
×
499
  }
500
  if (tEncodeI64(pEncoder, pInfo->minTS) < 0) {
7,276!
501
    code = TSDB_CODE_FAILED;
×
502
    QUERY_CHECK_CODE(code, lino, _end);
×
503
  }
504

505
  if (tScalableBfEncode(pInfo->pCloseWinSBF, pEncoder) < 0) {
3,638!
506
    code = TSDB_CODE_FAILED;
×
507
    QUERY_CHECK_CODE(code, lino, _end);
×
508
  }
509

510
  int32_t mapSize = taosHashGetSize(pInfo->pMap);
3,637✔
511
  if (tEncodeI32(pEncoder, mapSize) < 0) {
3,638!
512
    code = TSDB_CODE_FAILED;
×
513
    QUERY_CHECK_CODE(code, lino, _end);
×
514
  }
515
  void*  pIte = NULL;
3,638✔
516
  size_t keyLen = 0;
3,638✔
517
  while ((pIte = taosHashIterate(pInfo->pMap, pIte)) != NULL) {
12,465✔
518
    void* key = taosHashGetKey(pIte, &keyLen);
8,863✔
519
    if (tEncodeU64(pEncoder, *(uint64_t*)key) < 0) {
17,732!
520
      code = TSDB_CODE_FAILED;
×
521
      QUERY_CHECK_CODE(code, lino, _end);
×
522
    }
523
    int32_t valueSize = taosHashGetValueSize(pIte);
8,866✔
524
    if (tEncodeBinary(pEncoder, (const uint8_t*)pIte, valueSize) < 0) {
17,654!
525
      code = TSDB_CODE_FAILED;
×
526
      QUERY_CHECK_CODE(code, lino, _end);
×
527
    }
528
  }
529

530
  if (tEncodeU64(pEncoder, pInfo->maxDataVersion) < 0) {
7,276!
531
    code = TSDB_CODE_FAILED;
×
532
    QUERY_CHECK_CODE(code, lino, _end);
×
533
  }
534

535
  if (tEncodeI32(pEncoder, pInfo->pkColLen) < 0) {
7,276!
536
    code = TSDB_CODE_FAILED;
×
537
    QUERY_CHECK_CODE(code, lino, _end);
×
538
  }
539
  if (tEncodeI8(pEncoder, pInfo->pkColType) < 0) {
7,276!
540
    code = TSDB_CODE_FAILED;
×
541
    QUERY_CHECK_CODE(code, lino, _end);
×
542
  }
543

544
_end:
3,638✔
545
  if (code != TSDB_CODE_SUCCESS) {
3,638!
546
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
547
  }
548
  return code;
3,638✔
549
}
550

551
int32_t updateInfoDeserialize(SDecoder* pDeCoder, SUpdateInfo* pInfo) {
1,781✔
552
  int32_t code = TSDB_CODE_SUCCESS;
1,781✔
553
  int32_t lino = 0;
1,781✔
554
  QUERY_CHECK_NULL(pInfo, code, lino, _error, TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR);
1,781!
555
  
556
  int32_t size = 0;
1,781✔
557
  if (tDecodeI32(pDeCoder, &size) < 0) return -1;
1,781!
558

559
  if (size < 0) {
1,781!
560
    return -1;
×
561
  }
562
  pInfo->pTsBuckets = taosArrayInit(size, sizeof(TSKEY));
1,781✔
563
  QUERY_CHECK_NULL(pInfo->pTsBuckets, code, lino, _error, terrno);
1,781!
564

565
  TSKEY ts = INT64_MIN;
1,781✔
566
  for (int32_t i = 0; i < size; i++) {
179,880,853✔
567
    if (tDecodeI64(pDeCoder, &ts) < 0) return -1;
179,833,960!
568
    void* tmp = taosArrayPush(pInfo->pTsBuckets, &ts);
179,833,960✔
569
    if (!tmp) {
179,879,072!
570
      code = terrno;
×
571
      QUERY_CHECK_CODE(code, lino, _error);
×
572
    }
573
  }
574

575
  if (tDecodeU64(pDeCoder, &pInfo->numBuckets) < 0) return -1;
688,616!
576

577
  int32_t sBfSize = 0;
1,781✔
578
  if (tDecodeI32(pDeCoder, &sBfSize) < 0) return -1;
1,781!
579
  pInfo->pTsSBFs = taosArrayInit(sBfSize, sizeof(void*));
1,781✔
580
  QUERY_CHECK_NULL(pInfo->pTsSBFs, code, lino, _error, terrno);
1,781!
581

582
  for (int32_t i = 0; i < sBfSize; i++) {
27,196✔
583
    SScalableBf* pSBf = NULL;
25,415✔
584
    code = tScalableBfDecode(pDeCoder, &pSBf);
25,415✔
585
    QUERY_CHECK_CODE(code, lino, _error);
25,415!
586

587
    void* tmp = taosArrayPush(pInfo->pTsSBFs, &pSBf);
25,415✔
588
    if (!tmp) {
25,415!
589
      code = terrno;
×
590
      QUERY_CHECK_CODE(code, lino, _error);
×
591
    }
592
  }
593

594
  if (tDecodeU64(pDeCoder, &pInfo->numSBFs) < 0) return -1;
3,562!
595
  if (tDecodeI64(pDeCoder, &pInfo->interval) < 0) return -1;
3,562!
596
  if (tDecodeI64(pDeCoder, &pInfo->watermark) < 0) return -1;
3,562!
597
  if (tDecodeI64(pDeCoder, &pInfo->minTS) < 0) return -1;
3,562!
598

599
  code = tScalableBfDecode(pDeCoder, &pInfo->pCloseWinSBF);
1,781✔
600
  if (code != TSDB_CODE_SUCCESS) {
1,781!
601
    pInfo->pCloseWinSBF = NULL;
×
602
    code = TSDB_CODE_SUCCESS;
×
603
  }
604

605
  int32_t mapSize = 0;
1,781✔
606
  if (tDecodeI32(pDeCoder, &mapSize) < 0) return -1;
1,781!
607
  _hash_fn_t hashFn = taosGetDefaultHashFunction(TSDB_DATA_TYPE_UBIGINT);
1,781✔
608
  pInfo->pMap = taosHashInit(mapSize, hashFn, true, HASH_NO_LOCK);
1,781✔
609
  uint64_t uid = 0;
1,781✔
610
  void*    pVal = NULL;
1,781✔
611
  uint32_t  valSize = 0;
1,781✔
612
  for (int32_t i = 0; i < mapSize; i++) {
4,186✔
613
    if (tDecodeU64(pDeCoder, &uid) < 0) return -1;
2,405!
614
    if (tDecodeBinary(pDeCoder, (uint8_t**)&pVal, &valSize) < 0) return -1;
2,405!
615
    code = taosHashPut(pInfo->pMap, &uid, sizeof(uint64_t), pVal, valSize);
2,405✔
616
    QUERY_CHECK_CODE(code, lino, _error);
2,405!
617
  }
618
  QUERY_CHECK_CONDITION((mapSize == taosHashGetSize(pInfo->pMap)), code, lino, _error,
1,781!
619
                        TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR);
620
  if (tDecodeU64(pDeCoder, &pInfo->maxDataVersion) < 0) return -1;
3,562!
621

622
  if (tDecodeI32(pDeCoder, &pInfo->pkColLen) < 0) return -1;
3,562!
623
  if (tDecodeI8(pDeCoder, &pInfo->pkColType) < 0) return -1;
3,562!
624

625
  pInfo->pKeyBuff = taosMemoryCalloc(1, sizeof(TSKEY) + sizeof(int64_t) + pInfo->pkColLen);
1,781✔
626
  QUERY_CHECK_NULL(pInfo->pKeyBuff, code, lino, _error, terrno);
1,781!
627

628
  pInfo->pValueBuff = taosMemoryCalloc(1, sizeof(TSKEY) + pInfo->pkColLen);
1,781✔
629
  QUERY_CHECK_NULL(pInfo->pValueBuff, code, lino, _error, terrno);
1,781!
630

631
  if (pInfo->pkColLen != 0) {
1,781!
632
    pInfo->comparePkRowFn = compareKeyTsAndPk;
×
633
    pInfo->comparePkCol = getKeyComparFunc(pInfo->pkColType, TSDB_ORDER_ASC);
×
634
  } else {
635
    pInfo->comparePkRowFn = compareKeyTs;
1,781✔
636
    pInfo->comparePkCol = NULL;
1,781✔
637
  }
638

639
_error:
1,781✔
640
  if (code != TSDB_CODE_SUCCESS) {
1,781!
641
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
642
  }
643
  return code;
1,781✔
644
}
645

646
bool isIncrementalTimeStamp(SUpdateInfo* pInfo, uint64_t tableId, TSKEY ts, void* pPkVal, int32_t len) {
7,435✔
647
  int32_t code = TSDB_CODE_SUCCESS;
7,435✔
648
  int32_t lino = 0;
7,435✔
649
  TSKEY*  pMapMaxTs = taosHashGet(pInfo->pMap, &tableId, sizeof(uint64_t));
7,435✔
650
  bool    res = true;
7,436✔
651
  if (pMapMaxTs && pInfo->comparePkRowFn(pMapMaxTs, &ts, pPkVal, pInfo->comparePkCol) == 1) {
7,436✔
652
    res = false;
316✔
653
  } else {
654
    int32_t valueLen = getValueBuff(ts, pPkVal, len, pInfo->pValueBuff);
7,120✔
655
    code = taosHashPut(pInfo->pMap, &tableId, sizeof(uint64_t), pInfo->pValueBuff, valueLen);
7,118✔
656
    QUERY_CHECK_CODE(code, lino, _error);
7,121!
657
  }
658
  return res;
7,437✔
659

660
_error:
×
661
  if (code != TSDB_CODE_SUCCESS) {
×
662
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
663
  }
664
  return false;
×
665
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc